)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"26ccce4d376bb2ca479cfc4319954931cc2e74d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e03905a5_acc91719","updated":"2023-08-10 09:18:00.000000000","message":"LGTM","commit_id":"c49ed6f6c734f5aca3ea1b1f1a32cdc9142181aa"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"22ac705a60f5a51c1373efc748e1eb13ace615ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ea137b0_4e6e81a6","updated":"2023-08-10 09:29:38.000000000","message":"LGTM!\nI would suggest adding a validation for the response.\nSee example here:\nhttps://github.com/openstack/tempest/blob/master/tempest/lib/services/volume/v3/volumes_client.py#L146\n\nIt could be in another patch.","commit_id":"c49ed6f6c734f5aca3ea1b1f1a32cdc9142181aa"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"96e33aa6f87bcad93528aa8d16edd58581686c51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cace623a_653b7ce8","updated":"2023-08-10 08:47:04.000000000","message":"check experimental","commit_id":"c49ed6f6c734f5aca3ea1b1f1a32cdc9142181aa"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"dcb43794848eb00367c6670d3d99e0c6406e3392","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"87236724_ec0281ef","updated":"2023-08-13 06:53:10.000000000","message":"recheck\n\npost failure","commit_id":"c49ed6f6c734f5aca3ea1b1f1a32cdc9142181aa"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"32b22a575a27ac8e6c73a3db751815a22ec01e6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"051310e1_1fb78dda","updated":"2023-08-12 07:42:21.000000000","message":"recheck post failure","commit_id":"c49ed6f6c734f5aca3ea1b1f1a32cdc9142181aa"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"512b1d8e75e2ec0c07c8e61edc25ff955c3b819b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ad92958_a0bce20b","updated":"2023-08-11 14:11:37.000000000","message":"recheck random failure","commit_id":"c49ed6f6c734f5aca3ea1b1f1a32cdc9142181aa"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e2680d023e65a9ab6f9494e34a31bb008f0cf5fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"86344675_dae5a490","updated":"2023-08-13 20:20:40.000000000","message":"recheck unrelated issues","commit_id":"c49ed6f6c734f5aca3ea1b1f1a32cdc9142181aa"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f93ec232e253f1bc060e28d716e8187e660d7d3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d37eff6b_3a58c209","updated":"2023-08-10 08:47:50.000000000","message":"what confuses me a bit is that no other clients have json.loads in their delete apis","commit_id":"c49ed6f6c734f5aca3ea1b1f1a32cdc9142181aa"}],"tempest/lib/services/volume/v3/attachments_client.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"26ccce4d376bb2ca479cfc4319954931cc2e74d1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \"\"\"Delete volume attachment.\"\"\""},{"line_number":32,"context_line":"        url \u003d \"attachments/%s\" % (attachment_id)"},{"line_number":33,"context_line":"        resp, body \u003d self.delete(url)"},{"line_number":34,"context_line":"        body \u003d json.loads(body)"},{"line_number":35,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":36,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f358ff6a_572d8724","line":34,"updated":"2023-08-10 09:18:00.000000000","message":"Looks good to me, because even if it doesn\u0027t say so in [the cinder API](https://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003ddelete-attachment-detail#delete-attachment), the [code explicitly say its returning the attachments](https://github.com/openstack/cinder/blob/ff4b1c910e65274efcbc0fd052f1f9bc5a643603/cinder/api/v3/attachments.py#L277) and [does return them](https://github.com/openstack/cinder/blob/ff4b1c910e65274efcbc0fd052f1f9bc5a643603/cinder/api/v3/attachments.py#L283).","commit_id":"c49ed6f6c734f5aca3ea1b1f1a32cdc9142181aa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2e31572fd0fc3d75323aae71a54e25a58416c0f3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \"\"\"Delete volume attachment.\"\"\""},{"line_number":32,"context_line":"        url \u003d \"attachments/%s\" % (attachment_id)"},{"line_number":33,"context_line":"        resp, body \u003d self.delete(url)"},{"line_number":34,"context_line":"        body \u003d json.loads(body)"},{"line_number":35,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":36,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b93be4af_37878266","line":34,"in_reply_to":"f358ff6a_572d8724","updated":"2023-08-10 23:34:26.000000000","message":"agree, code is what API contract is. usaully Delete rest API not suppose to return response body but that is not always the case.","commit_id":"c49ed6f6c734f5aca3ea1b1f1a32cdc9142181aa"}]}