)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4dcb300a123df6121864769ef2be18ae8f03572f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add option to specify source and destination host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As requested in https://bugs.launchpad.net/tempest/+bug/2028540,"},{"line_number":10,"context_line":"this patch adds options to specify source and destination host in"},{"line_number":11,"context_line":"these tests:"},{"line_number":12,"context_line":"-test_server_connectivity_cold_migration"},{"line_number":13,"context_line":"-test_server_connectivity_cold_migration_revert"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8378631f_c2102e9d","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":62},"updated":"2023-08-14 17:33:47.000000000","message":"let\u0027s update this too as we are only specifying source host in below tests\n..specify source host in..","commit_id":"426897d8ac3438b8cad1ec15fa8ae709bf55c202"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"73194c81ce547397e3d1f959fa38aabb0074e30f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add option to specify source and destination host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As requested in https://bugs.launchpad.net/tempest/+bug/2028540,"},{"line_number":10,"context_line":"this patch adds options to specify source and destination host in"},{"line_number":11,"context_line":"these tests:"},{"line_number":12,"context_line":"-test_server_connectivity_cold_migration"},{"line_number":13,"context_line":"-test_server_connectivity_cold_migration_revert"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"472eec87_4c629a24","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":62},"in_reply_to":"8378631f_c2102e9d","updated":"2023-08-22 10:02:09.000000000","message":"Done","commit_id":"426897d8ac3438b8cad1ec15fa8ae709bf55c202"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e13ec335973f19275b1db3a580424b594ca2d0d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c979df59_89271bdd","updated":"2023-08-10 23:31:03.000000000","message":"I am ok with the idea but a few comments inline","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4dcb300a123df6121864769ef2be18ae8f03572f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dc3249a3_646093c0","updated":"2023-08-14 17:33:47.000000000","message":"thanks for update, please add the release notes also for those new config option","commit_id":"426897d8ac3438b8cad1ec15fa8ae709bf55c202"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"73194c81ce547397e3d1f959fa38aabb0074e30f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"34bb8791_5161f07c","updated":"2023-08-22 10:02:09.000000000","message":"In launchpad - https://bugs.launchpad.net/tempest/+bug/2028540 is specified one more test: test_server_connectivity_resize, in which in my opinion is not possible to use this option, or am I wrong?","commit_id":"3ae82fb1626723663630ead0d62dacc945c19169"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b1eaf672f06b2b2547698b528082459532e4f20f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b4520b27_3a7c59aa","in_reply_to":"34bb8791_5161f07c","updated":"2023-08-24 12:28:44.000000000","message":"right, test_server_connectivity_resize","commit_id":"3ae82fb1626723663630ead0d62dacc945c19169"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"16b550b9ee42d0370087bdb8dec50878f3a24807","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0b1cd498_f5712fda","in_reply_to":"b4520b27_3a7c59aa","updated":"2023-09-15 08:12:39.000000000","message":"Done","commit_id":"3ae82fb1626723663630ead0d62dacc945c19169"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b5146fc5ec6ca5d1bf22a9125342ad395acf5c0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"24581e51_5e12e101","updated":"2023-10-03 10:15:16.000000000","message":"one more thing, the version check","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d1ad88510eb0f0c3a0c7c6f4f8b23042ded79bc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5e05da30_c83eab21","updated":"2023-10-03 09:59:55.000000000","message":"this is going the right way! 2 questions below for open discussion about checking if src/dest host equals to the values user set in tempest.conf","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"49ef119f42e1f13eadc3ca790176f3615e927e02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"12fd3716_d1f55455","updated":"2023-10-25 16:04:30.000000000","message":"I think we should not skip this test for older microversion for host passing things. commented inline, please check","commit_id":"b2e1c07099d5b47317bab03fca637cec9cbb6a07"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b32d743257ff2c1843087c4c4539a923eb6a392c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"db7baf24_a5f1b1fc","updated":"2023-10-24 10:09:10.000000000","message":"a few minor comments","commit_id":"b2e1c07099d5b47317bab03fca637cec9cbb6a07"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08f1ed17d6885346b244b50cd656e26a3e1a293b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a1748c7d_16db1f49","updated":"2023-11-21 19:08:52.000000000","message":"thanks for creating the new tests, some suggestion to reuse the code and microversion conditions.","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f34a6870ada0f1caf2232029649a4e596e61921b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"4f33cc9e_a38c814d","updated":"2023-11-20 14:09:46.000000000","message":"the new tests look good to me, I\u0027m not sure how big deal would be to change the path of a few tests though","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"3b246b05b314bd6dc6ceec79ff81093ee9a79557","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"910f9f98_c063b6b6","updated":"2023-11-27 22:30:12.000000000","message":"recheck timeout","commit_id":"34a505e3619f00e212ee3d1e52802474a1c9c346"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"26377e73c1e14fd170e7630eb920ac2ad1d5db8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"f659758f_fd4ae3c4","updated":"2023-12-04 12:37:29.000000000","message":"lgtm","commit_id":"0fddf67cec3a400bbb50346a4ad65bbbe716830e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"682d32f0a3b22b3022acfee2433ff13f6029ca3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"0b3c32ab_2d9dd226","updated":"2023-12-07 19:20:02.000000000","message":"test are not running bcz of admin condition check","commit_id":"0fddf67cec3a400bbb50346a4ad65bbbe716830e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8693f12f7a3bdb1e657f91bc315796aab1d45504","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"b2482cd3_85808c8c","updated":"2024-01-10 19:38:05.000000000","message":"It is very close, I would like to see the new tests run somewhere (maybe in in tempest-all and tempest-parallel) c and dest host set from devstack side.","commit_id":"11089c2075a4535751ec7d1b6839b12bdf8cb8d4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"29019902d53adf0e0f06335d3a8edbce38851af1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"4a1970e4_8b3fed98","in_reply_to":"0094f495_d230a78b","updated":"2024-01-16 18:53:38.000000000","message":"devstack can get it from nova itself. there is APi to list the available/active host where nova compute services are running and from there we can set it to tempest conf","commit_id":"11089c2075a4535751ec7d1b6839b12bdf8cb8d4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6a13e017b137f6e8af02b2c0b1956aec7349be2a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"0094f495_d230a78b","in_reply_to":"b2482cd3_85808c8c","updated":"2024-01-16 09:52:36.000000000","message":"i\u0027ve been thinking about that, although I\u0027m not exactly sure what\u0027s the best way to figure out the host names. I don\u0027t see a \"place\" where devstack knows names of both (if multinode setup) nodes. Also we probably wanna set this from tempest job definition so that it\u0027s not enabled for all devstack jobs.","commit_id":"11089c2075a4535751ec7d1b6839b12bdf8cb8d4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5b3c8d6530174358342a8fb6caefe80ec1eab3fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"5076fdb2_6e1cc78e","updated":"2024-02-08 05:08:07.000000000","message":"thanks for pushing the devstack change and now test is running and catching failure.","commit_id":"caed73d5e0b9a7ad26c56960a47c376e95b226f5"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"abfb2bc1cceacfb794cfda4752452b03140bfe0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"65974397_30248f7d","updated":"2024-02-08 23:12:34.000000000","message":"recheck","commit_id":"a1685f73e4a434fc4d94fd69afd640b592750e8c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"96f0e8daf8d3fdc4a69daa5918087bb8fbb6d860","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"c80173db_14d0e247","updated":"2024-02-08 23:33:11.000000000","message":"seems like the opts aren\u0027t set in tempest.conf:\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_646/891123/24/check/tempest-multinode-full-py3/646aee2/controller/logs/tempest_conf.txt\n\nmaybe because of the if i commented on the devstack change\n.. btw, you may ignore the zuul config error, it\u0027s not related to this patch","commit_id":"a1685f73e4a434fc4d94fd69afd640b592750e8c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ed352d96a9ebdb654671262ff3d472a99cb525f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"0ec8684f_2d527ab0","updated":"2024-02-13 10:58:02.000000000","message":"I managed to run the tests in the CI in https://review.opendev.org/c/openstack/tempest/+/908866\n\nalthough, it seems we can\u0027t due to \n\"\nDetails: {\u0027code\u0027: 403, \u0027message\u0027: \"Policy doesn\u0027t allow compute:servers:create:requested_destination to be performed.\"}\n\"\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_afb/908866/4/check/tempest-multinode-full-py3/afb874d/testr_results.html","commit_id":"b835e10e780933c63b5456e35a8cabef8eaf14a2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"52600741013e08f337dc84a83053ef1d2ed63606","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"2fb0a237_17206db6","updated":"2024-02-14 17:27:02.000000000","message":"recheck unstable gate","commit_id":"b835e10e780933c63b5456e35a8cabef8eaf14a2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e6e11f633025a831cb6efaa1fbee0552bd63236c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"9c2f8cf5_be671f37","in_reply_to":"0ec8684f_2d527ab0","updated":"2024-02-14 20:04:22.000000000","message":"policy error is valid error. new tests try to create the server with requested_destination with non admin creds where policy require admin. We should use the admin creds in new tests.\n\n- https://github.com/openstack/nova/blob/260dbd976199781f4918228cf9185258c6bfdda0/nova/policies/servers.py#L238\n\n  File \"/opt/stack/tempest/tempest/common/utils/__init__.py\", line 70, in wrapper\n    return f(*func_args, **func_kwargs)\n  File \"/opt/stack/tempest/tempest/scenario/test_network_advanced_server_ops.py\", line 415, in test_server_connectivity_cold_migration\n    self._test_server_connectivity_cold_migration(source_host\u003dsource_host,\n  File \"/opt/stack/tempest/tempest/scenario/test_network_advanced_server_ops.py\", line 137, in _test_server_connectivity_cold_migration\n    server \u003d self._setup_server(keypair, source_host)\n  File \"/opt/stack/tempest/tempest/scenario/test_network_advanced_server_ops.py\", line 71, in _setup_server\n    server \u003d self.create_server(**server_args)\n  File \"/opt/stack/tempest/tempest/scenario/manager.py\", line 349, in create_server\n    body, _ \u003d compute.create_test_server(\n  File \"/opt/stack/tempest/tempest/common/compute.py\", line 287, in create_test_server\n    body \u003d clients.servers_client.create_server(name\u003dname, imageRef\u003dimage_id,\n  File \"/opt/stack/tempest/tempest/lib/services/compute/servers_client.py\", line 115, in create_server\n    resp, body \u003d self.post(\u0027servers\u0027, post_body)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 300, in post\n    return self.request(\u0027POST\u0027, url, extra_headers, headers, body, chunked)\n  File \"/opt/stack/tempest/tempest/lib/services/compute/base_compute_client.py\", line 47, in request\n    resp, resp_body \u003d super(BaseComputeClient, self).request(\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 742, in request\n    self._error_checker(resp, resp_body)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 847, in _error_checker\n    raise exceptions.Forbidden(resp_body, resp\u003dresp)\ntempest.lib.exceptions.Forbidden: Forbidden\nDetails: {\u0027code\u0027: 403, \u0027message\u0027: \"Policy doesn\u0027t allow compute:servers:create:requested_destination to be performed.\"}","commit_id":"b835e10e780933c63b5456e35a8cabef8eaf14a2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a173cdf528d018952b86399d17717807e6caa066","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"11a1c8d3_9d95deff","updated":"2024-02-16 10:10:19.000000000","message":"recheck timeout","commit_id":"307df9c008a3d7666d60dddaee29f871f42252ee"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9a012c9337e17307e1fb1284d9cdde7adaae6231","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"cfdbedd8_88b0778b","updated":"2024-02-28 19:22:17.000000000","message":"lgtm, migration hosts are set\n\n- https://zuul.opendev.org/t/openstack/build/eab824cdc926487aaed69054c0feb5ea/log/controller/logs/tempest_conf.txt#26-27\n\nand all new tests are running fine.\n\nhttps://zuul.opendev.org/t/openstack/build/eab824cdc926487aaed69054c0feb5ea/log/job-output.txt#34656-34668","commit_id":"5a7ed97b7f36c7d966946dabf2383738e7dbad79"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"81ab49664c49bada49d4f4feceafb6b08608b9c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"0bd563b9_d3ac0206","updated":"2024-02-26 17:45:36.000000000","message":"this looks good to me, the tests are passing here:\nhttps://bc091f42a29a7135529f-f6f1806a4829a343b7540be166a34ea9.ssl.cf2.rackcdn.com/908866/12/check/tempest-multinode-full-py3/bf90ac7/testr_results.html\n\neach of the new tests takes around 120 sec \n\nas I coauthored this I can only +2","commit_id":"5a7ed97b7f36c7d966946dabf2383738e7dbad79"}],"releasenotes/notes/add-option-to-specify-source-host.yaml":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b1eaf672f06b2b2547698b528082459532e4f20f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a new config option migration_source_host in the network section,"},{"line_number":4,"context_line":"    which if is set takes source host from option, otherwise it would create."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e4d8f153_247ad335","line":3,"range":{"start_line":3,"start_character":28,"end_line":3,"end_character":49},"updated":"2023-08-24 12:28:44.000000000","message":"and migration_dest_host","commit_id":"3ae82fb1626723663630ead0d62dacc945c19169"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"16b550b9ee42d0370087bdb8dec50878f3a24807","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a new config option migration_source_host in the network section,"},{"line_number":4,"context_line":"    which if is set takes source host from option, otherwise it would create."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9218644e_f1f7e098","line":3,"range":{"start_line":3,"start_character":28,"end_line":3,"end_character":49},"in_reply_to":"e4d8f153_247ad335","updated":"2023-09-15 08:12:39.000000000","message":"Done","commit_id":"3ae82fb1626723663630ead0d62dacc945c19169"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b1eaf672f06b2b2547698b528082459532e4f20f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a new config option migration_source_host in the network section,"},{"line_number":4,"context_line":"    which if is set takes source host from option, otherwise it would create."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f72c2a8d_c842fab4","line":4,"range":{"start_line":4,"start_character":61,"end_line":4,"end_character":76},"updated":"2023-08-24 12:28:44.000000000","message":"otherwise a host is chosen automatically.","commit_id":"3ae82fb1626723663630ead0d62dacc945c19169"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"16b550b9ee42d0370087bdb8dec50878f3a24807","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a new config option migration_source_host in the network section,"},{"line_number":4,"context_line":"    which if is set takes source host from option, otherwise it would create."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ef6cc35c_26a2ecf0","line":4,"range":{"start_line":4,"start_character":61,"end_line":4,"end_character":76},"in_reply_to":"f72c2a8d_c842fab4","updated":"2023-09-15 08:12:39.000000000","message":"Done","commit_id":"3ae82fb1626723663630ead0d62dacc945c19169"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08f1ed17d6885346b244b50cd656e26a3e1a293b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a new config options migration_source_host and migration_dest_host"},{"line_number":4,"context_line":"    in the network section, which if is set takes source or destination"},{"line_number":5,"context_line":"    host from options, otherwise a host is chosen automatically."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"35964a52_466b95cc","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":19},"updated":"2023-11-21 19:08:52.000000000","message":"you mean compute section right?","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"26377e73c1e14fd170e7630eb920ac2ad1d5db8a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a new config options migration_source_host and migration_dest_host"},{"line_number":4,"context_line":"    in the network section, which if is set takes source or destination"},{"line_number":5,"context_line":"    host from options, otherwise a host is chosen automatically."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"0f350c18_30ef638d","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":19},"in_reply_to":"35964a52_466b95cc","updated":"2023-12-04 12:37:29.000000000","message":"++ , good catch!","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"4919e8c04aad004aab8490a4458a06fbb4ed9147","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a new config options migration_source_host and migration_dest_host"},{"line_number":4,"context_line":"    in the network section, which if is set takes source or destination"},{"line_number":5,"context_line":"    host from options, otherwise a host is chosen automatically."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"686c26b5_21b539db","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":19},"in_reply_to":"35964a52_466b95cc","updated":"2023-12-04 12:28:01.000000000","message":"Done","commit_id":"e34805825e99206667340db988750b34cd5fd672"}],"tempest/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e13ec335973f19275b1db3a580424b594ca2d0d0","unresolved":true,"context_lines":[{"line_number":830,"context_line":"                default\u003dFalse,"},{"line_number":831,"context_line":"                help\u003d\"The environment does not support network separation \""},{"line_number":832,"context_line":"                     \"between tenants.\"),"},{"line_number":833,"context_line":"    cfg.StrOpt(\u0027src_host\u0027,"},{"line_number":834,"context_line":"               default\u003d\"\","},{"line_number":835,"context_line":"               help\u003d\"Specify source host for live-migration, cold-migration\""},{"line_number":836,"context_line":"                    \" and resize tests.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"c15d921d_bf333922","line":833,"range":{"start_line":833,"start_character":16,"end_line":833,"end_character":24},"updated":"2023-08-10 23:31:03.000000000","message":"let\u0027s name it more clear \u0027migration_source_host\u0027 and \u0027migration_dest_host\u0027","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"f727c6a3eef3fa72653c71cdd04bf78c88719f32","unresolved":false,"context_lines":[{"line_number":830,"context_line":"                default\u003dFalse,"},{"line_number":831,"context_line":"                help\u003d\"The environment does not support network separation \""},{"line_number":832,"context_line":"                     \"between tenants.\"),"},{"line_number":833,"context_line":"    cfg.StrOpt(\u0027src_host\u0027,"},{"line_number":834,"context_line":"               default\u003d\"\","},{"line_number":835,"context_line":"               help\u003d\"Specify source host for live-migration, cold-migration\""},{"line_number":836,"context_line":"                    \" and resize tests.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"844e2516_e061f713","line":833,"range":{"start_line":833,"start_character":16,"end_line":833,"end_character":24},"in_reply_to":"c15d921d_bf333922","updated":"2023-08-11 10:42:01.000000000","message":"Done","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e13ec335973f19275b1db3a580424b594ca2d0d0","unresolved":true,"context_lines":[{"line_number":831,"context_line":"                help\u003d\"The environment does not support network separation \""},{"line_number":832,"context_line":"                     \"between tenants.\"),"},{"line_number":833,"context_line":"    cfg.StrOpt(\u0027src_host\u0027,"},{"line_number":834,"context_line":"               default\u003d\"\","},{"line_number":835,"context_line":"               help\u003d\"Specify source host for live-migration, cold-migration\""},{"line_number":836,"context_line":"                    \" and resize tests.\"),"},{"line_number":837,"context_line":"    cfg.StrOpt(\u0027dst_host\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d54a5a39_a14170cb","line":834,"range":{"start_line":834,"start_character":23,"end_line":834,"end_character":26},"updated":"2023-08-10 23:31:03.000000000","message":"let\u0027s default them None","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"f727c6a3eef3fa72653c71cdd04bf78c88719f32","unresolved":false,"context_lines":[{"line_number":831,"context_line":"                help\u003d\"The environment does not support network separation \""},{"line_number":832,"context_line":"                     \"between tenants.\"),"},{"line_number":833,"context_line":"    cfg.StrOpt(\u0027src_host\u0027,"},{"line_number":834,"context_line":"               default\u003d\"\","},{"line_number":835,"context_line":"               help\u003d\"Specify source host for live-migration, cold-migration\""},{"line_number":836,"context_line":"                    \" and resize tests.\"),"},{"line_number":837,"context_line":"    cfg.StrOpt(\u0027dst_host\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bcd7a335_d29a319e","line":834,"range":{"start_line":834,"start_character":23,"end_line":834,"end_character":26},"in_reply_to":"d54a5a39_a14170cb","updated":"2023-08-11 10:42:01.000000000","message":"Done","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e13ec335973f19275b1db3a580424b594ca2d0d0","unresolved":true,"context_lines":[{"line_number":833,"context_line":"    cfg.StrOpt(\u0027src_host\u0027,"},{"line_number":834,"context_line":"               default\u003d\"\","},{"line_number":835,"context_line":"               help\u003d\"Specify source host for live-migration, cold-migration\""},{"line_number":836,"context_line":"                    \" and resize tests.\"),"},{"line_number":837,"context_line":"    cfg.StrOpt(\u0027dst_host\u0027,"},{"line_number":838,"context_line":"               default\u003d\"\","},{"line_number":839,"context_line":"               help\u003d\"Specify destination host for live-migration,\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fbda13b_55ff879e","line":836,"range":{"start_line":836,"start_character":38,"end_line":836,"end_character":40},"updated":"2023-08-10 23:31:03.000000000","message":"also expand the help message that if it is not set then migration tests will use the host automatically.","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"f727c6a3eef3fa72653c71cdd04bf78c88719f32","unresolved":false,"context_lines":[{"line_number":833,"context_line":"    cfg.StrOpt(\u0027src_host\u0027,"},{"line_number":834,"context_line":"               default\u003d\"\","},{"line_number":835,"context_line":"               help\u003d\"Specify source host for live-migration, cold-migration\""},{"line_number":836,"context_line":"                    \" and resize tests.\"),"},{"line_number":837,"context_line":"    cfg.StrOpt(\u0027dst_host\u0027,"},{"line_number":838,"context_line":"               default\u003d\"\","},{"line_number":839,"context_line":"               help\u003d\"Specify destination host for live-migration,\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5560e802_bc61bcc4","line":836,"range":{"start_line":836,"start_character":38,"end_line":836,"end_character":40},"in_reply_to":"9fbda13b_55ff879e","updated":"2023-08-11 10:42:01.000000000","message":"Done","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e13ec335973f19275b1db3a580424b594ca2d0d0","unresolved":true,"context_lines":[{"line_number":834,"context_line":"               default\u003d\"\","},{"line_number":835,"context_line":"               help\u003d\"Specify source host for live-migration, cold-migration\""},{"line_number":836,"context_line":"                    \" and resize tests.\"),"},{"line_number":837,"context_line":"    cfg.StrOpt(\u0027dst_host\u0027,"},{"line_number":838,"context_line":"               default\u003d\"\","},{"line_number":839,"context_line":"               help\u003d\"Specify destination host for live-migration,\""},{"line_number":840,"context_line":"                    \" cold-migration and resize tests.\"),"},{"line_number":841,"context_line":"]"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"network_feature_group \u003d cfg.OptGroup(name\u003d\u0027network-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"756404bd_d05f1ea5","line":840,"range":{"start_line":837,"start_character":0,"end_line":840,"end_character":57},"updated":"2023-08-10 23:31:03.000000000","message":"^^ same comments for this too","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"f727c6a3eef3fa72653c71cdd04bf78c88719f32","unresolved":false,"context_lines":[{"line_number":834,"context_line":"               default\u003d\"\","},{"line_number":835,"context_line":"               help\u003d\"Specify source host for live-migration, cold-migration\""},{"line_number":836,"context_line":"                    \" and resize tests.\"),"},{"line_number":837,"context_line":"    cfg.StrOpt(\u0027dst_host\u0027,"},{"line_number":838,"context_line":"               default\u003d\"\","},{"line_number":839,"context_line":"               help\u003d\"Specify destination host for live-migration,\""},{"line_number":840,"context_line":"                    \" cold-migration and resize tests.\"),"},{"line_number":841,"context_line":"]"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"network_feature_group \u003d cfg.OptGroup(name\u003d\u0027network-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d59eabf9_9a580c81","line":840,"range":{"start_line":837,"start_character":0,"end_line":840,"end_character":57},"in_reply_to":"756404bd_d05f1ea5","updated":"2023-08-11 10:42:01.000000000","message":"Done","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":true,"context_lines":[{"line_number":830,"context_line":"                default\u003dFalse,"},{"line_number":831,"context_line":"                help\u003d\"The environment does not support network separation \""},{"line_number":832,"context_line":"                     \"between tenants.\"),"},{"line_number":833,"context_line":"    cfg.StrOpt(\u0027migration_source_host\u0027,"},{"line_number":834,"context_line":"               default\u003dNone,"},{"line_number":835,"context_line":"               help\u003d\"Specify source host for live-migration, cold-migration\""},{"line_number":836,"context_line":"                    \" and resize tests. If option is not set tests will use\""},{"line_number":837,"context_line":"                    \" host automatically.\"),"},{"line_number":838,"context_line":"    cfg.StrOpt(\u0027migration_dest_host\u0027,"},{"line_number":839,"context_line":"               default\u003dNone,"},{"line_number":840,"context_line":"               help\u003d\"Specify destination host for live-migration and cold\""},{"line_number":841,"context_line":"                    \" migration. If option is not set tests will use host\""},{"line_number":842,"context_line":"                    \" automatically.\"),"},{"line_number":843,"context_line":"]"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"network_feature_group \u003d cfg.OptGroup(name\u003d\u0027network-feature-enabled\u0027,"},{"line_number":846,"context_line":"                                     title\u003d\u0027Enabled network service features\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"d38fa8de_e1aa29be","line":843,"range":{"start_line":833,"start_character":2,"end_line":843,"end_character":1},"updated":"2023-10-10 08:27:14.000000000","message":"these aren\u0027t network config options, the values are passed to the compute service, please move them to the compute group","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"3adc36a5c61976e99547125b5e776baabb36e250","unresolved":false,"context_lines":[{"line_number":830,"context_line":"                default\u003dFalse,"},{"line_number":831,"context_line":"                help\u003d\"The environment does not support network separation \""},{"line_number":832,"context_line":"                     \"between tenants.\"),"},{"line_number":833,"context_line":"    cfg.StrOpt(\u0027migration_source_host\u0027,"},{"line_number":834,"context_line":"               default\u003dNone,"},{"line_number":835,"context_line":"               help\u003d\"Specify source host for live-migration, cold-migration\""},{"line_number":836,"context_line":"                    \" and resize tests. If option is not set tests will use\""},{"line_number":837,"context_line":"                    \" host automatically.\"),"},{"line_number":838,"context_line":"    cfg.StrOpt(\u0027migration_dest_host\u0027,"},{"line_number":839,"context_line":"               default\u003dNone,"},{"line_number":840,"context_line":"               help\u003d\"Specify destination host for live-migration and cold\""},{"line_number":841,"context_line":"                    \" migration. If option is not set tests will use host\""},{"line_number":842,"context_line":"                    \" automatically.\"),"},{"line_number":843,"context_line":"]"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"network_feature_group \u003d cfg.OptGroup(name\u003d\u0027network-feature-enabled\u0027,"},{"line_number":846,"context_line":"                                     title\u003d\u0027Enabled network service features\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"373d9179_3b00ac4b","line":843,"range":{"start_line":833,"start_character":2,"end_line":843,"end_character":1},"in_reply_to":"d38fa8de_e1aa29be","updated":"2023-10-18 15:52:39.000000000","message":"Done","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"}],"tempest/scenario/test_network_advanced_server_ops.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e13ec335973f19275b1db3a580424b594ca2d0d0","unresolved":true,"context_lines":[{"line_number":234,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":235,"context_line":"        server \u003d self._setup_server(keypair)"},{"line_number":236,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":237,"context_line":"        src_host \u003d self._check_if_host_is_specified(server[\u0027id\u0027], \u0027src\u0027)"},{"line_number":238,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":239,"context_line":"            server, keypair, floating_ip)"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7317a4c1_c08b450a","line":237,"range":{"start_line":237,"start_character":8,"end_line":237,"end_character":72},"updated":"2023-08-10 23:31:03.000000000","message":"we can just do something like below\n\nsrc_host \u003d CONF.network.src_host or self.get_host_for_server(server[\u0027id\u0027])","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"f727c6a3eef3fa72653c71cdd04bf78c88719f32","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":235,"context_line":"        server \u003d self._setup_server(keypair)"},{"line_number":236,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":237,"context_line":"        src_host \u003d self._check_if_host_is_specified(server[\u0027id\u0027], \u0027src\u0027)"},{"line_number":238,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":239,"context_line":"            server, keypair, floating_ip)"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"31bd8647_75c8ba69","line":237,"range":{"start_line":237,"start_character":8,"end_line":237,"end_character":72},"in_reply_to":"7317a4c1_c08b450a","updated":"2023-08-11 10:42:01.000000000","message":"Done","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e13ec335973f19275b1db3a580424b594ca2d0d0","unresolved":true,"context_lines":[{"line_number":244,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":245,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":246,"context_line":"            server, keypair, floating_ip)"},{"line_number":247,"context_line":"        dst_host \u003d self._check_if_host_is_specified(server[\u0027id\u0027], \u0027dst\u0027)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        self.assertNotEqual(src_host, dst_host)"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a27c0d51_a2bf1df4","line":247,"range":{"start_line":247,"start_character":8,"end_line":247,"end_character":72},"updated":"2023-08-10 23:31:03.000000000","message":"we do not specify the host to force the migration to in migration request to Nova so we cannot compare the configured dest host here. dest host will be the one where nova migrated the server so L237 is correct here.","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":245,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":246,"context_line":"            server, keypair, floating_ip)"},{"line_number":247,"context_line":"        dst_host \u003d self._check_if_host_is_specified(server[\u0027id\u0027], \u0027dst\u0027)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        self.assertNotEqual(src_host, dst_host)"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8f3ebb74_be4faa9b","line":247,"range":{"start_line":247,"start_character":8,"end_line":247,"end_character":72},"in_reply_to":"5520df24_f4f8657d","updated":"2023-10-10 08:27:14.000000000","message":"Done","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"f727c6a3eef3fa72653c71cdd04bf78c88719f32","unresolved":true,"context_lines":[{"line_number":244,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":245,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":246,"context_line":"            server, keypair, floating_ip)"},{"line_number":247,"context_line":"        dst_host \u003d self._check_if_host_is_specified(server[\u0027id\u0027], \u0027dst\u0027)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        self.assertNotEqual(src_host, dst_host)"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c571ee07_9e6ed6f2","line":247,"range":{"start_line":247,"start_character":8,"end_line":247,"end_character":72},"in_reply_to":"a27c0d51_a2bf1df4","updated":"2023-08-11 10:42:01.000000000","message":"I don\u0027t know if I understood you correctly, but I made some changes.","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7ecdfbd9fb8d148c8f81ebe220b4ed7e3cc1d502","unresolved":true,"context_lines":[{"line_number":244,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":245,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":246,"context_line":"            server, keypair, floating_ip)"},{"line_number":247,"context_line":"        dst_host \u003d self._check_if_host_is_specified(server[\u0027id\u0027], \u0027dst\u0027)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        self.assertNotEqual(src_host, dst_host)"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5520df24_f4f8657d","line":247,"range":{"start_line":247,"start_character":8,"end_line":247,"end_character":72},"in_reply_to":"c571ee07_9e6ed6f2","updated":"2023-08-24 12:35:14.000000000","message":"oh, right, so it\u0027s not possible to force the migration to specific host at all or just now due to the current code in tempest?","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e13ec335973f19275b1db3a580424b594ca2d0d0","unresolved":true,"context_lines":[{"line_number":277,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":278,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        dst_host \u003d self._check_if_host_is_specified(server[\u0027id\u0027], \u0027dst\u0027)"},{"line_number":281,"context_line":"        self.assertNotEqual(src_host, dst_host, \u0027Server did not migrate\u0027)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        # we first wait until the VM replies pings again, then check the"},{"line_number":284,"context_line":"        # network downtime"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f987a02_adc5ca8b","line":281,"range":{"start_line":280,"start_character":0,"end_line":281,"end_character":73},"updated":"2023-08-10 23:31:03.000000000","message":"ditto","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":278,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        dst_host \u003d self._check_if_host_is_specified(server[\u0027id\u0027], \u0027dst\u0027)"},{"line_number":281,"context_line":"        self.assertNotEqual(src_host, dst_host, \u0027Server did not migrate\u0027)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        # we first wait until the VM replies pings again, then check the"},{"line_number":284,"context_line":"        # network downtime"}],"source_content_type":"text/x-python","patch_set":2,"id":"a40645cf_75c601bb","line":281,"range":{"start_line":280,"start_character":0,"end_line":281,"end_character":73},"in_reply_to":"1f987a02_adc5ca8b","updated":"2023-10-10 08:27:14.000000000","message":"Done","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e13ec335973f19275b1db3a580424b594ca2d0d0","unresolved":true,"context_lines":[{"line_number":317,"context_line":"        self.servers_client.revert_resize_server(server[\u0027id\u0027])"},{"line_number":318,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":319,"context_line":"            server, keypair, floating_ip)"},{"line_number":320,"context_line":"        dst_host \u003d self._check_if_host_is_specified(server[\u0027id\u0027], \u0027dst\u0027)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        self.assertEqual(src_host, dst_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ebe0181c_627d3e3f","line":320,"range":{"start_line":320,"start_character":0,"end_line":320,"end_character":72},"updated":"2023-08-10 23:31:03.000000000","message":"ditto","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        self.servers_client.revert_resize_server(server[\u0027id\u0027])"},{"line_number":318,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":319,"context_line":"            server, keypair, floating_ip)"},{"line_number":320,"context_line":"        dst_host \u003d self._check_if_host_is_specified(server[\u0027id\u0027], \u0027dst\u0027)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        self.assertEqual(src_host, dst_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ceb2ada7_37e8aa0c","line":320,"range":{"start_line":320,"start_character":0,"end_line":320,"end_character":72},"in_reply_to":"ebe0181c_627d3e3f","updated":"2023-10-10 08:27:14.000000000","message":"Ack","commit_id":"4514eea19ff7923e232501f464e869c4945834b3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b1eaf672f06b2b2547698b528082459532e4f20f","unresolved":true,"context_lines":[{"line_number":235,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":236,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":237,"context_line":"            server, keypair, floating_ip)"},{"line_number":238,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        self.assertNotEqual(src_host, dst_host)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"6fa1b343_fa6680e6","line":238,"range":{"start_line":238,"start_character":19,"end_line":238,"end_character":23},"updated":"2023-08-24 12:28:44.000000000","message":"shouldn\u0027t we have here similar logic than on line 227?\ndst_host \u003d CONF.network.migration_dest_host or self.get_host_for_server(server[\u0027id\u0027]\n\notherwise the migration_dest_host option is not used","commit_id":"3ae82fb1626723663630ead0d62dacc945c19169"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d4d73a8bc89bdbc6561f25a93d99a0a9af27e1ac","unresolved":true,"context_lines":[{"line_number":235,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":236,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":237,"context_line":"            server, keypair, floating_ip)"},{"line_number":238,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        self.assertNotEqual(src_host, dst_host)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"57a727de_732c3084","line":238,"range":{"start_line":238,"start_character":19,"end_line":238,"end_character":23},"in_reply_to":"4f93486c_90481654","updated":"2023-09-15 18:02:37.000000000","message":"you do not need to create the new test instead you can pass the \u0027host\u0027 parameter in migrate_server() call @L232 and that can be configured dest host so that if dest host is configured then nova will migrate the server to that host otherwise nova scheduler will select the host\n\nBelow are the migrate API ref on how to pass host in migrate request\n\n- https://docs.openstack.org/api-ref/compute/#migrate-server-migrate-action\n\nsimilarlly for live migrate   \n- https://docs.openstack.org/api-ref/compute/#live-migrate-server-os-migratelive-action","commit_id":"3ae82fb1626723663630ead0d62dacc945c19169"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":236,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":237,"context_line":"            server, keypair, floating_ip)"},{"line_number":238,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        self.assertNotEqual(src_host, dst_host)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b64f67a8_b24f09ff","line":238,"range":{"start_line":238,"start_character":19,"end_line":238,"end_character":23},"in_reply_to":"57a727de_732c3084","updated":"2023-10-10 08:27:14.000000000","message":"Ack","commit_id":"3ae82fb1626723663630ead0d62dacc945c19169"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f37547b1371f7bef02c5e2018d8f5e80e2e566c1","unresolved":true,"context_lines":[{"line_number":235,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":236,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":237,"context_line":"            server, keypair, floating_ip)"},{"line_number":238,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        self.assertNotEqual(src_host, dst_host)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f625343f_aa5b7d63","line":238,"range":{"start_line":238,"start_character":19,"end_line":238,"end_character":23},"in_reply_to":"6fa1b343_fa6680e6","updated":"2023-08-25 18:26:50.000000000","message":"I commented it previously, this is not the host which nova will forcing server to migrate so we cannot compare the configured one here. if we want to make nova to migrate sevrer to configure one then we need to pass that dest host migrate_server APIs and then assert that nova migrated server to that requested host or not.\n\nIf you do not send dest host in migrate request to nova then nova scheduler choose any available host for server to migrate on.\n\nI think if we are adding config option in this change, I agree that we should use that at least in one test.","commit_id":"3ae82fb1626723663630ead0d62dacc945c19169"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"16b550b9ee42d0370087bdb8dec50878f3a24807","unresolved":true,"context_lines":[{"line_number":235,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":236,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":237,"context_line":"            server, keypair, floating_ip)"},{"line_number":238,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        self.assertNotEqual(src_host, dst_host)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4f93486c_90481654","line":238,"range":{"start_line":238,"start_character":19,"end_line":238,"end_character":23},"in_reply_to":"f625343f_aa5b7d63","updated":"2023-09-15 08:12:39.000000000","message":"As mentioned in https://bugs.launchpad.net/tempest/+bug/2028540 we want also to test migration to dest_host, so should I create new test for this?","commit_id":"3ae82fb1626723663630ead0d62dacc945c19169"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5de1486dc16c25c3ebffdb8c8eba4438e5e9a48c","unresolved":true,"context_lines":[{"line_number":224,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":225,"context_line":"        server \u003d self._setup_server(keypair)"},{"line_number":226,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":227,"context_line":"        src_host \u003d CONF.network.migration_source_host or \\"},{"line_number":228,"context_line":"                   self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":229,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":230,"context_line":"            server, keypair, floating_ip)"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"231c51a0_41b30690","line":228,"range":{"start_line":227,"start_character":0,"end_line":228,"end_character":57},"updated":"2023-09-15 18:09:16.000000000","message":"I am not sure if I commented about this too but this does not do the thing you want to do in this change. I does not have impact on from where you are migrating the server I mean this is not selected as source host which is what you want to do here.\n\nIf you want to specify the source host then you need to create the server on that configured source host and then it become the source host to migrate the server from\n- heck the below APi ref on how to pass the host parameter in create_server request so that server created for this test will be on configured source host and from there you will test the live migration\n\n-  https://docs.openstack.org/api-ref/compute/#create-server\n\nso for this test it has to be done in _setup_server()","commit_id":"d3acdbeb3da482a290b693c596bc967845369a1f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":225,"context_line":"        server \u003d self._setup_server(keypair)"},{"line_number":226,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":227,"context_line":"        src_host \u003d CONF.network.migration_source_host or \\"},{"line_number":228,"context_line":"                   self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":229,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":230,"context_line":"            server, keypair, floating_ip)"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"cd507f5a_5f77416b","line":228,"range":{"start_line":227,"start_character":0,"end_line":228,"end_character":57},"in_reply_to":"231c51a0_41b30690","updated":"2023-10-10 08:27:14.000000000","message":"Ack","commit_id":"d3acdbeb3da482a290b693c596bc967845369a1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5de1486dc16c25c3ebffdb8c8eba4438e5e9a48c","unresolved":true,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":258,"context_line":"                           block_migration_for_live_migration)"},{"line_number":259,"context_line":"        src_host \u003d CONF.network.migration_source_host or \\"},{"line_number":260,"context_line":"                   self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        downtime_meter \u003d net_downtime.NetDowntimeMeter("},{"line_number":263,"context_line":"            floating_ip[\u0027floating_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"e0508d92_e5349461","line":260,"range":{"start_line":259,"start_character":0,"end_line":260,"end_character":57},"updated":"2023-09-15 18:09:16.000000000","message":"ditto","commit_id":"d3acdbeb3da482a290b693c596bc967845369a1f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":258,"context_line":"                           block_migration_for_live_migration)"},{"line_number":259,"context_line":"        src_host \u003d CONF.network.migration_source_host or \\"},{"line_number":260,"context_line":"                   self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        downtime_meter \u003d net_downtime.NetDowntimeMeter("},{"line_number":263,"context_line":"            floating_ip[\u0027floating_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"d1018282_217eb4e4","line":260,"range":{"start_line":259,"start_character":0,"end_line":260,"end_character":57},"in_reply_to":"e0508d92_e5349461","updated":"2023-10-10 08:27:14.000000000","message":"Ack","commit_id":"d3acdbeb3da482a290b693c596bc967845369a1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5de1486dc16c25c3ebffdb8c8eba4438e5e9a48c","unresolved":true,"context_lines":[{"line_number":299,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":300,"context_line":"        server \u003d self._setup_server(keypair)"},{"line_number":301,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":302,"context_line":"        src_host \u003d CONF.network.migration_source_host or \\"},{"line_number":303,"context_line":"                   self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":304,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":305,"context_line":"            server, keypair, floating_ip)"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d76ddc0a_a32dfc6b","line":303,"range":{"start_line":302,"start_character":0,"end_line":303,"end_character":57},"updated":"2023-09-15 18:09:16.000000000","message":"ditto","commit_id":"d3acdbeb3da482a290b693c596bc967845369a1f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":300,"context_line":"        server \u003d self._setup_server(keypair)"},{"line_number":301,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":302,"context_line":"        src_host \u003d CONF.network.migration_source_host or \\"},{"line_number":303,"context_line":"                   self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":304,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":305,"context_line":"            server, keypair, floating_ip)"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"a24f6ec6_5e7c5e31","line":303,"range":{"start_line":302,"start_character":0,"end_line":303,"end_character":57},"in_reply_to":"d76ddc0a_a32dfc6b","updated":"2023-10-10 08:27:14.000000000","message":"Ack","commit_id":"d3acdbeb3da482a290b693c596bc967845369a1f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b5146fc5ec6ca5d1bf22a9125342ad395acf5c0c","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if host_spec is not None:"},{"line_number":77,"context_line":"            server_args[\u0027host\u0027] \u003d host_spec"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        server \u003d self.create_server(**server_args)"},{"line_number":80,"context_line":"        return server"}],"source_content_type":"text/x-python","patch_set":7,"id":"43a8ee71_2ff408f4","line":77,"range":{"start_line":77,"start_character":10,"end_line":77,"end_character":11},"updated":"2023-10-03 10:15:16.000000000","message":"the API offers the host option since 2.74 version .. we should check whether we comply with that if the user specified host_spec and skip if the version is \u003c 2.74\n\nhttps://docs.openstack.org/api-ref/compute/#create-server\n\nThis conditioned skip should go to the test itself","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b4c9365e407b74ea57bf208c33082904c917f874","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if host_spec is not None:"},{"line_number":77,"context_line":"            server_args[\u0027host\u0027] \u003d host_spec"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        server \u003d self.create_server(**server_args)"},{"line_number":80,"context_line":"        return server"}],"source_content_type":"text/x-python","patch_set":7,"id":"29f36498_e9bedb64","line":77,"range":{"start_line":77,"start_character":10,"end_line":77,"end_character":11},"in_reply_to":"25c38e37_5cccd670","updated":"2024-02-15 13:07:21.000000000","message":"Done","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"49ef119f42e1f13eadc3ca790176f3615e927e02","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if host_spec is not None:"},{"line_number":77,"context_line":"            server_args[\u0027host\u0027] \u003d host_spec"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        server \u003d self.create_server(**server_args)"},{"line_number":80,"context_line":"        return server"}],"source_content_type":"text/x-python","patch_set":7,"id":"b595b48c_04d07be6","line":77,"range":{"start_line":77,"start_character":10,"end_line":77,"end_character":11},"in_reply_to":"3692c347_67ecb25a","updated":"2023-10-25 16:04:30.000000000","message":"we need to handle the microversion check. old microversion exist in all the releases including latest master. In nova, we have not bumped the min microversion so it does not matter which release any new microversion is introduced but we need to handle the things for min and max microversions supported by any release.\n\nExample. if we do not handle microversion condition then testing this test with tempest.conf.compute.min_microversion \u003c2.74 will fail.","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if host_spec is not None:"},{"line_number":77,"context_line":"            server_args[\u0027host\u0027] \u003d host_spec"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        server \u003d self.create_server(**server_args)"},{"line_number":80,"context_line":"        return server"}],"source_content_type":"text/x-python","patch_set":7,"id":"3692c347_67ecb25a","line":77,"range":{"start_line":77,"start_character":10,"end_line":77,"end_character":11},"in_reply_to":"43a8ee71_2ff408f4","updated":"2023-10-10 08:27:14.000000000","message":"2.74 microversion exists since Train:\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/rest_api_version_history.rst#274\n\nThat\u0027s 8 releases back \u003d\u003e I don\u0027t think we need to handle this microversion and skip if lower","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f34a6870ada0f1caf2232029649a4e596e61921b","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if host_spec is not None:"},{"line_number":77,"context_line":"            server_args[\u0027host\u0027] \u003d host_spec"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        server \u003d self.create_server(**server_args)"},{"line_number":80,"context_line":"        return server"}],"source_content_type":"text/x-python","patch_set":7,"id":"25c38e37_5cccd670","line":77,"range":{"start_line":77,"start_character":10,"end_line":77,"end_character":11},"in_reply_to":"b595b48c_04d07be6","updated":"2023-11-20 14:09:46.000000000","message":"right, I didn\u0027t think of that :/ Thanks!","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":true,"context_lines":[{"line_number":199,"context_line":"        resize_flavor \u003d CONF.compute.flavor_ref_alt"},{"line_number":200,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":201,"context_line":"        src_host_spec \u003d CONF.network.migration_source_host"},{"line_number":202,"context_line":"        server \u003d self._setup_server(keypair, src_host_spec)"},{"line_number":203,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":204,"context_line":"        self.servers_client.resize_server(server[\u0027id\u0027],"},{"line_number":205,"context_line":"                                          flavor_ref\u003dresize_flavor)"}],"source_content_type":"text/x-python","patch_set":7,"id":"61def09f_bcf2fe1e","line":202,"updated":"2023-10-10 08:27:14.000000000","message":"let\u0027s add here something like:\n\n```\nif src_host_spec:\n    src_host \u003d self.get_host_for_server(server[\u0027id\u0027])\n    self.assertEqual(src_host, src_host_spec)\n```","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"3adc36a5c61976e99547125b5e776baabb36e250","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        resize_flavor \u003d CONF.compute.flavor_ref_alt"},{"line_number":200,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":201,"context_line":"        src_host_spec \u003d CONF.network.migration_source_host"},{"line_number":202,"context_line":"        server \u003d self._setup_server(keypair, src_host_spec)"},{"line_number":203,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":204,"context_line":"        self.servers_client.resize_server(server[\u0027id\u0027],"},{"line_number":205,"context_line":"                                          flavor_ref\u003dresize_flavor)"}],"source_content_type":"text/x-python","patch_set":7,"id":"2269bde3_122f5212","line":202,"in_reply_to":"61def09f_bcf2fe1e","updated":"2023-10-18 15:52:39.000000000","message":"Done","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b5146fc5ec6ca5d1bf22a9125342ad395acf5c0c","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                          \u0027tests.\u0027)"},{"line_number":228,"context_line":"    @decorators.attr(type\u003d[\u0027slow\u0027, \u0027multinode\u0027])"},{"line_number":229,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":230,"context_line":"    def test_server_connectivity_cold_migration(self):"},{"line_number":231,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":232,"context_line":"        src_host_spec \u003d CONF.network.migration_source_host"},{"line_number":233,"context_line":"        server \u003d self._setup_server(keypair, src_host_spec)"}],"source_content_type":"text/x-python","patch_set":7,"id":"71fd7c70_c698cf0e","line":230,"range":{"start_line":230,"start_character":52,"end_line":230,"end_character":54},"updated":"2023-10-03 10:15:16.000000000","message":"we should add a version check at the beginning of the test, the migrate API offers the host since version 2.56 - if the version requirement is not met, we need to skip the test.\n\nhttps://docs.openstack.org/api-ref/compute/#migrate-server-migrate-action","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b4c9365e407b74ea57bf208c33082904c917f874","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                          \u0027tests.\u0027)"},{"line_number":228,"context_line":"    @decorators.attr(type\u003d[\u0027slow\u0027, \u0027multinode\u0027])"},{"line_number":229,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":230,"context_line":"    def test_server_connectivity_cold_migration(self):"},{"line_number":231,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":232,"context_line":"        src_host_spec \u003d CONF.network.migration_source_host"},{"line_number":233,"context_line":"        server \u003d self._setup_server(keypair, src_host_spec)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5b416d_02e37830","line":230,"range":{"start_line":230,"start_character":52,"end_line":230,"end_character":54},"in_reply_to":"4b4fd36c_71ed12c7","updated":"2024-02-15 13:07:21.000000000","message":"we\u0027ve set compute_min_microversion \u003d \"2.74\"","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                          \u0027tests.\u0027)"},{"line_number":228,"context_line":"    @decorators.attr(type\u003d[\u0027slow\u0027, \u0027multinode\u0027])"},{"line_number":229,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":230,"context_line":"    def test_server_connectivity_cold_migration(self):"},{"line_number":231,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":232,"context_line":"        src_host_spec \u003d CONF.network.migration_source_host"},{"line_number":233,"context_line":"        server \u003d self._setup_server(keypair, src_host_spec)"}],"source_content_type":"text/x-python","patch_set":7,"id":"4b4fd36c_71ed12c7","line":230,"range":{"start_line":230,"start_character":52,"end_line":230,"end_character":54},"in_reply_to":"71fd7c70_c698cf0e","updated":"2023-10-10 08:27:14.000000000","message":"version 2.56 has been there since Queens release:\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/rest_api_version_history.rst#256\n\nThat\u0027s ~11 releases ago, we\u0027re fine here. I don\u0027t think we need to handle the version.","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d1ad88510eb0f0c3a0c7c6f4f8b23042ded79bc6","unresolved":true,"context_lines":[{"line_number":232,"context_line":"        src_host_spec \u003d CONF.network.migration_source_host"},{"line_number":233,"context_line":"        server \u003d self._setup_server(keypair, src_host_spec)"},{"line_number":234,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":235,"context_line":"        src_host \u003d src_host_spec or self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":236,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":237,"context_line":"            server, keypair, floating_ip)"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ae9da782_e8221610","line":235,"range":{"start_line":235,"start_character":20,"end_line":235,"end_character":74},"updated":"2023-10-03 09:59:55.000000000","message":"get_host_for_server should return the same value, however, this brings up an interesting question, do we want to check that get_host_for_server return value equals to src_host_spec?","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"3adc36a5c61976e99547125b5e776baabb36e250","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        src_host_spec \u003d CONF.network.migration_source_host"},{"line_number":233,"context_line":"        server \u003d self._setup_server(keypair, src_host_spec)"},{"line_number":234,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":235,"context_line":"        src_host \u003d src_host_spec or self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":236,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":237,"context_line":"            server, keypair, floating_ip)"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"62fba92e_68a0aba8","line":235,"range":{"start_line":235,"start_character":20,"end_line":235,"end_character":74},"in_reply_to":"685f7169_7b4c8b38","updated":"2023-10-18 15:52:39.000000000","message":"Done","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":true,"context_lines":[{"line_number":232,"context_line":"        src_host_spec \u003d CONF.network.migration_source_host"},{"line_number":233,"context_line":"        server \u003d self._setup_server(keypair, src_host_spec)"},{"line_number":234,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":235,"context_line":"        src_host \u003d src_host_spec or self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":236,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":237,"context_line":"            server, keypair, floating_ip)"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"685f7169_7b4c8b38","line":235,"range":{"start_line":235,"start_character":20,"end_line":235,"end_character":74},"in_reply_to":"ae9da782_e8221610","updated":"2023-10-10 08:27:14.000000000","message":"let\u0027s leave this line as it was:\n```\nsrc_host \u003d self.get_host_for_server(server[\u0027id\u0027])\n```\n\nand add something like the following at the end of the test:\n```\nif src_host_spec:\n    self.assertEqual(src_host, src_host_spec)\nif migration_dest_host:\n    self.assertEqual(dest_host, migration_dest_host)\n```","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d1ad88510eb0f0c3a0c7c6f4f8b23042ded79bc6","unresolved":true,"context_lines":[{"line_number":245,"context_line":"            server, keypair, floating_ip)"},{"line_number":246,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        self.assertNotEqual(src_host, dst_host)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    @decorators.idempotent_id(\u002703fd1562-faad-11e7-9ea0-fa163e65f5ce\u0027)"},{"line_number":251,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.live_migration,"}],"source_content_type":"text/x-python","patch_set":7,"id":"4b45b4a7_df1c8d27","line":248,"updated":"2023-10-03 09:59:55.000000000","message":"do we want to also add another assert checking that the dst_host equals to CONF.network.migration_dest_host?","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            server, keypair, floating_ip)"},{"line_number":246,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        self.assertNotEqual(src_host, dst_host)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    @decorators.idempotent_id(\u002703fd1562-faad-11e7-9ea0-fa163e65f5ce\u0027)"},{"line_number":251,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.live_migration,"}],"source_content_type":"text/x-python","patch_set":7,"id":"39814bb6_599f5390","line":248,"in_reply_to":"4b45b4a7_df1c8d27","updated":"2023-10-10 08:27:14.000000000","message":"yes, let\u0027s do that, i commented that in the comment on line 235","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b5146fc5ec6ca5d1bf22a9125342ad395acf5c0c","unresolved":true,"context_lines":[{"line_number":255,"context_line":"                          \u0027tests.\u0027)"},{"line_number":256,"context_line":"    @decorators.attr(type\u003d[\u0027slow\u0027, \u0027multinode\u0027])"},{"line_number":257,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":258,"context_line":"    def test_server_connectivity_live_migration(self):"},{"line_number":259,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":260,"context_line":"        src_host_spec \u003d CONF.network.migration_source_host"},{"line_number":261,"context_line":"        server \u003d self._setup_server(keypair, src_host_spec)"}],"source_content_type":"text/x-python","patch_set":7,"id":"138544e7_86163e57","line":258,"range":{"start_line":258,"start_character":52,"end_line":258,"end_character":54},"updated":"2023-10-03 10:15:16.000000000","message":"we should add a version check at the beginning of the test, the live migrate API offers the host since version 2.30 - if the version requirement is not met, we need to skip the test.\n\nhttps://docs.openstack.org/api-ref/compute/#live-migrate-server-os-migratelive-action","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":true,"context_lines":[{"line_number":255,"context_line":"                          \u0027tests.\u0027)"},{"line_number":256,"context_line":"    @decorators.attr(type\u003d[\u0027slow\u0027, \u0027multinode\u0027])"},{"line_number":257,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":258,"context_line":"    def test_server_connectivity_live_migration(self):"},{"line_number":259,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":260,"context_line":"        src_host_spec \u003d CONF.network.migration_source_host"},{"line_number":261,"context_line":"        server \u003d self._setup_server(keypair, src_host_spec)"}],"source_content_type":"text/x-python","patch_set":7,"id":"f378d2c5_1cfb67ba","line":258,"range":{"start_line":258,"start_character":52,"end_line":258,"end_character":54},"in_reply_to":"138544e7_86163e57","updated":"2023-10-10 08:27:14.000000000","message":"2.30 version has been there forever: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/rest_api_version_history.rst#230","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b4c9365e407b74ea57bf208c33082904c917f874","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                          \u0027tests.\u0027)"},{"line_number":256,"context_line":"    @decorators.attr(type\u003d[\u0027slow\u0027, \u0027multinode\u0027])"},{"line_number":257,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":258,"context_line":"    def test_server_connectivity_live_migration(self):"},{"line_number":259,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":260,"context_line":"        src_host_spec \u003d CONF.network.migration_source_host"},{"line_number":261,"context_line":"        server \u003d self._setup_server(keypair, src_host_spec)"}],"source_content_type":"text/x-python","patch_set":7,"id":"e72f7184_4dc29ad7","line":258,"range":{"start_line":258,"start_character":52,"end_line":258,"end_character":54},"in_reply_to":"f378d2c5_1cfb67ba","updated":"2024-02-15 13:07:21.000000000","message":"we\u0027ve set compute_min_microversion \u003d \"2.74\"","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":true,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":267,"context_line":"                           block_migration_for_live_migration)"},{"line_number":268,"context_line":"        src_host \u003d src_host_spec or self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        downtime_meter \u003d net_downtime.NetDowntimeMeter("},{"line_number":271,"context_line":"            floating_ip[\u0027floating_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"21a8b38c_ec0233f7","line":268,"range":{"start_line":268,"start_character":0,"end_line":268,"end_character":13},"updated":"2023-10-10 08:27:14.000000000","message":"let\u0027s leave this as it was:\n```\nsrc_host \u003d self.get_host_for_server(server[\u0027id\u0027]\n```","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"3adc36a5c61976e99547125b5e776baabb36e250","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":267,"context_line":"                           block_migration_for_live_migration)"},{"line_number":268,"context_line":"        src_host \u003d src_host_spec or self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        downtime_meter \u003d net_downtime.NetDowntimeMeter("},{"line_number":271,"context_line":"            floating_ip[\u0027floating_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"253c815d_9ae6b9e3","line":268,"range":{"start_line":268,"start_character":0,"end_line":268,"end_character":13},"in_reply_to":"21a8b38c_ec0233f7","updated":"2023-10-18 15:52:39.000000000","message":"Done","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":true,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":281,"context_line":"        self.assertNotEqual(src_host, dst_host, \u0027Server did not migrate\u0027)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        # we first wait until the VM replies pings again, then check the"},{"line_number":284,"context_line":"        # network downtime"},{"line_number":285,"context_line":"        self._wait_server_status_and_check_network_connectivity("}],"source_content_type":"text/x-python","patch_set":7,"id":"2edd9e42_b2b38e5e","line":282,"updated":"2023-10-10 08:27:14.000000000","message":"and add here something like;\n\n```\nif src_host_spec:\n    self.assertEqual(src_host, src_host_spec)\nif migration_dest_host:\n    self.assertEqual(dest_host, migration_dest_host)\n```","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"3adc36a5c61976e99547125b5e776baabb36e250","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":281,"context_line":"        self.assertNotEqual(src_host, dst_host, \u0027Server did not migrate\u0027)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        # we first wait until the VM replies pings again, then check the"},{"line_number":284,"context_line":"        # network downtime"},{"line_number":285,"context_line":"        self._wait_server_status_and_check_network_connectivity("}],"source_content_type":"text/x-python","patch_set":7,"id":"a13cf10b_aece3b9e","line":282,"in_reply_to":"2edd9e42_b2b38e5e","updated":"2023-10-18 15:52:39.000000000","message":"Done","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":true,"context_lines":[{"line_number":308,"context_line":"        src_host_spec \u003d CONF.network.migration_source_host"},{"line_number":309,"context_line":"        server \u003d self._setup_server(keypair, src_host_spec)"},{"line_number":310,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":311,"context_line":"        src_host \u003d src_host_spec or self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":312,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":313,"context_line":"            server, keypair, floating_ip)"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5fa140a1_0fdbcd3c","line":311,"range":{"start_line":311,"start_character":0,"end_line":311,"end_character":15},"updated":"2023-10-10 08:27:14.000000000","message":"ditto","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"3adc36a5c61976e99547125b5e776baabb36e250","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        src_host_spec \u003d CONF.network.migration_source_host"},{"line_number":309,"context_line":"        server \u003d self._setup_server(keypair, src_host_spec)"},{"line_number":310,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":311,"context_line":"        src_host \u003d src_host_spec or self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":312,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":313,"context_line":"            server, keypair, floating_ip)"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"313832f0_e7eca46f","line":311,"range":{"start_line":311,"start_character":0,"end_line":311,"end_character":15},"in_reply_to":"5fa140a1_0fdbcd3c","updated":"2023-10-18 15:52:39.000000000","message":"Done","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":true,"context_lines":[{"line_number":321,"context_line":"            server, keypair, floating_ip)"},{"line_number":322,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        self.assertEqual(src_host, dst_host)"}],"source_content_type":"text/x-python","patch_set":7,"id":"d75d155a_34106593","line":324,"range":{"start_line":324,"start_character":43,"end_line":324,"end_character":44},"updated":"2023-10-10 08:27:14.000000000","message":"let\u0027s add the new assert too","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b948d4248f518fc743c2bb618665a6e8bb8a16f9","unresolved":true,"context_lines":[{"line_number":321,"context_line":"            server, keypair, floating_ip)"},{"line_number":322,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        self.assertEqual(src_host, dst_host)"}],"source_content_type":"text/x-python","patch_set":7,"id":"b5e1de36_d2895117","line":324,"range":{"start_line":324,"start_character":13,"end_line":324,"end_character":24},"updated":"2023-10-10 08:27:14.000000000","message":"why is this assertEqual? Didn\u0027t the server migrate? .. if we expect that the server doesn\u0027t migrate here then we can\u0027t pass migration_dest_host in this test as it would mean the opposite","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b4c9365e407b74ea57bf208c33082904c917f874","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            server, keypair, floating_ip)"},{"line_number":322,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        self.assertEqual(src_host, dst_host)"}],"source_content_type":"text/x-python","patch_set":7,"id":"afd63146_861ca266","line":324,"range":{"start_line":324,"start_character":13,"end_line":324,"end_character":24},"in_reply_to":"0314b03a_aec6edb3","updated":"2024-02-15 13:07:21.000000000","message":"Done","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08f1ed17d6885346b244b50cd656e26a3e1a293b","unresolved":true,"context_lines":[{"line_number":321,"context_line":"            server, keypair, floating_ip)"},{"line_number":322,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        self.assertEqual(src_host, dst_host)"}],"source_content_type":"text/x-python","patch_set":7,"id":"0314b03a_aec6edb3","line":324,"range":{"start_line":324,"start_character":13,"end_line":324,"end_character":24},"in_reply_to":"6b255f47_8bc22171","updated":"2023-11-21 19:08:52.000000000","message":"this is correct, because cold migration/resize operation does not move the server to new host until resize is confirmed. Nova do create the new instance of same type but if it is reverted then it delete the new one. In this test, L334 revert the resize which means server stay at the same host as it was before.","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"3adc36a5c61976e99547125b5e776baabb36e250","unresolved":true,"context_lines":[{"line_number":321,"context_line":"            server, keypair, floating_ip)"},{"line_number":322,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        self.assertEqual(src_host, dst_host)"}],"source_content_type":"text/x-python","patch_set":7,"id":"6b255f47_8bc22171","line":324,"range":{"start_line":324,"start_character":13,"end_line":324,"end_character":24},"in_reply_to":"b5e1de36_d2895117","updated":"2023-10-18 15:52:39.000000000","message":"I think we can check it before calling revert_resize_server? But I\u0027m not sure if it is needed.","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"3adc36a5c61976e99547125b5e776baabb36e250","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            server, keypair, floating_ip)"},{"line_number":322,"context_line":"        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        self.assertEqual(src_host, dst_host)"}],"source_content_type":"text/x-python","patch_set":7,"id":"b4c72e2a_9909a6a9","line":324,"range":{"start_line":324,"start_character":43,"end_line":324,"end_character":44},"in_reply_to":"d75d155a_34106593","updated":"2023-10-18 15:52:39.000000000","message":"Done","commit_id":"bce6a83b42d52b6f6a3f12566c1b117884f0b35b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b32d743257ff2c1843087c4c4539a923eb6a392c","unresolved":true,"context_lines":[{"line_number":222,"context_line":"            self.assertEqual(resize_flavor, server[\u0027flavor\u0027][\u0027id\u0027])"},{"line_number":223,"context_line":"        else:"},{"line_number":224,"context_line":"            flavor \u003d self.flavors_client.show_flavor(resize_flavor)[\u0027flavor\u0027]"},{"line_number":225,"context_line":"            self.assertEqual(flavor[\u0027name\u0027], server[\u0027flavor\u0027][\u0027original_name\u0027])"},{"line_number":226,"context_line":"            for key in [\u0027ram\u0027, \u0027vcpus\u0027, \u0027disk\u0027]:"},{"line_number":227,"context_line":"                self.assertEqual(flavor[key], server[\u0027flavor\u0027][key])"},{"line_number":228,"context_line":"        self._wait_server_status_and_check_network_connectivity("}],"source_content_type":"text/x-python","patch_set":10,"id":"b79718dd_12677a5a","line":225,"range":{"start_line":225,"start_character":53,"end_line":225,"end_character":62},"updated":"2023-10-24 10:09:10.000000000","message":"good catch!","commit_id":"b2e1c07099d5b47317bab03fca637cec9cbb6a07"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f34a6870ada0f1caf2232029649a4e596e61921b","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            self.assertEqual(resize_flavor, server[\u0027flavor\u0027][\u0027id\u0027])"},{"line_number":223,"context_line":"        else:"},{"line_number":224,"context_line":"            flavor \u003d self.flavors_client.show_flavor(resize_flavor)[\u0027flavor\u0027]"},{"line_number":225,"context_line":"            self.assertEqual(flavor[\u0027name\u0027], server[\u0027flavor\u0027][\u0027original_name\u0027])"},{"line_number":226,"context_line":"            for key in [\u0027ram\u0027, \u0027vcpus\u0027, \u0027disk\u0027]:"},{"line_number":227,"context_line":"                self.assertEqual(flavor[key], server[\u0027flavor\u0027][key])"},{"line_number":228,"context_line":"        self._wait_server_status_and_check_network_connectivity("}],"source_content_type":"text/x-python","patch_set":10,"id":"a8f86ef6_4d03da24","line":225,"range":{"start_line":225,"start_character":53,"end_line":225,"end_character":62},"in_reply_to":"b79718dd_12677a5a","updated":"2023-11-20 14:09:46.000000000","message":"moved to https://review.opendev.org/c/openstack/tempest/+/901039","commit_id":"b2e1c07099d5b47317bab03fca637cec9cbb6a07"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b32d743257ff2c1843087c4c4539a923eb6a392c","unresolved":true,"context_lines":[{"line_number":244,"context_line":"                           CONF.compute.min_microversion \u003e\u003d \u00272.74\u0027) or"},{"line_number":245,"context_line":"                          not CONF.compute.migration_dest_host,"},{"line_number":246,"context_line":"                          \u0027For api calls microversion must be \u003e\u003d 2.74\u0027)"},{"line_number":247,"context_line":"    @testtools.skipUnless(not (CONF.compute.migration_source_host and"},{"line_number":248,"context_line":"                               CONF.compute.migration_dest_host and"},{"line_number":249,"context_line":"                               CONF.compute.migration_source_host \u003d\u003d"},{"line_number":250,"context_line":"                               CONF.compute.migration_dest_host),"}],"source_content_type":"text/x-python","patch_set":10,"id":"2fd26c81_3bbf7e77","line":247,"range":{"start_line":247,"start_character":15,"end_line":247,"end_character":25},"updated":"2023-10-24 10:09:10.000000000","message":"if you use skipIf you can get rid of the first \u0027not\u0027 - it would be easier readable\n\nthe same for other occurrences below","commit_id":"b2e1c07099d5b47317bab03fca637cec9cbb6a07"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f34a6870ada0f1caf2232029649a4e596e61921b","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                           CONF.compute.min_microversion \u003e\u003d \u00272.74\u0027) or"},{"line_number":245,"context_line":"                          not CONF.compute.migration_dest_host,"},{"line_number":246,"context_line":"                          \u0027For api calls microversion must be \u003e\u003d 2.74\u0027)"},{"line_number":247,"context_line":"    @testtools.skipUnless(not (CONF.compute.migration_source_host and"},{"line_number":248,"context_line":"                               CONF.compute.migration_dest_host and"},{"line_number":249,"context_line":"                               CONF.compute.migration_source_host \u003d\u003d"},{"line_number":250,"context_line":"                               CONF.compute.migration_dest_host),"}],"source_content_type":"text/x-python","patch_set":10,"id":"460772cd_7e60781d","line":247,"range":{"start_line":247,"start_character":15,"end_line":247,"end_character":25},"in_reply_to":"2fd26c81_3bbf7e77","updated":"2023-11-20 14:09:46.000000000","message":"Done","commit_id":"b2e1c07099d5b47317bab03fca637cec9cbb6a07"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"49ef119f42e1f13eadc3ca790176f3615e927e02","unresolved":true,"context_lines":[{"line_number":234,"context_line":"    @testtools.skipUnless(CONF.compute.min_compute_nodes \u003e 1,"},{"line_number":235,"context_line":"                          \u0027Less than 2 compute nodes, skipping multinode \u0027"},{"line_number":236,"context_line":"                          \u0027tests.\u0027)"},{"line_number":237,"context_line":"    @testtools.skipUnless((CONF.compute.migration_source_host and"},{"line_number":238,"context_line":"                           \u0027admin\u0027 in CONF.auth.tempest_roles and"},{"line_number":239,"context_line":"                           CONF.compute.min_microversion \u003e\u003d \u00272.74\u0027) or"},{"line_number":240,"context_line":"                          not CONF.compute.migration_source_host,"},{"line_number":241,"context_line":"                          \u0027For api calls with host admin credentials\u0027"},{"line_number":242,"context_line":"                          \u0027 are needed and microversion must be \u003e\u003d 2.74\u0027)"},{"line_number":243,"context_line":"    @testtools.skipUnless((CONF.compute.migration_dest_host and"},{"line_number":244,"context_line":"                           CONF.compute.min_microversion \u003e\u003d \u00272.74\u0027) or"},{"line_number":245,"context_line":"                          not CONF.compute.migration_dest_host,"},{"line_number":246,"context_line":"                          \u0027For api calls microversion must be \u003e\u003d 2.74\u0027)"},{"line_number":247,"context_line":"    @testtools.skipUnless(not (CONF.compute.migration_source_host and"},{"line_number":248,"context_line":"                               CONF.compute.migration_dest_host and"},{"line_number":249,"context_line":"                               CONF.compute.migration_source_host \u003d\u003d"},{"line_number":250,"context_line":"                               CONF.compute.migration_dest_host),"},{"line_number":251,"context_line":"                          \u0027Source and destination hosts are same\u0027)"},{"line_number":252,"context_line":"    @decorators.attr(type\u003d[\u0027slow\u0027, \u0027multinode\u0027])"},{"line_number":253,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":254,"context_line":"    def test_server_connectivity_cold_migration(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"909c6a2e_ee10990b","line":251,"range":{"start_line":237,"start_character":0,"end_line":251,"end_character":66},"updated":"2023-10-25 16:04:30.000000000","message":"skipping all the tests if CONF.compute.min_microversion \u003e 2.74 (which is our default setting in upstream CI) will endup skipping this test all the time.\n\nIf any test need min microvesion then we should have that in test class as min_microversion so that tempest logic for microversion selection can skip or run the test based on microversion required by the tests and configured one.\n\nsaying that we have two options to solve this:\n\n1. Add a new tests testing the source and dest host things based on configuration.\n\n2. if we want to handle/test it in existing tests then we should skip passing the host if condition of microversion is not met and run the test in same way it is currently (before this change).","commit_id":"b2e1c07099d5b47317bab03fca637cec9cbb6a07"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"7cd1e9f071574f87409ee6184df589fc4970de51","unresolved":true,"context_lines":[{"line_number":234,"context_line":"    @testtools.skipUnless(CONF.compute.min_compute_nodes \u003e 1,"},{"line_number":235,"context_line":"                          \u0027Less than 2 compute nodes, skipping multinode \u0027"},{"line_number":236,"context_line":"                          \u0027tests.\u0027)"},{"line_number":237,"context_line":"    @testtools.skipUnless((CONF.compute.migration_source_host and"},{"line_number":238,"context_line":"                           \u0027admin\u0027 in CONF.auth.tempest_roles and"},{"line_number":239,"context_line":"                           CONF.compute.min_microversion \u003e\u003d \u00272.74\u0027) or"},{"line_number":240,"context_line":"                          not CONF.compute.migration_source_host,"},{"line_number":241,"context_line":"                          \u0027For api calls with host admin credentials\u0027"},{"line_number":242,"context_line":"                          \u0027 are needed and microversion must be \u003e\u003d 2.74\u0027)"},{"line_number":243,"context_line":"    @testtools.skipUnless((CONF.compute.migration_dest_host and"},{"line_number":244,"context_line":"                           CONF.compute.min_microversion \u003e\u003d \u00272.74\u0027) or"},{"line_number":245,"context_line":"                          not CONF.compute.migration_dest_host,"},{"line_number":246,"context_line":"                          \u0027For api calls microversion must be \u003e\u003d 2.74\u0027)"},{"line_number":247,"context_line":"    @testtools.skipUnless(not (CONF.compute.migration_source_host and"},{"line_number":248,"context_line":"                               CONF.compute.migration_dest_host and"},{"line_number":249,"context_line":"                               CONF.compute.migration_source_host \u003d\u003d"},{"line_number":250,"context_line":"                               CONF.compute.migration_dest_host),"},{"line_number":251,"context_line":"                          \u0027Source and destination hosts are same\u0027)"},{"line_number":252,"context_line":"    @decorators.attr(type\u003d[\u0027slow\u0027, \u0027multinode\u0027])"},{"line_number":253,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":254,"context_line":"    def test_server_connectivity_cold_migration(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"a029cab5_aa3e8a74","line":251,"range":{"start_line":237,"start_character":0,"end_line":251,"end_character":66},"in_reply_to":"909c6a2e_ee10990b","updated":"2023-11-01 12:11:31.000000000","message":"In that case I think, we should create new tests, because for api calls where we creating server with specified host also admin credentials are needed.","commit_id":"b2e1c07099d5b47317bab03fca637cec9cbb6a07"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b4c9365e407b74ea57bf208c33082904c917f874","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    @testtools.skipUnless(CONF.compute.min_compute_nodes \u003e 1,"},{"line_number":235,"context_line":"                          \u0027Less than 2 compute nodes, skipping multinode \u0027"},{"line_number":236,"context_line":"                          \u0027tests.\u0027)"},{"line_number":237,"context_line":"    @testtools.skipUnless((CONF.compute.migration_source_host and"},{"line_number":238,"context_line":"                           \u0027admin\u0027 in CONF.auth.tempest_roles and"},{"line_number":239,"context_line":"                           CONF.compute.min_microversion \u003e\u003d \u00272.74\u0027) or"},{"line_number":240,"context_line":"                          not CONF.compute.migration_source_host,"},{"line_number":241,"context_line":"                          \u0027For api calls with host admin credentials\u0027"},{"line_number":242,"context_line":"                          \u0027 are needed and microversion must be \u003e\u003d 2.74\u0027)"},{"line_number":243,"context_line":"    @testtools.skipUnless((CONF.compute.migration_dest_host and"},{"line_number":244,"context_line":"                           CONF.compute.min_microversion \u003e\u003d \u00272.74\u0027) or"},{"line_number":245,"context_line":"                          not CONF.compute.migration_dest_host,"},{"line_number":246,"context_line":"                          \u0027For api calls microversion must be \u003e\u003d 2.74\u0027)"},{"line_number":247,"context_line":"    @testtools.skipUnless(not (CONF.compute.migration_source_host and"},{"line_number":248,"context_line":"                               CONF.compute.migration_dest_host and"},{"line_number":249,"context_line":"                               CONF.compute.migration_source_host \u003d\u003d"},{"line_number":250,"context_line":"                               CONF.compute.migration_dest_host),"},{"line_number":251,"context_line":"                          \u0027Source and destination hosts are same\u0027)"},{"line_number":252,"context_line":"    @decorators.attr(type\u003d[\u0027slow\u0027, \u0027multinode\u0027])"},{"line_number":253,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":254,"context_line":"    def test_server_connectivity_cold_migration(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"06d1b33e_77dc6873","line":251,"range":{"start_line":237,"start_character":0,"end_line":251,"end_character":66},"in_reply_to":"a029cab5_aa3e8a74","updated":"2024-02-15 13:07:21.000000000","message":"Done","commit_id":"b2e1c07099d5b47317bab03fca637cec9cbb6a07"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b32d743257ff2c1843087c4c4539a923eb6a392c","unresolved":true,"context_lines":[{"line_number":321,"context_line":"        self.admin_servers_client.live_migrate_server("},{"line_number":322,"context_line":"            server[\u0027id\u0027], host\u003ddst_host_spec,"},{"line_number":323,"context_line":"            block_migration\u003dblock_migration,"},{"line_number":324,"context_line":"            disk_over_commit\u003dFalse)"},{"line_number":325,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":326,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"72842615_06b9c604","line":324,"range":{"start_line":324,"start_character":11,"end_line":324,"end_character":35},"updated":"2023-10-24 10:09:10.000000000","message":"as I was testing this patch with CONF.compute.min_microversion \u003e\u003d \u00272.74\u0027 this test failed because disk_over_commit was available until version 2.25\n\nhttps://docs.openstack.org/api-ref/compute/#live-migrate-server-os-migratelive-action\n\nmaybe it would be better to address this together with the fix on line 225 in a separate patch as those 2 changes don\u0027t relate to this feature.","commit_id":"b2e1c07099d5b47317bab03fca637cec9cbb6a07"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f34a6870ada0f1caf2232029649a4e596e61921b","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        self.admin_servers_client.live_migrate_server("},{"line_number":322,"context_line":"            server[\u0027id\u0027], host\u003ddst_host_spec,"},{"line_number":323,"context_line":"            block_migration\u003dblock_migration,"},{"line_number":324,"context_line":"            disk_over_commit\u003dFalse)"},{"line_number":325,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":326,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"616292b7_1c8a4201","line":324,"range":{"start_line":324,"start_character":11,"end_line":324,"end_character":35},"in_reply_to":"72842615_06b9c604","updated":"2023-11-20 14:09:46.000000000","message":"fixed in https://review.opendev.org/c/openstack/tempest/+/901039","commit_id":"b2e1c07099d5b47317bab03fca637cec9cbb6a07"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f34a6870ada0f1caf2232029649a4e596e61921b","unresolved":true,"context_lines":[{"line_number":114,"context_line":"     * Rebuild an instance"},{"line_number":115,"context_line":"     * Pause/Unpause an instance"},{"line_number":116,"context_line":"     * Suspend/Resume an instance"},{"line_number":117,"context_line":"    \"\"\""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @decorators.idempotent_id(\u002761f1aa9a-1573-410e-9054-afa557cab021\u0027)"},{"line_number":120,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1c53504a_4f93cafb","line":117,"updated":"2023-11-20 14:09:46.000000000","message":"path of the tests in this class was not changed","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"682d32f0a3b22b3022acfee2433ff13f6029ca3a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"     * Rebuild an instance"},{"line_number":115,"context_line":"     * Pause/Unpause an instance"},{"line_number":116,"context_line":"     * Suspend/Resume an instance"},{"line_number":117,"context_line":"    \"\"\""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @decorators.idempotent_id(\u002761f1aa9a-1573-410e-9054-afa557cab021\u0027)"},{"line_number":120,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"889e2bf7_fb68fc3d","line":117,"in_reply_to":"1c53504a_4f93cafb","updated":"2023-12-07 19:20:02.000000000","message":"++","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08f1ed17d6885346b244b50cd656e26a3e1a293b","unresolved":true,"context_lines":[{"line_number":194,"context_line":"            server, keypair, floating_ip)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class TestNetworkAdvancedServerOpsNotSpec(BaseTestNetworkAdvancedServerOps):"},{"line_number":198,"context_line":"    \"\"\"Check VM connectivity without specifying source and destination hosts:"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"     * Resize an instance"}],"source_content_type":"text/x-python","patch_set":14,"id":"b674644d_1c74bec6","line":197,"range":{"start_line":197,"start_character":6,"end_line":197,"end_character":41},"updated":"2023-11-21 19:08:52.000000000","message":"let\u0027s name it TestNetworkAdvancedServerMigration so that it is clear that this test class has the test for server migration","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"d5a973a4240ffbcea4158d1e05e59640be5b3515","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            server, keypair, floating_ip)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class TestNetworkAdvancedServerOpsNotSpec(BaseTestNetworkAdvancedServerOps):"},{"line_number":198,"context_line":"    \"\"\"Check VM connectivity without specifying source and destination hosts:"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"     * Resize an instance"}],"source_content_type":"text/x-python","patch_set":14,"id":"9d442d7c_24cff234","line":197,"range":{"start_line":197,"start_character":6,"end_line":197,"end_character":41},"in_reply_to":"4b6b64fd_b8ca5afa","updated":"2023-11-27 19:44:53.000000000","message":"Done","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"140fe1521a0b5e6d3f5ac1e5700fcb2dd0892766","unresolved":true,"context_lines":[{"line_number":194,"context_line":"            server, keypair, floating_ip)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class TestNetworkAdvancedServerOpsNotSpec(BaseTestNetworkAdvancedServerOps):"},{"line_number":198,"context_line":"    \"\"\"Check VM connectivity without specifying source and destination hosts:"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"     * Resize an instance"}],"source_content_type":"text/x-python","patch_set":14,"id":"4b6b64fd_b8ca5afa","line":197,"range":{"start_line":197,"start_character":6,"end_line":197,"end_character":41},"in_reply_to":"b674644d_1c74bec6","updated":"2023-11-21 19:11:44.000000000","message":"I forgot to delete this comment, please see below comment of not creating this new class.","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f34a6870ada0f1caf2232029649a4e596e61921b","unresolved":true,"context_lines":[{"line_number":200,"context_line":"     * Resize an instance"},{"line_number":201,"context_line":"     * Migrate an instance"},{"line_number":202,"context_line":"    \"\"\""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u0027719eb59d-2f42-4b66-b8b1-bb1254473967\u0027)"},{"line_number":205,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.resize,"},{"line_number":206,"context_line":"                          \u0027Resize is not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"133b0888_c0d807cd","line":203,"updated":"2023-11-20 14:09:46.000000000","message":"path of the tests in this class was changed as they are in a new class named TestNetworkAdvancedServerOpsNotSpec (previously TestNetworkAdvancedServerOps)\n\nI\u0027m not sure how big deal this is:\n\nhttps://codesearch.opendev.org/?q\u003dtest_server_connectivity_resize\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\nThere is an occurrence in openstack-tempest-skiplist, x/trio2o and x/vmware-nsx-tempest-plugin\n\nhttps://codesearch.opendev.org/?q\u003dtest_server_connectivity_cold_migration\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\nopenstack-tempest-skiplist\n\nhttps://codesearch.opendev.org/?q\u003dtest_server_connectivity_live_migration\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\nopenstack-tempest-skiplist and devstack-plugin-ceph\n\nhttps://codesearch.opendev.org/?q\u003dtest_server_connectivity_cold_migration_revert\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\nThis is ok, only occurrence in Tempest","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"d5a973a4240ffbcea4158d1e05e59640be5b3515","unresolved":false,"context_lines":[{"line_number":200,"context_line":"     * Resize an instance"},{"line_number":201,"context_line":"     * Migrate an instance"},{"line_number":202,"context_line":"    \"\"\""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u0027719eb59d-2f42-4b66-b8b1-bb1254473967\u0027)"},{"line_number":205,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.resize,"},{"line_number":206,"context_line":"                          \u0027Resize is not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"8d061abb_40490a47","line":203,"in_reply_to":"02e3774a_273d09eb","updated":"2023-11-27 19:44:53.000000000","message":"Done","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08f1ed17d6885346b244b50cd656e26a3e1a293b","unresolved":true,"context_lines":[{"line_number":200,"context_line":"     * Resize an instance"},{"line_number":201,"context_line":"     * Migrate an instance"},{"line_number":202,"context_line":"    \"\"\""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u0027719eb59d-2f42-4b66-b8b1-bb1254473967\u0027)"},{"line_number":205,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.resize,"},{"line_number":206,"context_line":"                          \u0027Resize is not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"02e3774a_273d09eb","line":203,"in_reply_to":"133b0888_c0d807cd","updated":"2023-11-21 19:08:52.000000000","message":"I think we do not need to change the path. let\u0027s keep it in same way as it was before.\n\nRemember that Tempest test users can be outside of OpenStack code path, in testing scripts at downstream, production and they might be using the test path to run/skip the tests. so unless it is mandatory, we should avoid using the test path.","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08f1ed17d6885346b244b50cd656e26a3e1a293b","unresolved":true,"context_lines":[{"line_number":206,"context_line":"                          \u0027Resize is not available.\u0027)"},{"line_number":207,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":208,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":209,"context_line":"    def test_server_connectivity_resize(self):"},{"line_number":210,"context_line":"        resize_flavor \u003d CONF.compute.flavor_ref_alt"},{"line_number":211,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":212,"context_line":"        server \u003d self._setup_server(keypair)"},{"line_number":213,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":214,"context_line":"        self.servers_client.resize_server(server[\u0027id\u0027],"},{"line_number":215,"context_line":"                                          flavor_ref\u003dresize_flavor)"},{"line_number":216,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":217,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":218,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":219,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":220,"context_line":"        # Nova API \u003e 2.46 no longer includes flavor.id, and schema check"},{"line_number":221,"context_line":"        # will cover whether \u0027id\u0027 should be in flavor"},{"line_number":222,"context_line":"        if server[\u0027flavor\u0027].get(\u0027id\u0027):"},{"line_number":223,"context_line":"            self.assertEqual(resize_flavor, server[\u0027flavor\u0027][\u0027id\u0027])"},{"line_number":224,"context_line":"        else:"},{"line_number":225,"context_line":"            flavor \u003d self.flavors_client.show_flavor(resize_flavor)[\u0027flavor\u0027]"},{"line_number":226,"context_line":"            self.assertEqual(flavor[\u0027name\u0027], server[\u0027flavor\u0027][\u0027original_name\u0027])"},{"line_number":227,"context_line":"            for key in [\u0027ram\u0027, \u0027vcpus\u0027, \u0027disk\u0027]:"},{"line_number":228,"context_line":"                self.assertEqual(flavor[key], server[\u0027flavor\u0027][key])"},{"line_number":229,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":230,"context_line":"            server, keypair, floating_ip)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    @decorators.idempotent_id(\u0027a4858f6c-401e-4155-9a49-d5cd053d1a2f\u0027)"},{"line_number":233,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9516567f_45464682","line":230,"range":{"start_line":209,"start_character":0,"end_line":230,"end_character":41},"updated":"2023-11-21 19:08:52.000000000","message":"because this test most of the code is used in two test class, let\u0027s reuse them by moving to base class. something like below:\n\nBelow common function in BaseTestNetworkAdvancedServerOps\n\n    def _test_server_connectivity_resize(self, src_host\u003dNone):\n        resize_flavor \u003d CONF.compute.flavor_ref_alt\n        keypair \u003d self.create_keypair()\n        server \u003d self._setup_server(keypair, src_host)\n        if src_host:\n            server_host \u003d self.get_host_for_server(server[\u0027id\u0027])\n            self.assertEqual(server_host, src_host)\n        floating_ip \u003d self._setup_network(server, keypair)\n        self.servers_client.resize_server(server[\u0027id\u0027],\n                                          flavor_ref\u003dresize_flavor)\n        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],\n                                       \u0027VERIFY_RESIZE\u0027)\n        self.servers_client.confirm_resize_server(server[\u0027id\u0027])\n        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]\n        # Nova API \u003e 2.46 no longer includes flavor.id, and schema check\n        # will cover whether \u0027id\u0027 should be in flavor\n        if server[\u0027flavor\u0027].get(\u0027id\u0027):\n            self.assertEqual(resize_flavor, server[\u0027flavor\u0027][\u0027id\u0027])\n        else:\n            flavor \u003d self.flavors_client.show_flavor(resize_flavor)[\u0027flavor\u0027]\n            self.assertEqual(flavor[\u0027name\u0027], server[\u0027flavor\u0027][\u0027original_name\u0027])\n            for key in [\u0027ram\u0027, \u0027vcpus\u0027, \u0027disk\u0027]:\n                self.assertEqual(flavor[key], server[\u0027flavor\u0027][key])\n        self._wait_server_status_and_check_network_connectivity(\n            server, keypair, floating_ip)\n            \n            \n    def _test_server_connectivity_cold_migration(self, source_host\u003dNone, dest_host\u003dNone):\n        keypair \u003d self.create_keypair()\n        server \u003d self._setup_server(keypair, source_host)\n        floating_ip \u003d self._setup_network(server, keypair)\n        src_host\u003d self.get_host_for_server(server[\u0027id\u0027])\n        if source_host:\n            self.assertEqual(src_host, source_host)\n        self._wait_server_status_and_check_network_connectivity(\n            server, keypair, floating_ip)\n\n        self.admin_servers_client.migrate_server(\n            server[\u0027id\u0027], host\u003ddest_host)\n        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],\n                                       \u0027VERIFY_RESIZE\u0027)\n        self.servers_client.confirm_resize_server(server[\u0027id\u0027])\n        self._wait_server_status_and_check_network_connectivity(\n            server, keypair, floating_ip)\n        dst_host \u003d self.get_host_for_server(server[\u0027id\u0027])\n        if dest_host:\n            self.assertEqual(dst_host, dest_host)\n        self.assertNotEqual(src_host, dst_host)\n\n\nand now TestNetworkAdvancedServerOps can use this code in their test without passing the source and dest host:\n\n\n    @decorators.idempotent_id(\u0027719eb59d-2f42-4b66-b8b1-bb1254473967\u0027)\n    @testtools.skipUnless(CONF.compute_feature_enabled.resize,\n                          \u0027Resize is not available.\u0027)\n    @decorators.attr(type\u003d\u0027slow\u0027)\n    @utils.services(\u0027compute\u0027, \u0027network\u0027)\n    def test_server_connectivity_resize(self):\n        self._test_server_connectivity_resize()\n    \n    @decorators.idempotent_id(\u0027a4858f6c-401e-4155-9a49-d5cd053d1a2f\u0027)\n    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,\n                          \u0027Cold migration is not available.\u0027)\n    @testtools.skipUnless(CONF.compute.min_compute_nodes \u003e 1,\n                          \u0027Less than 2 compute nodes, skipping multinode \u0027\n                          \u0027tests.\u0027)\n    @decorators.attr(type\u003d[\u0027slow\u0027, \u0027multinode\u0027])\n    @utils.services(\u0027compute\u0027, \u0027network\u0027)\n    def test_server_connectivity_cold_migration(self):\n        self_test_server_connectivity_cold_migration()\n        \n        \n        \nand new test class TestNetworkAdvancedServerMigrationWithHost can use this code in their test with passing the source and dest host:\n\n    @decorators.idempotent_id(\u002706e23934-79ae-11ee-b962-0242ac120002\u0027)\n    @testtools.skipUnless(CONF.compute_feature_enabled.resize,\n                          \u0027Resize is not available.\u0027)\n    @decorators.attr(type\u003d\u0027slow\u0027)\n    @utils.services(\u0027compute\u0027, \u0027network\u0027)\n    def test_server_connectivity_resize(self):\n        source_host \u003d CONF.compute.migration_source_host\n        self._test_server_connectivity_resize(source_host\u003dsource_host)\n        \n        \n    @decorators.idempotent_id(\u002714f0c9e6-79ae-11ee-b962-0242ac120002\u0027)\n    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,\n                          \u0027Cold migration is not available.\u0027)\n    @testtools.skipUnless(CONF.compute.min_compute_nodes \u003e 1,\n                          \u0027Less than 2 compute nodes, skipping multinode \u0027\n                          \u0027tests.\u0027)\n    @decorators.attr(type\u003d[\u0027slow\u0027, \u0027multinode\u0027])\n    @utils.services(\u0027compute\u0027, \u0027network\u0027)\n    def test_server_connectivity_cold_migration(self):\n        source_host \u003d CONF.compute.migration_source_host\n        dest_host\u003d CONF.compute.migration_dest_host\n        self_test_server_connectivity_cold_migration(source_host\u003dsource_host, dest_host\u003ddest_host)\n        \n        \n        \n        \nSimilar way for other two migration tests","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"d5a973a4240ffbcea4158d1e05e59640be5b3515","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                          \u0027Resize is not available.\u0027)"},{"line_number":207,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":208,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":209,"context_line":"    def test_server_connectivity_resize(self):"},{"line_number":210,"context_line":"        resize_flavor \u003d CONF.compute.flavor_ref_alt"},{"line_number":211,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":212,"context_line":"        server \u003d self._setup_server(keypair)"},{"line_number":213,"context_line":"        floating_ip \u003d self._setup_network(server, keypair)"},{"line_number":214,"context_line":"        self.servers_client.resize_server(server[\u0027id\u0027],"},{"line_number":215,"context_line":"                                          flavor_ref\u003dresize_flavor)"},{"line_number":216,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":217,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":218,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":219,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":220,"context_line":"        # Nova API \u003e 2.46 no longer includes flavor.id, and schema check"},{"line_number":221,"context_line":"        # will cover whether \u0027id\u0027 should be in flavor"},{"line_number":222,"context_line":"        if server[\u0027flavor\u0027].get(\u0027id\u0027):"},{"line_number":223,"context_line":"            self.assertEqual(resize_flavor, server[\u0027flavor\u0027][\u0027id\u0027])"},{"line_number":224,"context_line":"        else:"},{"line_number":225,"context_line":"            flavor \u003d self.flavors_client.show_flavor(resize_flavor)[\u0027flavor\u0027]"},{"line_number":226,"context_line":"            self.assertEqual(flavor[\u0027name\u0027], server[\u0027flavor\u0027][\u0027original_name\u0027])"},{"line_number":227,"context_line":"            for key in [\u0027ram\u0027, \u0027vcpus\u0027, \u0027disk\u0027]:"},{"line_number":228,"context_line":"                self.assertEqual(flavor[key], server[\u0027flavor\u0027][key])"},{"line_number":229,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":230,"context_line":"            server, keypair, floating_ip)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    @decorators.idempotent_id(\u0027a4858f6c-401e-4155-9a49-d5cd053d1a2f\u0027)"},{"line_number":233,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"}],"source_content_type":"text/x-python","patch_set":14,"id":"c3e047f9_49ebaa9e","line":230,"range":{"start_line":209,"start_character":0,"end_line":230,"end_character":41},"in_reply_to":"9516567f_45464682","updated":"2023-11-27 19:44:53.000000000","message":"Done","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08f1ed17d6885346b244b50cd656e26a3e1a293b","unresolved":true,"context_lines":[{"line_number":339,"context_line":"        self.assertEqual(src_host, dst_host)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"class TestNetworkAdvancedServerOpsSpec(BaseTestNetworkAdvancedServerOps):"},{"line_number":343,"context_line":"    \"\"\"Check VM connectivity with specifying source and destination hosts:"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"     * Resize an instance"}],"source_content_type":"text/x-python","patch_set":14,"id":"99c6a442_224c9b05","line":342,"range":{"start_line":342,"start_character":39,"end_line":342,"end_character":71},"updated":"2023-11-21 19:08:52.000000000","message":"let\u0027s name this too TestNetworkAdvancedServerMigrationWithHost\n\nalso inherit this from TestNetworkAdvancedServerOpsNotSpec (new name TestNetworkAdvancedServerMigration ) so that we can reuse the test code instead of dulicating the same.","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"682d32f0a3b22b3022acfee2433ff13f6029ca3a","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self.assertEqual(src_host, dst_host)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"class TestNetworkAdvancedServerOpsSpec(BaseTestNetworkAdvancedServerOps):"},{"line_number":343,"context_line":"    \"\"\"Check VM connectivity with specifying source and destination hosts:"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"     * Resize an instance"}],"source_content_type":"text/x-python","patch_set":14,"id":"f2c98217_b01e1b05","line":342,"range":{"start_line":342,"start_character":39,"end_line":342,"end_character":71},"in_reply_to":"99c6a442_224c9b05","updated":"2023-12-07 19:20:02.000000000","message":"done","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08f1ed17d6885346b244b50cd656e26a3e1a293b","unresolved":true,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"class TestNetworkAdvancedServerOpsSpec(BaseTestNetworkAdvancedServerOps):"},{"line_number":343,"context_line":"    \"\"\"Check VM connectivity with specifying source and destination hosts:"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"     * Resize an instance"},{"line_number":346,"context_line":"     * Migrate an instance"},{"line_number":347,"context_line":"    \"\"\""},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"34124d7e_fca4f91b","line":346,"range":{"start_line":343,"start_character":0,"end_line":346,"end_character":10},"updated":"2023-11-21 19:08:52.000000000","message":"something like below\n\n    \"\"\"Check VM connectivity with specifying source and destination hosts to the server migration operations:\n\n     * Resize an instance by creating server on configured source host\n     * Migrate server by creating it on configured source host and migrate to configured destination host\n     ** Cold Migration\n     ** Cold Migration with revert\n     ** Live Migration","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"d5a973a4240ffbcea4158d1e05e59640be5b3515","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"class TestNetworkAdvancedServerOpsSpec(BaseTestNetworkAdvancedServerOps):"},{"line_number":343,"context_line":"    \"\"\"Check VM connectivity with specifying source and destination hosts:"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"     * Resize an instance"},{"line_number":346,"context_line":"     * Migrate an instance"},{"line_number":347,"context_line":"    \"\"\""},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"277ef65e_9b3fdfcb","line":346,"range":{"start_line":343,"start_character":0,"end_line":346,"end_character":10},"in_reply_to":"34124d7e_fca4f91b","updated":"2023-11-27 19:44:53.000000000","message":"Done","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08f1ed17d6885346b244b50cd656e26a3e1a293b","unresolved":true,"context_lines":[{"line_number":351,"context_line":"        super().skip_checks()"},{"line_number":352,"context_line":"        if \u0027admin\u0027 not in CONF.auth.tempest_roles:"},{"line_number":353,"context_line":"            raise cls.skipException(\"admin role is required\")"},{"line_number":354,"context_line":"        if not CONF.compute.min_microversion \u003e\u003d \u00272.74\u0027:"},{"line_number":355,"context_line":"            raise cls.skipException(\"microversion must be \u003e\u003d 2.74\")"},{"line_number":356,"context_line":"        if not (CONF.compute.migration_source_host or"},{"line_number":357,"context_line":"                CONF.compute.migration_dest_host):"},{"line_number":358,"context_line":"            raise cls.skipException(\"migration_source_host or \""}],"source_content_type":"text/x-python","patch_set":14,"id":"d050bcba_fb5330fb","line":355,"range":{"start_line":354,"start_character":0,"end_line":355,"end_character":67},"updated":"2023-11-21 19:08:52.000000000","message":"you need to add min_microversion in the test class level so that we can check configuration as well as available microversion in nova service,\n\nclass TestNetworkAdvancedServerOpsSpec(BaseTestNetworkAdvancedServerOps):\n    compute_min_microversion \u003d \u00272.74\u0027","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"d5a973a4240ffbcea4158d1e05e59640be5b3515","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        super().skip_checks()"},{"line_number":352,"context_line":"        if \u0027admin\u0027 not in CONF.auth.tempest_roles:"},{"line_number":353,"context_line":"            raise cls.skipException(\"admin role is required\")"},{"line_number":354,"context_line":"        if not CONF.compute.min_microversion \u003e\u003d \u00272.74\u0027:"},{"line_number":355,"context_line":"            raise cls.skipException(\"microversion must be \u003e\u003d 2.74\")"},{"line_number":356,"context_line":"        if not (CONF.compute.migration_source_host or"},{"line_number":357,"context_line":"                CONF.compute.migration_dest_host):"},{"line_number":358,"context_line":"            raise cls.skipException(\"migration_source_host or \""}],"source_content_type":"text/x-python","patch_set":14,"id":"8a5ded47_fece49e4","line":355,"range":{"start_line":354,"start_character":0,"end_line":355,"end_character":67},"in_reply_to":"d050bcba_fb5330fb","updated":"2023-11-27 19:44:53.000000000","message":"Done","commit_id":"e34805825e99206667340db988750b34cd5fd672"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"682d32f0a3b22b3022acfee2433ff13f6029ca3a","unresolved":true,"context_lines":[{"line_number":381,"context_line":"    @classmethod"},{"line_number":382,"context_line":"    def skip_checks(cls):"},{"line_number":383,"context_line":"        super().skip_checks()"},{"line_number":384,"context_line":"        if \u0027admin\u0027 not in CONF.auth.tempest_roles:"},{"line_number":385,"context_line":"            raise cls.skipException(\"admin role is required\")"},{"line_number":386,"context_line":"        if not float(CONF.compute.min_microversion) \u003e\u003d 2.74:"},{"line_number":387,"context_line":"            raise cls.skipException(\"microversion must be \u003e\u003d 2.74\")"},{"line_number":388,"context_line":"        if not (CONF.compute.migration_source_host or"}],"source_content_type":"text/x-python","patch_set":18,"id":"3028586f_9452cc4a","line":385,"range":{"start_line":384,"start_character":0,"end_line":385,"end_character":61},"updated":"2023-12-07 19:20:02.000000000","message":"these tests are not running because of this condition which is not correct as we do not configure \u0027admin\u0027 in CONF.auth.tempest_roles instead we assign the admin role for tests require it. \n\nAlso we do not need to check admin role condition in scenario tests and old tests also needed admin so it is ok to not check it.\n\nhttps://zuul.opendev.org/t/openstack/build/25cbe9132a3446bebcb71800ca0aeaf6/log/job-output.txt#33976","commit_id":"0fddf67cec3a400bbb50346a4ad65bbbe716830e"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"e86d3c54687c9bf2941d09ae85639c3f666d3438","unresolved":true,"context_lines":[{"line_number":381,"context_line":"    @classmethod"},{"line_number":382,"context_line":"    def skip_checks(cls):"},{"line_number":383,"context_line":"        super().skip_checks()"},{"line_number":384,"context_line":"        if \u0027admin\u0027 not in CONF.auth.tempest_roles:"},{"line_number":385,"context_line":"            raise cls.skipException(\"admin role is required\")"},{"line_number":386,"context_line":"        if not float(CONF.compute.min_microversion) \u003e\u003d 2.74:"},{"line_number":387,"context_line":"            raise cls.skipException(\"microversion must be \u003e\u003d 2.74\")"},{"line_number":388,"context_line":"        if not (CONF.compute.migration_source_host or"}],"source_content_type":"text/x-python","patch_set":18,"id":"4017390b_457df922","line":385,"range":{"start_line":384,"start_character":0,"end_line":385,"end_character":61},"in_reply_to":"3028586f_9452cc4a","updated":"2023-12-11 15:24:37.000000000","message":"I added it there mainly because in this new test class we added parameter host for creating server in function _setup_server. On this site -\u003e https://docs.openstack.org/api-ref/compute/#create-server in host parameter its said that it can be specified by administrators only, so i think those tests would fail without this.","commit_id":"0fddf67cec3a400bbb50346a4ad65bbbe716830e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b92a2e52f126957642fc0b0d372b31486bbb11d7","unresolved":true,"context_lines":[{"line_number":381,"context_line":"    @classmethod"},{"line_number":382,"context_line":"    def skip_checks(cls):"},{"line_number":383,"context_line":"        super().skip_checks()"},{"line_number":384,"context_line":"        if \u0027admin\u0027 not in CONF.auth.tempest_roles:"},{"line_number":385,"context_line":"            raise cls.skipException(\"admin role is required\")"},{"line_number":386,"context_line":"        if not float(CONF.compute.min_microversion) \u003e\u003d 2.74:"},{"line_number":387,"context_line":"            raise cls.skipException(\"microversion must be \u003e\u003d 2.74\")"},{"line_number":388,"context_line":"        if not (CONF.compute.migration_source_host or"}],"source_content_type":"text/x-python","patch_set":18,"id":"f615f2c5_eb1363dd","line":385,"range":{"start_line":384,"start_character":0,"end_line":385,"end_character":61},"in_reply_to":"4017390b_457df922","updated":"2023-12-18 19:13:49.000000000","message":"I get your point but I am saying all scenario test has the admin creds[1] so if no admin is created for these test then it will fail in base test class setup only.\n\nCONF.auth.tempest_roles is a kind of extra role if that needs to be assigned to all tempest users. so admin is not mandatory to be in this config value but still test will have admin creds\n\n[1] https://github.com/openstack/tempest/blob/ab3686d28d2728001e3bd2fd543575087bf00137/tempest/scenario/manager.py#L53","commit_id":"0fddf67cec3a400bbb50346a4ad65bbbe716830e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6a13e017b137f6e8af02b2c0b1956aec7349be2a","unresolved":false,"context_lines":[{"line_number":381,"context_line":"    @classmethod"},{"line_number":382,"context_line":"    def skip_checks(cls):"},{"line_number":383,"context_line":"        super().skip_checks()"},{"line_number":384,"context_line":"        if \u0027admin\u0027 not in CONF.auth.tempest_roles:"},{"line_number":385,"context_line":"            raise cls.skipException(\"admin role is required\")"},{"line_number":386,"context_line":"        if not float(CONF.compute.min_microversion) \u003e\u003d 2.74:"},{"line_number":387,"context_line":"            raise cls.skipException(\"microversion must be \u003e\u003d 2.74\")"},{"line_number":388,"context_line":"        if not (CONF.compute.migration_source_host or"}],"source_content_type":"text/x-python","patch_set":18,"id":"48d3dba2_129ae37e","line":385,"range":{"start_line":384,"start_character":0,"end_line":385,"end_character":61},"in_reply_to":"f615f2c5_eb1363dd","updated":"2024-01-16 09:52:36.000000000","message":"Done","commit_id":"0fddf67cec3a400bbb50346a4ad65bbbe716830e"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"81d4b8391ed254af5d0e96dc68a3b47690c87021","unresolved":false,"context_lines":[{"line_number":381,"context_line":"    @classmethod"},{"line_number":382,"context_line":"    def skip_checks(cls):"},{"line_number":383,"context_line":"        super().skip_checks()"},{"line_number":384,"context_line":"        if \u0027admin\u0027 not in CONF.auth.tempest_roles:"},{"line_number":385,"context_line":"            raise cls.skipException(\"admin role is required\")"},{"line_number":386,"context_line":"        if not float(CONF.compute.min_microversion) \u003e\u003d 2.74:"},{"line_number":387,"context_line":"            raise cls.skipException(\"microversion must be \u003e\u003d 2.74\")"},{"line_number":388,"context_line":"        if not (CONF.compute.migration_source_host or"}],"source_content_type":"text/x-python","patch_set":18,"id":"e21526cd_69bae45f","line":385,"range":{"start_line":384,"start_character":0,"end_line":385,"end_character":61},"in_reply_to":"f615f2c5_eb1363dd","updated":"2023-12-21 19:38:37.000000000","message":"OK, sorry for dumb questions, i didnt know about this, thanks :).","commit_id":"0fddf67cec3a400bbb50346a4ad65bbbe716830e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8693f12f7a3bdb1e657f91bc315796aab1d45504","unresolved":true,"context_lines":[{"line_number":376,"context_line":"        - Cold Migration with revert"},{"line_number":377,"context_line":"        - Live Migration"},{"line_number":378,"context_line":"    \"\"\""},{"line_number":379,"context_line":"    compute_min_microvers \u003d 2.74"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    @classmethod"},{"line_number":382,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":20,"id":"51031ffa_48eb9092","line":379,"range":{"start_line":379,"start_character":4,"end_line":379,"end_character":26},"updated":"2024-01-10 19:38:05.000000000","message":"s/compute_min_microvers/compute_min_microversion\n\nSeeing this typo, I think we should run these test with sor and dest host set from devstack side in some jobs. otherwise t is very difficult to know if these test work or not.","commit_id":"11089c2075a4535751ec7d1b6839b12bdf8cb8d4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6a13e017b137f6e8af02b2c0b1956aec7349be2a","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        - Cold Migration with revert"},{"line_number":377,"context_line":"        - Live Migration"},{"line_number":378,"context_line":"    \"\"\""},{"line_number":379,"context_line":"    compute_min_microvers \u003d 2.74"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    @classmethod"},{"line_number":382,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":20,"id":"f0718b56_82601903","line":379,"range":{"start_line":379,"start_character":4,"end_line":379,"end_character":26},"in_reply_to":"51031ffa_48eb9092","updated":"2024-01-16 09:52:36.000000000","message":"good catch! thanks","commit_id":"11089c2075a4535751ec7d1b6839b12bdf8cb8d4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8693f12f7a3bdb1e657f91bc315796aab1d45504","unresolved":true,"context_lines":[{"line_number":381,"context_line":"    @classmethod"},{"line_number":382,"context_line":"    def skip_checks(cls):"},{"line_number":383,"context_line":"        super().skip_checks()"},{"line_number":384,"context_line":"        if not CONF.compute.min_microversion or \\"},{"line_number":385,"context_line":"            float(CONF.compute.min_microversion) \u003c cls.compute_min_microvers:"},{"line_number":386,"context_line":"            raise cls.skipException(\"microversion must be \u003e\u003d 2.74\")"},{"line_number":387,"context_line":"        if not (CONF.compute.migration_source_host or"},{"line_number":388,"context_line":"                CONF.compute.migration_dest_host):"},{"line_number":389,"context_line":"            raise cls.skipException(\"migration_source_host or \""}],"source_content_type":"text/x-python","patch_set":20,"id":"f148bc44_2427a17d","line":386,"range":{"start_line":384,"start_character":0,"end_line":386,"end_character":67},"updated":"2024-01-10 19:38:05.000000000","message":"this condition is also not needed as it will be checked by the base test class and utils methods","commit_id":"11089c2075a4535751ec7d1b6839b12bdf8cb8d4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6a13e017b137f6e8af02b2c0b1956aec7349be2a","unresolved":false,"context_lines":[{"line_number":381,"context_line":"    @classmethod"},{"line_number":382,"context_line":"    def skip_checks(cls):"},{"line_number":383,"context_line":"        super().skip_checks()"},{"line_number":384,"context_line":"        if not CONF.compute.min_microversion or \\"},{"line_number":385,"context_line":"            float(CONF.compute.min_microversion) \u003c cls.compute_min_microvers:"},{"line_number":386,"context_line":"            raise cls.skipException(\"microversion must be \u003e\u003d 2.74\")"},{"line_number":387,"context_line":"        if not (CONF.compute.migration_source_host or"},{"line_number":388,"context_line":"                CONF.compute.migration_dest_host):"},{"line_number":389,"context_line":"            raise cls.skipException(\"migration_source_host or \""}],"source_content_type":"text/x-python","patch_set":20,"id":"6b1b8502_0e46e6cd","line":386,"range":{"start_line":384,"start_character":0,"end_line":386,"end_character":67},"in_reply_to":"f148bc44_2427a17d","updated":"2024-01-16 09:52:36.000000000","message":"Done","commit_id":"11089c2075a4535751ec7d1b6839b12bdf8cb8d4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5b3c8d6530174358342a8fb6caefe80ec1eab3fa","unresolved":true,"context_lines":[{"line_number":376,"context_line":"        - Cold Migration with revert"},{"line_number":377,"context_line":"        - Live Migration"},{"line_number":378,"context_line":"    \"\"\""},{"line_number":379,"context_line":"    compute_min_microversion \u003d 2.74"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    @classmethod"},{"line_number":382,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":23,"id":"8f0bb396_125b9c93","line":379,"range":{"start_line":379,"start_character":31,"end_line":379,"end_character":35},"updated":"2024-02-08 05:08:07.000000000","message":"this need to be string as it is failing for that \n\n- https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_988/891123/23/check/tempest-slow-py3/988060f/testr_results.html","commit_id":"caed73d5e0b9a7ad26c56960a47c376e95b226f5"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"ad29907768e2c0f459db51c3ab90889ae34bb2ae","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        - Cold Migration with revert"},{"line_number":377,"context_line":"        - Live Migration"},{"line_number":378,"context_line":"    \"\"\""},{"line_number":379,"context_line":"    compute_min_microversion \u003d 2.74"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    @classmethod"},{"line_number":382,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":23,"id":"f48f6328_2b31e290","line":379,"range":{"start_line":379,"start_character":31,"end_line":379,"end_character":35},"in_reply_to":"8f0bb396_125b9c93","updated":"2024-02-08 14:04:06.000000000","message":"Done","commit_id":"caed73d5e0b9a7ad26c56960a47c376e95b226f5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e6e11f633025a831cb6efaa1fbee0552bd63236c","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        if host_spec is not None:"},{"line_number":69,"context_line":"            server_args[\u0027host\u0027] \u003d host_spec"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        server \u003d self.create_server(**server_args)"},{"line_number":72,"context_line":"        return server"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _setup_network(self, server, keypair):"}],"source_content_type":"text/x-python","patch_set":26,"id":"6f72bf0d_ecca640f","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":50},"updated":"2024-02-14 20:04:22.000000000","message":"here, create_server use the non-admin creds for new tests also https://github.com/openstack/tempest/blob/0edee3b8d88440960b8e35a8193034948d78ff97/tempest/scenario/manager.py#L253\n\nin case of host is specified, you can pass the admin crds in create_server and it will pass the policy","commit_id":"b835e10e780933c63b5456e35a8cabef8eaf14a2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b4c9365e407b74ea57bf208c33082904c917f874","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        if host_spec is not None:"},{"line_number":69,"context_line":"            server_args[\u0027host\u0027] \u003d host_spec"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        server \u003d self.create_server(**server_args)"},{"line_number":72,"context_line":"        return server"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _setup_network(self, server, keypair):"}],"source_content_type":"text/x-python","patch_set":26,"id":"ddd6793a_4f04f715","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":50},"in_reply_to":"6f72bf0d_ecca640f","updated":"2024-02-15 13:07:21.000000000","message":"Done","commit_id":"b835e10e780933c63b5456e35a8cabef8eaf14a2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"08f5882130dad25730461f8c69bd66ef0c20330e","unresolved":true,"context_lines":[{"line_number":50,"context_line":"            cls.os_primary.security_group_rules_client"},{"line_number":51,"context_line":"        cls.sec_groups_client \u003d cls.os_primary.security_groups_client"},{"line_number":52,"context_line":"        cls.keypairs_client \u003d cls.os_primary.keypairs_client"},{"line_number":53,"context_line":"        cls.floating_ips_client \u003d cls.os_primary.floating_ips_client"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @classmethod"},{"line_number":56,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":32,"id":"ce7516cc_bb7c6320","line":53,"updated":"2024-02-20 15:55:39.000000000","message":"cls.servers_client \u003d cls.os_primary.servers_client","commit_id":"607889a678d415f197b4eace2e9b6b317e162e62"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"637f6a83f0ea5d7cda8a6048957d1124e0f780e4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            cls.os_primary.security_group_rules_client"},{"line_number":51,"context_line":"        cls.sec_groups_client \u003d cls.os_primary.security_groups_client"},{"line_number":52,"context_line":"        cls.keypairs_client \u003d cls.os_primary.keypairs_client"},{"line_number":53,"context_line":"        cls.floating_ips_client \u003d cls.os_primary.floating_ips_client"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @classmethod"},{"line_number":56,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":32,"id":"80f5b7e0_cdb2bb30","line":53,"in_reply_to":"ce7516cc_bb7c6320","updated":"2024-02-26 09:47:00.000000000","message":"Done","commit_id":"607889a678d415f197b4eace2e9b6b317e162e62"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"08f5882130dad25730461f8c69bd66ef0c20330e","unresolved":true,"context_lines":[{"line_number":114,"context_line":"    def _wait_server_status_and_check_network_connectivity("},{"line_number":115,"context_line":"        self, server, keypair, floating_ip,"},{"line_number":116,"context_line":"        username\u003dCONF.validation.image_ssh_user):"},{"line_number":117,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":118,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":119,"context_line":"        self._check_network_connectivity(server, keypair, floating_ip,"},{"line_number":120,"context_line":"                                         username\u003dusername)"}],"source_content_type":"text/x-python","patch_set":32,"id":"7665a8cb_60292cb7","line":117,"range":{"start_line":117,"start_character":44,"end_line":117,"end_character":58},"updated":"2024-02-20 15:55:39.000000000","message":"it fails here because this client isn\u0027t an admin one","commit_id":"607889a678d415f197b4eace2e9b6b317e162e62"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"637f6a83f0ea5d7cda8a6048957d1124e0f780e4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def _wait_server_status_and_check_network_connectivity("},{"line_number":115,"context_line":"        self, server, keypair, floating_ip,"},{"line_number":116,"context_line":"        username\u003dCONF.validation.image_ssh_user):"},{"line_number":117,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":118,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":119,"context_line":"        self._check_network_connectivity(server, keypair, floating_ip,"},{"line_number":120,"context_line":"                                         username\u003dusername)"}],"source_content_type":"text/x-python","patch_set":32,"id":"6a0e1647_9956a884","line":117,"range":{"start_line":117,"start_character":44,"end_line":117,"end_character":58},"in_reply_to":"7665a8cb_60292cb7","updated":"2024-02-26 09:47:00.000000000","message":"Done","commit_id":"607889a678d415f197b4eace2e9b6b317e162e62"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"08f5882130dad25730461f8c69bd66ef0c20330e","unresolved":true,"context_lines":[{"line_number":414,"context_line":"            cls.os_admin.security_group_rules_client"},{"line_number":415,"context_line":"        cls.sec_groups_client \u003d cls.os_admin.security_groups_client"},{"line_number":416,"context_line":"        cls.keypairs_client \u003d cls.os_admin.keypairs_client"},{"line_number":417,"context_line":"        cls.floating_ips_client \u003d cls.os_admin.floating_ips_client"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    @decorators.idempotent_id(\u002706e23934-79ae-11ee-b962-0242ac120002\u0027)"},{"line_number":420,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.resize,"}],"source_content_type":"text/x-python","patch_set":32,"id":"13740b0d_7eb81e7b","line":417,"updated":"2024-02-20 15:55:39.000000000","message":"cls.servers_client \u003d cls.os_admin.servers_client","commit_id":"607889a678d415f197b4eace2e9b6b317e162e62"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"637f6a83f0ea5d7cda8a6048957d1124e0f780e4","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            cls.os_admin.security_group_rules_client"},{"line_number":415,"context_line":"        cls.sec_groups_client \u003d cls.os_admin.security_groups_client"},{"line_number":416,"context_line":"        cls.keypairs_client \u003d cls.os_admin.keypairs_client"},{"line_number":417,"context_line":"        cls.floating_ips_client \u003d cls.os_admin.floating_ips_client"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    @decorators.idempotent_id(\u002706e23934-79ae-11ee-b962-0242ac120002\u0027)"},{"line_number":420,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.resize,"}],"source_content_type":"text/x-python","patch_set":32,"id":"44817192_83ded35a","line":417,"in_reply_to":"13740b0d_7eb81e7b","updated":"2024-02-26 09:47:00.000000000","message":"Done","commit_id":"607889a678d415f197b4eace2e9b6b317e162e62"}],"zuul.d/integrated-gate.yaml":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"96f0e8daf8d3fdc4a69daa5918087bb8fbb6d860","unresolved":true,"context_lines":[{"line_number":265,"context_line":"      tempest_concurrency: 4"},{"line_number":266,"context_line":"      devstack_localrc:"},{"line_number":267,"context_line":"        USE_PYTHON3: true"},{"line_number":268,"context_line":"        TEMEPST_SET_SRC_DEST_HOST: true"},{"line_number":269,"context_line":"      devstack_plugins:"},{"line_number":270,"context_line":"        neutron: https://opendev.org/openstack/neutron"},{"line_number":271,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"596a5685_588c5ab9","line":268,"range":{"start_line":268,"start_character":8,"end_line":268,"end_character":33},"updated":"2024-02-08 23:33:11.000000000","message":"there is a typo - TEMEPST -\u003e TEMPEST","commit_id":"a1685f73e4a434fc4d94fd69afd640b592750e8c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"aa55a6c65ba2c75d62565ede931248142fa5b718","unresolved":false,"context_lines":[{"line_number":265,"context_line":"      tempest_concurrency: 4"},{"line_number":266,"context_line":"      devstack_localrc:"},{"line_number":267,"context_line":"        USE_PYTHON3: true"},{"line_number":268,"context_line":"        TEMEPST_SET_SRC_DEST_HOST: true"},{"line_number":269,"context_line":"      devstack_plugins:"},{"line_number":270,"context_line":"        neutron: https://opendev.org/openstack/neutron"},{"line_number":271,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"c2547224_e4dae912","line":268,"range":{"start_line":268,"start_character":8,"end_line":268,"end_character":33},"in_reply_to":"596a5685_588c5ab9","updated":"2024-02-12 14:04:40.000000000","message":"Done","commit_id":"a1685f73e4a434fc4d94fd69afd640b592750e8c"}]}