)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0df8591985f3c64bd971a0127a391777b4454c5d","unresolved":true,"context_lines":[{"line_number":14,"context_line":"the image so that it will be ensured that each test can"},{"line_number":15,"context_line":"utilize own image."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://etherpad.opendev.org/p/glance-temepst-race"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I235b2c253887d61dd97acfb4e9fff3186ed0d61b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ad93304a_ec49cd8d","line":17,"range":{"start_line":17,"start_character":42,"end_line":17,"end_character":49},"updated":"2023-08-28 07:52:08.000000000","message":"tempest?\n\nThere is no content in this or the glance-tempest-race etherpad","commit_id":"40942a09fee65bca36e9f289ff9361778e910889"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"40fabb7e5cbcc1b3c89e6e9b1f867ff5861b41ac","unresolved":true,"context_lines":[{"line_number":14,"context_line":"the image so that it will be ensured that each test can"},{"line_number":15,"context_line":"utilize own image."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://etherpad.opendev.org/p/glance-temepst-race"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I235b2c253887d61dd97acfb4e9fff3186ed0d61b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"28cad0d3_d5cb5119","line":17,"range":{"start_line":17,"start_character":42,"end_line":17,"end_character":49},"in_reply_to":"ad93304a_ec49cd8d","updated":"2023-08-28 08:35:22.000000000","message":"sorry, check now","commit_id":"40942a09fee65bca36e9f289ff9361778e910889"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dae91f9a650828162d2e9244fc73803e2ea313c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d7c0803b_44e3d960","updated":"2023-08-28 13:19:34.000000000","message":"For now this looks good to fix gate, but we still need to dig into the underlying problem why different tests are consuming the same image.","commit_id":"40942a09fee65bca36e9f289ff9361778e910889"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"aa83efa28dc9c6dc4feb92286700d9ed7cb61a0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f57d01e_7a33162e","updated":"2023-08-28 07:01:32.000000000","message":"See stats on patch https://review.opendev.org/c/openstack/glance/+/892732\n\n15 rechecks\ntotal 3 failures, 2 failures in cinder job but not with race condition.\nSo we can safely say that this resolves race condition mentioned in the commit message.","commit_id":"40942a09fee65bca36e9f289ff9361778e910889"}],"tempest/api/image/base.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0df8591985f3c64bd971a0127a391777b4454c5d","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            name \u003d data_utils.rand_name(cls.__name__ + \"-image\")"},{"line_number":55,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        if \u0027id\u0027 not in kwargs:"},{"line_number":58,"context_line":"            image_id \u003d data_utils.rand_uuid()"},{"line_number":59,"context_line":"            kwargs[\u0027id\u0027] \u003d image_id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        image \u003d cls.client.create_image(**kwargs)"},{"line_number":62,"context_line":"        cls.created_images.append(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"304ec79b_b226ccbf","line":59,"range":{"start_line":57,"start_character":0,"end_line":59,"end_character":35},"updated":"2023-08-28 07:52:08.000000000","message":"doesn\u0027t glance generate a UUID for the image? It seems strange to send UUID as a image parameter","commit_id":"40942a09fee65bca36e9f289ff9361778e910889"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"11dbd69be40e2cfbd62c2dd876d1a6e1c336bee7","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            name \u003d data_utils.rand_name(cls.__name__ + \"-image\")"},{"line_number":55,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        if \u0027id\u0027 not in kwargs:"},{"line_number":58,"context_line":"            image_id \u003d data_utils.rand_uuid()"},{"line_number":59,"context_line":"            kwargs[\u0027id\u0027] \u003d image_id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        image \u003d cls.client.create_image(**kwargs)"},{"line_number":62,"context_line":"        cls.created_images.append(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fff88efe_7b8326be","line":59,"range":{"start_line":57,"start_character":0,"end_line":59,"end_character":35},"in_reply_to":"304ec79b_b226ccbf","updated":"2023-08-28 08:22:05.000000000","message":"I thought of this as a quick solution, we have couple of places where we passing same uuid in glance to create the image. I think fixing that could be the best approach. Will try it and ran the rechecks again on DNM patch.\n\nhttps://github.com/openstack/tempest/blob/master/tempest/api/image/v2/test_images.py#L55\nhttps://github.com/openstack/tempest/blob/master/tempest/api/image/v2/test_images.py#L418","commit_id":"40942a09fee65bca36e9f289ff9361778e910889"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c940b284b9cb0fa472ffa52d996a110f06d25cff","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            name \u003d data_utils.rand_name(cls.__name__ + \"-image\")"},{"line_number":55,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        if \u0027id\u0027 not in kwargs:"},{"line_number":58,"context_line":"            image_id \u003d data_utils.rand_uuid()"},{"line_number":59,"context_line":"            kwargs[\u0027id\u0027] \u003d image_id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        image \u003d cls.client.create_image(**kwargs)"},{"line_number":62,"context_line":"        cls.created_images.append(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"cd064a04_cf6d2131","line":59,"range":{"start_line":57,"start_character":0,"end_line":59,"end_character":35},"in_reply_to":"6109bca1_a486a0a0","updated":"2023-09-14 14:49:24.000000000","message":"Unfortunately we allow it :)","commit_id":"40942a09fee65bca36e9f289ff9361778e910889"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f8ca1c274f838da8e62f79e1d72c7d46c11f6310","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            name \u003d data_utils.rand_name(cls.__name__ + \"-image\")"},{"line_number":55,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        if \u0027id\u0027 not in kwargs:"},{"line_number":58,"context_line":"            image_id \u003d data_utils.rand_uuid()"},{"line_number":59,"context_line":"            kwargs[\u0027id\u0027] \u003d image_id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        image \u003d cls.client.create_image(**kwargs)"},{"line_number":62,"context_line":"        cls.created_images.append(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"a2464bfa_a87a3012","line":59,"range":{"start_line":57,"start_character":0,"end_line":59,"end_character":35},"in_reply_to":"cd064a04_cf6d2131","updated":"2024-01-11 01:00:36.000000000","message":"yeah it seems strange to allow uuid as request param. I think that is more chance to have/use same image.\n\nI think glance should return 400 if anyone pass but depends on how backward incompatible change you consider that as it is allowed currently. Agree with Dan to have assert here to make sure no uuid is passed.","commit_id":"40942a09fee65bca36e9f289ff9361778e910889"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"53d24e8a206c1f72f4dba142de9657c3d7edd526","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            name \u003d data_utils.rand_name(cls.__name__ + \"-image\")"},{"line_number":55,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        if \u0027id\u0027 not in kwargs:"},{"line_number":58,"context_line":"            image_id \u003d data_utils.rand_uuid()"},{"line_number":59,"context_line":"            kwargs[\u0027id\u0027] \u003d image_id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        image \u003d cls.client.create_image(**kwargs)"},{"line_number":62,"context_line":"        cls.created_images.append(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"6109bca1_a486a0a0","line":59,"range":{"start_line":57,"start_character":0,"end_line":59,"end_character":35},"in_reply_to":"e5518388_ce39755b","updated":"2023-09-05 15:42:41.000000000","message":"Glance allows the user to specify the uuid when creating an image? That seems pretty scary to me. However, should we maybe assert that uuid is not in kwargs in this helper to avoid any test trying to provide it and thus hitting a potential conflict?","commit_id":"40942a09fee65bca36e9f289ff9361778e910889"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4f0455a5a1bb8cd8f874c412d517c553c66e2845","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            name \u003d data_utils.rand_name(cls.__name__ + \"-image\")"},{"line_number":55,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        if \u0027id\u0027 not in kwargs:"},{"line_number":58,"context_line":"            image_id \u003d data_utils.rand_uuid()"},{"line_number":59,"context_line":"            kwargs[\u0027id\u0027] \u003d image_id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        image \u003d cls.client.create_image(**kwargs)"},{"line_number":62,"context_line":"        cls.created_images.append(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"e5518388_ce39755b","line":59,"range":{"start_line":57,"start_character":0,"end_line":59,"end_character":35},"in_reply_to":"fff88efe_7b8326be","updated":"2023-08-28 08:32:30.000000000","message":"Ignore this comment, those hardcoded id\u0027s are not used as image id.\nI think we need to debug this further on why two tests are using same images, but this is a quick solution to ensure that will not happen.","commit_id":"40942a09fee65bca36e9f289ff9361778e910889"}]}