)]}'
{".coveragerc":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"44e5bfd170eb469b307883cb661b14743a2ce20e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[run]"},{"line_number":2,"context_line":"branch \u003d True"},{"line_number":3,"context_line":"source \u003d tempest"},{"line_number":4,"context_line":"omit \u003d tempest/tests/*,tempest/scenario/test_*.py,tempest/api/*,tempest/serial_tests/*"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"288bfe76_0913ade0","line":4,"range":{"start_line":4,"start_character":63,"end_line":4,"end_character":86},"updated":"2023-09-15 18:43:11.000000000","message":"++, thanks","commit_id":"547c0fb86f628c90eee3636c76b7c539a0fb48fd"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6244857c7705b1baf57f671a588bb5697da4ec81","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[run]"},{"line_number":2,"context_line":"branch \u003d True"},{"line_number":3,"context_line":"source \u003d tempest"},{"line_number":4,"context_line":"omit \u003d tempest/tests/*,tempest/scenario/test_*.py,tempest/api/*,tempest/serial_tests/*"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"848f047e_e1308a5c","line":4,"range":{"start_line":4,"start_character":63,"end_line":4,"end_character":86},"in_reply_to":"288bfe76_0913ade0","updated":"2023-10-05 06:17:43.000000000","message":"good catch!","commit_id":"547c0fb86f628c90eee3636c76b7c539a0fb48fd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"44e5bfd170eb469b307883cb661b14743a2ce20e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7b7994f0_502d885b","updated":"2023-09-15 18:43:11.000000000","message":"thanks for working on this, though it is in WIP but a few early feedback. nice start","commit_id":"547c0fb86f628c90eee3636c76b7c539a0fb48fd"},{"author":{"_account_id":36227,"name":"Katarina Strenkova","email":"kstrenko@redhat.com","username":"kstrenko"},"change_message_id":"30ac515ddfab349c94b7d937f0a430cabbe3318b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"29d265b7_da886e76","updated":"2023-10-03 13:20:09.000000000","message":"There is one flaky error which I\u0027m not exactly sure how it happens. I think it\u0027s something with the use of CONF in test_compute, but I wanted to hear some thoughts on this as I\u0027m kinda stuck there. Other than that, it should be ready to go.","commit_id":"4942524b5975b288d74ae16e56b15e3b301f3cd9"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c63522aa263a245ccde5d8f34003742d787412ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"24beb325_b5a9fff3","updated":"2023-10-05 06:14:45.000000000","message":"recheck unrelated failures","commit_id":"433dbdc4b96cefdc522aca493b4eebd10e050f49"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"00b70a1c6b3c3f0a5b448a764303d34505ebe617","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f2943bad_ee99e806","updated":"2023-10-09 18:26:00.000000000","message":"thanks","commit_id":"433dbdc4b96cefdc522aca493b4eebd10e050f49"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a60a9543770f6da300e2ca3a3f78466fd3eb4cc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5307ec51_bd109160","updated":"2023-10-05 06:16:20.000000000","message":"total unit test coverage is now 77%, amazing!! (previously 75%), what a nice improvement, thanks!","commit_id":"433dbdc4b96cefdc522aca493b4eebd10e050f49"}],"tempest/tests/common/test_compute.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"44e5bfd170eb469b307883cb661b14743a2ce20e","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        self.assertEqual(fake_server_ip, \"10.10.10.1\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_get_server_ip_connect_method_fixed(self):"},{"line_number":46,"context_line":"        fake_server \u003d {\u0027id\u0027: \u0027fake-uuid\u0027, "},{"line_number":47,"context_line":"                       \u0027addresses\u0027: \u0027\u0027}"},{"line_number":48,"context_line":"        # TODO fixed IP "},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"40c84413_39f8cf02","line":46,"range":{"start_line":46,"start_character":40,"end_line":46,"end_character":42},"updated":"2023-09-15 18:43:11.000000000","message":"remove the whitespace","commit_id":"547c0fb86f628c90eee3636c76b7c539a0fb48fd"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6244857c7705b1baf57f671a588bb5697da4ec81","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertEqual(fake_server_ip, \"10.10.10.1\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_get_server_ip_connect_method_fixed(self):"},{"line_number":46,"context_line":"        fake_server \u003d {\u0027id\u0027: \u0027fake-uuid\u0027, "},{"line_number":47,"context_line":"                       \u0027addresses\u0027: \u0027\u0027}"},{"line_number":48,"context_line":"        # TODO fixed IP "},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a478b9eb_50b5c651","line":46,"range":{"start_line":46,"start_character":40,"end_line":46,"end_character":42},"in_reply_to":"40c84413_39f8cf02","updated":"2023-10-05 06:17:43.000000000","message":"Done","commit_id":"547c0fb86f628c90eee3636c76b7c539a0fb48fd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"44e5bfd170eb469b307883cb661b14743a2ce20e","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    def test_get_server_ip_connect_method_fixed(self):"},{"line_number":46,"context_line":"        fake_server \u003d {\u0027id\u0027: \u0027fake-uuid\u0027, "},{"line_number":47,"context_line":"                       \u0027addresses\u0027: \u0027\u0027}"},{"line_number":48,"context_line":"        # TODO fixed IP "},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_rfp_frame_not_cached(self):"},{"line_number":51,"context_line":"        # rfp negotiation frame arrived separately after upgrade"}],"source_content_type":"text/x-python","patch_set":1,"id":"e16df115_d99c76ad","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":24},"updated":"2023-09-15 18:43:11.000000000","message":"ditto","commit_id":"547c0fb86f628c90eee3636c76b7c539a0fb48fd"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6244857c7705b1baf57f671a588bb5697da4ec81","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def test_get_server_ip_connect_method_fixed(self):"},{"line_number":46,"context_line":"        fake_server \u003d {\u0027id\u0027: \u0027fake-uuid\u0027, "},{"line_number":47,"context_line":"                       \u0027addresses\u0027: \u0027\u0027}"},{"line_number":48,"context_line":"        # TODO fixed IP "},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_rfp_frame_not_cached(self):"},{"line_number":51,"context_line":"        # rfp negotiation frame arrived separately after upgrade"}],"source_content_type":"text/x-python","patch_set":1,"id":"462d6711_0a7db2a8","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":24},"in_reply_to":"e16df115_d99c76ad","updated":"2023-10-05 06:17:43.000000000","message":"Done","commit_id":"547c0fb86f628c90eee3636c76b7c539a0fb48fd"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"175a53d1e9fd2b8332cb318cb1bbd57c3542e4c5","unresolved":true,"context_lines":[{"line_number":29,"context_line":"        super(TestCompute, self).setUp()"},{"line_number":30,"context_line":"        self.client_sock \u003d mock.Mock()"},{"line_number":31,"context_line":"        self.url \u003d urlparse.urlparse(\"http://www.fake.com:80\")"},{"line_number":32,"context_line":"        self.mock_conf \u003d config.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_get_server_ip_connect_method_floating(self):"},{"line_number":35,"context_line":"        fake_server \u003d {\u0027id\u0027: \u0027fake-uuid\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"2572e216_87d6203e","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":8},"updated":"2023-10-03 22:12:22.000000000","message":"this line is the problem, it somehow conflicts with this definition:\nhttps://opendev.org/openstack/tempest/src/commit/5c64e3913a1a5a061a6b04b212ce35aaa84f2184/tempest/common/compute.py#L35\n\nI would try mocking the CONF.validation.connect_method call to force there any value the test requires - that way you don\u0027t have to instantiate the CONF.\n\ncheck out this example:\nhttps://opendev.org/openinfra/python-tempestconf/src/commit/b5ae1f69acf67ce8cd4818e792af60869340c55e/config_tempest/tests/test_clients.py#L62-L67\n\n^^ whenever the function get_project_by_name calls list_projects (the mocked function) the test\u0027s custom return value will be forced back.","commit_id":"4942524b5975b288d74ae16e56b15e3b301f3cd9"},{"author":{"_account_id":36227,"name":"Katarina Strenkova","email":"kstrenko@redhat.com","username":"kstrenko"},"change_message_id":"14c6ea1eeada1b3d78a7e673c9b6755304fa179c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(TestCompute, self).setUp()"},{"line_number":30,"context_line":"        self.client_sock \u003d mock.Mock()"},{"line_number":31,"context_line":"        self.url \u003d urlparse.urlparse(\"http://www.fake.com:80\")"},{"line_number":32,"context_line":"        self.mock_conf \u003d config.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_get_server_ip_connect_method_floating(self):"},{"line_number":35,"context_line":"        fake_server \u003d {\u0027id\u0027: \u0027fake-uuid\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"4aebf589_ed83c91c","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":8},"in_reply_to":"2572e216_87d6203e","updated":"2023-10-04 13:12:56.000000000","message":"Thank you for the feedback. I will try to do the mocking and update this patch.","commit_id":"4942524b5975b288d74ae16e56b15e3b301f3cd9"}],"tempest/tests/common/test_waiters.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"44e5bfd170eb469b307883cb661b14743a2ce20e","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        time_mock.side_effect \u003d utils.generate_timeout_series(1)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        fake_server \u003d {\u0027id\u0027: \u0027fake-uuid\u0027,"},{"line_number":52,"context_line":"                       \u0027status\u0027: \u0027ACTIVE\u0027}"},{"line_number":53,"context_line":"        self.client.show_server.return_value \u003d ({\u0027server\u0027: fake_server})"},{"line_number":54,"context_line":"        self.assertRaises(lib_exc.TimeoutException,"},{"line_number":55,"context_line":"                          waiters.wait_for_server_status,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2482ff6c_ec4b11ef","line":52,"range":{"start_line":52,"start_character":34,"end_line":52,"end_character":40},"updated":"2023-09-15 18:43:11.000000000","message":"you need to have something else here like \u0027ERROR\u0027","commit_id":"547c0fb86f628c90eee3636c76b7c539a0fb48fd"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"60951209c9532880d33da87574b108586bf928d0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        time_mock.side_effect \u003d utils.generate_timeout_series(1)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        fake_server \u003d {\u0027id\u0027: \u0027fake-uuid\u0027,"},{"line_number":52,"context_line":"                       \u0027status\u0027: \u0027ACTIVE\u0027}"},{"line_number":53,"context_line":"        self.client.show_server.return_value \u003d ({\u0027server\u0027: fake_server})"},{"line_number":54,"context_line":"        self.assertRaises(lib_exc.TimeoutException,"},{"line_number":55,"context_line":"                          waiters.wait_for_server_status,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e8c89120_9ceece49","line":52,"range":{"start_line":52,"start_character":34,"end_line":52,"end_character":40},"in_reply_to":"2482ff6c_ec4b11ef","updated":"2023-10-05 08:06:00.000000000","message":"I think there is no SAVING status for servers in openstack but SAVING should work for this unit test.","commit_id":"547c0fb86f628c90eee3636c76b7c539a0fb48fd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"44e5bfd170eb469b307883cb661b14743a2ce20e","unresolved":true,"context_lines":[{"line_number":216,"context_line":"            {\u0027status\u0027: \u0027processing\u0027})"},{"line_number":217,"context_line":"        self.assertRaises(lib_exc.TimeoutException,"},{"line_number":218,"context_line":"                          waiters.wait_for_tasks_status,"},{"line_number":219,"context_line":"                          self.client, \u0027fake_task_id\u0027, \u0027success\u0027)    "},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"class TestInterfaceWaiters(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"6ce6b67d_a0362a37","line":219,"range":{"start_line":219,"start_character":65,"end_line":219,"end_character":69},"updated":"2023-09-15 18:43:11.000000000","message":"ditto","commit_id":"547c0fb86f628c90eee3636c76b7c539a0fb48fd"},{"author":{"_account_id":36227,"name":"Katarina Strenkova","email":"kstrenko@redhat.com","username":"kstrenko"},"change_message_id":"db7e528d96e0d36ab51e8134d7b817501e56dc08","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            {\u0027status\u0027: \u0027processing\u0027})"},{"line_number":217,"context_line":"        self.assertRaises(lib_exc.TimeoutException,"},{"line_number":218,"context_line":"                          waiters.wait_for_tasks_status,"},{"line_number":219,"context_line":"                          self.client, \u0027fake_task_id\u0027, \u0027success\u0027)    "},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"class TestInterfaceWaiters(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"77a72d0e_ce631621","line":219,"range":{"start_line":219,"start_character":65,"end_line":219,"end_character":69},"in_reply_to":"6ce6b67d_a0362a37","updated":"2023-10-06 08:54:50.000000000","message":"Done","commit_id":"547c0fb86f628c90eee3636c76b7c539a0fb48fd"}],"tox.ini":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"44e5bfd170eb469b307883cb661b14743a2ce20e","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  coverage combine"},{"line_number":65,"context_line":"  coverage html -d cover"},{"line_number":66,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":67,"context_line":"  coverage report -m --fail-under\u003d75"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"[testenv:debug]"},{"line_number":70,"context_line":"commands \u003d oslo_debug_helper -t tempest/tests {posargs}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"70e0cc0e_beb1f0c6","line":67,"range":{"start_line":67,"start_character":18,"end_line":67,"end_character":36},"updated":"2023-09-15 18:43:11.000000000","message":"++","commit_id":"547c0fb86f628c90eee3636c76b7c539a0fb48fd"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6244857c7705b1baf57f671a588bb5697da4ec81","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  coverage combine"},{"line_number":65,"context_line":"  coverage html -d cover"},{"line_number":66,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":67,"context_line":"  coverage report -m --fail-under\u003d75"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"[testenv:debug]"},{"line_number":70,"context_line":"commands \u003d oslo_debug_helper -t tempest/tests {posargs}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"99f306ae_98f80bb0","line":67,"range":{"start_line":67,"start_character":18,"end_line":67,"end_character":36},"in_reply_to":"70e0cc0e_beb1f0c6","updated":"2023-10-05 06:17:43.000000000","message":"Done","commit_id":"547c0fb86f628c90eee3636c76b7c539a0fb48fd"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6244857c7705b1baf57f671a588bb5697da4ec81","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  coverage combine"},{"line_number":65,"context_line":"  coverage html -d cover"},{"line_number":66,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":67,"context_line":"  coverage report -m --fail-under\u003d76"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"[testenv:debug]"},{"line_number":70,"context_line":"commands \u003d oslo_debug_helper -t tempest/tests {posargs}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"bf13d404_caf20736","line":67,"range":{"start_line":67,"start_character":34,"end_line":67,"end_character":36},"updated":"2023-10-05 06:17:43.000000000","message":"it seems it could be 77","commit_id":"433dbdc4b96cefdc522aca493b4eebd10e050f49"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b03b8433cee10f183c6d9281ae2531d19dd9dc57","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  coverage combine"},{"line_number":65,"context_line":"  coverage html -d cover"},{"line_number":66,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":67,"context_line":"  coverage report -m --fail-under\u003d76"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"[testenv:debug]"},{"line_number":70,"context_line":"commands \u003d oslo_debug_helper -t tempest/tests {posargs}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"b9604e6f_581b8c8d","line":67,"range":{"start_line":67,"start_character":34,"end_line":67,"end_character":36},"in_reply_to":"3a32f0e0_71cbcada","updated":"2023-10-06 08:27:38.000000000","message":"Let\u0027s try it again. I\u0027ve run tox -ecover locally with this change and I got 77 %.","commit_id":"433dbdc4b96cefdc522aca493b4eebd10e050f49"},{"author":{"_account_id":36227,"name":"Katarina Strenkova","email":"kstrenko@redhat.com","username":"kstrenko"},"change_message_id":"4d985ce756847612aa80ed6eedfd6285e4b821b6","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  coverage combine"},{"line_number":65,"context_line":"  coverage html -d cover"},{"line_number":66,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":67,"context_line":"  coverage report -m --fail-under\u003d76"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"[testenv:debug]"},{"line_number":70,"context_line":"commands \u003d oslo_debug_helper -t tempest/tests {posargs}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"ef1b7701_c9d1d686","line":67,"range":{"start_line":67,"start_character":34,"end_line":67,"end_character":36},"in_reply_to":"b9604e6f_581b8c8d","updated":"2023-10-06 09:22:04.000000000","message":"I still have 76% locally :( Even after trying different things to get the 77%.. I am not sure what is the problem to be honest. Do you think we should raise it to 77% either way?","commit_id":"433dbdc4b96cefdc522aca493b4eebd10e050f49"},{"author":{"_account_id":36227,"name":"Katarina Strenkova","email":"kstrenko@redhat.com","username":"kstrenko"},"change_message_id":"ba6b8eb1528dfec59dea23b8625bbed4167f8379","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  coverage combine"},{"line_number":65,"context_line":"  coverage html -d cover"},{"line_number":66,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":67,"context_line":"  coverage report -m --fail-under\u003d76"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"[testenv:debug]"},{"line_number":70,"context_line":"commands \u003d oslo_debug_helper -t tempest/tests {posargs}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"3a32f0e0_71cbcada","line":67,"range":{"start_line":67,"start_character":34,"end_line":67,"end_character":36},"in_reply_to":"bf13d404_caf20736","updated":"2023-10-06 07:33:25.000000000","message":"When I run it, the coverage is 76%, although I think it\u0027s close to 77%. I don\u0027t know if putting it to --fail-under\u003d77 will be ideal,as the tox -e cover fails before any changes are made.","commit_id":"433dbdc4b96cefdc522aca493b4eebd10e050f49"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c76f6cb199dd5e2c106b30532e7d0104da2b114c","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  coverage combine"},{"line_number":65,"context_line":"  coverage html -d cover"},{"line_number":66,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":67,"context_line":"  coverage report -m --fail-under\u003d76"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"[testenv:debug]"},{"line_number":70,"context_line":"commands \u003d oslo_debug_helper -t tempest/tests {posargs}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"9029418b_ccc34195","line":67,"range":{"start_line":67,"start_character":34,"end_line":67,"end_character":36},"in_reply_to":"ef1b7701_c9d1d686","updated":"2023-10-08 10:59:22.000000000","message":"does it give different results locally? In the cover job I see that the total coverage is 77% - https://f1f8dbe7036889e56512-4bfcd1a0cc7c3d4f9c4976468d7d6805.ssl.cf2.rackcdn.com/893080/6/check/openstack-tox-cover/0c9d53b/cover/ - therefore I suggested to change it 77, if it gives different results locally then leave it as it is. The patch is a significant improvement already.","commit_id":"433dbdc4b96cefdc522aca493b4eebd10e050f49"}]}