)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"88d1f4dd5d6b32fbe55d073a8cc4b8732d248ff1","unresolved":false,"context_lines":[{"line_number":9,"context_line":" - Added test to make sure trove flavors matched OS (nova) flavors"},{"line_number":10,"context_line":" - Added response status checks to existing tests"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially implements blueprint: trove-tempest"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I59cc551ef5ec58fe43b794ae8dbd6a89c40c774b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5adbc538_c1882625","line":12,"updated":"2014-05-26 16:43:38.000000000","message":"Partially implements: blueprint trove-tempest\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"b0836ec7107c4b125b220ec4f8bfb4463c390104"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"6ae97f3ad27ee51767ce381ae2fdec75ccc0d368","unresolved":false,"context_lines":[{"line_number":9,"context_line":" - Added test to make sure trove flavors matched OS (nova) flavors"},{"line_number":10,"context_line":" - Added response status checks to existing tests"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially implements blueprint: trove-tempest"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I59cc551ef5ec58fe43b794ae8dbd6a89c40c774b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3ae8d1ca_a617c750","line":12,"in_reply_to":"5adbc538_04e93c80","updated":"2014-05-27 08:43:00.000000000","message":"I just want to say that \"blueprint\" line is incorrect slightly.\n\n    Implements: blueprint trove-tempest\n    Partially implements: blueprint trove-tempest\n\ninstead of\n    \n    Implements blueprint: trove-tempest\n    Partially implements blueprint: trove-tempest\n\nSee \"Summary of GIT commit message structure\" section https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"b0836ec7107c4b125b220ec4f8bfb4463c390104"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8cbd62920baf61fcb30f1f78bdec43f034d14c45","unresolved":false,"context_lines":[{"line_number":9,"context_line":" - Added test to make sure trove flavors matched OS (nova) flavors"},{"line_number":10,"context_line":" - Added response status checks to existing tests"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially implements blueprint: trove-tempest"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I59cc551ef5ec58fe43b794ae8dbd6a89c40c774b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5adbc538_04e93c80","line":12,"in_reply_to":"5adbc538_c1882625","updated":"2014-05-26 18:50:01.000000000","message":"I\u0027m not sure what you\u0027re trying to point out with the GitCommitMessages link.  If it\u0027s the fact that the blueprint can\u0027t be found with the link gerrit created, I\u0027m not sure there\u0027s much I can do about that.  The actual blueprint is at: https://blueprints.launchpad.net/trove/+spec/trove-tempest","commit_id":"b0836ec7107c4b125b220ec4f8bfb4463c390104"}],"tempest/api/database/flavors/test_flavors.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"24f781b6e617f1a75443a377182fea4478929f9f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.assertIn(flavor, flavors)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def check_value(self, name, db_flavor, os_flavor, in_db\u003dTrue):"},{"line_number":44,"context_line":"        self.assertTrue(name in db_flavor if in_db else name not in db_flavor,"},{"line_number":45,"context_line":"                        \"Database flavor did not have %s value\" % name)"},{"line_number":46,"context_line":"        self.assertTrue(name in os_flavor,"},{"line_number":47,"context_line":"                        \"Open Stack flavor did not have %s value\" % name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FSSs%3D","line":44,"updated":"2014-04-22 18:31:44.000000000","message":"ok, way too much use of logic in an assertTrue, can we unwind this?\n\nif in_db:\n   self.assertIn(name, db_flavor)\nelse:\n   sel.assertNotIn(name, db_flavor)\n\nself.assertIn(name, os_flavor)","commit_id":"ad582f1b66655199e0dc5449da13e83c56dc6afc"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"46949178192d0d839b2e69791206a06af4ad076e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.assertIn(name, os_flavor)"},{"line_number":45,"context_line":"        if in_db:"},{"line_number":46,"context_line":"            self.assertIn(name, db_flavor)"},{"line_number":47,"context_line":"            self.assertEqual(str(db_flavor[name]), str(os_flavor[name]),"},{"line_number":48,"context_line":"                             \"DB flavor differs from OS on \u0027%s\u0027 value\" % name)"},{"line_number":49,"context_line":"        else:"},{"line_number":50,"context_line":"            self.assertNotIn(name, db_flavor)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bad4c104_f288a6c8","line":47,"updated":"2014-04-29 14:22:54.000000000","message":"is str() really needed there?","commit_id":"1251b2392a96fceb4849470feeba2260675503e9"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"44994fbabf4a567035304a24fee8d77983e2eb5e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.assertIn(name, os_flavor)"},{"line_number":45,"context_line":"        if in_db:"},{"line_number":46,"context_line":"            self.assertIn(name, db_flavor)"},{"line_number":47,"context_line":"            self.assertEqual(str(db_flavor[name]), str(os_flavor[name]),"},{"line_number":48,"context_line":"                             \"DB flavor differs from OS on \u0027%s\u0027 value\" % name)"},{"line_number":49,"context_line":"        else:"},{"line_number":50,"context_line":"            self.assertNotIn(name, db_flavor)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bad4c104_9c1208b3","line":47,"in_reply_to":"bad4c104_f288a6c8","updated":"2014-04-29 20:22:51.000000000","message":"Yes.  For most comparisons it wouldn\u0027t be needed, however the \u0027id\u0027 field in trove is a numeric, while in os it\u0027s a string (so for that specific comparison it is necessary).","commit_id":"1251b2392a96fceb4849470feeba2260675503e9"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"46949178192d0d839b2e69791206a06af4ad076e","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":59,"context_line":"    def test_compare_db_flavors_with_os(self):"},{"line_number":60,"context_line":"        resp, db_flavors \u003d self.client.list_db_flavors()"},{"line_number":61,"context_line":"        resp, os_flavors \u003d self.os_flavors_client.list_flavors()"},{"line_number":62,"context_line":"        self.assertEqual(len(os_flavors), len(db_flavors))"},{"line_number":63,"context_line":"        for flavor in os_flavors:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bad4c104_32e5aea8","line":60,"updated":"2014-04-29 14:22:54.000000000","message":"unused variable \"resp\"","commit_id":"1251b2392a96fceb4849470feeba2260675503e9"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"46949178192d0d839b2e69791206a06af4ad076e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":59,"context_line":"    def test_compare_db_flavors_with_os(self):"},{"line_number":60,"context_line":"        resp, db_flavors \u003d self.client.list_db_flavors()"},{"line_number":61,"context_line":"        resp, os_flavors \u003d self.os_flavors_client.list_flavors()"},{"line_number":62,"context_line":"        self.assertEqual(len(os_flavors), len(db_flavors))"},{"line_number":63,"context_line":"        for flavor in os_flavors:"},{"line_number":64,"context_line":"            resp, db_flavor \u003d self.client.get_db_flavor_details(flavor[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"bad4c104_72ee568d","line":61,"updated":"2014-04-29 14:22:54.000000000","message":"unused variable \"resp\"","commit_id":"1251b2392a96fceb4849470feeba2260675503e9"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"46949178192d0d839b2e69791206a06af4ad076e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        resp, os_flavors \u003d self.os_flavors_client.list_flavors()"},{"line_number":62,"context_line":"        self.assertEqual(len(os_flavors), len(db_flavors))"},{"line_number":63,"context_line":"        for flavor in os_flavors:"},{"line_number":64,"context_line":"            resp, db_flavor \u003d self.client.get_db_flavor_details(flavor[\u0027id\u0027])"},{"line_number":65,"context_line":"            resp, os_flavor \u003d\\"},{"line_number":66,"context_line":"                self.os_flavors_client.get_flavor_details(flavor[\u0027id\u0027])"},{"line_number":67,"context_line":"            self.check_values(db_flavor, os_flavor)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bad4c104_3293eefb","line":64,"updated":"2014-04-29 14:22:54.000000000","message":"unused variable \"resp\"","commit_id":"1251b2392a96fceb4849470feeba2260675503e9"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"46949178192d0d839b2e69791206a06af4ad076e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertEqual(len(os_flavors), len(db_flavors))"},{"line_number":63,"context_line":"        for flavor in os_flavors:"},{"line_number":64,"context_line":"            resp, db_flavor \u003d self.client.get_db_flavor_details(flavor[\u0027id\u0027])"},{"line_number":65,"context_line":"            resp, os_flavor \u003d\\"},{"line_number":66,"context_line":"                self.os_flavors_client.get_flavor_details(flavor[\u0027id\u0027])"},{"line_number":67,"context_line":"            self.check_values(db_flavor, os_flavor)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bad4c104_92c11ae7","line":65,"updated":"2014-04-29 14:22:54.000000000","message":"unused variable \"resp\"","commit_id":"1251b2392a96fceb4849470feeba2260675503e9"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"44994fbabf4a567035304a24fee8d77983e2eb5e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertEqual(len(os_flavors), len(db_flavors))"},{"line_number":63,"context_line":"        for flavor in os_flavors:"},{"line_number":64,"context_line":"            resp, db_flavor \u003d self.client.get_db_flavor_details(flavor[\u0027id\u0027])"},{"line_number":65,"context_line":"            resp, os_flavor \u003d\\"},{"line_number":66,"context_line":"                self.os_flavors_client.get_flavor_details(flavor[\u0027id\u0027])"},{"line_number":67,"context_line":"            self.check_values(db_flavor, os_flavor)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bad4c104_5caa401a","line":65,"in_reply_to":"bad4c104_92c11ae7","updated":"2014-04-29 20:22:51.000000000","message":"I\u0027ll add some status checks for all, thx","commit_id":"1251b2392a96fceb4849470feeba2260675503e9"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"36318378fe0db6589cba19aa300ce1c650b6a1a6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":65,"context_line":"        resp, os_flavors \u003d self.os_flavors_client.list_flavors()"},{"line_number":66,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":67,"context_line":"        self.assertEqual(len(os_flavors), len(db_flavors))"},{"line_number":68,"context_line":"        for flavor in os_flavors:"},{"line_number":69,"context_line":"            resp, db_flavor \u003d self.client.get_db_flavor_details(flavor[\u0027id\u0027])"},{"line_number":70,"context_line":"            self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_b01a6b15","line":67,"updated":"2014-05-09 12:29:50.000000000","message":"Can we get the 3rd parameter to be both lists, so we could debug what wasn\u0027t found.","commit_id":"ce54b5a412a2902e80d3d3bfafbbd30dfb1580d0"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"f1e57ef3a5d1980beaf7e9b0cc384266f167a29a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def test_get_db_flavor(self):"},{"line_number":29,"context_line":"        # The expected flavor details should be returned"},{"line_number":30,"context_line":"        resp, flavor \u003d self.client.get_db_flavor_details(self.db_flavor_ref)"},{"line_number":31,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":32,"context_line":"        self.assertEqual(self.db_flavor_ref, str(flavor[\u0027id\u0027]))"},{"line_number":33,"context_line":"        self.assertIn(\u0027ram\u0027, flavor)"},{"line_number":34,"context_line":"        self.assertIn(\u0027links\u0027, flavor)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_68ab4f75","line":31,"updated":"2014-05-15 12:25:27.000000000","message":"This change is not relevant to purpose of patch set :) Please, add info to the commit message about done changes here.","commit_id":"7d19c2cf3dde103f25b8bd88815857599c01f92e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"f1e57ef3a5d1980beaf7e9b0cc384266f167a29a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":38,"context_line":"    def test_list_db_flavors(self):"},{"line_number":39,"context_line":"        resp, flavor \u003d self.client.get_db_flavor_details(self.db_flavor_ref)"},{"line_number":40,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":41,"context_line":"        # List of all flavors should contain the expected flavor"},{"line_number":42,"context_line":"        resp, flavors \u003d self.client.list_db_flavors()"},{"line_number":43,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_88a89b78","line":40,"updated":"2014-05-15 12:25:27.000000000","message":"ditto","commit_id":"7d19c2cf3dde103f25b8bd88815857599c01f92e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"f1e57ef3a5d1980beaf7e9b0cc384266f167a29a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":41,"context_line":"        # List of all flavors should contain the expected flavor"},{"line_number":42,"context_line":"        resp, flavors \u003d self.client.list_db_flavors()"},{"line_number":43,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":44,"context_line":"        self.assertIn(flavor, flavors)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def check_value(self, name, db_flavor, os_flavor, in_db\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_e8ae7f80","line":43,"updated":"2014-05-15 12:25:27.000000000","message":"ditto","commit_id":"7d19c2cf3dde103f25b8bd88815857599c01f92e"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"dd05fb98c0781c5ed7d47b83fbc31da389a1cace","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertIn(name, os_flavor)"},{"line_number":48,"context_line":"        if in_db:"},{"line_number":49,"context_line":"            self.assertIn(name, db_flavor)"},{"line_number":50,"context_line":"            self.assertEqual(str(db_flavor[name]), str(os_flavor[name]),"},{"line_number":51,"context_line":"                             \"DB flavor differs from OS on \u0027%s\u0027 value\" % name)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            self.assertNotIn(name, db_flavor)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_ae4575b4","line":50,"updated":"2014-05-14 05:50:59.000000000","message":"db_flavor[name] and os_flavor[name] are strings, isn\u0027t it?","commit_id":"7d19c2cf3dde103f25b8bd88815857599c01f92e"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"11b8eaf696b708b57fd6ea0b93fe32797d9ab9e4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertIn(name, os_flavor)"},{"line_number":48,"context_line":"        if in_db:"},{"line_number":49,"context_line":"            self.assertIn(name, db_flavor)"},{"line_number":50,"context_line":"            self.assertEqual(str(db_flavor[name]), str(os_flavor[name]),"},{"line_number":51,"context_line":"                             \"DB flavor differs from OS on \u0027%s\u0027 value\" % name)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            self.assertNotIn(name, db_flavor)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_0f81004a","line":50,"in_reply_to":"7adec928_ae4575b4","updated":"2014-05-14 14:12:41.000000000","message":"Not always - it depends on the value of \u0027name.\u0027  There is also a case where the type in the OS dict doesn\u0027t match the trove one, hence the need for str().  Please see the comments in patchset-3 for more clarification.","commit_id":"7d19c2cf3dde103f25b8bd88815857599c01f92e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b93a625f3737ba433eef9aeb07c41b054f03e351","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def check_values(self, db_flavor, os_flavor):"},{"line_number":56,"context_line":"        self.check_value(\u0027id\u0027, db_flavor, os_flavor)"},{"line_number":57,"context_line":"        self.check_value(\u0027name\u0027, db_flavor, os_flavor)"},{"line_number":58,"context_line":"        self.check_value(\u0027ram\u0027, db_flavor, os_flavor)"},{"line_number":59,"context_line":"        self.check_value(\u0027disk\u0027, db_flavor, os_flavor, in_db\u003dFalse)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_3a1298b4","line":58,"updated":"2014-05-23 07:29:38.000000000","message":"above 3 calls to same function can be replaced with passing a dict to function. like below-\n\nexpected_keys \u003d {\u0027id\u0027, \u0027name\u0027, \u0027ram\u0027}\nself.check_value(expected_keys, db_flavor, os_flavor)\n\n def check_value(self, keys, db_flavor, os_flavor):\t\n           for key in keys\n\t\t\tself.assertIn(key, os_flavor)\t\n\t\t\tself.assertIn(key, db_flavor)\t\n\t\t\tself.assertEqual(str(db_flavor[key]), str(os_flavor[key]),\t\n\t\t\t\"DB flavor differs from OS on \u0027%s\u0027 value\" % key)","commit_id":"0e52f37ca79a827c19eba56acc5e68d2e845ddcb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b93a625f3737ba433eef9aeb07c41b054f03e351","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.check_value(\u0027id\u0027, db_flavor, os_flavor)"},{"line_number":57,"context_line":"        self.check_value(\u0027name\u0027, db_flavor, os_flavor)"},{"line_number":58,"context_line":"        self.check_value(\u0027ram\u0027, db_flavor, os_flavor)"},{"line_number":59,"context_line":"        self.check_value(\u0027disk\u0027, db_flavor, os_flavor, in_db\u003dFalse)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":62,"context_line":"    def test_compare_db_flavors_with_os(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_fa9e7062","line":59,"updated":"2014-05-23 07:29:38.000000000","message":"as per previous comemnt, this can be just replaced with below lines-\n\nself.assertNotIn(\u0027disk\u0027, db_flavor)\n\nsame check can be done for \u0027vcpus\u0027 also as it not expected to present in db_flavor","commit_id":"0e52f37ca79a827c19eba56acc5e68d2e845ddcb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b93a625f3737ba433eef9aeb07c41b054f03e351","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def test_compare_db_flavors_with_os(self):"},{"line_number":63,"context_line":"        resp, db_flavors \u003d self.client.list_db_flavors()"},{"line_number":64,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":65,"context_line":"        resp, os_flavors \u003d self.os_flavors_client.list_flavors()"},{"line_number":66,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":67,"context_line":"        self.assertEqual(len(os_flavors), len(db_flavors),"},{"line_number":68,"context_line":"                         \"OS flavors %s do not match DB flavors %s\" %"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_3add3815","line":65,"updated":"2014-05-23 07:29:38.000000000","message":"instead of list_flavors(), list_flavors_with_detail() can be used to get the compute flavor with detail so that later get_flavor_details() call is not needed.","commit_id":"0e52f37ca79a827c19eba56acc5e68d2e845ddcb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b93a625f3737ba433eef9aeb07c41b054f03e351","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            resp, db_flavor \u003d self.client.get_db_flavor_details(flavor[\u0027id\u0027])"},{"line_number":72,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":73,"context_line":"            resp, os_flavor \u003d\\"},{"line_number":74,"context_line":"                self.os_flavors_client.get_flavor_details(flavor[\u0027id\u0027])"},{"line_number":75,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":76,"context_line":"            self.check_values(db_flavor, os_flavor)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_bad068f8","line":74,"updated":"2014-05-23 07:29:38.000000000","message":"This can be removed according to previous comment","commit_id":"0e52f37ca79a827c19eba56acc5e68d2e845ddcb"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2e5308dc30e86a44a38ea1718fac38c48d8684b8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            resp, db_flavor \u003d\\"},{"line_number":68,"context_line":"                self.client.get_db_flavor_details(os_flavor[\u0027id\u0027])"},{"line_number":69,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":70,"context_line":"            self._check_values({\u0027id\u0027, \u0027name\u0027, \u0027ram\u0027}, db_flavor, os_flavor)"},{"line_number":71,"context_line":"            self._check_values({\u0027disk\u0027, \u0027vcpus\u0027, \u0027swap\u0027}, db_flavor, os_flavor,"},{"line_number":72,"context_line":"                               in_db\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_b0517910","line":70,"updated":"2014-06-02 06:53:36.000000000","message":"Why are you using a dict as first argument? A lists would be more obvious.","commit_id":"74e003630ef818f6547d3f4343b6ee68b98b96df"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2e5308dc30e86a44a38ea1718fac38c48d8684b8","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                self.client.get_db_flavor_details(os_flavor[\u0027id\u0027])"},{"line_number":69,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":70,"context_line":"            self._check_values({\u0027id\u0027, \u0027name\u0027, \u0027ram\u0027}, db_flavor, os_flavor)"},{"line_number":71,"context_line":"            self._check_values({\u0027disk\u0027, \u0027vcpus\u0027, \u0027swap\u0027}, db_flavor, os_flavor,"},{"line_number":72,"context_line":"                               in_db\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_705e1114","line":71,"updated":"2014-06-02 06:53:36.000000000","message":"Same here","commit_id":"74e003630ef818f6547d3f4343b6ee68b98b96df"}]}