)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cea10c709c9aeabaa93dc36d7d2e8c155d0e620d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"2. Set provision state of a given node"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Console mode can be set to either True or False."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1379e84751818d0f558f28ba7b0bc9b5e4c76053"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAXH%2F%2FDdQ%3D","line":14,"updated":"2014-04-24 10:48:35.000000000","message":"mention the BP here.","commit_id":"5ecc6196d700c36db45fd04f972ca1c27c405d03"}],"tempest/api/baremetal/test_nodestates.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cea10c709c9aeabaa93dc36d7d2e8c155d0e620d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":75,"context_line":"            # Validate that console mode is set"},{"line_number":76,"context_line":"            resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":77,"context_line":"            self.assertEqual(console_set, node[\u0027console_enabled\u0027])"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":80,"context_line":"    def test_set_node_provision_state(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FDeI%3D","line":77,"updated":"2014-04-24 10:48:35.000000000","message":"check the resp code here.","commit_id":"5ecc6196d700c36db45fd04f972ca1c27c405d03"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cea10c709c9aeabaa93dc36d7d2e8c155d0e620d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":80,"context_line":"    def test_set_node_provision_state(self):"},{"line_number":81,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":82,"context_line":"        resp, body \u003d self.client.set_node_provision_state(node[\u0027uuid\u0027],"},{"line_number":83,"context_line":"                                                          \"active\")"},{"line_number":84,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":85,"context_line":"        # Validate that target provision state is set"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FDdg%3D","line":82,"updated":"2014-04-24 10:48:35.000000000","message":"add for \u0027deleted\u0027 state also","commit_id":"5ecc6196d700c36db45fd04f972ca1c27c405d03"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cea10c709c9aeabaa93dc36d7d2e8c155d0e620d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":85,"context_line":"        # Validate that target provision state is set"},{"line_number":86,"context_line":"        resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":87,"context_line":"        self.assertEqual(\"deploy complete\", node[\u0027target_provision_state\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FDd8%3D","line":87,"updated":"2014-04-24 10:48:35.000000000","message":"same as above","commit_id":"5ecc6196d700c36db45fd04f972ca1c27c405d03"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"56d801dc80eb2118c69b4082b12ff6c2206d4b64","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _set_node_provision_state(self, provision_state, node_uuid):"},{"line_number":48,"context_line":"        resp, body \u003d self.client.set_node_provision_state(node_uuid,"},{"line_number":49,"context_line":"                                                          provision_state)"},{"line_number":50,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bad4c104_722bb6eb","line":48,"updated":"2014-04-29 14:19:39.000000000","message":"unused variable \"body\"","commit_id":"75aff59c254833cee9a8335c84fcb33f53651839"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"8ef287056797d3c01486487626a5e4eb920def8a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _set_node_provision_state(self, provision_state, node_uuid):"},{"line_number":48,"context_line":"        resp, body \u003d self.client.set_node_provision_state(node_uuid,"},{"line_number":49,"context_line":"                                                          provision_state)"},{"line_number":50,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad9bd40_59bfc3d0","line":48,"in_reply_to":"bad4c104_722bb6eb","updated":"2014-04-30 04:42:58.000000000","message":"Done","commit_id":"75aff59c254833cee9a8335c84fcb33f53651839"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"56d801dc80eb2118c69b4082b12ff6c2206d4b64","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        set_values \u003d [True, False]"},{"line_number":76,"context_line":"        for console_set in set_values:"},{"line_number":77,"context_line":"            resp, body \u003d self.client.set_node_console_mode(node[\u0027uuid\u0027],"},{"line_number":78,"context_line":"                                                           console_set)"},{"line_number":79,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":80,"context_line":"            # Validate that console mode is set"}],"source_content_type":"text/x-python","patch_set":7,"id":"bad4c104_7212d6b5","line":77,"updated":"2014-04-29 14:19:39.000000000","message":"unused variable \"body\"","commit_id":"75aff59c254833cee9a8335c84fcb33f53651839"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"8ef287056797d3c01486487626a5e4eb920def8a","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        set_values \u003d [True, False]"},{"line_number":76,"context_line":"        for console_set in set_values:"},{"line_number":77,"context_line":"            resp, body \u003d self.client.set_node_console_mode(node[\u0027uuid\u0027],"},{"line_number":78,"context_line":"                                                           console_set)"},{"line_number":79,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":80,"context_line":"            # Validate that console mode is set"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad9bd40_79b487f2","line":77,"in_reply_to":"bad4c104_7212d6b5","updated":"2014-04-30 04:42:58.000000000","message":"Done","commit_id":"75aff59c254833cee9a8335c84fcb33f53651839"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"e588ef6765097b13901fdda2b34b7ca9654bd883","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def _set_node_provision_state(self, provision_state, node_uuid):"},{"line_number":50,"context_line":"        resp, _ \u003d self.client.set_node_provision_state(node_uuid,"},{"line_number":51,"context_line":"                                                          provision_state)"},{"line_number":52,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":55,"context_line":"    def test_list_nodestates(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_3474c69b","line":52,"updated":"2014-04-30 05:26:18.000000000","message":"As the response returned is 202, u need to wait for process completion. You may use a wait_for method similar to (rest_client)-\u003ewait_for_resource_deletion()","commit_id":"26fcd34f02297f82ced739a37dab0010cb981148"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"214a44886581ba21970bc3c2bfa91b0244d8e28a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def _set_node_provision_state(self, provision_state, node_uuid):"},{"line_number":50,"context_line":"        resp, _ \u003d self.client.set_node_provision_state(node_uuid,"},{"line_number":51,"context_line":"                                                          provision_state)"},{"line_number":52,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":55,"context_line":"    def test_list_nodestates(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_b4ae16e6","line":52,"in_reply_to":"9ad9bd40_3474c69b","updated":"2014-04-30 05:32:45.000000000","message":"I had talked on IRC for it. It has 30 min timeout which would not be good to check. So please evaluate your comments.","commit_id":"26fcd34f02297f82ced739a37dab0010cb981148"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"cefcb6ae254bf079e05f114cec1a2efc966480c2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def _set_node_provision_state(self, provision_state, node_uuid):"},{"line_number":50,"context_line":"        resp, _ \u003d self.client.set_node_provision_state(node_uuid,"},{"line_number":51,"context_line":"                                                          provision_state)"},{"line_number":52,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":55,"context_line":"    def test_list_nodestates(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_d478fa2d","line":52,"in_reply_to":"9ad9bd40_b4ae16e6","updated":"2014-04-30 06:02:08.000000000","message":"Ok. got that","commit_id":"26fcd34f02297f82ced739a37dab0010cb981148"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"e588ef6765097b13901fdda2b34b7ca9654bd883","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        for console_set in set_values:"},{"line_number":79,"context_line":"            resp, _ \u003d self.client.set_node_console_mode(node[\u0027uuid\u0027],"},{"line_number":80,"context_line":"                                                           console_set)"},{"line_number":81,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":82,"context_line":"            # Validate that console mode is set"},{"line_number":83,"context_line":"            resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":84,"context_line":"            self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_b467f6e9","line":81,"updated":"2014-04-30 05:26:18.000000000","message":"ditto","commit_id":"26fcd34f02297f82ced739a37dab0010cb981148"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"214a44886581ba21970bc3c2bfa91b0244d8e28a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        for console_set in set_values:"},{"line_number":79,"context_line":"            resp, _ \u003d self.client.set_node_console_mode(node[\u0027uuid\u0027],"},{"line_number":80,"context_line":"                                                           console_set)"},{"line_number":81,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":82,"context_line":"            # Validate that console mode is set"},{"line_number":83,"context_line":"            resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":84,"context_line":"            self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_34820653","line":81,"in_reply_to":"9ad9bd40_b467f6e9","updated":"2014-04-30 05:32:45.000000000","message":"There is no specified time out for this as of talk based on ironic.","commit_id":"26fcd34f02297f82ced739a37dab0010cb981148"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"118112339f1389eeedb4788f50eab672b799c045","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":62,"context_line":"    def test_set_node_power_state(self):"},{"line_number":63,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":64,"context_line":"        states \u003d [\"power on\", \"rebooting\", \"power off\"]"},{"line_number":65,"context_line":"        for state in states:"},{"line_number":66,"context_line":"            # Set power state"},{"line_number":67,"context_line":"            resp, _ \u003d self.client.set_node_power_state(node[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_c899d020","line":64,"updated":"2014-06-03 09:23:47.000000000","message":"A similar pattern.","commit_id":"24b61168ea7eab2be243e8de87cbd731ee523b98"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"e8c8970fb83908c92fb1b17077b75d45c65389f2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        set_values \u003d [True, False]"},{"line_number":78,"context_line":"        for console_set in set_values:"},{"line_number":79,"context_line":"            resp, _ \u003d self.client.set_node_console_mode(node[\u0027uuid\u0027],"},{"line_number":80,"context_line":"                                                        console_set)"},{"line_number":81,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad9bd40_e5e62016","line":78,"updated":"2014-04-30 13:56:13.000000000","message":"This saves you a few lines of code, but makes reading/following this test more difficult. Splitting out the code inside this block into a private function and calling that function twice (once for true, once for false) would be much more clear","commit_id":"24b61168ea7eab2be243e8de87cbd731ee523b98"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"054b86127726da39999a154ab962945243e04de6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        set_values \u003d [True, False]"},{"line_number":78,"context_line":"        for console_set in set_values:"},{"line_number":79,"context_line":"            resp, _ \u003d self.client.set_node_console_mode(node[\u0027uuid\u0027],"},{"line_number":80,"context_line":"                                                        console_set)"},{"line_number":81,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_74a35c4f","line":78,"in_reply_to":"9ad9bd40_64903f96","updated":"2014-06-02 11:38:05.000000000","message":"@Daryl Walleck - We should ask more developers about this.","commit_id":"24b61168ea7eab2be243e8de87cbd731ee523b98"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"118112339f1389eeedb4788f50eab672b799c045","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        set_values \u003d [True, False]"},{"line_number":78,"context_line":"        for console_set in set_values:"},{"line_number":79,"context_line":"            resp, _ \u003d self.client.set_node_console_mode(node[\u0027uuid\u0027],"},{"line_number":80,"context_line":"                                                        console_set)"},{"line_number":81,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_887d08b4","line":78,"in_reply_to":"9ad9bd40_e5e62016","updated":"2014-06-03 09:23:47.000000000","message":"@dwalleck: A similar pattern used in another tests in this file, do you think we MUST handle the Boolean type differently ?","commit_id":"24b61168ea7eab2be243e8de87cbd731ee523b98"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"b89884b8a58d6abce76b9c3548b65f46a8011874","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        set_values \u003d [True, False]"},{"line_number":78,"context_line":"        for console_set in set_values:"},{"line_number":79,"context_line":"            resp, _ \u003d self.client.set_node_console_mode(node[\u0027uuid\u0027],"},{"line_number":80,"context_line":"                                                        console_set)"},{"line_number":81,"context_line":"            self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad9bd40_64903f96","line":78,"in_reply_to":"9ad9bd40_e5e62016","updated":"2014-05-01 06:17:36.000000000","message":"Thanks for your suggestion but I think I is much better to use optimised LOC to fulfil same requirement. Not only this many core reviewers recommend this way of coding. So it\u0027s fine for me.","commit_id":"24b61168ea7eab2be243e8de87cbd731ee523b98"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2e06e4d624f87953c61aaa7192ffea80c31cf5b8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":84,"context_line":"    def test_set_node_provision_state_active(self):"},{"line_number":85,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":86,"context_line":"        self._set_node_provision_state(\"active\", node[\u0027uuid\u0027])"},{"line_number":87,"context_line":"        # Validate that target provision state is set"},{"line_number":88,"context_line":"        resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":89,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_0002a46e","line":86,"updated":"2014-06-03 15:46:18.000000000","message":"I don\u0027t understand purpose of self._set_node_provision_state method. You might create the same method for setting node console mode, but you didn\u0027t do it. I think you don\u0027t need self._set_node_provision_state method. Lines 75-77 are more readable than 86 for me. But I\u0027d make such method\n\n    def _check_node_state_is_set(expected_val, actual_val):\n        resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])\n        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])\n        self.assertEqual(expected_val, actual_val)\n\nSo test would look something like this\n\n    @test.attr(type\u003d\u0027smoke\u0027)\n    def test_set_node_provision_state_active(self):\n        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]\n        resp \u003d self.client.set_node_provision_state(node_uuid, provision_state)[0]\n        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])\n        # Validate that target provision state is set \n        self._check_node_state_is_set(expected_state, actual_state)\n\nIt is the same for other test. Maybe, you will not like this but I think it is more readable.","commit_id":"fa136237724cc3c1a7c8d3f3388002e68d1e8c36"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"e3b7c26886c9171799857d873dea4606e37016a0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":84,"context_line":"    def test_set_node_provision_state_active(self):"},{"line_number":85,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":86,"context_line":"        self._set_node_provision_state(\"active\", node[\u0027uuid\u0027])"},{"line_number":87,"context_line":"        # Validate that target provision state is set"},{"line_number":88,"context_line":"        resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":89,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_b053e7e0","line":86,"in_reply_to":"1ae5cdf2_0002a46e","updated":"2014-06-04 05:12:24.000000000","message":"To make a new method \"_check_node_state_is_set\" will not be very effecient. Because in checks we can here check only target provision state not power state.\n\nthis is called only once so to make it a separate method will not be very good IMO.\n\nAlso in further addition of testcases it may be possible that power state set is required in many test so it will be better to use a separate method for this purpose as of me. This was suggested by others also in previous patches.\nIn case of test_set_node_console_mode test, setting is required on the basis of set_values (a list), so to make it more readable no separate method is written.\n\nSo, IMO it is fine here.","commit_id":"fa136237724cc3c1a7c8d3f3388002e68d1e8c36"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"54e28c1cf2552278941a450705c4d6075d248861","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":84,"context_line":"    def test_set_node_provision_state_active(self):"},{"line_number":85,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":86,"context_line":"        self._set_node_provision_state(\"active\", node[\u0027uuid\u0027])"},{"line_number":87,"context_line":"        # Validate that target provision state is set"},{"line_number":88,"context_line":"        resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":89,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_6f333d62","line":86,"in_reply_to":"1ae5cdf2_8fb7a9f4","updated":"2014-06-04 06:48:44.000000000","message":"Please refer second para of my last comment.\nAlso--**\n\nIMO separate power state set method will be much better. In previous patches people have given there views to make this method separate","commit_id":"fa136237724cc3c1a7c8d3f3388002e68d1e8c36"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"c6becce48218d36765435629774d55cbdcbd7a66","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":84,"context_line":"    def test_set_node_provision_state_active(self):"},{"line_number":85,"context_line":"        node \u003d self.create_node(self.chassis[\u0027uuid\u0027])[\u0027node\u0027]"},{"line_number":86,"context_line":"        self._set_node_provision_state(\"active\", node[\u0027uuid\u0027])"},{"line_number":87,"context_line":"        # Validate that target provision state is set"},{"line_number":88,"context_line":"        resp, node \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":89,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_8fb7a9f4","line":86,"in_reply_to":"1ae5cdf2_b053e7e0","updated":"2014-06-04 06:36:10.000000000","message":"Mh Raies, OK, I understood regarding \"_check_node_state_is_set\" :) What about method \"_set_node_provision_state\". Do you want to leave it?","commit_id":"fa136237724cc3c1a7c8d3f3388002e68d1e8c36"}]}