)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65feae0d4e4680744a4d1cc3ad1ecaa4702c1b2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"423d04bd_8f174551","updated":"2023-09-19 18:55:36.000000000","message":"lgtm, 1 comment","commit_id":"9a4005656a8d22c1ebfdc474ff11a98a3441f8e4"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"978b024d77a5de3fb4c0191e6c2c01db8afe41fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d5868714_bea72746","updated":"2023-09-18 19:04:04.000000000","message":"recheck\n\nproblem with stestr should\u0027ve been fixed with the latest release.\n\nStill, I think it is beneficial to have the pep8 env to have the same constraints as the rest envs.","commit_id":"9a4005656a8d22c1ebfdc474ff11a98a3441f8e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"05807f2f0600eb727229b8996161f96b2f43374b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c18a9dec_27eafcbe","updated":"2023-09-21 18:19:26.000000000","message":"recheck stable/yoga failing for unrelated failure","commit_id":"53885e50faeda559e477bbaa1bea71fa030b7f56"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5f7cba5d610bbf1df74c14c9b996c57d780b5a2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7d4730b3_4db3dc20","updated":"2023-09-21 21:45:47.000000000","message":"recheck unrelated failure in rbac job","commit_id":"53885e50faeda559e477bbaa1bea71fa030b7f56"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5c1718b44af7f088878461c1e37923b74ee6af0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"49e9e299_90bb0b23","updated":"2023-09-21 18:19:08.000000000","message":"thanks. lgtm","commit_id":"53885e50faeda559e477bbaa1bea71fa030b7f56"}],"tox.ini":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65feae0d4e4680744a4d1cc3ad1ecaa4702c1b2c","unresolved":true,"context_lines":[{"line_number":385,"context_line":"[testenv:pep8]"},{"line_number":386,"context_line":"deps \u003d"},{"line_number":387,"context_line":"    -r{toxinidir}/test-requirements.txt"},{"line_number":388,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":389,"context_line":"    autopep8"},{"line_number":390,"context_line":"commands \u003d"},{"line_number":391,"context_line":"    autopep8 --exit-code --max-line-length\u003d79 --experimental --diff -r tempest setup.py"}],"source_content_type":"text/x-properties","patch_set":1,"id":"bc5a92c5_7c32a285","line":388,"range":{"start_line":388,"start_character":4,"end_line":388,"end_character":90},"updated":"2023-09-19 18:55:36.000000000","message":"can we do {[testenv]deps} so that we do not need to change it to stable here too when we cut tempest release","commit_id":"9a4005656a8d22c1ebfdc474ff11a98a3441f8e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"70b70889768e74b8aa3788b6fea9fea3aeda39c8","unresolved":false,"context_lines":[{"line_number":385,"context_line":"[testenv:pep8]"},{"line_number":386,"context_line":"deps \u003d"},{"line_number":387,"context_line":"    -r{toxinidir}/test-requirements.txt"},{"line_number":388,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":389,"context_line":"    autopep8"},{"line_number":390,"context_line":"commands \u003d"},{"line_number":391,"context_line":"    autopep8 --exit-code --max-line-length\u003d79 --experimental --diff -r tempest setup.py"}],"source_content_type":"text/x-properties","patch_set":1,"id":"23647a1a_6a09a379","line":388,"range":{"start_line":388,"start_character":4,"end_line":388,"end_character":90},"in_reply_to":"09bc09f6_4d5678be","updated":"2023-09-20 18:52:59.000000000","message":"oh you were right this will install  \u0027requirements.txt\u0027  also which we do not want to do. Let\u0027s do the way you did in PS11. sorry about missing the  \u0027requirements.txt\u0027 point.\n\nI am not sure why you find  \u0027requirements.txt\u0027 installed in pep8 env, i cannot find it. \n\nhttps://zuul.opendev.org/t/openstack/build/249a76400577489f9b71a959baf17c43/log/job-output.txt","commit_id":"9a4005656a8d22c1ebfdc474ff11a98a3441f8e4"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"58ab35b9cf5722df640c9dc54b0ed99562b0ef95","unresolved":false,"context_lines":[{"line_number":385,"context_line":"[testenv:pep8]"},{"line_number":386,"context_line":"deps \u003d"},{"line_number":387,"context_line":"    -r{toxinidir}/test-requirements.txt"},{"line_number":388,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":389,"context_line":"    autopep8"},{"line_number":390,"context_line":"commands \u003d"},{"line_number":391,"context_line":"    autopep8 --exit-code --max-line-length\u003d79 --experimental --diff -r tempest setup.py"}],"source_content_type":"text/x-properties","patch_set":1,"id":"d29cacf1_13dfbfb1","line":388,"range":{"start_line":388,"start_character":4,"end_line":388,"end_character":90},"in_reply_to":"23647a1a_6a09a379","updated":"2023-09-21 13:06:38.000000000","message":"they are definitely there - in the log you\u0027ve provided, look at\n\n2023-09-19 19:05:58.682932\n\n```\n2023-09-19 19:05:58.682932 | ubuntu-jammy | pep8: 14403 W install_package_deps\u003e python -I -m pip install \u0027PrettyTable\u003e\u003d0.7.1\u0027 \u0027PyYAML\u003e\u003d3.12\u0027 \u0027cliff!\u003d2.9.0,\u003e\u003d2.8.0\u0027 \u0027cryptography\u003e\u003d2.1\u0027 \u0027debtcollector\u003e\u003d1.2.0\u0027 \u0027defusedxml\u003e\u003d0.7.1\u0027 \u0027fasteners\u003e\u003d0.16.0\u0027 \u0027fixtures\u003e\u003d3.0.0\u0027 \u0027jsonschema\u003e\u003d3.2.0\u0027 \u0027netaddr\u003e\u003d0.7.18\u0027 \u0027oslo.concurrency\u003e\u003d3.26.0\u0027 \u0027oslo.config\u003e\u003d5.2.0\u0027 \u0027oslo.log\u003e\u003d3.36.0\u0027 \u0027oslo.serialization!\u003d2.19.1,\u003e\u003d2.18.0\u0027 \u0027oslo.utils\u003e\u003d4.7.0\u0027 \u0027paramiko\u003e\u003d2.7.0\u0027 \u0027pbr!\u003d2.1.0,\u003e\u003d2.0.0\u0027 \u0027python-subunit\u003e\u003d1.0.0\u0027 \u0027stestr\u003e\u003d1.0.0\u0027 \u0027stevedore\u003e\u003d1.20.0\u0027 \u0027testtools\u003e\u003d2.2.0\u0027 \u0027urllib3\u003e\u003d1.21.1\u0027 [tox/tox_env/api.py:427]\n```\nthese are deps from requirements.txt, since we install tempest into the venv too they are installed as well","commit_id":"9a4005656a8d22c1ebfdc474ff11a98a3441f8e4"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"91b1175e3f36a691d736c809b8cb191f4d1fe019","unresolved":false,"context_lines":[{"line_number":385,"context_line":"[testenv:pep8]"},{"line_number":386,"context_line":"deps \u003d"},{"line_number":387,"context_line":"    -r{toxinidir}/test-requirements.txt"},{"line_number":388,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":389,"context_line":"    autopep8"},{"line_number":390,"context_line":"commands \u003d"},{"line_number":391,"context_line":"    autopep8 --exit-code --max-line-length\u003d79 --experimental --diff -r tempest setup.py"}],"source_content_type":"text/x-properties","patch_set":1,"id":"09bc09f6_4d5678be","line":388,"range":{"start_line":388,"start_character":4,"end_line":388,"end_character":90},"in_reply_to":"901782fe_576e9a3c","updated":"2023-09-20 08:49:49.000000000","message":"Done","commit_id":"9a4005656a8d22c1ebfdc474ff11a98a3441f8e4"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"060ebb6153a926ef08930234e86e2db101637d77","unresolved":true,"context_lines":[{"line_number":385,"context_line":"[testenv:pep8]"},{"line_number":386,"context_line":"deps \u003d"},{"line_number":387,"context_line":"    -r{toxinidir}/test-requirements.txt"},{"line_number":388,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":389,"context_line":"    autopep8"},{"line_number":390,"context_line":"commands \u003d"},{"line_number":391,"context_line":"    autopep8 --exit-code --max-line-length\u003d79 --experimental --diff -r tempest setup.py"}],"source_content_type":"text/x-properties","patch_set":1,"id":"901782fe_576e9a3c","line":388,"range":{"start_line":388,"start_character":4,"end_line":388,"end_character":90},"in_reply_to":"bc5a92c5_7c32a285","updated":"2023-09-20 08:48:22.000000000","message":"actually we can!\n\nthe difference seems to be that \u0027requirements.txt\u0027 will be installed too,\nBUT\nsince we develop-install tempest itself anyway, those in \u0027requirements.txt\u0027 will be installed always installed whatever you do.","commit_id":"9a4005656a8d22c1ebfdc474ff11a98a3441f8e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2e643372abbab93b9955294fb4bf2901ef8a136c","unresolved":false,"context_lines":[{"line_number":385,"context_line":"[testenv:pep8]"},{"line_number":386,"context_line":"deps \u003d"},{"line_number":387,"context_line":"    -r{toxinidir}/test-requirements.txt"},{"line_number":388,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":389,"context_line":"    autopep8"},{"line_number":390,"context_line":"commands \u003d"},{"line_number":391,"context_line":"    autopep8 --exit-code --max-line-length\u003d79 --experimental --diff -r tempest setup.py"}],"source_content_type":"text/x-properties","patch_set":1,"id":"b63c36db_e7c5c8b6","line":388,"range":{"start_line":388,"start_character":4,"end_line":388,"end_character":90},"in_reply_to":"d29cacf1_13dfbfb1","updated":"2023-09-21 18:18:30.000000000","message":"ah my bad, those are anyways needed also.","commit_id":"9a4005656a8d22c1ebfdc474ff11a98a3441f8e4"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"58ab35b9cf5722df640c9dc54b0ed99562b0ef95","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    ZUUL_CACHE_DIR"},{"line_number":37,"context_line":"    REQUIREMENTS_PIP_LOCATION"},{"line_number":38,"context_line":"    GENERATE_TEMPEST_PLUGIN_LIST"},{"line_number":39,"context_line":"usedevelop \u003d True"},{"line_number":40,"context_line":"allowlist_externals \u003d"},{"line_number":41,"context_line":"    find"},{"line_number":42,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"31f7cc7c_54859f16","line":39,"updated":"2023-09-21 13:06:38.000000000","message":"here, we use setupdevelop and effectively we are calling\n```\npip install -e .\n```\nhttps://tox.wiki/en/latest/config.html#use_develop\nwhich will naturally install all the normal dependencies too","commit_id":"53885e50faeda559e477bbaa1bea71fa030b7f56"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5c1718b44af7f088878461c1e37923b74ee6af0b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    ZUUL_CACHE_DIR"},{"line_number":37,"context_line":"    REQUIREMENTS_PIP_LOCATION"},{"line_number":38,"context_line":"    GENERATE_TEMPEST_PLUGIN_LIST"},{"line_number":39,"context_line":"usedevelop \u003d True"},{"line_number":40,"context_line":"allowlist_externals \u003d"},{"line_number":41,"context_line":"    find"},{"line_number":42,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"0df53b2e_39b7b672","line":39,"in_reply_to":"31f7cc7c_54859f16","updated":"2023-09-21 18:19:08.000000000","message":"yeah.","commit_id":"53885e50faeda559e477bbaa1bea71fa030b7f56"}]}