)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"8ffbe9e96ffe60e35f9a1701b5b2b551526ad712","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b04572d7_068ba4db","updated":"2023-11-06 08:21:46.000000000","message":"openstack-tox-docs fails because:\n```\ndocstring of scenario.test_instances_with_cinder_volumes.TestInstancesWithCinderVolumes.\ntest_instances_with_cinder_volumes_on_all_compute_nodes:9:Unexpected indentation.\n```\nIt should be resolved by fixing the indentation in the docstring of the new test.","commit_id":"109c431016a2ca3393dcf7e2e8e39a38b989f22c"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"93bc12a3b4e5972f55b0e35e2e83ba0300962ea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9c6375f4_68d78e22","updated":"2023-11-16 08:32:26.000000000","message":"Just two small comments:).","commit_id":"27ef72111a85e754204ddf8983f9763593ee962a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"69470ec285b5c7d1f3015382de644f3137b24c97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"456cbb17_e39002b2","updated":"2023-11-28 11:00:54.000000000","message":"Thanks for updating the patch. I added three comments.","commit_id":"9a877fa4b71b11322b6ae181a79397d520dc5bbc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8ef31cb09526b2a14818bb884a31dff630e2157","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ff05cac0_dd3e1612","updated":"2023-12-14 23:52:42.000000000","message":"I am not sure if I understand the purpose of this test, it seems stress test to me but if I missed any specific configuration/scenario, please explain it in commit msg.","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"2fd7ac0144084fe615b6dc25b1cda853a0ba4b03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d852bff4_031cd871","updated":"2023-12-06 15:58:29.000000000","message":"recheck","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a9a22a0fba7b0383803c0a77a67fee14c0881b20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f202a39b_1196044b","updated":"2023-12-14 08:26:12.000000000","message":"some comments inline","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eedb738f0d2e6f10e959c572162fd72020aa95ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cbe5c2fd_f2b397a7","updated":"2023-12-15 18:21:26.000000000","message":"Thanks for response. but I am still not convinced on the need of this test and what exactly different scenario it test from existing one. Remember stress testing is not in scope of tempest instead those should be added in tempest-stress repo. - https://github.com/openstack/tempest-stress","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60328f858ef4ac5bcd658fafce29edd84ff27699","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2cde1bd2_b58095bc","in_reply_to":"1ab1a344_b4dae804","updated":"2024-01-29 13:34:19.000000000","message":"aand from now on it can also tell this test on how many nodes it should spawn the instances .. I don\u0027t see a problem in that, what do I miss?","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"baf2492dac27ff928221edacc6a7c85f9ee73907","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b454662e_848e5f35","in_reply_to":"2e8edd6b_b463786b","updated":"2023-12-20 20:06:07.000000000","message":"If we want to be test this scenario with multiple nodes, I have another idea:\n\n- Limit the targeted number of host to create VM, for example max host to create VM is \u003d 2 if number-of-available-host \u003c 4 OR number-of-available-host / 2\n\nThis way we will be able to not hitting the limit of stress load on nova or cinder services.","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"af4845cc9f8ae3613094b1b309252b49b01fa76b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4708be66_055d02a1","in_reply_to":"456693f1_9d6444ef","updated":"2024-01-16 10:51:54.000000000","message":"Re: Limit the targeted number of hosts to create VMs on - number-of-available-host / 2:\nDon\u0027t we have ``CONF.compute.min_compute_nodes`` for that?\n\nAs ``CONF.compute.min_compute_nodes`` is set by default to 1, this test will be running by default on a single node. My previous statement about forgetting to implement running on a single node was incorrect. I\u0027ve just noticed this:\nhttps://review.opendev.org/c/openstack/tempest/+/898732/13/tempest/scenario/test_instances_with_cinder_volumes.py#108","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1bfd57a1c196a7730978f44d38b24ea33d7c82b2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1ab1a344_b4dae804","in_reply_to":"4708be66_055d02a1","updated":"2024-01-25 06:14:51.000000000","message":"min_compute_nodes  node is just to know if env  is single node or multi node so that Tempest can skip multinode tests. All multinode test do fetch compute nodes from nova only.","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6ad35f26b9c5956cfc377d381184e79e0754fc49","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"456693f1_9d6444ef","in_reply_to":"b454662e_848e5f35","updated":"2024-01-08 10:25:07.000000000","message":"The main difference between test_volume_boot_pattern and test_instances_with_cinder_volumes_on_all_compute_nodes is:\n\nthe boot pattern test\n* creates a volume\n* creates an instance from it and a timestamp on the volume\n* creates another instance form the same volume and verifies that the timestamp matches\n* creates a snapshot from the volume\n* creates another instance from the snapshot and verifies that the timestamp matches\n\nwhereas the new test\n* creates a volume (with a specific volume type)\n* creates an instance from it\n* create another volume or volumes (with potentially different volume types - configured via CONF)\n* the volumes (except the first one) are attached to the instance\n* the instance is assigned a floating ip and a write test is performed on all attached volumes.\n\nthe new test works with at least 2 volumes, one is used to boot an instance, the other one is attached to the instances. The volumes have specific types, the instance has a floating ip assigned and the write test (create/get timestamp) is performed on the attached volume/volumes.\n\n\nRe to the other comment:\nI agree with limiting the targeted number of hosts.","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"770f514b01640af8a0c08e450670d185502ac5c0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d842877f_3aac7891","in_reply_to":"cbe5c2fd_f2b397a7","updated":"2023-12-20 17:10:11.000000000","message":"I understand that running it on all the nodes sounds like a stress test, however, this test is supposed to have 2 modes (we forgot to implement one):\n1. run on a single node\n2. run on all the nodes\n\nIf the test is primarily supposed to run on a single node, would it make sense to have it in tempest? Running it on all the nodes would be just an extension as the main test logic would be already there.","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b4506a7113d36c900fbfa2129d4ca87c0ebab7f1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2e8edd6b_b463786b","in_reply_to":"d842877f_3aac7891","updated":"2023-12-20 20:01:29.000000000","message":"But if we are only adding it for single node tests then most of the things are covered in test_volume_boot_pattern test right? if not then we can extend tests or add extra assert there in new tests with specific thing not covered in existing test.\n\nRemember we used to have the large scale test in Tempest which used to boot lot of VM on all nodes but that was working only in nova fake driver not in real one and at the end we have to remove it from tempest.\n\nTempest should cover the specific scenario/integration testing not the stress testing.","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"764e01992d4ba66240a886924a6ca7d8c4efb574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"074efe5d_5e02ff86","updated":"2024-01-31 20:15:11.000000000","message":"After discussing on IRC, this almost lgtm, a few comments inline to address so that this new test can run in jobs.","commit_id":"d0729f1645fa48fab79aff6c3c21b21767dbf3c2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1bfd57a1c196a7730978f44d38b24ea33d7c82b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"fb0a70b2_beed8ee0","updated":"2024-01-25 06:14:51.000000000","message":"just restoring my -1.","commit_id":"d0729f1645fa48fab79aff6c3c21b21767dbf3c2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c83f23bd36bca80094d9d363819cfb439480b2d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"397e24a8_d82c8c68","updated":"2024-02-18 06:48:24.000000000","message":"recheck looks like a timeout","commit_id":"aa38c00d16456ecba4808522cc793fff95dc15e9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9f2e353af9bfb85635d2c30403bf31c5d58dbc52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"ce96b404_09a84649","updated":"2024-02-22 06:50:38.000000000","message":"this test is running but it is taking scary 638.344065s. I added a few of the idea to parallelize the operation and see how much it speed up.","commit_id":"c47d9762b06b8f19f5a2610d55764f05af9940e6"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"c1897e0521ce637170c3294fb05a1bd7b98c6caa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"e395399f_48b3e6ad","updated":"2024-02-25 12:04:51.000000000","message":"recheck unrelated error","commit_id":"1469b2653f597952d6d9b6701ed2ce8ad8057481"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b1673e5a07bacdf3d53e293f38841a8767961a08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"096fd77c_bfd45728","updated":"2024-02-26 14:09:13.000000000","message":"recheck\nLet\u0027s get more clues to investigate this issue","commit_id":"0ec6c2f44ec1803c540885acdea4e28338dbcfa2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ae17bd211160272cd1f67496bd4af5eea9fdb004","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"f189b7cb_18c3bb5b","updated":"2024-02-26 17:43:15.000000000","message":"seems like the previous couple of failures in tempest multinode job were just random timeouts","commit_id":"0ec6c2f44ec1803c540885acdea4e28338dbcfa2"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"e26072644adbd7f54a4947d6cea94ab80f21aaed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"91920567_4b4d9c63","updated":"2024-03-01 08:37:23.000000000","message":"recheck\nLet\u0027s see if error is caused by this patch","commit_id":"5aad3ad61b11f6fa6ab7dbae5ea3f35261e7a91e"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"6ee56dfb8f49cd9d4387aae6330f04ff1dca664f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"78099d58_e4b7d19e","updated":"2024-03-05 15:56:32.000000000","message":"recheck\nchecking if the flakiness of the test was fixed","commit_id":"bb273a0e37a229189255e12b6a8875933c98df68"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"499668a2b22e1ad39831fe63381b28a25357b8f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"5666c3b1_e8393851","updated":"2024-03-20 17:18:09.000000000","message":"293 sec this time so most of time it is \u003c300 so I am ok to merge it but let\u0027s wait for the caracel release in case this test start breaking things\n\n- https://zuul.opendev.org/t/openstack/build/d80d06c0175c45539affc0da09d06dbe/log/job-output.txt#34458","commit_id":"d7445981798aa7c4d2f8389749c8e474b51ac9fa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"11afbc09c32e91f44589b1c1332a3bfbc56aa024","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"be8b815b_d084770a","updated":"2024-04-05 19:39:27.000000000","message":"caracal is released now. let\u0027s see how it goes.","commit_id":"d7445981798aa7c4d2f8389749c8e474b51ac9fa"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c1f8ddc78309580a9575bf2e6cff2136525237f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"9c9a0f53_25f4d9df","updated":"2024-04-04 12:10:10.000000000","message":"lgtm, this time the test took 272 seconds\n\nhttps://210be1f5cbeabbdaba80-eeccdc6968a6b16fa4ca2e3ee7c1080d.ssl.cf2.rackcdn.com/898732/32/check/tempest-multinode-full-py3/4afea88/job-output.txt","commit_id":"d7445981798aa7c4d2f8389749c8e474b51ac9fa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7d09e868f12892014365faa255c0f0bdf0dd3444","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"72c36bd7_4d7d7836","updated":"2024-03-20 02:04:45.000000000","message":"recheck another run\n\n283 sec this time  https://zuul.opendev.org/t/openstack/build/f69f0248970a43fbb5bddbc4aae945dc/log/job-output.txt#34446","commit_id":"d7445981798aa7c4d2f8389749c8e474b51ac9fa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2fb1c4f85e03bef83719c222bb24743c973cf6d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"78a61d0f_07a910d6","updated":"2024-03-16 02:55:55.000000000","message":"recheck run test again","commit_id":"d7445981798aa7c4d2f8389749c8e474b51ac9fa"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"89f3238c1bc30fc21359cc145d6e2397c6e930ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"dffaafee_12dfd383","updated":"2024-04-03 12:02:41.000000000","message":"recheck to see the latest results","commit_id":"d7445981798aa7c4d2f8389749c8e474b51ac9fa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7862b9b1ef1013a1440ec401f2646f43fbe053d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"673a1875_ec7349fa","updated":"2024-03-16 02:55:47.000000000","message":"took 306 sec in another run https://zuul.opendev.org/t/openstack/build/5015426cc45a4da293872af58b36c0bf/log/job-output.txt#35706","commit_id":"d7445981798aa7c4d2f8389749c8e474b51ac9fa"}],"tempest/config.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1a95fe2acb827e102134893d77456699f345dba8","unresolved":true,"context_lines":[{"line_number":627,"context_line":"                     \u0027migration?\u0027),"},{"line_number":628,"context_line":"    cfg.StrOpt(\u0027volume_type_for_boot\u0027,"},{"line_number":629,"context_line":"               default\u003dNone,"},{"line_number":630,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":631,"context_line":"    cfg.StrOpt(\u0027volume_types_for_data_volume\u0027,"},{"line_number":632,"context_line":"               default\u003dNone,"},{"line_number":633,"context_line":"               help\u003d\u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"c497cc94_1fd52c30","line":630,"range":{"start_line":630,"start_character":20,"end_line":630,"end_character":23},"updated":"2023-11-13 13:37:12.000000000","message":"missing help","commit_id":"dd3645ee52f96c4f430dbebf8650191480ed63bb"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"54dae3640b6cff764984384625db9f6dffbbd9ea","unresolved":false,"context_lines":[{"line_number":627,"context_line":"                     \u0027migration?\u0027),"},{"line_number":628,"context_line":"    cfg.StrOpt(\u0027volume_type_for_boot\u0027,"},{"line_number":629,"context_line":"               default\u003dNone,"},{"line_number":630,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":631,"context_line":"    cfg.StrOpt(\u0027volume_types_for_data_volume\u0027,"},{"line_number":632,"context_line":"               default\u003dNone,"},{"line_number":633,"context_line":"               help\u003d\u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"870be717_792a3c68","line":630,"range":{"start_line":630,"start_character":20,"end_line":630,"end_character":23},"in_reply_to":"c497cc94_1fd52c30","updated":"2023-11-15 15:41:49.000000000","message":"Done","commit_id":"dd3645ee52f96c4f430dbebf8650191480ed63bb"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1a95fe2acb827e102134893d77456699f345dba8","unresolved":true,"context_lines":[{"line_number":630,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":631,"context_line":"    cfg.StrOpt(\u0027volume_types_for_data_volume\u0027,"},{"line_number":632,"context_line":"               default\u003dNone,"},{"line_number":633,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":634,"context_line":"    cfg.BoolOpt(\u0027volume_multiattach\u0027,"},{"line_number":635,"context_line":"                default\u003dFalse,"},{"line_number":636,"context_line":"                help\u003d\u0027Does the test environment support attaching a volume to \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"b9c76c60_280ef9aa","line":633,"range":{"start_line":633,"start_character":20,"end_line":633,"end_character":22},"updated":"2023-11-13 13:37:12.000000000","message":"missing help","commit_id":"dd3645ee52f96c4f430dbebf8650191480ed63bb"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"54dae3640b6cff764984384625db9f6dffbbd9ea","unresolved":false,"context_lines":[{"line_number":630,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":631,"context_line":"    cfg.StrOpt(\u0027volume_types_for_data_volume\u0027,"},{"line_number":632,"context_line":"               default\u003dNone,"},{"line_number":633,"context_line":"               help\u003d\u0027\u0027),"},{"line_number":634,"context_line":"    cfg.BoolOpt(\u0027volume_multiattach\u0027,"},{"line_number":635,"context_line":"                default\u003dFalse,"},{"line_number":636,"context_line":"                help\u003d\u0027Does the test environment support attaching a volume to \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"03517df6_9072e157","line":633,"range":{"start_line":633,"start_character":20,"end_line":633,"end_character":22},"in_reply_to":"b9c76c60_280ef9aa","updated":"2023-11-15 15:41:49.000000000","message":"Done","commit_id":"dd3645ee52f96c4f430dbebf8650191480ed63bb"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a9a22a0fba7b0383803c0a77a67fee14c0881b20","unresolved":true,"context_lines":[{"line_number":625,"context_line":"                default\u003dFalse,"},{"line_number":626,"context_line":"                help\u003d\u0027Does the test environment support volume-backed live \u0027"},{"line_number":627,"context_line":"                     \u0027migration?\u0027),"},{"line_number":628,"context_line":"    cfg.StrOpt(\u0027volume_type_for_boot\u0027,"},{"line_number":629,"context_line":"               default\u003dNone,"},{"line_number":630,"context_line":"               help\u003d\u0027Volume type used for boot volumes. One volume type \u0027"},{"line_number":631,"context_line":"                    \u0027can be assigned.\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"45e42cd4_e49e4afd","line":628,"range":{"start_line":628,"start_character":16,"end_line":628,"end_character":36},"updated":"2023-12-14 08:26:12.000000000","message":"as these new options are consumed only in a scenario test, they should belong to the ScenarioGroup on line 1205","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a9a22a0fba7b0383803c0a77a67fee14c0881b20","unresolved":true,"context_lines":[{"line_number":625,"context_line":"                default\u003dFalse,"},{"line_number":626,"context_line":"                help\u003d\u0027Does the test environment support volume-backed live \u0027"},{"line_number":627,"context_line":"                     \u0027migration?\u0027),"},{"line_number":628,"context_line":"    cfg.StrOpt(\u0027volume_type_for_boot\u0027,"},{"line_number":629,"context_line":"               default\u003dNone,"},{"line_number":630,"context_line":"               help\u003d\u0027Volume type used for boot volumes. One volume type \u0027"},{"line_number":631,"context_line":"                    \u0027can be assigned.\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"16ed7c76_91c8b773","line":628,"range":{"start_line":628,"start_character":16,"end_line":628,"end_character":36},"updated":"2023-12-14 08:26:12.000000000","message":"let\u0027s also add a releasenote for these new config options.\nExample: https://review.opendev.org/c/openstack/tempest/+/897231/10/releasenotes/notes/Add-resource_name_prefix-config-option-26e0b7cfeffc48f9.yaml","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":625,"context_line":"                default\u003dFalse,"},{"line_number":626,"context_line":"                help\u003d\u0027Does the test environment support volume-backed live \u0027"},{"line_number":627,"context_line":"                     \u0027migration?\u0027),"},{"line_number":628,"context_line":"    cfg.StrOpt(\u0027volume_type_for_boot\u0027,"},{"line_number":629,"context_line":"               default\u003dNone,"},{"line_number":630,"context_line":"               help\u003d\u0027Volume type used for boot volumes. One volume type \u0027"},{"line_number":631,"context_line":"                    \u0027can be assigned.\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"3d8c2b15_ee284be0","line":628,"range":{"start_line":628,"start_character":16,"end_line":628,"end_character":36},"in_reply_to":"16ed7c76_91c8b773","updated":"2023-12-15 13:58:24.000000000","message":"Done","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8ef31cb09526b2a14818bb884a31dff630e2157","unresolved":true,"context_lines":[{"line_number":625,"context_line":"                default\u003dFalse,"},{"line_number":626,"context_line":"                help\u003d\u0027Does the test environment support volume-backed live \u0027"},{"line_number":627,"context_line":"                     \u0027migration?\u0027),"},{"line_number":628,"context_line":"    cfg.StrOpt(\u0027volume_type_for_boot\u0027,"},{"line_number":629,"context_line":"               default\u003dNone,"},{"line_number":630,"context_line":"               help\u003d\u0027Volume type used for boot volumes. One volume type \u0027"},{"line_number":631,"context_line":"                    \u0027can be assigned.\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"bb5d5aae_c0a811f0","line":628,"range":{"start_line":628,"start_character":16,"end_line":628,"end_character":36},"in_reply_to":"45e42cd4_e49e4afd","updated":"2023-12-14 23:52:42.000000000","message":"not in scenario but volume_types are cinder things so it should be there not in compute or scenario section.\n\nBut how this is different from existing option \u0027volume_type\u0027 ? - https://review.opendev.org/c/openstack/tempest/+/898732/12/tempest/config.py#1020","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":625,"context_line":"                default\u003dFalse,"},{"line_number":626,"context_line":"                help\u003d\u0027Does the test environment support volume-backed live \u0027"},{"line_number":627,"context_line":"                     \u0027migration?\u0027),"},{"line_number":628,"context_line":"    cfg.StrOpt(\u0027volume_type_for_boot\u0027,"},{"line_number":629,"context_line":"               default\u003dNone,"},{"line_number":630,"context_line":"               help\u003d\u0027Volume type used for boot volumes. One volume type \u0027"},{"line_number":631,"context_line":"                    \u0027can be assigned.\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"c73a2aaa_420c4a87","line":628,"range":{"start_line":628,"start_character":16,"end_line":628,"end_character":36},"in_reply_to":"bb5d5aae_c0a811f0","updated":"2023-12-15 13:58:24.000000000","message":"Yeah you are right, this option seems to have same purpose. I think we can delete this option then.","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8ef31cb09526b2a14818bb884a31dff630e2157","unresolved":true,"context_lines":[{"line_number":629,"context_line":"               default\u003dNone,"},{"line_number":630,"context_line":"               help\u003d\u0027Volume type used for boot volumes. One volume type \u0027"},{"line_number":631,"context_line":"                    \u0027can be assigned.\u0027),"},{"line_number":632,"context_line":"    cfg.StrOpt(\u0027volume_types_for_data_volume\u0027,"},{"line_number":633,"context_line":"               default\u003dNone,"},{"line_number":634,"context_line":"               help\u003d\u0027Volume types used for data volumes. Multiple volume \u0027"},{"line_number":635,"context_line":"                    \u0027types can be assigned.\u0027),"},{"line_number":636,"context_line":"    cfg.BoolOpt(\u0027volume_multiattach\u0027,"},{"line_number":637,"context_line":"                default\u003dFalse,"},{"line_number":638,"context_line":"                help\u003d\u0027Does the test environment support attaching a volume to \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"56613477_e5502618","line":635,"range":{"start_line":632,"start_character":0,"end_line":635,"end_character":46},"updated":"2023-12-14 23:52:42.000000000","message":"what is the main purpose for this? please explain why this config is must for this scenario testing?","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":629,"context_line":"               default\u003dNone,"},{"line_number":630,"context_line":"               help\u003d\u0027Volume type used for boot volumes. One volume type \u0027"},{"line_number":631,"context_line":"                    \u0027can be assigned.\u0027),"},{"line_number":632,"context_line":"    cfg.StrOpt(\u0027volume_types_for_data_volume\u0027,"},{"line_number":633,"context_line":"               default\u003dNone,"},{"line_number":634,"context_line":"               help\u003d\u0027Volume types used for data volumes. Multiple volume \u0027"},{"line_number":635,"context_line":"                    \u0027types can be assigned.\u0027),"},{"line_number":636,"context_line":"    cfg.BoolOpt(\u0027volume_multiattach\u0027,"},{"line_number":637,"context_line":"                default\u003dFalse,"},{"line_number":638,"context_line":"                help\u003d\u0027Does the test environment support attaching a volume to \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"16cacf83_37002478","line":635,"range":{"start_line":632,"start_character":0,"end_line":635,"end_character":46},"in_reply_to":"56613477_e5502618","updated":"2023-12-15 13:58:24.000000000","message":"In this option we specify types of volumes which are attached to the instance. It can be multiple volumes.","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"}],"tempest/scenario/test_instances_with_cinder_volumes.py":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"532e3822b7849140f345fb81ffd6c464dfe2bde5","unresolved":true,"context_lines":[{"line_number":44,"context_line":"                  \"volume_type_for_boot must be specified\""},{"line_number":45,"context_line":"            raise cls.skipException(msg)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def create_and_add_security_group_to_server(self, server):"},{"line_number":48,"context_line":"        secgroup \u003d self.create_security_group()"},{"line_number":49,"context_line":"        self.servers_client.add_security_group(server[\u0027id\u0027],"},{"line_number":50,"context_line":"                                               name\u003dsecgroup[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ad73a23c_4582e481","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":62},"updated":"2023-11-08 17:15:02.000000000","message":"Just an idea. Don\u0027t we want to move this function to ScenarioTest class [1]? It is also used here [2]. \n\n[1] https://opendev.org/openstack/tempest/src/branch/master/tempest/scenario/manager.py\n[2] https://opendev.org/openstack/tempest/src/branch/master/tempest/scenario/test_minimum_basic.py#L76","commit_id":"dd3645ee52f96c4f430dbebf8650191480ed63bb"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1a95fe2acb827e102134893d77456699f345dba8","unresolved":true,"context_lines":[{"line_number":44,"context_line":"                  \"volume_type_for_boot must be specified\""},{"line_number":45,"context_line":"            raise cls.skipException(msg)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def create_and_add_security_group_to_server(self, server):"},{"line_number":48,"context_line":"        secgroup \u003d self.create_security_group()"},{"line_number":49,"context_line":"        self.servers_client.add_security_group(server[\u0027id\u0027],"},{"line_number":50,"context_line":"                                               name\u003dsecgroup[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"c1bc4bca_e1e68265","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":62},"in_reply_to":"ad73a23c_4582e481","updated":"2023-11-13 13:37:12.000000000","message":"++ good catch, yes, let\u0027s define that function only once in tempest/scenario/manager.py","commit_id":"dd3645ee52f96c4f430dbebf8650191480ed63bb"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"54dae3640b6cff764984384625db9f6dffbbd9ea","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                  \"volume_type_for_boot must be specified\""},{"line_number":45,"context_line":"            raise cls.skipException(msg)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def create_and_add_security_group_to_server(self, server):"},{"line_number":48,"context_line":"        secgroup \u003d self.create_security_group()"},{"line_number":49,"context_line":"        self.servers_client.add_security_group(server[\u0027id\u0027],"},{"line_number":50,"context_line":"                                               name\u003dsecgroup[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"4cb8a873_e605f3a8","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":62},"in_reply_to":"c1bc4bca_e1e68265","updated":"2023-11-15 15:41:49.000000000","message":"Done","commit_id":"dd3645ee52f96c4f430dbebf8650191480ed63bb"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1a95fe2acb827e102134893d77456699f345dba8","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027d0e3c1a3-4b0a-4b0e-8b0a-4b0e8b0a4b0e\u0027)"},{"line_number":67,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":68,"context_line":"    def test_instances_with_cinder_volumes_on_all_compute_nodes(self):"},{"line_number":69,"context_line":"        \"\"\"Test instances with cinder volumes launches on all compute nodes"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        Steps:"}],"source_content_type":"text/x-python","patch_set":4,"id":"198a5b02_40038472","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":63},"updated":"2023-11-13 13:37:12.000000000","message":"did you test this locally Jakub? Do you think we could run this test in a multinode job?","commit_id":"dd3645ee52f96c4f430dbebf8650191480ed63bb"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027d0e3c1a3-4b0a-4b0e-8b0a-4b0e8b0a4b0e\u0027)"},{"line_number":67,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":68,"context_line":"    def test_instances_with_cinder_volumes_on_all_compute_nodes(self):"},{"line_number":69,"context_line":"        \"\"\"Test instances with cinder volumes launches on all compute nodes"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        Steps:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1646bb22_786daafd","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":63},"in_reply_to":"04715147_ce496b94","updated":"2023-12-15 13:58:24.000000000","message":"Done","commit_id":"dd3645ee52f96c4f430dbebf8650191480ed63bb"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"54dae3640b6cff764984384625db9f6dffbbd9ea","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027d0e3c1a3-4b0a-4b0e-8b0a-4b0e8b0a4b0e\u0027)"},{"line_number":67,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":68,"context_line":"    def test_instances_with_cinder_volumes_on_all_compute_nodes(self):"},{"line_number":69,"context_line":"        \"\"\"Test instances with cinder volumes launches on all compute nodes"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        Steps:"}],"source_content_type":"text/x-python","patch_set":4,"id":"04715147_ce496b94","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":63},"in_reply_to":"198a5b02_40038472","updated":"2023-11-15 15:41:49.000000000","message":"Yeah I test this on multinode enviroment and it worked.","commit_id":"dd3645ee52f96c4f430dbebf8650191480ed63bb"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"93bc12a3b4e5972f55b0e35e2e83ba0300962ea0","unresolved":true,"context_lines":[{"line_number":107,"context_line":"                volume_type\u003dCONF.compute_feature_enabled.volume_type_for_boot)"},{"line_number":108,"context_line":"            # attach boot volume to instance"},{"line_number":109,"context_line":"            volume \u003d self.nova_volume_attach(server, volume)"},{"line_number":110,"context_line":"            self.addCleanup(self.nova_volume_detach, server, volume)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"            # Create and attach volumes of different types to the instance"},{"line_number":113,"context_line":"            attached_volumes \u003d []  # Store the attached volumes for cleanup"}],"source_content_type":"text/x-python","patch_set":6,"id":"752ab678_93de2423","line":110,"updated":"2023-11-16 08:32:26.000000000","message":"Maybe I\u0027m missing something but is this cleanup necessary? There is already one in the nova_volume_detach() [1]. \n\n[1] https://opendev.org/openstack/tempest/src/commit/cc0e9b18170bc796fd8516e41d2ec09236b168aa/tempest/scenario/manager.py#L892","commit_id":"27ef72111a85e754204ddf8983f9763593ee962a"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"828128f0e4169a79d4aad5d75971f41b79e9b3aa","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                volume_type\u003dCONF.compute_feature_enabled.volume_type_for_boot)"},{"line_number":108,"context_line":"            # attach boot volume to instance"},{"line_number":109,"context_line":"            volume \u003d self.nova_volume_attach(server, volume)"},{"line_number":110,"context_line":"            self.addCleanup(self.nova_volume_detach, server, volume)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"            # Create and attach volumes of different types to the instance"},{"line_number":113,"context_line":"            attached_volumes \u003d []  # Store the attached volumes for cleanup"}],"source_content_type":"text/x-python","patch_set":6,"id":"8b84f45d_d87629d9","line":110,"in_reply_to":"752ab678_93de2423","updated":"2023-11-20 12:52:33.000000000","message":"I see, thanks :)","commit_id":"27ef72111a85e754204ddf8983f9763593ee962a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"93bc12a3b4e5972f55b0e35e2e83ba0300962ea0","unresolved":true,"context_lines":[{"line_number":116,"context_line":"                self.nova_volume_attach(server, volume)"},{"line_number":117,"context_line":"                attached_volumes.append(volume)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"                print(attached_volumes)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            # Set up cleanup for the attached volumes"},{"line_number":122,"context_line":"            for volume in attached_volumes:"}],"source_content_type":"text/x-python","patch_set":6,"id":"f0e9f6ef_af294b53","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":5},"updated":"2023-11-16 08:32:26.000000000","message":"Do we want to keep this print? Maybe we can use logging instead [1]?\n\n[1] https://opendev.org/openstack/tempest/src/commit/cc0e9b18170bc796fd8516e41d2ec09236b168aa/tempest/scenario/manager.py#L935","commit_id":"27ef72111a85e754204ddf8983f9763593ee962a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"7d9aa88d295491b9e9b52bec8fe4679b38e6a2dd","unresolved":true,"context_lines":[{"line_number":116,"context_line":"                self.nova_volume_attach(server, volume)"},{"line_number":117,"context_line":"                attached_volumes.append(volume)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"                print(attached_volumes)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            # Set up cleanup for the attached volumes"},{"line_number":122,"context_line":"            for volume in attached_volumes:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5321ff28_5fa469ef","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":5},"in_reply_to":"310e6aa9_8dda6f4b","updated":"2023-11-21 09:01:52.000000000","message":"Ok:), now there is a pep8 issue but it should be fixed quickly.","commit_id":"27ef72111a85e754204ddf8983f9763593ee962a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"dff18c00fae57455bbe39435df709b6b5342c7c8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                self.nova_volume_attach(server, volume)"},{"line_number":117,"context_line":"                attached_volumes.append(volume)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"                print(attached_volumes)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            # Set up cleanup for the attached volumes"},{"line_number":122,"context_line":"            for volume in attached_volumes:"}],"source_content_type":"text/x-python","patch_set":6,"id":"b66ffe6b_66e39aa4","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":5},"in_reply_to":"5321ff28_5fa469ef","updated":"2023-11-21 12:19:21.000000000","message":"Done","commit_id":"27ef72111a85e754204ddf8983f9763593ee962a"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"828128f0e4169a79d4aad5d75971f41b79e9b3aa","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                self.nova_volume_attach(server, volume)"},{"line_number":117,"context_line":"                attached_volumes.append(volume)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"                print(attached_volumes)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            # Set up cleanup for the attached volumes"},{"line_number":122,"context_line":"            for volume in attached_volumes:"}],"source_content_type":"text/x-python","patch_set":6,"id":"310e6aa9_8dda6f4b","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":5},"in_reply_to":"f0e9f6ef_af294b53","updated":"2023-11-20 12:52:33.000000000","message":"Yeah, it was used just for debugging. I think it is useful info, so i replaced that print with logging as you said.","commit_id":"27ef72111a85e754204ddf8983f9763593ee962a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"a9934ce5000cfbc6bb9fc746253fab0456cfca71","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            self.addCleanup(self.nova_volume_detach, server, volume)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"            # Create and attach volumes of different types to the instance"},{"line_number":113,"context_line":"            attached_volumes \u003d []  # Store the attached volumes for cleanup"},{"line_number":114,"context_line":"            for vol_type in volume_types:"},{"line_number":115,"context_line":"                volume \u003d self.create_volume(volume_type\u003dvol_type)"},{"line_number":116,"context_line":"                self.nova_volume_attach(server, volume)"}],"source_content_type":"text/x-python","patch_set":8,"id":"a9a8202d_e3572769","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":2},"updated":"2023-11-21 14:03:46.000000000","message":"Do we really need this? It seems like this is the only place where we are using this variable. The create_volume() should add the cleanup as well [1].\n\n[1] https://opendev.org/openstack/tempest/src/commit/cc0e9b18170bc796fd8516e41d2ec09236b168aa/tempest/scenario/manager.py#L388","commit_id":"3b5c54fdb773c0e7f35873ce0a336f4752fa61b8"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"8530a5e6ca8eadeb0073709ae25bd0eeaacfb91f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            self.addCleanup(self.nova_volume_detach, server, volume)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"            # Create and attach volumes of different types to the instance"},{"line_number":113,"context_line":"            attached_volumes \u003d []  # Store the attached volumes for cleanup"},{"line_number":114,"context_line":"            for vol_type in volume_types:"},{"line_number":115,"context_line":"                volume \u003d self.create_volume(volume_type\u003dvol_type)"},{"line_number":116,"context_line":"                self.nova_volume_attach(server, volume)"}],"source_content_type":"text/x-python","patch_set":8,"id":"2680f9ea_e65228d1","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":2},"in_reply_to":"a9a8202d_e3572769","updated":"2023-11-27 20:35:49.000000000","message":"Done","commit_id":"3b5c54fdb773c0e7f35873ce0a336f4752fa61b8"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"a9934ce5000cfbc6bb9fc746253fab0456cfca71","unresolved":true,"context_lines":[{"line_number":140,"context_line":"            )"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"            # write test through ssh connection"},{"line_number":143,"context_line":"            timestamp_before \u003d self.create_timestamp("},{"line_number":144,"context_line":"                ssh_ip, private_key\u003dkeypair[\u0027private_key\u0027], server\u003dserver)"},{"line_number":145,"context_line":"            timestamp_after \u003d self.get_timestamp("},{"line_number":146,"context_line":"                ssh_ip, private_key\u003dkeypair[\u0027private_key\u0027], server\u003dserver)"}],"source_content_type":"text/x-python","patch_set":8,"id":"39e9d07b_4ec29013","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":2},"updated":"2023-11-21 14:03:46.000000000","message":"I\u0027m sorry for writing a comment again. This time I\u0027m not sure but I want to write this. I\u0027m assuming that you want to write to the volumes attached on line 116. If my assumption is wrong then you can ignore this :D. \n\nHow can we be sure here that we are really writing the timestamp to the attached volumes? I guess that there can be multiple volumes attached to a single instance (?) and yet the create_timestamp() function writes always to the same directory /tmp [1].\n\n[1] https://opendev.org/openstack/tempest/src/commit/cc0e9b18170bc796fd8516e41d2ec09236b168aa/tempest/scenario/manager.py#L1122","commit_id":"3b5c54fdb773c0e7f35873ce0a336f4752fa61b8"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"8530a5e6ca8eadeb0073709ae25bd0eeaacfb91f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            )"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"            # write test through ssh connection"},{"line_number":143,"context_line":"            timestamp_before \u003d self.create_timestamp("},{"line_number":144,"context_line":"                ssh_ip, private_key\u003dkeypair[\u0027private_key\u0027], server\u003dserver)"},{"line_number":145,"context_line":"            timestamp_after \u003d self.get_timestamp("},{"line_number":146,"context_line":"                ssh_ip, private_key\u003dkeypair[\u0027private_key\u0027], server\u003dserver)"}],"source_content_type":"text/x-python","patch_set":8,"id":"59c5c4c6_cd8a9223","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":2},"in_reply_to":"39e9d07b_4ec29013","updated":"2023-11-27 20:35:49.000000000","message":"Yeah good point Lukas, thanks. I added argumet dev_name as we spoke.","commit_id":"3b5c54fdb773c0e7f35873ce0a336f4752fa61b8"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"69470ec285b5c7d1f3015382de644f3137b24c97","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        # create instances in available zones"},{"line_number":102,"context_line":"        for host in hosts[:CONF.compute.min_compute_nodes]:"},{"line_number":103,"context_line":"            # create instance"},{"line_number":104,"context_line":"            server \u003d self.create_server("},{"line_number":105,"context_line":"                image_id\u003dimage,"},{"line_number":106,"context_line":"                key_name\u003dkeypair[\u0027name\u0027])"},{"line_number":107,"context_line":"            # create boot volume with image and type specified at boot_volume"},{"line_number":108,"context_line":"            volume \u003d self.create_volume("},{"line_number":109,"context_line":"                imageRef\u003dimage, volume_type\u003dboot_volume)"}],"source_content_type":"text/x-python","patch_set":9,"id":"acd8fbb6_b3ce1907","line":106,"range":{"start_line":104,"start_character":12,"end_line":106,"end_character":41},"updated":"2023-11-28 11:00:54.000000000","message":"Aren\u0027t we supposed to create this server from a boot volume? I\u0027m just following the test description. You can ignore this if it is not a relevant question.","commit_id":"9a877fa4b71b11322b6ae181a79397d520dc5bbc"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4c51fe9febc93bfafa9ba920689d250ebcacd68e","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        # create instances in available zones"},{"line_number":102,"context_line":"        for host in hosts[:CONF.compute.min_compute_nodes]:"},{"line_number":103,"context_line":"            # create instance"},{"line_number":104,"context_line":"            server \u003d self.create_server("},{"line_number":105,"context_line":"                image_id\u003dimage,"},{"line_number":106,"context_line":"                key_name\u003dkeypair[\u0027name\u0027])"},{"line_number":107,"context_line":"            # create boot volume with image and type specified at boot_volume"},{"line_number":108,"context_line":"            volume \u003d self.create_volume("},{"line_number":109,"context_line":"                imageRef\u003dimage, volume_type\u003dboot_volume)"}],"source_content_type":"text/x-python","patch_set":9,"id":"e8880c6c_c3b88d93","line":106,"range":{"start_line":104,"start_character":12,"end_line":106,"end_character":41},"in_reply_to":"acd8fbb6_b3ce1907","updated":"2023-12-04 13:54:29.000000000","message":"correct, we want to create an instance from a volume that was created from the image in tempest.conf (mostly cirros) and it\u0027s of volume_type_for_boot type","commit_id":"9a877fa4b71b11322b6ae181a79397d520dc5bbc"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # create instances in available zones"},{"line_number":102,"context_line":"        for host in hosts[:CONF.compute.min_compute_nodes]:"},{"line_number":103,"context_line":"            # create instance"},{"line_number":104,"context_line":"            server \u003d self.create_server("},{"line_number":105,"context_line":"                image_id\u003dimage,"},{"line_number":106,"context_line":"                key_name\u003dkeypair[\u0027name\u0027])"},{"line_number":107,"context_line":"            # create boot volume with image and type specified at boot_volume"},{"line_number":108,"context_line":"            volume \u003d self.create_volume("},{"line_number":109,"context_line":"                imageRef\u003dimage, volume_type\u003dboot_volume)"}],"source_content_type":"text/x-python","patch_set":9,"id":"716eeca6_cdb65eb1","line":106,"range":{"start_line":104,"start_character":12,"end_line":106,"end_character":41},"in_reply_to":"e8880c6c_c3b88d93","updated":"2023-12-15 13:58:24.000000000","message":"Done","commit_id":"9a877fa4b71b11322b6ae181a79397d520dc5bbc"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"69470ec285b5c7d1f3015382de644f3137b24c97","unresolved":true,"context_lines":[{"line_number":119,"context_line":"                LOG.debug(\"Attached volume %s to server %s\","},{"line_number":120,"context_line":"                          volume[\u0027id\u0027], server[\u0027id\u0027])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        for instance in servers:"},{"line_number":123,"context_line":"            # assign floating ip"},{"line_number":124,"context_line":"            if (CONF.network_feature_enabled.floating_ips and"},{"line_number":125,"context_line":"                CONF.network.floating_network_name):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f204548_4bfcb349","line":122,"range":{"start_line":122,"start_character":24,"end_line":122,"end_character":31},"updated":"2023-11-28 11:00:54.000000000","message":"Do we ever get into this loop? The servers variable is initialized as an empty list and is never updated (line 99).","commit_id":"9a877fa4b71b11322b6ae181a79397d520dc5bbc"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4c51fe9febc93bfafa9ba920689d250ebcacd68e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                LOG.debug(\"Attached volume %s to server %s\","},{"line_number":120,"context_line":"                          volume[\u0027id\u0027], server[\u0027id\u0027])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        for instance in servers:"},{"line_number":123,"context_line":"            # assign floating ip"},{"line_number":124,"context_line":"            if (CONF.network_feature_enabled.floating_ips and"},{"line_number":125,"context_line":"                CONF.network.floating_network_name):"}],"source_content_type":"text/x-python","patch_set":9,"id":"d1e96131_39ab348f","line":122,"range":{"start_line":122,"start_character":24,"end_line":122,"end_character":31},"in_reply_to":"3f204548_4bfcb349","updated":"2023-12-04 13:54:29.000000000","message":"Done","commit_id":"9a877fa4b71b11322b6ae181a79397d520dc5bbc"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"69470ec285b5c7d1f3015382de644f3137b24c97","unresolved":true,"context_lines":[{"line_number":150,"context_line":"                )"},{"line_number":151,"context_line":"                timestamp_after \u003d self.get_timestamp("},{"line_number":152,"context_line":"                    ssh_ip, private_key\u003dkeypair[\u0027private_key\u0027], server\u003dserver,"},{"line_number":153,"context_line":"                    dev_name\u003dvolume"},{"line_number":154,"context_line":"                )"},{"line_number":155,"context_line":"                self.assertEqual(timestamp_before, timestamp_after)"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"54555f6a_67f5e1ba","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":2},"updated":"2023-11-28 11:00:54.000000000","message":"Thank you Kuba for updating this. I think that the dev_name should be the name of a device in the VM of the attached volume (volume[\u0027attachments\u0027][0][\u0027device\u0027]). Right now you are passing a volume type.","commit_id":"9a877fa4b71b11322b6ae181a79397d520dc5bbc"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4c51fe9febc93bfafa9ba920689d250ebcacd68e","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                )"},{"line_number":151,"context_line":"                timestamp_after \u003d self.get_timestamp("},{"line_number":152,"context_line":"                    ssh_ip, private_key\u003dkeypair[\u0027private_key\u0027], server\u003dserver,"},{"line_number":153,"context_line":"                    dev_name\u003dvolume"},{"line_number":154,"context_line":"                )"},{"line_number":155,"context_line":"                self.assertEqual(timestamp_before, timestamp_after)"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"17ba120a_1e055099","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":2},"in_reply_to":"54555f6a_67f5e1ba","updated":"2023-12-04 13:54:29.000000000","message":"Done","commit_id":"9a877fa4b71b11322b6ae181a79397d520dc5bbc"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4c51fe9febc93bfafa9ba920689d250ebcacd68e","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        Steps:"},{"line_number":55,"context_line":"        1. Create an image"},{"line_number":56,"context_line":"        2. Create a keypair"},{"line_number":57,"context_line":"        3. Create boot volumes with the image and volume types"},{"line_number":58,"context_line":"        4. Boot instances with the volume on all compute nodes"},{"line_number":59,"context_line":"        5. Create volumes based on volume_types_for_data_volume"},{"line_number":60,"context_line":"        6. Attach volumes of each volume type to an instance"}],"source_content_type":"text/x-python","patch_set":10,"id":"e6bfab86_580877b5","line":57,"range":{"start_line":57,"start_character":12,"end_line":57,"end_character":62},"updated":"2023-12-04 13:54:29.000000000","message":"Create a boot volume from the image and of the given volume type (volume_type_for_boot)","commit_id":"57b7e5ac3a9bb395fabfc3ae55a2b0a7fb2d24d8"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        Steps:"},{"line_number":55,"context_line":"        1. Create an image"},{"line_number":56,"context_line":"        2. Create a keypair"},{"line_number":57,"context_line":"        3. Create boot volumes with the image and volume types"},{"line_number":58,"context_line":"        4. Boot instances with the volume on all compute nodes"},{"line_number":59,"context_line":"        5. Create volumes based on volume_types_for_data_volume"},{"line_number":60,"context_line":"        6. Attach volumes of each volume type to an instance"}],"source_content_type":"text/x-python","patch_set":10,"id":"97bfe8f0_d97d4f17","line":57,"range":{"start_line":57,"start_character":12,"end_line":57,"end_character":62},"in_reply_to":"e6bfab86_580877b5","updated":"2023-12-15 13:58:24.000000000","message":"Done","commit_id":"57b7e5ac3a9bb395fabfc3ae55a2b0a7fb2d24d8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4c51fe9febc93bfafa9ba920689d250ebcacd68e","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        1. Create an image"},{"line_number":56,"context_line":"        2. Create a keypair"},{"line_number":57,"context_line":"        3. Create boot volumes with the image and volume types"},{"line_number":58,"context_line":"        4. Boot instances with the volume on all compute nodes"},{"line_number":59,"context_line":"        5. Create volumes based on volume_types_for_data_volume"},{"line_number":60,"context_line":"        6. Attach volumes of each volume type to an instance"},{"line_number":61,"context_line":"        7. Assign floating IP to all instances"}],"source_content_type":"text/x-python","patch_set":10,"id":"aa2511bc_4f71c0c8","line":58,"range":{"start_line":58,"start_character":11,"end_line":58,"end_character":62},"updated":"2023-12-04 13:54:29.000000000","message":"let\u0027s rephrase is to that it\u0027s more clear what we\u0027re up to, something like:\n\"Boot an instance from the boot volume on each compute node.\"","commit_id":"57b7e5ac3a9bb395fabfc3ae55a2b0a7fb2d24d8"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        1. Create an image"},{"line_number":56,"context_line":"        2. Create a keypair"},{"line_number":57,"context_line":"        3. Create boot volumes with the image and volume types"},{"line_number":58,"context_line":"        4. Boot instances with the volume on all compute nodes"},{"line_number":59,"context_line":"        5. Create volumes based on volume_types_for_data_volume"},{"line_number":60,"context_line":"        6. Attach volumes of each volume type to an instance"},{"line_number":61,"context_line":"        7. Assign floating IP to all instances"}],"source_content_type":"text/x-python","patch_set":10,"id":"756ac9c8_ed4429bf","line":58,"range":{"start_line":58,"start_character":11,"end_line":58,"end_character":62},"in_reply_to":"aa2511bc_4f71c0c8","updated":"2023-12-15 13:58:24.000000000","message":"Done","commit_id":"57b7e5ac3a9bb395fabfc3ae55a2b0a7fb2d24d8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4c51fe9febc93bfafa9ba920689d250ebcacd68e","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        2. Create a keypair"},{"line_number":57,"context_line":"        3. Create boot volumes with the image and volume types"},{"line_number":58,"context_line":"        4. Boot instances with the volume on all compute nodes"},{"line_number":59,"context_line":"        5. Create volumes based on volume_types_for_data_volume"},{"line_number":60,"context_line":"        6. Attach volumes of each volume type to an instance"},{"line_number":61,"context_line":"        7. Assign floating IP to all instances"},{"line_number":62,"context_line":"        8. Configure security group for ssh access to all instances"}],"source_content_type":"text/x-python","patch_set":10,"id":"09b29058_b6d768f2","line":59,"range":{"start_line":59,"start_character":11,"end_line":59,"end_character":63},"updated":"2023-12-04 13:54:29.000000000","message":"Create a volume using each volume_types_for_data_volume on all compute nodes. Total number of volumes \u003d compute nodes * len(volume_types_for_data_volume)","commit_id":"57b7e5ac3a9bb395fabfc3ae55a2b0a7fb2d24d8"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        2. Create a keypair"},{"line_number":57,"context_line":"        3. Create boot volumes with the image and volume types"},{"line_number":58,"context_line":"        4. Boot instances with the volume on all compute nodes"},{"line_number":59,"context_line":"        5. Create volumes based on volume_types_for_data_volume"},{"line_number":60,"context_line":"        6. Attach volumes of each volume type to an instance"},{"line_number":61,"context_line":"        7. Assign floating IP to all instances"},{"line_number":62,"context_line":"        8. Configure security group for ssh access to all instances"}],"source_content_type":"text/x-python","patch_set":10,"id":"d018bb01_023c5f4d","line":59,"range":{"start_line":59,"start_character":11,"end_line":59,"end_character":63},"in_reply_to":"09b29058_b6d768f2","updated":"2023-12-15 13:58:24.000000000","message":"Done","commit_id":"57b7e5ac3a9bb395fabfc3ae55a2b0a7fb2d24d8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4c51fe9febc93bfafa9ba920689d250ebcacd68e","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        3. Create boot volumes with the image and volume types"},{"line_number":58,"context_line":"        4. Boot instances with the volume on all compute nodes"},{"line_number":59,"context_line":"        5. Create volumes based on volume_types_for_data_volume"},{"line_number":60,"context_line":"        6. Attach volumes of each volume type to an instance"},{"line_number":61,"context_line":"        7. Assign floating IP to all instances"},{"line_number":62,"context_line":"        8. Configure security group for ssh access to all instances"},{"line_number":63,"context_line":"        9. Confirm ssh access to all instances"}],"source_content_type":"text/x-python","patch_set":10,"id":"579a9033_aec5b212","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":2},"updated":"2023-12-04 13:54:29.000000000","message":"Attach the volumes to the instances","commit_id":"57b7e5ac3a9bb395fabfc3ae55a2b0a7fb2d24d8"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        3. Create boot volumes with the image and volume types"},{"line_number":58,"context_line":"        4. Boot instances with the volume on all compute nodes"},{"line_number":59,"context_line":"        5. Create volumes based on volume_types_for_data_volume"},{"line_number":60,"context_line":"        6. Attach volumes of each volume type to an instance"},{"line_number":61,"context_line":"        7. Assign floating IP to all instances"},{"line_number":62,"context_line":"        8. Configure security group for ssh access to all instances"},{"line_number":63,"context_line":"        9. Confirm ssh access to all instances"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f6e0546_c2984420","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":2},"in_reply_to":"579a9033_aec5b212","updated":"2023-12-15 13:58:24.000000000","message":"Done","commit_id":"57b7e5ac3a9bb395fabfc3ae55a2b0a7fb2d24d8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4c51fe9febc93bfafa9ba920689d250ebcacd68e","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        10. Run write test to all volumes through ssh connection per instance"},{"line_number":65,"context_line":"        11. Clean up the sources, an instance, volumes, keypair and image"},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":"        boot_volume \u003d CONF.compute_feature_enabled.volume_type_for_boot"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # create an image"},{"line_number":70,"context_line":"        image \u003d self.image_create()"}],"source_content_type":"text/x-python","patch_set":10,"id":"38965d8f_bd8cf3d4","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":19},"updated":"2023-12-04 13:54:29.000000000","message":"practically this isn\u0027t a volume, it\u0027s just a volume type .. so maybe boot_volume_type would be a better naming option?","commit_id":"57b7e5ac3a9bb395fabfc3ae55a2b0a7fb2d24d8"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        10. Run write test to all volumes through ssh connection per instance"},{"line_number":65,"context_line":"        11. Clean up the sources, an instance, volumes, keypair and image"},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":"        boot_volume \u003d CONF.compute_feature_enabled.volume_type_for_boot"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # create an image"},{"line_number":70,"context_line":"        image \u003d self.image_create()"}],"source_content_type":"text/x-python","patch_set":10,"id":"d1bc6e52_993f0031","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":19},"in_reply_to":"38965d8f_bd8cf3d4","updated":"2023-12-15 13:58:24.000000000","message":"Done","commit_id":"57b7e5ac3a9bb395fabfc3ae55a2b0a7fb2d24d8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8ef31cb09526b2a14818bb884a31dff630e2157","unresolved":true,"context_lines":[{"line_number":39,"context_line":"            CONF.compute.min_microversion \u003c \"2.60\":"},{"line_number":40,"context_line":"            raise cls.skipException(\"Multiattach volume feature requires \""},{"line_number":41,"context_line":"                                    \"microversion 2.60 or greater\")"},{"line_number":42,"context_line":"        if not CONF.service_available.cinder:"},{"line_number":43,"context_line":"            raise cls.skipException(\"Cinder is not available\")"},{"line_number":44,"context_line":"        if not (CONF.compute_feature_enabled.volume_types_for_data_volume and"},{"line_number":45,"context_line":"                CONF.compute_feature_enabled.volume_type_for_boot):"},{"line_number":46,"context_line":"            msg \u003d \"Both volume_types_for_data_volume and \" \\"}],"source_content_type":"text/x-python","patch_set":12,"id":"43ebc51a_be302765","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":62},"updated":"2023-12-14 23:52:42.000000000","message":"you do not need to add this condition as L51 check the same.","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            CONF.compute.min_microversion \u003c \"2.60\":"},{"line_number":40,"context_line":"            raise cls.skipException(\"Multiattach volume feature requires \""},{"line_number":41,"context_line":"                                    \"microversion 2.60 or greater\")"},{"line_number":42,"context_line":"        if not CONF.service_available.cinder:"},{"line_number":43,"context_line":"            raise cls.skipException(\"Cinder is not available\")"},{"line_number":44,"context_line":"        if not (CONF.compute_feature_enabled.volume_types_for_data_volume and"},{"line_number":45,"context_line":"                CONF.compute_feature_enabled.volume_type_for_boot):"},{"line_number":46,"context_line":"            msg \u003d \"Both volume_types_for_data_volume and \" \\"}],"source_content_type":"text/x-python","patch_set":12,"id":"b37086d0_1ddabaeb","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":62},"in_reply_to":"43ebc51a_be302765","updated":"2023-12-15 13:58:24.000000000","message":"Thanks I didn\u0027t noticed this.","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8ef31cb09526b2a14818bb884a31dff630e2157","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        Steps:"},{"line_number":56,"context_line":"            1. Create an image"},{"line_number":57,"context_line":"            2. Create a keypair"},{"line_number":58,"context_line":"            3. Create a boot volume from the image and of the given volume"},{"line_number":59,"context_line":"               type"},{"line_number":60,"context_line":"            4. Boot an instance from the boot volume on each compute node"},{"line_number":61,"context_line":"            5. Create a volume using each volume_types_for_data_volume on all"}],"source_content_type":"text/x-python","patch_set":12,"id":"254c490a_11bd1e59","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":29},"updated":"2023-12-14 23:52:42.000000000","message":"bootable","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        Steps:"},{"line_number":56,"context_line":"            1. Create an image"},{"line_number":57,"context_line":"            2. Create a keypair"},{"line_number":58,"context_line":"            3. Create a boot volume from the image and of the given volume"},{"line_number":59,"context_line":"               type"},{"line_number":60,"context_line":"            4. Boot an instance from the boot volume on each compute node"},{"line_number":61,"context_line":"            5. Create a volume using each volume_types_for_data_volume on all"}],"source_content_type":"text/x-python","patch_set":12,"id":"d34b6923_14659d97","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":29},"in_reply_to":"254c490a_11bd1e59","updated":"2023-12-15 13:58:24.000000000","message":"Done","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8ef31cb09526b2a14818bb884a31dff630e2157","unresolved":true,"context_lines":[{"line_number":57,"context_line":"            2. Create a keypair"},{"line_number":58,"context_line":"            3. Create a boot volume from the image and of the given volume"},{"line_number":59,"context_line":"               type"},{"line_number":60,"context_line":"            4. Boot an instance from the boot volume on each compute node"},{"line_number":61,"context_line":"            5. Create a volume using each volume_types_for_data_volume on all"},{"line_number":62,"context_line":"               compute nodes. Total number of volumes is equal to"},{"line_number":63,"context_line":"               compute nodes * len(volume_types_for_data_volume)"}],"source_content_type":"text/x-python","patch_set":12,"id":"565db71f_d3385dc7","line":60,"range":{"start_line":60,"start_character":41,"end_line":60,"end_character":46},"updated":"2023-12-14 23:52:42.000000000","message":"bootable","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            2. Create a keypair"},{"line_number":58,"context_line":"            3. Create a boot volume from the image and of the given volume"},{"line_number":59,"context_line":"               type"},{"line_number":60,"context_line":"            4. Boot an instance from the boot volume on each compute node"},{"line_number":61,"context_line":"            5. Create a volume using each volume_types_for_data_volume on all"},{"line_number":62,"context_line":"               compute nodes. Total number of volumes is equal to"},{"line_number":63,"context_line":"               compute nodes * len(volume_types_for_data_volume)"}],"source_content_type":"text/x-python","patch_set":12,"id":"b36c93df_119f1bac","line":60,"range":{"start_line":60,"start_character":41,"end_line":60,"end_character":46},"in_reply_to":"565db71f_d3385dc7","updated":"2023-12-15 13:58:24.000000000","message":"Done","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8ef31cb09526b2a14818bb884a31dff630e2157","unresolved":true,"context_lines":[{"line_number":56,"context_line":"            1. Create an image"},{"line_number":57,"context_line":"            2. Create a keypair"},{"line_number":58,"context_line":"            3. Create a boot volume from the image and of the given volume"},{"line_number":59,"context_line":"               type"},{"line_number":60,"context_line":"            4. Boot an instance from the boot volume on each compute node"},{"line_number":61,"context_line":"            5. Create a volume using each volume_types_for_data_volume on all"},{"line_number":62,"context_line":"               compute nodes. Total number of volumes is equal to"},{"line_number":63,"context_line":"               compute nodes * len(volume_types_for_data_volume)"},{"line_number":64,"context_line":"            6. Attach volumes to the instances"},{"line_number":65,"context_line":"            7. Assign floating IP to all instances"},{"line_number":66,"context_line":"            8. Configure security group for ssh access to all instances"},{"line_number":67,"context_line":"            9. Confirm ssh access to all instances"},{"line_number":68,"context_line":"            10. Run write test to all volumes through ssh connection per"},{"line_number":69,"context_line":"                instance"},{"line_number":70,"context_line":"            11. Clean up the sources, an instance, volumes, keypair and image"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        boot_volume_type \u003d CONF.compute_feature_enabled.volume_type_for_boot"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # create an image"}],"source_content_type":"text/x-python","patch_set":12,"id":"1bee4c76_0c6137c3","line":71,"range":{"start_line":59,"start_character":10,"end_line":71,"end_character":11},"updated":"2023-12-14 23:52:42.000000000","message":"this seems a very heavy load tests and it will be good to see how much time it takes to finish.\n\nAlso, before we add such test I would like to know what is specific thing it test which are not covered in existing one for example in test_volume_boot_pattern.py.\n\nis this to test the stress tests on services if they can create server boot from volume on all the compute nodes at the same time?","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            1. Create an image"},{"line_number":57,"context_line":"            2. Create a keypair"},{"line_number":58,"context_line":"            3. Create a boot volume from the image and of the given volume"},{"line_number":59,"context_line":"               type"},{"line_number":60,"context_line":"            4. Boot an instance from the boot volume on each compute node"},{"line_number":61,"context_line":"            5. Create a volume using each volume_types_for_data_volume on all"},{"line_number":62,"context_line":"               compute nodes. Total number of volumes is equal to"},{"line_number":63,"context_line":"               compute nodes * len(volume_types_for_data_volume)"},{"line_number":64,"context_line":"            6. Attach volumes to the instances"},{"line_number":65,"context_line":"            7. Assign floating IP to all instances"},{"line_number":66,"context_line":"            8. Configure security group for ssh access to all instances"},{"line_number":67,"context_line":"            9. Confirm ssh access to all instances"},{"line_number":68,"context_line":"            10. Run write test to all volumes through ssh connection per"},{"line_number":69,"context_line":"                instance"},{"line_number":70,"context_line":"            11. Clean up the sources, an instance, volumes, keypair and image"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        boot_volume_type \u003d CONF.compute_feature_enabled.volume_type_for_boot"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # create an image"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f7eb82e_23093b75","line":71,"range":{"start_line":59,"start_character":10,"end_line":71,"end_character":11},"in_reply_to":"1bee4c76_0c6137c3","updated":"2023-12-15 13:58:24.000000000","message":"Yeah its basically as you said, it is creating instance on all compute nodes and then it attach same volumes to all instances on all nodes.","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eedb738f0d2e6f10e959c572162fd72020aa95ea","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            1. Create an image"},{"line_number":57,"context_line":"            2. Create a keypair"},{"line_number":58,"context_line":"            3. Create a boot volume from the image and of the given volume"},{"line_number":59,"context_line":"               type"},{"line_number":60,"context_line":"            4. Boot an instance from the boot volume on each compute node"},{"line_number":61,"context_line":"            5. Create a volume using each volume_types_for_data_volume on all"},{"line_number":62,"context_line":"               compute nodes. Total number of volumes is equal to"},{"line_number":63,"context_line":"               compute nodes * len(volume_types_for_data_volume)"},{"line_number":64,"context_line":"            6. Attach volumes to the instances"},{"line_number":65,"context_line":"            7. Assign floating IP to all instances"},{"line_number":66,"context_line":"            8. Configure security group for ssh access to all instances"},{"line_number":67,"context_line":"            9. Confirm ssh access to all instances"},{"line_number":68,"context_line":"            10. Run write test to all volumes through ssh connection per"},{"line_number":69,"context_line":"                instance"},{"line_number":70,"context_line":"            11. Clean up the sources, an instance, volumes, keypair and image"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        boot_volume_type \u003d CONF.compute_feature_enabled.volume_type_for_boot"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # create an image"}],"source_content_type":"text/x-python","patch_set":12,"id":"57522d46_b437897b","line":71,"range":{"start_line":59,"start_character":10,"end_line":71,"end_character":11},"in_reply_to":"9f7eb82e_23093b75","updated":"2023-12-15 18:21:26.000000000","message":"ok, so we do create instance, boot from volume, attach volume in a few of the tests so how different is this test from other?\n\nand can you link where this test run it will be interesting to see run time of this stress test.","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a9a22a0fba7b0383803c0a77a67fee14c0881b20","unresolved":true,"context_lines":[{"line_number":69,"context_line":"                instance"},{"line_number":70,"context_line":"            11. Clean up the sources, an instance, volumes, keypair and image"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        boot_volume_type \u003d CONF.compute_feature_enabled.volume_type_for_boot"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # create an image"},{"line_number":75,"context_line":"        image \u003d self.image_create()"}],"source_content_type":"text/x-python","patch_set":12,"id":"72e5d0a5_368cd569","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":24},"updated":"2023-12-14 08:26:12.000000000","message":"I have a question for a further discussion, would it make sense to create boot_volume_type and volume_types_for_data_volume if they don\u0027t exist? It would allow us to run this test in the upstream CI. However, what I\u0027m not so sure about, if it would be a valid test case.","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"770f514b01640af8a0c08e450670d185502ac5c0","unresolved":true,"context_lines":[{"line_number":69,"context_line":"                instance"},{"line_number":70,"context_line":"            11. Clean up the sources, an instance, volumes, keypair and image"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        boot_volume_type \u003d CONF.compute_feature_enabled.volume_type_for_boot"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # create an image"},{"line_number":75,"context_line":"        image \u003d self.image_create()"}],"source_content_type":"text/x-python","patch_set":12,"id":"a6ab1755_d66679aa","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":24},"in_reply_to":"23aaec34_3ad47ada","updated":"2023-12-20 17:10:11.000000000","message":"ok, sounds good, we can make it optional","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"959e7d77c811ac5a9032981cebea1783e95619c6","unresolved":true,"context_lines":[{"line_number":69,"context_line":"                instance"},{"line_number":70,"context_line":"            11. Clean up the sources, an instance, volumes, keypair and image"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        boot_volume_type \u003d CONF.compute_feature_enabled.volume_type_for_boot"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # create an image"},{"line_number":75,"context_line":"        image \u003d self.image_create()"}],"source_content_type":"text/x-python","patch_set":12,"id":"baf2125a_c91de8ea","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":24},"in_reply_to":"72e5d0a5_368cd569","updated":"2023-12-14 13:23:57.000000000","message":"Adding my two cents. Do not know whether this helps, but I think that volume types are created in upstream by lib/cinder during the deployment if multiple-storage backend is used [1][2][3]. So we could theoretically run this test if we enable multiple-storage backend like in this cinder job [4]. What we could do is to update devstack so that it sets the newly introduced config options during the deployment [5].\n\nI\u0027m not sure how we would approach creating the volume type on tempest side. I do not know much about how they work. For example how we would select properties for such volume types? Are there properties which can always be used for a volume type?\n\n[1] https://docs.openstack.org/cinder/latest/admin/multi-backend.html\n[2] https://opendev.org/openstack/devstack/src/commit/6b0f055b4ed407f8a190f768d0e654235ac015dd/lib/cinder#L91\n[3] https://opendev.org/openstack/devstack/src/commit/6b0f055b4ed407f8a190f768d0e654235ac015dd/lib/cinder#L658\n[4] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_5d6/887559/16/check/cinder-tempest-lvm-multibackend/5d677eb/controller/logs/local_conf.txt\n[5] https://opendev.org/openstack/devstack/src/commit/6b0f055b4ed407f8a190f768d0e654235ac015dd/lib/tempest#L553","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"764e01992d4ba66240a886924a6ca7d8c4efb574","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                instance"},{"line_number":70,"context_line":"            11. Clean up the sources, an instance, volumes, keypair and image"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        boot_volume_type \u003d CONF.compute_feature_enabled.volume_type_for_boot"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # create an image"},{"line_number":75,"context_line":"        image \u003d self.image_create()"}],"source_content_type":"text/x-python","patch_set":12,"id":"63a66de3_f360f22f","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":24},"in_reply_to":"a6ab1755_d66679aa","updated":"2024-01-31 20:15:11.000000000","message":"Done","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eedb738f0d2e6f10e959c572162fd72020aa95ea","unresolved":true,"context_lines":[{"line_number":69,"context_line":"                instance"},{"line_number":70,"context_line":"            11. Clean up the sources, an instance, volumes, keypair and image"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        boot_volume_type \u003d CONF.compute_feature_enabled.volume_type_for_boot"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # create an image"},{"line_number":75,"context_line":"        image \u003d self.image_create()"}],"source_content_type":"text/x-python","patch_set":12,"id":"23aaec34_3ad47ada","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":24},"in_reply_to":"baf2125a_c91de8ea","updated":"2023-12-15 18:21:26.000000000","message":"volume type is only mandatory for multi storage backend where volume scheduler select the volume service/backend where volume to be created based on volume_typeso it should not be must for tests. If anyone running these tests in multi storage backend then they can configure the volume_type otherwise not required.","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a9a22a0fba7b0383803c0a77a67fee14c0881b20","unresolved":true,"context_lines":[{"line_number":135,"context_line":"                    fip, server)"},{"line_number":136,"context_line":"                ssh_ip \u003d floating_ip[\u0027floating_ip_address\u0027]"},{"line_number":137,"context_line":"            else:"},{"line_number":138,"context_line":"                ssh_ip \u003d self.get_server_ip(server)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"            # create security group"},{"line_number":141,"context_line":"            self.create_and_add_security_group_to_server(server)"}],"source_content_type":"text/x-python","patch_set":12,"id":"74c94166_884f5cf8","line":138,"range":{"start_line":138,"start_character":30,"end_line":138,"end_character":43},"updated":"2023-12-14 08:26:12.000000000","message":"isn\u0027t the goal of the test to assign a floating ip to each instance? If yes, then we shouldn\u0027t have this else statement here, should we? Networking isn\u0027t my strong suit, can we perform write test on the instances if they aren\u0027t assigned floating ip?","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7424c8d0760bc54e9e4f11f2192e80785570b0b8","unresolved":true,"context_lines":[{"line_number":135,"context_line":"                    fip, server)"},{"line_number":136,"context_line":"                ssh_ip \u003d floating_ip[\u0027floating_ip_address\u0027]"},{"line_number":137,"context_line":"            else:"},{"line_number":138,"context_line":"                ssh_ip \u003d self.get_server_ip(server)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"            # create security group"},{"line_number":141,"context_line":"            self.create_and_add_security_group_to_server(server)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9743d2c2_6cdc6116","line":138,"range":{"start_line":138,"start_character":30,"end_line":138,"end_character":43},"in_reply_to":"1bebe9d7_c0bcced1","updated":"2023-12-14 14:08:34.000000000","message":"ok, then we need to answer only this: is the purpose of the test to run the write test over a connection through floating ip? if yes, then we can\u0027t have the else statement and the test has to always allocate and assign a fip.","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"959e7d77c811ac5a9032981cebea1783e95619c6","unresolved":true,"context_lines":[{"line_number":135,"context_line":"                    fip, server)"},{"line_number":136,"context_line":"                ssh_ip \u003d floating_ip[\u0027floating_ip_address\u0027]"},{"line_number":137,"context_line":"            else:"},{"line_number":138,"context_line":"                ssh_ip \u003d self.get_server_ip(server)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"            # create security group"},{"line_number":141,"context_line":"            self.create_and_add_security_group_to_server(server)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1bebe9d7_c0bcced1","line":138,"range":{"start_line":138,"start_character":30,"end_line":138,"end_character":43},"in_reply_to":"74c94166_884f5cf8","updated":"2023-12-14 13:23:57.000000000","message":"\u003e Networking isn\u0027t my strong suit, can we perform write test on the instances if they aren\u0027t assigned floating ip?\n\nI\u0027m not confident with my networking skills either. I\u0027m adding it here for reference. In this function, we can see that they are able to get ssh connection to an instance even without the floating ip [1][2] if validation.network_for_ssh and validation.ip_version_for_ssh are set.\n\n[1] https://opendev.org/openstack/tempest/src/commit/ab3686d28d2728001e3bd2fd543575087bf00137/tempest/scenario/test_server_basic_ops.py#L53\n[2] https://opendev.org/openstack/tempest/src/commit/ab3686d28d2728001e3bd2fd543575087bf00137/tempest/common/compute.py#L60","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"aaf83d14c11c59c099bf3e8a397210e707100742","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                    fip, server)"},{"line_number":136,"context_line":"                ssh_ip \u003d floating_ip[\u0027floating_ip_address\u0027]"},{"line_number":137,"context_line":"            else:"},{"line_number":138,"context_line":"                ssh_ip \u003d self.get_server_ip(server)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"            # create security group"},{"line_number":141,"context_line":"            self.create_and_add_security_group_to_server(server)"}],"source_content_type":"text/x-python","patch_set":12,"id":"fde3abb5_ae2cdf3d","line":138,"range":{"start_line":138,"start_character":30,"end_line":138,"end_character":43},"in_reply_to":"9743d2c2_6cdc6116","updated":"2023-12-15 13:58:24.000000000","message":"Yeah, you are right, I think the purpose is run write test over a connection through floating IP, so I deleted else statement.","commit_id":"04b2cb5d8880667e96dd00a3071aa7afcc7d4a40"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eedb738f0d2e6f10e959c572162fd72020aa95ea","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def skip_checks(cls):"},{"line_number":37,"context_line":"        super(TestInstancesWithCinderVolumes, cls).skip_checks()"},{"line_number":38,"context_line":"        if not CONF.compute.min_microversion or \\"},{"line_number":39,"context_line":"            CONF.compute.min_microversion \u003c \"2.60\":"},{"line_number":40,"context_line":"            raise cls.skipException(\"Multiattach volume feature requires \""},{"line_number":41,"context_line":"                                    \"microversion 2.60 or greater\")"},{"line_number":42,"context_line":"        if not (CONF.volume_feature_enabled.volume_types_for_data_volume and"},{"line_number":43,"context_line":"                CONF.volume.volume_type):"},{"line_number":44,"context_line":"            msg \u003d \"Both volume_types_for_data_volume and \" \\"}],"source_content_type":"text/x-python","patch_set":13,"id":"c5800038_b2bdbb67","line":41,"range":{"start_line":38,"start_character":0,"end_line":41,"end_character":67},"updated":"2023-12-15 18:21:26.000000000","message":"so this can go at the class level with compute_min_microversion\u003d\u00272.60\u0027","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"af4845cc9f8ae3613094b1b309252b49b01fa76b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def skip_checks(cls):"},{"line_number":37,"context_line":"        super(TestInstancesWithCinderVolumes, cls).skip_checks()"},{"line_number":38,"context_line":"        if not CONF.compute.min_microversion or \\"},{"line_number":39,"context_line":"            CONF.compute.min_microversion \u003c \"2.60\":"},{"line_number":40,"context_line":"            raise cls.skipException(\"Multiattach volume feature requires \""},{"line_number":41,"context_line":"                                    \"microversion 2.60 or greater\")"},{"line_number":42,"context_line":"        if not (CONF.volume_feature_enabled.volume_types_for_data_volume and"},{"line_number":43,"context_line":"                CONF.volume.volume_type):"},{"line_number":44,"context_line":"            msg \u003d \"Both volume_types_for_data_volume and \" \\"}],"source_content_type":"text/x-python","patch_set":13,"id":"71b89364_698da785","line":41,"range":{"start_line":38,"start_character":0,"end_line":41,"end_character":67},"in_reply_to":"c5800038_b2bdbb67","updated":"2024-01-16 10:51:54.000000000","message":"Done","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eedb738f0d2e6f10e959c572162fd72020aa95ea","unresolved":true,"context_lines":[{"line_number":39,"context_line":"            CONF.compute.min_microversion \u003c \"2.60\":"},{"line_number":40,"context_line":"            raise cls.skipException(\"Multiattach volume feature requires \""},{"line_number":41,"context_line":"                                    \"microversion 2.60 or greater\")"},{"line_number":42,"context_line":"        if not (CONF.volume_feature_enabled.volume_types_for_data_volume and"},{"line_number":43,"context_line":"                CONF.volume.volume_type):"},{"line_number":44,"context_line":"            msg \u003d \"Both volume_types_for_data_volume and \" \\"},{"line_number":45,"context_line":"                  \"volume_type_for_boot must be specified\""},{"line_number":46,"context_line":"            raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"4e0e1052_777e1735","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":41},"updated":"2023-12-15 18:21:26.000000000","message":"why we want to skip the tests for these. cannot we create volume without volume_type? If we cannot then default value as \u0027\u0027 for these options are wrong. We should not have this skip condition.","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"58f03600908caf81bb730f72748ca70321fc5b67","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            CONF.compute.min_microversion \u003c \"2.60\":"},{"line_number":40,"context_line":"            raise cls.skipException(\"Multiattach volume feature requires \""},{"line_number":41,"context_line":"                                    \"microversion 2.60 or greater\")"},{"line_number":42,"context_line":"        if not (CONF.volume_feature_enabled.volume_types_for_data_volume and"},{"line_number":43,"context_line":"                CONF.volume.volume_type):"},{"line_number":44,"context_line":"            msg \u003d \"Both volume_types_for_data_volume and \" \\"},{"line_number":45,"context_line":"                  \"volume_type_for_boot must be specified\""},{"line_number":46,"context_line":"            raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"dd6708b8_ee657597","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":41},"in_reply_to":"0cb183a2_93a1c266","updated":"2024-03-15 18:00:18.000000000","message":"Done","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"770f514b01640af8a0c08e450670d185502ac5c0","unresolved":true,"context_lines":[{"line_number":39,"context_line":"            CONF.compute.min_microversion \u003c \"2.60\":"},{"line_number":40,"context_line":"            raise cls.skipException(\"Multiattach volume feature requires \""},{"line_number":41,"context_line":"                                    \"microversion 2.60 or greater\")"},{"line_number":42,"context_line":"        if not (CONF.volume_feature_enabled.volume_types_for_data_volume and"},{"line_number":43,"context_line":"                CONF.volume.volume_type):"},{"line_number":44,"context_line":"            msg \u003d \"Both volume_types_for_data_volume and \" \\"},{"line_number":45,"context_line":"                  \"volume_type_for_boot must be specified\""},{"line_number":46,"context_line":"            raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"eae6c98f_8fe9c4ce","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":41},"in_reply_to":"4e0e1052_777e1735","updated":"2023-12-20 17:10:11.000000000","message":"we could, the question is if we want to, we just need to align on what we want the test to test. As it\u0027s right now, the step 5 of the test states \"Create a volume using each volume_types_for_data_volume\" .. therefore the test is skipped if the opt is not set - it\u0027s a requirement to set volume types ... we can come up with a default volume types though and use those unless overwritten by the opt","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"764e01992d4ba66240a886924a6ca7d8c4efb574","unresolved":true,"context_lines":[{"line_number":39,"context_line":"            CONF.compute.min_microversion \u003c \"2.60\":"},{"line_number":40,"context_line":"            raise cls.skipException(\"Multiattach volume feature requires \""},{"line_number":41,"context_line":"                                    \"microversion 2.60 or greater\")"},{"line_number":42,"context_line":"        if not (CONF.volume_feature_enabled.volume_types_for_data_volume and"},{"line_number":43,"context_line":"                CONF.volume.volume_type):"},{"line_number":44,"context_line":"            msg \u003d \"Both volume_types_for_data_volume and \" \\"},{"line_number":45,"context_line":"                  \"volume_type_for_boot must be specified\""},{"line_number":46,"context_line":"            raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"0cb183a2_93a1c266","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":41},"in_reply_to":"eae6c98f_8fe9c4ce","updated":"2024-01-31 20:15:11.000000000","message":"I think using default volume type is good instead of adding new config options. \n\nThis test is not run anywhere I think bcz of these condition it is skipped - https://zuul.opendev.org/t/openstack/build/fd944f90856346869e45cc178c94fd2b/log/job-output.txt#24068\n\nWe already have two config option for volume_type of volume_type of multiattach https://github.com/openstack/tempest/blob/60a374b4fc619772f4e4d4f90a7c16bb44152218/tempest/config.py#L972-L975","commit_id":"17f154fc32dbdb852ac6b351938dca22ab1a1582"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"764e01992d4ba66240a886924a6ca7d8c4efb574","unresolved":true,"context_lines":[{"line_number":44,"context_line":"            raise cls.skipException(msg)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @decorators.idempotent_id(\u0027d0e3c1a3-4b0a-4b0e-8b0a-4b0e8b0a4b0e\u0027)"},{"line_number":47,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":48,"context_line":"    def test_instances_with_cinder_volumes_on_all_compute_nodes(self):"},{"line_number":49,"context_line":"        \"\"\"Test instances with cinder volumes launches on all compute nodes"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"5941ca12_5ec15e5b","line":47,"range":{"start_line":47,"start_character":59,"end_line":47,"end_character":60},"updated":"2024-01-31 20:15:11.000000000","message":"This test is not running in multinode job as it is not tagged as \u0027multinode\u0027\n- https://zuul.opendev.org/t/openstack/build/a2a7e9fcb04b4c5cb17ef84d428c5270/log/job-output.txt\n\nLet\u0027s tag this slow and multinode both\n\n@decorators.attr(type\u003d[\u0027slow\u0027, \u0027multinode\u0027])","commit_id":"d0729f1645fa48fab79aff6c3c21b21767dbf3c2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0900d507e46b41baef3ba212852dd5480de4f34b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            raise cls.skipException(msg)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @decorators.idempotent_id(\u0027d0e3c1a3-4b0a-4b0e-8b0a-4b0e8b0a4b0e\u0027)"},{"line_number":47,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":48,"context_line":"    def test_instances_with_cinder_volumes_on_all_compute_nodes(self):"},{"line_number":49,"context_line":"        \"\"\"Test instances with cinder volumes launches on all compute nodes"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"5b53e832_d40be592","line":47,"range":{"start_line":47,"start_character":59,"end_line":47,"end_character":60},"in_reply_to":"5941ca12_5ec15e5b","updated":"2024-02-12 22:46:50.000000000","message":"Done","commit_id":"d0729f1645fa48fab79aff6c3c21b21767dbf3c2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"764e01992d4ba66240a886924a6ca7d8c4efb574","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        boot_volume \u003d self.create_volume("},{"line_number":104,"context_line":"            imageRef\u003dimage, volume_type\u003dboot_volume_type"},{"line_number":105,"context_line":"        )"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # create instances in available zones"},{"line_number":108,"context_line":"        for host in hosts[:CONF.compute.min_compute_nodes]:"},{"line_number":109,"context_line":"            attached_volumes \u003d []"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"            # create an instance from bootable volume"}],"source_content_type":"text/x-python","patch_set":15,"id":"2bf5394b_c87e2c9e","line":108,"range":{"start_line":106,"start_character":0,"end_line":108,"end_character":59},"updated":"2024-01-31 20:15:11.000000000","message":"++, thanks for point it out in IRC, this resolve my concern of stress testing on all compute node. Can we add logs also here so that we know what all hosts are choosen to boot server:\n\n\nhosts_to_boot_servers \u003d hosts[:CONF.compute.min_compute_nodes]\nLOG.debug(\"List of hosts selected to boot servers %s: \",\n                          hosts_to_boot_servers)\n                          \n# create instances in available zones\nfor host in hosts_to_boot_servers:","commit_id":"d0729f1645fa48fab79aff6c3c21b21767dbf3c2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0900d507e46b41baef3ba212852dd5480de4f34b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        boot_volume \u003d self.create_volume("},{"line_number":104,"context_line":"            imageRef\u003dimage, volume_type\u003dboot_volume_type"},{"line_number":105,"context_line":"        )"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # create instances in available zones"},{"line_number":108,"context_line":"        for host in hosts[:CONF.compute.min_compute_nodes]:"},{"line_number":109,"context_line":"            attached_volumes \u003d []"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"            # create an instance from bootable volume"}],"source_content_type":"text/x-python","patch_set":15,"id":"da95d826_6172899c","line":108,"range":{"start_line":106,"start_character":0,"end_line":108,"end_character":59},"in_reply_to":"2bf5394b_c87e2c9e","updated":"2024-02-12 22:46:50.000000000","message":"Done","commit_id":"d0729f1645fa48fab79aff6c3c21b21767dbf3c2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ff501e976b045394d3e40d8913f48f6c1466d456","unresolved":true,"context_lines":[{"line_number":112,"context_line":"            attached_volumes \u003d []"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            # create an instance from bootable volume"},{"line_number":115,"context_line":"            server \u003d self.boot_instance_from_resource("},{"line_number":116,"context_line":"                source_id\u003dboot_volume[\u0027id\u0027],"},{"line_number":117,"context_line":"                source_type\u003d\u0027volume\u0027,"},{"line_number":118,"context_line":"                keypair\u003dkeypair"}],"source_content_type":"text/x-python","patch_set":22,"id":"8882f171_c627674b","line":115,"range":{"start_line":115,"start_character":26,"end_line":115,"end_character":53},"updated":"2024-02-19 08:09:13.000000000","message":"```\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/common/utils/__init__.py\", line 70, in wrapper\n    return f(*func_args, **func_kwargs)\n  File \"/opt/stack/tempest/tempest/scenario/test_instances_with_cinder_volumes.py\", line 115, in test_instances_with_cinder_volumes_on_all_compute_nodes\n    server \u003d self.boot_instance_from_resource(\n  File \"/opt/stack/tempest/tempest/scenario/manager.py\", line 1351, in boot_instance_from_resource\n    return self.create_server(**create_kwargs)\n  File \"/opt/stack/tempest/tempest/scenario/manager.py\", line 349, in create_server\n    body, _ \u003d compute.create_test_server(\n  File \"/opt/stack/tempest/tempest/common/compute.py\", line 287, in create_test_server\n    body \u003d clients.servers_client.create_server(name\u003dname, imageRef\u003dimage_id,\n  File \"/opt/stack/tempest/tempest/lib/services/compute/servers_client.py\", line 115, in create_server\n    resp, body \u003d self.post(\u0027servers\u0027, post_body)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 300, in post\n    return self.request(\u0027POST\u0027, url, extra_headers, headers, body, chunked)\n  File \"/opt/stack/tempest/tempest/lib/services/compute/base_compute_client.py\", line 47, in request\n    resp, resp_body \u003d super(BaseComputeClient, self).request(\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 742, in request\n    self._error_checker(resp, resp_body)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 857, in _error_checker\n    raise exceptions.BadRequest(resp_body, resp\u003dresp)\ntempest.lib.exceptions.BadRequest: Bad request\nDetails: {\u0027code\u0027: 400, \u0027message\u0027: \u0027Invalid volume: Invalid input received: Invalid volume: Volume ef35aa1f-a191-40b8-86e2-87e1eac85ebd status must be available or downloading to reserve, but the current status is in-use. (HTTP 400) (Request-ID: req-6943846c-8244-4314-94da-d50cb0eab61b)\u0027}\n```","commit_id":"aa38c00d16456ecba4808522cc793fff95dc15e9"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ae17bd211160272cd1f67496bd4af5eea9fdb004","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            attached_volumes \u003d []"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            # create an instance from bootable volume"},{"line_number":115,"context_line":"            server \u003d self.boot_instance_from_resource("},{"line_number":116,"context_line":"                source_id\u003dboot_volume[\u0027id\u0027],"},{"line_number":117,"context_line":"                source_type\u003d\u0027volume\u0027,"},{"line_number":118,"context_line":"                keypair\u003dkeypair"}],"source_content_type":"text/x-python","patch_set":22,"id":"7d29937c_59f9b334","line":115,"range":{"start_line":115,"start_character":26,"end_line":115,"end_character":53},"in_reply_to":"8882f171_c627674b","updated":"2024-02-26 17:43:15.000000000","message":"Done","commit_id":"aa38c00d16456ecba4808522cc793fff95dc15e9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9f2e353af9bfb85635d2c30403bf31c5d58dbc52","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            attached_volumes \u003d []"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            # create boot volume from image and of the given volume type"},{"line_number":110,"context_line":"            boot_volume \u003d self.create_volume("},{"line_number":111,"context_line":"                imageRef\u003dimage, volume_type\u003dboot_volume_type"},{"line_number":112,"context_line":"            )"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            # create an instance from bootable volume"},{"line_number":115,"context_line":"            server \u003d self.boot_instance_from_resource("}],"source_content_type":"text/x-python","patch_set":23,"id":"631c5566_b661bcab","line":112,"range":{"start_line":110,"start_character":0,"end_line":112,"end_character":13},"updated":"2024-02-22 06:50:38.000000000","message":"here we are creating volume and waiting for the them to become \u0027available\u0027 one by one which take time. let\u0027s do the below:\n\n1. create all volume without waiting for \u0027available\u0027 state:\n    \n        bootable_volumes \u003d []\n        for host in hosts_to_boot_servers:\n            # create boot volume from image and of the given volume type\n            bootable_volume \u003d self.create_volume(\n                imageRef\u003dimage, volume_type\u003dboot_volume_type, wait_until\u003dNone\n            )\n            bootable_volumes.append(bootable_volume )\n            \n\n2. wait for volume available state:\n\n\n        for bootable_volume in bootable_volumes:\n            waiters.wait_for_volume_resource_status(self.volumes_client,\n                                                bootable_volume[\u0027id\u0027], \u0027available\u0027)\n            )\n            \n\n3. boot server:\n\n        servers \u003d []\n        for bootable_volume in bootable_volumes:\n            # create an instance from bootable volume\n            server \u003d self.boot_instance_from_resource(\n                source_id\u003dbootable_volume[\u0027id\u0027],\n                source_type\u003d\u0027volume\u0027,\n                keypair\u003dkeypair,\n                wait_until\u003dNone\n            )\n            servers.append(server)\n\n4. Wait for server to be boot properly:\n\n        for server in servers:\n        network \u003d self.get_tenant_network()\n\n        validation_resources \u003d self.get_test_validation_resources(\n            self.os_primary)\n            server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]\n            compute.wait_for_ssh_or_ping(server, self.os_primary, network,\n                                         True, validation_resources,\n                                         \u0027SSHABLE\u0027, True)","commit_id":"c47d9762b06b8f19f5a2610d55764f05af9940e6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9f2e353af9bfb85635d2c30403bf31c5d58dbc52","unresolved":true,"context_lines":[{"line_number":103,"context_line":"                  hosts_to_boot_servers)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # create instances in available zones"},{"line_number":106,"context_line":"        for host in hosts_to_boot_servers:"},{"line_number":107,"context_line":"            attached_volumes \u003d []"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            # create boot volume from image and of the given volume type"},{"line_number":110,"context_line":"            boot_volume \u003d self.create_volume("},{"line_number":111,"context_line":"                imageRef\u003dimage, volume_type\u003dboot_volume_type"},{"line_number":112,"context_line":"            )"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            # create an instance from bootable volume"},{"line_number":115,"context_line":"            server \u003d self.boot_instance_from_resource("},{"line_number":116,"context_line":"                source_id\u003dboot_volume[\u0027id\u0027],"},{"line_number":117,"context_line":"                source_type\u003d\u0027volume\u0027,"},{"line_number":118,"context_line":"                keypair\u003dkeypair"}],"source_content_type":"text/x-python","patch_set":23,"id":"82e00a2c_2f6103cd","line":115,"range":{"start_line":106,"start_character":0,"end_line":115,"end_character":54},"updated":"2024-02-22 06:50:38.000000000","message":"seeing the logs, this test taking 638.344065s which is very long running. \n\n- https://zuul.opendev.org/t/openstack/build/1c8e732447eb4ccfb39534fada6e83f6/log/job-output.txt#34693\n\nand only for two hosts:\n\"List of hosts selected to boot servers [{\u0027zone\u0027: \u0027nova\u0027, \u0027host_name\u0027: \u0027np0036804081\u0027}, {\u0027zone\u0027: \u0027nova\u0027, \u0027host_name\u0027: \u0027np0036804085\u0027}]\"\n\n- https://zuul.opendev.org/t/openstack/build/1c8e732447eb4ccfb39534fada6e83f6/log/controller/logs/tempest_log.txt#12846\n\nI have a few idea to run the operations in parallel to speed up the test. Commenting those per operation.","commit_id":"c47d9762b06b8f19f5a2610d55764f05af9940e6"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ae17bd211160272cd1f67496bd4af5eea9fdb004","unresolved":true,"context_lines":[{"line_number":103,"context_line":"                  hosts_to_boot_servers)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # create instances in available zones"},{"line_number":106,"context_line":"        for host in hosts_to_boot_servers:"},{"line_number":107,"context_line":"            attached_volumes \u003d []"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            # create boot volume from image and of the given volume type"},{"line_number":110,"context_line":"            boot_volume \u003d self.create_volume("},{"line_number":111,"context_line":"                imageRef\u003dimage, volume_type\u003dboot_volume_type"},{"line_number":112,"context_line":"            )"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            # create an instance from bootable volume"},{"line_number":115,"context_line":"            server \u003d self.boot_instance_from_resource("},{"line_number":116,"context_line":"                source_id\u003dboot_volume[\u0027id\u0027],"},{"line_number":117,"context_line":"                source_type\u003d\u0027volume\u0027,"},{"line_number":118,"context_line":"                keypair\u003dkeypair"}],"source_content_type":"text/x-python","patch_set":23,"id":"cc73de27_9240e8a7","line":115,"range":{"start_line":106,"start_character":0,"end_line":115,"end_character":54},"in_reply_to":"82e00a2c_2f6103cd","updated":"2024-02-26 17:43:15.000000000","message":"good point! \nnow the test takes only 271 seconds:\n\n2024-02-26 14:43:29.018758 | controller | {0} tempest.scenario.test_instances_with_cinder_volumes.TestInstancesWithCinderVolumes.test_instances_with_cinder_volumes_on_all_compute_nodes [271.425426s] ... ok","commit_id":"c47d9762b06b8f19f5a2610d55764f05af9940e6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"58f03600908caf81bb730f72748ca70321fc5b67","unresolved":true,"context_lines":[{"line_number":103,"context_line":"                  hosts_to_boot_servers)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # create instances in available zones"},{"line_number":106,"context_line":"        for host in hosts_to_boot_servers:"},{"line_number":107,"context_line":"            attached_volumes \u003d []"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            # create boot volume from image and of the given volume type"},{"line_number":110,"context_line":"            boot_volume \u003d self.create_volume("},{"line_number":111,"context_line":"                imageRef\u003dimage, volume_type\u003dboot_volume_type"},{"line_number":112,"context_line":"            )"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            # create an instance from bootable volume"},{"line_number":115,"context_line":"            server \u003d self.boot_instance_from_resource("},{"line_number":116,"context_line":"                source_id\u003dboot_volume[\u0027id\u0027],"},{"line_number":117,"context_line":"                source_type\u003d\u0027volume\u0027,"},{"line_number":118,"context_line":"                keypair\u003dkeypair"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa2e7e49_5ca27677","line":115,"range":{"start_line":106,"start_character":0,"end_line":115,"end_character":54},"in_reply_to":"cc73de27_9240e8a7","updated":"2024-03-15 18:00:18.000000000","message":"This is still taking 416 sec\n\n- https://zuul.opendev.org/t/openstack/build/5ec22ec784f74dd2bcc3254e88ea19a4/log/job-output.txt#34468","commit_id":"c47d9762b06b8f19f5a2610d55764f05af9940e6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9f2e353af9bfb85635d2c30403bf31c5d58dbc52","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            # Create and attach volumes of different types to the instance"},{"line_number":122,"context_line":"            for vol_type in volume_types:"},{"line_number":123,"context_line":"                data_volume \u003d self.create_volume(volume_type\u003dvol_type)"},{"line_number":124,"context_line":"                attached_volume \u003d self.nova_volume_attach(server, data_volume)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"                attached_volumes.append(attached_volume)"}],"source_content_type":"text/x-python","patch_set":23,"id":"f23f70aa_ebbdc3ab","line":123,"range":{"start_line":123,"start_character":16,"end_line":123,"end_character":70},"updated":"2024-02-22 06:50:38.000000000","message":"let\u0027s create these volume before L106 and with wait_until\u003dNone so that we do not need to create volume and wait for \u0027available\u0027 state in this for loop one by one. if we create these volume before we boot instance they will automatically will have enough time to become available.","commit_id":"c47d9762b06b8f19f5a2610d55764f05af9940e6"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ae17bd211160272cd1f67496bd4af5eea9fdb004","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            # Create and attach volumes of different types to the instance"},{"line_number":122,"context_line":"            for vol_type in volume_types:"},{"line_number":123,"context_line":"                data_volume \u003d self.create_volume(volume_type\u003dvol_type)"},{"line_number":124,"context_line":"                attached_volume \u003d self.nova_volume_attach(server, data_volume)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"                attached_volumes.append(attached_volume)"}],"source_content_type":"text/x-python","patch_set":23,"id":"b89bc91c_ced637f8","line":123,"range":{"start_line":123,"start_character":16,"end_line":123,"end_character":70},"in_reply_to":"f23f70aa_ebbdc3ab","updated":"2024-02-26 17:43:15.000000000","message":"Done","commit_id":"c47d9762b06b8f19f5a2610d55764f05af9940e6"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ae17bd211160272cd1f67496bd4af5eea9fdb004","unresolved":true,"context_lines":[{"line_number":124,"context_line":"                attached_volume \u003d self.nova_volume_attach(server, data_volume)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"                attached_volumes.append(attached_volume)"},{"line_number":127,"context_line":"                LOG.debug(\"Attached volume %s to server %s\","},{"line_number":128,"context_line":"                          attached_volume[\u0027id\u0027], server[\u0027id\u0027])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            # assign floating ip"}],"source_content_type":"text/x-python","patch_set":23,"id":"3e99b0c4_a80af4ac","line":127,"range":{"start_line":127,"start_character":16,"end_line":127,"end_character":60},"updated":"2024-02-26 17:43:15.000000000","message":"we can still use this log","commit_id":"c47d9762b06b8f19f5a2610d55764f05af9940e6"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2a36953d4b31afda9ea90ab002b9e16daa0382d4","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                attached_volume \u003d self.nova_volume_attach(server, data_volume)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"                attached_volumes.append(attached_volume)"},{"line_number":127,"context_line":"                LOG.debug(\"Attached volume %s to server %s\","},{"line_number":128,"context_line":"                          attached_volume[\u0027id\u0027], server[\u0027id\u0027])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            # assign floating ip"}],"source_content_type":"text/x-python","patch_set":23,"id":"a550d38e_fae8527a","line":127,"range":{"start_line":127,"start_character":16,"end_line":127,"end_character":60},"in_reply_to":"3e99b0c4_a80af4ac","updated":"2024-03-15 17:30:03.000000000","message":"Done","commit_id":"c47d9762b06b8f19f5a2610d55764f05af9940e6"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ae17bd211160272cd1f67496bd4af5eea9fdb004","unresolved":true,"context_lines":[{"line_number":145,"context_line":"        for server in servers:"},{"line_number":146,"context_line":"            attached_volumes \u003d []"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            #wait for server to become active"},{"line_number":149,"context_line":"            waiters.wait_for_server_status(self.servers_client,"},{"line_number":150,"context_line":"                                          server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"1b2a2cc2_5015abec","line":148,"range":{"start_line":148,"start_character":13,"end_line":148,"end_character":17},"updated":"2024-02-26 17:43:15.000000000","message":"space after # needed to pass pep8","commit_id":"0ec6c2f44ec1803c540885acdea4e28338dbcfa2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2a36953d4b31afda9ea90ab002b9e16daa0382d4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        for server in servers:"},{"line_number":146,"context_line":"            attached_volumes \u003d []"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            #wait for server to become active"},{"line_number":149,"context_line":"            waiters.wait_for_server_status(self.servers_client,"},{"line_number":150,"context_line":"                                          server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"a29417bc_13187eec","line":148,"range":{"start_line":148,"start_character":13,"end_line":148,"end_character":17},"in_reply_to":"1b2a2cc2_5015abec","updated":"2024-03-15 17:30:03.000000000","message":"Done","commit_id":"0ec6c2f44ec1803c540885acdea4e28338dbcfa2"}]}