)]}'
{"tempest/api/volume/admin/test_volume_quotas.py":[{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"929b622080cfef190dbc48be648139d5a2502243","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":104,"context_line":"    def test_delete_quota(self):"},{"line_number":105,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":106,"context_line":"        resp, quota_set_default \u003d self.quotas_client.get_quota_set("},{"line_number":107,"context_line":"            self.demo_tenant_id)"},{"line_number":108,"context_line":"        volume_default \u003d quota_set_default[\u0027volumes\u0027]"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bad4c104_3a183184","line":106,"updated":"2014-04-29 08:19:49.000000000","message":"unused variable \"resp\"","commit_id":"8fd17d760047fa0e7fa004d5059bf00c81fea51e"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"e46e733ef42b838cf3c11bedbb2c0a38966ebfd3","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":104,"context_line":"    def test_delete_quota(self):"},{"line_number":105,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":106,"context_line":"        resp, quota_set_default \u003d self.quotas_client.get_quota_set("},{"line_number":107,"context_line":"            self.demo_tenant_id)"},{"line_number":108,"context_line":"        volume_default \u003d quota_set_default[\u0027volumes\u0027]"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_eb8cd337","line":106,"in_reply_to":"bad4c104_3a183184","updated":"2014-05-05 06:54:37.000000000","message":"Done","commit_id":"8fd17d760047fa0e7fa004d5059bf00c81fea51e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"db52219a11debf8cfcbe204b94bdbe3f827c4c38","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        volume_default \u003d quota_set_default[\u0027volumes\u0027]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        resp, _ \u003d self.quotas_client.update_quota_set("},{"line_number":111,"context_line":"            self.demo_tenant_id, volumes\u003d\u002715\u0027)"},{"line_number":112,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        resp, _ \u003d self.quotas_client.delete_quota_set(self.demo_tenant_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2Fuvg%3D","line":111,"updated":"2014-04-28 12:06:33.000000000","message":"Instead of using hard code value \u002715\u0027, it will be better if you can add something in \u0027volume_default\u0027 to make sure different volume quota is being updated and deleted.","commit_id":"8fd17d760047fa0e7fa004d5059bf00c81fea51e"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"e46e733ef42b838cf3c11bedbb2c0a38966ebfd3","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        volume_default \u003d quota_set_default[\u0027volumes\u0027]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        resp, _ \u003d self.quotas_client.update_quota_set("},{"line_number":111,"context_line":"            self.demo_tenant_id, volumes\u003d\u002715\u0027)"},{"line_number":112,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        resp, _ \u003d self.quotas_client.delete_quota_set(self.demo_tenant_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_8b77c739","line":111,"in_reply_to":"AAAAXX%2F%2Fuvg%3D","updated":"2014-05-05 06:54:37.000000000","message":"Done","commit_id":"8fd17d760047fa0e7fa004d5059bf00c81fea51e"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"702ee6db7443614445c9f42f64cb8673d3c260e1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":104,"context_line":"    def test_delete_quota(self):"},{"line_number":105,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":106,"context_line":"        _, quota_set_default \u003d self.quotas_client.get_quota_set("},{"line_number":107,"context_line":"            self.demo_tenant_id)"},{"line_number":108,"context_line":"        volume_default \u003d quota_set_default[\u0027volumes\u0027]"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_817a1875","line":106,"updated":"2014-05-17 18:51:39.000000000","message":"get_default_quota_set should be used here.","commit_id":"909db26381cae0833b50fc69e934790a0f162fed"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"0e01719f9e9259e046362d93e7d8db9efc6837c0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":104,"context_line":"    def test_delete_quota(self):"},{"line_number":105,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":106,"context_line":"        _, quota_set_default \u003d self.quotas_client.get_quota_set("},{"line_number":107,"context_line":"            self.demo_tenant_id)"},{"line_number":108,"context_line":"        volume_default \u003d quota_set_default[\u0027volumes\u0027]"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_0f5b5cf6","line":106,"in_reply_to":"7adec928_817a1875","updated":"2014-05-19 12:39:07.000000000","message":"Done","commit_id":"909db26381cae0833b50fc69e934790a0f162fed"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1e3ea8831b95b0e0c64079ac40c648f714bf3f71","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                         new_quota_usage[\u0027gigabytes\u0027][\u0027in_use\u0027])"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":103,"context_line":"    def test_delete_quota(self):"},{"line_number":104,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":105,"context_line":"        _, quota_set_default \u003d self.quotas_client.get_default_quota_set("},{"line_number":106,"context_line":"            self.demo_tenant_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_609ead64","line":103,"updated":"2014-05-19 14:52:24.000000000","message":"I am not sure. He really tests only the delete part. There\u0027s no call to test that the update went well (excepted that the API returned 200)","commit_id":"46c5231293f205060d36c90343ba7cbb31dc279b"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"4ebcf5ad1ad48b26af02608ad7cd08b0e23aed36","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                         new_quota_usage[\u0027gigabytes\u0027][\u0027in_use\u0027])"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":103,"context_line":"    def test_delete_quota(self):"},{"line_number":104,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":105,"context_line":"        _, quota_set_default \u003d self.quotas_client.get_default_quota_set("},{"line_number":106,"context_line":"            self.demo_tenant_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_257f5716","line":103,"updated":"2014-05-19 14:20:36.000000000","message":"May be, \"test_get_update_delete_quota\" is better name for this test. What do you think about that?","commit_id":"46c5231293f205060d36c90343ba7cbb31dc279b"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"e79598009c70951745a6de8f1bc65c16d2b9e163","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                         new_quota_usage[\u0027gigabytes\u0027][\u0027in_use\u0027])"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":103,"context_line":"    def test_delete_quota(self):"},{"line_number":104,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":105,"context_line":"        _, quota_set_default \u003d self.quotas_client.get_default_quota_set("},{"line_number":106,"context_line":"            self.demo_tenant_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_4adf0fd6","line":103,"in_reply_to":"7adec928_609ead64","updated":"2014-05-19 15:24:21.000000000","message":"OK. I don\u0027t mind :)","commit_id":"46c5231293f205060d36c90343ba7cbb31dc279b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1e3ea8831b95b0e0c64079ac40c648f714bf3f71","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def test_delete_quota(self):"},{"line_number":104,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":105,"context_line":"        _, quota_set_default \u003d self.quotas_client.get_default_quota_set("},{"line_number":106,"context_line":"            self.demo_tenant_id)"},{"line_number":107,"context_line":"        volume_default \u003d quota_set_default[\u0027volumes\u0027]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        resp, _ \u003d self.quotas_client.update_quota_set("}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_8099f97a","line":106,"updated":"2014-05-19 14:52:24.000000000","message":"Agreed","commit_id":"46c5231293f205060d36c90343ba7cbb31dc279b"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"4ebcf5ad1ad48b26af02608ad7cd08b0e23aed36","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def test_delete_quota(self):"},{"line_number":104,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":105,"context_line":"        _, quota_set_default \u003d self.quotas_client.get_default_quota_set("},{"line_number":106,"context_line":"            self.demo_tenant_id)"},{"line_number":107,"context_line":"        volume_default \u003d quota_set_default[\u0027volumes\u0027]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        resp, _ \u003d self.quotas_client.update_quota_set("}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_e5e64fe7","line":106,"updated":"2014-05-19 14:20:36.000000000","message":"What about check for response status code here?","commit_id":"46c5231293f205060d36c90343ba7cbb31dc279b"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"9e2a7ef710487430aaf06b9f2ce22fb88e068037","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def test_delete_quota(self):"},{"line_number":104,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":105,"context_line":"        _, quota_set_default \u003d self.quotas_client.get_default_quota_set("},{"line_number":106,"context_line":"            self.demo_tenant_id)"},{"line_number":107,"context_line":"        volume_default \u003d quota_set_default[\u0027volumes\u0027]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        resp, _ \u003d self.quotas_client.update_quota_set("}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_be9ef952","line":106,"in_reply_to":"7adec928_8099f97a","updated":"2014-05-20 17:12:19.000000000","message":"Hi Lobankov/Pittier,\n\nAs already mentioned in other submissions, we only check the response code of the API call that is directly related to the aim of the test case. Thus response status check is not required for get_default_quota_set in this test case.\n\nIMHO, ideally, even the response status checks for \u0027update_quota_set\u0027 and \u0027get_quota_set\u0027 must be removed from this test case. Thus removing the status checks and submitted next patch.\n\nPlease check the following for response code checks:\n1. \u0027get_default_quota_set\u0027 is checked in \u0027test_list_default_quotas\u0027 test case.\n\n2. \u0027update_quota_set\u0027 is checked in \u0027test_update_all_quota_resources_for_tenant\u0027 test case.\n\n3. \u0027get_quota_set\u0027 is checked in \u0027test_list_quotas\u0027 test case.\n\nRegards,\nRajalakshmi Ganesan","commit_id":"46c5231293f205060d36c90343ba7cbb31dc279b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1e3ea8831b95b0e0c64079ac40c648f714bf3f71","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.demo_tenant_id)"},{"line_number":107,"context_line":"        volume_default \u003d quota_set_default[\u0027volumes\u0027]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        resp, _ \u003d self.quotas_client.update_quota_set("},{"line_number":110,"context_line":"            self.demo_tenant_id, volumes\u003d(int(volume_default) + 5))"},{"line_number":111,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_60aced8c","line":109,"updated":"2014-05-19 14:52:24.000000000","message":"Could you also, in the same call, update the quotas for gigabytes and snapshots ? You may want to iterate over QUOTA_KEYS\n\nI am not very familiar with cinder source code, maybe it\u0027s purely redundant.","commit_id":"46c5231293f205060d36c90343ba7cbb31dc279b"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"9e2a7ef710487430aaf06b9f2ce22fb88e068037","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.demo_tenant_id)"},{"line_number":107,"context_line":"        volume_default \u003d quota_set_default[\u0027volumes\u0027]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        resp, _ \u003d self.quotas_client.update_quota_set("},{"line_number":110,"context_line":"            self.demo_tenant_id, volumes\u003d(int(volume_default) + 5))"},{"line_number":111,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_a470a674","line":109,"in_reply_to":"7adec928_60aced8c","updated":"2014-05-20 17:12:19.000000000","message":"Hi Pittier,\n\nAs the aim of test case is to check delete_quota, IMHO it is not really necessary to update and delete all quota values.\n\nUpdating and deletion of one value would suffice the purpose.\n\nRegards,\nRajalakshmi Ganesan","commit_id":"46c5231293f205060d36c90343ba7cbb31dc279b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1e3ea8831b95b0e0c64079ac40c648f714bf3f71","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        resp, quota_set_new \u003d self.quotas_client.get_quota_set("},{"line_number":117,"context_line":"            self.demo_tenant_id)"},{"line_number":118,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":119,"context_line":"        self.assertEqual(volume_default, quota_set_new[\u0027volumes\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class VolumeQuotasAdminTestXML(VolumeQuotasAdminTestJSON):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_60da2d18","line":119,"updated":"2014-05-19 14:52:24.000000000","message":"If you implement my previous comment, also check here that quotas for gigabytes and snapshots were also deleted.","commit_id":"46c5231293f205060d36c90343ba7cbb31dc279b"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"9e2a7ef710487430aaf06b9f2ce22fb88e068037","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        resp, quota_set_new \u003d self.quotas_client.get_quota_set("},{"line_number":117,"context_line":"            self.demo_tenant_id)"},{"line_number":118,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":119,"context_line":"        self.assertEqual(volume_default, quota_set_new[\u0027volumes\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class VolumeQuotasAdminTestXML(VolumeQuotasAdminTestJSON):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_c46db29b","line":119,"in_reply_to":"7adec928_60da2d18","updated":"2014-05-20 17:12:19.000000000","message":"ditto","commit_id":"46c5231293f205060d36c90343ba7cbb31dc279b"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"0727d8dd5aedafda176219f11ff96e17570651a7","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.demo_tenant_id)"},{"line_number":107,"context_line":"        volume_default \u003d quota_set_default[\u0027volumes\u0027]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        resp, _ \u003d self.quotas_client.update_quota_set("},{"line_number":110,"context_line":"            self.demo_tenant_id, volumes\u003d(int(volume_default) + 5))"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        resp, _ \u003d self.quotas_client.delete_quota_set(self.demo_tenant_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_b5c9a4ae","line":109,"updated":"2014-05-21 06:21:03.000000000","message":"unused variable \"resp\"","commit_id":"945456bea11bb6a3cfda147e60f18d43dd228977"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"dac300d22f7c549628dd4ab6476f115b172e0a17","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.demo_tenant_id)"},{"line_number":107,"context_line":"        volume_default \u003d quota_set_default[\u0027volumes\u0027]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        resp, _ \u003d self.quotas_client.update_quota_set("},{"line_number":110,"context_line":"            self.demo_tenant_id, volumes\u003d(int(volume_default) + 5))"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        resp, _ \u003d self.quotas_client.delete_quota_set(self.demo_tenant_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_7039c3d7","line":109,"in_reply_to":"7adec928_b5c9a4ae","updated":"2014-05-22 09:46:59.000000000","message":"Done","commit_id":"945456bea11bb6a3cfda147e60f18d43dd228977"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"0727d8dd5aedafda176219f11ff96e17570651a7","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        resp, _ \u003d self.quotas_client.delete_quota_set(self.demo_tenant_id)"},{"line_number":113,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        resp, quota_set_new \u003d self.quotas_client.get_quota_set("},{"line_number":116,"context_line":"            self.demo_tenant_id)"},{"line_number":117,"context_line":"        self.assertEqual(volume_default, quota_set_new[\u0027volumes\u0027])"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_d5ce30b4","line":115,"updated":"2014-05-21 06:21:03.000000000","message":"unused variable \"resp\"","commit_id":"945456bea11bb6a3cfda147e60f18d43dd228977"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"dac300d22f7c549628dd4ab6476f115b172e0a17","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        resp, _ \u003d self.quotas_client.delete_quota_set(self.demo_tenant_id)"},{"line_number":113,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        resp, quota_set_new \u003d self.quotas_client.get_quota_set("},{"line_number":116,"context_line":"            self.demo_tenant_id)"},{"line_number":117,"context_line":"        self.assertEqual(volume_default, quota_set_new[\u0027volumes\u0027])"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_90364fe6","line":115,"in_reply_to":"7adec928_d5ce30b4","updated":"2014-05-22 09:46:59.000000000","message":"Done","commit_id":"945456bea11bb6a3cfda147e60f18d43dd228977"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e0522210cd710140d510b85650972d150269b6d5","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                         new_quota_usage[\u0027gigabytes\u0027][\u0027in_use\u0027])"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":103,"context_line":"    def test_delete_quota(self):"},{"line_number":104,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":105,"context_line":"        _, quota_set_default \u003d self.quotas_client.get_default_quota_set("},{"line_number":106,"context_line":"            self.demo_tenant_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_1c26d868","line":103,"updated":"2014-05-22 12:09:14.000000000","message":"If the quota of demo_tenant has been changed already before this test, this \ntest would fail because the quota after deleting would be default values.\n\nTo avoid this failure, the compute API test creates temporary tenant for this kind of test. I think this test also needs temporary tenant. Could you see test_delete_quota of tempest/api$ vi compute/admin/test_quotas.py ?","commit_id":"c7e214e5670df109428c634fb99f246c16d60738"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"187fda87411b1f21562d4d93c30d40aee19a1937","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                         new_quota_usage[\u0027gigabytes\u0027][\u0027in_use\u0027])"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":103,"context_line":"    def test_delete_quota(self):"},{"line_number":104,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":105,"context_line":"        _, quota_set_default \u003d self.quotas_client.get_default_quota_set("},{"line_number":106,"context_line":"            self.demo_tenant_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_667c7721","line":103,"in_reply_to":"7adec928_1c26d868","updated":"2014-05-23 18:32:26.000000000","message":"Done","commit_id":"c7e214e5670df109428c634fb99f246c16d60738"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"b179a2bc0957a73bf584e534195dc1bee20c4696","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def test_delete_quota(self):"},{"line_number":105,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":106,"context_line":"        tenant_name \u003d data_utils.rand_name(\u0027quota_tenant_\u0027)"},{"line_number":107,"context_line":"        tenant_desc \u003d tenant_name + \u0027-desc\u0027"},{"line_number":108,"context_line":"        identity_client \u003d self.os_adm.identity_client"},{"line_number":109,"context_line":"        _, tenant \u003d identity_client.create_tenant(name\u003dtenant_name,"},{"line_number":110,"context_line":"                                                  description\u003dtenant_desc)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7adec928_a96d7d9b","line":107,"updated":"2014-05-23 12:32:02.000000000","message":"Why do you create tenant_desc? There is no need to create this variable. You can create a tenant without description.\n\n    tenant \u003d identity_client.create_tenant(tenant_name)[1]","commit_id":"076feed3e9704c52341fb99d304f31a7c987b218"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"3c6f32e39bf96b973d6abbb7ee962d70d97020a9","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def test_delete_quota(self):"},{"line_number":105,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":106,"context_line":"        tenant_name \u003d data_utils.rand_name(\u0027quota_tenant_\u0027)"},{"line_number":107,"context_line":"        tenant_desc \u003d tenant_name + \u0027-desc\u0027"},{"line_number":108,"context_line":"        identity_client \u003d self.os_adm.identity_client"},{"line_number":109,"context_line":"        _, tenant \u003d identity_client.create_tenant(name\u003dtenant_name,"},{"line_number":110,"context_line":"                                                  description\u003dtenant_desc)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7adec928_269a6f63","line":107,"in_reply_to":"7adec928_24f42ff1","updated":"2014-05-23 18:33:53.000000000","message":"Done","commit_id":"076feed3e9704c52341fb99d304f31a7c987b218"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a0aed0b3aa579858bf3fd3fde4afc495bf1141cd","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def test_delete_quota(self):"},{"line_number":105,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":106,"context_line":"        tenant_name \u003d data_utils.rand_name(\u0027quota_tenant_\u0027)"},{"line_number":107,"context_line":"        tenant_desc \u003d tenant_name + \u0027-desc\u0027"},{"line_number":108,"context_line":"        identity_client \u003d self.os_adm.identity_client"},{"line_number":109,"context_line":"        _, tenant \u003d identity_client.create_tenant(name\u003dtenant_name,"},{"line_number":110,"context_line":"                                                  description\u003dtenant_desc)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7adec928_46105ba8","line":107,"in_reply_to":"7adec928_24f42ff1","updated":"2014-05-23 18:45:23.000000000","message":"Jordan Pittier, yes, I meant this :)","commit_id":"076feed3e9704c52341fb99d304f31a7c987b218"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"089bf843298de4edf85d4f92dfffa212108cd6b9","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def test_delete_quota(self):"},{"line_number":105,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":106,"context_line":"        tenant_name \u003d data_utils.rand_name(\u0027quota_tenant_\u0027)"},{"line_number":107,"context_line":"        tenant_desc \u003d tenant_name + \u0027-desc\u0027"},{"line_number":108,"context_line":"        identity_client \u003d self.os_adm.identity_client"},{"line_number":109,"context_line":"        _, tenant \u003d identity_client.create_tenant(name\u003dtenant_name,"},{"line_number":110,"context_line":"                                                  description\u003dtenant_desc)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7adec928_24f42ff1","line":107,"in_reply_to":"7adec928_61262918","updated":"2014-05-23 14:46:04.000000000","message":"What Yaroslav meant is, there\u0027s no need to specify a description if you don\u0027t check/assert that the same description is returned afterward.\n\nBut -1 may be a bit hard just for this :)","commit_id":"076feed3e9704c52341fb99d304f31a7c987b218"},{"author":{"_account_id":1795,"name":"Ravikumar Venkatesan","email":"ravikumar.venkatesan@hpe.com","username":"ravikumar-venkatesan"},"change_message_id":"a5e280e35cbf68f50a8a5779fd11330e83e1bd6b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def test_delete_quota(self):"},{"line_number":105,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":106,"context_line":"        tenant_name \u003d data_utils.rand_name(\u0027quota_tenant_\u0027)"},{"line_number":107,"context_line":"        tenant_desc \u003d tenant_name + \u0027-desc\u0027"},{"line_number":108,"context_line":"        identity_client \u003d self.os_adm.identity_client"},{"line_number":109,"context_line":"        _, tenant \u003d identity_client.create_tenant(name\u003dtenant_name,"},{"line_number":110,"context_line":"                                                  description\u003dtenant_desc)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7adec928_61262918","line":107,"in_reply_to":"7adec928_a96d7d9b","updated":"2014-05-23 14:30:26.000000000","message":"It could be subjective . Here would like to create tenant passing description . Do you still want us to remove description variable.Another reviewer could comment \"why this variable is not used\" in resource creation if not in this review in another submission. i would like to continue this submission with this variable","commit_id":"076feed3e9704c52341fb99d304f31a7c987b218"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"8e6b89f812535dde2da6c1f8751bbe402df506ed","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        # Admin can delete the resource quota set for a tenant"},{"line_number":106,"context_line":"        tenant_name \u003d data_utils.rand_name(\u0027quota_tenant_\u0027)"},{"line_number":107,"context_line":"        identity_client \u003d self.os_adm.identity_client"},{"line_number":108,"context_line":"        tenant \u003d identity_client.create_tenant(tenant_name)[1]"},{"line_number":109,"context_line":"        tenant_id \u003d tenant[\u0027id\u0027]"},{"line_number":110,"context_line":"        self.addCleanup(identity_client.delete_tenant, tenant_id)"},{"line_number":111,"context_line":"        _, quota_set_default \u003d self.quotas_client.get_default_quota_set("}],"source_content_type":"text/x-python","patch_set":9,"id":"3ae8d1ca_bf192c7b","line":108,"updated":"2014-05-29 13:14:35.000000000","message":"Force tenant isolation is enabled here, so you could just use the alt_tenant instead of making another. But, that being said this is probably more explicit.","commit_id":"3d59e4a060f0735eb2db9957739092635e143a71"}],"tempest/services/volume/json/admin/volume_quotas_client.py":[{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"929b622080cfef190dbc48be648139d5a2502243","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def delete_quota_set(self, tenant_id):"},{"line_number":82,"context_line":"        \"\"\"Delete the tenant\u0027s quota set.\"\"\""},{"line_number":83,"context_line":"        resp, body \u003d self.delete(\u0027os-quota-sets/%s\u0027 % str(tenant_id))"},{"line_number":84,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":2,"id":"bad4c104_fa05e914","line":83,"updated":"2014-04-29 08:19:49.000000000","message":"may be would be better:\n\nreturn self.delete(\u0027os-quota-sets/%s\u0027 % str(tenant_id))\n\n?","commit_id":"8fd17d760047fa0e7fa004d5059bf00c81fea51e"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"e46e733ef42b838cf3c11bedbb2c0a38966ebfd3","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def delete_quota_set(self, tenant_id):"},{"line_number":82,"context_line":"        \"\"\"Delete the tenant\u0027s quota set.\"\"\""},{"line_number":83,"context_line":"        resp, body \u003d self.delete(\u0027os-quota-sets/%s\u0027 % str(tenant_id))"},{"line_number":84,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_cbb70fd7","line":83,"in_reply_to":"bad4c104_fa05e914","updated":"2014-05-05 06:54:37.000000000","message":"Done","commit_id":"8fd17d760047fa0e7fa004d5059bf00c81fea51e"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"9b8c7cc42a27b3a1677c8d7ad6ed758a0b5b6176","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def delete_quota_set(self, tenant_id):"},{"line_number":82,"context_line":"        \"\"\"Delete the tenant\u0027s quota set.\"\"\""},{"line_number":83,"context_line":"        return self.delete(\u0027os-quota-sets/%s\u0027 % str(tenant_id))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_f9102903","line":83,"updated":"2014-05-05 08:00:39.000000000","message":"is tenant_id not string?","commit_id":"5c147f22a203cec238d4989214fabd10f6a16196"}]}