)]}'
{"tempest/api/data_processing/test_cluster_templates.py":[{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"5e3f108f4ca2a281e7fee7dcd14d648b1d3d04e7","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":100,"context_line":"    def test_cluster_template_create(self):"},{"line_number":101,"context_line":"        template_name \u003d data_utils.rand_name(\u0027sahara-cluster-template\u0027)"},{"line_number":102,"context_line":"        resp, body \u003d self.create_cluster_template(template_name,"},{"line_number":103,"context_line":"                                                  **self.full_cluster_template)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_6e3108ec","line":101,"range":{"start_line":101,"start_character":24,"end_line":101,"end_character":34},"updated":"2014-04-30 17:55:53.000000000","message":"Why we do this here and in function _create_cluster_template too? Let\u0027s remove one of them.","commit_id":"e6cd3168505fd1fea8d476687dbac9d6877f11ca"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"10dd1e6af11b489a79df25d4f84a430a1f99ee46","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            ]"},{"line_number":71,"context_line":"        }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        cluster_template \u003d cls.full_cluster_template.copy()"},{"line_number":74,"context_line":"        del cluster_template[\u0027node_groups\u0027]"},{"line_number":75,"context_line":"        cls.cluster_template \u003d cluster_template"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_ff6f29c3","line":73,"updated":"2014-05-05 09:08:11.000000000","message":"please use cls.cluster_template there","commit_id":"10fa2dee1f403504afd6bbd7cbf7ccfb51f7232d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"dff682e5b77aafb4bdcf5b591db674c2bf0ca5d5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ClusterTemplateTest(dp_base.BaseDataProcessingTest):"},{"line_number":21,"context_line":"    @classmethod"},{"line_number":22,"context_line":"    def setUpClass(cls):"},{"line_number":23,"context_line":"        super(ClusterTemplateTest, cls).setUpClass()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_32b5b8d0","line":20,"updated":"2014-05-20 18:21:50.000000000","message":"Can you add a docstring to the class for the api spec: http://docs.openstack.org/developer/sahara/restapi/rest_api_v1.0.html#cluster-templates\n\nThis is something we discussed at summit and I think it will add value to the tests here to have a reference to the api being used.","commit_id":"f929aea6a88d75de80c9440559629a5642e53db1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"5e5414aaefdb488d3fd12d111c7a3cb056d4ecbe","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ClusterTemplateTest(dp_base.BaseDataProcessingTest):"},{"line_number":21,"context_line":"    @classmethod"},{"line_number":22,"context_line":"    def setUpClass(cls):"},{"line_number":23,"context_line":"        super(ClusterTemplateTest, cls).setUpClass()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_189b7d73","line":20,"in_reply_to":"7adec928_32b5b8d0","updated":"2014-05-20 19:28:02.000000000","message":"Yes, of course, I will do it.","commit_id":"f929aea6a88d75de80c9440559629a5642e53db1"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"dff682e5b77aafb4bdcf5b591db674c2bf0ca5d5","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ClusterTemplateTest(dp_base.BaseDataProcessingTest):"},{"line_number":21,"context_line":"    @classmethod"},{"line_number":22,"context_line":"    def setUpClass(cls):"},{"line_number":23,"context_line":"        super(ClusterTemplateTest, cls).setUpClass()"},{"line_number":24,"context_line":"        # create node group template"},{"line_number":25,"context_line":"        node_group_template \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_3249388f","line":22,"updated":"2014-05-20 18:21:50.000000000","message":"Is there a specific reason this is a setUpClass and not a setUp? Are these operations slow/resource intensive?","commit_id":"f929aea6a88d75de80c9440559629a5642e53db1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"5e5414aaefdb488d3fd12d111c7a3cb056d4ecbe","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ClusterTemplateTest(dp_base.BaseDataProcessingTest):"},{"line_number":21,"context_line":"    @classmethod"},{"line_number":22,"context_line":"    def setUpClass(cls):"},{"line_number":23,"context_line":"        super(ClusterTemplateTest, cls).setUpClass()"},{"line_number":24,"context_line":"        # create node group template"},{"line_number":25,"context_line":"        node_group_template \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_78b5617d","line":22,"in_reply_to":"7adec928_3249388f","updated":"2014-05-20 19:28:02.000000000","message":"Yes, the reason is that setUp method will be run for each test. There are 4 tests in this class. So node group template will be created once (line 38) but not 4.","commit_id":"f929aea6a88d75de80c9440559629a5642e53db1"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"dff682e5b77aafb4bdcf5b591db674c2bf0ca5d5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                }"},{"line_number":36,"context_line":"            }"},{"line_number":37,"context_line":"        }"},{"line_number":38,"context_line":"        node_group_template \u003d cls.create_node_group_template("},{"line_number":39,"context_line":"            **node_group_template)[1]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        cls.full_cluster_template \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_4d03850d","line":38,"updated":"2014-05-20 18:21:50.000000000","message":"Do you need to clean this up?","commit_id":"f929aea6a88d75de80c9440559629a5642e53db1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"5e5414aaefdb488d3fd12d111c7a3cb056d4ecbe","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                }"},{"line_number":36,"context_line":"            }"},{"line_number":37,"context_line":"        }"},{"line_number":38,"context_line":"        node_group_template \u003d cls.create_node_group_template("},{"line_number":39,"context_line":"            **node_group_template)[1]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        cls.full_cluster_template \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_38dcb918","line":38,"in_reply_to":"7adec928_4d03850d","updated":"2014-05-20 19:28:02.000000000","message":"All resources created by this method will be automatically removed. https://github.com/openstack/tempest/blob/master/tempest/api/data_processing/base.py#L84","commit_id":"f929aea6a88d75de80c9440559629a5642e53db1"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"dff682e5b77aafb4bdcf5b591db674c2bf0ca5d5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                }"},{"line_number":69,"context_line":"            ]"},{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"        cls.cluster_template \u003d cls.full_cluster_template.copy()"},{"line_number":72,"context_line":"        del cls.cluster_template[\u0027node_groups\u0027]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _create_cluster_template(self, template_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_122b5c95","line":71,"updated":"2014-05-20 18:21:50.000000000","message":"Maybe add a comment here about setting up a subset to use for comparison. By itself it\u0027s not exactly clear what you\u0027re doing here unless you look at the rest of the file.","commit_id":"f929aea6a88d75de80c9440559629a5642e53db1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"5e5414aaefdb488d3fd12d111c7a3cb056d4ecbe","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                }"},{"line_number":69,"context_line":"            ]"},{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"        cls.cluster_template \u003d cls.full_cluster_template.copy()"},{"line_number":72,"context_line":"        del cls.cluster_template[\u0027node_groups\u0027]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _create_cluster_template(self, template_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_b85c494e","line":71,"in_reply_to":"7adec928_122b5c95","updated":"2014-05-20 19:28:02.000000000","message":"Yes, of course, I will add it.","commit_id":"f929aea6a88d75de80c9440559629a5642e53db1"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"dff682e5b77aafb4bdcf5b591db674c2bf0ca5d5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            template_name \u003d data_utils.rand_name(\u0027sahara-cluster-template\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # create cluster template"},{"line_number":86,"context_line":"        resp, body \u003d self.create_cluster_template(template_name,"},{"line_number":87,"context_line":"                                                  **self.full_cluster_template)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # ensure that template created successfully"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_ed3291f1","line":86,"updated":"2014-05-20 18:21:50.000000000","message":"Same thing here about the cleanup. Won\u0027t this leave a bunch of cluster templates after the test","commit_id":"f929aea6a88d75de80c9440559629a5642e53db1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"5e5414aaefdb488d3fd12d111c7a3cb056d4ecbe","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            template_name \u003d data_utils.rand_name(\u0027sahara-cluster-template\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # create cluster template"},{"line_number":86,"context_line":"        resp, body \u003d self.create_cluster_template(template_name,"},{"line_number":87,"context_line":"                                                  **self.full_cluster_template)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # ensure that template created successfully"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_f87fb1a9","line":86,"in_reply_to":"7adec928_ed3291f1","updated":"2014-05-20 19:28:02.000000000","message":"See comment above.","commit_id":"f929aea6a88d75de80c9440559629a5642e53db1"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"dff153186f38053a4d16dfba006f62a352ac6643","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def setUpClass(cls):"},{"line_number":26,"context_line":"        super(ClusterTemplateTest, cls).setUpClass()"},{"line_number":27,"context_line":"        # create node group template"},{"line_number":28,"context_line":"        node_group_template \u003d {"},{"line_number":29,"context_line":"            \u0027name\u0027: data_utils.rand_name(\u0027sahara-ng-template\u0027),"},{"line_number":30,"context_line":"            \u0027description\u0027: \u0027Test node group template\u0027,"},{"line_number":31,"context_line":"            \u0027plugin_name\u0027: \u0027vanilla\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ae8d1ca_1617ccee","line":28,"updated":"2014-05-27 05:57:12.000000000","message":"It looks a little confusing. It\u0027s better to use a different name for the parameter. e.g. \u0027params\u0027","commit_id":"63b0c41aa085992fc8212b34ca613ec6e697d2dc"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"b87a8d324dd07be972553ebc257b0c24a5dd3a4e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def setUpClass(cls):"},{"line_number":26,"context_line":"        super(ClusterTemplateTest, cls).setUpClass()"},{"line_number":27,"context_line":"        # create node group template"},{"line_number":28,"context_line":"        node_group_template \u003d {"},{"line_number":29,"context_line":"            \u0027name\u0027: data_utils.rand_name(\u0027sahara-ng-template\u0027),"},{"line_number":30,"context_line":"            \u0027description\u0027: \u0027Test node group template\u0027,"},{"line_number":31,"context_line":"            \u0027plugin_name\u0027: \u0027vanilla\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_6f3bd9eb","line":28,"in_reply_to":"3ae8d1ca_1617ccee","updated":"2014-05-29 23:11:47.000000000","message":"I wouldn\u0027t like to submit a new patch set, but I will fix it in an other patch once this patch is merged.","commit_id":"63b0c41aa085992fc8212b34ca613ec6e697d2dc"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"1176a2e839e13c71d520363cdb7e84a074b96b9c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                }"},{"line_number":39,"context_line":"            }"},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"        node_group_template \u003d cls.create_node_group_template("},{"line_number":42,"context_line":"            **node_group_template)[1]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        cls.full_cluster_template \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_62791efc","line":41,"updated":"2014-05-30 12:41:17.000000000","message":"yes, It is confusing.","commit_id":"63b0c41aa085992fc8212b34ca613ec6e697d2dc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bb8c2f0fee7c2e31af8e7eec40c6aed19084cc91","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # delete the cluster template by id"},{"line_number":145,"context_line":"        resp \u003d self.client.delete_cluster_template(template_id)[0]"},{"line_number":146,"context_line":"        self.assertEqual(204, resp.status)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ae8d1ca_63f3f173","line":146,"updated":"2014-05-27 07:54:28.000000000","message":"Please verify the deleted template by get call with not found error.\nThere might be case where delete API does not perform the operation and return success silently.","commit_id":"63b0c41aa085992fc8212b34ca613ec6e697d2dc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bea6f72b433626f6815f508aaffd128b6612f600","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # delete the cluster template by id"},{"line_number":145,"context_line":"        resp \u003d self.client.delete_cluster_template(template_id)[0]"},{"line_number":146,"context_line":"        self.assertEqual(204, resp.status)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ae8d1ca_57886b22","line":146,"in_reply_to":"3ae8d1ca_575eabea","updated":"2014-05-27 10:00:27.000000000","message":"Sure.\nI am searching this in complete tempest and will fix where ever needed which will cover the data_processing tests also. If it will be missed from your test, please add.","commit_id":"63b0c41aa085992fc8212b34ca613ec6e697d2dc"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"e1b143df6c6c39de825940cde2d21920329a3cf0","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # delete the cluster template by id"},{"line_number":145,"context_line":"        resp \u003d self.client.delete_cluster_template(template_id)[0]"},{"line_number":146,"context_line":"        self.assertEqual(204, resp.status)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ae8d1ca_f7ac1738","line":146,"in_reply_to":"3ae8d1ca_57886b22","updated":"2014-05-27 10:10:55.000000000","message":"Yes, sure.","commit_id":"63b0c41aa085992fc8212b34ca613ec6e697d2dc"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"e25d99d0aba2667c4847a53fdc1db0884fd276ca","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # delete the cluster template by id"},{"line_number":145,"context_line":"        resp \u003d self.client.delete_cluster_template(template_id)[0]"},{"line_number":146,"context_line":"        self.assertEqual(204, resp.status)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ae8d1ca_f9da5016","line":146,"in_reply_to":"3ae8d1ca_63f3f173","updated":"2014-05-27 08:57:19.000000000","message":"Ghanshyam, you meant to add \n  \n    self.assertRaises(...)\n\nhere?","commit_id":"63b0c41aa085992fc8212b34ca613ec6e697d2dc"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"13da4a9b9e5477dfa8be35236dea69ec98a4d26f","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # delete the cluster template by id"},{"line_number":145,"context_line":"        resp \u003d self.client.delete_cluster_template(template_id)[0]"},{"line_number":146,"context_line":"        self.assertEqual(204, resp.status)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ae8d1ca_bc127656","line":146,"in_reply_to":"3ae8d1ca_995f8c72","updated":"2014-05-27 09:08:54.000000000","message":"I would add this check, but I\u0027m concerned that this will be introducing a race if the delete doesn\u0027t happen fast enough in my case.","commit_id":"63b0c41aa085992fc8212b34ca613ec6e697d2dc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fddaf5088db6b738fc5b0a3c5a36910f3902e284","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # delete the cluster template by id"},{"line_number":145,"context_line":"        resp \u003d self.client.delete_cluster_template(template_id)[0]"},{"line_number":146,"context_line":"        self.assertEqual(204, resp.status)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ae8d1ca_fce4fead","line":146,"in_reply_to":"3ae8d1ca_bc127656","updated":"2014-05-27 09:33:01.000000000","message":"Yes, we need to have wait for that. \nActually I saw many place in tempest, delete is not verified. I am thinking of fixing those in separate patch. I can update this also if you want:).\n\nBasically we need to use-\nself.client.wait_for_resource_deletion(..) (defined in rest_client.py) and override the is_resource_deleted() in client accordingly.","commit_id":"63b0c41aa085992fc8212b34ca613ec6e697d2dc"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"1176a2e839e13c71d520363cdb7e84a074b96b9c","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # delete the cluster template by id"},{"line_number":145,"context_line":"        resp \u003d self.client.delete_cluster_template(template_id)[0]"},{"line_number":146,"context_line":"        self.assertEqual(204, resp.status)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_427422fd","line":146,"in_reply_to":"3ae8d1ca_f7ac1738","updated":"2014-05-30 12:41:17.000000000","message":"You can just leave TODO note here now.","commit_id":"63b0c41aa085992fc8212b34ca613ec6e697d2dc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9f533f8cad132456dfa9dcab278011f5e599ec63","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # delete the cluster template by id"},{"line_number":145,"context_line":"        resp \u003d self.client.delete_cluster_template(template_id)[0]"},{"line_number":146,"context_line":"        self.assertEqual(204, resp.status)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ae8d1ca_995f8c72","line":146,"in_reply_to":"3ae8d1ca_f9da5016","updated":"2014-05-27 09:02:09.000000000","message":"Yes.","commit_id":"63b0c41aa085992fc8212b34ca613ec6e697d2dc"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"8ced82fb3900ebee593102eb2dcb455b71d32731","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # delete the cluster template by id"},{"line_number":145,"context_line":"        resp \u003d self.client.delete_cluster_template(template_id)[0]"},{"line_number":146,"context_line":"        self.assertEqual(204, resp.status)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ae8d1ca_575eabea","line":146,"in_reply_to":"3ae8d1ca_fce4fead","updated":"2014-05-27 09:51:54.000000000","message":"Ghanshyam, I wouldn\u0027t like to add this check right now if you don\u0027t mind :) I think these changes should be done in a different patch. I will add this check to all my tests.","commit_id":"63b0c41aa085992fc8212b34ca613ec6e697d2dc"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"0d50e2440262d6e43014b2440a1e436ef5822c0e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # create cls.cluster_template variable to use for comparison to cluster"},{"line_number":74,"context_line":"        # template response body. The \u0027node_groups\u0027 field in the response body"},{"line_number":75,"context_line":"        # has some extra info that post body does not have. The \u0027node_groups\u0027"},{"line_number":76,"context_line":"        # field in the response body is something like this"},{"line_number":77,"context_line":"        #"},{"line_number":78,"context_line":"        #   \u0027node_groups\u0027: ["},{"line_number":79,"context_line":"        #       {"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_6340c8a5","line":76,"updated":"2014-06-11 13:52:53.000000000","message":"You didn\u0027t actually need this much detail, all I meant in the previous review was to say somthing like node_group isn\u0027t in the response so removing it from a copy for comparison.","commit_id":"436605b5bd69d8eb0db060c8888dd24268abb62d"}]}