)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4af1e9735a8b04303f09b25dfbad72d43ad15a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9c3a904c_d927bd0b","updated":"2024-02-28 09:43:29.000000000","message":"recheck dependency updated","commit_id":"2c5ce9896e43632fc887af1ccd97382789eaa578"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ad6d712fb0ce2fa51f6c0ada1805ab68cbfbf793","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a9887ba_60f5a079","updated":"2024-03-01 07:20:11.000000000","message":"Dependency merged","commit_id":"7b0e609472df5cbc884d1e2f6666f4d04386df37"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a7268da37a8f417f3533367e5f57b3fbc3cb01ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"570e1c90_2f0a10a8","updated":"2024-03-04 14:45:20.000000000","message":"Isn\u0027t the existing test a big race? I\u0027m not sure how it can work reliably, if an image is cached super fast. Perhaps it would be better to just skip the queue assertion and wait for it to become cached for a test like this? I guess I need to go see, maybe the periodic is set very long in the devstack patch to reduce the window, but then we just end up blocking a worker for a long time waiting. What am I missing?","commit_id":"7b0e609472df5cbc884d1e2f6666f4d04386df37"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"aed76a65f7f6a84c9f6a8eff24579b53d118319d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7107e791_0f012aa2","updated":"2024-03-04 15:02:57.000000000","message":"Will push a new revision, thank you for inputs!","commit_id":"7b0e609472df5cbc884d1e2f6666f4d04386df37"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4a727fcda260b9575fe85840dcea35d559620edf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"42c8a732_06d0dffc","updated":"2024-03-04 15:31:06.000000000","message":"Looks good to me now, pending results of course.","commit_id":"56364027879c655e38957780059f41007e6516ea"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ac2bb85a4cb4848dffbff0f7f9939c5743aa0738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f19b6e69_adbef188","updated":"2024-03-05 09:37:35.000000000","message":"lgtm, thanks","commit_id":"56364027879c655e38957780059f41007e6516ea"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fd582a9a7825d5f97db38fa8b4cbf8531db6e33d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f0284fe6_70ac1160","updated":"2024-03-05 02:55:48.000000000","message":"thanks, lgtm, new test is passing https://zuul.opendev.org/t/openstack/build/461a2b1086b24fb19569a1a260ba9fdf/log/job-output.txt#23632","commit_id":"56364027879c655e38957780059f41007e6516ea"}],"tempest/api/image/v2/admin/test_image_caching.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a7268da37a8f417f3533367e5f57b3fbc3cb01ae","unresolved":true,"context_lines":[{"line_number":47,"context_line":"                image_id)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        for image_id in self.cached_info_remote:"},{"line_number":50,"context_line":"            self.os_admin.image_cache_client.cache_delete("},{"line_number":51,"context_line":"                image_id)"},{"line_number":52,"context_line":"        super(ImageCachingTest, self).tearDown()"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"04949e73_f23a8bf5","line":50,"updated":"2024-03-04 14:45:20.000000000","message":"I think this can be one line :)","commit_id":"7b0e609472df5cbc884d1e2f6666f4d04386df37"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a1fb345ed8ba6302ec4397f5ff5c6cc461a72294","unresolved":true,"context_lines":[{"line_number":47,"context_line":"                image_id)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        for image_id in self.cached_info_remote:"},{"line_number":50,"context_line":"            self.os_admin.image_cache_client.cache_delete("},{"line_number":51,"context_line":"                image_id)"},{"line_number":52,"context_line":"        super(ImageCachingTest, self).tearDown()"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f77950d8_c832367c","line":50,"in_reply_to":"04949e73_f23a8bf5","updated":"2024-03-04 14:54:33.000000000","message":"cache delete all?","commit_id":"7b0e609472df5cbc884d1e2f6666f4d04386df37"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"aed76a65f7f6a84c9f6a8eff24579b53d118319d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                image_id)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        for image_id in self.cached_info_remote:"},{"line_number":50,"context_line":"            self.os_admin.image_cache_client.cache_delete("},{"line_number":51,"context_line":"                image_id)"},{"line_number":52,"context_line":"        super(ImageCachingTest, self).tearDown()"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d02ebfeb_8a30a08b","line":50,"in_reply_to":"d93fface_f05a68a7","updated":"2024-03-04 15:02:57.000000000","message":"ack","commit_id":"7b0e609472df5cbc884d1e2f6666f4d04386df37"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0077b74a059b4eb838581d4718fc84561015ce98","unresolved":true,"context_lines":[{"line_number":47,"context_line":"                image_id)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        for image_id in self.cached_info_remote:"},{"line_number":50,"context_line":"            self.os_admin.image_cache_client.cache_delete("},{"line_number":51,"context_line":"                image_id)"},{"line_number":52,"context_line":"        super(ImageCachingTest, self).tearDown()"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d93fface_f05a68a7","line":50,"in_reply_to":"f77950d8_c832367c","updated":"2024-03-04 14:58:33.000000000","message":"No, I mean I don\u0027t think you need to put `image_id` on the next line :)","commit_id":"7b0e609472df5cbc884d1e2f6666f4d04386df37"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a7268da37a8f417f3533367e5f57b3fbc3cb01ae","unresolved":true,"context_lines":[{"line_number":128,"context_line":"        # Queue image for caching"},{"line_number":129,"context_line":"        self.os_admin.image_cache_client.cache_queue(image[\u0027id\u0027])"},{"line_number":130,"context_line":"        self.cached_info[image[\u0027id\u0027]] \u003d \u0027queued\u0027"},{"line_number":131,"context_line":"        # Verify that we have 1 image for queueing and 0 for caching"},{"line_number":132,"context_line":"        output \u003d self.os_admin.image_cache_client.list_cache()"},{"line_number":133,"context_line":"        self._assertCheckQueues(output[\u0027queued_images\u0027], self.cached_info)"},{"line_number":134,"context_line":"        self._assertCheckCache(output[\u0027cached_images\u0027], self.cached_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"abbdb74c_a9b743fa","line":131,"updated":"2024-03-04 14:45:20.000000000","message":"I\u0027m not really sure how this test could work reliably... Isn\u0027t this just a big race?","commit_id":"7b0e609472df5cbc884d1e2f6666f4d04386df37"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0077b74a059b4eb838581d4718fc84561015ce98","unresolved":true,"context_lines":[{"line_number":128,"context_line":"        # Queue image for caching"},{"line_number":129,"context_line":"        self.os_admin.image_cache_client.cache_queue(image[\u0027id\u0027])"},{"line_number":130,"context_line":"        self.cached_info[image[\u0027id\u0027]] \u003d \u0027queued\u0027"},{"line_number":131,"context_line":"        # Verify that we have 1 image for queueing and 0 for caching"},{"line_number":132,"context_line":"        output \u003d self.os_admin.image_cache_client.list_cache()"},{"line_number":133,"context_line":"        self._assertCheckQueues(output[\u0027queued_images\u0027], self.cached_info)"},{"line_number":134,"context_line":"        self._assertCheckCache(output[\u0027cached_images\u0027], self.cached_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bcbe401a_3267c535","line":131,"in_reply_to":"a83eca9c_268f548c","updated":"2024-03-04 14:58:33.000000000","message":"Yeah, I imagine we\u0027re just getting lucky that it doesn\u0027t complete before we check it right now. But yes, I think it would be better to either go straight to waiting for \"cached\" or at least make it not fatal if we see queued before cached.\n\nI suspect this is the sort of time bomb we could have where this passes 100% now, and then we make some change to the workers that makes them faster or slower and suddenly this test fails 100% of the time. Probably best to fix that up while we\u0027re here. The functional tests should be enough to confirm the queued-\u003ecached transition.","commit_id":"7b0e609472df5cbc884d1e2f6666f4d04386df37"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a1fb345ed8ba6302ec4397f5ff5c6cc461a72294","unresolved":true,"context_lines":[{"line_number":128,"context_line":"        # Queue image for caching"},{"line_number":129,"context_line":"        self.os_admin.image_cache_client.cache_queue(image[\u0027id\u0027])"},{"line_number":130,"context_line":"        self.cached_info[image[\u0027id\u0027]] \u003d \u0027queued\u0027"},{"line_number":131,"context_line":"        # Verify that we have 1 image for queueing and 0 for caching"},{"line_number":132,"context_line":"        output \u003d self.os_admin.image_cache_client.list_cache()"},{"line_number":133,"context_line":"        self._assertCheckQueues(output[\u0027queued_images\u0027], self.cached_info)"},{"line_number":134,"context_line":"        self._assertCheckCache(output[\u0027cached_images\u0027], self.cached_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a83eca9c_268f548c","line":131,"in_reply_to":"abbdb74c_a9b743fa","updated":"2024-03-04 14:54:33.000000000","message":"This never caused a race till date, but yes there is a possibility of a race here. I think we should avoid checking for queued state. If you agree to make change in this patch, I will do it.","commit_id":"7b0e609472df5cbc884d1e2f6666f4d04386df37"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"aed76a65f7f6a84c9f6a8eff24579b53d118319d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        # Queue image for caching"},{"line_number":129,"context_line":"        self.os_admin.image_cache_client.cache_queue(image[\u0027id\u0027])"},{"line_number":130,"context_line":"        self.cached_info[image[\u0027id\u0027]] \u003d \u0027queued\u0027"},{"line_number":131,"context_line":"        # Verify that we have 1 image for queueing and 0 for caching"},{"line_number":132,"context_line":"        output \u003d self.os_admin.image_cache_client.list_cache()"},{"line_number":133,"context_line":"        self._assertCheckQueues(output[\u0027queued_images\u0027], self.cached_info)"},{"line_number":134,"context_line":"        self._assertCheckCache(output[\u0027cached_images\u0027], self.cached_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3396a770_2bda5ad8","line":131,"in_reply_to":"bcbe401a_3267c535","updated":"2024-03-04 15:02:57.000000000","message":"ack","commit_id":"7b0e609472df5cbc884d1e2f6666f4d04386df37"}]}