)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7b2879ea27c9d0fb52b24691537e15489367ef1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b9aeb507_1b7d6e06","updated":"2023-12-01 10:25:51.000000000","message":"recheck unrelated failure","commit_id":"7872178bc7c6a262569686d465548c47a91b5f08"},{"author":{"_account_id":33983,"name":"Luigi Dino Tamagnone","display_name":"luigi","email":"ltamagno@redhat.com","username":"ltamagno"},"change_message_id":"505c3c32a0cb04a2dfd77e8b9bc686bd4a415ba0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"88260177_8b197c7b","updated":"2023-12-01 15:55:16.000000000","message":"All the files should be update now with prefix option","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb32aac1305a3afb23b5c9d5382a63cafa99bc79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"760fa0fd_2598566c","updated":"2023-12-05 20:37:04.000000000","message":"thanks for updating all. overall looks good to me, a few comments inline","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"8c0fb6b2cb65a28ec9f63ab4410290b9b40aae7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"23a9d5a0_dd6586bc","updated":"2023-12-07 17:20:15.000000000","message":"I just quickly went through the patch and it looks good to me. I have just two questions:\n\n- How will this work with plugins that use the rand_name() function? I can imagine it might be confusing for someone that the new config option won\u0027t influence plugins [1] if I understand it correctly.\n\n- Do we want to modify the hacking rules [2] (if it is possible) to ensure that we check that we always pass the prefix parameter to rand_name() function? I think in the future someone will forget to keep an eye on this.\n\n[1] https://opendev.org/openstack/keystone-tempest-plugin/src/commit/dbe56f0a07febd9e8babf54b88c63084b59f0b39/keystone_tempest_plugin/tests/api/identity/v3/test_oauth1_tokens.py#L27\n\n[2] https://opendev.org/openstack/tempest/src/branch/master/tempest/hacking/checks.py","commit_id":"213d0a4c686fc99a730f7774b935bed0dd9a8ce4"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"ed4899b45e6e2d829ccfff43eae4f79bfb0e6215","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"71a11d12_a7986622","updated":"2023-12-11 10:56:41.000000000","message":"LGTM! Thanks gmann for the answers.","commit_id":"213d0a4c686fc99a730f7774b935bed0dd9a8ce4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b6632569716dc48a1356f9ef963e54819a8e2b21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"01b4f964_1a14e7cf","updated":"2023-12-11 10:59:13.000000000","message":"all questions answered, let\u0027s proceed with this to avoid any merge conflicts as this is a huge patch.","commit_id":"213d0a4c686fc99a730f7774b935bed0dd9a8ce4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"146f48bd3910666f554eac600686a1660d454f18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9d56b417_14dea5ef","updated":"2023-12-07 19:12:01.000000000","message":"lgtm, waiting to approve as Lukas has a few question here and if answer lgtm to him.","commit_id":"213d0a4c686fc99a730f7774b935bed0dd9a8ce4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"146f48bd3910666f554eac600686a1660d454f18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1b129c09_d77563b3","in_reply_to":"23a9d5a0_dd6586bc","updated":"2023-12-07 19:12:01.000000000","message":"Thanks Lukas, good points:\n\n\u003e - How will this work with plugins that use the rand_name() function? I can imagine it might be confusing for someone that the new config option won\u0027t influence plugins [1] if I understand it correctly.\n\nI think plugins can adopt these in their own pace but it will be good if someone can start it.\n\n\u003e \n\u003e - Do we want to modify the hacking rules [2] (if it is possible) to ensure that we check that we always pass the prefix parameter to rand_name() function? I think in the future someone will forget to keep an eye on this.\n\nAt the end, yes but until all test and plugins are fixed it will break the things so let\u0027s plan it at the end.","commit_id":"213d0a4c686fc99a730f7774b935bed0dd9a8ce4"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"ed4899b45e6e2d829ccfff43eae4f79bfb0e6215","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"18f33c40_c204a4f1","in_reply_to":"9d56b417_14dea5ef","updated":"2023-12-11 10:56:41.000000000","message":"\u003e I think plugins can adopt these in their own pace but it will be good if someone can start it.\n\nThanks gmann for the explanation. We can slowly start the effort of updating the rand_name() function in plugins. We have some students who are helping us with some stuff. I think this would be great introductory task for them. \n\n\u003e At the end, yes but until all test and plugins are fixed it will break the things so let\u0027s plan it at the end.\n\nOk, we can do this once we have all the calls of rand_name updated.","commit_id":"213d0a4c686fc99a730f7774b935bed0dd9a8ce4"}],"tempest/api/compute/admin/test_aggregates_negative.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb32aac1305a3afb23b5c9d5382a63cafa99bc79","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _create_test_aggregate(self):"},{"line_number":46,"context_line":"        aggregate_name \u003d data_utils.rand_name("},{"line_number":47,"context_line":"            prefix\u003dCONF.validation.resource_name_prefix,"},{"line_number":48,"context_line":"            name\u003dself.aggregate_name_prefix)"},{"line_number":49,"context_line":"        aggregate \u003d (self.client.create_aggregate(name\u003daggregate_name)"},{"line_number":50,"context_line":"                     [\u0027aggregate\u0027])"},{"line_number":51,"context_line":"        self.addCleanup(self.client.delete_aggregate, aggregate[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"feea3ca8_d3a7241e","line":48,"range":{"start_line":47,"start_character":12,"end_line":48,"end_character":44},"updated":"2023-12-05 20:37:04.000000000","message":"these will make name like tempest-test-test_aggregate-\u003crandom number\u003e\n\nit adds \u0027test\u0027 twice and most of test might have same \u0027test\u0027 in their existing name/prefix. I think we should just make resource_name_prefix as \u0027tempest\u0027 which should be clear enough that this resource is tempest created resource. I will comment it in dependent change so no action needed here.","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e78e3d817761b192ece4b1cbd0a527b9a0ff608a","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _create_test_aggregate(self):"},{"line_number":46,"context_line":"        aggregate_name \u003d data_utils.rand_name("},{"line_number":47,"context_line":"            prefix\u003dCONF.validation.resource_name_prefix,"},{"line_number":48,"context_line":"            name\u003dself.aggregate_name_prefix)"},{"line_number":49,"context_line":"        aggregate \u003d (self.client.create_aggregate(name\u003daggregate_name)"},{"line_number":50,"context_line":"                     [\u0027aggregate\u0027])"},{"line_number":51,"context_line":"        self.addCleanup(self.client.delete_aggregate, aggregate[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"267b51e0_c32a9a5b","line":48,"range":{"start_line":47,"start_character":12,"end_line":48,"end_character":44},"in_reply_to":"feea3ca8_d3a7241e","updated":"2023-12-06 20:54:14.000000000","message":"Done","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"}],"tempest/api/compute/admin/test_create_server.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb32aac1305a3afb23b5c9d5382a63cafa99bc79","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        def create_flavor_with_ephemeral(ephem_disk):"},{"line_number":53,"context_line":"            name \u003d \u0027flavor_with_ephemeral_%s\u0027 % ephem_disk"},{"line_number":54,"context_line":"            flavor_name \u003d data_utils.rand_name("},{"line_number":55,"context_line":"                prefix\u003dCONF.validation.resource_name_prefix, name\u003dname)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"            ram \u003d flavor_base[\u0027ram\u0027]"},{"line_number":58,"context_line":"            vcpus \u003d flavor_base[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"72a01272_2e0731e0","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":71},"updated":"2023-12-05 20:37:04.000000000","message":"I am wondering if we are making it too long name and nova might reject it or maybe not? most of name limit is 255 char. anyways test should catch that if we overlimit the name length","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e78e3d817761b192ece4b1cbd0a527b9a0ff608a","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        def create_flavor_with_ephemeral(ephem_disk):"},{"line_number":53,"context_line":"            name \u003d \u0027flavor_with_ephemeral_%s\u0027 % ephem_disk"},{"line_number":54,"context_line":"            flavor_name \u003d data_utils.rand_name("},{"line_number":55,"context_line":"                prefix\u003dCONF.validation.resource_name_prefix, name\u003dname)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"            ram \u003d flavor_base[\u0027ram\u0027]"},{"line_number":58,"context_line":"            vcpus \u003d flavor_base[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7bd9c254_62aa7a6a","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":71},"in_reply_to":"72a01272_2e0731e0","updated":"2023-12-06 20:54:14.000000000","message":"agree, it seems we\u0027re going with \"tempest\" prefix, that makes it 7 characters .. we\u0027re prolonging the name only by 7 chars - if this change will cause issues with name length, it would mean that the name was already too long before this change and this just made it visible","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"}],"tempest/api/compute/servers/test_device_tagging.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb32aac1305a3afb23b5c9d5382a63cafa99bc79","unresolved":true,"context_lines":[{"line_number":26,"context_line":"from tempest.lib.common.utils import test_utils"},{"line_number":27,"context_line":"from tempest.lib import decorators"},{"line_number":28,"context_line":"from tempest.lib import exceptions"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d config.CONF"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"2f25768c_4e03abc9","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":0},"updated":"2023-12-05 20:37:04.000000000","message":"this change not needed but nevermind","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e78e3d817761b192ece4b1cbd0a527b9a0ff608a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from tempest.lib.common.utils import test_utils"},{"line_number":27,"context_line":"from tempest.lib import decorators"},{"line_number":28,"context_line":"from tempest.lib import exceptions"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d config.CONF"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3705554a_b7c5da73","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":0},"in_reply_to":"2f25768c_4e03abc9","updated":"2023-12-06 20:54:14.000000000","message":"Done","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"}],"tempest/api/identity/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb32aac1305a3afb23b5c9d5382a63cafa99bc79","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        \"\"\"Set up a test tenant.\"\"\""},{"line_number":165,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":166,"context_line":"            kwargs[\u0027name\u0027] \u003d data_utils.rand_name("},{"line_number":167,"context_line":"                name\u003d\u0027test_tenant\u0027, "},{"line_number":168,"context_line":"                prefix\u003dCONF.validation.resource_name_prefix)"},{"line_number":169,"context_line":"        if \u0027description\u0027 not in kwargs:"},{"line_number":170,"context_line":"            kwargs[\u0027description\u0027] \u003d data_utils.rand_name(name\u003d\u0027desc\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"4f954c59_87663f45","line":167,"range":{"start_line":167,"start_character":35,"end_line":167,"end_character":36},"updated":"2023-12-05 20:37:04.000000000","message":"whitespace","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e78e3d817761b192ece4b1cbd0a527b9a0ff608a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        \"\"\"Set up a test tenant.\"\"\""},{"line_number":165,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":166,"context_line":"            kwargs[\u0027name\u0027] \u003d data_utils.rand_name("},{"line_number":167,"context_line":"                name\u003d\u0027test_tenant\u0027, "},{"line_number":168,"context_line":"                prefix\u003dCONF.validation.resource_name_prefix)"},{"line_number":169,"context_line":"        if \u0027description\u0027 not in kwargs:"},{"line_number":170,"context_line":"            kwargs[\u0027description\u0027] \u003d data_utils.rand_name(name\u003d\u0027desc\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"aa4bed24_f430afd9","line":167,"range":{"start_line":167,"start_character":35,"end_line":167,"end_character":36},"in_reply_to":"4f954c59_87663f45","updated":"2023-12-06 20:54:14.000000000","message":"lol, i don\u0027t know how i missed that, usually all my text editors remove trailing spaces","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"155732c4761c53faa731fbc05644f6d50a363c57","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        \"\"\"Set up a test tenant.\"\"\""},{"line_number":165,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":166,"context_line":"            kwargs[\u0027name\u0027] \u003d data_utils.rand_name("},{"line_number":167,"context_line":"                name\u003d\u0027test_tenant\u0027, "},{"line_number":168,"context_line":"                prefix\u003dCONF.validation.resource_name_prefix)"},{"line_number":169,"context_line":"        if \u0027description\u0027 not in kwargs:"},{"line_number":170,"context_line":"            kwargs[\u0027description\u0027] \u003d data_utils.rand_name(name\u003d\u0027desc\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c66f727e_031fda93","line":167,"range":{"start_line":167,"start_character":35,"end_line":167,"end_character":36},"in_reply_to":"aa4bed24_f430afd9","updated":"2023-12-06 23:39:21.000000000","message":"omg, I\u0027ve noticed only now, I didn\u0027t leave the whitespace there, this isn\u0027t my change\n\n@luigi, why did you push another patchset to this instead of creating a new review on top of this? We were supposed to divide the files and each of us was supposed to add the prefix to each rand_name call. I did my half, pushed this patch and named it \"Pass resource_name_prefix from tests (1/2)\" indicating that this is just the first half. You were supposed to push your changes to a new patch!","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"146f48bd3910666f554eac600686a1660d454f18","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        \"\"\"Set up a test tenant.\"\"\""},{"line_number":165,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":166,"context_line":"            kwargs[\u0027name\u0027] \u003d data_utils.rand_name("},{"line_number":167,"context_line":"                name\u003d\u0027test_tenant\u0027, "},{"line_number":168,"context_line":"                prefix\u003dCONF.validation.resource_name_prefix)"},{"line_number":169,"context_line":"        if \u0027description\u0027 not in kwargs:"},{"line_number":170,"context_line":"            kwargs[\u0027description\u0027] \u003d data_utils.rand_name(name\u003d\u0027desc\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ea66e44b_9a91c2d6","line":167,"range":{"start_line":167,"start_character":35,"end_line":167,"end_character":36},"in_reply_to":"c66f727e_031fda93","updated":"2023-12-07 19:12:01.000000000","message":"Done","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb32aac1305a3afb23b5c9d5382a63cafa99bc79","unresolved":true,"context_lines":[{"line_number":254,"context_line":"    def create_domain(cls, **kwargs):"},{"line_number":255,"context_line":"        \"\"\"Create a domain.\"\"\""},{"line_number":256,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":257,"context_line":"            kwargs[\u0027name\u0027] \u003d data_utils.rand_name(test\u003d\u0027test_domain\u0027,"},{"line_number":258,"context_line":"                prefix\u003dCONF.validation.resource_name_prefix)"},{"line_number":259,"context_line":"        if \u0027description\u0027 not in kwargs:"},{"line_number":260,"context_line":"            kwargs[\u0027description\u0027] \u003d data_utils.rand_name(name\u003d\u0027desc\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7b1aefff_c694f84f","line":257,"range":{"start_line":257,"start_character":50,"end_line":257,"end_character":54},"updated":"2023-12-05 20:37:04.000000000","message":"s/test/name","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e78e3d817761b192ece4b1cbd0a527b9a0ff608a","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    def create_domain(cls, **kwargs):"},{"line_number":255,"context_line":"        \"\"\"Create a domain.\"\"\""},{"line_number":256,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":257,"context_line":"            kwargs[\u0027name\u0027] \u003d data_utils.rand_name(test\u003d\u0027test_domain\u0027,"},{"line_number":258,"context_line":"                prefix\u003dCONF.validation.resource_name_prefix)"},{"line_number":259,"context_line":"        if \u0027description\u0027 not in kwargs:"},{"line_number":260,"context_line":"            kwargs[\u0027description\u0027] \u003d data_utils.rand_name(name\u003d\u0027desc\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f8aaa126_12e07d87","line":257,"range":{"start_line":257,"start_character":50,"end_line":257,"end_character":54},"in_reply_to":"7b1aefff_c694f84f","updated":"2023-12-06 20:54:14.000000000","message":"good catch!","commit_id":"33778bcd820f0a0e8779a5aea960bd0853ecf533"}]}