)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80c81f5318469c9b535e46de61582a4f9c10fd4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7564791_017e491b","updated":"2023-12-05 08:10:27.000000000","message":"this is missing the cleanup of the extract dir i think but over all it looks good","commit_id":"f3895f008a2b15027f5943b3f5ca6384cbc418be"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ee67810359346086d53530ffcc2e3be2fd4c1569","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"81d87040_87972da1","updated":"2023-12-06 09:08:08.000000000","message":"looks good to me, thank you","commit_id":"a0b161bbde6d7734833a26ced76ca44b888fe152"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ee51cf9c7d9c051ade25d5f410362c92022df195","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a9ea50a_69a61631","updated":"2023-12-05 22:24:26.000000000","message":"thanks, lgtm","commit_id":"a0b161bbde6d7734833a26ced76ca44b888fe152"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a783ac9acecac8577e453274066a615c48fad1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0ade7c9b_c5743723","updated":"2023-12-05 10:55:01.000000000","message":"we shall see what zuul thinks via the nova patch that uses this with the uec images but over all this looks good to me.","commit_id":"a0b161bbde6d7734833a26ced76ca44b888fe152"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5fa6314ca248ad34cacfae2ef3a84cc675a15c67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a3bf428_8d7f0d26","in_reply_to":"0ade7c9b_c5743723","updated":"2023-12-05 16:58:58.000000000","message":"The nova patch has passed https://review.opendev.org/c/openstack/nova/+/902217 !","commit_id":"a0b161bbde6d7734833a26ced76ca44b888fe152"}],"tempest/api/compute/admin/test_volume.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80c81f5318469c9b535e46de61582a4f9c10fd4a","unresolved":true,"context_lines":[{"line_number":59,"context_line":"            \u0027min_ram\u0027: image[\u0027min_ram\u0027],"},{"line_number":60,"context_line":"            \u0027visibility\u0027: \u0027public\u0027,"},{"line_number":61,"context_line":"        }"},{"line_number":62,"context_line":"        if \u0027kernel_id\u0027 in image:"},{"line_number":63,"context_line":"            create_dict[\u0027kernel_id\u0027] \u003d image[\u0027kernel_id\u0027]"},{"line_number":64,"context_line":"        if \u0027ramdisk_id\u0027 in image:"},{"line_number":65,"context_line":"            create_dict[\u0027ramdisk_id\u0027] \u003d image[\u0027ramdisk_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"d1ea8214_0f882f94","line":62,"updated":"2023-12-05 08:10:27.000000000","message":"i guess neutron never ran this","commit_id":"f3895f008a2b15027f5943b3f5ca6384cbc418be"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8739a84e136389c7c367910830c848f5e94e6d65","unresolved":true,"context_lines":[{"line_number":59,"context_line":"            \u0027min_ram\u0027: image[\u0027min_ram\u0027],"},{"line_number":60,"context_line":"            \u0027visibility\u0027: \u0027public\u0027,"},{"line_number":61,"context_line":"        }"},{"line_number":62,"context_line":"        if \u0027kernel_id\u0027 in image:"},{"line_number":63,"context_line":"            create_dict[\u0027kernel_id\u0027] \u003d image[\u0027kernel_id\u0027]"},{"line_number":64,"context_line":"        if \u0027ramdisk_id\u0027 in image:"},{"line_number":65,"context_line":"            create_dict[\u0027ramdisk_id\u0027] \u003d image[\u0027ramdisk_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fac7df57_bbf7da15","line":62,"in_reply_to":"d1ea8214_0f882f94","updated":"2023-12-05 09:42:04.000000000","message":"Neutron is pretty aggressive with running only network-focused tests in their gate, from what I could tell.","commit_id":"f3895f008a2b15027f5943b3f5ca6384cbc418be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a783ac9acecac8577e453274066a615c48fad1d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            \u0027min_ram\u0027: image[\u0027min_ram\u0027],"},{"line_number":60,"context_line":"            \u0027visibility\u0027: \u0027public\u0027,"},{"line_number":61,"context_line":"        }"},{"line_number":62,"context_line":"        if \u0027kernel_id\u0027 in image:"},{"line_number":63,"context_line":"            create_dict[\u0027kernel_id\u0027] \u003d image[\u0027kernel_id\u0027]"},{"line_number":64,"context_line":"        if \u0027ramdisk_id\u0027 in image:"},{"line_number":65,"context_line":"            create_dict[\u0027ramdisk_id\u0027] \u003d image[\u0027ramdisk_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ea369ec3_ee705489","line":62,"in_reply_to":"fac7df57_bbf7da15","updated":"2023-12-05 10:55:01.000000000","message":"Acknowledged","commit_id":"f3895f008a2b15027f5943b3f5ca6384cbc418be"}],"tempest/scenario/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80c81f5318469c9b535e46de61582a4f9c10fd4a","unresolved":true,"context_lines":[{"line_number":766,"context_line":"        linux_client.validate_authentication()"},{"line_number":767,"context_line":"        return linux_client"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    def image_create(self, name\u003d\u0027scenario-img\u0027, **kwargs):"},{"line_number":770,"context_line":"        img_path \u003d CONF.scenario.img_file"},{"line_number":771,"context_line":"        if not os.path.exists(img_path):"},{"line_number":772,"context_line":"            lib_exc.InvalidConfiguration("}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa390e4_be7a470a","line":769,"updated":"2023-12-05 08:10:27.000000000","message":"the fact they never ran this is a little more surprising since i would not have expected this to be the first time the senario test have been used with the uec images","commit_id":"f3895f008a2b15027f5943b3f5ca6384cbc418be"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8739a84e136389c7c367910830c848f5e94e6d65","unresolved":true,"context_lines":[{"line_number":766,"context_line":"        linux_client.validate_authentication()"},{"line_number":767,"context_line":"        return linux_client"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    def image_create(self, name\u003d\u0027scenario-img\u0027, **kwargs):"},{"line_number":770,"context_line":"        img_path \u003d CONF.scenario.img_file"},{"line_number":771,"context_line":"        if not os.path.exists(img_path):"},{"line_number":772,"context_line":"            lib_exc.InvalidConfiguration("}],"source_content_type":"text/x-python","patch_set":2,"id":"6f437080_c87301f1","line":769,"in_reply_to":"1fa390e4_be7a470a","updated":"2023-12-05 09:42:04.000000000","message":"Yeah.. there\u0027s literally only one test class that runs this and it\u0027s TestMinimumBasicScenario 😑","commit_id":"f3895f008a2b15027f5943b3f5ca6384cbc418be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a783ac9acecac8577e453274066a615c48fad1d","unresolved":false,"context_lines":[{"line_number":766,"context_line":"        linux_client.validate_authentication()"},{"line_number":767,"context_line":"        return linux_client"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    def image_create(self, name\u003d\u0027scenario-img\u0027, **kwargs):"},{"line_number":770,"context_line":"        img_path \u003d CONF.scenario.img_file"},{"line_number":771,"context_line":"        if not os.path.exists(img_path):"},{"line_number":772,"context_line":"            lib_exc.InvalidConfiguration("}],"source_content_type":"text/x-python","patch_set":2,"id":"518cfaef_32bff57f","line":769,"in_reply_to":"6f437080_c87301f1","updated":"2023-12-05 10:55:01.000000000","message":"Acknowledged","commit_id":"f3895f008a2b15027f5943b3f5ca6384cbc418be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80c81f5318469c9b535e46de61582a4f9c10fd4a","unresolved":true,"context_lines":[{"line_number":800,"context_line":"        # This code is basically copying the devstack code that extracts and"},{"line_number":801,"context_line":"        # uploads split kernel/ramdisk images."},{"line_number":802,"context_line":"        if tarfile.is_tarfile(img_path):"},{"line_number":803,"context_line":"            extract_dir \u003d os.path.join(tempfile.gettempdir(), \u0027images\u0027, name)"},{"line_number":804,"context_line":"            os.makedirs(extract_dir)"},{"line_number":805,"context_line":"            with tarfile.open(img_path) as tar:"},{"line_number":806,"context_line":"                tar.extractall(extract_dir, filter\u003d\u0027data\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7bff17b5_c283b23b","line":803,"updated":"2023-12-05 08:10:27.000000000","message":"you should do self.addCleanup(shutil.rmtree, extract_dir)","commit_id":"f3895f008a2b15027f5943b3f5ca6384cbc418be"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8739a84e136389c7c367910830c848f5e94e6d65","unresolved":true,"context_lines":[{"line_number":800,"context_line":"        # This code is basically copying the devstack code that extracts and"},{"line_number":801,"context_line":"        # uploads split kernel/ramdisk images."},{"line_number":802,"context_line":"        if tarfile.is_tarfile(img_path):"},{"line_number":803,"context_line":"            extract_dir \u003d os.path.join(tempfile.gettempdir(), \u0027images\u0027, name)"},{"line_number":804,"context_line":"            os.makedirs(extract_dir)"},{"line_number":805,"context_line":"            with tarfile.open(img_path) as tar:"},{"line_number":806,"context_line":"                tar.extractall(extract_dir, filter\u003d\u0027data\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d29e9919_11fa602a","line":803,"in_reply_to":"7bff17b5_c283b23b","updated":"2023-12-05 09:42:04.000000000","message":"Ah, right, thanks!","commit_id":"f3895f008a2b15027f5943b3f5ca6384cbc418be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a783ac9acecac8577e453274066a615c48fad1d","unresolved":false,"context_lines":[{"line_number":800,"context_line":"        # This code is basically copying the devstack code that extracts and"},{"line_number":801,"context_line":"        # uploads split kernel/ramdisk images."},{"line_number":802,"context_line":"        if tarfile.is_tarfile(img_path):"},{"line_number":803,"context_line":"            extract_dir \u003d os.path.join(tempfile.gettempdir(), \u0027images\u0027, name)"},{"line_number":804,"context_line":"            os.makedirs(extract_dir)"},{"line_number":805,"context_line":"            with tarfile.open(img_path) as tar:"},{"line_number":806,"context_line":"                tar.extractall(extract_dir, filter\u003d\u0027data\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab0d627_27725bee","line":803,"in_reply_to":"d29e9919_11fa602a","updated":"2023-12-05 10:55:01.000000000","message":"Done","commit_id":"f3895f008a2b15027f5943b3f5ca6384cbc418be"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8739a84e136389c7c367910830c848f5e94e6d65","unresolved":true,"context_lines":[{"line_number":808,"context_line":"            for fname in filenames:"},{"line_number":809,"context_line":"                if re.search(r\u0027(.*-vmlinuz.*|aki-.*/image$)\u0027, fname):"},{"line_number":810,"context_line":"                    kernel_img_path \u003d os.path.join(extract_dir, fname)"},{"line_number":811,"context_line":"                elif re.search(r\u0027(.*\u003dinitrd.*|ari-.*/image$)\u0027, fname):"},{"line_number":812,"context_line":"                    ramdisk_img_path \u003d os.path.join(extract_dir, fname)"},{"line_number":813,"context_line":"                elif re.search(f\u0027(.*\\\\.img$|ami-.*/image$)\u0027, fname):"},{"line_number":814,"context_line":"                    img_path \u003d os.path.join(extract_dir, fname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f6e5adf1_375571fb","line":811,"range":{"start_line":811,"start_character":36,"end_line":811,"end_character":37},"updated":"2023-12-05 09:42:04.000000000","message":"ARRRGHHHHH 😩","commit_id":"f3895f008a2b15027f5943b3f5ca6384cbc418be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a783ac9acecac8577e453274066a615c48fad1d","unresolved":false,"context_lines":[{"line_number":808,"context_line":"            for fname in filenames:"},{"line_number":809,"context_line":"                if re.search(r\u0027(.*-vmlinuz.*|aki-.*/image$)\u0027, fname):"},{"line_number":810,"context_line":"                    kernel_img_path \u003d os.path.join(extract_dir, fname)"},{"line_number":811,"context_line":"                elif re.search(r\u0027(.*\u003dinitrd.*|ari-.*/image$)\u0027, fname):"},{"line_number":812,"context_line":"                    ramdisk_img_path \u003d os.path.join(extract_dir, fname)"},{"line_number":813,"context_line":"                elif re.search(f\u0027(.*\\\\.img$|ami-.*/image$)\u0027, fname):"},{"line_number":814,"context_line":"                    img_path \u003d os.path.join(extract_dir, fname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"01a19ab9_0fd61324","line":811,"range":{"start_line":811,"start_character":36,"end_line":811,"end_character":37},"in_reply_to":"f6e5adf1_375571fb","updated":"2023-12-05 10:55:01.000000000","message":"Acknowledged","commit_id":"f3895f008a2b15027f5943b3f5ca6384cbc418be"}]}