)]}'
{"tempest/api/compute/v3/admin/test_hosts.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"a4cc4f48d339d1448cffb446cb79c721d3ed8779","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # successful and it will return all the hosts"},{"line_number":87,"context_line":"        params \u003d {\u0027service\u0027: \u0027\u0027}"},{"line_number":88,"context_line":"        resp, hosts \u003d self.client.list_hosts(params)"},{"line_number":89,"context_line":"        self.assertNotEqual(0, len(hosts))"},{"line_number":90,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_f69b13c7","line":89,"updated":"2014-05-01 20:30:02.000000000","message":"If this is testing what the comment says then this should be asserting that the returned hosts is the same as what list_hosts() returns.","commit_id":"08d2421ebcabb1f5db061a5dfbc287c23f923537"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b2547435e96a28b12aa6ab58fd313f0c1df5fcdb","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # successful and it will return all the hosts"},{"line_number":87,"context_line":"        params \u003d {\u0027service\u0027: \u0027\u0027}"},{"line_number":88,"context_line":"        resp, hosts \u003d self.client.list_hosts(params)"},{"line_number":89,"context_line":"        self.assertNotEqual(0, len(hosts))"},{"line_number":90,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_2024dac3","line":89,"in_reply_to":"9ad9bd40_f69b13c7","updated":"2014-05-07 02:55:20.000000000","message":"Thanks. That is good validation point.\n Done.","commit_id":"08d2421ebcabb1f5db061a5dfbc287c23f923537"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"0c0f1458bb9a0391b657926283ac7ad7a31a12b8","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":72,"context_line":"    def test_list_hosts_with_service(self):"},{"line_number":73,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027availability_zone\u0027))"},{"line_number":74,"context_line":"        resp, hosts \u003d self.client.list_hosts()"},{"line_number":75,"context_line":"        host \u003d hosts[0]"},{"line_number":76,"context_line":"        service_name \u003d host[\u0027service\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_3118aa1d","line":73,"updated":"2014-05-07 06:31:57.000000000","message":"what is the use of lock here ?","commit_id":"7336e0864703b12d6a607c29a736e16d74610d82"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"350e4bb3d0664996de165d789c3a79012ec0b72f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":38,"context_line":"    def test_list_hosts_with_zone(self):"},{"line_number":39,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027availability_zone\u0027))"},{"line_number":40,"context_line":"        _, hosts \u003d self.client.list_hosts()"},{"line_number":41,"context_line":"        host \u003d hosts[0]"},{"line_number":42,"context_line":"        zone_name \u003d host[\u0027zone\u0027]"},{"line_number":43,"context_line":"        params \u003d {\u0027zone\u0027: zone_name}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_a1d098f8","line":40,"updated":"2014-05-07 13:28:19.000000000","message":"I think it will be better to add  \n\n    self.assertEqual(200, resp.status)\n\nhere than removing \"resp\" variable.","commit_id":"6c441c9e65e13b8a647fc4df24d43f520bc1129a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"0da4d8bf7cb3579b7d56c90a35b47f8002ccdbca","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":38,"context_line":"    def test_list_hosts_with_zone(self):"},{"line_number":39,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027availability_zone\u0027))"},{"line_number":40,"context_line":"        _, hosts \u003d self.client.list_hosts()"},{"line_number":41,"context_line":"        host \u003d hosts[0]"},{"line_number":42,"context_line":"        zone_name \u003d host[\u0027zone\u0027]"},{"line_number":43,"context_line":"        params \u003d {\u0027zone\u0027: zone_name}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_875c8c27","line":40,"in_reply_to":"7adec928_245e56ea","updated":"2014-05-07 14:15:08.000000000","message":"OK. Why do you use \n\n    self.assertEqual(200, resp.status)\n\nin lines 56, 78, 89, ...?\n\nIt is not clear for me.","commit_id":"6c441c9e65e13b8a647fc4df24d43f520bc1129a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f08c69a5535a45b46c1b3a55b5c7c9f4b289ceb2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":38,"context_line":"    def test_list_hosts_with_zone(self):"},{"line_number":39,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027availability_zone\u0027))"},{"line_number":40,"context_line":"        _, hosts \u003d self.client.list_hosts()"},{"line_number":41,"context_line":"        host \u003d hosts[0]"},{"line_number":42,"context_line":"        zone_name \u003d host[\u0027zone\u0027]"},{"line_number":43,"context_line":"        params \u003d {\u0027zone\u0027: zone_name}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_f6eeb6eb","line":40,"in_reply_to":"7adec928_875c8c27","updated":"2014-05-09 01:22:56.000000000","message":"There are discussion on http://lists.openstack.org/pipermail/openstack-dev/2014-May/034623.html to have the all return code check on client side.\n\nI will remove the return code check from this as client does check the same.","commit_id":"6c441c9e65e13b8a647fc4df24d43f520bc1129a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6a73144ee5f552b5212c0d5e7e38bd0455080712","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":38,"context_line":"    def test_list_hosts_with_zone(self):"},{"line_number":39,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027availability_zone\u0027))"},{"line_number":40,"context_line":"        _, hosts \u003d self.client.list_hosts()"},{"line_number":41,"context_line":"        host \u003d hosts[0]"},{"line_number":42,"context_line":"        zone_name \u003d host[\u0027zone\u0027]"},{"line_number":43,"context_line":"        params \u003d {\u0027zone\u0027: zone_name}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_245e56ea","line":40,"in_reply_to":"7adec928_a1d098f8","updated":"2014-05-07 13:51:42.000000000","message":"Thanks for the comment.\nActually status code is validated on client side by Json schema. So I think we should not add the same here.","commit_id":"6c441c9e65e13b8a647fc4df24d43f520bc1129a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"abba2377d3288564296e34515f54c55ff2f223c9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":38,"context_line":"    def test_list_hosts_with_zone(self):"},{"line_number":39,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027availability_zone\u0027))"},{"line_number":40,"context_line":"        _, hosts \u003d self.client.list_hosts()"},{"line_number":41,"context_line":"        host \u003d hosts[0]"},{"line_number":42,"context_line":"        zone_name \u003d host[\u0027zone\u0027]"},{"line_number":43,"context_line":"        params \u003d {\u0027zone\u0027: zone_name}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_4d7350e9","line":40,"in_reply_to":"7adec928_f6eeb6eb","updated":"2014-05-14 08:57:10.000000000","message":"Thanks, I understood.","commit_id":"6c441c9e65e13b8a647fc4df24d43f520bc1129a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"350e4bb3d0664996de165d789c3a79012ec0b72f","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":72,"context_line":"    def test_list_hosts_with_service(self):"},{"line_number":73,"context_line":"        _, hosts \u003d self.client.list_hosts()"},{"line_number":74,"context_line":"        host \u003d hosts[0]"},{"line_number":75,"context_line":"        service_name \u003d host[\u0027service\u0027]"},{"line_number":76,"context_line":"        params \u003d {\u0027service\u0027: service_name}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_a1f7b88b","line":73,"updated":"2014-05-07 13:28:19.000000000","message":"And here.","commit_id":"6c441c9e65e13b8a647fc4df24d43f520bc1129a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6a73144ee5f552b5212c0d5e7e38bd0455080712","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":72,"context_line":"    def test_list_hosts_with_service(self):"},{"line_number":73,"context_line":"        _, hosts \u003d self.client.list_hosts()"},{"line_number":74,"context_line":"        host \u003d hosts[0]"},{"line_number":75,"context_line":"        service_name \u003d host[\u0027service\u0027]"},{"line_number":76,"context_line":"        params \u003d {\u0027service\u0027: service_name}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_64585efb","line":73,"in_reply_to":"7adec928_a1f7b88b","updated":"2014-05-07 13:51:42.000000000","message":"same as above.","commit_id":"6c441c9e65e13b8a647fc4df24d43f520bc1129a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"350e4bb3d0664996de165d789c3a79012ec0b72f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":105,"context_line":"    def test_list_hosts_with_service_and_zone(self):"},{"line_number":106,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027availability_zone\u0027))"},{"line_number":107,"context_line":"        _, hosts \u003d self.client.list_hosts()"},{"line_number":108,"context_line":"        host \u003d hosts[0]"},{"line_number":109,"context_line":"        zone_name \u003d host[\u0027zone\u0027]"},{"line_number":110,"context_line":"        service_name \u003d host[\u0027service\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_a13ed827","line":107,"updated":"2014-05-07 13:28:19.000000000","message":"And here.","commit_id":"6c441c9e65e13b8a647fc4df24d43f520bc1129a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6a73144ee5f552b5212c0d5e7e38bd0455080712","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":105,"context_line":"    def test_list_hosts_with_service_and_zone(self):"},{"line_number":106,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027availability_zone\u0027))"},{"line_number":107,"context_line":"        _, hosts \u003d self.client.list_hosts()"},{"line_number":108,"context_line":"        host \u003d hosts[0]"},{"line_number":109,"context_line":"        zone_name \u003d host[\u0027zone\u0027]"},{"line_number":110,"context_line":"        service_name \u003d host[\u0027service\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_845d6aec","line":107,"in_reply_to":"7adec928_a13ed827","updated":"2014-05-07 13:51:42.000000000","message":"same as above.","commit_id":"6c441c9e65e13b8a647fc4df24d43f520bc1129a"}]}