)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1913d3286ca51988e4f668bdad5bea37746c83e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"650e6c52_005272b8","updated":"2024-07-08 17:29:05.000000000","message":"lgtm","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9ad73922b581c233d5c942062e951aaa18f5d11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"eca77362_c270360c","updated":"2024-07-08 11:43:45.000000000","message":"recheck get fresh logs","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a348bb855a004dc26ede65bbcd0774cc0177c98d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"717ae440_507f37d0","updated":"2024-07-08 12:21:26.000000000","message":"some questions inline, I could also handle those in a follow-up though if you prefer","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"08735bec403b90bdbdaf7d4cd4ed8469da677b53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b780d0ea_8647bc2d","updated":"2024-07-09 14:32:04.000000000","message":"lgtm","commit_id":"c0c90279ce45b62c9cee49c53e0fa2375b82e573"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"95082b5754c50c8340b9868cf8d6a8237d0a5256","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"aa33d266_20931b59","updated":"2024-07-09 05:09:23.000000000","message":"thx, lgtm now","commit_id":"c0c90279ce45b62c9cee49c53e0fa2375b82e573"}],"tempest/config.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a348bb855a004dc26ede65bbcd0774cc0177c98d","unresolved":true,"context_lines":[{"line_number":133,"context_line":"                                 \u0027Queens release. Options for the v2.0 API \u0027"},{"line_number":134,"context_line":"                                 \u0027will be removed in a future release.\u0027,"},{"line_number":135,"context_line":"               help\u003d\"Full URI of the OpenStack Identity API (Keystone), v2\"),"},{"line_number":136,"context_line":"    cfg.URIOpt(\u0027uri_v3\u0027,"},{"line_number":137,"context_line":"               schemes\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":138,"context_line":"               help\u003d\u0027Full URI of the OpenStack Identity API (Keystone), v3\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027auth_version\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dd9bfe6b_8d0fc20e","line":136,"updated":"2024-07-08 12:21:26.000000000","message":"Actually I wonder whether you\u0027d want to keep this option forever, or whether one could deprecate it instead and use the `uri` option for the identity option in the future.","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1913d3286ca51988e4f668bdad5bea37746c83e4","unresolved":true,"context_lines":[{"line_number":133,"context_line":"                                 \u0027Queens release. Options for the v2.0 API \u0027"},{"line_number":134,"context_line":"                                 \u0027will be removed in a future release.\u0027,"},{"line_number":135,"context_line":"               help\u003d\"Full URI of the OpenStack Identity API (Keystone), v2\"),"},{"line_number":136,"context_line":"    cfg.URIOpt(\u0027uri_v3\u0027,"},{"line_number":137,"context_line":"               schemes\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":138,"context_line":"               help\u003d\u0027Full URI of the OpenStack Identity API (Keystone), v3\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027auth_version\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"44f76472_6b7f3c7a","line":136,"in_reply_to":"18e91264_ae0daca5","updated":"2024-07-08 17:29:05.000000000","message":"yeah, we could have used uri but there are a more of such v3 specific options example v3_endpoint_type and not sure if it is worth to rename/make general. I am ok to keep them as it is.","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"95082b5754c50c8340b9868cf8d6a8237d0a5256","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                                 \u0027Queens release. Options for the v2.0 API \u0027"},{"line_number":134,"context_line":"                                 \u0027will be removed in a future release.\u0027,"},{"line_number":135,"context_line":"               help\u003d\"Full URI of the OpenStack Identity API (Keystone), v2\"),"},{"line_number":136,"context_line":"    cfg.URIOpt(\u0027uri_v3\u0027,"},{"line_number":137,"context_line":"               schemes\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":138,"context_line":"               help\u003d\u0027Full URI of the OpenStack Identity API (Keystone), v3\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027auth_version\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"4b2e4894_d59253a2","line":136,"in_reply_to":"44f76472_6b7f3c7a","updated":"2024-07-09 05:09:23.000000000","message":"Acknowledged","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"49180e356b9864649402518fdb2ba3b3285dd0bc","unresolved":true,"context_lines":[{"line_number":133,"context_line":"                                 \u0027Queens release. Options for the v2.0 API \u0027"},{"line_number":134,"context_line":"                                 \u0027will be removed in a future release.\u0027,"},{"line_number":135,"context_line":"               help\u003d\"Full URI of the OpenStack Identity API (Keystone), v2\"),"},{"line_number":136,"context_line":"    cfg.URIOpt(\u0027uri_v3\u0027,"},{"line_number":137,"context_line":"               schemes\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":138,"context_line":"               help\u003d\u0027Full URI of the OpenStack Identity API (Keystone), v3\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027auth_version\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"18e91264_ae0daca5","line":136,"in_reply_to":"dd9bfe6b_8d0fc20e","updated":"2024-07-08 12:57:29.000000000","message":"I decided to keep uri_v3 because this parameter was required to run identity v3 API tests and requiring people to switch back to uri option requires more effort.\n\nhttps://github.com/openstack/tempest/blob/8e7232b74003879c165d176a03f64052706055ec/tempest/clients.py#L268-L270","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a348bb855a004dc26ede65bbcd0774cc0177c98d","unresolved":true,"context_lines":[{"line_number":136,"context_line":"    cfg.URIOpt(\u0027uri_v3\u0027,"},{"line_number":137,"context_line":"               schemes\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":138,"context_line":"               help\u003d\u0027Full URI of the OpenStack Identity API (Keystone), v3\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027auth_version\u0027,"},{"line_number":140,"context_line":"               default\u003d\u0027v3\u0027,"},{"line_number":141,"context_line":"               help\u003d\"Identity API version to be used for authentication \""},{"line_number":142,"context_line":"                    \"for API tests.\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3e3268da_a854fc60","line":139,"updated":"2024-07-08 12:21:26.000000000","message":"This option could be deprecated as well?","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"49180e356b9864649402518fdb2ba3b3285dd0bc","unresolved":true,"context_lines":[{"line_number":136,"context_line":"    cfg.URIOpt(\u0027uri_v3\u0027,"},{"line_number":137,"context_line":"               schemes\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":138,"context_line":"               help\u003d\u0027Full URI of the OpenStack Identity API (Keystone), v3\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027auth_version\u0027,"},{"line_number":140,"context_line":"               default\u003d\u0027v3\u0027,"},{"line_number":141,"context_line":"               help\u003d\"Identity API version to be used for authentication \""},{"line_number":142,"context_line":"                    \"for API tests.\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"bd8a1af6_981ce386","line":139,"in_reply_to":"3e3268da_a854fc60","updated":"2024-07-08 12:57:29.000000000","message":"Technically we can deprecate this and the api_v3 option below. I just followed the fact that api_v2 for glance is kept.\nI have no strong preference here so If others prefer actively deprecating useless but \"generic\" options then I\u0027ll update the change to cover deprecations.","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dccba6d0789c093364d13821a0b0d17634926fac","unresolved":true,"context_lines":[{"line_number":136,"context_line":"    cfg.URIOpt(\u0027uri_v3\u0027,"},{"line_number":137,"context_line":"               schemes\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":138,"context_line":"               help\u003d\u0027Full URI of the OpenStack Identity API (Keystone), v3\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027auth_version\u0027,"},{"line_number":140,"context_line":"               default\u003d\u0027v3\u0027,"},{"line_number":141,"context_line":"               help\u003d\"Identity API version to be used for authentication \""},{"line_number":142,"context_line":"                    \"for API tests.\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"b221b884_e7fefeee","line":139,"in_reply_to":"62025b9f_0d9e13ac","updated":"2024-07-09 02:27:12.000000000","message":"Or unless we see bunch of deprecations then we can leave the cleanup now and address it when we actually remove this option.","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"daa1711a17c54c94ff444e5dd09a03f40a6b2000","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    cfg.URIOpt(\u0027uri_v3\u0027,"},{"line_number":137,"context_line":"               schemes\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":138,"context_line":"               help\u003d\u0027Full URI of the OpenStack Identity API (Keystone), v3\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027auth_version\u0027,"},{"line_number":140,"context_line":"               default\u003d\u0027v3\u0027,"},{"line_number":141,"context_line":"               help\u003d\"Identity API version to be used for authentication \""},{"line_number":142,"context_line":"                    \"for API tests.\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"93373454_250c5128","line":139,"in_reply_to":"b221b884_e7fefeee","updated":"2024-07-09 03:10:04.000000000","message":"Ignore my comment above. I was confused by the deprecation warnings caused by renamed options. Now we directly deprecate these options so we should not be bothered by such warnings.","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"02d0a9e001e9a4851d4a027272b1ad332f9da36d","unresolved":true,"context_lines":[{"line_number":136,"context_line":"    cfg.URIOpt(\u0027uri_v3\u0027,"},{"line_number":137,"context_line":"               schemes\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":138,"context_line":"               help\u003d\u0027Full URI of the OpenStack Identity API (Keystone), v3\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027auth_version\u0027,"},{"line_number":140,"context_line":"               default\u003d\u0027v3\u0027,"},{"line_number":141,"context_line":"               help\u003d\"Identity API version to be used for authentication \""},{"line_number":142,"context_line":"                    \"for API tests.\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"62025b9f_0d9e13ac","line":139,"in_reply_to":"bd8a1af6_981ce386","updated":"2024-07-09 02:26:09.000000000","message":"It turned out deprecating this option needs much more cleanup because of multiple references... I\u0027ll try to update the patch to address this but it may take some more time.","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a348bb855a004dc26ede65bbcd0774cc0177c98d","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                help\u003d\"Is the v2 identity admin API available?\"),"},{"line_number":253,"context_line":"    cfg.BoolOpt(\u0027api_v3\u0027,"},{"line_number":254,"context_line":"                default\u003dTrue,"},{"line_number":255,"context_line":"                help\u003d\u0027Is the v3 identity API enabled\u0027),"},{"line_number":256,"context_line":"    cfg.ListOpt(\u0027api_extensions\u0027,"},{"line_number":257,"context_line":"                default\u003d[\u0027all\u0027],"},{"line_number":258,"context_line":"                help\u003d\"A list of enabled identity extensions with a special \""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa319ad1_aa43c503","line":255,"updated":"2024-07-08 12:21:26.000000000","message":"Is there a reason to keep this flag? Are there any tests that work without any identity API? I\u0027d assume no, so this flag could also be deprecated and made to have no effect.","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dccba6d0789c093364d13821a0b0d17634926fac","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                help\u003d\"Is the v2 identity admin API available?\"),"},{"line_number":253,"context_line":"    cfg.BoolOpt(\u0027api_v3\u0027,"},{"line_number":254,"context_line":"                default\u003dTrue,"},{"line_number":255,"context_line":"                help\u003d\u0027Is the v3 identity API enabled\u0027),"},{"line_number":256,"context_line":"    cfg.ListOpt(\u0027api_extensions\u0027,"},{"line_number":257,"context_line":"                default\u003d[\u0027all\u0027],"},{"line_number":258,"context_line":"                help\u003d\"A list of enabled identity extensions with a special \""}],"source_content_type":"text/x-python","patch_set":5,"id":"7e6a830e_637b2480","line":255,"in_reply_to":"0fc94847_dbe44dbd","updated":"2024-07-09 02:27:12.000000000","message":"Done","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1913d3286ca51988e4f668bdad5bea37746c83e4","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                help\u003d\"Is the v2 identity admin API available?\"),"},{"line_number":253,"context_line":"    cfg.BoolOpt(\u0027api_v3\u0027,"},{"line_number":254,"context_line":"                default\u003dTrue,"},{"line_number":255,"context_line":"                help\u003d\u0027Is the v3 identity API enabled\u0027),"},{"line_number":256,"context_line":"    cfg.ListOpt(\u0027api_extensions\u0027,"},{"line_number":257,"context_line":"                default\u003d[\u0027all\u0027],"},{"line_number":258,"context_line":"                help\u003d\"A list of enabled identity extensions with a special \""}],"source_content_type":"text/x-python","patch_set":5,"id":"0fc94847_dbe44dbd","line":255,"in_reply_to":"fa319ad1_aa43c503","updated":"2024-07-08 17:29:05.000000000","message":"++, let\u0027s drop it also as this config does not make any difference.","commit_id":"2ea5ef77fc66ef4ffb868fc354112fe4c2fc35bf"}]}