)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"faa931f802cfdd9c318ce517faee4d11718e1faa","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enforce minimum value for volume (extend) size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume size shouldn\u0027t be 0 or a negative value. Also, cinder does not"},{"line_number":10,"context_line":"support shrinking volumes so extend should be apparently a positive"},{"line_number":11,"context_line":"value."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b3ad0752_14f3058e","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":27},"updated":"2024-01-25 03:46:40.000000000","message":"I think volume size is allowed as null. that is what i see from code\n\n- https://github.com/openstack/cinder/blob/2a18843ab928ad104ac9b535f28fe1eea5c1a5c7/cinder/api/schemas/volumes.py#L50C41-L50C64\n- https://github.com/openstack/cinder/blob/2a18843ab928ad104ac9b535f28fe1eea5c1a5c7/cinder/api/validation/parameter_types.py#L227","commit_id":"db8413c4dce897a61abf17d232681a0ac0958b69"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f206c0da2233799d0a8374a6d9e7f4f0902c232d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enforce minimum value for volume (extend) size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume size shouldn\u0027t be 0 or a negative value. Also, cinder does not"},{"line_number":10,"context_line":"support shrinking volumes so extend should be apparently a positive"},{"line_number":11,"context_line":"value."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8a8f8414_fec39d87","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":27},"in_reply_to":"3d072f6f_c4efd34c","updated":"2024-11-04 06:27:59.000000000","message":"I tested volume creation with size: null and without size and both failed with 400 error.\n\n```\n[vagrant@localhost ~]$ curl -g -i -X POST http://127.0.0.1:8776/v3/volumes -H \"Accept: application/json\" -H \"Content-Type: application/json\" -H \"User-Agent: python-cinderclient\" -H \u0027X-Auth-Token: gAAAAABnKGjaA3LbpmdVa2DM3WpDx6nBxbxNj5rwXvikXrK4Hcf-A6tG8mymEvjh0s17akIN7nIvOx0-Mh_-qWUKAlB9InUEa-0iTGfcoQcrnkVXrzAI-wqmqG8DZS3BCBkYudX4SmNHQVLSH5fahlXDEYSbbsCmuyTFpRqF2EVklgZWnhYX7fo\u0027 -d \u0027{\"volume\": {\"size\": null, \"consistencygroup_id\": null, \"snapshot_id\": null, \"name\": \"test\", \"description\": null, \"volume_type\": null, \"availability_zone\": null, \"metadata\": {}, \"imageRef\": null, \"source_volid\": null, \"backup_id\": null}}\u0027\nHTTP/1.1 400 Bad Request\nDate: Mon, 04 Nov 2024 06:26:09 GMT\nServer: Apache\nContent-Length: 141\nOpenStack-API-Version: volume 3.0\nVary: OpenStack-API-Version\nx-compute-request-id: req-f409db2b-5899-4373-8e3a-e29bb746dfe7\nx-openstack-request-id: req-f409db2b-5899-4373-8e3a-e29bb746dfe7\nConnection: close\nContent-Type: application/json\n\n{\"badRequest\": {\"code\": 400, \"message\": \"The server could not comply with the request since it is either malformed or otherwise incorrect.\"}}[vagrant@localhost ~]$ curl -g -i -X POST http://127.0.0.1:8776/v3/volumes -H \"Accept: application/json\" -H \"Content-Type: application/json\" -H \"User-Agent: python-cinderclient\" -H \u0027X-Auth-Token: gAAAAABnKGjaA3LbpmdVa2DM3WpDx6nBxbxNj5rwXvikXrK4Hcf-A6tG8mymEvjh0s17akIN7nIvOx0-Mh_-qWUKAlB9InUEa-0iTGfcoQcrnkVXrzAI-wqmqG8DZS3BCBkYudX4SmNHQVLSH5fahlXDEYSbbsCmuyTFpRqF2EVklgZWnhYX7fo\u0027 -d \u0027{\"volume\": {\"consistencygroup_id\": null, \"snapshot_id\": null, \"name\": \"test\", \"description\": null, \"volume_type\": null, \"availability_zone\": null, \"metadata\": {}, \"imageRef\": null, \"source_volid\": null, \"backup_id\": null}}\u0027\nHTTP/1.1 400 Bad Request\nDate: Mon, 04 Nov 2024 06:26:26 GMT\nServer: Apache\nContent-Length: 141\nOpenStack-API-Version: volume 3.0\nVary: OpenStack-API-Version\nx-compute-request-id: req-001f31d4-3c7a-40d3-9eae-6719da4737b1\nx-openstack-request-id: req-001f31d4-3c7a-40d3-9eae-6719da4737b1\nConnection: close\nContent-Type: application/json\n\n{\"badRequest\": {\"code\": 400, \"message\": \"The server could not comply with the request since it is either malformed or otherwise incorrect.\"}}\n```","commit_id":"db8413c4dce897a61abf17d232681a0ac0958b69"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"114e57f0514ebae6cdc23c0f39c961c6bf58f401","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enforce minimum value for volume (extend) size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume size shouldn\u0027t be 0 or a negative value. Also, cinder does not"},{"line_number":10,"context_line":"support shrinking volumes so extend should be apparently a positive"},{"line_number":11,"context_line":"value."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"775fbec8_62076e73","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":27},"in_reply_to":"8a8f8414_fec39d87","updated":"2026-01-15 19:31:02.000000000","message":"Yeah, it can be present in request as None for cases like creatino of volume from snapshot but passing 0 is not valid for any case. I agree. thanks for testing it.","commit_id":"db8413c4dce897a61abf17d232681a0ac0958b69"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"083054b17f4dc74dedcc3256e19ce1ec7cb943ad","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enforce minimum value for volume (extend) size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume size shouldn\u0027t be 0 or a negative value. Also, cinder does not"},{"line_number":10,"context_line":"support shrinking volumes so extend should be apparently a positive"},{"line_number":11,"context_line":"value."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3d072f6f_c4efd34c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":27},"in_reply_to":"af75d14f_2d2691c3","updated":"2024-11-03 20:05:01.000000000","message":"https://github.com/openstack/cinder/blob/c4bedc1de1d8dd0a00abb6f036fa8add0e72f437/cinder/volume/api.py#L251-L255","commit_id":"db8413c4dce897a61abf17d232681a0ac0958b69"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bac8bdd41dbf5d49f84a02cb6f6ae26c94e46ff2","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enforce minimum value for volume (extend) size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume size shouldn\u0027t be 0 or a negative value. Also, cinder does not"},{"line_number":10,"context_line":"support shrinking volumes so extend should be apparently a positive"},{"line_number":11,"context_line":"value."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"af75d14f_2d2691c3","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":27},"in_reply_to":"b3ad0752_14f3058e","updated":"2024-11-03 20:03:25.000000000","message":"IIUC, size is defined as optional because it is not required when a volume is created from snapshot/volume/backup but it\u0027s required when creating an empty volume or one from image.","commit_id":"db8413c4dce897a61abf17d232681a0ac0958b69"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"faa931f802cfdd9c318ce517faee4d11718e1faa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d5ddd5e_e728d1bb","updated":"2024-01-25 03:46:40.000000000","message":"Adding cinder folks to confirm this.","commit_id":"db8413c4dce897a61abf17d232681a0ac0958b69"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9d217cc7419196c16b8236a4be4f7311638236a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a4f91e69_4504df21","updated":"2024-01-20 07:06:42.000000000","message":"recheck unrelated failure","commit_id":"db8413c4dce897a61abf17d232681a0ac0958b69"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"797f8d89d425cef5b5ba05a6330a8ebe1a84f9ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"02358000_95a08fa1","updated":"2026-01-17 17:14:57.000000000","message":"recheck post failure","commit_id":"a06cf36f3979709ab708a0cd4af307d571cac801"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"225a33863da9f911a9ffb884609a77e4261a3e43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4bf3174e_685fbaa8","updated":"2026-01-16 02:29:38.000000000","message":"recheck post failure","commit_id":"a06cf36f3979709ab708a0cd4af307d571cac801"}]}
