)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6e3b59f1b8fffed6a0443fc07db24590f732f309","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"109472d9_d41cf16a","updated":"2024-01-25 03:22:11.000000000","message":"Test deletion are not corrent but config option cleanup is ok.","commit_id":"fbb58011f954d77857a18b46a3cb40f0bbd2c8e9"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"85df341ed56e01b8acb3d0787a0665064c87b451","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"66c46031_e67cf950","updated":"2024-01-23 10:34:18.000000000","message":"lgtm, the api is not used anywhere - https://codesearch.opendev.org/?q\u003dxenapi_apis\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d plus the opt been marked for removal for more than 3 years - https://review.opendev.org/c/openstack/tempest/+/749527","commit_id":"fbb58011f954d77857a18b46a3cb40f0bbd2c8e9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4b31692b480ac7ecfef5497f2cf72274bdff9473","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4f528d9f_121d06b0","updated":"2024-01-20 14:39:21.000000000","message":"recheck the failure is unrelated","commit_id":"fbb58011f954d77857a18b46a3cb40f0bbd2c8e9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"13ece1d86ef3bddf4c96b75858f47c13c0ed44c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9ee4a3f_3287ab52","in_reply_to":"109472d9_d41cf16a","updated":"2024-01-25 16:51:49.000000000","message":"I can try fix missing test coverage, but please be aware that these tests have never been executed unless xen driver is used. So this change itself does not remove tests, but just cleans up tests unused.","commit_id":"fbb58011f954d77857a18b46a3cb40f0bbd2c8e9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bbc37e84ffb61a21fb26fc73cc902fa88a43e85c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d82e9924_f860c754","in_reply_to":"a9ee4a3f_3287ab52","updated":"2024-01-31 05:06:51.000000000","message":"yeah, I do not know why we did not executed them. I am also confused that nova API exist means but I think by mistake we skipped the test for xenapi. maybe you can remove the xenapi config checks and see if all work fine for libvirt.","commit_id":"fbb58011f954d77857a18b46a3cb40f0bbd2c8e9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d628f8f3f5e085a13f4554e972107d781f203cd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"64fb2515_3c69509d","in_reply_to":"d82e9924_f860c754","updated":"2024-02-07 14:05:14.000000000","message":"I\u0027ve restored some API tests according to the current availability. Please check the latest version and let me know in case there are still any tests I misunderstood.","commit_id":"fbb58011f954d77857a18b46a3cb40f0bbd2c8e9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e154ec18035e723273d62070bedcb09405d3b552","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f99c3552_0e77ada9","updated":"2024-03-29 18:14:16.000000000","message":"Thanks for update, all looks good just one comment","commit_id":"81e06af991230a86ff7254e497a6e57885318f0a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b39eb48481d7f3bb01140dadc28f0bafc15f8082","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bbfad249_fcdebe6f","updated":"2024-04-01 20:59:56.000000000","message":"lgtm","commit_id":"ea0bafde654951faa221fc9b18b7293b127c21ec"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"040c9fa64868b685da08f1c73b70c8ca680b0dfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"528b7f94_fa5b2533","updated":"2024-05-03 18:47:54.000000000","message":"thanks Takashi for update. lgtm","commit_id":"ea0bafde654951faa221fc9b18b7293b127c21ec"}],"tempest/api/compute/admin/test_agents.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6e3b59f1b8fffed6a0443fc07db24590f732f309","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# TODO(stephenfin): Remove these tests once the nova Ussuri branch goes EOL"},{"line_number":24,"context_line":"class AgentsAdminTestJSON(base.BaseV2ComputeAdminTest):"},{"line_number":25,"context_line":"    \"\"\"Tests Compute Agents API\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"592f1bda_a6959cf1","side":"PARENT","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":34},"updated":"2024-01-25 03:22:11.000000000","message":"Compute Agent API was only specific to XenAPI virt driver to test deletion is ok.","commit_id":"2921b3d3f46bdcf5b0a2c71bb9a2da5d7a2e0757"}],"tempest/api/compute/admin/test_servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6e3b59f1b8fffed6a0443fc07db24590f732f309","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        rebuilt_image_id \u003d server[\u0027image\u0027][\u0027id\u0027]"},{"line_number":207,"context_line":"        self.assertEqual(self.image_ref_alt, rebuilt_image_id)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u00277a1323b4-a6a2-497a-96cb-76c07b945c71\u0027)"},{"line_number":210,"context_line":"    def test_reset_network_inject_network_info(self):"},{"line_number":211,"context_line":"        \"\"\"Test resetting and injecting network info of a server\"\"\""},{"line_number":212,"context_line":"        if not CONF.compute_feature_enabled.xenapi_apis:"},{"line_number":213,"context_line":"            raise self.skipException("},{"line_number":214,"context_line":"                \u0027The resetNetwork server action is not supported.\u0027)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        # Reset Network of a Server"},{"line_number":217,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":218,"context_line":"        self.client.reset_network(server[\u0027id\u0027])"},{"line_number":219,"context_line":"        # Inject the Network Info into Server"},{"line_number":220,"context_line":"        self.client.inject_network_info(server[\u0027id\u0027])"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @decorators.idempotent_id(\u0027fdcd9b33-0903-4e00-a1f7-b5f6543068d6\u0027)"},{"line_number":223,"context_line":"    def test_create_server_with_scheduling_hint(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d3462cb8_9deb5bdf","side":"PARENT","line":220,"range":{"start_line":209,"start_character":0,"end_line":220,"end_character":53},"updated":"2024-01-25 03:22:11.000000000","message":"this test is still valid, only reset network API was xenapi specific but not inject network info. we should continue testing the later part and instead rename the test to test_inject_network_info","commit_id":"2921b3d3f46bdcf5b0a2c71bb9a2da5d7a2e0757"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5ff5c9193f82d214837bd11a77fa0c809a99b86b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        rebuilt_image_id \u003d server[\u0027image\u0027][\u0027id\u0027]"},{"line_number":207,"context_line":"        self.assertEqual(self.image_ref_alt, rebuilt_image_id)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u00277a1323b4-a6a2-497a-96cb-76c07b945c71\u0027)"},{"line_number":210,"context_line":"    def test_reset_network_inject_network_info(self):"},{"line_number":211,"context_line":"        \"\"\"Test resetting and injecting network info of a server\"\"\""},{"line_number":212,"context_line":"        if not CONF.compute_feature_enabled.xenapi_apis:"},{"line_number":213,"context_line":"            raise self.skipException("},{"line_number":214,"context_line":"                \u0027The resetNetwork server action is not supported.\u0027)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        # Reset Network of a Server"},{"line_number":217,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":218,"context_line":"        self.client.reset_network(server[\u0027id\u0027])"},{"line_number":219,"context_line":"        # Inject the Network Info into Server"},{"line_number":220,"context_line":"        self.client.inject_network_info(server[\u0027id\u0027])"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @decorators.idempotent_id(\u0027fdcd9b33-0903-4e00-a1f7-b5f6543068d6\u0027)"},{"line_number":223,"context_line":"    def test_create_server_with_scheduling_hint(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"33b5c266_3a5c0e03","side":"PARENT","line":220,"range":{"start_line":209,"start_character":0,"end_line":220,"end_character":53},"in_reply_to":"d3462cb8_9deb5bdf","updated":"2024-02-05 02:02:51.000000000","message":"Done","commit_id":"2921b3d3f46bdcf5b0a2c71bb9a2da5d7a2e0757"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e154ec18035e723273d62070bedcb09405d3b552","unresolved":true,"context_lines":[{"line_number":211,"context_line":"        \"\"\"Test resetting and injecting network info of a server\"\"\""},{"line_number":212,"context_line":"        # Reset Network of a Server"},{"line_number":213,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":214,"context_line":"        self.assertRaises(lib_exc.Gone, self.client.reset_network,"},{"line_number":215,"context_line":"                          server[\u0027id\u0027])"},{"line_number":216,"context_line":"        # Inject the Network Info into Server"},{"line_number":217,"context_line":"        self.client.inject_network_info(server[\u0027id\u0027])"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"15a9f385_cd7806af","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":39},"updated":"2024-03-29 18:14:16.000000000","message":"as you have renamed the test also, let\u0027s not check for reset_network API. the reset_network 410 is tested at Nova side so tempest does not need to test it explicitly.","commit_id":"81e06af991230a86ff7254e497a6e57885318f0a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"70cb665e333c0eeb329f328e48c6ab5b932faa05","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        \"\"\"Test resetting and injecting network info of a server\"\"\""},{"line_number":212,"context_line":"        # Reset Network of a Server"},{"line_number":213,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":214,"context_line":"        self.assertRaises(lib_exc.Gone, self.client.reset_network,"},{"line_number":215,"context_line":"                          server[\u0027id\u0027])"},{"line_number":216,"context_line":"        # Inject the Network Info into Server"},{"line_number":217,"context_line":"        self.client.inject_network_info(server[\u0027id\u0027])"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ee9fca23_5efa983f","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":39},"in_reply_to":"15a9f385_cd7806af","updated":"2024-03-30 02:53:12.000000000","message":"+1. Done.","commit_id":"81e06af991230a86ff7254e497a6e57885318f0a"}],"tempest/api/compute/servers/test_server_metadata.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6e3b59f1b8fffed6a0443fc07db24590f732f309","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# TODO(stephenfin): Remove these tests once the nova Ussuri branch goes EOL"},{"line_number":24,"context_line":"class ServerMetadataTestJSON(base.BaseV2ComputeTest):"},{"line_number":25,"context_line":"    \"\"\"Test server metadata\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    create_default_network \u003d True"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"86c8e50c_be2a6bca","side":"PARENT","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":30},"updated":"2024-01-25 03:22:11.000000000","message":"Server metadata API is not gone and it is still valid, we should not delete its tests - https://docs.openstack.org/api-ref/compute/#server-metadata-servers-metadata","commit_id":"2921b3d3f46bdcf5b0a2c71bb9a2da5d7a2e0757"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5ff5c9193f82d214837bd11a77fa0c809a99b86b","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# TODO(stephenfin): Remove these tests once the nova Ussuri branch goes EOL"},{"line_number":24,"context_line":"class ServerMetadataTestJSON(base.BaseV2ComputeTest):"},{"line_number":25,"context_line":"    \"\"\"Test server metadata\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    create_default_network \u003d True"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4b3f6882_f7572241","side":"PARENT","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":30},"in_reply_to":"86c8e50c_be2a6bca","updated":"2024-02-05 02:02:51.000000000","message":"Done","commit_id":"2921b3d3f46bdcf5b0a2c71bb9a2da5d7a2e0757"}],"tempest/api/compute/servers/test_server_metadata_negative.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6e3b59f1b8fffed6a0443fc07db24590f732f309","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ServerMetadataNegativeTestJSON(base.BaseV2ComputeTest):"},{"line_number":26,"context_line":"    \"\"\"Negative tests of server metadata\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    create_default_network \u003d True"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1081647e_ec902319","side":"PARENT","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":43},"updated":"2024-01-25 03:22:11.000000000","message":"ditto, this API still exist - https://docs.openstack.org/api-ref/compute/#server-metadata-servers-metadata","commit_id":"2921b3d3f46bdcf5b0a2c71bb9a2da5d7a2e0757"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5ff5c9193f82d214837bd11a77fa0c809a99b86b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ServerMetadataNegativeTestJSON(base.BaseV2ComputeTest):"},{"line_number":26,"context_line":"    \"\"\"Negative tests of server metadata\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    create_default_network \u003d True"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6b68c3eb_d6008143","side":"PARENT","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":43},"in_reply_to":"1081647e_ec902319","updated":"2024-02-05 02:02:51.000000000","message":"Done","commit_id":"2921b3d3f46bdcf5b0a2c71bb9a2da5d7a2e0757"}]}