)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"81ec0af16ed0da17eedabb84de293dca7425806e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e75f0a7d_ee945f76","updated":"2024-03-30 07:18:44.000000000","message":"@Abhishek @Brian @Cyril @Pranali I wonder if I can ask your thoughts on the proposed change.","commit_id":"e37fbf01204352b2289fc3b8be6ef288570e8048"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"963f2457563b062f001aaf083ec3d213e35e334e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dca3dfc9_b8ad848b","updated":"2024-04-12 14:04:38.000000000","message":"Makes sense to deprecate and remove these config options.","commit_id":"e37fbf01204352b2289fc3b8be6ef288570e8048"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"eee43c6aaf9f266c70884841118e6984ad7d81ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f883dbce_543bb116","updated":"2024-01-24 05:00:39.000000000","message":"recheck unrelated","commit_id":"e37fbf01204352b2289fc3b8be6ef288570e8048"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"fba79b8e36cc51a26e0cd8c0ddb92b21cdce873a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"24237dd9_04d7c237","updated":"2024-04-12 15:08:49.000000000","message":"It seems uncontroversial enough (pending more vote from glance people)","commit_id":"9fcc4a3ffb5822ff908bda1e3e81e4455aa326cb"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"39b6f3599118db7f0bb2a67199b3763f8503cbde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fe0ef660_5650cc4a","updated":"2024-04-24 07:14:26.000000000","message":"lgtm, thanks for the patch and all the reviews","commit_id":"9fcc4a3ffb5822ff908bda1e3e81e4455aa326cb"}],"tempest/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ade2505cf12c6267458f82b981e0e5a46ab88fa7","unresolved":true,"context_lines":[{"line_number":698,"context_line":"                                  \u0027are current one. In future, Tempest will \u0027"},{"line_number":699,"context_line":"                                  \u0027test v2 APIs only so this config option \u0027"},{"line_number":700,"context_line":"                                  \u0027will be removed.\u0027),"},{"line_number":701,"context_line":"    # Image import feature is setup in devstack victoria onwards."},{"line_number":702,"context_line":"    # Once all stable branches setup the same via glance standalone"},{"line_number":703,"context_line":"    # mode or with uwsgi, we can remove this config option."},{"line_number":704,"context_line":"    cfg.BoolOpt(\u0027import_image\u0027,"},{"line_number":705,"context_line":"                default\u003dFalse,"},{"line_number":706,"context_line":"                help\u003d\"Is image import feature enabled\"),"},{"line_number":707,"context_line":"    # NOTE(danms): Starting mid-Wallaby glance began enforcing the"},{"line_number":708,"context_line":"    # previously-informal requirement that os_glance_* properties are"},{"line_number":709,"context_line":"    # reserved for internal use. Thus, we can only run these checks"},{"line_number":710,"context_line":"    # if we know we are on a new enough glance."},{"line_number":711,"context_line":"    cfg.BoolOpt(\u0027os_glance_reserved\u0027,"},{"line_number":712,"context_line":"                default\u003dFalse,"},{"line_number":713,"context_line":"                help\u003d\"Should we check that os_glance namespace is reserved\"),"},{"line_number":714,"context_line":"    cfg.BoolOpt(\u0027manage_locations\u0027,"},{"line_number":715,"context_line":"                default\u003dFalse,"},{"line_number":716,"context_line":"                help\u003d(\u0027Is show_multiple_locations enabled in glance. \u0027"},{"line_number":717,"context_line":"                      \u0027Note that at least one http store must be enabled as \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"0aa5b323_c6a6491d","side":"PARENT","line":714,"range":{"start_line":701,"start_character":0,"end_line":714,"end_character":0},"updated":"2024-01-25 03:37:56.000000000","message":"they are setup in devstack side but tempest can be run in non-devstack env also. we should remove them only if glance has enabled them by default and no config option corresponded to these in glance.","commit_id":"1da7a33099e0a06e4cca3b4a8e6c9d7874426df6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"026237fbac54751e0f2b24cce599223845e2f4f4","unresolved":true,"context_lines":[{"line_number":698,"context_line":"                                  \u0027are current one. In future, Tempest will \u0027"},{"line_number":699,"context_line":"                                  \u0027test v2 APIs only so this config option \u0027"},{"line_number":700,"context_line":"                                  \u0027will be removed.\u0027),"},{"line_number":701,"context_line":"    # Image import feature is setup in devstack victoria onwards."},{"line_number":702,"context_line":"    # Once all stable branches setup the same via glance standalone"},{"line_number":703,"context_line":"    # mode or with uwsgi, we can remove this config option."},{"line_number":704,"context_line":"    cfg.BoolOpt(\u0027import_image\u0027,"},{"line_number":705,"context_line":"                default\u003dFalse,"},{"line_number":706,"context_line":"                help\u003d\"Is image import feature enabled\"),"},{"line_number":707,"context_line":"    # NOTE(danms): Starting mid-Wallaby glance began enforcing the"},{"line_number":708,"context_line":"    # previously-informal requirement that os_glance_* properties are"},{"line_number":709,"context_line":"    # reserved for internal use. Thus, we can only run these checks"},{"line_number":710,"context_line":"    # if we know we are on a new enough glance."},{"line_number":711,"context_line":"    cfg.BoolOpt(\u0027os_glance_reserved\u0027,"},{"line_number":712,"context_line":"                default\u003dFalse,"},{"line_number":713,"context_line":"                help\u003d\"Should we check that os_glance namespace is reserved\"),"},{"line_number":714,"context_line":"    cfg.BoolOpt(\u0027manage_locations\u0027,"},{"line_number":715,"context_line":"                default\u003dFalse,"},{"line_number":716,"context_line":"                help\u003d(\u0027Is show_multiple_locations enabled in glance. \u0027"},{"line_number":717,"context_line":"                      \u0027Note that at least one http store must be enabled as \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"810b8837_c27dc8bf","side":"PARENT","line":714,"range":{"start_line":701,"start_character":0,"end_line":714,"end_character":0},"in_reply_to":"0aa5b323_c6a6491d","updated":"2024-01-25 07:54:09.000000000","message":"For image_import\n\nEven when this option is set to True, tempest checks if the required import plugin is enabled[1][2]. So enabling this does not immediately enable image import tests, and we have that different mechanism to deal with the case image import is not configured.\n\n[1] https://github.com/openstack/tempest/blob/566ac3faa3eacaa2da6b5d9efd12a847607156cf/tempest/api/image/v2/test_images.py#L47-L51\n[2] https://github.com/openstack/tempest/blob/566ac3faa3eacaa2da6b5d9efd12a847607156cf/tempest/lib/services/image/v2/images_client.py#L191-L198\n\nIIUC this option was added to disable image import tests when glance-api is run by uwsgi, because of the known old problem with async thread to process import, but it should have been fixed in recent releases.\n\n\nFor os_glance_reserved\n\nThe os_glance_ namespace is always reserved and is not configurable.","commit_id":"1da7a33099e0a06e4cca3b4a8e6c9d7874426df6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ea4f0a9966c01e646038483a34d57f3d8c8f4fe7","unresolved":false,"context_lines":[{"line_number":698,"context_line":"                                  \u0027are current one. In future, Tempest will \u0027"},{"line_number":699,"context_line":"                                  \u0027test v2 APIs only so this config option \u0027"},{"line_number":700,"context_line":"                                  \u0027will be removed.\u0027),"},{"line_number":701,"context_line":"    # Image import feature is setup in devstack victoria onwards."},{"line_number":702,"context_line":"    # Once all stable branches setup the same via glance standalone"},{"line_number":703,"context_line":"    # mode or with uwsgi, we can remove this config option."},{"line_number":704,"context_line":"    cfg.BoolOpt(\u0027import_image\u0027,"},{"line_number":705,"context_line":"                default\u003dFalse,"},{"line_number":706,"context_line":"                help\u003d\"Is image import feature enabled\"),"},{"line_number":707,"context_line":"    # NOTE(danms): Starting mid-Wallaby glance began enforcing the"},{"line_number":708,"context_line":"    # previously-informal requirement that os_glance_* properties are"},{"line_number":709,"context_line":"    # reserved for internal use. Thus, we can only run these checks"},{"line_number":710,"context_line":"    # if we know we are on a new enough glance."},{"line_number":711,"context_line":"    cfg.BoolOpt(\u0027os_glance_reserved\u0027,"},{"line_number":712,"context_line":"                default\u003dFalse,"},{"line_number":713,"context_line":"                help\u003d\"Should we check that os_glance namespace is reserved\"),"},{"line_number":714,"context_line":"    cfg.BoolOpt(\u0027manage_locations\u0027,"},{"line_number":715,"context_line":"                default\u003dFalse,"},{"line_number":716,"context_line":"                help\u003d(\u0027Is show_multiple_locations enabled in glance. \u0027"},{"line_number":717,"context_line":"                      \u0027Note that at least one http store must be enabled as \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"6ca8ab8c_476a7294","side":"PARENT","line":714,"range":{"start_line":701,"start_character":0,"end_line":714,"end_character":0},"in_reply_to":"810b8837_c27dc8bf","updated":"2024-04-12 15:07:41.000000000","message":"I\u0027ll split the image_import part to a separate patch. Let\u0027s continue discussion there.","commit_id":"1da7a33099e0a06e4cca3b4a8e6c9d7874426df6"}]}