)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"81d673cd8f3459dd46391c9116211fa71a50d193","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Roman Safronov \u003crsafrono@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-03-21 20:02:13 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add option to spawn a vm on specific host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This option allows to specify a target host for a server to run."},{"line_number":10,"context_line":"This functionality is useful for advanced network routing"},{"line_number":11,"context_line":"tests on multinode environments, where routers and servers are"},{"line_number":12,"context_line":"required to be hosted on different hosts."},{"line_number":13,"context_line":"Note, Nova API supports the \u0027host\u0027 option starting from version 2.74"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I45acd33b96c39d9b4f4ffbd502694030a2bac6d2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b0810b19_40790670","line":13,"range":{"start_line":7,"start_character":0,"end_line":13,"end_character":68},"updated":"2024-03-24 19:04:12.000000000","message":"I recall I needed the same \u0027host\u0027 capability and almost added microversion support to our downstream plugin (which affects all tests and I preferred to avoid), but I had an alternative, same affect can be achieved by using samehostfilter [1] and differenthostfilter [2].\n\n[1] https://docs.openstack.org/nova/wallaby/admin/configuration/schedulers.html#samehostfilter\n[2] https://docs.openstack.org/nova/wallaby/admin/configuration/schedulers.html#differenthostfilter","commit_id":"533eaa28864fee9ea555675c80516a9150b4471b"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"cca134deb101a44f4f237fdd121879452f4f7214","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Roman Safronov \u003crsafrono@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-03-21 20:02:13 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add option to spawn a vm on specific host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This option allows to specify a target host for a server to run."},{"line_number":10,"context_line":"This functionality is useful for advanced network routing"},{"line_number":11,"context_line":"tests on multinode environments, where routers and servers are"},{"line_number":12,"context_line":"required to be hosted on different hosts."},{"line_number":13,"context_line":"Note, Nova API supports the \u0027host\u0027 option starting from version 2.74"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I45acd33b96c39d9b4f4ffbd502694030a2bac6d2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"58a1e097_2031ad81","line":13,"range":{"start_line":7,"start_character":0,"end_line":13,"end_character":68},"in_reply_to":"b0810b19_40790670","updated":"2024-03-24 20:54:07.000000000","message":"IIRC, same/different host filter requires a VM id as a parameter.  Can you confirm that a router id can be used with different host filter instead of VM id? IIUC nova knows nothing about routers","commit_id":"533eaa28864fee9ea555675c80516a9150b4471b"}],"tempest/lib/services/compute/servers_client.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"5576edf803fb7505c55421cbb7d9dd87e4f87b9b","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        headers \u003d None"},{"line_number":110,"context_line":"        if body.get(\u0027host\u0027):"},{"line_number":111,"context_line":"            headers \u003d {\u0027openstack-api-version\u0027: \u0027compute 2.74\u0027,"},{"line_number":112,"context_line":"                       \u0027x-openstack-nova-api-version\u0027: \u00272.74\u0027}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        post_body \u003d {\u0027server\u0027: body}"}],"source_content_type":"text/x-python","patch_set":1,"id":"d8791b8f_e537945e","line":111,"updated":"2024-03-25 15:09:46.000000000","message":"How does this interact if the test class sets a min_microversion that\u0027s higher than 2.74? Does it just get clobbered? I suspect it is, and the current few cases we have of test classes that declare a higher microversion just happen to work regardless.","commit_id":"533eaa28864fee9ea555675c80516a9150b4471b"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"c5eb22cf4019fe80a22096ccae955667b70d7f0d","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        headers \u003d None"},{"line_number":110,"context_line":"        if body.get(\u0027host\u0027):"},{"line_number":111,"context_line":"            headers \u003d {\u0027openstack-api-version\u0027: \u0027compute 2.74\u0027,"},{"line_number":112,"context_line":"                       \u0027x-openstack-nova-api-version\u0027: \u00272.74\u0027}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        post_body \u003d {\u0027server\u0027: body}"}],"source_content_type":"text/x-python","patch_set":1,"id":"652969c2_ff51de16","line":111,"in_reply_to":"d8791b8f_e537945e","updated":"2024-03-25 18:06:32.000000000","message":"IIUC, there are still no tests that try to use this \u0027host\u0027 option so nothing was affected. Thanks for the help in slack. I managed to make my test work without modifying create_server","commit_id":"533eaa28864fee9ea555675c80516a9150b4471b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"05bb0069dc683905d5657b5df8f83e1814c69745","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        headers \u003d None"},{"line_number":110,"context_line":"        if body.get(\u0027host\u0027):"},{"line_number":111,"context_line":"            headers \u003d {\u0027openstack-api-version\u0027: \u0027compute 2.74\u0027,"},{"line_number":112,"context_line":"                       \u0027x-openstack-nova-api-version\u0027: \u00272.74\u0027}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        post_body \u003d {\u0027server\u0027: body}"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fc214a1d_c3fd5259","line":112,"updated":"2024-03-25 15:05:10.000000000","message":"I think this subverts the existing microversion cointrols per-class and would cause confusion to someone that doesn\u0027t know about this hack. I would suggest just asserting that the microversion in use is appropriate when host is provided, but do not override it silently.","commit_id":"533eaa28864fee9ea555675c80516a9150b4471b"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"c5eb22cf4019fe80a22096ccae955667b70d7f0d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        headers \u003d None"},{"line_number":110,"context_line":"        if body.get(\u0027host\u0027):"},{"line_number":111,"context_line":"            headers \u003d {\u0027openstack-api-version\u0027: \u0027compute 2.74\u0027,"},{"line_number":112,"context_line":"                       \u0027x-openstack-nova-api-version\u0027: \u00272.74\u0027}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        post_body \u003d {\u0027server\u0027: body}"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ddfda4ec_6fc8fcaf","line":112,"in_reply_to":"fc214a1d_c3fd5259","updated":"2024-03-25 18:06:32.000000000","message":"thanks for the clue in slack regarding compute_microversion. I managed to make it work just by specifying the following in my test function:\n        self.useFixture(api_microversion_fixture.APIMicroversionFixture(\n            compute_microversion\u003d\u00272.74\u0027))\nSo there is no need to extend create_server now","commit_id":"533eaa28864fee9ea555675c80516a9150b4471b"}]}