)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8285bdad040dd2397029f8d2c8e45a1f561b772e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a94ce60_f6bfc2c1","updated":"2024-05-08 13:58:47.000000000","message":"Yep, tempest cores, this is the patch that enables testing:\n\nhttps://review.opendev.org/c/openstack/nova/+/918458/4\n\nI could drop the dep from this patch and probably make zuul happy, but it should be moot once the bottom two patches merge.","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"66b89b0c03d04377412bc91f8a6605e48667f608","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32bd49dd_d38ea63e","updated":"2024-05-08 10:36:50.000000000","message":"also zuul is high\n\nthere is not depency cycle \n\nthe tempest patch depend on nova  patch 1 and then nova patch 2 depend on the tempset patch\n\nso there is a linear merge order.\nso we can ignore that.","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"df17fd62ac07de2c57b0ede3b72fa679fb54ec74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0617c58e_8be8fc93","updated":"2024-05-17 18:05:25.000000000","message":"lgtm, test passing https://zuul.opendev.org/t/openstack/build/a9357c341a9447da8e786d382ddcec88/log/job-output.txt#37247-37252","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ba8df1deb199d989dfeccf10928816e365c58e86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ff5a3819_fb7da204","updated":"2024-05-09 17:48:54.000000000","message":"recheck https://review.opendev.org/c/openstack/nova/+/918470/2 is now merged so the depends on is not required","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"51c9d5ca91e6cc9aee732e4bbdd6f4ea018ce3be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a365ade4_99e0a656","updated":"2024-05-17 20:12:47.000000000","message":"thanks","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"}],"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c1c3b5fb863c0cfada8f7654017e7ce1c411a9e1","unresolved":true,"context_lines":[{"line_number":398,"context_line":"        for server in servers:"},{"line_number":399,"context_line":"            waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":400,"context_line":"                                           \u0027ACTIVE\u0027)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        volume \u003d self._create_multiattach_volume()"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        # Attach the volume to the servers"}],"source_content_type":"text/x-python","patch_set":2,"id":"0630c610_3ac4d5b0","line":401,"updated":"2024-05-08 10:35:40.000000000","message":"i noticed this when looking at this file in general yesterday.\n\nthere is actully a race here as this should also be sshable not active.\ne.g. when the attach happens below the server may not be booted to the point it can hanel the attach call. so this test might be flaky as this is one of the places we are not using the sshable workaround.\n\nim not sure if you want to fix that or not just tought i would point it out.","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b44954c9fa7d01ce7b5510fac96daaed723ac10","unresolved":true,"context_lines":[{"line_number":398,"context_line":"        for server in servers:"},{"line_number":399,"context_line":"            waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":400,"context_line":"                                           \u0027ACTIVE\u0027)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        volume \u003d self._create_multiattach_volume()"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        # Attach the volume to the servers"}],"source_content_type":"text/x-python","patch_set":2,"id":"7171abf6_d09bd7ba","line":401,"in_reply_to":"0630c610_3ac4d5b0","updated":"2024-05-08 13:51:33.000000000","message":"Yeah, I guess so. Prefer to keep that separate from this though.","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c1c3b5fb863c0cfada8f7654017e7ce1c411a9e1","unresolved":true,"context_lines":[{"line_number":473,"context_line":"            # but cirros (and other) test images won\u0027t see the device unless"},{"line_number":474,"context_line":"            # they have lsilogic drivers (which is the default). So use this"},{"line_number":475,"context_line":"            # as sort of the indication that the test should be enabled."},{"line_number":476,"context_line":"            self.skip(\u0027hw_scsi_model\u003dvirtio-scsi not set on image\u0027)"},{"line_number":477,"context_line":"        if not CONF.validation.run_validation:"},{"line_number":478,"context_line":"            self.skip(\u0027validation is required for this test\u0027)"},{"line_number":479,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e2228c97_31a2fb39","line":476,"updated":"2024-05-08 10:35:40.000000000","message":"i think we should still look into why this is defaulting to lsilogic\nsince we shoudl be defaulting to virtio-scis in the libvirt dirver but my gues is\nthe way we add the scsi controller when we add one via the bdm does not specify the model and we get libvirts default instead.\n\n\nthat is something we can looking later on the nova side \ni think this is fine for now.","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b44954c9fa7d01ce7b5510fac96daaed723ac10","unresolved":false,"context_lines":[{"line_number":473,"context_line":"            # but cirros (and other) test images won\u0027t see the device unless"},{"line_number":474,"context_line":"            # they have lsilogic drivers (which is the default). So use this"},{"line_number":475,"context_line":"            # as sort of the indication that the test should be enabled."},{"line_number":476,"context_line":"            self.skip(\u0027hw_scsi_model\u003dvirtio-scsi not set on image\u0027)"},{"line_number":477,"context_line":"        if not CONF.validation.run_validation:"},{"line_number":478,"context_line":"            self.skip(\u0027validation is required for this test\u0027)"},{"line_number":479,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"973a4f63_2ace37d8","line":476,"in_reply_to":"e2228c97_31a2fb39","updated":"2024-05-08 13:51:33.000000000","message":"Well, it only works this way now, so we either need to fix it in nova and backport it as far as necessary to keep tempest running, or do this :)\n\nI guess I don\u0027t know if anyone is really using lsilogic (although I can imagine some pets on legacy operating systems might use/need it), but changing the default may be mildly disruptive. Also, the image properties doc says that switching *to* virtio is the only option:\n\nhttps://docs.openstack.org/glance/latest/admin/useful-image-properties.html\n\nSo if we change the default, then there may be no way for someone to opt into the old behavior if we don\u0027t have it implemented, and otherwise would just make that image property pointless.\n\nI\u0027m going to mark this as resolved so we don\u0027t (hopefully) confuse a tempest reviewer that there\u0027s something we\u0027re planning to change before this merges.","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"df17fd62ac07de2c57b0ede3b72fa679fb54ec74","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            # they have lsilogic drivers (which is the default). So use this"},{"line_number":475,"context_line":"            # as sort of the indication that the test should be enabled."},{"line_number":476,"context_line":"            self.skip(\u0027hw_scsi_model\u003dvirtio-scsi not set on image\u0027)"},{"line_number":477,"context_line":"        if not CONF.validation.run_validation:"},{"line_number":478,"context_line":"            self.skip(\u0027validation is required for this test\u0027)"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        validation_resources \u003d self.get_test_validation_resources("},{"line_number":481,"context_line":"            self.os_primary)"}],"source_content_type":"text/x-python","patch_set":2,"id":"113a16d9_b0561b6d","line":478,"range":{"start_line":477,"start_character":0,"end_line":478,"end_character":61},"updated":"2024-05-17 18:05:25.000000000","message":"not related to this change. I think we should run_validation flag and test with validation always. anyways different topic.","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c1c3b5fb863c0cfada8f7654017e7ce1c411a9e1","unresolved":true,"context_lines":[{"line_number":502,"context_line":"        server \u003d self.create_test_server("},{"line_number":503,"context_line":"            validatable\u003dTrue,"},{"line_number":504,"context_line":"            validation_resources\u003dvalidation_resources,"},{"line_number":505,"context_line":"            block_device_mapping_v2\u003dbdm, wait_until\u003d\u0027SSHABLE\u0027)"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        # Assert the volume is attached to the server."},{"line_number":508,"context_line":"        attachments \u003d self.servers_client.list_volume_attachments("}],"source_content_type":"text/x-python","patch_set":2,"id":"1c545159_3569342a","line":505,"updated":"2024-05-08 10:35:40.000000000","message":"+1 for using sshable here.","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b44954c9fa7d01ce7b5510fac96daaed723ac10","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        server \u003d self.create_test_server("},{"line_number":503,"context_line":"            validatable\u003dTrue,"},{"line_number":504,"context_line":"            validation_resources\u003dvalidation_resources,"},{"line_number":505,"context_line":"            block_device_mapping_v2\u003dbdm, wait_until\u003d\u0027SSHABLE\u0027)"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        # Assert the volume is attached to the server."},{"line_number":508,"context_line":"        attachments \u003d self.servers_client.list_volume_attachments("}],"source_content_type":"text/x-python","patch_set":2,"id":"c5f388f4_27c21508","line":505,"in_reply_to":"1c545159_3569342a","updated":"2024-05-08 13:51:33.000000000","message":"Acknowledged","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"}]}