)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"07fe4b477813b374cd4622914765f8dafaa4e2f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a929dea_f9948ca4","updated":"2024-05-09 11:33:43.000000000","message":"check experimental","commit_id":"1e8bf294d8adceb983b092e2fa565e0366000d16"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"26d17c6fb9b6fbbe747648b545fa0a4bf76680cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2ee4aa35_41a4ad84","updated":"2024-05-09 17:50:25.000000000","message":"check experimental","commit_id":"14955d3b2d7bd535d38d3ace35ccac8efed20709"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d98dc9ede60008f78b085292982bfa7655dc7b18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3938a5ba_f1610fd0","updated":"2024-05-09 14:28:34.000000000","message":"check experimental","commit_id":"14955d3b2d7bd535d38d3ace35ccac8efed20709"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f271c959b66b9c8ebf312c2616e1acebb8159370","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e43b3580_e79c87c1","updated":"2024-05-09 17:50:14.000000000","message":"run-tempest role failed and due to that it did not run the cleanup https://zuul.opendev.org/t/openstack/build/6e9c1a036d1d4646a0f311c2d297b759/console\n\n-1 on the default setting missing otherwise lgtm","commit_id":"14955d3b2d7bd535d38d3ace35ccac8efed20709"},{"author":{"_account_id":36227,"name":"Katarina Strenkova","email":"kstrenko@redhat.com","username":"kstrenko"},"change_message_id":"998f4ccb07500786c97b9031a26272594f205487","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"411d539a_e1a9b76d","updated":"2024-05-10 13:33:40.000000000","message":"I have checked why dry_run fails. In function _load_json() in the file tempest/cmd/cleanup.py I have stated that saved_state.json file should be loaded only when self.options.init_saved_state is true, which excludes dry_run option. Now that I\u0027m looking at the code, I am not sure what kind of condition should I turn it into as current condition doesn\u0027t make sense. \n\nSomething like: if not self.options.prefix and not self.options.resource_list? Or does anyone have better suggestion. Thanks in advance.","commit_id":"e88c6ed452ca73c504671204ddfaa34ad6132837"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"dfa11e0b5adefeee96cc6ae69bb6755205bf5e9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a7b9dc6_c1c2969d","updated":"2024-05-10 08:32:42.000000000","message":"check experimental","commit_id":"e88c6ed452ca73c504671204ddfaa34ad6132837"},{"author":{"_account_id":36227,"name":"Katarina Strenkova","email":"kstrenko@redhat.com","username":"kstrenko"},"change_message_id":"0375b0fbee57bf5738b1aebea90ba15ef91ba876","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a5fed1f5_4dfc9bcd","in_reply_to":"411d539a_e1a9b76d","updated":"2024-05-10 13:52:07.000000000","message":"Or I can make 2 functions that load different files like so:\n\nif parsed_args.prefix:\n    return\n\nif parsed_args.resource_list:\n    self._load_resource_list_json()\n    return\n\nself._load_saved_state_json()","commit_id":"e88c6ed452ca73c504671204ddfaa34ad6132837"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b995b77f1f62a39d178d7be98e48a19827778724","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"694b6244_6bad9ade","in_reply_to":"a5fed1f5_4dfc9bcd","updated":"2024-05-10 17:41:36.000000000","message":"Thanks, dry_run was skipped in gate run. let me enable it and see.","commit_id":"e88c6ed452ca73c504671204ddfaa34ad6132837"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b995b77f1f62a39d178d7be98e48a19827778724","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2879722d_7ce836ae","updated":"2024-05-10 17:41:36.000000000","message":"check experimental","commit_id":"39ad57ab6466dc0c53310849a129b3b5c4a992d2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7ff37805784dc6514fd209455f388f072e47ddb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"830401a5_1f26bfd6","updated":"2024-05-11 08:49:44.000000000","message":"check experimental","commit_id":"30829861a86c321141aa07b52140d358c999e652"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5bebbe293d03b0d23f35e0555a82faffd7f4dfb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bcc6457d_4f0e1d74","updated":"2024-05-16 14:25:23.000000000","message":"check experimental","commit_id":"3785019c87c1315f410d75ddf2b226f0fcb50e6d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"696b7611c5f7be6af4a6c82e8c2fddb2d91c9121","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e2ca7c0b_05c80e22","updated":"2024-05-17 09:05:23.000000000","message":"check experimental","commit_id":"3785019c87c1315f410d75ddf2b226f0fcb50e6d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"834f2f9c66c7b3a7567c985a91751a42e433c90c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6fab9407_3e0990cd","updated":"2024-05-16 14:25:16.000000000","message":"recheck test_shelve_volume_backed_instance failed with ssh timeout in tempest-slow-py3 job","commit_id":"3785019c87c1315f410d75ddf2b226f0fcb50e6d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"15f5c42e4d130857af9f2aa3f50ffbd431592926","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"92218918_b09ec673","updated":"2024-05-20 10:34:29.000000000","message":"check experimental","commit_id":"de96268f72c4967a4d68c2fe87952f742c4e7be2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2228544985c74a558dd595bcb77a4a80b241d9db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"23e6fd96_7c59712a","updated":"2024-05-20 15:37:38.000000000","message":"check experimental","commit_id":"1a9c40d4696d89afc7ef71ca4bbbd55cd4c63890"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ed6a275851de7e65ac521ae9242ec0e9bfb80692","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bd602a09_4506abfb","updated":"2024-05-21 07:17:36.000000000","message":"recheck test_instances_with_cinder_volumes_on_all_compute_nodes failed in multiple jobs with:\nmount: mounting /dev/vdb on /mnt/vdb failed: Device or resource busy","commit_id":"1a9c40d4696d89afc7ef71ca4bbbd55cd4c63890"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e1c9649bcdc8ba0fb2de439720514bfa1298d36b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4bcb0830_b5ce53bb","updated":"2024-05-21 10:33:31.000000000","message":"recheck test_live_block_migration - the live migration failed","commit_id":"1a9c40d4696d89afc7ef71ca4bbbd55cd4c63890"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"038e489957049bba2e5ff6ccf7d39090a24a283d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b1236110_e288c209","updated":"2024-05-21 04:08:48.000000000","message":"thanks, lgtm","commit_id":"1a9c40d4696d89afc7ef71ca4bbbd55cd4c63890"}],"roles/tempest-cleanup/README.rst":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f271c959b66b9c8ebf312c2616e1acebb8159370","unresolved":true,"context_lines":[{"line_number":47,"context_line":"   only resources with names that match the prefix. This option can be used"},{"line_number":48,"context_line":"   together with dry_run."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. zuul:rolevar:: run_tempest_cleanup_resource_list"},{"line_number":51,"context_line":"   :default: false"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"   When true, tempest cleanup will be called with \u0027--resource-list\u0027 to delete"},{"line_number":54,"context_line":"   only resources listed in ./resource_list.json that is created if"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4451efcb_f2d747e6","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":18},"updated":"2024-05-09 17:50:14.000000000","message":"we need to add this in default setting too https://github.com/openstack/tempest/blob/master/roles/tempest-cleanup/defaults/main.yaml","commit_id":"14955d3b2d7bd535d38d3ace35ccac8efed20709"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c3145cc1ac6f0c775e7bb3f5afa4ae1b3dfcf8ba","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   only resources with names that match the prefix. This option can be used"},{"line_number":48,"context_line":"   together with dry_run."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. zuul:rolevar:: run_tempest_cleanup_resource_list"},{"line_number":51,"context_line":"   :default: false"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"   When true, tempest cleanup will be called with \u0027--resource-list\u0027 to delete"},{"line_number":54,"context_line":"   only resources listed in ./resource_list.json that is created if"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9adbcb4f_811e1b05","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":18},"in_reply_to":"4451efcb_f2d747e6","updated":"2024-05-10 08:32:35.000000000","message":"good catch, i totally forgot","commit_id":"14955d3b2d7bd535d38d3ace35ccac8efed20709"}],"roles/tempest-cleanup/tasks/main.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f271c959b66b9c8ebf312c2616e1acebb8159370","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    - import_tasks: dry_run.yaml"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - name: Cat dry_run.json"},{"line_number":18,"context_line":"      command: cat \"{{ devstack_base_dir }}/tempest/dry_run.json\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- when:"},{"line_number":21,"context_line":"    - not dry_run"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"998dedb9_26c4485d","line":18,"range":{"start_line":18,"start_character":64,"end_line":18,"end_character":65},"updated":"2024-05-09 17:50:14.000000000","message":"let\u0027s do it in dry run also https://github.com/openstack/tempest/blob/master/roles/tempest-cleanup/tasks/dry_run.yaml","commit_id":"14955d3b2d7bd535d38d3ace35ccac8efed20709"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c3145cc1ac6f0c775e7bb3f5afa4ae1b3dfcf8ba","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    - import_tasks: dry_run.yaml"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - name: Cat dry_run.json"},{"line_number":18,"context_line":"      command: cat \"{{ devstack_base_dir }}/tempest/dry_run.json\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- when:"},{"line_number":21,"context_line":"    - not dry_run"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8514be2e_e6506877","line":18,"range":{"start_line":18,"start_character":64,"end_line":18,"end_character":65},"in_reply_to":"998dedb9_26c4485d","updated":"2024-05-10 08:32:35.000000000","message":"Done","commit_id":"14955d3b2d7bd535d38d3ace35ccac8efed20709"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fff54bc96c775dd40db94b2cfacab709ae1a2441","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        chdir: \"{{ devstack_base_dir }}/tempest\""},{"line_number":40,"context_line":"      when: run_tempest_cleanup_prefix"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Run tempest cleanup with tempest resource list"},{"line_number":43,"context_line":"      become: yes"},{"line_number":44,"context_line":"      become_user: tempest"},{"line_number":45,"context_line":"      command: tox -evenv-tempest -- tempest cleanup --debug --resource-list"},{"line_number":46,"context_line":"      args:"},{"line_number":47,"context_line":"        chdir: \"{{ devstack_base_dir }}/tempest\""},{"line_number":48,"context_line":"      when: run_tempest_cleanup_resource_list"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- when:"},{"line_number":51,"context_line":"    - run_tempest_fail_if_leaked_resources"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ef9f2e84_238fecd3","line":48,"range":{"start_line":42,"start_character":0,"end_line":48,"end_character":45},"updated":"2024-05-10 17:51:30.000000000","message":"I was not able to see what all resources are recording to cleanup, log says below which means 0 resources were recorded?\n\n--------------------------\nvenv-tempest run-test: commands[0] | tempest cleanup --debug --resource-list\nBegin cleanup\nList count, 0 Projects after reconcile\nProcessing 0 projects\nProcessing global services\nList count, 0 Flavors after reconcile\nList count, 0 Images after reconcile\nList count, 0 Users after reconcile\nList count, 0 Projects after reconcile\nList count, 0 Domains after reconcile\nList count, 0 Roles after reconcile\nProcessing services\nList count, 0 Servers\nList count, 0 Keypairs\nList count, 0 Server Groups\nList count, 0 Network Floating IPs\nList count, 0 Routers\nList count, 0 Ports\nList count, 0 Subnets\nList count, 0 Networks\nList count, 0 security_groups\nList count, 0 Subnet Pools\nList count, 0 Snapshots\nList count, 0 Volumes\nClearing \u0027resource_list.json\u0027 file.\n---------------------------------------\n\nI think we should log the file in this case too like we do for dry run and saved state file. Before the cleanup (L42) we should add below:\n\n    - name: Cat resource_list.json\n      command: cat \"{{ devstack_base_dir }}/tempest/resource_list.json\"","commit_id":"39ad57ab6466dc0c53310849a129b3b5c4a992d2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f4ae45625aea6ad6ec8cd7ec8f8c8207d32379ba","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        chdir: \"{{ devstack_base_dir }}/tempest\""},{"line_number":40,"context_line":"      when: run_tempest_cleanup_prefix"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Run tempest cleanup with tempest resource list"},{"line_number":43,"context_line":"      become: yes"},{"line_number":44,"context_line":"      become_user: tempest"},{"line_number":45,"context_line":"      command: tox -evenv-tempest -- tempest cleanup --debug --resource-list"},{"line_number":46,"context_line":"      args:"},{"line_number":47,"context_line":"        chdir: \"{{ devstack_base_dir }}/tempest\""},{"line_number":48,"context_line":"      when: run_tempest_cleanup_resource_list"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- when:"},{"line_number":51,"context_line":"    - run_tempest_fail_if_leaked_resources"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a53d4c69_d40781c2","line":48,"range":{"start_line":42,"start_character":0,"end_line":48,"end_character":45},"in_reply_to":"31b6ebfb_6b9aa7d0","updated":"2024-05-15 13:12:15.000000000","message":"so, all good?","commit_id":"39ad57ab6466dc0c53310849a129b3b5c4a992d2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"15245a7f0d103637a4d3d41a9bac394ae711cc50","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        chdir: \"{{ devstack_base_dir }}/tempest\""},{"line_number":40,"context_line":"      when: run_tempest_cleanup_prefix"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Run tempest cleanup with tempest resource list"},{"line_number":43,"context_line":"      become: yes"},{"line_number":44,"context_line":"      become_user: tempest"},{"line_number":45,"context_line":"      command: tox -evenv-tempest -- tempest cleanup --debug --resource-list"},{"line_number":46,"context_line":"      args:"},{"line_number":47,"context_line":"        chdir: \"{{ devstack_base_dir }}/tempest\""},{"line_number":48,"context_line":"      when: run_tempest_cleanup_resource_list"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- when:"},{"line_number":51,"context_line":"    - run_tempest_fail_if_leaked_resources"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9b404448_12ead72a","line":48,"range":{"start_line":42,"start_character":0,"end_line":48,"end_character":45},"in_reply_to":"459816dd_d4f28c06","updated":"2024-05-12 16:20:50.000000000","message":"the resource_list.json is created, search for:\n\"2024-05-11 10:44:24.759735 | TASK [tempest-cleanup : Cat resource_list.json]\"\n\nhttps://03319cc15cd4fcfb2a78-9347d83a8fe43a1fb2bb874d5a705361.ssl.cf5.rackcdn.com/918725/5/experimental/tempest-all/498f3a9/job-output.txt","commit_id":"39ad57ab6466dc0c53310849a129b3b5c4a992d2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8b35548cdb7422a913785b545c6ec65711915177","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        chdir: \"{{ devstack_base_dir }}/tempest\""},{"line_number":40,"context_line":"      when: run_tempest_cleanup_prefix"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Run tempest cleanup with tempest resource list"},{"line_number":43,"context_line":"      become: yes"},{"line_number":44,"context_line":"      become_user: tempest"},{"line_number":45,"context_line":"      command: tox -evenv-tempest -- tempest cleanup --debug --resource-list"},{"line_number":46,"context_line":"      args:"},{"line_number":47,"context_line":"        chdir: \"{{ devstack_base_dir }}/tempest\""},{"line_number":48,"context_line":"      when: run_tempest_cleanup_resource_list"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- when:"},{"line_number":51,"context_line":"    - run_tempest_fail_if_leaked_resources"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"31b6ebfb_6b9aa7d0","line":48,"range":{"start_line":42,"start_character":0,"end_line":48,"end_character":45},"in_reply_to":"9b404448_12ead72a","updated":"2024-05-14 19:32:02.000000000","message":"yeah, it seems nothing was found to cleanup. I checked in logs also to see what all resources are present in the service side and in the resource list file and it gives 0 for many of those. let me let it with some uncleaned resources and I will be good on this.\n\nA Few resources to cleanup but those might be preserved networks?\n-----------------------------------------------------------------\nList count, 3 Networks list /opt/stack/tempest/tempest/cmd/cleanup_service.py:503\n- https://zuul.opendev.org/t/openstack/build/498f3a9c49234830809791cd814fc6a3/log/controller/logs/tempest_log.txt#768\n\nList count, 5 Subnets list /opt/stack/tempest/tempest/cmd/cleanup_service.py:820\n- https://zuul.opendev.org/t/openstack/build/498f3a9c49234830809791cd814fc6a3/log/controller/logs/tempest_log.txt#762\n\nZero resources to cleanup:\n---------------------------\nList count, 0 Servers list /opt/stack/tempest/tempest/cmd/cleanup_service.py:226\n- https://zuul.opendev.org/t/openstack/build/498f3a9c49234830809791cd814fc6a3/log/controller/logs/tempest_log.txt#726\n\nList count, 0 Keypairs list /opt/stack/tempest/tempest/cmd/cleanup_service.py:307\n- https://zuul.opendev.org/t/openstack/build/498f3a9c49234830809791cd814fc6a3/log/controller/logs/tempest_log.txt#732\n\nList count, 0 Server Groups list /opt/stack/tempest/tempest/cmd/cleanup_service.py:263\n- https://zuul.opendev.org/t/openstack/build/498f3a9c49234830809791cd814fc6a3/log/controller/logs/tempest_log.txt#738\n\nList count, 0 Volumes list /opt/stack/tempest/tempest/cmd/cleanup_service.py:349\n- https://zuul.opendev.org/t/openstack/build/498f3a9c49234830809791cd814fc6a3/log/controller/logs/tempest_log.txt#792","commit_id":"39ad57ab6466dc0c53310849a129b3b5c4a992d2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"710e36b6918dd52afc4015c517533d7b7c29e915","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        chdir: \"{{ devstack_base_dir }}/tempest\""},{"line_number":40,"context_line":"      when: run_tempest_cleanup_prefix"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Run tempest cleanup with tempest resource list"},{"line_number":43,"context_line":"      become: yes"},{"line_number":44,"context_line":"      become_user: tempest"},{"line_number":45,"context_line":"      command: tox -evenv-tempest -- tempest cleanup --debug --resource-list"},{"line_number":46,"context_line":"      args:"},{"line_number":47,"context_line":"        chdir: \"{{ devstack_base_dir }}/tempest\""},{"line_number":48,"context_line":"      when: run_tempest_cleanup_resource_list"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- when:"},{"line_number":51,"context_line":"    - run_tempest_fail_if_leaked_resources"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3b08f651_79aa1d74","line":48,"range":{"start_line":42,"start_character":0,"end_line":48,"end_character":45},"in_reply_to":"a53d4c69_d40781c2","updated":"2024-05-15 21:23:58.000000000","message":"There are three cases I am checking here:\n1. it records the resources: tested ok in this change\n2. it pass if no resource to cleanup: tested ok in this change\n3. cleanup resource when some are not cleaned by tests - Testing in https://review.opendev.org/c/openstack/tempest/+/919617","commit_id":"39ad57ab6466dc0c53310849a129b3b5c4a992d2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"65239e2f6a4195915b646a42309d06ef4e976e92","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        chdir: \"{{ devstack_base_dir }}/tempest\""},{"line_number":40,"context_line":"      when: run_tempest_cleanup_prefix"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Run tempest cleanup with tempest resource list"},{"line_number":43,"context_line":"      become: yes"},{"line_number":44,"context_line":"      become_user: tempest"},{"line_number":45,"context_line":"      command: tox -evenv-tempest -- tempest cleanup --debug --resource-list"},{"line_number":46,"context_line":"      args:"},{"line_number":47,"context_line":"        chdir: \"{{ devstack_base_dir }}/tempest\""},{"line_number":48,"context_line":"      when: run_tempest_cleanup_resource_list"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- when:"},{"line_number":51,"context_line":"    - run_tempest_fail_if_leaked_resources"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"459816dd_d4f28c06","line":48,"range":{"start_line":42,"start_character":0,"end_line":48,"end_character":45},"in_reply_to":"ef9f2e84_238fecd3","updated":"2024-05-11 08:44:33.000000000","message":"this is the cleanup output, it only means that 0 resources were deleted as part of the cleanup which usually means that no resources were left behind after tempest testing\n\nYeah, i was thinking about catting the file - also it crossed my mind that what if the file is too long .. let\u0027s try that","commit_id":"39ad57ab6466dc0c53310849a129b3b5c4a992d2"}]}