)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0ba0b1e4ff25688b6143dbccdc34a6d667442c66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b3851130_25943830","updated":"2024-06-03 13:49:45.000000000","message":"lgtm, thanks","commit_id":"edbb0d17f915f6b195e6b96bddc071159cb24f84"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d0bced7ea6aafadb9c4ea1ca944c0776816a961e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0e70a7f3_7ab9a1a4","updated":"2024-06-03 20:00:51.000000000","message":"+1, makes sense. I have seen at least one job failure recently that had to do with a device mount busy.","commit_id":"8280f43489733047045e2ba84653dda537f88f48"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d10d2e1867ab4e38dc391c525820fde22b6aabf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"63b9b7f5_bc60f39b","updated":"2024-06-04 17:48:45.000000000","message":"lgtm","commit_id":"8280f43489733047045e2ba84653dda537f88f48"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6b784a4a8ab6008be3fc8cc764befed5405eda39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f5220f1b_0568bf79","updated":"2024-06-04 15:19:59.000000000","message":"lgtm, one question inside.","commit_id":"8280f43489733047045e2ba84653dda537f88f48"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d7ba220ef270ec9f9c6bcda9e916a1ff0a22095f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4245607d_4a4164d4","updated":"2024-06-09 10:12:10.000000000","message":"recheck 502 from glance during image upload, which is likely a timeout problem","commit_id":"8280f43489733047045e2ba84653dda537f88f48"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1b70ce5dad7d4758a07a9f5a7a625293fc9b8cca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"622f05c5_d06c165e","updated":"2024-06-05 18:37:30.000000000","message":"recheck test_instances_with_cinder_volumes_on_all_compute_nodes timed out with  Command: \u0027set -eu -o pipefail; PATH\u003d$PATH:/sbin:/usr/sbin; sudo mkfs -t vfat /dev/vdb\u0027","commit_id":"8280f43489733047045e2ba84653dda537f88f48"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3136078525d2a4418bfa99b9f42660cb0b631847","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"98f675e5_2760bd9e","updated":"2024-06-05 13:22:50.000000000","message":"thanks","commit_id":"8280f43489733047045e2ba84653dda537f88f48"}],"tempest/scenario/manager.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4610d8eb2cab97848bb6e9584e9a3d80ebccd40d","unresolved":true,"context_lines":[{"line_number":986,"context_line":"            server[\u0027id\u0027], volumeId\u003dvolume_to_attach[\u0027id\u0027],"},{"line_number":987,"context_line":"            **kwargs)[\u0027volumeAttachment\u0027]"},{"line_number":988,"context_line":"        self.assertEqual(volume_to_attach[\u0027id\u0027], volume[\u0027id\u0027])"},{"line_number":989,"context_line":"        waiters.wait_for_volume_resource_status(volumes_client,"},{"line_number":990,"context_line":"                                                volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":991,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":992,"context_line":"                        self.nova_volume_detach, server, volume,"},{"line_number":993,"context_line":"                        servers_client)"}],"source_content_type":"text/x-python","patch_set":4,"id":"8351ba2b_245b3d23","line":990,"range":{"start_line":989,"start_character":8,"end_line":990,"end_character":71},"updated":"2024-06-04 17:04:42.000000000","message":"This is where nova_volume_attach waits for the volume to be in-use.","commit_id":"8280f43489733047045e2ba84653dda537f88f48"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d10d2e1867ab4e38dc391c525820fde22b6aabf6","unresolved":false,"context_lines":[{"line_number":986,"context_line":"            server[\u0027id\u0027], volumeId\u003dvolume_to_attach[\u0027id\u0027],"},{"line_number":987,"context_line":"            **kwargs)[\u0027volumeAttachment\u0027]"},{"line_number":988,"context_line":"        self.assertEqual(volume_to_attach[\u0027id\u0027], volume[\u0027id\u0027])"},{"line_number":989,"context_line":"        waiters.wait_for_volume_resource_status(volumes_client,"},{"line_number":990,"context_line":"                                                volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":991,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":992,"context_line":"                        self.nova_volume_detach, server, volume,"},{"line_number":993,"context_line":"                        servers_client)"}],"source_content_type":"text/x-python","patch_set":4,"id":"124e020e_a5d90751","line":990,"range":{"start_line":989,"start_character":8,"end_line":990,"end_character":71},"in_reply_to":"8351ba2b_245b3d23","updated":"2024-06-04 17:48:45.000000000","message":"+1, thanks for pointing it","commit_id":"8280f43489733047045e2ba84653dda537f88f48"}],"tempest/scenario/test_instances_with_cinder_volumes.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5cb5fc827f72bfeacb869533e2f17ce0584afe45","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            # run write test on all volumes"},{"line_number":185,"context_line":"            for volume in attached_volumes:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"                waiters.wait_for_volume_resource_status("},{"line_number":188,"context_line":"                    self.volumes_client, volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"                # get the mount path"}],"source_content_type":"text/x-python","patch_set":3,"id":"665d8df2_20ac9c55","side":"PARENT","line":187,"range":{"start_line":187,"start_character":24,"end_line":187,"end_character":55},"updated":"2024-06-03 14:43:30.000000000","message":"this is removed because nova_volume_attach already ensures the same state.","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5cb5fc827f72bfeacb869533e2f17ce0584afe45","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                    self.volumes_client, volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"                # get the mount path"},{"line_number":191,"context_line":"                mount_path \u003d f\"/mnt/{volume[\u0027attachments\u0027][0][\u0027device\u0027][5:]}\""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"                # create file for mounting on server"},{"line_number":194,"context_line":"                self.create_file(ssh_ip, mount_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3e30009f_0ac3e0db","side":"PARENT","line":191,"range":{"start_line":191,"start_character":16,"end_line":191,"end_character":77},"updated":"2024-06-03 14:43:30.000000000","message":"just noticed that we no longer need to maintain this logic here and can rely on the underlying implementation now.","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6b784a4a8ab6008be3fc8cc764befed5405eda39","unresolved":true,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"            # run write test on all volumes"},{"line_number":185,"context_line":"            for volume in attached_volumes:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"                waiters.wait_for_volume_resource_status("},{"line_number":188,"context_line":"                    self.volumes_client, volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"                # get the mount path"},{"line_number":191,"context_line":"                mount_path \u003d f\"/mnt/{volume[\u0027attachments\u0027][0][\u0027device\u0027][5:]}\""},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da65e37a_f1b777f7","side":"PARENT","line":189,"range":{"start_line":186,"start_character":0,"end_line":189,"end_character":0},"updated":"2024-06-04 15:19:59.000000000","message":"we still need to check volume state right?","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d10d2e1867ab4e38dc391c525820fde22b6aabf6","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"            # run write test on all volumes"},{"line_number":185,"context_line":"            for volume in attached_volumes:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"                waiters.wait_for_volume_resource_status("},{"line_number":188,"context_line":"                    self.volumes_client, volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"                # get the mount path"},{"line_number":191,"context_line":"                mount_path \u003d f\"/mnt/{volume[\u0027attachments\u0027][0][\u0027device\u0027][5:]}\""},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e57177f2_eb291096","side":"PARENT","line":189,"range":{"start_line":186,"start_character":0,"end_line":189,"end_character":0},"in_reply_to":"b2d2b84d_68f03f2e","updated":"2024-06-04 17:48:45.000000000","message":"ah yeah, we do not need to wait it again.","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4610d8eb2cab97848bb6e9584e9a3d80ebccd40d","unresolved":true,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"            # run write test on all volumes"},{"line_number":185,"context_line":"            for volume in attached_volumes:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"                waiters.wait_for_volume_resource_status("},{"line_number":188,"context_line":"                    self.volumes_client, volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"                # get the mount path"},{"line_number":191,"context_line":"                mount_path \u003d f\"/mnt/{volume[\u0027attachments\u0027][0][\u0027device\u0027][5:]}\""},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b2d2b84d_68f03f2e","side":"PARENT","line":189,"range":{"start_line":186,"start_character":0,"end_line":189,"end_character":0},"in_reply_to":"da65e37a_f1b777f7","updated":"2024-06-04 17:04:42.000000000","message":"On PS3 Takashi mentioned that nova_volume_attach already waits for volume status:\n\nhttps://review.opendev.org/c/openstack/tempest/+/920021/comment/665d8df2_20ac9c55/","commit_id":"aec7f39cbe29fef41f64001cb2abbbdef35b3500"}]}