)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"5cdbe65d812b3610b8c86b5510ccb9400033ff5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ef3aedec_a6ef6c26","updated":"2024-06-10 11:20:03.000000000","message":"I think we must add here something as I proposed. Now after your patch is merged when I create 2 same instances on 2 nodes it will use these paths:\n/mnt/vdb/vdb\n/mnt/vdc/vdc\n/mnt/vdb/vdb\n/mnt/vdc/vdc\nSo there are just 2 unique ones. I think we must add something unique to this names, for example volume name as i proposed. What do you think?","commit_id":"68b6078ea9b7e41aa23d6ee2f19e664b3ab6b9ed"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f78fb8d7e21c1c08a27bf4883011d3ccba1ab4a3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1143a13a_41353c75","updated":"2024-06-03 14:41:45.000000000","message":"I\u0027m a bit confused with the patch set 2. The parent patch would be enough unless volume devices are not detached/attached during","commit_id":"68b6078ea9b7e41aa23d6ee2f19e664b3ab6b9ed"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"c6ed76e6d4d8ad519cc59dcb64aa54d7c7e27cad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e3f402a0_d1fca467","updated":"2024-06-10 08:21:05.000000000","message":"Sorry for late reply, I just want to check if there is some work to do. I tested your patch and it worked and from my understanding of code it would fix problem with unmounting, am I right? I think there is nothing else to change in test test_instances_with_cinder_volumes.","commit_id":"68b6078ea9b7e41aa23d6ee2f19e664b3ab6b9ed"}],"tempest/scenario/test_instances_with_cinder_volumes.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0bc26056c0ab92a9f38f45a1d0c14df673b2d9b5","unresolved":true,"context_lines":[{"line_number":201,"context_line":"                try:"},{"line_number":202,"context_line":"                    self.linux_client.exec_command(check_mount_cmd)"},{"line_number":203,"context_line":"                    # If the directory is already mounted, unmount it"},{"line_number":204,"context_line":"                    unmount_cmd \u003d f\"sudo umount {mount_path}\""},{"line_number":205,"context_line":"                    self.linux_client.exec_command(unmount_cmd)"},{"line_number":206,"context_line":"                except exceptions.SSHExecCommandFailed:"},{"line_number":207,"context_line":"                    # Directory is not mounted, continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"1b27506a_3b90d7e0","line":204,"range":{"start_line":204,"start_character":20,"end_line":204,"end_character":61},"updated":"2024-06-03 09:06:55.000000000","message":"IIUC the problem here is caused by the umount command which does not wait until the unmount operation is completed. So we don\u0027t need this mount but should implement looping check after umount command to ensure the mount is actually completed.\n\nAlternatively we can use independent path per each device which I proposed in https://review.opendev.org/c/openstack/tempest/+/920021 .","commit_id":"365cca71ad33e4db467672f12cfef399cd9feb36"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"d147d28833b590cc9070fe1532b3a8eaae5c158b","unresolved":true,"context_lines":[{"line_number":201,"context_line":"                try:"},{"line_number":202,"context_line":"                    self.linux_client.exec_command(check_mount_cmd)"},{"line_number":203,"context_line":"                    # If the directory is already mounted, unmount it"},{"line_number":204,"context_line":"                    unmount_cmd \u003d f\"sudo umount {mount_path}\""},{"line_number":205,"context_line":"                    self.linux_client.exec_command(unmount_cmd)"},{"line_number":206,"context_line":"                except exceptions.SSHExecCommandFailed:"},{"line_number":207,"context_line":"                    # Directory is not mounted, continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"56466cd3_70ae5d4f","line":204,"range":{"start_line":204,"start_character":20,"end_line":204,"end_character":61},"in_reply_to":"1b27506a_3b90d7e0","updated":"2024-06-03 11:59:25.000000000","message":"@kajinamit@oss.nttdata.com Thanks for letting me know about this patch. Yeah I also though about implementing some waiter there, but i think it is useless, cause it can take so much time 😞.\n\nSo I tried to do that with independent paths, we will see how it works 😊.","commit_id":"365cca71ad33e4db467672f12cfef399cd9feb36"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f78fb8d7e21c1c08a27bf4883011d3ccba1ab4a3","unresolved":true,"context_lines":[{"line_number":188,"context_line":"                    self.volumes_client, volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"                # get device name"},{"line_number":191,"context_line":"                dev_name \u003d f\"{volume[\u0027attachments\u0027][0][\u0027device\u0027][5:]}\""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"                # create file for mounting on server"},{"line_number":194,"context_line":"                self.create_file(ssh_ip, "}],"source_content_type":"text/x-python","patch_set":2,"id":"63e91123_127e25c5","line":191,"range":{"start_line":191,"start_character":16,"end_line":191,"end_character":70},"updated":"2024-06-03 14:41:45.000000000","message":"Hmm, wait. I think we no longer need this complicated logic here because the device name is appended to mount path in underlying implementation. I\u0027ll address this in my parent patch...","commit_id":"68b6078ea9b7e41aa23d6ee2f19e664b3ab6b9ed"}]}