)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2455ac5d2d383dc6425e72629dc34eb174ce335e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This patch adds a test for verifying that hostname allows"},{"line_number":10,"context_line":"FQDN and can contains periods in hostname starting API microversion 2.94."},{"line_number":11,"context_line":"This patch also verifies hostname from the metadata api and also checks"},{"line_number":12,"context_line":"hostname allows character lenght above 64 ."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also, adding a config feature flag dncp_domain to set the suffix in"},{"line_number":15,"context_line":"order to verify the hostname correctly ."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"43aad151_74607bee","line":12,"range":{"start_line":12,"start_character":26,"end_line":12,"end_character":32},"updated":"2024-07-04 05:23:19.000000000","message":"nit","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"cff51c012e0b4ddc8ba95b6dee717b0f66b32874","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds a test for verifying that hostname allows"},{"line_number":10,"context_line":"FQDN and can contains periods in hostname starting API microversion 2.94."},{"line_number":11,"context_line":"This patch also verifies hostname from the metadata api and also checks"},{"line_number":12,"context_line":"hostname allows character lenght above 64 ."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also, adding a config feature flag dncp_domain to set the suffix in"},{"line_number":15,"context_line":"order to verify the hostname correctly ."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"650950f6_f89e6ec8","line":12,"range":{"start_line":12,"start_character":26,"end_line":12,"end_character":32},"in_reply_to":"43aad151_74607bee","updated":"2024-07-04 19:47:15.000000000","message":"Done","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2455ac5d2d383dc6425e72629dc34eb174ce335e","unresolved":true,"context_lines":[{"line_number":11,"context_line":"This patch also verifies hostname from the metadata api and also checks"},{"line_number":12,"context_line":"hostname allows character lenght above 64 ."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also, adding a config feature flag dncp_domain to set the suffix in"},{"line_number":15,"context_line":"order to verify the hostname correctly ."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Relates to : https://review.opendev.org/c/openstack/nova/+/869812"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"833dcaea_0c7fabcd","line":14,"range":{"start_line":14,"start_character":35,"end_line":14,"end_character":46},"updated":"2024-07-04 05:23:19.000000000","message":"nit:dhcp","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"cff51c012e0b4ddc8ba95b6dee717b0f66b32874","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This patch also verifies hostname from the metadata api and also checks"},{"line_number":12,"context_line":"hostname allows character lenght above 64 ."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also, adding a config feature flag dncp_domain to set the suffix in"},{"line_number":15,"context_line":"order to verify the hostname correctly ."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Relates to : https://review.opendev.org/c/openstack/nova/+/869812"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"6755a1e3_ab29af78","line":14,"range":{"start_line":14,"start_character":35,"end_line":14,"end_character":46},"in_reply_to":"833dcaea_0c7fabcd","updated":"2024-07-04 19:47:15.000000000","message":"Done","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"8f1125cd9e95d433a8767448656fe562712ba38f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"65e1c70b_b9949af2","updated":"2024-06-29 10:19:30.000000000","message":"recheck, timeout","commit_id":"281ba556ee57a34fa45eb1918912afa66e1b8b31"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2455ac5d2d383dc6425e72629dc34eb174ce335e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"eb36ae66_03abb08e","updated":"2024-07-04 05:23:19.000000000","message":"test lgtm","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"a44cee2fe23e5f2332459c73bd05cb206176b98a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"4cc419a0_8176576e","updated":"2024-07-16 10:05:51.000000000","message":"Looks good to me! \n\nOne small question raised.","commit_id":"e27a9d6221734420ccf73f8f6278c0368a65dcc3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9a4110c5aae035197161d7fe56a7253375deb24d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"e28a60ce_d262105e","updated":"2024-07-15 21:35:37.000000000","message":"lgtm, the test successfully ran in https://9764ebf39d584e1aacca-7d0efbcadbac6c5ef275b01e35cbf4c9.ssl.cf2.rackcdn.com/922342/22/check/tempest-full-2024-1/1d5b527/testr_results.html","commit_id":"e27a9d6221734420ccf73f8f6278c0368a65dcc3"}],"tempest/api/compute/base.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2455ac5d2d383dc6425e72629dc34eb174ce335e","unresolved":true,"context_lines":[{"line_number":539,"context_line":"        return volume"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    @classmethod"},{"line_number":542,"context_line":"    def verify_metadata_from_api(self, server, ssh_client, verify_method):"},{"line_number":543,"context_line":"        md_url \u003d \u0027http://169.254.169.254/openstack/latest/meta_data.json\u0027"},{"line_number":544,"context_line":"        LOG.info(\u0027Attempting to verify tagged devices in server %s via \u0027"},{"line_number":545,"context_line":"                 \u0027the metadata service: %s\u0027, server[\u0027id\u0027], md_url)"}],"source_content_type":"text/x-python","patch_set":20,"id":"12b6a6ad_93359cd0","line":542,"updated":"2024-07-04 05:23:19.000000000","message":"if we are moving this in base\nI think we should call it get_server_metadata_from_api instead of verify.","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"2886498de89ce77f85fc4105f66e8e30029b8b93","unresolved":true,"context_lines":[{"line_number":539,"context_line":"        return volume"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    @classmethod"},{"line_number":542,"context_line":"    def verify_metadata_from_api(self, server, ssh_client, verify_method):"},{"line_number":543,"context_line":"        md_url \u003d \u0027http://169.254.169.254/openstack/latest/meta_data.json\u0027"},{"line_number":544,"context_line":"        LOG.info(\u0027Attempting to verify tagged devices in server %s via \u0027"},{"line_number":545,"context_line":"                 \u0027the metadata service: %s\u0027, server[\u0027id\u0027], md_url)"}],"source_content_type":"text/x-python","patch_set":20,"id":"b43ac127_efdc92af","line":542,"in_reply_to":"12b6a6ad_93359cd0","updated":"2024-07-04 19:45:20.000000000","message":"So I think the reason it is being called verify_metadata_from_api is because it not only fetches the meta but verifies it later based on what is being returned by the verify method ,maybe something like get_and_verify_metadata_from_api would work better ?","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"0518d5e5596624fd541b91b994b52dff41c24a5a","unresolved":false,"context_lines":[{"line_number":539,"context_line":"        return volume"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    @classmethod"},{"line_number":542,"context_line":"    def verify_metadata_from_api(self, server, ssh_client, verify_method):"},{"line_number":543,"context_line":"        md_url \u003d \u0027http://169.254.169.254/openstack/latest/meta_data.json\u0027"},{"line_number":544,"context_line":"        LOG.info(\u0027Attempting to verify tagged devices in server %s via \u0027"},{"line_number":545,"context_line":"                 \u0027the metadata service: %s\u0027, server[\u0027id\u0027], md_url)"}],"source_content_type":"text/x-python","patch_set":20,"id":"bd6a342a_f8a786ff","line":542,"in_reply_to":"75224528_47b5b1ef","updated":"2024-07-17 08:03:12.000000000","message":"Resolving this as tempest-cores are okay with it as is","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"fefd0b5ac9f909c1e42448d7057ea32f97fdd1d8","unresolved":true,"context_lines":[{"line_number":539,"context_line":"        return volume"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    @classmethod"},{"line_number":542,"context_line":"    def verify_metadata_from_api(self, server, ssh_client, verify_method):"},{"line_number":543,"context_line":"        md_url \u003d \u0027http://169.254.169.254/openstack/latest/meta_data.json\u0027"},{"line_number":544,"context_line":"        LOG.info(\u0027Attempting to verify tagged devices in server %s via \u0027"},{"line_number":545,"context_line":"                 \u0027the metadata service: %s\u0027, server[\u0027id\u0027], md_url)"}],"source_content_type":"text/x-python","patch_set":20,"id":"75224528_47b5b1ef","line":542,"in_reply_to":"b43ac127_efdc92af","updated":"2024-07-08 09:47:11.000000000","message":"yeah, so I meant to say, we should remove callback from here, it should not verify in base `(if we are moving it to base, which I think we should not)`,\nit should only retrieve metadata and verification should be done in caller-test.","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"55c627056f6d54085154cd8c3248cc6b911b95a3","unresolved":true,"context_lines":[{"line_number":539,"context_line":"        return volume"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    @classmethod"},{"line_number":542,"context_line":"    def verify_metadata_from_api(self, server, ssh_client, verify_method):"},{"line_number":543,"context_line":"        md_url \u003d \u0027http://169.254.169.254/openstack/latest/meta_data.json\u0027"},{"line_number":544,"context_line":"        LOG.info(\u0027Attempting to verify tagged devices in server %s via \u0027"},{"line_number":545,"context_line":"                 \u0027the metadata service: %s\u0027, server[\u0027id\u0027], md_url)"}],"source_content_type":"text/x-python","patch_set":22,"id":"7c31ede4_f98fcc10","line":542,"updated":"2024-07-17 11:21:41.000000000","message":"Femtonit: classmethods normally accept `cls` instead of `self`","commit_id":"e27a9d6221734420ccf73f8f6278c0368a65dcc3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"136d94ab7975c629e1d8066dfb68255fa2685be4","unresolved":true,"context_lines":[{"line_number":539,"context_line":"        return volume"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    @classmethod"},{"line_number":542,"context_line":"    def verify_metadata_from_api(self, server, ssh_client, verify_method):"},{"line_number":543,"context_line":"        md_url \u003d \u0027http://169.254.169.254/openstack/latest/meta_data.json\u0027"},{"line_number":544,"context_line":"        LOG.info(\u0027Attempting to verify tagged devices in server %s via \u0027"},{"line_number":545,"context_line":"                 \u0027the metadata service: %s\u0027, server[\u0027id\u0027], md_url)"}],"source_content_type":"text/x-python","patch_set":22,"id":"bd920294_fe6a4128","line":542,"in_reply_to":"7c31ede4_f98fcc10","updated":"2024-07-17 11:56:20.000000000","message":"ah, missed that, i wonder how big of a problem it makes as it wasn\u0027t caught by e.g. tox jobs or the execution.","commit_id":"e27a9d6221734420ccf73f8f6278c0368a65dcc3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"199ad50333399bf0138af91f59dbbfe24b442651","unresolved":true,"context_lines":[{"line_number":539,"context_line":"        return volume"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    @classmethod"},{"line_number":542,"context_line":"    def verify_metadata_from_api(self, server, ssh_client, verify_method):"},{"line_number":543,"context_line":"        md_url \u003d \u0027http://169.254.169.254/openstack/latest/meta_data.json\u0027"},{"line_number":544,"context_line":"        LOG.info(\u0027Attempting to verify tagged devices in server %s via \u0027"},{"line_number":545,"context_line":"                 \u0027the metadata service: %s\u0027, server[\u0027id\u0027], md_url)"}],"source_content_type":"text/x-python","patch_set":22,"id":"f7f033d9_9c297db8","line":542,"in_reply_to":"bd920294_fe6a4128","updated":"2024-07-17 11:58:10.000000000","message":"absultely none\n\nthis is just a convention and the name we use here is just the local name in this scope\n\nits purly a style issue not a functional one","commit_id":"e27a9d6221734420ccf73f8f6278c0368a65dcc3"}],"tempest/api/compute/servers/test_create_server.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b6a5c88bb0526260fb7ed38e1bb4b199a1f078a3","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            server\u003dself.test_server,"},{"line_number":315,"context_line":"            servers_client\u003dself.client)"},{"line_number":316,"context_line":"        self.verify_metadata_from_api("},{"line_number":317,"context_line":"            self.test_server, linux_client, self.verify_metadata_hostname)"}],"source_content_type":"text/x-python","patch_set":14,"id":"8c143644_6356f4d8","line":317,"updated":"2024-07-01 15:29:01.000000000","message":"the other way you coudl check as a seperate test woudl be if the init system actully put that in /etc/hostname however that depened on the image and if its using cloud init/glean and how they are configured.\n\nso i agree verifying the data retruned to the guest via the metadata api is more correct.","commit_id":"570417f2c8195ef2f37634207084c71d154bb06a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70e1a21ee12319db87914883df47d8a7850a1377","unresolved":true,"context_lines":[{"line_number":284,"context_line":"    def verify_metadata_hostname(self, md_json):"},{"line_number":285,"context_line":"        md_dict \u003d json.loads(md_json)"},{"line_number":286,"context_line":"        dhcp_domain \u003d CONF.compute_feature_enabled.dhcp_domain"},{"line_number":287,"context_line":"        if md_dict[\u0027hostname\u0027] \u003d\u003d \u0027.\u0027.join([self.hostname, dhcp_domain]):"},{"line_number":288,"context_line":"            return True"},{"line_number":289,"context_line":"        else:"},{"line_number":290,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":20,"id":"83a0ac9c_eddaced4","line":287,"range":{"start_line":287,"start_character":34,"end_line":287,"end_character":72},"updated":"2024-07-08 11:26:02.000000000","message":"i would personlaly not do this.\n\nthis iwll reqult in adding a `.` to the end of the hostname wehn dhcp_domain is the empty string.\n\ninstad just do \n\nf\"{self.hostname}{dhcp_domian}\"","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"bf7b2d5837e7802f5d325b4e362f30f174727fd1","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    def verify_metadata_hostname(self, md_json):"},{"line_number":285,"context_line":"        md_dict \u003d json.loads(md_json)"},{"line_number":286,"context_line":"        dhcp_domain \u003d CONF.compute_feature_enabled.dhcp_domain"},{"line_number":287,"context_line":"        if md_dict[\u0027hostname\u0027] \u003d\u003d \u0027.\u0027.join([self.hostname, dhcp_domain]):"},{"line_number":288,"context_line":"            return True"},{"line_number":289,"context_line":"        else:"},{"line_number":290,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":20,"id":"2d2c8172_07a50597","line":287,"range":{"start_line":287,"start_character":34,"end_line":287,"end_character":72},"in_reply_to":"83a0ac9c_eddaced4","updated":"2024-07-15 13:51:54.000000000","message":"Done","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2455ac5d2d383dc6425e72629dc34eb174ce335e","unresolved":true,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        Verify the hostname has FQDN value and Freeform characters"},{"line_number":299,"context_line":"        in the hostname are allowed"},{"line_number":300,"context_line":"        \"\"\""},{"line_number":301,"context_line":"        self.assertEqual("},{"line_number":302,"context_line":"            self.hostname, self.server[\u0027OS-EXT-SRV-ATTR:hostname\u0027])"},{"line_number":303,"context_line":"        # Verify that metadata API has correct hostname inside guest"}],"source_content_type":"text/x-python","patch_set":20,"id":"d239f099_2e298af0","line":300,"updated":"2024-07-04 05:23:19.000000000","message":"this gives\nlocal-hostname: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-guest-test.domaintest.com.novalocal\n\ncan you please add another one with empty dhcp_domain (if its not added already in tempest)\nwhich should return *.test.domaintest.com","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"0518d5e5596624fd541b91b994b52dff41c24a5a","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        Verify the hostname has FQDN value and Freeform characters"},{"line_number":299,"context_line":"        in the hostname are allowed"},{"line_number":300,"context_line":"        \"\"\""},{"line_number":301,"context_line":"        self.assertEqual("},{"line_number":302,"context_line":"            self.hostname, self.server[\u0027OS-EXT-SRV-ATTR:hostname\u0027])"},{"line_number":303,"context_line":"        # Verify that metadata API has correct hostname inside guest"}],"source_content_type":"text/x-python","patch_set":20,"id":"fddb0319_fbae9e0b","line":300,"in_reply_to":"0c88079e_c46d614f","updated":"2024-07-17 08:03:12.000000000","message":"Done","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"fefd0b5ac9f909c1e42448d7057ea32f97fdd1d8","unresolved":true,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        Verify the hostname has FQDN value and Freeform characters"},{"line_number":299,"context_line":"        in the hostname are allowed"},{"line_number":300,"context_line":"        \"\"\""},{"line_number":301,"context_line":"        self.assertEqual("},{"line_number":302,"context_line":"            self.hostname, self.server[\u0027OS-EXT-SRV-ATTR:hostname\u0027])"},{"line_number":303,"context_line":"        # Verify that metadata API has correct hostname inside guest"}],"source_content_type":"text/x-python","patch_set":20,"id":"4d218a58_e5704ed0","line":300,"in_reply_to":"308ea921_53603edf","updated":"2024-07-08 09:47:11.000000000","message":"As-of-now, whatever hostname we ask while server creation, novalocal will be appended after that, which you are alredy confirming/verifing at L287.\n\nbecause deafult value of CONF.compute_feature_enabled.dhcp_domain is \u0027novalocal\u0027.\n\nanother test I am asking to add is when operator set dhcp_domain \u003d \u0027\u0027 in nova.conf. That time only the asked hostname will get set, without \u0027novalocal\u0027.\n\nI think we should be ablt to do that by:\n```\nCONF.compute_feature_enabled.dhcp_domain \u003d \u0027\u0027```","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"a3fa21d8f2fe0c48c030b9f7972da500ac2b4fc7","unresolved":true,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        Verify the hostname has FQDN value and Freeform characters"},{"line_number":299,"context_line":"        in the hostname are allowed"},{"line_number":300,"context_line":"        \"\"\""},{"line_number":301,"context_line":"        self.assertEqual("},{"line_number":302,"context_line":"            self.hostname, self.server[\u0027OS-EXT-SRV-ATTR:hostname\u0027])"},{"line_number":303,"context_line":"        # Verify that metadata API has correct hostname inside guest"}],"source_content_type":"text/x-python","patch_set":20,"id":"f851bef8_bb9ce122","line":300,"in_reply_to":"4d218a58_e5704ed0","updated":"2024-07-08 11:03:56.000000000","message":"so we need to restart nova services after conf updates, hence we can\u0027t test it here with tempest, I think that why its was not discussed by others already.","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"2886498de89ce77f85fc4105f66e8e30029b8b93","unresolved":true,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        Verify the hostname has FQDN value and Freeform characters"},{"line_number":299,"context_line":"        in the hostname are allowed"},{"line_number":300,"context_line":"        \"\"\""},{"line_number":301,"context_line":"        self.assertEqual("},{"line_number":302,"context_line":"            self.hostname, self.server[\u0027OS-EXT-SRV-ATTR:hostname\u0027])"},{"line_number":303,"context_line":"        # Verify that metadata API has correct hostname inside guest"}],"source_content_type":"text/x-python","patch_set":20,"id":"308ea921_53603edf","line":300,"in_reply_to":"d239f099_2e298af0","updated":"2024-07-04 19:45:20.000000000","message":"You are suggesting adding another flag in tempest.conf ? dhcp_domain part is coming into picture only in metadata api result . For show server part it will always show what has been passed by the user using --hostname parameter . Apologies if I misunderstood your comment and would surely love to have some clarification","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70e1a21ee12319db87914883df47d8a7850a1377","unresolved":true,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        Verify the hostname has FQDN value and Freeform characters"},{"line_number":299,"context_line":"        in the hostname are allowed"},{"line_number":300,"context_line":"        \"\"\""},{"line_number":301,"context_line":"        self.assertEqual("},{"line_number":302,"context_line":"            self.hostname, self.server[\u0027OS-EXT-SRV-ATTR:hostname\u0027])"},{"line_number":303,"context_line":"        # Verify that metadata API has correct hostname inside guest"}],"source_content_type":"text/x-python","patch_set":20,"id":"0c88079e_c46d614f","line":300,"in_reply_to":"f851bef8_bb9ce122","updated":"2024-07-08 11:26:02.000000000","message":"generic tempest tests are blackbox tests and are not allowed to restart services or performa any host-level operation like reading the nova.conf for example.\n\n\nwe should not have a separate test without the suffix as the way this is intended to work is that you set the suffix in the tempest.config to the value used for the deployed cloud.\n\n\na separate test would only make sense if this was a per vm setting but its not\nwe previously discussed that we can\u0027t and shoudl not have a separate test for each\npermuation since only one of the two is valid on a given cloud.","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2455ac5d2d383dc6425e72629dc34eb174ce335e","unresolved":true,"context_lines":[{"line_number":308,"context_line":"            self.validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":309,"context_line":"            server\u003dself.test_server,"},{"line_number":310,"context_line":"            servers_client\u003dself.client)"},{"line_number":311,"context_line":"        self.verify_metadata_from_api("},{"line_number":312,"context_line":"            self.test_server, linux_client, self.verify_metadata_hostname)"}],"source_content_type":"text/x-python","patch_set":20,"id":"a61ae18a_4c3f5fc7","line":311,"updated":"2024-07-04 05:23:19.000000000","message":"verify_metadata_hostname return True or False, we can verify it by, self.assertTrue","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"fefd0b5ac9f909c1e42448d7057ea32f97fdd1d8","unresolved":true,"context_lines":[{"line_number":308,"context_line":"            self.validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":309,"context_line":"            server\u003dself.test_server,"},{"line_number":310,"context_line":"            servers_client\u003dself.client)"},{"line_number":311,"context_line":"        self.verify_metadata_from_api("},{"line_number":312,"context_line":"            self.test_server, linux_client, self.verify_metadata_hostname)"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f8d0e26_95c227c5","line":311,"in_reply_to":"593f8f65_60c0a1ff","updated":"2024-07-08 09:47:11.000000000","message":"yes, because we are doing verification in base instead of here in test. \nwhich is offcourse alright because it works and if tempest-cores are okay with that.","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9a4110c5aae035197161d7fe56a7253375deb24d","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            self.validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":309,"context_line":"            server\u003dself.test_server,"},{"line_number":310,"context_line":"            servers_client\u003dself.client)"},{"line_number":311,"context_line":"        self.verify_metadata_from_api("},{"line_number":312,"context_line":"            self.test_server, linux_client, self.verify_metadata_hostname)"}],"source_content_type":"text/x-python","patch_set":20,"id":"07fb259b_356c30fc","line":311,"in_reply_to":"7f8d0e26_95c227c5","updated":"2024-07-15 21:35:37.000000000","message":"imo, looks good as is","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"2886498de89ce77f85fc4105f66e8e30029b8b93","unresolved":true,"context_lines":[{"line_number":308,"context_line":"            self.validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":309,"context_line":"            server\u003dself.test_server,"},{"line_number":310,"context_line":"            servers_client\u003dself.client)"},{"line_number":311,"context_line":"        self.verify_metadata_from_api("},{"line_number":312,"context_line":"            self.test_server, linux_client, self.verify_metadata_hostname)"}],"source_content_type":"text/x-python","patch_set":20,"id":"593f8f65_60c0a1ff","line":311,"in_reply_to":"a61ae18a_4c3f5fc7","updated":"2024-07-04 19:45:20.000000000","message":"I don\u0027t think we need to explicitly assert this here as the verify_metadata_hostname returns True or False to the calling function(verify_metadata_from_api) and based on the value received it will pass or fails with an exception .","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"a44cee2fe23e5f2332459c73bd05cb206176b98a","unresolved":true,"context_lines":[{"line_number":298,"context_line":"        Verify the hostname has FQDN value and Freeform characters"},{"line_number":299,"context_line":"        in the hostname are allowed"},{"line_number":300,"context_line":"        \"\"\""},{"line_number":301,"context_line":"        self.assertEqual("},{"line_number":302,"context_line":"            self.hostname, self.server[\u0027OS-EXT-SRV-ATTR:hostname\u0027])"},{"line_number":303,"context_line":"        # Verify that metadata API has correct hostname inside guest"},{"line_number":304,"context_line":"        linux_client \u003d remote_client.RemoteClient("}],"source_content_type":"text/x-python","patch_set":22,"id":"33a2389f_f491eb01","line":301,"updated":"2024-07-16 10:05:51.000000000","message":"Didn\u0027t we want to make this a separate testcase? Is this something that no longer makes sense? I think it would make the results more granular and it would be more cleaner what went wrong if there is a failure.\n\nBut I\u0027m mentioning this only because we talked about this and you did the work of moving the server creation into the resource_setup(). Otherwise it looks good to me:).","commit_id":"e27a9d6221734420ccf73f8f6278c0368a65dcc3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"aee5a7a379819479cc4176e90c819a3266112550","unresolved":true,"context_lines":[{"line_number":298,"context_line":"        Verify the hostname has FQDN value and Freeform characters"},{"line_number":299,"context_line":"        in the hostname are allowed"},{"line_number":300,"context_line":"        \"\"\""},{"line_number":301,"context_line":"        self.assertEqual("},{"line_number":302,"context_line":"            self.hostname, self.server[\u0027OS-EXT-SRV-ATTR:hostname\u0027])"},{"line_number":303,"context_line":"        # Verify that metadata API has correct hostname inside guest"},{"line_number":304,"context_line":"        linux_client \u003d remote_client.RemoteClient("}],"source_content_type":"text/x-python","patch_set":22,"id":"bef0db62_05247dad","line":301,"in_reply_to":"33a2389f_f491eb01","updated":"2024-07-16 12:55:29.000000000","message":"i don\u0027t follow, this is a separate test case, it starts on line 295, if we remove this assert, what will be left here?","commit_id":"e27a9d6221734420ccf73f8f6278c0368a65dcc3"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"0518d5e5596624fd541b91b994b52dff41c24a5a","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        Verify the hostname has FQDN value and Freeform characters"},{"line_number":299,"context_line":"        in the hostname are allowed"},{"line_number":300,"context_line":"        \"\"\""},{"line_number":301,"context_line":"        self.assertEqual("},{"line_number":302,"context_line":"            self.hostname, self.server[\u0027OS-EXT-SRV-ATTR:hostname\u0027])"},{"line_number":303,"context_line":"        # Verify that metadata API has correct hostname inside guest"},{"line_number":304,"context_line":"        linux_client \u003d remote_client.RemoteClient("}],"source_content_type":"text/x-python","patch_set":22,"id":"fa3a2506_82426a54","line":301,"in_reply_to":"bef0db62_05247dad","updated":"2024-07-17 08:03:12.000000000","message":"Hi Lukas , It seemed better to have it in the same test as there was only one assert in the test and metadata verification was being done by function in the base","commit_id":"e27a9d6221734420ccf73f8f6278c0368a65dcc3"}],"tempest/api/compute/servers/test_device_tagging.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2455ac5d2d383dc6425e72629dc34eb174ce335e","unresolved":true,"context_lines":[{"line_number":64,"context_line":"                                  dhcp\u003dTrue)"},{"line_number":65,"context_line":"        super(DeviceTaggingBase, cls).setup_credentials()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def verify_metadata_from_api(self, server, ssh_client, verify_method):"},{"line_number":68,"context_line":"        md_url \u003d \u0027http://169.254.169.254/openstack/latest/meta_data.json\u0027"},{"line_number":69,"context_line":"        LOG.info(\u0027Attempting to verify tagged devices in server %s via \u0027"},{"line_number":70,"context_line":"                 \u0027the metadata service: %s\u0027, server[\u0027id\u0027], md_url)"}],"source_content_type":"text/x-python","patch_set":20,"id":"79070a26_2ed77a1f","side":"PARENT","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":32},"updated":"2024-07-04 05:23:19.000000000","message":"I think it should not be moved to base.\nany particular reason to move this, instead of inheriting to added test ?","commit_id":"3619d297d57c719d2f297f16e8867b5b4f7abf20"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"2886498de89ce77f85fc4105f66e8e30029b8b93","unresolved":true,"context_lines":[{"line_number":64,"context_line":"                                  dhcp\u003dTrue)"},{"line_number":65,"context_line":"        super(DeviceTaggingBase, cls).setup_credentials()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def verify_metadata_from_api(self, server, ssh_client, verify_method):"},{"line_number":68,"context_line":"        md_url \u003d \u0027http://169.254.169.254/openstack/latest/meta_data.json\u0027"},{"line_number":69,"context_line":"        LOG.info(\u0027Attempting to verify tagged devices in server %s via \u0027"},{"line_number":70,"context_line":"                 \u0027the metadata service: %s\u0027, server[\u0027id\u0027], md_url)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9329bb04_9ebb104c","side":"PARENT","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":32},"in_reply_to":"79070a26_2ed77a1f","updated":"2024-07-04 19:45:20.000000000","message":"As this function is now being used by multiple test cases I thought it would be a good idea to move this to base as we are already inheriting from base in both the cases where this function is being used to verify metadata and also more tests verifying the metadata can also leverage this in future","commit_id":"3619d297d57c719d2f297f16e8867b5b4f7abf20"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"0518d5e5596624fd541b91b994b52dff41c24a5a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                  dhcp\u003dTrue)"},{"line_number":65,"context_line":"        super(DeviceTaggingBase, cls).setup_credentials()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def verify_metadata_from_api(self, server, ssh_client, verify_method):"},{"line_number":68,"context_line":"        md_url \u003d \u0027http://169.254.169.254/openstack/latest/meta_data.json\u0027"},{"line_number":69,"context_line":"        LOG.info(\u0027Attempting to verify tagged devices in server %s via \u0027"},{"line_number":70,"context_line":"                 \u0027the metadata service: %s\u0027, server[\u0027id\u0027], md_url)"}],"source_content_type":"text/x-python","patch_set":20,"id":"e0bdc16e_bdf05485","side":"PARENT","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":32},"in_reply_to":"9329bb04_9ebb104c","updated":"2024-07-17 08:03:12.000000000","message":"Done","commit_id":"3619d297d57c719d2f297f16e8867b5b4f7abf20"}],"tempest/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70e1a21ee12319db87914883df47d8a7850a1377","unresolved":true,"context_lines":[{"line_number":457,"context_line":"                     \"changed that in Wallaby cycle, if your cloud is older \""},{"line_number":458,"context_line":"                     \"than wallaby then you can keep/make it False.\"),"},{"line_number":459,"context_line":"    cfg.StrOpt(\u0027dhcp_domain\u0027,"},{"line_number":460,"context_line":"               default\u003d\u0027novalocal\u0027,"},{"line_number":461,"context_line":"               help\u003d\"Configure a fully-qualified domain name for instance \""},{"line_number":462,"context_line":"                    \"hostnames. The value is suffixed to instance hostname \""},{"line_number":463,"context_line":"                    \"from the database to construct the hostname that \""}],"source_content_type":"text/x-python","patch_set":20,"id":"845d8bbb_934a9538","line":460,"range":{"start_line":460,"start_character":24,"end_line":460,"end_character":33},"updated":"2024-07-08 11:26:02.000000000","message":"this shoudl be \".novalocal\"","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"bf7b2d5837e7802f5d325b4e362f30f174727fd1","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                     \"changed that in Wallaby cycle, if your cloud is older \""},{"line_number":458,"context_line":"                     \"than wallaby then you can keep/make it False.\"),"},{"line_number":459,"context_line":"    cfg.StrOpt(\u0027dhcp_domain\u0027,"},{"line_number":460,"context_line":"               default\u003d\u0027novalocal\u0027,"},{"line_number":461,"context_line":"               help\u003d\"Configure a fully-qualified domain name for instance \""},{"line_number":462,"context_line":"                    \"hostnames. The value is suffixed to instance hostname \""},{"line_number":463,"context_line":"                    \"from the database to construct the hostname that \""}],"source_content_type":"text/x-python","patch_set":20,"id":"75591f99_b9aa9baf","line":460,"range":{"start_line":460,"start_character":24,"end_line":460,"end_character":33},"in_reply_to":"845d8bbb_934a9538","updated":"2024-07-15 13:51:54.000000000","message":"Done","commit_id":"1140628efcdc0ed72f7f71424eda6a00c9ab1ea6"}]}