)]}'
{"tempest/api/compute/admin/test_flavors_negative.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9d7c66c456d8f7eb6552f33e86bfdc0424243570","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def setUpClass(cls):"},{"line_number":34,"context_line":"        super(FlavorsAdminNegativeTestJSON, cls).setUpClass()"},{"line_number":35,"context_line":"        if not test.is_extension_enabled(\u0027OS-FLV-EXT-DATA\u0027, \u0027compute\u0027):"},{"line_number":36,"context_line":"            msg \u003d \"FlavorExtraData extension not enabled.\""},{"line_number":37,"context_line":"            raise cls.skipException(msg)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        cls.client \u003d cls.os_adm.flavors_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_da5f180d","line":36,"updated":"2014-05-09 09:55:54.000000000","message":"Missed to change the Alias in msg.","commit_id":"a8eea4623e57f2a9746d61e76876d49bed05e928"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"aeb8d44c65d8db54d6293a4d8caa4fea933729f9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def setUpClass(cls):"},{"line_number":34,"context_line":"        super(FlavorsAdminNegativeTestJSON, cls).setUpClass()"},{"line_number":35,"context_line":"        if not test.is_extension_enabled(\u0027OS-FLV-EXT-DATA\u0027, \u0027compute\u0027):"},{"line_number":36,"context_line":"            msg \u003d \"FlavorExtraData extension not enabled.\""},{"line_number":37,"context_line":"            raise cls.skipException(msg)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        cls.client \u003d cls.os_adm.flavors_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_2116eff1","line":36,"in_reply_to":"7adec928_da5f180d","updated":"2014-05-12 15:36:54.000000000","message":"Oh, nice catch.\nwill fix it.","commit_id":"a8eea4623e57f2a9746d61e76876d49bed05e928"}],"tempest/cmd/verify_tempest_config.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"28cb483adeaac379e7bf50b15f57fade32bde803","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    extensions_client \u003d get_extension_client(os, service)"},{"line_number":161,"context_line":"    __, resp \u003d extensions_client.list_extensions()"},{"line_number":162,"context_line":"    if isinstance(resp, dict):"},{"line_number":163,"context_line":"        if service in [\u0027nova\u0027, \u0027nova_v3\u0027]:"},{"line_number":164,"context_line":"            extensions \u003d map(lambda x: x[\u0027alias\u0027], resp[\u0027extensions\u0027])"},{"line_number":165,"context_line":"        # Neutron\u0027s extension \u0027name\u0027 field has is not a single word (it has"},{"line_number":166,"context_line":"        # spaces in the string) Since that can\u0027t be used for list option the"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ae8d1ca_7221a39e","line":163,"updated":"2014-05-29 08:20:57.000000000","message":"L164 and L170 are equal. What about \n\n    # Neutron\u0027s extension \u0027name\u0027 field has is not a single word (it has\n    # spaces in the string) Since that can\u0027t be used for list option the\n    # api_extension option in the network-feature-enabled group uses alias\n    # instead of name.\n    if service in [\u0027nova\u0027, \u0027nova_v3\u0027, \u0027neutron\u0027]:\n        extensions \u003d map(lambda x: x[\u0027alias\u0027], resp[\u0027extensions\u0027])\n    elif service \u003d \u0027swift\u0027:\n        ...","commit_id":"57394d50cedd5d0fd0f8c35fcd41ba657e4d1dee"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"bd5640b160463c07fd22a84a0efa0fff35b3148a","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    extensions_client \u003d get_extension_client(os, service)"},{"line_number":161,"context_line":"    __, resp \u003d extensions_client.list_extensions()"},{"line_number":162,"context_line":"    if isinstance(resp, dict):"},{"line_number":163,"context_line":"        if service in [\u0027nova\u0027, \u0027nova_v3\u0027]:"},{"line_number":164,"context_line":"            extensions \u003d map(lambda x: x[\u0027alias\u0027], resp[\u0027extensions\u0027])"},{"line_number":165,"context_line":"        # Neutron\u0027s extension \u0027name\u0027 field has is not a single word (it has"},{"line_number":166,"context_line":"        # spaces in the string) Since that can\u0027t be used for list option the"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_3fdc1f73","line":163,"in_reply_to":"1ae5cdf2_33c4ce3f","updated":"2014-06-03 13:57:07.000000000","message":"I think a merge of the two would be fine and just say that for both nova and neutron we use the alias name rather than the \u0027name\u0027 field because the alias is considered to be the canonical name. Don\u0027t need to go into the details for neutron and nova here.","commit_id":"57394d50cedd5d0fd0f8c35fcd41ba657e4d1dee"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"208092453048dbbc291e8ba7446cf994c057cf31","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    extensions_client \u003d get_extension_client(os, service)"},{"line_number":161,"context_line":"    __, resp \u003d extensions_client.list_extensions()"},{"line_number":162,"context_line":"    if isinstance(resp, dict):"},{"line_number":163,"context_line":"        if service in [\u0027nova\u0027, \u0027nova_v3\u0027]:"},{"line_number":164,"context_line":"            extensions \u003d map(lambda x: x[\u0027alias\u0027], resp[\u0027extensions\u0027])"},{"line_number":165,"context_line":"        # Neutron\u0027s extension \u0027name\u0027 field has is not a single word (it has"},{"line_number":166,"context_line":"        # spaces in the string) Since that can\u0027t be used for list option the"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_15fe48ae","line":163,"in_reply_to":"1ae5cdf2_3fdc1f73","updated":"2014-06-04 07:43:28.000000000","message":"Yaroslav, Chris,\n\nThanks for your comments, I got it.\nI will change here in the next patch.","commit_id":"57394d50cedd5d0fd0f8c35fcd41ba657e4d1dee"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"8203bdb438d6e4bca48f063592da1214ef86731c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    extensions_client \u003d get_extension_client(os, service)"},{"line_number":161,"context_line":"    __, resp \u003d extensions_client.list_extensions()"},{"line_number":162,"context_line":"    if isinstance(resp, dict):"},{"line_number":163,"context_line":"        if service in [\u0027nova\u0027, \u0027nova_v3\u0027]:"},{"line_number":164,"context_line":"            extensions \u003d map(lambda x: x[\u0027alias\u0027], resp[\u0027extensions\u0027])"},{"line_number":165,"context_line":"        # Neutron\u0027s extension \u0027name\u0027 field has is not a single word (it has"},{"line_number":166,"context_line":"        # spaces in the string) Since that can\u0027t be used for list option the"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_33c4ce3f","line":163,"in_reply_to":"1ae5cdf2_c76cd139","updated":"2014-05-30 09:51:29.000000000","message":"Not native speaker, but may be something like this\n\n    # Extension \u0027name\u0027 field of one of services (Neutron) has is not\n    # a single word (it has spaces in the string) Since that can\u0027t be used\n    # for list option the api_extension option in\n    # the network-feature-enabled group uses alias instead of name.\n\nI think readability will be good with such comment.\n\nI am not sure, but it seems there is a typo in this sentence \n\n    Neutron\u0027s extension \u0027name\u0027 field HAS IS not a single word ...\n\nI think\n\n    Neutron\u0027s extension \u0027name\u0027 field IS not a single word ...","commit_id":"57394d50cedd5d0fd0f8c35fcd41ba657e4d1dee"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"19dd4fc83ccca724818e9954b70c6c17d8bbbf9b","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    extensions_client \u003d get_extension_client(os, service)"},{"line_number":161,"context_line":"    __, resp \u003d extensions_client.list_extensions()"},{"line_number":162,"context_line":"    if isinstance(resp, dict):"},{"line_number":163,"context_line":"        if service in [\u0027nova\u0027, \u0027nova_v3\u0027]:"},{"line_number":164,"context_line":"            extensions \u003d map(lambda x: x[\u0027alias\u0027], resp[\u0027extensions\u0027])"},{"line_number":165,"context_line":"        # Neutron\u0027s extension \u0027name\u0027 field has is not a single word (it has"},{"line_number":166,"context_line":"        # spaces in the string) Since that can\u0027t be used for list option the"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_c76cd139","line":163,"in_reply_to":"3ae8d1ca_7221a39e","updated":"2014-05-30 02:28:07.000000000","message":"Yep, I did think the same thing, but I\u0027ve created current implementation because the following comment is only for neutron and if merging them, the readability would be wrong I felt.","commit_id":"57394d50cedd5d0fd0f8c35fcd41ba657e4d1dee"}]}