)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"149542f7f56c11118c5eae86dd73f47cbd1f7a17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2e18fe32_de44d866","updated":"2024-07-02 05:45:44.000000000","message":"Cinder logs to verify the operation is working\n\n2024-07-01 19:57:46.160183 | controller | {1} tempest.api.image.v2.test_images_dependency.ImageDependencyTests.test_image_volume_server_snapshot_dependency [41.467735s] ... ok\n\nVOLUME CREATE: req-88a97d06-1f28-4954-b524-8f692897a995\n\n\u0027volume_id\u0027: \u002712f83c7c-3248-4782-bf5b-cdf851d5619d\u0027\n\nJul 01 19:57:16.045517 np0037851357 cinder-volume[89445]: INFO cinder.volume.manager [None req-88a97d06-1f28-4954-b524-8f692897a995 tempest-ImageDependencyTests-248518901 None] Created volume successfully.\n\n\nATTACHMENT: req-00f1a00f-ffe9-4832-88b0-9446052e0c26\n\nJul 01 19:57:28.691569 np0037851357 cinder-volume[89445]: INFO cinder.volume.manager [req-00f1a00f-ffe9-4832-88b0-9446052e0c26 req-35f00009-0ebb-4cbb-a0e7-8cf9ed94d06c tempest-ImageDependencyTests-248518901 None] attachment_update completed successfully.\n\nSNAPSHOT CREATE: req-4193488f-3a3b-473d-af0f-091f0988c9c3\n\nJul 01 19:57:41.540173 np0037851357 cinder-volume[89445]: INFO cinder.volume.manager [req-4193488f-3a3b-473d-af0f-091f0988c9c3 req-eecef6ba-4c9d-4bda-b5d4-590b1d71e16a tempest-ImageDependencyTests-248518901 None] Create snapshot completed successfully\n\nSNAPSHOT DELETE: req-af24120a-aea7-461c-9e18-a038c3538127\n\nJul 01 19:57:45.035402 np0037851357 cinder-volume[89445]: INFO cinder.volume.manager [None req-af24120a-aea7-461c-9e18-a038c3538127 tempest-ImageDependencyTests-248518901 None] Delete snapshot completed successfully.\n\nVOLUME DELETE: req-1ff3b08e-3cbb-419b-be27-346ead155e82\n\nJul 01 19:58:36.562816 np0037851357 cinder-volume[89445]: INFO cinder.volume.manager [req-1ff3b08e-3cbb-419b-be27-346ead155e82 req-f1a4bc5b-6c61-453c-97d0-0cfb60764812 tempest-ImageDependencyTests-248518901 None] Deleted volume successfully.","commit_id":"ddf9d600694659fcb2c323f693c5aa24d8c1427a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ec07104a9dc9ff5b5f69d5bf7b74c2f5d8d685a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6eeb0cbf_73b65e29","updated":"2024-07-02 05:44:30.000000000","message":"Tempest logs to verify the test is working\n\nImage create\n2024-07-01 19:57:05.593 96175 INFO tempest.lib.common.rest_client [req-47348fc9-6871-4797-a500-91c351e9a0ee req-47348fc9-6871-4797-a500-91c351e9a0ee ] Request (ImageDependencyTests:test_image_volume_server_snapshot_dependency): 201 POST https://10.209.100.57/image/v2/images 0.909s\n\nImage upload\n2024-07-01 19:57:07.460 96175 INFO tempest.lib.common.rest_client [req-c10338f0-b789-418d-a160-3209bb1cd58e req-c10338f0-b789-418d-a160-3209bb1cd58e ] Request (ImageDependencyTests:test_image_volume_server_snapshot_dependency): 204 PUT https://10.209.100.57/image/v2/images/c16c3b72-dbeb-483e-9510-e508bb7c81d8/file 1.865s\n\nVolume create\n2024-07-01 19:57:07.919 96175 INFO tempest.lib.common.rest_client [req-88a97d06-1f28-4954-b524-8f692897a995 req-88a97d06-1f28-4954-b524-8f692897a995 ] Request (ImageDependencyTests:test_image_volume_server_snapshot_dependency): 202 POST https://10.209.100.57/volume/v3/996e26a17eab47ba989363f098a04878/volumes 0.386s\n\nServer create\n2024-07-01 19:57:17.213 96175 INFO tempest.lib.common.rest_client [req-00f1a00f-ffe9-4832-88b0-9446052e0c26 req-00f1a00f-ffe9-4832-88b0-9446052e0c26 ] Request (ImageDependencyTests:test_image_volume_server_snapshot_dependency): 202 POST https://10.209.100.57/compute/v2.1/servers 0.738s\n\nServer Snapshot\n2024-07-01 19:57:43.247 96175 INFO tempest.lib.common.rest_client [req-4193488f-3a3b-473d-af0f-091f0988c9c3 req-4193488f-3a3b-473d-af0f-091f0988c9c3 ] Request (ImageDependencyTests:test_image_volume_server_snapshot_dependency): 202 POST https://10.209.100.57/compute/v2.1/servers/e364d560-c48b-4c0d-a44f-ead75a9c1f98/action 3.995s\n\nDelete Image\n2024-07-01 19:57:43.563 96175 INFO tempest.lib.common.rest_client [req-228b040e-703f-4d3f-9f4b-17af41bc9f00 req-228b040e-703f-4d3f-9f4b-17af41bc9f00 ] Request (ImageDependencyTests:test_image_volume_server_snapshot_dependency): 204 DELETE https://10.209.100.57/image/v2/images/c16c3b72-dbeb-483e-9510-e508bb7c81d8 0.219s","commit_id":"ddf9d600694659fcb2c323f693c5aa24d8c1427a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f0dc9f3935d306d13f98def546b8b6e6fa876558","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1c97ac70_6a9a5c14","updated":"2024-07-04 10:37:11.000000000","message":"Thanks Maxim for the review, i can address the concerns in a followup.","commit_id":"ea914a22e2cc447d5916e187f4aba110237dcd60"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dda3a458bca41d2d38aa84c718c09f67755ec522","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"582cc801_2dcaeb47","updated":"2024-07-04 17:03:09.000000000","message":"lgtm, thanks","commit_id":"ea914a22e2cc447d5916e187f4aba110237dcd60"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"23fc33229f802fbfdae7666e1125c0e8e2c30c31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"531abb61_4565e68d","updated":"2024-07-04 18:40:51.000000000","message":"thanks","commit_id":"ea914a22e2cc447d5916e187f4aba110237dcd60"}],"tempest/api/image/v2/test_images_dependency.py":[{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"d5e67d44832be0f4158f39b990820f2d837b532c","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        waiters.wait_for_image_status("},{"line_number":74,"context_line":"            self.client, image[\u0027id\u0027], \u0027active\u0027)"},{"line_number":75,"context_line":"        if bfv:"},{"line_number":76,"context_line":"            # Create instance"},{"line_number":77,"context_line":"            instance \u003d self.create_test_server("},{"line_number":78,"context_line":"                name\u003d\u0027instance-depend-image\u0027,"},{"line_number":79,"context_line":"                image_id\u003dimage[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3c838251_f4e3ff11","line":76,"range":{"start_line":76,"start_character":15,"end_line":76,"end_character":29},"updated":"2024-07-03 21:18:09.000000000","message":"Should we change it to \"Create instance with attached volume\"?","commit_id":"ea914a22e2cc447d5916e187f4aba110237dcd60"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f0dc9f3935d306d13f98def546b8b6e6fa876558","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        waiters.wait_for_image_status("},{"line_number":74,"context_line":"            self.client, image[\u0027id\u0027], \u0027active\u0027)"},{"line_number":75,"context_line":"        if bfv:"},{"line_number":76,"context_line":"            # Create instance"},{"line_number":77,"context_line":"            instance \u003d self.create_test_server("},{"line_number":78,"context_line":"                name\u003d\u0027instance-depend-image\u0027,"},{"line_number":79,"context_line":"                image_id\u003dimage[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"f210b6c3_5907ed7f","line":76,"range":{"start_line":76,"start_character":15,"end_line":76,"end_character":29},"in_reply_to":"3c838251_f4e3ff11","updated":"2024-07-04 10:37:11.000000000","message":"Probably create instance with boot from volume would better describe it, i can address it but in a followup since it doesn\u0027t change the functionality of the test","commit_id":"ea914a22e2cc447d5916e187f4aba110237dcd60"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dda3a458bca41d2d38aa84c718c09f67755ec522","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        waiters.wait_for_image_status("},{"line_number":74,"context_line":"            self.client, image[\u0027id\u0027], \u0027active\u0027)"},{"line_number":75,"context_line":"        if bfv:"},{"line_number":76,"context_line":"            # Create instance"},{"line_number":77,"context_line":"            instance \u003d self.create_test_server("},{"line_number":78,"context_line":"                name\u003d\u0027instance-depend-image\u0027,"},{"line_number":79,"context_line":"                image_id\u003dimage[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"04bf9084_d661e271","line":76,"range":{"start_line":76,"start_character":15,"end_line":76,"end_character":29},"in_reply_to":"f210b6c3_5907ed7f","updated":"2024-07-04 17:03:09.000000000","message":"yeah, i think it is clear from volume_backed parameter","commit_id":"ea914a22e2cc447d5916e187f4aba110237dcd60"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"d5e67d44832be0f4158f39b990820f2d837b532c","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        We are going to perform the following steps in the test:"},{"line_number":120,"context_line":"        * Create image"},{"line_number":121,"context_line":"        * Create a bootable volume from Image"},{"line_number":122,"context_line":"        * Launch an instance from the bootable volume"},{"line_number":123,"context_line":"        * Take snapshot of the instance -- which creates the volume snapshot"},{"line_number":124,"context_line":"        * Delete the image."}],"source_content_type":"text/x-python","patch_set":3,"id":"8ee9a9d8_48b63933","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":2},"updated":"2024-07-03 21:18:09.000000000","message":"I think we didn\u0027t create bootable volume from image here","commit_id":"ea914a22e2cc447d5916e187f4aba110237dcd60"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dda3a458bca41d2d38aa84c718c09f67755ec522","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        We are going to perform the following steps in the test:"},{"line_number":120,"context_line":"        * Create image"},{"line_number":121,"context_line":"        * Create a bootable volume from Image"},{"line_number":122,"context_line":"        * Launch an instance from the bootable volume"},{"line_number":123,"context_line":"        * Take snapshot of the instance -- which creates the volume snapshot"},{"line_number":124,"context_line":"        * Delete the image."}],"source_content_type":"text/x-python","patch_set":3,"id":"c6a158d3_9446bf95","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":2},"in_reply_to":"86fdbf71_d2e1720f","updated":"2024-07-04 17:03:09.000000000","message":"it is done here https://github.com/openstack/tempest/blob/4bae4b08cc04a8edaed325726684d6318db762f4/tempest/common/compute.py#L248","commit_id":"ea914a22e2cc447d5916e187f4aba110237dcd60"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f0dc9f3935d306d13f98def546b8b6e6fa876558","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        We are going to perform the following steps in the test:"},{"line_number":120,"context_line":"        * Create image"},{"line_number":121,"context_line":"        * Create a bootable volume from Image"},{"line_number":122,"context_line":"        * Launch an instance from the bootable volume"},{"line_number":123,"context_line":"        * Take snapshot of the instance -- which creates the volume snapshot"},{"line_number":124,"context_line":"        * Delete the image."}],"source_content_type":"text/x-python","patch_set":3,"id":"86fdbf71_d2e1720f","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":2},"in_reply_to":"8ee9a9d8_48b63933","updated":"2024-07-04 10:37:11.000000000","message":"We do create it.\nthe operation is launch an instance from bootable volume providing an image and in the background, we first create a bootable volume from image and then launch instance from it. It\u0027s visible in the log analysis I\u0027ve posted as comments.","commit_id":"ea914a22e2cc447d5916e187f4aba110237dcd60"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"d5e67d44832be0f4158f39b990820f2d837b532c","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        We are going to perform the following steps in the test:"},{"line_number":120,"context_line":"        * Create image"},{"line_number":121,"context_line":"        * Create a bootable volume from Image"},{"line_number":122,"context_line":"        * Launch an instance from the bootable volume"},{"line_number":123,"context_line":"        * Take snapshot of the instance -- which creates the volume snapshot"},{"line_number":124,"context_line":"        * Delete the image."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"cc87d77b_d7a0c91b","line":122,"range":{"start_line":122,"start_character":10,"end_line":122,"end_character":16},"updated":"2024-07-03 21:18:09.000000000","message":"Should we changed it to \"Launch an instance with attached volume\"?","commit_id":"ea914a22e2cc447d5916e187f4aba110237dcd60"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dda3a458bca41d2d38aa84c718c09f67755ec522","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        We are going to perform the following steps in the test:"},{"line_number":120,"context_line":"        * Create image"},{"line_number":121,"context_line":"        * Create a bootable volume from Image"},{"line_number":122,"context_line":"        * Launch an instance from the bootable volume"},{"line_number":123,"context_line":"        * Take snapshot of the instance -- which creates the volume snapshot"},{"line_number":124,"context_line":"        * Delete the image."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7e0ae65b_6e16c9be","line":122,"range":{"start_line":122,"start_character":10,"end_line":122,"end_character":16},"in_reply_to":"65664ca3_cd033c4c","updated":"2024-07-04 17:03:09.000000000","message":"both are different things and as Rajat mentioned \u0027from the bootable volume\u0027 is more clear.","commit_id":"ea914a22e2cc447d5916e187f4aba110237dcd60"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f0dc9f3935d306d13f98def546b8b6e6fa876558","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        We are going to perform the following steps in the test:"},{"line_number":120,"context_line":"        * Create image"},{"line_number":121,"context_line":"        * Create a bootable volume from Image"},{"line_number":122,"context_line":"        * Launch an instance from the bootable volume"},{"line_number":123,"context_line":"        * Take snapshot of the instance -- which creates the volume snapshot"},{"line_number":124,"context_line":"        * Delete the image."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"65664ca3_cd033c4c","line":122,"range":{"start_line":122,"start_character":10,"end_line":122,"end_character":16},"in_reply_to":"cc87d77b_d7a0c91b","updated":"2024-07-04 10:37:11.000000000","message":"I think attached volume sounds like an external data volume attached to the instance whereas we are doing a boot from volume operation so launching instance from bootable volume sounds right IMO","commit_id":"ea914a22e2cc447d5916e187f4aba110237dcd60"}]}