)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"158a09b97d060ad2849d2244582a4a8d27b01bb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37ccfb27_a42160e3","updated":"2024-07-15 10:41:01.000000000","message":"Thanks for the review !","commit_id":"93ff2bb11fc3b72ff06e07fe367354f16c01b297"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"26b4f96a2403a017c8973dca8099ef422e650d10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d8c7ab14_708a947f","updated":"2024-07-16 06:45:55.000000000","message":"This is required for new location API which has introduced async workflow to calculate hash and checksum for snapshot images with nova and glance using rbd as backend.","commit_id":"953940288c51e2c035a21aee518a925caabe7549"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1b9809edb160249e4e183778b06371570c661345","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b0019df6_4c30890b","updated":"2024-07-19 05:47:14.000000000","message":"lgtm","commit_id":"953940288c51e2c035a21aee518a925caabe7549"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"06b8f4f4ee9492e9da319e7a74547f47f3745a4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"72c0fff3_65462be5","updated":"2024-07-18 17:57:41.000000000","message":"thanks, lgtm","commit_id":"953940288c51e2c035a21aee518a925caabe7549"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8a7e37b3ad6e6fec6f564d2cdf4b5f3b12a0d6f5","unresolved":true,"context_lines":[{"line_number":611,"context_line":"        # import task to complete."},{"line_number":612,"context_line":"        # This should work with old location API since we don\u0027t fail if there"},{"line_number":613,"context_line":"        # are no tasks for the image"},{"line_number":614,"context_line":"        waiters.wait_for_image_tasks_status(self.images_client,"},{"line_number":615,"context_line":"                                            image1_id, \u0027success\u0027)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        backup2 \u003d data_utils.rand_name("},{"line_number":618,"context_line":"            prefix\u003dCONF.resource_name_prefix, name\u003d\u0027backup-2\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"70d0ce3a_006a0f11","line":615,"range":{"start_line":614,"start_character":8,"end_line":615,"end_character":65},"updated":"2024-07-15 08:24:23.000000000","message":"I don\u0027t think it is required here where it is not using location api because for location API image becomes active immediately and does not requires to wait for becoming active.","commit_id":"93ff2bb11fc3b72ff06e07fe367354f16c01b297"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"26b4f96a2403a017c8973dca8099ef422e650d10","unresolved":true,"context_lines":[{"line_number":611,"context_line":"        # import task to complete."},{"line_number":612,"context_line":"        # This should work with old location API since we don\u0027t fail if there"},{"line_number":613,"context_line":"        # are no tasks for the image"},{"line_number":614,"context_line":"        waiters.wait_for_image_tasks_status(self.images_client,"},{"line_number":615,"context_line":"                                            image1_id, \u0027success\u0027)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        backup2 \u003d data_utils.rand_name("},{"line_number":618,"context_line":"            prefix\u003dCONF.resource_name_prefix, name\u003d\u0027backup-2\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba39a617_83cb0e84","line":615,"range":{"start_line":614,"start_character":8,"end_line":615,"end_character":65},"in_reply_to":"2f4d14bc_c502cd81","updated":"2024-07-16 06:45:55.000000000","message":"Ack, I think this wait for active here is for other backends than ceph where location API is not used.","commit_id":"93ff2bb11fc3b72ff06e07fe367354f16c01b297"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"158a09b97d060ad2849d2244582a4a8d27b01bb0","unresolved":true,"context_lines":[{"line_number":611,"context_line":"        # import task to complete."},{"line_number":612,"context_line":"        # This should work with old location API since we don\u0027t fail if there"},{"line_number":613,"context_line":"        # are no tasks for the image"},{"line_number":614,"context_line":"        waiters.wait_for_image_tasks_status(self.images_client,"},{"line_number":615,"context_line":"                                            image1_id, \u0027success\u0027)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        backup2 \u003d data_utils.rand_name("},{"line_number":618,"context_line":"            prefix\u003dCONF.resource_name_prefix, name\u003d\u0027backup-2\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2f4d14bc_c502cd81","line":615,"range":{"start_line":614,"start_character":8,"end_line":615,"end_character":65},"in_reply_to":"70d0ce3a_006a0f11","updated":"2024-07-15 10:41:01.000000000","message":"No, it does. during backup creation, location api is called. I have tested this locally and confirmed that all the tasks of location_import runs thrice.\n\nI\u0027m also not sure why the wait_for_image_status() call is here.","commit_id":"93ff2bb11fc3b72ff06e07fe367354f16c01b297"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8a7e37b3ad6e6fec6f564d2cdf4b5f3b12a0d6f5","unresolved":true,"context_lines":[{"line_number":630,"context_line":"        waiters.wait_for_image_status(glance_client,"},{"line_number":631,"context_line":"                                      image2_id, \u0027active\u0027)"},{"line_number":632,"context_line":"        waiters.wait_for_image_tasks_status(self.images_client,"},{"line_number":633,"context_line":"                                            image2_id, \u0027success\u0027)"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        # verify they have been created"},{"line_number":636,"context_line":"        properties \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"d7f13fa0_4478d6f3","line":633,"updated":"2024-07-15 08:24:23.000000000","message":"ditto","commit_id":"93ff2bb11fc3b72ff06e07fe367354f16c01b297"}]}