)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"cfc47fcdaa11a2e70a4ce22100b2fbabe84c405b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7b01322f_db46c521","updated":"2024-07-24 19:39:16.000000000","message":"There are several other tests that filter around \u0027-ironic\u0027, would like to update them as well for this patch.","commit_id":"cd59e99b31d7bbd56ae93552d5f58d2b160cee97"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"807170b8c377b03417f3e9fcc0d42f402b6bb20c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"848cabb4_530c0c60","updated":"2024-07-24 06:55:10.000000000","message":"looks good.","commit_id":"cd59e99b31d7bbd56ae93552d5f58d2b160cee97"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"ae4fd8b4857cc32a385afa5a8019141c79c3c664","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fbf8e6e2_24c25d4b","updated":"2024-07-24 13:24:31.000000000","message":"recheck","commit_id":"cd59e99b31d7bbd56ae93552d5f58d2b160cee97"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"179e5af3ddab00db56d42d42b5459142a5259038","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"78df86e6_0b23a5b8","updated":"2024-07-24 08:24:40.000000000","message":"recheck unrealted fail\nAssertionError: 5.800000000000001 not less than or equal to 5.0 : Downtime of 5.800000000000001 seconds is higher than expected \u00275.0\u0027","commit_id":"cd59e99b31d7bbd56ae93552d5f58d2b160cee97"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"451cba235047e955e4e205ea3596ea817f34789d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"86303be6_abd554ac","updated":"2024-07-24 18:13:01.000000000","message":"recheck unrelated tempest failures","commit_id":"cd59e99b31d7bbd56ae93552d5f58d2b160cee97"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"afd4b548cb1a7390d572a711fd32eb8df79f1d07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae5c91fe_09c9a64a","updated":"2024-07-24 08:28:39.000000000","message":"this works `Body: {\"unshelve\": {\"host\": \"nova-cell1-compute-ironic-compute-0\"}}`\ncan be merged now, not sure, why its in progress.","commit_id":"cd59e99b31d7bbd56ae93552d5f58d2b160cee97"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ccf9c072cc881a71015f26d88aa6109ff6d0b8ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bc6bb378_7c2dcb9c","updated":"2024-08-01 10:10:43.000000000","message":"Thoughts inline, not sure I\u0027m -1 over them, but not +1 either...","commit_id":"1ba68c0376f9d3dbd6f87896d0259bfd176db70c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"15660229d26c587d2a7b373d0fbad5c3bec7dc4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c2a97ba7_0c97ef8d","updated":"2024-07-25 12:23:45.000000000","message":"even better.","commit_id":"1ba68c0376f9d3dbd6f87896d0259bfd176db70c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"80368c4b70ba7d954f6c2d762a174905056c7666","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"36e2c425_d6979a18","updated":"2024-07-29 14:09:53.000000000","message":"recheck","commit_id":"1ba68c0376f9d3dbd6f87896d0259bfd176db70c"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"c21c8f0ae0bbfc13537e9398ea287484e5711246","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8cdb3af5_3e0fdda3","updated":"2024-08-02 11:35:07.000000000","message":"also deployment fail in \nneutron-ovs-grenade-multinode","commit_id":"8d1c5f32df8ac97f5455555589b9a7bbe4467d76"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"8bc83771fe4994b88e370d2df7e439cce4ca8bbf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"99596fc6_4be2f5ca","updated":"2024-08-02 11:53:30.000000000","message":"neutron-ovs-grenade-multinode is not deployment issue, noticed it failed with same error every time,\nreason is same, `target_hostname_pattern_to_avoid`\nhttps://zuul.opendev.org/t/openstack/build/c3e08342763f438eaab652511c184930/log/controller/logs/grenade.sh_log.txt#450","commit_id":"8d1c5f32df8ac97f5455555589b9a7bbe4467d76"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"accaa177dbb35233b90ad9f657c45f626444a33d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5ee3e977_397dc06d","updated":"2024-08-01 17:07:46.000000000","message":"recheck","commit_id":"8d1c5f32df8ac97f5455555589b9a7bbe4467d76"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"fcee47e6d07ecbbaf8bb6f5f1dfe35003a39cf29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6d46cc09_2911e7b9","updated":"2024-08-01 19:16:19.000000000","message":"recheck","commit_id":"8d1c5f32df8ac97f5455555589b9a7bbe4467d76"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"7120a644b81bfefe08e4a474baf0c512086acd74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c7b77562_81996a34","updated":"2024-08-01 21:17:04.000000000","message":"recheck","commit_id":"8d1c5f32df8ac97f5455555589b9a7bbe4467d76"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"acdd29c020ac34ed345cf8bb6b9ac4304f0e3d02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b84d273b_5731aeee","updated":"2024-08-02 10:01:22.000000000","message":"recheck unrealted deployment fail neutron-ovs-grenade-multinode \n\nneed for\ntempest.lib.exceptions.TimeoutException: Request timed out\nDetails: (UnshelveToHostMultiNodesTest:test_unshelve_to_specific_host)","commit_id":"8d1c5f32df8ac97f5455555589b9a7bbe4467d76"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"abd575c35c3422883963be256a0dc21659d5a364","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1e3574e6_3ca358fe","in_reply_to":"99596fc6_4be2f5ca","updated":"2024-08-16 14:18:33.000000000","message":"Done","commit_id":"8d1c5f32df8ac97f5455555589b9a7bbe4467d76"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"d3fed8065599b46f7cb65f67903342201189e7e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"85e4c9aa_c807484d","updated":"2024-08-13 20:34:56.000000000","message":"Thanks for the review!","commit_id":"4051bb515b953bef24c6ac34d84552b119764d81"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"90317dd2595b78e9a24ed7044881f49b230cdfb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6bcab0ae_6853b190","updated":"2024-08-13 20:13:04.000000000","message":"Thanks. overall idea lgtm. one suggestion in config name/help msg.\n\nAlso, please add a release notes about this new config option.","commit_id":"4051bb515b953bef24c6ac34d84552b119764d81"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"9e122b24c8c26632869cfee65a68637fb5b1119a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"720ee4ec_9c76018d","updated":"2024-08-05 02:44:06.000000000","message":"lgtm","commit_id":"4051bb515b953bef24c6ac34d84552b119764d81"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"cc7c640a7bcfb0263cf35a71b2961be76c879392","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bb8f88f3_81714d89","updated":"2024-08-13 19:49:18.000000000","message":"lgtm, simple change - hardcoded values replaced by a new config opt","commit_id":"4051bb515b953bef24c6ac34d84552b119764d81"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"9bd4974205112f9a91727a770f334d38f3f25e9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b69cd1ad_62c52a36","updated":"2024-08-15 19:51:56.000000000","message":"Updated based on @ghanshyammann.com, -1 for now to address release notes, I actually do not think I\u0027ve ever done it before for tempest so need to figure out the process 😊","commit_id":"2006219881cb692057b61c0587ab2b9413b14125"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"c20886f94b75596a0f758d6459d4f0ddab1ccd2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9692ebad_a11d523a","in_reply_to":"02866e2b_32d9c806","updated":"2024-08-16 14:07:55.000000000","message":"Awesome thanks for the help Martin!","commit_id":"2006219881cb692057b61c0587ab2b9413b14125"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"abd575c35c3422883963be256a0dc21659d5a364","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"606cd004_e1af0caf","in_reply_to":"02866e2b_32d9c806","updated":"2024-08-16 14:18:33.000000000","message":"Done","commit_id":"2006219881cb692057b61c0587ab2b9413b14125"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"76152cffff22dfdde2c9677ead818fb6f1cfe31f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"02866e2b_32d9c806","in_reply_to":"b69cd1ad_62c52a36","updated":"2024-08-15 21:42:57.000000000","message":"https://docs.openstack.org/reno/2.1.1/usage.html\n\nI usually run \u0027tox -ereleasenotes\u0027 to install required deps (I usually kill the process right after installation of all the deps so that i don\u0027t have to wait while all release notes are generated.\n\nThen I source the env (source .tox/releasenotes/bin/activate) and run \"reno new \u003cname of the release note\u003e) .. and as the last step I edit the release note based on https://docs.openstack.org/reno/2.1.1/usage.html#editing-a-release-note (delete all categories that don\u0027t apply)","commit_id":"2006219881cb692057b61c0587ab2b9413b14125"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e654a6034eefdd452b8ddeb66f6354db611fedae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"75c1a313_759f0c39","updated":"2024-08-16 17:45:07.000000000","message":"lgtm thanks. considering martin previous +2, I am approving it directly.","commit_id":"9d8d631bdd6ba56d84bee75788cd0c1a3692cf1a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8aca664f556abbb304e7c40ce3e4c03002addd92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7dfd60e0_ba17da0f","updated":"2024-08-20 15:28:42.000000000","message":"recheck .. network downtime was higher than expected \u00275.0\u0027 in one of the tests","commit_id":"9d8d631bdd6ba56d84bee75788cd0c1a3692cf1a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"63156714b1b6e60f15dace08995e0230768eb44a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"215f80e8_07388123","updated":"2024-08-18 09:26:28.000000000","message":"recheck ssh timeout","commit_id":"9d8d631bdd6ba56d84bee75788cd0c1a3692cf1a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0eca19b14575ee5cd53deec49ae08fa650cadfb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"93b75757_3d9234a4","updated":"2024-08-20 10:03:31.000000000","message":"recheck weird issue in the tox-cover job, no way the test coverage got several % points lower by this patch o.O","commit_id":"9d8d631bdd6ba56d84bee75788cd0c1a3692cf1a"}],"tempest/api/compute/base.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ccf9c072cc881a71015f26d88aa6109ff6d0b8ac","unresolved":true,"context_lines":[{"line_number":720,"context_line":"            binary\u003d\u0027nova-compute\u0027)[\u0027services\u0027]"},{"line_number":721,"context_line":"        hosts \u003d []"},{"line_number":722,"context_line":"        for svc in svcs:"},{"line_number":723,"context_line":"            if CONF.compute.target_hostname_pattern_to_avoid in svc[\u0027host\u0027]:"},{"line_number":724,"context_line":"                continue"},{"line_number":725,"context_line":"            if svc[\u0027state\u0027] \u003d\u003d \u0027up\u0027 and svc[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027:"},{"line_number":726,"context_line":"                if CONF.compute.compute_volume_common_az:"}],"source_content_type":"text/x-python","patch_set":2,"id":"429cd5c0_1428b2d1","line":723,"updated":"2024-08-01 10:10:43.000000000","message":"Do we need a way to disable this entirely? The \"intuitive\" way would be to set this to the empty string, but that\u0027ll end up filtering _everything_, because\n\n    $ python\n    \u003e\u003e\u003e \u0027\u0027 in \u0027any string\u0027\n    True\n    \u003e\u003e\u003e","commit_id":"1ba68c0376f9d3dbd6f87896d0259bfd176db70c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"12a7b89999c9014df11e1edd1d7a2e90ae621771","unresolved":true,"context_lines":[{"line_number":720,"context_line":"            binary\u003d\u0027nova-compute\u0027)[\u0027services\u0027]"},{"line_number":721,"context_line":"        hosts \u003d []"},{"line_number":722,"context_line":"        for svc in svcs:"},{"line_number":723,"context_line":"            if CONF.compute.target_hostname_pattern_to_avoid in svc[\u0027host\u0027]:"},{"line_number":724,"context_line":"                continue"},{"line_number":725,"context_line":"            if svc[\u0027state\u0027] \u003d\u003d \u0027up\u0027 and svc[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027:"},{"line_number":726,"context_line":"                if CONF.compute.compute_volume_common_az:"}],"source_content_type":"text/x-python","patch_set":2,"id":"94e9d396_8c416813","line":723,"in_reply_to":"07ef89dd_4364183a","updated":"2024-08-01 13:31:29.000000000","message":"Yeah, I\u0027m not sure that this is an actual problem in practice (we used to just have \u0027-ironic\u0027 hardcoded, it can\u0027t get much worse than that), but wanted to raise it in case others had ideas.","commit_id":"1ba68c0376f9d3dbd6f87896d0259bfd176db70c"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"af7d6acc78b15bdcea38764f6559872554fd046e","unresolved":true,"context_lines":[{"line_number":720,"context_line":"            binary\u003d\u0027nova-compute\u0027)[\u0027services\u0027]"},{"line_number":721,"context_line":"        hosts \u003d []"},{"line_number":722,"context_line":"        for svc in svcs:"},{"line_number":723,"context_line":"            if CONF.compute.target_hostname_pattern_to_avoid in svc[\u0027host\u0027]:"},{"line_number":724,"context_line":"                continue"},{"line_number":725,"context_line":"            if svc[\u0027state\u0027] \u003d\u003d \u0027up\u0027 and svc[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027:"},{"line_number":726,"context_line":"                if CONF.compute.compute_volume_common_az:"}],"source_content_type":"text/x-python","patch_set":2,"id":"07ef89dd_4364183a","line":723,"in_reply_to":"429cd5c0_1428b2d1","updated":"2024-08-01 13:28:25.000000000","message":"An additional condition confirming length is greater than zero could work, it just starts to get verbose.","commit_id":"1ba68c0376f9d3dbd6f87896d0259bfd176db70c"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"3aea889bfd4ee48a7c220cea467d199817117b8e","unresolved":false,"context_lines":[{"line_number":720,"context_line":"            binary\u003d\u0027nova-compute\u0027)[\u0027services\u0027]"},{"line_number":721,"context_line":"        hosts \u003d []"},{"line_number":722,"context_line":"        for svc in svcs:"},{"line_number":723,"context_line":"            if CONF.compute.target_hostname_pattern_to_avoid in svc[\u0027host\u0027]:"},{"line_number":724,"context_line":"                continue"},{"line_number":725,"context_line":"            if svc[\u0027state\u0027] \u003d\u003d \u0027up\u0027 and svc[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027:"},{"line_number":726,"context_line":"                if CONF.compute.compute_volume_common_az:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ac0a32bd_fa003f23","line":723,"in_reply_to":"94e9d396_8c416813","updated":"2024-08-16 14:18:44.000000000","message":"Done","commit_id":"1ba68c0376f9d3dbd6f87896d0259bfd176db70c"}],"tempest/config.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ccf9c072cc881a71015f26d88aa6109ff6d0b8ac","unresolved":true,"context_lines":[{"line_number":418,"context_line":"               help\u003d\"Specify destination host for live-migration and cold\""},{"line_number":419,"context_line":"                    \" migration. If option is not set tests will use host\""},{"line_number":420,"context_line":"                    \" automatically.\"),"},{"line_number":421,"context_line":"    cfg.StrOpt(\u0027target_hostname_pattern_to_avoid\u0027,"},{"line_number":422,"context_line":"               default\u003d\u0027-ironic\u0027,"},{"line_number":423,"context_line":"               help\u003d\"When aggregating hypervisors that are currently not\""},{"line_number":424,"context_line":"               \" hosting the guest VM, avoid using Computes that contain\""}],"source_content_type":"text/x-python","patch_set":2,"id":"c0b21cd4_f21827a4","line":421,"updated":"2024-08-01 10:10:43.000000000","message":"nit: I\u0027d name this something like \u0027get_host_filter\u0027","commit_id":"1ba68c0376f9d3dbd6f87896d0259bfd176db70c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"12a7b89999c9014df11e1edd1d7a2e90ae621771","unresolved":false,"context_lines":[{"line_number":418,"context_line":"               help\u003d\"Specify destination host for live-migration and cold\""},{"line_number":419,"context_line":"                    \" migration. If option is not set tests will use host\""},{"line_number":420,"context_line":"                    \" automatically.\"),"},{"line_number":421,"context_line":"    cfg.StrOpt(\u0027target_hostname_pattern_to_avoid\u0027,"},{"line_number":422,"context_line":"               default\u003d\u0027-ironic\u0027,"},{"line_number":423,"context_line":"               help\u003d\"When aggregating hypervisors that are currently not\""},{"line_number":424,"context_line":"               \" hosting the guest VM, avoid using Computes that contain\""}],"source_content_type":"text/x-python","patch_set":2,"id":"c0628c97_fc36bc4d","line":421,"in_reply_to":"9899e9e2_eb72118c","updated":"2024-08-01 13:31:29.000000000","message":"Or maybe `filter_for_get_host`... I know this is horribly bikesheddy/nitpicky, but option names are a kind of public contract after all, so once they\u0027re public, they\u0027re more or less set in stone. Hence the desire to get them right the first time.","commit_id":"1ba68c0376f9d3dbd6f87896d0259bfd176db70c"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"60f041b1160fdc4cd3634a9905c5ddd85d074bbc","unresolved":false,"context_lines":[{"line_number":418,"context_line":"               help\u003d\"Specify destination host for live-migration and cold\""},{"line_number":419,"context_line":"                    \" migration. If option is not set tests will use host\""},{"line_number":420,"context_line":"                    \" automatically.\"),"},{"line_number":421,"context_line":"    cfg.StrOpt(\u0027target_hostname_pattern_to_avoid\u0027,"},{"line_number":422,"context_line":"               default\u003d\u0027-ironic\u0027,"},{"line_number":423,"context_line":"               help\u003d\"When aggregating hypervisors that are currently not\""},{"line_number":424,"context_line":"               \" hosting the guest VM, avoid using Computes that contain\""}],"source_content_type":"text/x-python","patch_set":2,"id":"93b04d06_f8b80224","line":421,"in_reply_to":"c0628c97_fc36bc4d","updated":"2024-08-01 13:34:04.000000000","message":"It\u0027s not a problem, I changed the name a couple of times locally before using that and I still was not super happy with it.","commit_id":"1ba68c0376f9d3dbd6f87896d0259bfd176db70c"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"af7d6acc78b15bdcea38764f6559872554fd046e","unresolved":false,"context_lines":[{"line_number":418,"context_line":"               help\u003d\"Specify destination host for live-migration and cold\""},{"line_number":419,"context_line":"                    \" migration. If option is not set tests will use host\""},{"line_number":420,"context_line":"                    \" automatically.\"),"},{"line_number":421,"context_line":"    cfg.StrOpt(\u0027target_hostname_pattern_to_avoid\u0027,"},{"line_number":422,"context_line":"               default\u003d\u0027-ironic\u0027,"},{"line_number":423,"context_line":"               help\u003d\"When aggregating hypervisors that are currently not\""},{"line_number":424,"context_line":"               \" hosting the guest VM, avoid using Computes that contain\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9899e9e2_eb72118c","line":421,"in_reply_to":"c0b21cd4_f21827a4","updated":"2024-08-01 13:28:25.000000000","message":"Acknowledged","commit_id":"1ba68c0376f9d3dbd6f87896d0259bfd176db70c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"90317dd2595b78e9a24ed7044881f49b230cdfb9","unresolved":true,"context_lines":[{"line_number":418,"context_line":"               help\u003d\"Specify destination host for live-migration and cold\""},{"line_number":419,"context_line":"                    \" migration. If option is not set tests will use host\""},{"line_number":420,"context_line":"                    \" automatically.\"),"},{"line_number":421,"context_line":"    cfg.StrOpt(\u0027filter_for_get_host\u0027,"},{"line_number":422,"context_line":"               default\u003d\u0027-ironic\u0027,"},{"line_number":423,"context_line":"               help\u003d\"When aggregating hypervisors that are currently not\""},{"line_number":424,"context_line":"               \" hosting the guest VM, avoid using Computes that contain\""}],"source_content_type":"text/x-python","patch_set":4,"id":"6c01b923_57f6571e","line":421,"range":{"start_line":421,"start_character":16,"end_line":421,"end_character":35},"updated":"2024-08-13 20:13:04.000000000","message":"This name does not give much clarity wbout what all host we need to set here.\n\nHow about \"hosts_with_no_guest_VM\"","commit_id":"4051bb515b953bef24c6ac34d84552b119764d81"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"abd575c35c3422883963be256a0dc21659d5a364","unresolved":false,"context_lines":[{"line_number":418,"context_line":"               help\u003d\"Specify destination host for live-migration and cold\""},{"line_number":419,"context_line":"                    \" migration. If option is not set tests will use host\""},{"line_number":420,"context_line":"                    \" automatically.\"),"},{"line_number":421,"context_line":"    cfg.StrOpt(\u0027filter_for_get_host\u0027,"},{"line_number":422,"context_line":"               default\u003d\u0027-ironic\u0027,"},{"line_number":423,"context_line":"               help\u003d\"When aggregating hypervisors that are currently not\""},{"line_number":424,"context_line":"               \" hosting the guest VM, avoid using Computes that contain\""}],"source_content_type":"text/x-python","patch_set":4,"id":"95756f26_a2046d00","line":421,"range":{"start_line":421,"start_character":16,"end_line":421,"end_character":35},"in_reply_to":"156a7db3_aeb347d6","updated":"2024-08-16 14:18:33.000000000","message":"Done","commit_id":"4051bb515b953bef24c6ac34d84552b119764d81"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"d3fed8065599b46f7cb65f67903342201189e7e3","unresolved":true,"context_lines":[{"line_number":418,"context_line":"               help\u003d\"Specify destination host for live-migration and cold\""},{"line_number":419,"context_line":"                    \" migration. If option is not set tests will use host\""},{"line_number":420,"context_line":"                    \" automatically.\"),"},{"line_number":421,"context_line":"    cfg.StrOpt(\u0027filter_for_get_host\u0027,"},{"line_number":422,"context_line":"               default\u003d\u0027-ironic\u0027,"},{"line_number":423,"context_line":"               help\u003d\"When aggregating hypervisors that are currently not\""},{"line_number":424,"context_line":"               \" hosting the guest VM, avoid using Computes that contain\""}],"source_content_type":"text/x-python","patch_set":4,"id":"e4e988d3_8370a3ae","line":421,"range":{"start_line":421,"start_character":16,"end_line":421,"end_character":35},"in_reply_to":"6c01b923_57f6571e","updated":"2024-08-13 20:34:56.000000000","message":"When I see the variable name I tend to think it is a request for hosts that currently do not have a guest VM versus a variable for filtering out target hosts for a movement operation. Some other ideas to use instead of filter_for_get_host that could improve clarity:\n* target_hosts_to_avoid\n* target_hosts_to_filter\n* hosts_for_guest_to_avoid","commit_id":"4051bb515b953bef24c6ac34d84552b119764d81"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"18a17a27ea940945ec8041acffb32c50fedd8d2c","unresolved":true,"context_lines":[{"line_number":418,"context_line":"               help\u003d\"Specify destination host for live-migration and cold\""},{"line_number":419,"context_line":"                    \" migration. If option is not set tests will use host\""},{"line_number":420,"context_line":"                    \" automatically.\"),"},{"line_number":421,"context_line":"    cfg.StrOpt(\u0027filter_for_get_host\u0027,"},{"line_number":422,"context_line":"               default\u003d\u0027-ironic\u0027,"},{"line_number":423,"context_line":"               help\u003d\"When aggregating hypervisors that are currently not\""},{"line_number":424,"context_line":"               \" hosting the guest VM, avoid using Computes that contain\""}],"source_content_type":"text/x-python","patch_set":4,"id":"156a7db3_aeb347d6","line":421,"range":{"start_line":421,"start_character":16,"end_line":421,"end_character":35},"in_reply_to":"e4e988d3_8370a3ae","updated":"2024-08-14 01:03:58.000000000","message":"I see, I think \u0027target_hosts_to_avoid\u0027 works fine for every case.\n\nPlease modify the help msg also accordingly. You can specify about \u0027...host to avoid migration and test VM to boot on...\u0027","commit_id":"4051bb515b953bef24c6ac34d84552b119764d81"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"90317dd2595b78e9a24ed7044881f49b230cdfb9","unresolved":true,"context_lines":[{"line_number":420,"context_line":"                    \" automatically.\"),"},{"line_number":421,"context_line":"    cfg.StrOpt(\u0027filter_for_get_host\u0027,"},{"line_number":422,"context_line":"               default\u003d\u0027-ironic\u0027,"},{"line_number":423,"context_line":"               help\u003d\"When aggregating hypervisors that are currently not\""},{"line_number":424,"context_line":"               \" hosting the guest VM, avoid using Computes that contain\""},{"line_number":425,"context_line":"               \" provided hostname pattern.\"),"},{"line_number":426,"context_line":"]"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"placement_group \u003d cfg.OptGroup(name\u003d\u0027placement\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"53110703_e09187bb","line":425,"range":{"start_line":423,"start_character":21,"end_line":425,"end_character":44},"updated":"2024-08-13 20:13:04.000000000","message":"\"Pattern for the host name when aggregating hypervisors that are currently not\"\n               \" hosting the guest VM. Avoid using Computes that contain\"\n               \" provided hostname pattern.\"","commit_id":"4051bb515b953bef24c6ac34d84552b119764d81"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"d3fed8065599b46f7cb65f67903342201189e7e3","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                    \" automatically.\"),"},{"line_number":421,"context_line":"    cfg.StrOpt(\u0027filter_for_get_host\u0027,"},{"line_number":422,"context_line":"               default\u003d\u0027-ironic\u0027,"},{"line_number":423,"context_line":"               help\u003d\"When aggregating hypervisors that are currently not\""},{"line_number":424,"context_line":"               \" hosting the guest VM, avoid using Computes that contain\""},{"line_number":425,"context_line":"               \" provided hostname pattern.\"),"},{"line_number":426,"context_line":"]"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"placement_group \u003d cfg.OptGroup(name\u003d\u0027placement\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"e0ad7e8a_d40ce1b2","line":425,"range":{"start_line":423,"start_character":21,"end_line":425,"end_character":44},"in_reply_to":"53110703_e09187bb","updated":"2024-08-13 20:34:56.000000000","message":"Acknowledged","commit_id":"4051bb515b953bef24c6ac34d84552b119764d81"}],"tempest/scenario/test_server_multinode.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"c21c8f0ae0bbfc13537e9398ea287484e5711246","unresolved":true,"context_lines":[{"line_number":48,"context_line":"                for host in zone[\u0027hosts\u0027]:"},{"line_number":49,"context_line":"                    if \u0027nova-compute\u0027 in zone[\u0027hosts\u0027][host] and \\"},{"line_number":50,"context_line":"                        zone[\u0027hosts\u0027][host][\u0027nova-compute\u0027][\u0027available\u0027] and \\"},{"line_number":51,"context_line":"                        CONF.compute.target_hostname_pattern_to_avoid not in \\"},{"line_number":52,"context_line":"                        host:"},{"line_number":53,"context_line":"                        hosts.append({\u0027zone\u0027: zone[\u0027zoneName\u0027],"},{"line_number":54,"context_line":"                                      \u0027host_name\u0027: host})"}],"source_content_type":"text/x-python","patch_set":3,"id":"0678c703_4994ace6","line":51,"range":{"start_line":51,"start_character":37,"end_line":51,"end_character":69},"updated":"2024-08-02 11:35:07.000000000","message":"filter_for_get_host","commit_id":"8d1c5f32df8ac97f5455555589b9a7bbe4467d76"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"db7a0612675f48e5ee4df0acdb0c4230081a33f9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                for host in zone[\u0027hosts\u0027]:"},{"line_number":49,"context_line":"                    if \u0027nova-compute\u0027 in zone[\u0027hosts\u0027][host] and \\"},{"line_number":50,"context_line":"                        zone[\u0027hosts\u0027][host][\u0027nova-compute\u0027][\u0027available\u0027] and \\"},{"line_number":51,"context_line":"                        CONF.compute.target_hostname_pattern_to_avoid not in \\"},{"line_number":52,"context_line":"                        host:"},{"line_number":53,"context_line":"                        hosts.append({\u0027zone\u0027: zone[\u0027zoneName\u0027],"},{"line_number":54,"context_line":"                                      \u0027host_name\u0027: host})"}],"source_content_type":"text/x-python","patch_set":3,"id":"6f7cee1a_cc88de9a","line":51,"range":{"start_line":51,"start_character":37,"end_line":51,"end_character":69},"in_reply_to":"0678c703_4994ace6","updated":"2024-08-02 20:01:47.000000000","message":"Thanks!","commit_id":"8d1c5f32df8ac97f5455555589b9a7bbe4467d76"}]}