)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"cce344ed5b6861ddb84a498a0588bf1a096e4989","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"edc183bb_81166fd4","updated":"2024-08-01 14:54:24.000000000","message":"recheck","commit_id":"7b7b81d6fbc7a67841a680b2da4ebbef7e15424e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d691aeebd2f2dadeea6731677ba8e1751f9c8b55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67c2f6fd_c2c3b2a7","updated":"2024-08-01 16:45:36.000000000","message":"recheck devstack patch changed","commit_id":"7b7b81d6fbc7a67841a680b2da4ebbef7e15424e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9bbbe795984277213a1f5432223f79674c6a9187","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"843097b5_7448941d","updated":"2024-08-02 16:24:04.000000000","message":"This skips on the non-import tests and passes on the import ones:\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_50c/925490/2/check/glance-multistore-cinder-import/50cde8b/testr_results.html\n\nSo this is good. Will fix the pep8 fail.","commit_id":"fb8d2121fd9a109f5859b86cae2d069d7cba6adb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"227fa9cce531a99f7e1744fae8a43d73a0e11152","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c6a339d0_3e46a754","updated":"2024-08-09 00:34:19.000000000","message":"lgtm,\n\ntests are generated and passing fine - https://zuul.opendev.org/t/openstack/build/0549811edae04025a0d922f1cb0d4c8c/log/job-output.txt#24245-24259","commit_id":"77a0eb5c52bb50b9c8020c14324ae4b12bda5e8a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d2e8c9873552c4809d5107d8f66c88af34a09fee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1131342a_c776cc07","updated":"2024-08-10 00:28:21.000000000","message":"lgtm, approving it","commit_id":"e8efa4f94d36d328bedce3da1a63d51ed0efcf47"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1f7f13507ef3952696feb23b186f4f9b46383f44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fe8326a1_90b8740a","updated":"2024-08-09 23:47:23.000000000","message":"recheck failed a volume test again","commit_id":"e8efa4f94d36d328bedce3da1a63d51ed0efcf47"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9d14dc3e245e49e7503452a519f787a5e9363e57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3b30532a_b8ad888b","updated":"2024-08-09 16:26:13.000000000","message":"recheck failed a volume test, clearly not related","commit_id":"e8efa4f94d36d328bedce3da1a63d51ed0efcf47"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"22a7394f0c1609b92b05a8418e1400f283de82fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0f28a289_433f2e26","updated":"2024-08-09 18:44:02.000000000","message":"recheck grenade job failed post, didn\u0027t upload logs","commit_id":"e8efa4f94d36d328bedce3da1a63d51ed0efcf47"}],"tempest/api/image/v2/test_images_formats.py":[{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"d1e0afe6b9210d214319203e90587b089103492a","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        image_name \u003d data_utils.rand_name("},{"line_number":57,"context_line":"            prefix\u003dCONF.resource_name_prefix,"},{"line_number":58,"context_line":"            name\u003dimage_def[\u0027name\u0027])"},{"line_number":59,"context_line":"        image \u003d self.client.create_image("},{"line_number":60,"context_line":"            name\u003dimage_name,"},{"line_number":61,"context_line":"            container_format\u003d\u0027bare\u0027,"},{"line_number":62,"context_line":"            disk_format\u003doverride_format or image_def[\u0027format\u0027])"},{"line_number":63,"context_line":"        self.images.append(image)"},{"line_number":64,"context_line":"        image_fn \u003d os.path.join(self._image_base, image_def[\u0027filename\u0027])"},{"line_number":65,"context_line":"        with open(image_fn, \u0027rb\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":4,"id":"afc5fb1f_87481c66","line":62,"range":{"start_line":59,"start_character":8,"end_line":62,"end_character":63},"updated":"2024-08-05 09:57:34.000000000","message":"Should we check if image is created?","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"61ecb8b0bf289af65c5cc5bbe39af8922aaf436d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        image_name \u003d data_utils.rand_name("},{"line_number":57,"context_line":"            prefix\u003dCONF.resource_name_prefix,"},{"line_number":58,"context_line":"            name\u003dimage_def[\u0027name\u0027])"},{"line_number":59,"context_line":"        image \u003d self.client.create_image("},{"line_number":60,"context_line":"            name\u003dimage_name,"},{"line_number":61,"context_line":"            container_format\u003d\u0027bare\u0027,"},{"line_number":62,"context_line":"            disk_format\u003doverride_format or image_def[\u0027format\u0027])"},{"line_number":63,"context_line":"        self.images.append(image)"},{"line_number":64,"context_line":"        image_fn \u003d os.path.join(self._image_base, image_def[\u0027filename\u0027])"},{"line_number":65,"context_line":"        with open(image_fn, \u0027rb\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":4,"id":"df9a99c5_cf28da69","line":62,"range":{"start_line":59,"start_character":8,"end_line":62,"end_character":63},"in_reply_to":"a45d5941_25a0da0c","updated":"2024-08-09 13:45:00.000000000","message":"Acknowledged","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"227fa9cce531a99f7e1744fae8a43d73a0e11152","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        image_name \u003d data_utils.rand_name("},{"line_number":57,"context_line":"            prefix\u003dCONF.resource_name_prefix,"},{"line_number":58,"context_line":"            name\u003dimage_def[\u0027name\u0027])"},{"line_number":59,"context_line":"        image \u003d self.client.create_image("},{"line_number":60,"context_line":"            name\u003dimage_name,"},{"line_number":61,"context_line":"            container_format\u003d\u0027bare\u0027,"},{"line_number":62,"context_line":"            disk_format\u003doverride_format or image_def[\u0027format\u0027])"},{"line_number":63,"context_line":"        self.images.append(image)"},{"line_number":64,"context_line":"        image_fn \u003d os.path.join(self._image_base, image_def[\u0027filename\u0027])"},{"line_number":65,"context_line":"        with open(image_fn, \u0027rb\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":4,"id":"a45d5941_25a0da0c","line":62,"range":{"start_line":59,"start_character":8,"end_line":62,"end_character":63},"in_reply_to":"afc5fb1f_87481c66","updated":"2024-08-09 00:34:19.000000000","message":"it is not needed as it image is not created test will fail here itself.","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"d1e0afe6b9210d214319203e90587b089103492a","unresolved":true,"context_lines":[{"line_number":61,"context_line":"            container_format\u003d\u0027bare\u0027,"},{"line_number":62,"context_line":"            disk_format\u003doverride_format or image_def[\u0027format\u0027])"},{"line_number":63,"context_line":"        self.images.append(image)"},{"line_number":64,"context_line":"        image_fn \u003d os.path.join(self._image_base, image_def[\u0027filename\u0027])"},{"line_number":65,"context_line":"        with open(image_fn, \u0027rb\u0027) as f:"},{"line_number":66,"context_line":"            if asimport:"},{"line_number":67,"context_line":"                self.client.stage_image_file(image[\u0027id\u0027], f)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4432edaf_e4a099ab","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":72},"updated":"2024-08-05 09:57:34.000000000","message":"Should we check if files exists before?","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3facf73abafe352dd39583482149f7fd2aab4052","unresolved":true,"context_lines":[{"line_number":61,"context_line":"            container_format\u003d\u0027bare\u0027,"},{"line_number":62,"context_line":"            disk_format\u003doverride_format or image_def[\u0027format\u0027])"},{"line_number":63,"context_line":"        self.images.append(image)"},{"line_number":64,"context_line":"        image_fn \u003d os.path.join(self._image_base, image_def[\u0027filename\u0027])"},{"line_number":65,"context_line":"        with open(image_fn, \u0027rb\u0027) as f:"},{"line_number":66,"context_line":"            if asimport:"},{"line_number":67,"context_line":"                self.client.stage_image_file(image[\u0027id\u0027], f)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9cec2601_b55f9319","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":72},"in_reply_to":"4432edaf_e4a099ab","updated":"2024-08-05 13:46:07.000000000","message":"And do what? We still need to fail if the file were to be missing, but this raising a FileNotFound will stop the test and communicate the problem...","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"d1e0afe6b9210d214319203e90587b089103492a","unresolved":true,"context_lines":[{"line_number":77,"context_line":"                if image[\u0027format\u0027] in CONF.image.disk_formats:"},{"line_number":78,"context_line":"                    # These are expected to work"},{"line_number":79,"context_line":"                    self._test_image(image)"},{"line_number":80,"context_line":"                else:"},{"line_number":81,"context_line":"                    # If this is not configured to be supported, we should get"},{"line_number":82,"context_line":"                    # a BadRequest from glance"},{"line_number":83,"context_line":"                    self.assertRaises(lib_exc.BadRequest,"},{"line_number":84,"context_line":"                                      self._test_image, image)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @decorators.idempotent_id(\u00277c7c2f16-2e97-4dce-8cb4-bc10be031c85\u0027)"},{"line_number":87,"context_line":"    def test_accept_reject_formats_import(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"d1e6eb15_5da2db05","line":84,"range":{"start_line":80,"start_character":14,"end_line":84,"end_character":62},"updated":"2024-08-05 09:57:34.000000000","message":"Should we separate negative tests from positive one?","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"d1e0afe6b9210d214319203e90587b089103492a","unresolved":true,"context_lines":[{"line_number":84,"context_line":"                                      self._test_image, image)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @decorators.idempotent_id(\u00277c7c2f16-2e97-4dce-8cb4-bc10be031c85\u0027)"},{"line_number":87,"context_line":"    def test_accept_reject_formats_import(self):"},{"line_number":88,"context_line":"        \"\"\"Make sure glance rejects invalid images during conversion.\"\"\""},{"line_number":89,"context_line":"        if \u0027glance-direct\u0027 not in self.available_import_methods:"},{"line_number":90,"context_line":"            self.skipTest(\u0027Import via glance-direct is not available\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"b2b6ddbb_2945cac8","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":48},"updated":"2024-08-05 09:57:34.000000000","message":"1.Should we separate negative tests from positive one?\n2.I think it\u0027s a bad idea to put all testcases in one test.\n  Should we create testcases for each image format?\n  Ex.tests that support conversion,masqueraded images and not supported images.","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"227fa9cce531a99f7e1744fae8a43d73a0e11152","unresolved":true,"context_lines":[{"line_number":84,"context_line":"                                      self._test_image, image)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @decorators.idempotent_id(\u00277c7c2f16-2e97-4dce-8cb4-bc10be031c85\u0027)"},{"line_number":87,"context_line":"    def test_accept_reject_formats_import(self):"},{"line_number":88,"context_line":"        \"\"\"Make sure glance rejects invalid images during conversion.\"\"\""},{"line_number":89,"context_line":"        if \u0027glance-direct\u0027 not in self.available_import_methods:"},{"line_number":90,"context_line":"            self.skipTest(\u0027Import via glance-direct is not available\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9e772045_5fca0f5d","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":48},"in_reply_to":"335f3166_375e6843","updated":"2024-08-09 00:34:19.000000000","message":"+1 on load_tests, it separate the tests and avoid test not teting any case.","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9674e86308b69a09b1243cf54df59ba0e148d381","unresolved":true,"context_lines":[{"line_number":84,"context_line":"                                      self._test_image, image)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @decorators.idempotent_id(\u00277c7c2f16-2e97-4dce-8cb4-bc10be031c85\u0027)"},{"line_number":87,"context_line":"    def test_accept_reject_formats_import(self):"},{"line_number":88,"context_line":"        \"\"\"Make sure glance rejects invalid images during conversion.\"\"\""},{"line_number":89,"context_line":"        if \u0027glance-direct\u0027 not in self.available_import_methods:"},{"line_number":90,"context_line":"            self.skipTest(\u0027Import via glance-direct is not available\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a87c7f15_7a0618dc","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":48},"in_reply_to":"4ac231ef_23275268","updated":"2024-08-05 13:56:53.000000000","message":"I can split the \"usable\" tests from the \"unusable\" tests if you want, although since there is a case where glance will fail on a should-be-usable test right now, that test will still have the special case called out...","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"61ecb8b0bf289af65c5cc5bbe39af8922aaf436d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                                      self._test_image, image)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @decorators.idempotent_id(\u00277c7c2f16-2e97-4dce-8cb4-bc10be031c85\u0027)"},{"line_number":87,"context_line":"    def test_accept_reject_formats_import(self):"},{"line_number":88,"context_line":"        \"\"\"Make sure glance rejects invalid images during conversion.\"\"\""},{"line_number":89,"context_line":"        if \u0027glance-direct\u0027 not in self.available_import_methods:"},{"line_number":90,"context_line":"            self.skipTest(\u0027Import via glance-direct is not available\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c6406443_57c77b3d","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":48},"in_reply_to":"9e772045_5fca0f5d","updated":"2024-08-09 13:45:00.000000000","message":"Acknowledged","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"920851618436137db5736eab4bdec91eb7ddefad","unresolved":true,"context_lines":[{"line_number":84,"context_line":"                                      self._test_image, image)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @decorators.idempotent_id(\u00277c7c2f16-2e97-4dce-8cb4-bc10be031c85\u0027)"},{"line_number":87,"context_line":"    def test_accept_reject_formats_import(self):"},{"line_number":88,"context_line":"        \"\"\"Make sure glance rejects invalid images during conversion.\"\"\""},{"line_number":89,"context_line":"        if \u0027glance-direct\u0027 not in self.available_import_methods:"},{"line_number":90,"context_line":"            self.skipTest(\u0027Import via glance-direct is not available\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"335f3166_375e6843","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":48},"in_reply_to":"a87c7f15_7a0618dc","updated":"2024-08-06 17:49:10.000000000","message":"I\u0027m about to push up a change that uses the `load_tests()` protocol to generate these scenarios dynamically for us. Hopefully that will address your concern.","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3facf73abafe352dd39583482149f7fd2aab4052","unresolved":true,"context_lines":[{"line_number":84,"context_line":"                                      self._test_image, image)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @decorators.idempotent_id(\u00277c7c2f16-2e97-4dce-8cb4-bc10be031c85\u0027)"},{"line_number":87,"context_line":"    def test_accept_reject_formats_import(self):"},{"line_number":88,"context_line":"        \"\"\"Make sure glance rejects invalid images during conversion.\"\"\""},{"line_number":89,"context_line":"        if \u0027glance-direct\u0027 not in self.available_import_methods:"},{"line_number":90,"context_line":"            self.skipTest(\u0027Import via glance-direct is not available\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4ac231ef_23275268","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":48},"in_reply_to":"b2b6ddbb_2945cac8","updated":"2024-08-05 13:46:07.000000000","message":"I too would prefer that we have a different test case per format, but I\u0027m not sure we can generate those after we have processed our config file with `stestr`. If we can, then I\u0027d be glad to do that.\n\nThe point is, we need to make sure we run all the image variations in the manifest. If we hard-code each test here, we\u0027re (a) duplicating work, (b) making it required to add a new tempest case every time we add an image variant, and (c) risk forgetting to do that and not testing a case.","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"d1e0afe6b9210d214319203e90587b089103492a","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @decorators.idempotent_id(\u00277c7c2f16-2e97-4dce-8cb4-bc10be031c85\u0027)"},{"line_number":87,"context_line":"    def test_accept_reject_formats_import(self):"},{"line_number":88,"context_line":"        \"\"\"Make sure glance rejects invalid images during conversion.\"\"\""},{"line_number":89,"context_line":"        if \u0027glance-direct\u0027 not in self.available_import_methods:"},{"line_number":90,"context_line":"            self.skipTest(\u0027Import via glance-direct is not available\u0027)"},{"line_number":91,"context_line":"        if not CONF.image_feature_enabled.image_conversion:"}],"source_content_type":"text/x-python","patch_set":4,"id":"8922c372_32b89bca","line":88,"range":{"start_line":88,"start_character":11,"end_line":88,"end_character":68},"updated":"2024-08-05 09:57:34.000000000","message":"Need more details about what type of image we test here and to what type we convert image to","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3facf73abafe352dd39583482149f7fd2aab4052","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @decorators.idempotent_id(\u00277c7c2f16-2e97-4dce-8cb4-bc10be031c85\u0027)"},{"line_number":87,"context_line":"    def test_accept_reject_formats_import(self):"},{"line_number":88,"context_line":"        \"\"\"Make sure glance rejects invalid images during conversion.\"\"\""},{"line_number":89,"context_line":"        if \u0027glance-direct\u0027 not in self.available_import_methods:"},{"line_number":90,"context_line":"            self.skipTest(\u0027Import via glance-direct is not available\u0027)"},{"line_number":91,"context_line":"        if not CONF.image_feature_enabled.image_conversion:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dd0d13bd_c5ab7e3b","line":88,"range":{"start_line":88,"start_character":11,"end_line":88,"end_character":68},"in_reply_to":"8922c372_32b89bca","updated":"2024-08-05 13:46:07.000000000","message":"It\u0027s defined in the manifest.\n\n\nWe don\u0027t care what type we\u0027re converting to, we only care that we run through the image conversion plugin, which should inspect and fail on these images.","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"d1e0afe6b9210d214319203e90587b089103492a","unresolved":true,"context_lines":[{"line_number":125,"context_line":"                    image \u003d self._test_image(image_def, asimport\u003dTrue)"},{"line_number":126,"context_line":"                    waiters.wait_for_image_status(self.client, image[\u0027id\u0027],"},{"line_number":127,"context_line":"                                                  \u0027queued\u0027)"},{"line_number":128,"context_line":"                    self.client.delete_image(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"d9025e89_045d00e7","line":128,"updated":"2024-08-05 09:57:34.000000000","message":"Should we check if image is delete?","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3facf73abafe352dd39583482149f7fd2aab4052","unresolved":true,"context_lines":[{"line_number":125,"context_line":"                    image \u003d self._test_image(image_def, asimport\u003dTrue)"},{"line_number":126,"context_line":"                    waiters.wait_for_image_status(self.client, image[\u0027id\u0027],"},{"line_number":127,"context_line":"                                                  \u0027queued\u0027)"},{"line_number":128,"context_line":"                    self.client.delete_image(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1c108e8b_6775e522","line":128,"in_reply_to":"d9025e89_045d00e7","updated":"2024-08-05 13:46:07.000000000","message":"No? We don\u0027t need to even do this because it will be cleaned up in tearDown, but it\u0027s not part of the actual thing we\u0027re verifying here. I just added this to make it easier to reason about which test was failing while I was working through all of them. I could remove it, but images stack up in glance while this test is running.","commit_id":"8f17efe0696096892ee76006068efb7341d76cf5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"10ebc538e8cdccdfa2873e98fe871ed019d30e5b","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        with open(image_fn, \u0027rb\u0027) as f:"},{"line_number":80,"context_line":"            if asimport:"},{"line_number":81,"context_line":"                self.client.stage_image_file(image[\u0027id\u0027], f)"},{"line_number":82,"context_line":"                self.client.image_import(image[\u0027id\u0027], method\u003d\u0027glance-direct\u0027)"},{"line_number":83,"context_line":"            else:"},{"line_number":84,"context_line":"                self.client.store_image_file(image[\u0027id\u0027], f)"},{"line_number":85,"context_line":"        return image"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ea33032_4f90681f","line":82,"range":{"start_line":82,"start_character":53,"end_line":82,"end_character":76},"updated":"2024-08-06 18:11:00.000000000","message":"I think default is glance-direct so this can be avoided and also IMO test execution will not come to this point as test will be skipped if this method is not enabled.","commit_id":"ef4773ac6737a85dda0fb485084bbf1f11f6da31"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a91bec47240ff6225daa8a44ebcd6696259fa70b","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        with open(image_fn, \u0027rb\u0027) as f:"},{"line_number":80,"context_line":"            if asimport:"},{"line_number":81,"context_line":"                self.client.stage_image_file(image[\u0027id\u0027], f)"},{"line_number":82,"context_line":"                self.client.image_import(image[\u0027id\u0027], method\u003d\u0027glance-direct\u0027)"},{"line_number":83,"context_line":"            else:"},{"line_number":84,"context_line":"                self.client.store_image_file(image[\u0027id\u0027], f)"},{"line_number":85,"context_line":"        return image"}],"source_content_type":"text/x-python","patch_set":5,"id":"724cf1eb_f08aeb5e","line":82,"range":{"start_line":82,"start_character":53,"end_line":82,"end_character":76},"in_reply_to":"68f6506c_2ccb12ab","updated":"2024-08-06 18:14:46.000000000","message":"Ack, no concerns from readability point!!","commit_id":"ef4773ac6737a85dda0fb485084bbf1f11f6da31"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96fe8a33f64e0ed698f6f4d0094d41d9b437a0c3","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        with open(image_fn, \u0027rb\u0027) as f:"},{"line_number":80,"context_line":"            if asimport:"},{"line_number":81,"context_line":"                self.client.stage_image_file(image[\u0027id\u0027], f)"},{"line_number":82,"context_line":"                self.client.image_import(image[\u0027id\u0027], method\u003d\u0027glance-direct\u0027)"},{"line_number":83,"context_line":"            else:"},{"line_number":84,"context_line":"                self.client.store_image_file(image[\u0027id\u0027], f)"},{"line_number":85,"context_line":"        return image"}],"source_content_type":"text/x-python","patch_set":5,"id":"68f6506c_2ccb12ab","line":82,"range":{"start_line":82,"start_character":53,"end_line":82,"end_character":76},"in_reply_to":"7ea33032_4f90681f","updated":"2024-08-06 18:13:00.000000000","message":"I copied this from other import tests that hard-code the method. Even if it\u0027s not strictly required, I don\u0027t think it\u0027s bad for readability to be explicit...","commit_id":"ef4773ac6737a85dda0fb485084bbf1f11f6da31"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"dfa2ed345ae29ed89002a4442cff90f9d77ab609","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        cls.available_import_methods \u003d cls.client.info_import()["},{"line_number":67,"context_line":"            \u0027import-methods\u0027][\u0027value\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _test_image(self, image_def, override_format\u003dNone, asimport\u003dFalse):"},{"line_number":70,"context_line":"        image_name \u003d data_utils.rand_name("},{"line_number":71,"context_line":"            prefix\u003dCONF.resource_name_prefix,"},{"line_number":72,"context_line":"            name\u003dimage_def[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"b8b50625_ead52cbd","line":69,"updated":"2024-08-12 07:54:02.000000000","message":"Missing docstring","commit_id":"e8efa4f94d36d328bedce3da1a63d51ed0efcf47"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"dfa2ed345ae29ed89002a4442cff90f9d77ab609","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        return image"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @decorators.idempotent_id(\u0027a245fcbe-63ce-4dc1-a1d0-c16d76d9e6df\u0027)"},{"line_number":88,"context_line":"    def test_accept_usable_formats(self):"},{"line_number":89,"context_line":"        if self.imgdef[\u0027usable\u0027]:"},{"line_number":90,"context_line":"            if self.imgdef[\u0027format\u0027] in CONF.image.disk_formats:"},{"line_number":91,"context_line":"                # These are expected to work"}],"source_content_type":"text/x-python","patch_set":8,"id":"88dce34a_9bc606a5","line":88,"updated":"2024-08-12 07:54:02.000000000","message":"Missing docstring","commit_id":"e8efa4f94d36d328bedce3da1a63d51ed0efcf47"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"dfa2ed345ae29ed89002a4442cff90f9d77ab609","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        if not CONF.image_feature_enabled.image_conversion:"},{"line_number":108,"context_line":"            self.skipTest(\u0027Import image_conversion not enabled\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        glance_noconvert \u003d ["},{"line_number":111,"context_line":"            # Glance does not support conversion from iso/udf, so these"},{"line_number":112,"context_line":"            # will always fail, even though they are marked as usable."},{"line_number":113,"context_line":"            \u0027iso\u0027,"},{"line_number":114,"context_line":"            \u0027udf\u0027,"},{"line_number":115,"context_line":"            # Glance does not support vmdk-sparse-with-footer with the"},{"line_number":116,"context_line":"            # in-tree format_inspector"},{"line_number":117,"context_line":"            \u0027vmdk-sparse-with-footer\u0027,"},{"line_number":118,"context_line":"            ]"},{"line_number":119,"context_line":"        # Any images glance does not support in *conversion* for some"},{"line_number":120,"context_line":"        # reason will fail, even though the manifest marks them as usable."},{"line_number":121,"context_line":"        expect_fail \u003d any(x in self.imgdef[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"b4435daf_b271b0b2","line":118,"range":{"start_line":110,"start_character":1,"end_line":118,"end_character":13},"updated":"2024-08-12 07:54:02.000000000","message":"If we have one source with image types is manifest file.\nShould we move \u0027non-convert formats\u0027 to manifest file?","commit_id":"e8efa4f94d36d328bedce3da1a63d51ed0efcf47"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"941fa5f036a23abb0656503343ff5e6bd74253fe","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        if not CONF.image_feature_enabled.image_conversion:"},{"line_number":108,"context_line":"            self.skipTest(\u0027Import image_conversion not enabled\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        glance_noconvert \u003d ["},{"line_number":111,"context_line":"            # Glance does not support conversion from iso/udf, so these"},{"line_number":112,"context_line":"            # will always fail, even though they are marked as usable."},{"line_number":113,"context_line":"            \u0027iso\u0027,"},{"line_number":114,"context_line":"            \u0027udf\u0027,"},{"line_number":115,"context_line":"            # Glance does not support vmdk-sparse-with-footer with the"},{"line_number":116,"context_line":"            # in-tree format_inspector"},{"line_number":117,"context_line":"            \u0027vmdk-sparse-with-footer\u0027,"},{"line_number":118,"context_line":"            ]"},{"line_number":119,"context_line":"        # Any images glance does not support in *conversion* for some"},{"line_number":120,"context_line":"        # reason will fail, even though the manifest marks them as usable."},{"line_number":121,"context_line":"        expect_fail \u003d any(x in self.imgdef[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"118f744e_7cf3cd31","line":118,"range":{"start_line":110,"start_character":1,"end_line":118,"end_character":13},"in_reply_to":"b4435daf_b271b0b2","updated":"2024-08-12 13:29:37.000000000","message":"No, the manifest file describes the images. The above list is a temporary exclusion list because of a couple missing patches in glance. One is close to merging, the other will require the oslo.utils cutover.","commit_id":"e8efa4f94d36d328bedce3da1a63d51ed0efcf47"}],"tempest/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"227fa9cce531a99f7e1744fae8a43d73a0e11152","unresolved":true,"context_lines":[{"line_number":721,"context_line":"                help\u003d(\u0027Is show_multiple_locations enabled in glance. \u0027"},{"line_number":722,"context_line":"                      \u0027Note that at least one http store must be enabled as \u0027"},{"line_number":723,"context_line":"                      \u0027well, because we use that location scheme to test.\u0027)),"},{"line_number":724,"context_line":"    cfg.BoolOpt(\u0027image_conversion\u0027,"},{"line_number":725,"context_line":"                default\u003dFalse,"},{"line_number":726,"context_line":"                help\u003d(\u0027Is image_conversion enabled in glance.\u0027)),"},{"line_number":727,"context_line":"]"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"network_group \u003d cfg.OptGroup(name\u003d\u0027network\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"b0bc449b_d543b2ea","line":726,"range":{"start_line":724,"start_character":0,"end_line":726,"end_character":65},"updated":"2024-08-09 00:34:19.000000000","message":"for this also, can you add releasenotes, or add together with other one and this.","commit_id":"77a0eb5c52bb50b9c8020c14324ae4b12bda5e8a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"61ecb8b0bf289af65c5cc5bbe39af8922aaf436d","unresolved":false,"context_lines":[{"line_number":721,"context_line":"                help\u003d(\u0027Is show_multiple_locations enabled in glance. \u0027"},{"line_number":722,"context_line":"                      \u0027Note that at least one http store must be enabled as \u0027"},{"line_number":723,"context_line":"                      \u0027well, because we use that location scheme to test.\u0027)),"},{"line_number":724,"context_line":"    cfg.BoolOpt(\u0027image_conversion\u0027,"},{"line_number":725,"context_line":"                default\u003dFalse,"},{"line_number":726,"context_line":"                help\u003d(\u0027Is image_conversion enabled in glance.\u0027)),"},{"line_number":727,"context_line":"]"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"network_group \u003d cfg.OptGroup(name\u003d\u0027network\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ddee5a02_735d8b2f","line":726,"range":{"start_line":724,"start_character":0,"end_line":726,"end_character":65},"in_reply_to":"b0bc449b_d543b2ea","updated":"2024-08-09 13:45:00.000000000","message":"Acknowledged","commit_id":"77a0eb5c52bb50b9c8020c14324ae4b12bda5e8a"}]}