)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d66601bb2305a359e0c503452293a98fe6a7dc44","unresolved":false,"context_lines":[{"line_number":387,"context_line":"            private_key \u003d self.keypair.private_key"},{"line_number":388,"context_line":"        linux_client \u003d remote_client.RemoteClient(ip, username,"},{"line_number":389,"context_line":"                                                  pkey\u003dprivate_key)"},{"line_number":390,"context_line":"        linux_client.validate_authentication"},{"line_number":391,"context_line":"        return linux_client"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def _log_console_output(self, servers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_debcccbd","line":390,"updated":"2014-05-19 10:05:52.000000000","message":"Don\u0027t you need round brackets here? I mean \n\n    linux_client.validate_authentication()","commit_id":"7b0bcd154e1e2c5f2a97382fe86708ad9ea8e212"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"aa8c16a75f13abe21dbebd577c4ee177d59bcb3c","unresolved":false,"context_lines":[{"line_number":387,"context_line":"            private_key \u003d self.keypair.private_key"},{"line_number":388,"context_line":"        linux_client \u003d remote_client.RemoteClient(ip, username,"},{"line_number":389,"context_line":"                                                  pkey\u003dprivate_key)"},{"line_number":390,"context_line":"        linux_client.validate_authentication"},{"line_number":391,"context_line":"        return linux_client"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def _log_console_output(self, servers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_3ef1176b","line":390,"in_reply_to":"7adec928_debcccbd","updated":"2014-05-20 06:36:35.000000000","message":"Sorry","commit_id":"7b0bcd154e1e2c5f2a97382fe86708ad9ea8e212"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"5cc8eecf8fa3b21bf5d4f3e4216f54959cc3faad","unresolved":false,"context_lines":[{"line_number":391,"context_line":"            private_key \u003d self.keypair.private_key"},{"line_number":392,"context_line":"        linux_client \u003d remote_client.RemoteClient(ip, username,"},{"line_number":393,"context_line":"                                                  pkey\u003dprivate_key)"},{"line_number":394,"context_line":"        linux_client.validate_authentication()"},{"line_number":395,"context_line":"        return linux_client"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def _log_console_output(self, servers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_8832bff0","line":394,"updated":"2014-06-16 16:38:38.000000000","message":"Here there is no try block with console log or debug.","commit_id":"3b673349fe8a7f154746d689de5c672025ecbcec"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d5a9730338d11e5ab29bd76cfc45d2387f72c51a","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        try:"},{"line_number":395,"context_line":"            linux_client.validate_authentication()"},{"line_number":396,"context_line":"        except exceptions.SSHTimeout:"},{"line_number":397,"context_line":"            LOG.exception(\u0027Tenant network connectivity check failed\u0027)"},{"line_number":398,"context_line":"            debug.log_net_debug()"},{"line_number":399,"context_line":"            raise"},{"line_number":400,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_45cbde71","line":397,"updated":"2014-06-18 14:08:08.000000000","message":"Please, correct message in log. \"Tenant network connectivity\" is not relevant here.","commit_id":"06a36f1d2324243ecdb7a62ecbd44bba3aa6b21f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3c393720abb493382023ccbbbc6efb1d93690151","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        try:"},{"line_number":395,"context_line":"            linux_client.validate_authentication()"},{"line_number":396,"context_line":"        except exceptions.SSHTimeout:"},{"line_number":397,"context_line":"            LOG.exception(\u0027Tenant network connectivity check failed\u0027)"},{"line_number":398,"context_line":"            debug.log_net_debug()"},{"line_number":399,"context_line":"            raise"},{"line_number":400,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_6620d649","line":397,"in_reply_to":"1ae5cdf2_45cbde71","updated":"2014-06-18 18:36:39.000000000","message":"I agree this log message will be confusing. Make it something like:\n\n\"ssh connection to %s failed\" % ip\n\nto actually explain what failed","commit_id":"06a36f1d2324243ecdb7a62ecbd44bba3aa6b21f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3c393720abb493382023ccbbbc6efb1d93690151","unresolved":false,"context_lines":[{"line_number":880,"context_line":"                ex_msg +\u003d \": \" + msg"},{"line_number":881,"context_line":"            LOG.exception(ex_msg)"},{"line_number":882,"context_line":"            self._log_console_output(servers)"},{"line_number":883,"context_line":"            if not isinstance(e, exceptions.SSHTimeout):"},{"line_number":884,"context_line":"                # SSHTimeout is handled in get_remote_client()"},{"line_number":885,"context_line":"                debug.log_net_debug()"},{"line_number":886,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_060ab289","line":883,"updated":"2014-06-18 18:36:39.000000000","message":"This is precisely why we should be avoiding catch all exceptions like in this block. But since it was already in the tree I guess fixing it would be outside the scope of the patch","commit_id":"06a36f1d2324243ecdb7a62ecbd44bba3aa6b21f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3c393720abb493382023ccbbbc6efb1d93690151","unresolved":false,"context_lines":[{"line_number":881,"context_line":"            LOG.exception(ex_msg)"},{"line_number":882,"context_line":"            self._log_console_output(servers)"},{"line_number":883,"context_line":"            if not isinstance(e, exceptions.SSHTimeout):"},{"line_number":884,"context_line":"                # SSHTimeout is handled in get_remote_client()"},{"line_number":885,"context_line":"                debug.log_net_debug()"},{"line_number":886,"context_line":"            raise"},{"line_number":887,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_46ad9a9a","line":884,"updated":"2014-06-18 18:36:39.000000000","message":"This comment is backwards, it should be on the if not the debug call...\n\nAlso you should just mention that it\u0027s the network debug call duplication. Not the error handling. They\u0027re 2 different things.","commit_id":"06a36f1d2324243ecdb7a62ecbd44bba3aa6b21f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3c393720abb493382023ccbbbc6efb1d93690151","unresolved":false,"context_lines":[{"line_number":907,"context_line":"            LOG.exception(\u0027Tenant network connectivity check failed\u0027)"},{"line_number":908,"context_line":"            self._log_console_output(servers_for_debug)"},{"line_number":909,"context_line":"            if not isinstance(e, exceptions.SSHTimeout):"},{"line_number":910,"context_line":"                # SSHTimeout is handled in get_remote_client()"},{"line_number":911,"context_line":"                debug.log_net_debug()"},{"line_number":912,"context_line":"            raise"},{"line_number":913,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_86a08291","line":910,"updated":"2014-06-18 18:36:39.000000000","message":"Same thing for this block","commit_id":"06a36f1d2324243ecdb7a62ecbd44bba3aa6b21f"}],"tempest/scenario/test_minimum_basic.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3c393720abb493382023ccbbbc6efb1d93690151","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            LOG.exception(\u0027ssh to server failed\u0027)"},{"line_number":98,"context_line":"            self._log_console_output()"},{"line_number":99,"context_line":"            if not isinstance(e, test.exceptions.SSHTimeout):"},{"line_number":100,"context_line":"                # SSHTimeout is handled in get_remote_client()"},{"line_number":101,"context_line":"                debug.log_net_debug()"},{"line_number":102,"context_line":"            raise"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_465cba7d","line":100,"updated":"2014-06-18 18:36:39.000000000","message":"Same here with this comment.","commit_id":"06a36f1d2324243ecdb7a62ecbd44bba3aa6b21f"}]}