)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"93cff4ab6052403af01f98426f08f7a5b1fd62a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f1a1fdc_f83ca165","updated":"2024-10-29 23:25:17.000000000","message":"As Takashi said in a previous comment, and for the record, this is breaking some other projects which were relying on hardcoded volumev3 as service_type for cinder.\nE.G. mistral actions.\nThis is forcing us to change this to block-storage, which is wrong based on what cinder actually recommend to configure on its documentation as of today.","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ed3081df4f913b4224852bccc089db408010ba6c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"72229721_4e464079","updated":"2024-09-25 12:07:49.000000000","message":"IMO we should fix the value used in devstack instead. The `volumev3` service type is what the install guide have suggested for many years. Changing it may impact number of existing deployments following that guidance.","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"75ee2d4786e9e138b6f92ceae62cb2cc0f6f4570","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"782b8790_f7bcaa05","updated":"2024-10-07 12:12:40.000000000","message":"lgtm","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4552e4d41874940de056267e01df1da23e9571bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b2b817f2_12a7b4d9","updated":"2024-10-04 16:55:51.000000000","message":"recheck change lgtm, failure not related","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"570f085394320c6543d51e818c2475215bd1ec61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0014dcb2_7d899808","updated":"2024-10-05 01:30:36.000000000","message":"recheck not sure why test were not triggered","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa47e77e2d13e0074c1583dd923d04cf75abcff0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"858cc058_8c21182b","in_reply_to":"31bf8797_f751bd28","updated":"2024-10-30 11:43:07.000000000","message":"\u003e As Takashi said in a previous comment, and for the record, this is breaking some other projects which were relying on hardcoded volumev3 as service_type for cinder. E.G. mistral actions.\n\nI think the root cause here is that mistral-extra is using a single hardcoded value when in fact a service can be referred to via multiple aliases, as documented at https://service-types.openstack.org/. As things stood, mistral-extra was previously broken on deployments that (correctly) documented their service type as `block-storage`. I\u0027ll respond on the review with (IMO) the correct resolution here.\n\n\u003e This is forcing us to change this to block-storage, which is wrong based on what cinder actually recommend to configure on its documentation as of today.\n\nThat doc is outdated and https://review.opendev.org/c/openstack/cinder/+/931699 was proposed a few weeks ago to correct this (per similar feedback from `openstack-discuss`). Alas, review throughput on Cinder is pretty awful right now and it might take some time for that to merge 😞","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a33630517996dfd7ddc4ba890787d57a17481c6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"58d98a48_6fc9f5b1","in_reply_to":"40c9e79e_10ca5c6f","updated":"2024-10-31 14:06:10.000000000","message":"Yes, and anyone that uses the discovery feature of keystoneauth gets this for free. Other projects such as Gophercloud (which the terraform provider is based on) need some tweaks but they\u0027re good bug fixes to add and they will be easily seen in CI.","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c790e322339cbe3a1718786e2b9e5de6632c9c48","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5b9597ab_3e1733cb","in_reply_to":"48f37bb1_2a212182","updated":"2024-10-04 16:59:45.000000000","message":"devstack \"may\" be fixed but changing this makes default in tempest and the other services inconsistent.\n\nAlso as I mentioned in the thread, changing the default in nova/glance/etc is huge breaking change which impacts upgrade. IMHO I don\u0027t think it\u0027s a good idea to change the default now, after several years, for consistency unless it really breaks something.","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0239a5b5f6fcd964dd06e99dac73229ff39291e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"60ff9e7b_50ad51c0","in_reply_to":"5b9597ab_3e1733cb","updated":"2024-10-04 18:09:09.000000000","message":"So based on the discussion in the thread the legacy service type and the official service type should be internally translated.","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"a4b9c0d1eb13caba344ea6d73d4f3c4cf0ca267b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"31bf8797_f751bd28","in_reply_to":"6f1a1fdc_f83ca165","updated":"2024-10-29 23:32:07.000000000","message":"https://review.opendev.org/c/openstack/mistral-extra/+/933691","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"00e9831459debd68eb97a69778bc763da25a748a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b275e780_77c768bb","in_reply_to":"72229721_4e464079","updated":"2024-09-25 12:09:12.000000000","message":"If we people think using the \"official\" name is better then at least the install guide in cinder should be updated consistently.","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fefcf1de0f49d0d3e388fe60f8e13f8861564459","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ea24cab_74a02829","in_reply_to":"858cc058_8c21182b","updated":"2024-10-30 11:57:37.000000000","message":"\u003e I\u0027ll respond on the review with (IMO) the correct resolution here.\n\nActually, @kajinamit@oss.nttdata.com beat me to it 😄","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"025a942f2c0185f597d52a377303e75f1ebd34ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ae3f9cbc_f62e8757","in_reply_to":"9ea24cab_74a02829","updated":"2024-10-30 17:03:17.000000000","message":"Agree. If anything is broken then my suggestion is to fix that. Fixing these kind of things at start of the cycle are not very blocking in our development work. Otherwise we would not be able to cleanup the things on common tooling.","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fb3e94660db9ae30df96f5aed065f1cc03a01894","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"40c9e79e_10ca5c6f","in_reply_to":"a36f3873_db1cf824","updated":"2024-10-30 17:45:41.000000000","message":"Thanks, Amaud. The operator should not be impacted by this dev stack change to remove the \u0027volumev3\u0027 endpoint. Operators using this or other endpoint alias should not be impacted as long as they discover the endpoint with what they resigned. Fixing it in devstack scripts means using the right alias in upstream CI and recommending the same to operator whenever they are ready.\n\nWe discussed it in detail here https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/7BZMAKF7GXBLYBHZZQFVHUKOIW4YTCII/","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"44a08d7f378cfb3c36e6afceca5fa67b365cd694","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a36f3873_db1cf824","in_reply_to":"ae3f9cbc_f62e8757","updated":"2024-10-30 17:27:38.000000000","message":"Ok, thank for your answers.\nI will propose a patch on mistral side to handle multiple service types then.\n\nOne minor concern here, as an operator, I am a little bit afraid about this change, even if it early in the cycle. I am afraid by all external dependencies which are using the volumev3 alias instead of block-storage (thinking about terraform, etc.).","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c58ff9b881d2ecb90aead9698748456c6bae5051","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dbb12f59_e2fe4f48","in_reply_to":"b275e780_77c768bb","updated":"2024-09-25 13:38:42.000000000","message":"Note that there are a few more tings like [cinder] catalog_info in nova which referes to the volumev3 service type and these may be also updated.","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4552e4d41874940de056267e01df1da23e9571bf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"48f37bb1_2a212182","in_reply_to":"dbb12f59_e2fe4f48","updated":"2024-10-04 16:55:51.000000000","message":"devstack fix is up and we can cleanup in nova but that is not blocking for it as nova look for both name there and volume3 can be just removed - https://github.com/openstack/nova/blob/df5454021543e8aa3c73289224158c9090f0da6a/nova/context.py#L116","commit_id":"1a744c8042d3c5c5ad153ef1e645975428ba0dfe"}]}