)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb79842b6e5a2f612851c6789e70529bfacd7d34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5943e1da_8e95f4b7","updated":"2024-10-09 06:02:43.000000000","message":"recheck neutron-ovs-grenade-multinode","commit_id":"3bf4c5be27dc4fbf7c643cd4fb712129fc796bfc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e4543d39d34533fdb92badd7896734ba2d8a1ea7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8a1bb0a4_d5d14aa7","updated":"2024-10-14 18:27:26.000000000","message":"almost lgtm, but please add a note for dvr case","commit_id":"359c62de62ef708523b6f88b1d5672373bb08ed0"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"747a6b5d7f4222f3445a3f5e1fe884527491725a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c3a49f81_33972822","updated":"2024-10-14 08:52:13.000000000","message":"lgtm","commit_id":"359c62de62ef708523b6f88b1d5672373bb08ed0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"935b9890bd54f516e8d484ee0925809de136d767","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"87ae1b12_adfb7baa","updated":"2024-10-10 13:20:28.000000000","message":"recheck grenade, I don\u0027t think this patch is related","commit_id":"359c62de62ef708523b6f88b1d5672373bb08ed0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4a9eb5791e5233180492c0d0a03d643e1b30d2d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"044223f8_7c139346","updated":"2024-10-11 08:12:01.000000000","message":"recheck tempest-full-enforce-scope-new-defaults unrelated","commit_id":"359c62de62ef708523b6f88b1d5672373bb08ed0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"94dd64dcfc7b78e5caae3ffffc95c041b69eee0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cf027553_6df4b603","updated":"2024-10-15 17:11:14.000000000","message":"lgtm, approving it as Martin already +2 on this before the notes change","commit_id":"6ad37f2b2962b56123bcd1ff30c72cb3a678de2f"}],"tempest/api/network/test_routers.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"67165a04a732b1192644bcecc6a4a80c4a7f806e","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    def _remove_router_interface_with_subnet_id(self, router_id, subnet_id,"},{"line_number":42,"context_line":"                                                port_id):"},{"line_number":43,"context_line":"        waiters.wait_for_port_status(client\u003dself.ports_client,"},{"line_number":44,"context_line":"                                     port_id\u003dport_id, status\u003d\u0027ACTIVE\u0027)"},{"line_number":45,"context_line":"        body \u003d self.routers_client.remove_router_interface(router_id,"},{"line_number":46,"context_line":"                                                           subnet_id\u003dsubnet_id)"},{"line_number":47,"context_line":"        self.assertEqual(subnet_id, body[\u0027subnet_id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"8d3d4b1f_d7923366","line":44,"range":{"start_line":44,"start_character":62,"end_line":44,"end_character":68},"updated":"2024-10-09 14:32:45.000000000","message":"The router port can belong to a router still not scheduled to a host. In that case, the port cannot be ACTIVE.","commit_id":"3bf4c5be27dc4fbf7c643cd4fb712129fc796bfc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"094975dc8729b2e88d922fe9991b0d73d8fd3506","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    def _remove_router_interface_with_subnet_id(self, router_id, subnet_id,"},{"line_number":42,"context_line":"                                                port_id):"},{"line_number":43,"context_line":"        waiters.wait_for_port_status(client\u003dself.ports_client,"},{"line_number":44,"context_line":"                                     port_id\u003dport_id, status\u003d\u0027ACTIVE\u0027)"},{"line_number":45,"context_line":"        body \u003d self.routers_client.remove_router_interface(router_id,"},{"line_number":46,"context_line":"                                                           subnet_id\u003dsubnet_id)"},{"line_number":47,"context_line":"        self.assertEqual(subnet_id, body[\u0027subnet_id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfa225ef_c75ec1cf","line":44,"range":{"start_line":44,"start_character":62,"end_line":44,"end_character":68},"in_reply_to":"8d3d4b1f_d7923366","updated":"2024-10-09 19:30:30.000000000","message":"This check needs to be disabled if mech driver !\u003d OVN and enable_dvr\u003dTrue","commit_id":"3bf4c5be27dc4fbf7c643cd4fb712129fc796bfc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a87d981fcd631d7375b4c19b1be1e7f685185e68","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def _remove_router_interface_with_subnet_id(self, router_id, subnet_id,"},{"line_number":42,"context_line":"                                                port_id):"},{"line_number":43,"context_line":"        waiters.wait_for_port_status(client\u003dself.ports_client,"},{"line_number":44,"context_line":"                                     port_id\u003dport_id, status\u003d\u0027ACTIVE\u0027)"},{"line_number":45,"context_line":"        body \u003d self.routers_client.remove_router_interface(router_id,"},{"line_number":46,"context_line":"                                                           subnet_id\u003dsubnet_id)"},{"line_number":47,"context_line":"        self.assertEqual(subnet_id, body[\u0027subnet_id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"8b3f467f_19e7bab2","line":44,"range":{"start_line":44,"start_character":62,"end_line":44,"end_character":68},"in_reply_to":"bfa225ef_c75ec1cf","updated":"2024-10-10 09:24:31.000000000","message":"Done","commit_id":"3bf4c5be27dc4fbf7c643cd4fb712129fc796bfc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e4543d39d34533fdb92badd7896734ba2d8a1ea7","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _remove_router_interface_with_subnet_id(self, router_id, subnet_id,"},{"line_number":42,"context_line":"                                                port_id):"},{"line_number":43,"context_line":"        if not utils.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027):"},{"line_number":44,"context_line":"            waiters.wait_for_port_status(client\u003dself.ports_client,"},{"line_number":45,"context_line":"                                         port_id\u003dport_id, status\u003d\u0027ACTIVE\u0027)"},{"line_number":46,"context_line":"        body \u003d self.routers_client.remove_router_interface(router_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"8733e027_f5cfa091","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":60},"updated":"2024-10-14 18:27:26.000000000","message":"do not we want to do it for dvr? maybe it will be good to add a 1-2 line not about reason just in case we remove this check accidently.","commit_id":"359c62de62ef708523b6f88b1d5672373bb08ed0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"94dd64dcfc7b78e5caae3ffffc95c041b69eee0c","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _remove_router_interface_with_subnet_id(self, router_id, subnet_id,"},{"line_number":42,"context_line":"                                                port_id):"},{"line_number":43,"context_line":"        if not utils.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027):"},{"line_number":44,"context_line":"            waiters.wait_for_port_status(client\u003dself.ports_client,"},{"line_number":45,"context_line":"                                         port_id\u003dport_id, status\u003d\u0027ACTIVE\u0027)"},{"line_number":46,"context_line":"        body \u003d self.routers_client.remove_router_interface(router_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"64d2a9e1_7bf4b3a3","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":60},"in_reply_to":"387e3427_64e6cb5c","updated":"2024-10-15 17:11:14.000000000","message":"thanks for adding notes about it. lgtm","commit_id":"359c62de62ef708523b6f88b1d5672373bb08ed0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a62acf0f82a6665c67ffaeef20fe5c1354086bc5","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _remove_router_interface_with_subnet_id(self, router_id, subnet_id,"},{"line_number":42,"context_line":"                                                port_id):"},{"line_number":43,"context_line":"        if not utils.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027):"},{"line_number":44,"context_line":"            waiters.wait_for_port_status(client\u003dself.ports_client,"},{"line_number":45,"context_line":"                                         port_id\u003dport_id, status\u003d\u0027ACTIVE\u0027)"},{"line_number":46,"context_line":"        body \u003d self.routers_client.remove_router_interface(router_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"387e3427_64e6cb5c","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":60},"in_reply_to":"8733e027_f5cfa091","updated":"2024-10-15 06:00:24.000000000","message":"Right. With DVR, until we have a traffic port connected to the router, we don\u0027t know what agent will host this router interface and won\u0027t be bound.","commit_id":"359c62de62ef708523b6f88b1d5672373bb08ed0"}]}