)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"26eff8ee1680cc11e9e2f07f019c87927fc7870f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"followed by retrieval and then deletion of security group. Deletion"},{"line_number":12,"context_line":"of security group is missing in the testcase."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch also addresses the issue in test_security_groups_create_list_delete"},{"line_number":15,"context_line":"operating on self.security_groups which includes all the security_groups"},{"line_number":16,"context_line":"created by previous test-cases. self.security_groups is not updated when"},{"line_number":17,"context_line":"a security_group is deleted, as we use self.client.delete_security_group for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7adec928_b002ddb1","line":14,"updated":"2014-05-19 06:14:03.000000000","message":"all lines must be wrapped in 72 characters.\n78 \u003e 72\nPlease Refer to :-\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_GIT_commit_message_structure","commit_id":"eeb06df74aa0557c25b638d67d79539e265a546c"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"8ed10da86ebef36a8472e51baebb2c4304a1b597","unresolved":false,"context_lines":[{"line_number":11,"context_line":"followed by retrieval and then deletion of security group. Deletion"},{"line_number":12,"context_line":"of security group is missing in the testcase."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch also addresses the issue in test_security_groups_create_list_delete"},{"line_number":15,"context_line":"operating on self.security_groups which includes all the security_groups"},{"line_number":16,"context_line":"created by previous test-cases. self.security_groups is not updated when"},{"line_number":17,"context_line":"a security_group is deleted, as we use self.client.delete_security_group for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7adec928_34879ab6","line":14,"in_reply_to":"7adec928_b002ddb1","updated":"2014-05-19 07:44:47.000000000","message":"Done","commit_id":"eeb06df74aa0557c25b638d67d79539e265a546c"}],"tempest/api/compute/security_groups/test_security_groups.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"247a2907d085226b6ca660d74381673c7fe9fe83","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        for i in range(3):"},{"line_number":35,"context_line":"            resp, body \u003d self.create_security_group()"},{"line_number":36,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":37,"context_line":"            security_group_list.append(body)"},{"line_number":38,"context_line":"        # Fetch all Security Groups and verify the list"},{"line_number":39,"context_line":"        # has all created Security Groups"},{"line_number":40,"context_line":"        resp, fetched_list \u003d self.client.list_security_groups()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_50b2ae94","line":37,"updated":"2014-05-16 07:45:10.000000000","message":"self.create_security_group() does the same thing internally, so I am not sure this change reason.","commit_id":"a9de8426da136e1ba523c01770b304c16d75025b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"91b99ac3bf17ad6db282823b2d6c897ee9737b1a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        for i in range(3):"},{"line_number":35,"context_line":"            resp, body \u003d self.create_security_group()"},{"line_number":36,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":37,"context_line":"            security_group_list.append(body)"},{"line_number":38,"context_line":"        # Fetch all Security Groups and verify the list"},{"line_number":39,"context_line":"        # has all created Security Groups"},{"line_number":40,"context_line":"        resp, fetched_list \u003d self.client.list_security_groups()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_cdc8ce57","line":37,"in_reply_to":"7adec928_30160256","updated":"2014-05-19 02:38:45.000000000","message":"It is necessary to explain it in the commit message because of https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"a9de8426da136e1ba523c01770b304c16d75025b"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"06615d69d159a47e767152e0a8a27b1078f85818","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        for i in range(3):"},{"line_number":35,"context_line":"            resp, body \u003d self.create_security_group()"},{"line_number":36,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":37,"context_line":"            security_group_list.append(body)"},{"line_number":38,"context_line":"        # Fetch all Security Groups and verify the list"},{"line_number":39,"context_line":"        # has all created Security Groups"},{"line_number":40,"context_line":"        resp, fetched_list \u003d self.client.list_security_groups()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_30160256","line":37,"in_reply_to":"7adec928_50b2ae94","updated":"2014-05-16 07:57:12.000000000","message":"Thanks Kenichi for your review comments. \n\nI explained the reason for the change as part of Bug report - https://bugs.launchpad.net/tempest/+bug/1318644\nand also as a comment in this patch (just before submitting Patch set 2).\nPlease have a look at it.","commit_id":"a9de8426da136e1ba523c01770b304c16d75025b"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"336032798d7d659e32eefe22375ce0072b9627aa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        for i in range(3):"},{"line_number":35,"context_line":"            resp, body \u003d self.create_security_group()"},{"line_number":36,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":37,"context_line":"            security_group_list.append(body)"},{"line_number":38,"context_line":"        # Fetch all Security Groups and verify the list"},{"line_number":39,"context_line":"        # has all created Security Groups"},{"line_number":40,"context_line":"        resp, fetched_list \u003d self.client.list_security_groups()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_3586c2db","line":37,"in_reply_to":"7adec928_cdc8ce57","updated":"2014-05-19 06:01:24.000000000","message":"Yes Kenichi the commit message does not include the description. I\u0027ll update the commit message. Thanks.","commit_id":"a9de8426da136e1ba523c01770b304c16d75025b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"247a2907d085226b6ca660d74381673c7fe9fe83","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                         \"The fetched Security Group is different \""},{"line_number":82,"context_line":"                         \"from the created Group\")"},{"line_number":83,"context_line":"        resp, _ \u003d self.client.delete_security_group(securitygroup[\u0027id\u0027])"},{"line_number":84,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":87,"context_line":"    def test_server_security_groups(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_30ba826e","line":84,"updated":"2014-05-16 07:45:10.000000000","message":"This check is nice, thanks!","commit_id":"a9de8426da136e1ba523c01770b304c16d75025b"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"576fd6130ca3365749e0f3e5b0eba8be20afefe2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # Create 3 Security Groups"},{"line_number":33,"context_line":"        security_group_list \u003d []"},{"line_number":34,"context_line":"        for i in range(3):"},{"line_number":35,"context_line":"            resp, body \u003d self.create_security_group()"},{"line_number":36,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":37,"context_line":"            security_group_list.append(body)"},{"line_number":38,"context_line":"        # Fetch all Security Groups and verify the list"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_90cfa155","line":35,"updated":"2014-05-19 06:19:33.000000000","message":"It\u0027s a suggestion :\nIts better to add  addCleanUp() method for these created security groups.\nNot having the cleanUp can lead the environment to inconsistent state.","commit_id":"eeb06df74aa0557c25b638d67d79539e265a546c"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"6ecc261ac6aab0e7742063f9e60e75ce0bda6925","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # Create 3 Security Groups"},{"line_number":33,"context_line":"        security_group_list \u003d []"},{"line_number":34,"context_line":"        for i in range(3):"},{"line_number":35,"context_line":"            resp, body \u003d self.create_security_group()"},{"line_number":36,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":37,"context_line":"            security_group_list.append(body)"},{"line_number":38,"context_line":"        # Fetch all Security Groups and verify the list"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_1798e076","line":35,"in_reply_to":"7adec928_74be82af","updated":"2014-05-19 07:52:13.000000000","message":"yes, definitely we are deleting them at L51.\nBut what if these tests get failed before L51 ( may be due to some error or interrupt ). Then, those resources will not be deleted.\nWe need to make sure that no test resources should exist in the end.\naddCleanUp() method is executed in the end. So it runs always.","commit_id":"eeb06df74aa0557c25b638d67d79539e265a546c"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"8ed10da86ebef36a8472e51baebb2c4304a1b597","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # Create 3 Security Groups"},{"line_number":33,"context_line":"        security_group_list \u003d []"},{"line_number":34,"context_line":"        for i in range(3):"},{"line_number":35,"context_line":"            resp, body \u003d self.create_security_group()"},{"line_number":36,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":37,"context_line":"            security_group_list.append(body)"},{"line_number":38,"context_line":"        # Fetch all Security Groups and verify the list"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_74be82af","line":35,"in_reply_to":"7adec928_90cfa155","updated":"2014-05-19 07:44:47.000000000","message":"We are deleting the Security Groups created in the test-case at L51.","commit_id":"eeb06df74aa0557c25b638d67d79539e265a546c"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"576fd6130ca3365749e0f3e5b0eba8be20afefe2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                         \"The fetched Security Group is different \""},{"line_number":82,"context_line":"                         \"from the created Group\")"},{"line_number":83,"context_line":"        resp, _ \u003d self.client.delete_security_group(securitygroup[\u0027id\u0027])"},{"line_number":84,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":87,"context_line":"    def test_server_security_groups(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_b0fbbd45","line":84,"updated":"2014-05-19 06:19:33.000000000","message":"as response is 202, its better to have a wait_for_resource_deletion() method here.\n\nand you should also verify the deletion.","commit_id":"eeb06df74aa0557c25b638d67d79539e265a546c"},{"author":{"_account_id":10966,"name":"Abhijeet Jain","email":"abhijeetjpjain@gmail.com","username":"Abhijeet.Jain"},"change_message_id":"6ecc261ac6aab0e7742063f9e60e75ce0bda6925","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                         \"The fetched Security Group is different \""},{"line_number":82,"context_line":"                         \"from the created Group\")"},{"line_number":83,"context_line":"        resp, _ \u003d self.client.delete_security_group(securitygroup[\u0027id\u0027])"},{"line_number":84,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":87,"context_line":"    def test_server_security_groups(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_d7a4b809","line":84,"in_reply_to":"7adec928_94986e1d","updated":"2014-05-19 07:52:13.000000000","message":"yes, and you may need to overwrite the is_resource_deleted() method for that.","commit_id":"eeb06df74aa0557c25b638d67d79539e265a546c"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"8ed10da86ebef36a8472e51baebb2c4304a1b597","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                         \"The fetched Security Group is different \""},{"line_number":82,"context_line":"                         \"from the created Group\")"},{"line_number":83,"context_line":"        resp, _ \u003d self.client.delete_security_group(securitygroup[\u0027id\u0027])"},{"line_number":84,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":87,"context_line":"    def test_server_security_groups(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_94986e1d","line":84,"in_reply_to":"7adec928_b0fbbd45","updated":"2014-05-19 07:44:47.000000000","message":"Ok, will add \"self.client.wait_for_resource_deletion(securitygroup[\u0027id\u0027])\".\n\nThe api, wait_for_resource_deletion, internally validates that securitygroup is deleted before returning True. Thanks for the review.","commit_id":"eeb06df74aa0557c25b638d67d79539e265a546c"}]}