)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5a57f88a06efa6434f4f2757ea27e9ca0eda42e0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"For test VM validation resource were added."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With ec63f4aaf6 change additional creation of test VM was added. New"},{"line_number":10,"context_line":"VM is created without security group specified. It leads to default"},{"line_number":11,"context_line":"security group usage. As there is no allow rules for ssh access in"},{"line_number":12,"context_line":"default security group - ssh check after VM rebuild will fail."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d5fba6f3_affdf59b","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":15},"updated":"2024-11-05 12:20:59.000000000","message":"its better to provide Ia1a57b4d0127baaa614191cc013115732ca1cceb which Gerrit converts to a clickable link to the change","commit_id":"eb49a3ccb2a0b066b7bf372d8b790d701a50e1e3"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"7d562c5d5c89ba8c0c5e67401a539bb12aa45490","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"For test VM validation resource were added."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With ec63f4aaf6 change additional creation of test VM was added. New"},{"line_number":10,"context_line":"VM is created without security group specified. It leads to default"},{"line_number":11,"context_line":"security group usage. As there is no allow rules for ssh access in"},{"line_number":12,"context_line":"default security group - ssh check after VM rebuild will fail."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"a0d415f8_10dcd874","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":15},"in_reply_to":"d5fba6f3_affdf59b","updated":"2024-11-07 06:48:46.000000000","message":"Done","commit_id":"eb49a3ccb2a0b066b7bf372d8b790d701a50e1e3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"c2cd36523c9f6dc7e768af4915db0a7f30cb97eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a5fa813_df5636b5","updated":"2024-10-24 16:07:45.000000000","message":"recheck","commit_id":"3d6cd3f50e8f9ccad033598e2c60cb7885113a40"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"a2d5c0a64bc043b4a0a321ce2bf34e83ca66c54d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a32fe26a_4689cac9","updated":"2024-11-01 12:34:35.000000000","message":"recheck","commit_id":"eb49a3ccb2a0b066b7bf372d8b790d701a50e1e3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d93656377e449c3622c3ff64f4fbecf52ad46ed8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9e45ef70_f16b093a","updated":"2024-12-10 15:31:42.000000000","message":"lgtm","commit_id":"c2d17623503c1166f9fc7e37fb73200a57344d65"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"315b846564842a6dc393fc9f26d9d4ed51acb844","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fc55f7a7_0bd5f916","updated":"2024-12-10 14:25:54.000000000","message":"lgtm","commit_id":"c2d17623503c1166f9fc7e37fb73200a57344d65"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b6eb26a1427011f6c2dcceebb028ca8a6955d8eb","unresolved":true,"context_lines":[{"line_number":127,"context_line":"            self.assertGreater(new_boot_time, boot_time,"},{"line_number":128,"context_line":"                               \u0027%s \u003e %s\u0027 % (new_boot_time, boot_time))"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _test_rebuild_server(self, server_id, **kwargs):"},{"line_number":131,"context_line":"        # Get the IPs the server has before rebuilding it"},{"line_number":132,"context_line":"        original_addresses \u003d (self.client.show_server(server_id)[\u0027server\u0027]"},{"line_number":133,"context_line":"                              [\u0027addresses\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"97c769ef_6ac0690e","line":130,"range":{"start_line":130,"start_character":48,"end_line":130,"end_character":54},"updated":"2024-11-21 10:42:59.000000000","message":"considering that this is a private method and is used (and meant to be used) only in this file, can\u0027t we use self.validation_resources instead of passing it through kwargs?","commit_id":"c2d17623503c1166f9fc7e37fb73200a57344d65"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"27c00f2036eff4bc544c33db0833393a076d4928","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            self.assertGreater(new_boot_time, boot_time,"},{"line_number":128,"context_line":"                               \u0027%s \u003e %s\u0027 % (new_boot_time, boot_time))"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _test_rebuild_server(self, server_id, **kwargs):"},{"line_number":131,"context_line":"        # Get the IPs the server has before rebuilding it"},{"line_number":132,"context_line":"        original_addresses \u003d (self.client.show_server(server_id)[\u0027server\u0027]"},{"line_number":133,"context_line":"                              [\u0027addresses\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"482f9e53_65ea02e3","line":130,"range":{"start_line":130,"start_character":48,"end_line":130,"end_character":54},"in_reply_to":"97c769ef_6ac0690e","updated":"2024-11-24 14:58:27.000000000","message":"I decided to prevent existing self.validation_resources, as it were initialized in parent class \n\n(https://opendev.org/openstack/tempest/src/branch/master/tempest/api/compute/servers/test_server_actions.py#L40)\n\nduring parent class setup and pointed to another VM (created in parent class setup either). So if we create additional VM for particular test, we need to have additional validation resource specially for this new VM. And it seems we need to preserve self.validation_resources. The _test_rebuild_server is used in two tests: test_rebuild_server and test_rebuild_server_with_volume_attached. Both mentioned tests create test VMs outside _test_rebuild_server and even more test_rebuild_server_with_volume_attached create new validation resources for test VM outside _test_rebuild_server.\n\n(https://opendev.org/openstack/tempest/src/branch/master/tempest/api/compute/servers/test_server_actions.py#L450). And more other test_rebuild_server_with_volume_attached doesn\u0027t assign validation resources to self.validation_resources. \n\nThat\u0027s why I decided to add kwargs into _test_rebuild_server.","commit_id":"c2d17623503c1166f9fc7e37fb73200a57344d65"}]}