)]}'
{"tempest/api/identity/admin/test_endpoint.py":[{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"580d80977f496c7b187b3f9c20b998a402a8e7f6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            self.assertEqual(expected[key], endpoint[key])"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        # List the service endpoint"},{"line_number":82,"context_line":"        resp, endpoint_list \u003d self.client.list_endpoints()"},{"line_number":83,"context_line":"        self.assertTrue([element[\u0027id\u0027] is not None for element in endpoint_list"},{"line_number":84,"context_line":"                        if endpoint[\u0027id\u0027] in element[\u0027id\u0027]])"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_22d6d4c5","line":82,"updated":"2014-05-14 12:29:30.000000000","message":"unused variable \"resp\"","commit_id":"c39c475cc78c10537df4c620d073999c27576209"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"109776c63624d3a56e0945c9f9a5bb662696da52","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        expected \u003d {\u0027name\u0027: name, \u0027type\u0027: type, \u0027description\u0027: description}"},{"line_number":49,"context_line":"        resp, service \u003d self.client.create_service("},{"line_number":50,"context_line":"            name, type, description\u003ddescription)"},{"line_number":51,"context_line":"        self.assertFalse(service[\u0027id\u0027] is None)"},{"line_number":52,"context_line":"        self.addCleanup(self._del_service, service[\u0027id\u0027])"},{"line_number":53,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":54,"context_line":"        # Verifying response body of created service"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_1f15cee4","line":51,"updated":"2014-05-23 06:29:47.000000000","message":"may be using self.assertIsNone would be better?","commit_id":"505cbd33b6cb1ef35e761b39b22866607f34b178"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"109776c63624d3a56e0945c9f9a5bb662696da52","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        resp, endpoint \u003d self.client.create_endpoint("},{"line_number":69,"context_line":"            service[\u0027id\u0027], public_url, region\u003dregion, adminurl\u003dadmin_url,"},{"line_number":70,"context_line":"            internalurl\u003dinternal_url)"},{"line_number":71,"context_line":"        self.assertFalse(endpoint[\u0027id\u0027] is None)"},{"line_number":72,"context_line":"        self.addCleanup(self._del_endpoint, endpoint[\u0027id\u0027])"},{"line_number":73,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":74,"context_line":"        # Verifying response body of created service"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_3fd36a39","line":71,"updated":"2014-05-23 06:29:47.000000000","message":"may be using self.assertIsNotNone would be better?","commit_id":"505cbd33b6cb1ef35e761b39b22866607f34b178"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8288e666287e42531b86ad9a1b516a34d077bb85","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            name, type, description\u003ddescription)"},{"line_number":51,"context_line":"        self.assertIsNotNone(service[\u0027id\u0027])"},{"line_number":52,"context_line":"        self.addCleanup(self._del_service, service[\u0027id\u0027])"},{"line_number":53,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":54,"context_line":"        # Verifying response body of created service"},{"line_number":55,"context_line":"        self.assertIn(\u0027id\u0027, service)"},{"line_number":56,"context_line":"        for key in [\u0027name\u0027, \u0027type\u0027, \u0027description\u0027]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_157ccdb4","line":53,"updated":"2014-05-23 08:40:17.000000000","message":"move this before checking the service[\u0027id\u0027]","commit_id":"9148c1d93788b97232157be9920fc799f74fd595"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8288e666287e42531b86ad9a1b516a34d077bb85","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.addCleanup(self._del_service, service[\u0027id\u0027])"},{"line_number":53,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":54,"context_line":"        # Verifying response body of created service"},{"line_number":55,"context_line":"        self.assertIn(\u0027id\u0027, service)"},{"line_number":56,"context_line":"        for key in [\u0027name\u0027, \u0027type\u0027, \u0027description\u0027]:"},{"line_number":57,"context_line":"            self.assertIn(key, service)"},{"line_number":58,"context_line":"            self.assertEqual(expected[key], service[key])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_75443174","line":55,"updated":"2014-05-23 08:40:17.000000000","message":"this check not needed as id has been checked earlier.","commit_id":"9148c1d93788b97232157be9920fc799f74fd595"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8288e666287e42531b86ad9a1b516a34d077bb85","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            internalurl\u003dinternal_url)"},{"line_number":71,"context_line":"        self.assertIsNotNone(endpoint[\u0027id\u0027])"},{"line_number":72,"context_line":"        self.addCleanup(self._del_endpoint, endpoint[\u0027id\u0027])"},{"line_number":73,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":74,"context_line":"        # Verifying response body of created service"},{"line_number":75,"context_line":"        self.assertIn(\u0027id\u0027, endpoint)"},{"line_number":76,"context_line":"        for key in [\u0027service_id\u0027, \u0027region\u0027, \u0027publicurl\u0027, \u0027adminurl\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_d558a559","line":73,"updated":"2014-05-23 08:40:17.000000000","message":"ditto","commit_id":"9148c1d93788b97232157be9920fc799f74fd595"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8288e666287e42531b86ad9a1b516a34d077bb85","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.addCleanup(self._del_endpoint, endpoint[\u0027id\u0027])"},{"line_number":73,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":74,"context_line":"        # Verifying response body of created service"},{"line_number":75,"context_line":"        self.assertIn(\u0027id\u0027, endpoint)"},{"line_number":76,"context_line":"        for key in [\u0027service_id\u0027, \u0027region\u0027, \u0027publicurl\u0027, \u0027adminurl\u0027,"},{"line_number":77,"context_line":"                    \u0027internalurl\u0027]:"},{"line_number":78,"context_line":"            self.assertIn(key, endpoint)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_3531c90b","line":75,"updated":"2014-05-23 08:40:17.000000000","message":"ditto","commit_id":"9148c1d93788b97232157be9920fc799f74fd595"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8288e666287e42531b86ad9a1b516a34d077bb85","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        resp, endpoint_list \u003d self.client.list_endpoints()"},{"line_number":83,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":84,"context_line":"        self.assertTrue([element[\u0027id\u0027] is not None for element in endpoint_list"},{"line_number":85,"context_line":"                        if endpoint[\u0027id\u0027] in element[\u0027id\u0027]])"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # Delete the service endpoint"},{"line_number":88,"context_line":"        resp, _ \u003d self.client.delete_endpoint(endpoint[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_f054cfcb","line":85,"updated":"2014-05-23 08:40:17.000000000","message":"How it will check this-\u003e if endpoint[\u0027id\u0027] in element[\u0027id\u0027]\n\nor more simple to avoid making assertTrue more complex-\n\nfound  \u003d false\nfor element in endpoint_list:\n    if endpoint[\u0027id\u0027] \u003d\u003d element[\u0027id\u0027]\n         found \u003d true\n         break\nassertTrue (found)","commit_id":"9148c1d93788b97232157be9920fc799f74fd595"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4cb7c5f3aa11ff84525ec6c9f266f6f5c8732d29","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        resp, _ \u003d self.client.delete_service(service_id)"},{"line_number":28,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":29,"context_line":"        # Checking whether service is deleted successfully"},{"line_number":30,"context_line":"        self.assertRaises(exceptions.NotFound, self.client.get_service,"},{"line_number":31,"context_line":"                          service_id)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _del_endpoint(self, endpoint_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_cda4ccbb","line":30,"updated":"2014-06-16 22:17:17.000000000","message":"I feel like this is an eventual consistency thing, and I\u0027m not 100% sure that it\u0027s going to be not found by the time delete returns.","commit_id":"b36aa8f8e3793ef3ae1d94a57bf838c96329e52a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ec20589a14b3e0029cd87afdf05c61542222a21e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # Cleanup the endpoint created"},{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            resp, _ \u003d self.client.delete_endpoint(endpoint_id)"},{"line_number":37,"context_line":"            self.assertEqual(204, resp.status)"},{"line_number":38,"context_line":"        except exceptions.NotFound:"},{"line_number":39,"context_line":"            pass"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_5413b065","line":37,"updated":"2014-05-23 13:24:17.000000000","message":"In a normal (successful run) this line is never executed. Because you are deleting the endpoint twice, in addCleanup and L86.\n\nIn _del_endpoint(), client.delete_endpoint() would raise a exceptions.NotFound that will be catched below, but the assertEqual(204, resp.status) L37 will be skipped.\n\nI +1 this, but just wanted to let you know because it\u0027s a bit confusing. I\u0027d instead remove the check of return code in _del_endpoint because you are already doing it L87.","commit_id":"b36aa8f8e3793ef3ae1d94a57bf838c96329e52a"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4cb7c5f3aa11ff84525ec6c9f266f6f5c8732d29","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # Cleanup the endpoint created"},{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            resp, _ \u003d self.client.delete_endpoint(endpoint_id)"},{"line_number":37,"context_line":"            self.assertEqual(204, resp.status)"},{"line_number":38,"context_line":"        except exceptions.NotFound:"},{"line_number":39,"context_line":"            pass"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_6dc6586a","line":37,"in_reply_to":"7adec928_5413b065","updated":"2014-06-16 22:17:17.000000000","message":"Realistically cleanups shouldn\u0027t have asserts in them.","commit_id":"b36aa8f8e3793ef3ae1d94a57bf838c96329e52a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb6030528ca8cd0a21165384002a78e344c938ca","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        resp, service \u003d self.client.create_service("},{"line_number":50,"context_line":"            name, type, description\u003ddescription)"},{"line_number":51,"context_line":"        self.addCleanup(self._del_service, service[\u0027id\u0027])"},{"line_number":52,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":53,"context_line":"        # Verifying response body of created service"},{"line_number":54,"context_line":"        self.assertIn(\u0027id\u0027, service)"},{"line_number":55,"context_line":"        for key in [\u0027name\u0027, \u0027type\u0027, \u0027description\u0027]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_83e7c011","line":52,"updated":"2014-05-23 11:13:23.000000000","message":"Move this before addCleanup as server[\u0027id\u0027] is being fetched there.","commit_id":"b36aa8f8e3793ef3ae1d94a57bf838c96329e52a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6900668f6b676a82140c086ecaf1c0f3cf026af1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        resp, service \u003d self.client.create_service("},{"line_number":50,"context_line":"            name, type, description\u003ddescription)"},{"line_number":51,"context_line":"        self.addCleanup(self._del_service, service[\u0027id\u0027])"},{"line_number":52,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":53,"context_line":"        # Verifying response body of created service"},{"line_number":54,"context_line":"        self.assertIn(\u0027id\u0027, service)"},{"line_number":55,"context_line":"        for key in [\u0027name\u0027, \u0027type\u0027, \u0027description\u0027]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_e9ece5f5","line":52,"in_reply_to":"7adec928_83e7c011","updated":"2014-05-23 12:31:47.000000000","message":"got it.","commit_id":"b36aa8f8e3793ef3ae1d94a57bf838c96329e52a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb6030528ca8cd0a21165384002a78e344c938ca","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            service[\u0027id\u0027], public_url, region\u003dregion, adminurl\u003dadmin_url,"},{"line_number":69,"context_line":"            internalurl\u003dinternal_url)"},{"line_number":70,"context_line":"        self.addCleanup(self._del_endpoint, endpoint[\u0027id\u0027])"},{"line_number":71,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":72,"context_line":"        # Verifying response body of created service"},{"line_number":73,"context_line":"        self.assertIn(\u0027id\u0027, endpoint)"},{"line_number":74,"context_line":"        for key in [\u0027service_id\u0027, \u0027region\u0027, \u0027publicurl\u0027, \u0027adminurl\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_a3e2fcfe","line":71,"updated":"2014-05-23 11:13:23.000000000","message":"ditto","commit_id":"b36aa8f8e3793ef3ae1d94a57bf838c96329e52a"}],"tempest/services/identity/xml/identity_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8288e666287e42531b86ad9a1b516a34d077bb85","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        resp, body \u003d self.post(\u0027endpoints\u0027, str(xml.Document(post_body)))"},{"line_number":140,"context_line":"        return resp, self._parse_resp(body)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"class TokenClientXML(identity_client.TokenClientJSON):"},{"line_number":144,"context_line":"    TYPE \u003d \"xml\""}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_500823d9","line":141,"updated":"2014-05-23 08:40:17.000000000","message":"do not we need  delete and list function?","commit_id":"9148c1d93788b97232157be9920fc799f74fd595"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7c82a0cb269c9ffa18e06c66cc8cf612831f8d66","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        resp, body \u003d self.post(\u0027endpoints\u0027, str(xml.Document(post_body)))"},{"line_number":140,"context_line":"        return resp, self._parse_resp(body)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"class TokenClientXML(identity_client.TokenClientJSON):"},{"line_number":144,"context_line":"    TYPE \u003d \"xml\""}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_09bbd1e5","line":141,"in_reply_to":"7adec928_500823d9","updated":"2014-05-23 12:31:37.000000000","message":"got it","commit_id":"9148c1d93788b97232157be9920fc799f74fd595"}]}