)]}'
{"tempest/api/network/test_networks.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7224484affc3b07882ba59fc43dce26994c99a59","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":404,"context_line":"    def test_create_delete_subnet_with_gw(self):"},{"line_number":405,"context_line":"        net \u003d netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr)"},{"line_number":406,"context_line":"        gateway \u003d str(netaddr.IPAddress(net.first + 2))"},{"line_number":407,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":408,"context_line":"        resp, body \u003d self.client.create_network(name\u003dname)"},{"line_number":409,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_a8df170c","line":406,"updated":"2014-05-15 12:29:29.000000000","message":"The hard coding is bad, agreed. I\u0027m not sure why there is a magic +2 constant here though.","commit_id":"ea73d53cc4f300769e6453e9dff9c327d2eafae8"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"5648296f1960781ec5bedfc7b4890a4319db5951","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":404,"context_line":"    def test_create_delete_subnet_with_gw(self):"},{"line_number":405,"context_line":"        net \u003d netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr)"},{"line_number":406,"context_line":"        gateway \u003d str(netaddr.IPAddress(net.first + 2))"},{"line_number":407,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":408,"context_line":"        resp, body \u003d self.client.create_network(name\u003dname)"},{"line_number":409,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_1f9a2b14","line":406,"in_reply_to":"3ae8d1ca_4b4efcc2","updated":"2014-07-02 16:38:33.000000000","message":"In my previous comments, I mentioned the following four options.\n\n1. Modify the patch to use a LLA as the GW ip. tch.\n2. Even though, specifying the GW ip outside of subnet CIDR (i.e., LLA or GUA) is meaningful only in a provider network scenario,\n   since Neutron allows subnet creation with GW ip part of Subnet CIDR, we can enhance the patch as per the suggestions from sdague \n   (i.e, create Neutron router, attach router interface to the subnet and check that port is configured \n   with Gateway IP specified in subnet). This may fail once option b above is implemented. \n3. Remove the current test-case from tempest as its not a valid use-case. \n4. Merge the patch in the current state as it addresses the issue of hardcoding. \n\nOption 1 can be ignored as the use-case is merged as part of https://review.openstack.org/#/c/93502/8.\n\nOption 2: Neutron does not support this.\nhttps://github.com/openstack/neutron/blob/master/neutron/db/db_base_plugin_v2.py#L584\n\nThe only options now left are Option 3 and 4.  Comments and suggestions are welcome.","commit_id":"ea73d53cc4f300769e6453e9dff9c327d2eafae8"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"9df72da83e71d2c930a49a09be5ef7bbc0dea674","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":404,"context_line":"    def test_create_delete_subnet_with_gw(self):"},{"line_number":405,"context_line":"        net \u003d netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr)"},{"line_number":406,"context_line":"        gateway \u003d str(netaddr.IPAddress(net.first + 2))"},{"line_number":407,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":408,"context_line":"        resp, body \u003d self.client.create_network(name\u003dname)"},{"line_number":409,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_c082b7ff","line":406,"in_reply_to":"7adec928_83bf9ca9","updated":"2014-05-22 16:21:06.000000000","message":"Hi Sean Dague,\n\nAny update on this? As this patch addresses Bug #1318962, which is to remove the hard-coding, can we get this patch through.\n\nJFYI, I\u0027m working on a BP ipv6-testing-parity to bring in parity between IPv4 and IPv6 testcases. I would also be adding new IPV6 tests in tempest. \nI\u0027m happy to address your concern as part of the IPv6 tests that I\u0027m working on.\n\n--Sridhar.","commit_id":"ea73d53cc4f300769e6453e9dff9c327d2eafae8"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"501d488a13a5862d878e66ad3d1a732d2494b670","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":404,"context_line":"    def test_create_delete_subnet_with_gw(self):"},{"line_number":405,"context_line":"        net \u003d netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr)"},{"line_number":406,"context_line":"        gateway \u003d str(netaddr.IPAddress(net.first + 2))"},{"line_number":407,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":408,"context_line":"        resp, body \u003d self.client.create_network(name\u003dname)"},{"line_number":409,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_83bf9ca9","line":406,"in_reply_to":"7adec928_a8df170c","updated":"2014-05-15 13:24:38.000000000","message":"Sorry Sean, I did not get your question. \n\nThe objective of the test case is to verify.\n1. Subnet creation by specifying the Gateway IP which is part of the Subnet CIDR.\n2. Making sure that Subnet is successfully created and the Gateway-ip specified is properly configured in the subnet.\n\nAs we have to pick up some IPAddress in Subnet CIDR as the Gateway-ip, +2 was chosen.","commit_id":"ea73d53cc4f300769e6453e9dff9c327d2eafae8"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"5223a872cf46727d6fdaf10a70dc3f47d46bc243","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":404,"context_line":"    def test_create_delete_subnet_with_gw(self):"},{"line_number":405,"context_line":"        net \u003d netaddr.IPNetwork(CONF.network.tenant_network_v6_cidr)"},{"line_number":406,"context_line":"        gateway \u003d str(netaddr.IPAddress(net.first + 2))"},{"line_number":407,"context_line":"        name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":408,"context_line":"        resp, body \u003d self.client.create_network(name\u003dname)"},{"line_number":409,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_4b4efcc2","line":406,"in_reply_to":"7adec928_c082b7ff","updated":"2014-05-27 16:24:50.000000000","message":"In production, the gateway will most likely be a Link Local Address - I do not know if doing net.first + 2 is advisable. It will \"work\" for the API tests, but most deployments will be using the LLA for the gateway.\n\nIf I recall, we do not prevent people from doing a global address as the gateway, we assume they know what they\u0027re doing.\n\nI would suggest looking into Netaddr\u0027s doc for generating a LLA \n\nhttp://pythonhosted.org/netaddr/api.html?highlight\u003dcompact#mac-addresses-and-the-ieee-eui-standard","commit_id":"ea73d53cc4f300769e6453e9dff9c327d2eafae8"}]}