)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2bd5391041dac1fafd795b75b5720059762184fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f1cda946_aa4dd89a","updated":"2025-01-06 09:49:56.000000000","message":"Thanks Josephine!\n\nPlease see the comments.\nAdditionally, I have two questions:\n\n1. Is it supported to create a volume type with metadata pre-defined?\n2. Similar to volume metadata, is there a difference between updating a specific volume type metadata key and replacing the entire set of volume type metadata?","commit_id":"80c9f514cbd42827fca3a3f80e63e4ceb9e5ab7a"}],"tempest/api/volume/admin/test_volume_types_metadata.py":[{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"7076137d35edba11d3c467248687808747d074fe","unresolved":true,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # Update an existing metadata and create a new metadata"},{"line_number":88,"context_line":"        metadata \u003d {metadata_key: \"val3\", \"key4\": \"val4\"}"},{"line_number":89,"context_line":"        body \u003d self.admin_volume_types_client.create_volume_type_metadata("},{"line_number":90,"context_line":"            self.volume_type[\u0027id\u0027], metadata)[\u0027metadata\u0027]"},{"line_number":91,"context_line":"        self.assertEqual(metadata, body)"},{"line_number":92,"context_line":"        body \u003d self.admin_volume_types_client.list_volume_types_metadata("},{"line_number":93,"context_line":"            self.volume_type[\u0027id\u0027])[\u0027metadata\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"a85478cd_2c9fc1c9","line":90,"range":{"start_line":89,"start_character":8,"end_line":90,"end_character":57},"updated":"2025-01-05 14:03:37.000000000","message":"Not sure if metadata updated here.\nShould we change to `update_volume_type_metadata`?","commit_id":"80c9f514cbd42827fca3a3f80e63e4ceb9e5ab7a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2bd5391041dac1fafd795b75b5720059762184fe","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        self.assertEqual(metadata[metadata_key], body[metadata_key],"},{"line_number":85,"context_line":"                         \"Volume type metadata incorrectly updated\")"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # Update an existing metadata and create a new metadata"},{"line_number":88,"context_line":"        metadata \u003d {metadata_key: \"val3\", \"key4\": \"val4\"}"},{"line_number":89,"context_line":"        body \u003d self.admin_volume_types_client.create_volume_type_metadata("},{"line_number":90,"context_line":"            self.volume_type[\u0027id\u0027], metadata)[\u0027metadata\u0027]"},{"line_number":91,"context_line":"        self.assertEqual(metadata, body)"},{"line_number":92,"context_line":"        body \u003d self.admin_volume_types_client.list_volume_types_metadata("},{"line_number":93,"context_line":"            self.volume_type[\u0027id\u0027])[\u0027metadata\u0027]"},{"line_number":94,"context_line":"        for key in metadata:"},{"line_number":95,"context_line":"            self.assertIn(key, body)"},{"line_number":96,"context_line":"            self.assertEqual(metadata[key], body[key],"},{"line_number":97,"context_line":"                             \"Volume type metadata incorrectly created\")"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @decorators.idempotent_id(\u00278fd34579-77bc-44ec-8606-75b983ff2edf\u0027)"},{"line_number":100,"context_line":"    def test_volume_type_metadata_create_get_delete(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"859f39ad_c78f3396","line":97,"range":{"start_line":87,"start_character":0,"end_line":97,"end_character":72},"updated":"2025-01-06 09:49:56.000000000","message":"I\u0027m not sure about the purpose of this test.\nAre you trying to validate the creation of new metadata after updating the existing metadata?","commit_id":"80c9f514cbd42827fca3a3f80e63e4ceb9e5ab7a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2bd5391041dac1fafd795b75b5720059762184fe","unresolved":true,"context_lines":[{"line_number":113,"context_line":"        self.assertEqual(metadata, body,"},{"line_number":114,"context_line":"                         \"Volume type metadata incorrectly fetched\")"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        self.admin_volume_types_client.delete_volume_type_metadata("},{"line_number":117,"context_line":"            self.volume_type[\u0027id\u0027], metadata_key)"},{"line_number":118,"context_line":"        self.assertRaises("},{"line_number":119,"context_line":"            lib_exc.NotFound,"},{"line_number":120,"context_line":"            self.admin_volume_types_client.show_volume_type_metadata,"}],"source_content_type":"text/x-python","patch_set":13,"id":"ab9f4eb9_34108927","line":117,"range":{"start_line":116,"start_character":0,"end_line":117,"end_character":49},"updated":"2025-01-06 09:49:56.000000000","message":"For safety, it\u0027s better to include a waiter to ensure the resource is fully deleted.","commit_id":"80c9f514cbd42827fca3a3f80e63e4ceb9e5ab7a"}],"tempest/lib/api_schema/response/volume/v3_72/volume_types.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2bd5391041dac1fafd795b75b5720059762184fe","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 ZTE Corporation.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":13,"id":"a11c9e23_84c71166","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":55},"updated":"2025-01-06 09:49:56.000000000","message":"You might want to update the year.","commit_id":"80c9f514cbd42827fca3a3f80e63e4ceb9e5ab7a"}]}