)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"014c5f813be2667038bd5ad105a87d983c555a95","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Nathan Perez \u003cnaperezmail@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-18 16:17:33 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added encryption_id parameter to update_encryption_type and delete_encryption_type to follow OpenStack Documentation. Added encryption_id argument to all uses of both functions. Created an encryption_id variable in test_volume_types.py."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related bug: #1835186"},{"line_number":10,"context_line":"Co-Author: Evan Wever"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"89a3e248_e8fd0f56","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":236},"updated":"2024-11-18 15:45:37.000000000","message":"Please describe not the change itself but why this change is needed.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages would be a good guide to understand how commit message should look like","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":37166,"name":"Nathan","display_name":"Nathan","email":"naperezmail@gmail.com","username":"nathanperez"},"change_message_id":"35fd496d3926a2ccc4475d3738e03ea18cb098b3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nathan Perez \u003cnaperezmail@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-18 16:17:33 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added encryption_id parameter to update_encryption_type and delete_encryption_type to follow OpenStack Documentation. Added encryption_id argument to all uses of both functions. Created an encryption_id variable in test_volume_types.py."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related bug: #1835186"},{"line_number":10,"context_line":"Co-Author: Evan Wever"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5d16c3c4_ccf59443","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":236},"in_reply_to":"89a3e248_e8fd0f56","updated":"2024-11-27 16:25:49.000000000","message":"Done","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"014c5f813be2667038bd5ad105a87d983c555a95","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added encryption_id parameter to update_encryption_type and delete_encryption_type to follow OpenStack Documentation. Added encryption_id argument to all uses of both functions. Created an encryption_id variable in test_volume_types.py."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related bug: #1835186"},{"line_number":10,"context_line":"Co-Author: Evan Wever"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieca29000b5754373e6250818ccf2b3b6d4ef80e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1cd9f791_b351bac8","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":11},"updated":"2024-11-18 15:45:37.000000000","message":"Related-bug","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e60e338bfa28792960eaf158c167d281addfbc2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added encryption_id parameter to update_encryption_type and delete_encryption_type to follow OpenStack Documentation. Added encryption_id argument to all uses of both functions. Created an encryption_id variable in test_volume_types.py."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related bug: #1835186"},{"line_number":10,"context_line":"Co-Author: Evan Wever"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieca29000b5754373e6250818ccf2b3b6d4ef80e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dc5762f8_12102af1","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":11},"in_reply_to":"1cd9f791_b351bac8","updated":"2024-11-26 06:07:59.000000000","message":"Done","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":37166,"name":"Nathan","display_name":"Nathan","email":"naperezmail@gmail.com","username":"nathanperez"},"change_message_id":"35fd496d3926a2ccc4475d3738e03ea18cb098b3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added encryption_id parameter to update_encryption_type and delete_encryption_type to follow OpenStack Documentation. Added encryption_id argument to all uses of both functions. Created an encryption_id variable in test_volume_types.py."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related bug: #1835186"},{"line_number":10,"context_line":"Co-Author: Evan Wever"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieca29000b5754373e6250818ccf2b3b6d4ef80e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"eacfdd18_a77ed0e6","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":11},"in_reply_to":"1cd9f791_b351bac8","updated":"2024-11-27 16:25:49.000000000","message":"Done","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"014c5f813be2667038bd5ad105a87d983c555a95","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Added encryption_id parameter to update_encryption_type and delete_encryption_type to follow OpenStack Documentation. Added encryption_id argument to all uses of both functions. Created an encryption_id variable in test_volume_types.py."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related bug: #1835186"},{"line_number":10,"context_line":"Co-Author: Evan Wever"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieca29000b5754373e6250818ccf2b3b6d4ef80e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"10e9b716_f2aae63b","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":21},"updated":"2024-11-18 15:45:37.000000000","message":"This should be in\n\n```\nCo-Authored-By: NAME \u003cemail address\u003e\n```\n\nformat, as described in the guide I posted above.","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":37166,"name":"Nathan","display_name":"Nathan","email":"naperezmail@gmail.com","username":"nathanperez"},"change_message_id":"35fd496d3926a2ccc4475d3738e03ea18cb098b3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Added encryption_id parameter to update_encryption_type and delete_encryption_type to follow OpenStack Documentation. Added encryption_id argument to all uses of both functions. Created an encryption_id variable in test_volume_types.py."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related bug: #1835186"},{"line_number":10,"context_line":"Co-Author: Evan Wever"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieca29000b5754373e6250818ccf2b3b6d4ef80e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"31541a29_551c3f55","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":21},"in_reply_to":"10e9b716_f2aae63b","updated":"2024-11-27 16:25:49.000000000","message":"Done","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e60e338bfa28792960eaf158c167d281addfbc2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Nathan \u003cnaperezmail@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-25 19:54:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add encryption_id parameter to encryption type methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change replaces `provider` with the `encryption_id`"},{"line_number":10,"context_line":"parameter in the `update_encryption_type` and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ef59c9b_25ac8f01","line":7,"range":{"start_line":7,"start_character":47,"end_line":7,"end_character":54},"updated":"2024-11-26 06:07:59.000000000","message":"The important thing is not adding the argument to the method, but fixing the request url according to API spec.\n\nCould you describe why you need this change, instead of what is changed ?","commit_id":"a351ed755261a86b9396f2c2bc3711654bc789b5"},{"author":{"_account_id":37166,"name":"Nathan","display_name":"Nathan","email":"naperezmail@gmail.com","username":"nathanperez"},"change_message_id":"35fd496d3926a2ccc4475d3738e03ea18cb098b3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nathan \u003cnaperezmail@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-25 19:54:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add encryption_id parameter to encryption type methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change replaces `provider` with the `encryption_id`"},{"line_number":10,"context_line":"parameter in the `update_encryption_type` and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"30968b5d_c20439c8","line":7,"range":{"start_line":7,"start_character":47,"end_line":7,"end_character":54},"in_reply_to":"1ef59c9b_25ac8f01","updated":"2024-11-27 16:25:49.000000000","message":"Done","commit_id":"a351ed755261a86b9396f2c2bc3711654bc789b5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e60e338bfa28792960eaf158c167d281addfbc2","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This change replaces `provider` with the `encryption_id`"},{"line_number":10,"context_line":"parameter in the `update_encryption_type` and"},{"line_number":11,"context_line":"`delete_encryption_type` methods to comply with"},{"line_number":12,"context_line":"OpenStack documentation. It also updates all"},{"line_number":13,"context_line":"references to these methods to include the"},{"line_number":14,"context_line":"`encryption_id` argument."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Related-bug: #1835186"},{"line_number":17,"context_line":"Co-Author: Evan Wever evan.wever@gmail.com"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"aa2746cd_52de6179","line":14,"range":{"start_line":12,"start_character":25,"end_line":14,"end_character":25},"updated":"2024-11-26 06:07:59.000000000","message":"This explains the change needed in internal logic so I\u0027d suggest removing it.","commit_id":"a351ed755261a86b9396f2c2bc3711654bc789b5"},{"author":{"_account_id":37166,"name":"Nathan","display_name":"Nathan","email":"naperezmail@gmail.com","username":"nathanperez"},"change_message_id":"35fd496d3926a2ccc4475d3738e03ea18cb098b3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change replaces `provider` with the `encryption_id`"},{"line_number":10,"context_line":"parameter in the `update_encryption_type` and"},{"line_number":11,"context_line":"`delete_encryption_type` methods to comply with"},{"line_number":12,"context_line":"OpenStack documentation. It also updates all"},{"line_number":13,"context_line":"references to these methods to include the"},{"line_number":14,"context_line":"`encryption_id` argument."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Related-bug: #1835186"},{"line_number":17,"context_line":"Co-Author: Evan Wever evan.wever@gmail.com"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba48163a_bf0534db","line":14,"range":{"start_line":12,"start_character":25,"end_line":14,"end_character":25},"in_reply_to":"aa2746cd_52de6179","updated":"2024-11-27 16:25:49.000000000","message":"Done","commit_id":"a351ed755261a86b9396f2c2bc3711654bc789b5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e60e338bfa28792960eaf158c167d281addfbc2","unresolved":true,"context_lines":[{"line_number":14,"context_line":"`encryption_id` argument."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Related-bug: #1835186"},{"line_number":17,"context_line":"Co-Author: Evan Wever evan.wever@gmail.com"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ieca29000b5754373e6250818ccf2b3b6d4ef80e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"01a2f356_b8b272c3","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":42},"updated":"2024-11-26 06:07:59.000000000","message":"The format is still wrong. I don\u0027t know if you have read the guide I shared, really.","commit_id":"a351ed755261a86b9396f2c2bc3711654bc789b5"},{"author":{"_account_id":37166,"name":"Nathan","display_name":"Nathan","email":"naperezmail@gmail.com","username":"nathanperez"},"change_message_id":"35fd496d3926a2ccc4475d3738e03ea18cb098b3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"`encryption_id` argument."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Related-bug: #1835186"},{"line_number":17,"context_line":"Co-Author: Evan Wever evan.wever@gmail.com"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ieca29000b5754373e6250818ccf2b3b6d4ef80e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ebbd758_9d8371b9","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":42},"in_reply_to":"01a2f356_b8b272c3","updated":"2024-11-27 16:25:49.000000000","message":"Done","commit_id":"a351ed755261a86b9396f2c2bc3711654bc789b5"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c80944fcc3d6d8817082775e9f781e6a90da9655","unresolved":true,"context_lines":[{"line_number":18,"context_line":"`encryption_id` is only used for Cinder"},{"line_number":19,"context_line":"notifications."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Related-bug: #1835186"},{"line_number":22,"context_line":"Co-Authored-By: Evan Wever \u003cevan.wever@gmail.com\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ieca29000b5754373e6250818ccf2b3b6d4ef80e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9c665ab4_23570088","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":7},"updated":"2024-12-10 13:59:01.000000000","message":"just related? I think you could use:\nCloses-bug \nso that the LP gets closed automatically when this merges.","commit_id":"36d2d88ffa62fccd128e3c4e4f15cf315e04139b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"014c5f813be2667038bd5ad105a87d983c555a95","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c924c5e_5b4d73ed","updated":"2024-11-18 15:45:37.000000000","message":"Leaving a few workflow/format related feedback. As I wrote in my comment this may needs to be squashed into 924169","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":37166,"name":"Nathan","display_name":"Nathan","email":"naperezmail@gmail.com","username":"nathanperez"},"change_message_id":"35fd496d3926a2ccc4475d3738e03ea18cb098b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6580c572_01034e3a","in_reply_to":"0c924c5e_5b4d73ed","updated":"2024-11-27 16:25:49.000000000","message":"Thanking you for your input! I appreciate you taking the time to help me out and look at the patch","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"e25572dc2997ddffa77f59f01d19986a047bc933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f62c066d_323a22ea","updated":"2024-11-19 08:55:28.000000000","message":"You have to fix the unit tests as well. The unit test can be executed like this on your local env prior to pushing the change to Gerrit:\n\n```\ntox -epy310\n```\n\nTry to take a look at this and think about how you can approach fixing the unit tests. If something is not clear you can ping me:).\n\n[1] https://opendev.org/openstack/tempest/src/commit/082ec1933c62441d31ec1cd5b896561f947aa5e6/tempest/tests/lib/services/volume/v3/test_encryption_types_client.py#L103\n[2] https://opendev.org/openstack/tempest/src/commit/082ec1933c62441d31ec1cd5b896561f947aa5e6/tempest/tests/lib/services/volume/v3/test_encryption_types_client.py#L114\n[3] https://opendev.org/openstack/tempest/src/commit/082ec1933c62441d31ec1cd5b896561f947aa5e6/tempest/tests/lib/services/volume/v3/test_encryption_types_client.py#L111","commit_id":"ca97c74b03f5c9e38aee5e558c45ea32fc784dfa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b33861086fabe849bec2461d8b8e85d42d14ddb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"44d72f5c_521c3436","updated":"2024-12-10 15:30:46.000000000","message":"lgtm","commit_id":"5e1a714cfe3ba78c1fb8e60f06f91a864584bec5"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"9ceebe31b04d5c6d5fe1a34d6adf1f1aa0420c18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"2b805dd7_dac0f64a","updated":"2024-12-12 08:51:34.000000000","message":"recheck\ntempest-full-enforce-scope-new-defaults seems to be flaky","commit_id":"5e1a714cfe3ba78c1fb8e60f06f91a864584bec5"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ca7d74e4fad057bfa8d0edfc30fbfedf3837f761","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"38482fb5_f31e8be3","updated":"2024-12-11 22:24:55.000000000","message":"recheck a job TIMED_OUT","commit_id":"5e1a714cfe3ba78c1fb8e60f06f91a864584bec5"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9a87b92a76f7fe7933fd2f71cd18238ce80fc313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"b33a385f_37351fe5","updated":"2024-12-11 08:16:01.000000000","message":"recheck test_server_connectivity_live_migration had a long downtime","commit_id":"5e1a714cfe3ba78c1fb8e60f06f91a864584bec5"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b41960e491219799a19266df4635def91878fa9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c49c9621_e341f9fe","updated":"2024-12-10 15:22:15.000000000","message":"thanks","commit_id":"5e1a714cfe3ba78c1fb8e60f06f91a864584bec5"}],"tempest/api/compute/flavors/test_flavors.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e60e338bfa28792960eaf158c167d281addfbc2","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from tempest.api.compute import base"},{"line_number":17,"context_line":"from tempest.lib import decorators"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class FlavorsV2TestJSON(base.BaseV2ComputeTest):"},{"line_number":21,"context_line":"    \"\"\"Tests Flavors\"\"\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"49526c24_2f5b946a","side":"PARENT","line":19,"updated":"2024-11-26 06:07:59.000000000","message":"This shouldn\u0027t be removed","commit_id":"ac8ca421b96115c228640c1993e10ae5411c259a"},{"author":{"_account_id":37166,"name":"Nathan","display_name":"Nathan","email":"naperezmail@gmail.com","username":"nathanperez"},"change_message_id":"35fd496d3926a2ccc4475d3738e03ea18cb098b3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from tempest.api.compute import base"},{"line_number":17,"context_line":"from tempest.lib import decorators"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class FlavorsV2TestJSON(base.BaseV2ComputeTest):"},{"line_number":21,"context_line":"    \"\"\"Tests Flavors\"\"\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"e409dbcd_f8093abf","side":"PARENT","line":19,"in_reply_to":"49526c24_2f5b946a","updated":"2024-11-27 16:25:49.000000000","message":"Done","commit_id":"ac8ca421b96115c228640c1993e10ae5411c259a"}],"tempest/lib/services/volume/v3/encryption_types_client.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"014c5f813be2667038bd5ad105a87d983c555a95","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    def delete_encryption_type(self, volume_type_id, encryption_id):"},{"line_number":73,"context_line":"        \"\"\"Delete the encryption type for the specified volume-type.\"\"\""},{"line_number":74,"context_line":"        resp, body \u003d self.delete("},{"line_number":75,"context_line":"            \"/types/%s/encryption/%s\" % (volume_type_id, encryption_id))"},{"line_number":76,"context_line":"        self.validate_response(schema.delete_encryption_type, resp, body)"},{"line_number":77,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a746240c_61eaf2f5","line":75,"range":{"start_line":75,"start_character":57,"end_line":75,"end_character":70},"updated":"2024-11-18 15:45:37.000000000","message":"This indicates that the previous commit is incomplete? Then this should be squashed into the parent change instead of being submitted as a separate commit.","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":37166,"name":"Nathan","display_name":"Nathan","email":"naperezmail@gmail.com","username":"nathanperez"},"change_message_id":"35fd496d3926a2ccc4475d3738e03ea18cb098b3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def delete_encryption_type(self, volume_type_id, encryption_id):"},{"line_number":73,"context_line":"        \"\"\"Delete the encryption type for the specified volume-type.\"\"\""},{"line_number":74,"context_line":"        resp, body \u003d self.delete("},{"line_number":75,"context_line":"            \"/types/%s/encryption/%s\" % (volume_type_id, encryption_id))"},{"line_number":76,"context_line":"        self.validate_response(schema.delete_encryption_type, resp, body)"},{"line_number":77,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9d2d3a44_889bc0e7","line":75,"range":{"start_line":75,"start_character":57,"end_line":75,"end_character":70},"in_reply_to":"a746240c_61eaf2f5","updated":"2024-11-27 16:25:49.000000000","message":"Done","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e60e338bfa28792960eaf158c167d281addfbc2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def delete_encryption_type(self, volume_type_id, encryption_id):"},{"line_number":73,"context_line":"        \"\"\"Delete the encryption type for the specified volume-type.\"\"\""},{"line_number":74,"context_line":"        resp, body \u003d self.delete("},{"line_number":75,"context_line":"            \"/types/%s/encryption/%s\" % (volume_type_id, encryption_id))"},{"line_number":76,"context_line":"        self.validate_response(schema.delete_encryption_type, resp, body)"},{"line_number":77,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e04c4545_3388fce1","line":75,"range":{"start_line":75,"start_character":57,"end_line":75,"end_character":70},"in_reply_to":"a746240c_61eaf2f5","updated":"2024-11-26 06:07:59.000000000","message":"Done","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"014c5f813be2667038bd5ad105a87d983c555a95","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        self.validate_response(schema.delete_encryption_type, resp, body)"},{"line_number":77,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def update_encryption_type(self, volume_type_id, **kwargs, encryption_id):"},{"line_number":80,"context_line":"        \"\"\"Update an encryption type for an existing volume type."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":1,"id":"b4a34e2c_2adf48e2","line":79,"range":{"start_line":79,"start_character":63,"end_line":79,"end_character":76},"updated":"2024-11-18 15:45:37.000000000","message":"This should come before **kwargs .","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":37166,"name":"Nathan","display_name":"Nathan","email":"naperezmail@gmail.com","username":"nathanperez"},"change_message_id":"35fd496d3926a2ccc4475d3738e03ea18cb098b3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.validate_response(schema.delete_encryption_type, resp, body)"},{"line_number":77,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def update_encryption_type(self, volume_type_id, **kwargs, encryption_id):"},{"line_number":80,"context_line":"        \"\"\"Update an encryption type for an existing volume type."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd447155_1dfdeea7","line":79,"range":{"start_line":79,"start_character":63,"end_line":79,"end_character":76},"in_reply_to":"b4a34e2c_2adf48e2","updated":"2024-11-27 16:25:49.000000000","message":"Done","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e60e338bfa28792960eaf158c167d281addfbc2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.validate_response(schema.delete_encryption_type, resp, body)"},{"line_number":77,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def update_encryption_type(self, volume_type_id, **kwargs, encryption_id):"},{"line_number":80,"context_line":"        \"\"\"Update an encryption type for an existing volume type."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":1,"id":"d5a03309_6602b607","line":79,"range":{"start_line":79,"start_character":63,"end_line":79,"end_character":76},"in_reply_to":"b4a34e2c_2adf48e2","updated":"2024-11-26 06:07:59.000000000","message":"Done","commit_id":"19f3fa45985520b7c8c302b5f6ccb52dbd034b17"}]}