)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"43325d9d2f785b3b3740a5645c85f411a1f0f010","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"117fd2c5_24c6da1e","updated":"2025-01-05 10:19:30.000000000","message":"Thanks Roman!\nPlease check the comments. However, I\u0027m not entirely convinced about this approach. I believe these tests are already covered. If your goal is to test a Windows image, it seems more appropriate to create a dedicated Zuul job and set the Windows image using the existing \"image_ref\" configuration option.","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"}],"tempest/api/compute/admin/test_create_server.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"43325d9d2f785b3b3740a5645c85f411a1f0f010","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        super(WindowsServersBaseTest, cls).setup_clients()"},{"line_number":165,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _test_create_server(self):"},{"line_number":168,"context_line":"        # Create the server and wait for it to become ready"},{"line_number":169,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":170,"context_line":"            self.os_primary)"},{"line_number":171,"context_line":"        self.create_test_server("},{"line_number":172,"context_line":"            image_id\u003dself.image_id,"},{"line_number":173,"context_line":"            flavor\u003dself.flavor_id,"},{"line_number":174,"context_line":"            validatable\u003dTrue,"},{"line_number":175,"context_line":"            validation_resources\u003dvalidation_resources,"},{"line_number":176,"context_line":"            wait_until\u003d\u0027PINGABLE\u0027)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _test_live_migration(self):"},{"line_number":179,"context_line":"        block_migration \u003d (CONF.compute_feature_enabled."}],"source_content_type":"text/x-python","patch_set":2,"id":"9ae7d338_5516efb9","line":176,"range":{"start_line":167,"start_character":0,"end_line":176,"end_character":34},"updated":"2025-01-05 10:19:30.000000000","message":"Please ensure the server is cleaned up at the end of the test, as the create_test_server method performs cleanup at the class level.","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":35840,"name":"Roman Bubyr","email":"rbubyr@mirantis.com","username":"rbubyr","status":"Mirantis"},"change_message_id":"03557e03698cacb345b1683db9b53d15b2d2242f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        super(WindowsServersBaseTest, cls).setup_clients()"},{"line_number":165,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _test_create_server(self):"},{"line_number":168,"context_line":"        # Create the server and wait for it to become ready"},{"line_number":169,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":170,"context_line":"            self.os_primary)"},{"line_number":171,"context_line":"        self.create_test_server("},{"line_number":172,"context_line":"            image_id\u003dself.image_id,"},{"line_number":173,"context_line":"            flavor\u003dself.flavor_id,"},{"line_number":174,"context_line":"            validatable\u003dTrue,"},{"line_number":175,"context_line":"            validation_resources\u003dvalidation_resources,"},{"line_number":176,"context_line":"            wait_until\u003d\u0027PINGABLE\u0027)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _test_live_migration(self):"},{"line_number":179,"context_line":"        block_migration \u003d (CONF.compute_feature_enabled."}],"source_content_type":"text/x-python","patch_set":2,"id":"5271215c_eaeeb302","line":176,"range":{"start_line":167,"start_character":0,"end_line":176,"end_character":34},"in_reply_to":"9ae7d338_5516efb9","updated":"2025-01-24 15:14:35.000000000","message":"Done","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"43325d9d2f785b3b3740a5645c85f411a1f0f010","unresolved":true,"context_lines":[{"line_number":175,"context_line":"            validation_resources\u003dvalidation_resources,"},{"line_number":176,"context_line":"            wait_until\u003d\u0027PINGABLE\u0027)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _test_live_migration(self):"},{"line_number":179,"context_line":"        block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":180,"context_line":"                           block_migration_for_live_migration)"},{"line_number":181,"context_line":"        disk_over_commit \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"1e0402d6_c1f0b304","line":178,"range":{"start_line":178,"start_character":4,"end_line":178,"end_character":35},"updated":"2025-01-05 10:19:30.000000000","message":"Same","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"43325d9d2f785b3b3740a5645c85f411a1f0f010","unresolved":true,"context_lines":[{"line_number":179,"context_line":"        block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":180,"context_line":"                           block_migration_for_live_migration)"},{"line_number":181,"context_line":"        disk_over_commit \u003d False"},{"line_number":182,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":183,"context_line":"            self.os_primary)"},{"line_number":184,"context_line":"        server_id \u003d self.create_test_server("},{"line_number":185,"context_line":"            image_id\u003dself.image_id,"},{"line_number":186,"context_line":"            flavor\u003dself.flavor_id,"},{"line_number":187,"context_line":"            validatable\u003dTrue,"},{"line_number":188,"context_line":"            validation_resources\u003dvalidation_resources,"},{"line_number":189,"context_line":"            wait_until\u003d\u0027PINGABLE\u0027)[\u0027id\u0027]"},{"line_number":190,"context_line":"        source_host \u003d self.get_host_for_server(server_id)"},{"line_number":191,"context_line":"        if not CONF.compute_feature_enabled.can_migrate_between_any_hosts:"},{"line_number":192,"context_line":"            # not to specify a host so that the scheduler will pick one"}],"source_content_type":"text/x-python","patch_set":2,"id":"0a01c732_c86fdcd6","line":189,"range":{"start_line":182,"start_character":0,"end_line":189,"end_character":40},"updated":"2025-01-05 10:19:30.000000000","message":"If a method already exists for this, why not use it instead of duplicating the code?","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"43325d9d2f785b3b3740a5645c85f411a1f0f010","unresolved":true,"context_lines":[{"line_number":203,"context_line":"        destination_host \u003d self.get_host_for_server(server_id)"},{"line_number":204,"context_line":"        self.assertNotEqual(source_host, destination_host)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _test_cold_migration(self):"},{"line_number":207,"context_line":"        # Run as admin to allow migrate tpm secret"},{"line_number":208,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":209,"context_line":"            self.os_admin)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a3ab00f6_6a86f2c2","line":206,"range":{"start_line":206,"start_character":8,"end_line":206,"end_character":34},"updated":"2025-01-05 10:19:30.000000000","message":"Same","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1690464f2370e4b99ee70c4b8824b23f2ca225b8","unresolved":true,"context_lines":[{"line_number":204,"context_line":"        self.assertNotEqual(source_host, destination_host)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _test_cold_migration(self):"},{"line_number":207,"context_line":"        # Run as admin to allow migrate tpm secret"},{"line_number":208,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":209,"context_line":"            self.os_admin)"},{"line_number":210,"context_line":"        server_id \u003d self.create_test_server("}],"source_content_type":"text/x-python","patch_set":2,"id":"17df5476_05696d1d","line":207,"updated":"2025-01-02 18:09:13.000000000","message":"Is this the actual difference from the base test? This is also not a windows-specific requirement, as linux instances with TPM have the same limitation currently. Seems better to either make the base test check for TPM and do this for all, or maybe better to not codify this current limitation in tests.","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"f9fef27cb2da9bbef391e0960d62b18f3d3469dd","unresolved":true,"context_lines":[{"line_number":204,"context_line":"        self.assertNotEqual(source_host, destination_host)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _test_cold_migration(self):"},{"line_number":207,"context_line":"        # Run as admin to allow migrate tpm secret"},{"line_number":208,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":209,"context_line":"            self.os_admin)"},{"line_number":210,"context_line":"        server_id \u003d self.create_test_server("}],"source_content_type":"text/x-python","patch_set":2,"id":"520b841b_4f02f645","line":207,"in_reply_to":"17df5476_05696d1d","updated":"2025-01-24 17:18:32.000000000","message":"This point still stands, and in general the point about having the operating system name in the class name.","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"43325d9d2f785b3b3740a5645c85f411a1f0f010","unresolved":true,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _test_cold_migration(self):"},{"line_number":207,"context_line":"        # Run as admin to allow migrate tpm secret"},{"line_number":208,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":209,"context_line":"            self.os_admin)"},{"line_number":210,"context_line":"        server_id \u003d self.create_test_server("},{"line_number":211,"context_line":"            clients\u003dself.os_admin,"},{"line_number":212,"context_line":"            image_id\u003dself.image_id,"},{"line_number":213,"context_line":"            flavor\u003dself.flavor_id,"},{"line_number":214,"context_line":"            validatable\u003dTrue,"},{"line_number":215,"context_line":"            validation_resources\u003dvalidation_resources,"},{"line_number":216,"context_line":"            wait_until\u003d\u0027PINGABLE\u0027)[\u0027id\u0027]"},{"line_number":217,"context_line":"        source_host \u003d self.get_host_for_server(server_id)"},{"line_number":218,"context_line":"        self.admin_servers_client.migrate_server(server_id)"},{"line_number":219,"context_line":"        waiters.wait_for_server_status(self.admin_servers_client,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e23e958d_2f92b315","line":216,"range":{"start_line":208,"start_character":0,"end_line":216,"end_character":40},"updated":"2025-01-05 10:19:30.000000000","message":"Same","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"43325d9d2f785b3b3740a5645c85f411a1f0f010","unresolved":true,"context_lines":[{"line_number":224,"context_line":"        destination_host \u003d self.get_host_for_server(server_id)"},{"line_number":225,"context_line":"        self.assertNotEqual(source_host, destination_host)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def _test_create_server_from_volume(self):"},{"line_number":228,"context_line":"        size \u003d self._get_flavor_disc_size()"},{"line_number":229,"context_line":"        volume_bootable \u003d self.create_volume("},{"line_number":230,"context_line":"            image_ref\u003dself.image_id, size\u003dsize)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1b2f6b5b_97ede1c0","line":227,"range":{"start_line":227,"start_character":4,"end_line":227,"end_character":46},"updated":"2025-01-05 10:19:30.000000000","message":"same","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"43325d9d2f785b3b3740a5645c85f411a1f0f010","unresolved":true,"context_lines":[{"line_number":233,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":234,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":235,"context_line":"            \u0027boot_index\u0027: 0}]"},{"line_number":236,"context_line":"        validation_resources \u003d self.get_class_validation_resources("},{"line_number":237,"context_line":"            self.os_admin)"},{"line_number":238,"context_line":"        self.create_test_server("},{"line_number":239,"context_line":"            image_id\u003d\u0027\u0027,"},{"line_number":240,"context_line":"            flavor\u003dself.flavor_id,"},{"line_number":241,"context_line":"            clients\u003dself.os_admin,"},{"line_number":242,"context_line":"            validatable\u003dTrue,"},{"line_number":243,"context_line":"            validation_resources\u003dvalidation_resources,"},{"line_number":244,"context_line":"            wait_until\u003d\u0027PINGABLE\u0027,"},{"line_number":245,"context_line":"            block_device_mapping_v2\u003dbdm"},{"line_number":246,"context_line":"        )"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def _get_flavor_disc_size(self):"},{"line_number":249,"context_line":"        # Returns a disc size of a flavor"}],"source_content_type":"text/x-python","patch_set":2,"id":"66e84e24_1ab94f60","line":246,"range":{"start_line":236,"start_character":0,"end_line":246,"end_character":9},"updated":"2025-01-05 10:19:30.000000000","message":"Same","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"43325d9d2f785b3b3740a5645c85f411a1f0f010","unresolved":true,"context_lines":[{"line_number":245,"context_line":"            block_device_mapping_v2\u003dbdm"},{"line_number":246,"context_line":"        )"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def _get_flavor_disc_size(self):"},{"line_number":249,"context_line":"        # Returns a disc size of a flavor"},{"line_number":250,"context_line":"        flavor \u003d self.admin_flavors_client.show_flavor(self.flavor_id)["},{"line_number":251,"context_line":"            \u0027flavor\u0027]"},{"line_number":252,"context_line":"        return flavor[\u0027disk\u0027]"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"class WindowsServers10Test(WindowsServersBaseTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"17f26455_a30c1337","line":252,"range":{"start_line":248,"start_character":0,"end_line":252,"end_character":29},"updated":"2025-01-05 10:19:30.000000000","message":"What is the reason for creating a separate method for this, especially when it\u0027s only used once?","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":35840,"name":"Roman Bubyr","email":"rbubyr@mirantis.com","username":"rbubyr","status":"Mirantis"},"change_message_id":"03557e03698cacb345b1683db9b53d15b2d2242f","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            block_device_mapping_v2\u003dbdm"},{"line_number":246,"context_line":"        )"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def _get_flavor_disc_size(self):"},{"line_number":249,"context_line":"        # Returns a disc size of a flavor"},{"line_number":250,"context_line":"        flavor \u003d self.admin_flavors_client.show_flavor(self.flavor_id)["},{"line_number":251,"context_line":"            \u0027flavor\u0027]"},{"line_number":252,"context_line":"        return flavor[\u0027disk\u0027]"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"class WindowsServers10Test(WindowsServersBaseTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"84e239d2_b23bb205","line":252,"range":{"start_line":248,"start_character":0,"end_line":252,"end_character":29},"in_reply_to":"17f26455_a30c1337","updated":"2025-01-24 15:14:35.000000000","message":"Done","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1690464f2370e4b99ee70c4b8824b23f2ca225b8","unresolved":true,"context_lines":[{"line_number":255,"context_line":"class WindowsServers10Test(WindowsServersBaseTest):"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    image_id \u003d CONF.compute.windows10_image_ref"},{"line_number":258,"context_line":"    flavor_id \u003d CONF.compute.windows10_flavor_ref"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    @decorators.idempotent_id(\u00274d54bcfa-08d3-48eb-b7a1-3568db4fc607\u0027)"},{"line_number":261,"context_line":"    def test_create_server(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5e6c13ac_f59ab6a8","line":258,"updated":"2025-01-02 18:09:13.000000000","message":"I could be wrong, but I think the tempest team will argue that we shouldn\u0027t have guest-OS-specific tests like this. I certainly think that for something so basic like this, having a whole windows copy (or two) of these tests just to enable some special config and use a different image is not the best plan.\n\nShouldn\u0027t we solve this by using a flavor with tpm enabled, as well as the generic TPM check mentioned above, if we\u0027re going to switch to using admin for migrations in that case?","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":35840,"name":"Roman Bubyr","email":"rbubyr@mirantis.com","username":"rbubyr","status":"Mirantis"},"change_message_id":"03557e03698cacb345b1683db9b53d15b2d2242f","unresolved":false,"context_lines":[{"line_number":255,"context_line":"class WindowsServers10Test(WindowsServersBaseTest):"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    image_id \u003d CONF.compute.windows10_image_ref"},{"line_number":258,"context_line":"    flavor_id \u003d CONF.compute.windows10_flavor_ref"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    @decorators.idempotent_id(\u00274d54bcfa-08d3-48eb-b7a1-3568db4fc607\u0027)"},{"line_number":261,"context_line":"    def test_create_server(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"71f9d4c3_c75c4e9a","line":258,"in_reply_to":"051baddd_827652a1","updated":"2025-01-24 15:14:35.000000000","message":"Done","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1957e22030803e7261de1e6d3fc5aa7904095147","unresolved":true,"context_lines":[{"line_number":255,"context_line":"class WindowsServers10Test(WindowsServersBaseTest):"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    image_id \u003d CONF.compute.windows10_image_ref"},{"line_number":258,"context_line":"    flavor_id \u003d CONF.compute.windows10_flavor_ref"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    @decorators.idempotent_id(\u00274d54bcfa-08d3-48eb-b7a1-3568db4fc607\u0027)"},{"line_number":261,"context_line":"    def test_create_server(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"051baddd_827652a1","line":258,"in_reply_to":"5e6c13ac_f59ab6a8","updated":"2025-01-10 13:54:15.000000000","message":"I agree with Dan.","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"}],"tempest/config.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"43325d9d2f785b3b3740a5645c85f411a1f0f010","unresolved":true,"context_lines":[{"line_number":314,"context_line":"                help\u003d\"A list of trusted certificates to be used when the \""},{"line_number":315,"context_line":"                     \"image certificate validation compute feature is \""},{"line_number":316,"context_line":"                     \"enabled.\"),"},{"line_number":317,"context_line":"    cfg.StrOpt(\u0027windows10_image_ref\u0027,"},{"line_number":318,"context_line":"               default\u003dNone,"},{"line_number":319,"context_line":"               help\u003d\"Valid image reference to be used in Windows 10 tests.\"),"},{"line_number":320,"context_line":"    cfg.StrOpt(\u0027windows11_image_ref\u0027,"},{"line_number":321,"context_line":"               default\u003dNone,"},{"line_number":322,"context_line":"               help\u003d\"Valid image reference to be used in Windows 11 tests.\"),"},{"line_number":323,"context_line":"    cfg.StrOpt(\u0027flavor_ref\u0027,"},{"line_number":324,"context_line":"               default\u003d\"1\","},{"line_number":325,"context_line":"               help\u003d\"Valid primary flavor to use in tests.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"19158650_0f94c1eb","line":322,"range":{"start_line":317,"start_character":0,"end_line":322,"end_character":77},"updated":"2025-01-05 10:19:30.000000000","message":"There\u0027s no need to add a new configuration option; you can use the existing one, \"image_ref.\"","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":35840,"name":"Roman Bubyr","email":"rbubyr@mirantis.com","username":"rbubyr","status":"Mirantis"},"change_message_id":"1ff616bb49aa19d41c517e8b4e39422b44635de6","unresolved":true,"context_lines":[{"line_number":314,"context_line":"                help\u003d\"A list of trusted certificates to be used when the \""},{"line_number":315,"context_line":"                     \"image certificate validation compute feature is \""},{"line_number":316,"context_line":"                     \"enabled.\"),"},{"line_number":317,"context_line":"    cfg.StrOpt(\u0027windows10_image_ref\u0027,"},{"line_number":318,"context_line":"               default\u003dNone,"},{"line_number":319,"context_line":"               help\u003d\"Valid image reference to be used in Windows 10 tests.\"),"},{"line_number":320,"context_line":"    cfg.StrOpt(\u0027windows11_image_ref\u0027,"},{"line_number":321,"context_line":"               default\u003dNone,"},{"line_number":322,"context_line":"               help\u003d\"Valid image reference to be used in Windows 11 tests.\"),"},{"line_number":323,"context_line":"    cfg.StrOpt(\u0027flavor_ref\u0027,"},{"line_number":324,"context_line":"               default\u003d\"1\","},{"line_number":325,"context_line":"               help\u003d\"Valid primary flavor to use in tests.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"d0fa902d_2cc20113","line":322,"range":{"start_line":317,"start_character":0,"end_line":322,"end_character":77},"in_reply_to":"19158650_0f94c1eb","updated":"2025-01-13 16:49:40.000000000","message":"Usually image_ref refers to the cirros image. To run Windows10Server and Windows11Server VMs we need specific images for Windows10 and Windows11 respectively.","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":35840,"name":"Roman Bubyr","email":"rbubyr@mirantis.com","username":"rbubyr","status":"Mirantis"},"change_message_id":"03557e03698cacb345b1683db9b53d15b2d2242f","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                help\u003d\"A list of trusted certificates to be used when the \""},{"line_number":315,"context_line":"                     \"image certificate validation compute feature is \""},{"line_number":316,"context_line":"                     \"enabled.\"),"},{"line_number":317,"context_line":"    cfg.StrOpt(\u0027windows10_image_ref\u0027,"},{"line_number":318,"context_line":"               default\u003dNone,"},{"line_number":319,"context_line":"               help\u003d\"Valid image reference to be used in Windows 10 tests.\"),"},{"line_number":320,"context_line":"    cfg.StrOpt(\u0027windows11_image_ref\u0027,"},{"line_number":321,"context_line":"               default\u003dNone,"},{"line_number":322,"context_line":"               help\u003d\"Valid image reference to be used in Windows 11 tests.\"),"},{"line_number":323,"context_line":"    cfg.StrOpt(\u0027flavor_ref\u0027,"},{"line_number":324,"context_line":"               default\u003d\"1\","},{"line_number":325,"context_line":"               help\u003d\"Valid primary flavor to use in tests.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"771562c3_d1d16c0d","line":322,"range":{"start_line":317,"start_character":0,"end_line":322,"end_character":77},"in_reply_to":"af7b42b6_4dbedbf2","updated":"2025-01-24 15:14:35.000000000","message":"Done","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3dbb312314500a87522f9d0f9f925f221bd354d8","unresolved":true,"context_lines":[{"line_number":314,"context_line":"                help\u003d\"A list of trusted certificates to be used when the \""},{"line_number":315,"context_line":"                     \"image certificate validation compute feature is \""},{"line_number":316,"context_line":"                     \"enabled.\"),"},{"line_number":317,"context_line":"    cfg.StrOpt(\u0027windows10_image_ref\u0027,"},{"line_number":318,"context_line":"               default\u003dNone,"},{"line_number":319,"context_line":"               help\u003d\"Valid image reference to be used in Windows 10 tests.\"),"},{"line_number":320,"context_line":"    cfg.StrOpt(\u0027windows11_image_ref\u0027,"},{"line_number":321,"context_line":"               default\u003dNone,"},{"line_number":322,"context_line":"               help\u003d\"Valid image reference to be used in Windows 11 tests.\"),"},{"line_number":323,"context_line":"    cfg.StrOpt(\u0027flavor_ref\u0027,"},{"line_number":324,"context_line":"               default\u003d\"1\","},{"line_number":325,"context_line":"               help\u003d\"Valid primary flavor to use in tests.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"af7b42b6_4dbedbf2","line":322,"range":{"start_line":317,"start_character":0,"end_line":322,"end_character":77},"in_reply_to":"d0fa902d_2cc20113","updated":"2025-01-13 16:55:41.000000000","message":"Right, but those could/would be configured in a windows-specific job to a windows-specific image.","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"43325d9d2f785b3b3740a5645c85f411a1f0f010","unresolved":true,"context_lines":[{"line_number":326,"context_line":"    cfg.StrOpt(\u0027flavor_ref_alt\u0027,"},{"line_number":327,"context_line":"               default\u003d\"2\","},{"line_number":328,"context_line":"               help\u003d\u0027Valid secondary flavor to be used in tests.\u0027),"},{"line_number":329,"context_line":"    cfg.StrOpt(\u0027windows10_flavor_ref\u0027,"},{"line_number":330,"context_line":"               default\u003dNone,"},{"line_number":331,"context_line":"               help\u003d\"Valid flavor to be used for Windows 10 tests.\"),"},{"line_number":332,"context_line":"    cfg.StrOpt(\u0027windows11_flavor_ref\u0027,"},{"line_number":333,"context_line":"               default\u003dNone,"},{"line_number":334,"context_line":"               help\u003d\"Valid flavor to be used for Windows 11 tests.\"),"},{"line_number":335,"context_line":"    cfg.IntOpt(\u0027build_interval\u0027,"},{"line_number":336,"context_line":"               default\u003d1,"},{"line_number":337,"context_line":"               help\u003d\"Time in seconds between build status checks.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5190c1b8_7ffa76c3","line":334,"range":{"start_line":329,"start_character":0,"end_line":334,"end_character":69},"updated":"2025-01-05 10:19:30.000000000","message":"Same\nYou can use \"flavor_ref\".","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":35840,"name":"Roman Bubyr","email":"rbubyr@mirantis.com","username":"rbubyr","status":"Mirantis"},"change_message_id":"03557e03698cacb345b1683db9b53d15b2d2242f","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    cfg.StrOpt(\u0027flavor_ref_alt\u0027,"},{"line_number":327,"context_line":"               default\u003d\"2\","},{"line_number":328,"context_line":"               help\u003d\u0027Valid secondary flavor to be used in tests.\u0027),"},{"line_number":329,"context_line":"    cfg.StrOpt(\u0027windows10_flavor_ref\u0027,"},{"line_number":330,"context_line":"               default\u003dNone,"},{"line_number":331,"context_line":"               help\u003d\"Valid flavor to be used for Windows 10 tests.\"),"},{"line_number":332,"context_line":"    cfg.StrOpt(\u0027windows11_flavor_ref\u0027,"},{"line_number":333,"context_line":"               default\u003dNone,"},{"line_number":334,"context_line":"               help\u003d\"Valid flavor to be used for Windows 11 tests.\"),"},{"line_number":335,"context_line":"    cfg.IntOpt(\u0027build_interval\u0027,"},{"line_number":336,"context_line":"               default\u003d1,"},{"line_number":337,"context_line":"               help\u003d\"Time in seconds between build status checks.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9145afa1_a5f0b34b","line":334,"range":{"start_line":329,"start_character":0,"end_line":334,"end_character":69},"in_reply_to":"34c21e6c_ec689f4a","updated":"2025-01-24 15:14:35.000000000","message":"Done","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":35840,"name":"Roman Bubyr","email":"rbubyr@mirantis.com","username":"rbubyr","status":"Mirantis"},"change_message_id":"1ff616bb49aa19d41c517e8b4e39422b44635de6","unresolved":true,"context_lines":[{"line_number":326,"context_line":"    cfg.StrOpt(\u0027flavor_ref_alt\u0027,"},{"line_number":327,"context_line":"               default\u003d\"2\","},{"line_number":328,"context_line":"               help\u003d\u0027Valid secondary flavor to be used in tests.\u0027),"},{"line_number":329,"context_line":"    cfg.StrOpt(\u0027windows10_flavor_ref\u0027,"},{"line_number":330,"context_line":"               default\u003dNone,"},{"line_number":331,"context_line":"               help\u003d\"Valid flavor to be used for Windows 10 tests.\"),"},{"line_number":332,"context_line":"    cfg.StrOpt(\u0027windows11_flavor_ref\u0027,"},{"line_number":333,"context_line":"               default\u003dNone,"},{"line_number":334,"context_line":"               help\u003d\"Valid flavor to be used for Windows 11 tests.\"),"},{"line_number":335,"context_line":"    cfg.IntOpt(\u0027build_interval\u0027,"},{"line_number":336,"context_line":"               default\u003d1,"},{"line_number":337,"context_line":"               help\u003d\"Time in seconds between build status checks.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"f9c8d377_bda25a46","line":334,"range":{"start_line":329,"start_character":0,"end_line":334,"end_character":69},"in_reply_to":"5190c1b8_7ffa76c3","updated":"2025-01-13 16:49:40.000000000","message":"Similar as the comment above - usually flavor_ref refers to the flavour with minimum/medium capacity parameters suitable for most of the tests. To run Windows10Server and Windows11Server VMs we need specific parameters with big capacities (Disc \u003d 40 or 80 Gb for example)","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3dbb312314500a87522f9d0f9f925f221bd354d8","unresolved":true,"context_lines":[{"line_number":326,"context_line":"    cfg.StrOpt(\u0027flavor_ref_alt\u0027,"},{"line_number":327,"context_line":"               default\u003d\"2\","},{"line_number":328,"context_line":"               help\u003d\u0027Valid secondary flavor to be used in tests.\u0027),"},{"line_number":329,"context_line":"    cfg.StrOpt(\u0027windows10_flavor_ref\u0027,"},{"line_number":330,"context_line":"               default\u003dNone,"},{"line_number":331,"context_line":"               help\u003d\"Valid flavor to be used for Windows 10 tests.\"),"},{"line_number":332,"context_line":"    cfg.StrOpt(\u0027windows11_flavor_ref\u0027,"},{"line_number":333,"context_line":"               default\u003dNone,"},{"line_number":334,"context_line":"               help\u003d\"Valid flavor to be used for Windows 11 tests.\"),"},{"line_number":335,"context_line":"    cfg.IntOpt(\u0027build_interval\u0027,"},{"line_number":336,"context_line":"               default\u003d1,"},{"line_number":337,"context_line":"               help\u003d\"Time in seconds between build status checks.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"34c21e6c_ec689f4a","line":334,"range":{"start_line":329,"start_character":0,"end_line":334,"end_character":69},"in_reply_to":"f9c8d377_bda25a46","updated":"2025-01-13 16:55:41.000000000","message":"Same... if you have a job that tests windows, using a windows image, that job would/should have a flavor configured that is suitable for that client OS image.","commit_id":"913b3ff2cc66f4b0d3856bc620e8ba0e8d59ccea"}]}