)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"71944e8e1fe485c33a7d0c59d7bbb31a5164a67e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhi Kun Liu \u003czhikunli@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-16 13:25:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix image member tests error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"BaseV2MemberImageTest still uses identity client to get tenant id."},{"line_number":10,"context_line":"tenant_id is available in the Credentials instance now as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7adec928_3c0b387e","line":7,"updated":"2014-05-16 15:07:25.000000000","message":"This is pretty generic, it should mention tenant isolation and why that is the problem.","commit_id":"1d2e300fdf1a070e6c97e75618ed98f894efdb30"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"dd0991fbe0cb1aa1203c60565ac1b62470e98db4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhi Kun Liu \u003czhikunli@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-16 13:25:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix image member tests error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"BaseV2MemberImageTest still uses identity client to get tenant id."},{"line_number":10,"context_line":"tenant_id is available in the Credentials instance now as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7adec928_c721904e","line":7,"in_reply_to":"7adec928_178ad569","updated":"2014-05-18 03:26:19.000000000","message":"will fix it in next patch.\n\nThanks!","commit_id":"1d2e300fdf1a070e6c97e75618ed98f894efdb30"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"9a69d2075707b442fc94d6c788ca56962b8026b6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhi Kun Liu \u003czhikunli@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-16 13:25:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix image member tests error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"BaseV2MemberImageTest still uses identity client to get tenant id."},{"line_number":10,"context_line":"tenant_id is available in the Credentials instance now as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7adec928_178ad569","line":7,"in_reply_to":"7adec928_3c0b387e","updated":"2014-05-16 15:27:10.000000000","message":"There are two things in here:\n- lp#1320079 is caused by getting the tenant name in the wrong way, which needs fixing. The bug happens only when tenant isolation is off.\n- commit 9612e81d142e88782d4faf6a85e81967b5323908 introduced getting the tenant_id from credentials. This case was missed. Fixing this involves completely removing the code that caused lp#1320079 \n\nSo both things should be mentioned in the commit message.","commit_id":"1d2e300fdf1a070e6c97e75618ed98f894efdb30"}],"tempest/api/image/base.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"bceda2b93e7bef7a60f1da02ac8e61f171097d22","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            cls.os_alt \u003d clients.AltManager()"},{"line_number":134,"context_line":"        cls.os_img_client \u003d cls.os.image_client_v2"},{"line_number":135,"context_line":"        cls.alt_img_client \u003d cls.os_alt.image_client_v2"},{"line_number":136,"context_line":"        cls.alt_tenant_id \u003d cls.alt_img_client.tenant_id"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _list_image_ids_as_alt(self):"},{"line_number":139,"context_line":"        _, image_list \u003d self.alt_img_client.image_list()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_681a21c7","line":136,"updated":"2014-05-19 08:36:31.000000000","message":"This change looks wrong: if allow_tenant_isolation is True, you should retrieve the credentials from: cls.isolated_creds.get_alt_creds().","commit_id":"d752c60b0f6ff217f822abcbefd3e2fa615ef8d2"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0bb045fdb4d3d492dc94801330d0fc5c24e4abc9","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            cls.os_alt \u003d clients.AltManager()"},{"line_number":134,"context_line":"        cls.os_img_client \u003d cls.os.image_client_v2"},{"line_number":135,"context_line":"        cls.alt_img_client \u003d cls.os_alt.image_client_v2"},{"line_number":136,"context_line":"        cls.alt_tenant_id \u003d cls.alt_img_client.tenant_id"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _list_image_ids_as_alt(self):"},{"line_number":139,"context_line":"        _, image_list \u003d self.alt_img_client.image_list()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_bb7c72ed","line":136,"in_reply_to":"7adec928_681a21c7","updated":"2014-05-19 09:30:05.000000000","message":"os_alt contains the correct credentials, either the configured ones if tenant isolation is off, or the dynamic ones if it is on. The alt_img_client gets the credentials from os_alt, so the proposed code change is fine.\nI abandoned my change as this one save a couple of lines of codes more compared to mine.","commit_id":"d752c60b0f6ff217f822abcbefd3e2fa615ef8d2"}]}