)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0d9b9279fdd7d3c1e29b851538bab00b485198da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d781ab2_8a164050","updated":"2025-01-07 17:46:03.000000000","message":"Thanks Luigi for the review, my response is inline.","commit_id":"1e0223392ed2b11631152eb087f53ffdc91ffb8b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"16ae1bcb394e3128352317385c7f5558ce983f2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"afaac5a3_d90646f2","updated":"2025-01-09 03:11:12.000000000","message":"lgtm, -1 for adding release notes","commit_id":"55d7e40e5ea3b5d4dcd9f94376c74cfc13f7246b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bbf5155dc6af3b0bf903f6cbde74e28147676bee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a5e907ee_f9d4c6f8","updated":"2025-01-18 15:50:12.000000000","message":"Thanks for the review.","commit_id":"7127c5b2e04d067cdbcf1087745c22bf8226e8b5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8e844fbb403252d12d9bfe7d102d703372073349","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad2dee5e_f5ef9a0c","updated":"2025-01-12 17:54:57.000000000","message":"Thanks gmann for the review!","commit_id":"7127c5b2e04d067cdbcf1087745c22bf8226e8b5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b8c4d67ec8c31b8f49d72312169b11fcc0d8f2ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"10f3c0d2_107471d4","updated":"2025-02-17 09:52:43.000000000","message":"Uhm, it seems that tempest.api.volume.test_volumes_actions.VolumesActionsTest.test_volume_upload is consistently failing in devstack-plugin-ceph-tempest-py3","commit_id":"7127c5b2e04d067cdbcf1087745c22bf8226e8b5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"518c569ddfb879156f0995d2c2f31a3bf65e252d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"49a6be31_8390fc1e","updated":"2025-02-14 22:46:01.000000000","message":"recheck - https://review.opendev.org/q/I533b7444 has merged into stable/2024.2 and stable/2023.2, which should address the tempest-full-2024-2 and tempest-full-2023-2 failures","commit_id":"7127c5b2e04d067cdbcf1087745c22bf8226e8b5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dcd2aee06b27508feb42b108431ea23b7a963f25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b883781d_198e7253","updated":"2025-01-13 19:46:01.000000000","message":"thanks for adding reno. that looks fine but it seems stable job failing this test","commit_id":"7127c5b2e04d067cdbcf1087745c22bf8226e8b5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f0f897479a9e80a59234205c6d3fd1a45025a6f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"414bd038_91acf1f1","in_reply_to":"10f3c0d2_107471d4","updated":"2025-02-17 09:56:30.000000000","message":"Yeah that\u0027s a known issue that we wanted to test with this patch.\nIt is fixed by change[1]. let me include it with the depends-on tag.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/938265","commit_id":"7127c5b2e04d067cdbcf1087745c22bf8226e8b5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"39b8ad5e686b8c1a737e7bb40a142ccea3991445","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e0ba0229_a1fa1356","in_reply_to":"414bd038_91acf1f1","updated":"2025-02-17 13:02:07.000000000","message":"I guess you plan to backport https://review.opendev.org/c/openstack/cinder/+/938265 to all supported branches, right?","commit_id":"7127c5b2e04d067cdbcf1087745c22bf8226e8b5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"60a3e802a2f67cad13bff5f9b62feba6c1eb58e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"750bc27d_96f45494","updated":"2025-02-18 20:17:18.000000000","message":"lgtm, thanks","commit_id":"fbd90e963943cdb577e068dc22c255b4d0b87135"}],"tempest/api/volume/test_volumes_actions.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"bb62550286b25198f8985ee99b7f5514a6d394cc","unresolved":true,"context_lines":[{"line_number":113,"context_line":"        # but similar implementation is done in test_volume_bootable test."},{"line_number":114,"context_line":"        # Also there is no trace of ddt usage in tempest so this looks like"},{"line_number":115,"context_line":"        # the only way."},{"line_number":116,"context_line":"        for disk_format in CONF.volume.disk_format:"},{"line_number":117,"context_line":"            image_name \u003d data_utils.rand_name("},{"line_number":118,"context_line":"                self.__class__.__name__ + \u0027-Image\u0027,"},{"line_number":119,"context_line":"                prefix\u003dCONF.resource_name_prefix)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7e1603b8_03394273","line":116,"updated":"2025-01-07 17:39:42.000000000","message":"volume.disk_format looks like a string, as single value.\n\nMaybe you meant image.disk_formats?","commit_id":"1e0223392ed2b11631152eb087f53ffdc91ffb8b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8e844fbb403252d12d9bfe7d102d703372073349","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        # but similar implementation is done in test_volume_bootable test."},{"line_number":114,"context_line":"        # Also there is no trace of ddt usage in tempest so this looks like"},{"line_number":115,"context_line":"        # the only way."},{"line_number":116,"context_line":"        for disk_format in CONF.volume.disk_format:"},{"line_number":117,"context_line":"            image_name \u003d data_utils.rand_name("},{"line_number":118,"context_line":"                self.__class__.__name__ + \u0027-Image\u0027,"},{"line_number":119,"context_line":"                prefix\u003dCONF.resource_name_prefix)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e402031b_bd4f0604","line":116,"in_reply_to":"404220ac_14f09f8c","updated":"2025-01-12 17:54:57.000000000","message":"Thanks for confirming.","commit_id":"1e0223392ed2b11631152eb087f53ffdc91ffb8b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0d9b9279fdd7d3c1e29b851538bab00b485198da","unresolved":true,"context_lines":[{"line_number":113,"context_line":"        # but similar implementation is done in test_volume_bootable test."},{"line_number":114,"context_line":"        # Also there is no trace of ddt usage in tempest so this looks like"},{"line_number":115,"context_line":"        # the only way."},{"line_number":116,"context_line":"        for disk_format in CONF.volume.disk_format:"},{"line_number":117,"context_line":"            image_name \u003d data_utils.rand_name("},{"line_number":118,"context_line":"                self.__class__.__name__ + \u0027-Image\u0027,"},{"line_number":119,"context_line":"                prefix\u003dCONF.resource_name_prefix)"}],"source_content_type":"text/x-python","patch_set":1,"id":"cce98b93_fdf64945","line":116,"in_reply_to":"7e1603b8_03394273","updated":"2025-01-07 17:46:03.000000000","message":"Few things I would like to clarify here:\n1. I\u0027ve updated the volume.disk_format to be a ListOpt instead of an StrOpt\n2. for the upload case, volume.disk_format is the right variable and it was used before this change as well\n3. image.disk_formats is used all across image tests and won\u0027t be suitable for this since we\u0027re relying on the defaults which I\u0027ve set to \u0027raw\u0027 and \u0027qcow2\u0027\n\nI could have modified the name from volume.disk_format to volume.disk_formats but that would break backward compatibility so didn\u0027t go that route.","commit_id":"1e0223392ed2b11631152eb087f53ffdc91ffb8b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"16ae1bcb394e3128352317385c7f5558ce983f2b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        # but similar implementation is done in test_volume_bootable test."},{"line_number":114,"context_line":"        # Also there is no trace of ddt usage in tempest so this looks like"},{"line_number":115,"context_line":"        # the only way."},{"line_number":116,"context_line":"        for disk_format in CONF.volume.disk_format:"},{"line_number":117,"context_line":"            image_name \u003d data_utils.rand_name("},{"line_number":118,"context_line":"                self.__class__.__name__ + \u0027-Image\u0027,"},{"line_number":119,"context_line":"                prefix\u003dCONF.resource_name_prefix)"}],"source_content_type":"text/x-python","patch_set":1,"id":"404220ac_14f09f8c","line":116,"in_reply_to":"9d695cc6_540a7a84","updated":"2025-01-09 03:11:12.000000000","message":"loop looks ok gere. for default value change, commneting in config.py","commit_id":"1e0223392ed2b11631152eb087f53ffdc91ffb8b"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"342688249643b94f9e86d0d12c6118802541884c","unresolved":true,"context_lines":[{"line_number":113,"context_line":"        # but similar implementation is done in test_volume_bootable test."},{"line_number":114,"context_line":"        # Also there is no trace of ddt usage in tempest so this looks like"},{"line_number":115,"context_line":"        # the only way."},{"line_number":116,"context_line":"        for disk_format in CONF.volume.disk_format:"},{"line_number":117,"context_line":"            image_name \u003d data_utils.rand_name("},{"line_number":118,"context_line":"                self.__class__.__name__ + \u0027-Image\u0027,"},{"line_number":119,"context_line":"                prefix\u003dCONF.resource_name_prefix)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9d695cc6_540a7a84","line":116,"in_reply_to":"cce98b93_fdf64945","updated":"2025-01-07 17:50:29.000000000","message":"I see, I should have checked: volume.disk_format is only used by that file. Luckily it is not used by cinder-tempest-plugin. I wonder what is the change policy for a variable like this, maybe a new one should be added? I\u0027ll let the tempest cores chime in","commit_id":"1e0223392ed2b11631152eb087f53ffdc91ffb8b"}],"tempest/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"16ae1bcb394e3128352317385c7f5558ce983f2b","unresolved":true,"context_lines":[{"line_number":1027,"context_line":"               default\u003d\u0027Open Source\u0027,"},{"line_number":1028,"context_line":"               help\u003d\u0027Backend vendor to target when creating volume types\u0027),"},{"line_number":1029,"context_line":"    cfg.ListOpt(\u0027disk_format\u0027,"},{"line_number":1030,"context_line":"                default\u003d[\u0027raw\u0027, \u0027qcow2\u0027],"},{"line_number":1031,"context_line":"                help\u003d\u0027Disk format to use when copying a volume to image\u0027),"},{"line_number":1032,"context_line":"    cfg.IntOpt(\u0027volume_size\u0027,"},{"line_number":1033,"context_line":"               default\u003d1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5590b447_51c92536","line":1030,"range":{"start_line":1030,"start_character":0,"end_line":1030,"end_character":41},"updated":"2025-01-09 03:11:12.000000000","message":"changing default value is ok but we need to add a releasenotes about it. rest all is ok.\n\nexample- https://github.com/openstack/tempest/blob/master/releasenotes/notes/change-volume-catalog_type-default-fbcb2be6ebc42818.yaml","commit_id":"55d7e40e5ea3b5d4dcd9f94376c74cfc13f7246b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8e844fbb403252d12d9bfe7d102d703372073349","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"               default\u003d\u0027Open Source\u0027,"},{"line_number":1028,"context_line":"               help\u003d\u0027Backend vendor to target when creating volume types\u0027),"},{"line_number":1029,"context_line":"    cfg.ListOpt(\u0027disk_format\u0027,"},{"line_number":1030,"context_line":"                default\u003d[\u0027raw\u0027, \u0027qcow2\u0027],"},{"line_number":1031,"context_line":"                help\u003d\u0027Disk format to use when copying a volume to image\u0027),"},{"line_number":1032,"context_line":"    cfg.IntOpt(\u0027volume_size\u0027,"},{"line_number":1033,"context_line":"               default\u003d1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"2ec357f2_6caced68","line":1030,"range":{"start_line":1030,"start_character":0,"end_line":1030,"end_character":41},"in_reply_to":"5590b447_51c92536","updated":"2025-01-12 17:54:57.000000000","message":"Done","commit_id":"55d7e40e5ea3b5d4dcd9f94376c74cfc13f7246b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dcd2aee06b27508feb42b108431ea23b7a963f25","unresolved":true,"context_lines":[{"line_number":1027,"context_line":"               default\u003d\u0027Open Source\u0027,"},{"line_number":1028,"context_line":"               help\u003d\u0027Backend vendor to target when creating volume types\u0027),"},{"line_number":1029,"context_line":"    cfg.ListOpt(\u0027disk_format\u0027,"},{"line_number":1030,"context_line":"                default\u003d[\u0027raw\u0027, \u0027qcow2\u0027],"},{"line_number":1031,"context_line":"                help\u003d\u0027Disk format to use when copying a volume to image\u0027),"},{"line_number":1032,"context_line":"    cfg.IntOpt(\u0027volume_size\u0027,"},{"line_number":1033,"context_line":"               default\u003d1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"0b0ee356_1de39bb7","line":1030,"range":{"start_line":1030,"start_character":33,"end_line":1030,"end_character":38},"updated":"2025-01-13 19:46:01.000000000","message":"stable branches jobs are failing /tempest-full-2023-2 and /tempest-full-2024-2. is there some backports fixes needed on stable?\n\n\n- https://0feb766990d7a9a5b8c5-80b58333ad170242388e8ae016218703.ssl.cf5.rackcdn.com/938592/3/check/tempest-full-2023-2/16f8641/testr_results.html\n\n\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/common/utils/__init__.py\", line 65, in wrapper\n    return f(*func_args, **func_kwargs)\n  File \"/opt/stack/tempest/tempest/api/volume/test_volumes_actions.py\", line 127, in test_volume_upload\n    waiters.wait_for_image_status(self.images_client, image_id,\n  File \"/opt/stack/tempest/tempest/common/waiters.py\", line 175, in wait_for_image_status\n    image \u003d show_image(image_id)\n  File \"/opt/stack/tempest/tempest/lib/services/image/v2/images_client.py\", line 119, in show_image\n    resp, body \u003d self.get(url)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 342, in get\n    return self.request(\u0027GET\u0027, url, extra_headers, headers,\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 762, in request\n    self._error_checker(resp, resp_body)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 872, in _error_checker\n    raise exceptions.NotFound(resp_body, resp\u003dresp)\ntempest.lib.exceptions.NotFound: Object not found\nDetails: {\u0027message\u0027: \u0027No image found with ID ff830ea5-bb9a-459b-a68c-9cff5e6eca6a\u003cbr /\u003e\u003cbr /\u003e\\n\\n\\n\u0027, \u0027code\u0027: \u0027404 Not Found\u0027, \u0027title\u0027: \u0027Not Found\u0027}","commit_id":"7127c5b2e04d067cdbcf1087745c22bf8226e8b5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f670f58cbdb8d628a6fc2b0aed1bd07a3e063fff","unresolved":true,"context_lines":[{"line_number":1027,"context_line":"               default\u003d\u0027Open Source\u0027,"},{"line_number":1028,"context_line":"               help\u003d\u0027Backend vendor to target when creating volume types\u0027),"},{"line_number":1029,"context_line":"    cfg.ListOpt(\u0027disk_format\u0027,"},{"line_number":1030,"context_line":"                default\u003d[\u0027raw\u0027, \u0027qcow2\u0027],"},{"line_number":1031,"context_line":"                help\u003d\u0027Disk format to use when copying a volume to image\u0027),"},{"line_number":1032,"context_line":"    cfg.IntOpt(\u0027volume_size\u0027,"},{"line_number":1033,"context_line":"               default\u003d1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"b222aa19_f387d3a7","line":1030,"range":{"start_line":1030,"start_character":33,"end_line":1030,"end_character":38},"in_reply_to":"01ab548d_07074e06","updated":"2025-01-20 18:19:27.000000000","message":"thanks, I change the devstack change priority, let\u0027s wait for that to merge. I will bring that in wed QA meeting.","commit_id":"7127c5b2e04d067cdbcf1087745c22bf8226e8b5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bbf5155dc6af3b0bf903f6cbde74e28147676bee","unresolved":true,"context_lines":[{"line_number":1027,"context_line":"               default\u003d\u0027Open Source\u0027,"},{"line_number":1028,"context_line":"               help\u003d\u0027Backend vendor to target when creating volume types\u0027),"},{"line_number":1029,"context_line":"    cfg.ListOpt(\u0027disk_format\u0027,"},{"line_number":1030,"context_line":"                default\u003d[\u0027raw\u0027, \u0027qcow2\u0027],"},{"line_number":1031,"context_line":"                help\u003d\u0027Disk format to use when copying a volume to image\u0027),"},{"line_number":1032,"context_line":"    cfg.IntOpt(\u0027volume_size\u0027,"},{"line_number":1033,"context_line":"               default\u003d1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"01ab548d_07074e06","line":1030,"range":{"start_line":1030,"start_character":33,"end_line":1030,"end_character":38},"in_reply_to":"0b0ee356_1de39bb7","updated":"2025-01-18 15:50:12.000000000","message":"The failure is related to the limit on image size, it is fixed here[1] which needs to be merged and backported.\n\n[1] https://review.opendev.org/c/openstack/devstack/+/938656","commit_id":"7127c5b2e04d067cdbcf1087745c22bf8226e8b5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dd8c1d2dc52b9738f9b485895ae49ab7cfc304c0","unresolved":true,"context_lines":[{"line_number":1027,"context_line":"               default\u003d\u0027Open Source\u0027,"},{"line_number":1028,"context_line":"               help\u003d\u0027Backend vendor to target when creating volume types\u0027),"},{"line_number":1029,"context_line":"    cfg.ListOpt(\u0027disk_format\u0027,"},{"line_number":1030,"context_line":"                default\u003d[\u0027raw\u0027, \u0027qcow2\u0027],"},{"line_number":1031,"context_line":"                help\u003d\u0027Disk format to use when copying a volume to image\u0027),"},{"line_number":1032,"context_line":"    cfg.IntOpt(\u0027volume_size\u0027,"},{"line_number":1033,"context_line":"               default\u003d1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"90744820_36c5ae6f","line":1030,"range":{"start_line":1030,"start_character":33,"end_line":1030,"end_character":38},"in_reply_to":"b222aa19_f387d3a7","updated":"2025-01-22 21:12:37.000000000","message":"Thank you, I\u0027ve backported the change to 2024.2 https://review.opendev.org/c/openstack/devstack/+/939917","commit_id":"7127c5b2e04d067cdbcf1087745c22bf8226e8b5"}]}