)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4bfc303cd0d1c7339f870e99c8b61310ebea9000","unresolved":true,"context_lines":[{"line_number":12,"context_line":"validated impacts volumes that use an NFS backend,"},{"line_number":13,"context_line":"causing boot failures post-snapshot creation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2e09b5b0fc6b49cb64cfcbe4394121741e0df3ed"},{"line_number":16,"context_line":"Related-bug: #1989514"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e5455508_12dd7fc4","line":15,"updated":"2025-01-15 12:06:38.000000000","message":"shouldn\u0027t Change-Id the last line in the commit message, after all Related-bug/Closed-bug items?","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"59f39b330a8c6e809c1d9dc9cadc28148a2fb737","unresolved":false,"context_lines":[{"line_number":12,"context_line":"validated impacts volumes that use an NFS backend,"},{"line_number":13,"context_line":"causing boot failures post-snapshot creation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2e09b5b0fc6b49cb64cfcbe4394121741e0df3ed"},{"line_number":16,"context_line":"Related-bug: #1989514"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d82ad9a5_f4c38c7e","line":15,"in_reply_to":"be745f44_1a3160f9","updated":"2025-01-23 19:50:05.000000000","message":"Done","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"6bb24ab2ae6f6b676398d497043f0128353ba433","unresolved":true,"context_lines":[{"line_number":12,"context_line":"validated impacts volumes that use an NFS backend,"},{"line_number":13,"context_line":"causing boot failures post-snapshot creation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2e09b5b0fc6b49cb64cfcbe4394121741e0df3ed"},{"line_number":16,"context_line":"Related-bug: #1989514"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"be745f44_1a3160f9","line":15,"in_reply_to":"e5455508_12dd7fc4","updated":"2025-01-15 12:59:35.000000000","message":"I don\u0027t know how this line popped up.","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"84f9401ab2290dd906b35eda73e3e4b048f6b3dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e2cdd9e6_fef5ec1f","updated":"2025-01-15 13:48:17.000000000","message":"I asked in https://review.opendev.org/c/openstack/cinder/+/857528 for a backport to all open branches, otherwise we can\u0027t merge this (as it would fail on the older branches)","commit_id":"c21b286c99ce7c02d2ba4a8bb1ed5d38176324ce"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"43a6617a38db06186566882972363d187073cd00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"010f530c_d48d260b","in_reply_to":"2feb1455_b510539f","updated":"2025-01-15 20:41:32.000000000","message":"Sure, done!\nhttps://review.opendev.org/c/openstack/devstack-plugin-nfs/+/939395","commit_id":"c21b286c99ce7c02d2ba4a8bb1ed5d38176324ce"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1ff3d3d5fa26d228220953d0f50cfc7bdf890ba8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2feb1455_b510539f","in_reply_to":"e2cdd9e6_fef5ec1f","updated":"2025-01-15 15:29:30.000000000","message":"I did the backports. Can you please try a DNM patch on devstack-plugin-nfs which depends on this change to ensure that, while the backports are not merged, the issue is detected by this new tempest test on the older branches and fixed on master?","commit_id":"c21b286c99ce7c02d2ba4a8bb1ed5d38176324ce"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c9121a3fe234d555962656bd39df866a40c4e207","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"304fd454_42e5b8be","updated":"2025-01-20 19:13:31.000000000","message":"@melwittt Based on the email correspondence, I have removed the volume extension portion of the test, as this operation is not expected to work with NFS. Additionally, there is already an existing Tempest test named \"test_volume_extend_when_volume_has_snapshot\" that covers this functionality.","commit_id":"30375ce7e5018d5f363147c81e88152fb7f3d14f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"51dd85d5496233e19c6e6864d47ba3640d0f8877","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"838bf49e_d5dd62ed","updated":"2025-01-23 03:24:22.000000000","message":"LGTM, can also see the test running successfully in tempest-full-py3, for example [1]:\n\ntest_bootable_volume_snapshot_stop_start_instance[compute,id-e3f4f2fc-5c6a-4be6-9c54-aedfc0954da7,image,volume]\npass\n[x]\n        \npt187.3: tempest.scenario.test_volume_boot_pattern.TestVolumeBootPattern.test_bootable_volume_snapshot_stop_start_instance[compute,id-e3f4f2fc-5c6a-4be6-9c54-aedfc0954da7,image,volume]\n\n[1] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_893/939329/6/check/tempest-full-py3/89387aa/testr_results.html","commit_id":"eabbd35510240b58dfe2b728ece633b603ce681a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"59f39b330a8c6e809c1d9dc9cadc28148a2fb737","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"588d1ba9_873fb003","updated":"2025-01-23 19:50:05.000000000","message":"thanks, lgtm, test running fine and it verify the nice use case.","commit_id":"eabbd35510240b58dfe2b728ece633b603ce681a"}],"tempest/scenario/test_volume_boot_pattern.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ceb4aa903fbc5884d01ede8c04825ec34d8796fa","unresolved":true,"context_lines":[{"line_number":155,"context_line":"        instance \u003d self.boot_instance_from_resource("},{"line_number":156,"context_line":"            source_id\u003dvolume[\u0027id\u0027],"},{"line_number":157,"context_line":"            source_type\u003d\u0027volume\u0027,"},{"line_number":158,"context_line":"            keypair\u003dkeypair,"},{"line_number":159,"context_line":"            security_group\u003dsecurity_group"},{"line_number":160,"context_line":"        )"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8af63db5_fc8999ea","line":158,"updated":"2025-01-15 12:06:04.000000000","message":"are the custom keypair and security_group needed here?","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"59f39b330a8c6e809c1d9dc9cadc28148a2fb737","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        instance \u003d self.boot_instance_from_resource("},{"line_number":156,"context_line":"            source_id\u003dvolume[\u0027id\u0027],"},{"line_number":157,"context_line":"            source_type\u003d\u0027volume\u0027,"},{"line_number":158,"context_line":"            keypair\u003dkeypair,"},{"line_number":159,"context_line":"            security_group\u003dsecurity_group"},{"line_number":160,"context_line":"        )"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ea823d2c_33322f69","line":158,"in_reply_to":"19d7112f_c40332f0","updated":"2025-01-23 19:50:05.000000000","message":"Done","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"6bb24ab2ae6f6b676398d497043f0128353ba433","unresolved":true,"context_lines":[{"line_number":155,"context_line":"        instance \u003d self.boot_instance_from_resource("},{"line_number":156,"context_line":"            source_id\u003dvolume[\u0027id\u0027],"},{"line_number":157,"context_line":"            source_type\u003d\u0027volume\u0027,"},{"line_number":158,"context_line":"            keypair\u003dkeypair,"},{"line_number":159,"context_line":"            security_group\u003dsecurity_group"},{"line_number":160,"context_line":"        )"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"19d7112f_c40332f0","line":158,"in_reply_to":"8af63db5_fc8999ea","updated":"2025-01-15 12:59:35.000000000","message":"I think we can remove it as we don\u0027t ssh to the instance","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ceb4aa903fbc5884d01ede8c04825ec34d8796fa","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        # Step 5: Start the instance and verify it returns to ACTIVE state"},{"line_number":171,"context_line":"        self.servers_client.start_server(instance[\u0027id\u0027])"},{"line_number":172,"context_line":"        waiters.wait_for_server_status(self.servers_client, instance[\u0027id\u0027],"},{"line_number":173,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":176,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"222b6153_ea18b792","line":173,"updated":"2025-01-15 12:06:04.000000000","message":"I see other tests use SSHABLE as the final status, shouldn\u0027t this be SSHABLE too?","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"6bb24ab2ae6f6b676398d497043f0128353ba433","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        # Step 5: Start the instance and verify it returns to ACTIVE state"},{"line_number":171,"context_line":"        self.servers_client.start_server(instance[\u0027id\u0027])"},{"line_number":172,"context_line":"        waiters.wait_for_server_status(self.servers_client, instance[\u0027id\u0027],"},{"line_number":173,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":176,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6ce1bfc7_a0e6104d","line":173,"in_reply_to":"222b6153_ea18b792","updated":"2025-01-15 12:59:35.000000000","message":"SSHABLE is specified only during server creation.\nSpecifying it here would cause the test to fail due to a timeout.","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7478440e1aa2b0b984955d29a40da8a2141f1ced","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        # Step 5: Start the instance and verify it returns to ACTIVE state"},{"line_number":171,"context_line":"        self.servers_client.start_server(instance[\u0027id\u0027])"},{"line_number":172,"context_line":"        waiters.wait_for_server_status(self.servers_client, instance[\u0027id\u0027],"},{"line_number":173,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":176,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb63767a_359e6c71","line":173,"in_reply_to":"5ac972ea_a5a8175d","updated":"2025-01-16 22:00:23.000000000","message":"Yes, I believe it\u0027s good enough.\nI separated the class based on microversion 3.42. Additionally, I removed the `slow` attribute to receive indications from NFS jobs, as I\u0027m unsure whether it is considered a slow test.","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cb97536e5cacf7123f27767a2964e60c6e2f759d","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        # Step 5: Start the instance and verify it returns to ACTIVE state"},{"line_number":171,"context_line":"        self.servers_client.start_server(instance[\u0027id\u0027])"},{"line_number":172,"context_line":"        waiters.wait_for_server_status(self.servers_client, instance[\u0027id\u0027],"},{"line_number":173,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":176,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ac972ea_a5a8175d","line":173,"in_reply_to":"67e477dc_6b642bb5","updated":"2025-01-16 20:58:09.000000000","message":"Ah, good point.\n\nI\u0027m not sure whether there could be disadvantage to running the entire test at 3.42. Looking in the code I don\u0027t see an \"easy\" way to pass 3.42 for only the volume extend request. AFAICT you would have to do it a bit manually i.e. not through self.volumes_client.\n\nAs far as where, I think doing it right after the snapshot would work. I refreshed my memory about that part of the fix and the issue was that prior to the fix, the extend would make the assumption it\u0027s resizing a raw format file, i.e. the backing file. But if the volume has snapshot(s), it will have an overlay file with format qcow2 and that is the file that should be extended in that case, not the backing file.\n\nIn short, without the fix, the sequence of volume snapshot followed by volume extend would have a failure to extend the volume.\n\nWhat I\u0027m not sure yet about is how the volume extend API works as far as finding whether the extend was successful or not. It\u0027s an async API so maybe you could do a volume GET and then verify the size is now the new size, or such to check for success?","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5a28baedb23753bf4bc7eb3c675990655fabfe83","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        # Step 5: Start the instance and verify it returns to ACTIVE state"},{"line_number":171,"context_line":"        self.servers_client.start_server(instance[\u0027id\u0027])"},{"line_number":172,"context_line":"        waiters.wait_for_server_status(self.servers_client, instance[\u0027id\u0027],"},{"line_number":173,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":176,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"cde0de81_11596ded","line":173,"in_reply_to":"6ce1bfc7_a0e6104d","updated":"2025-01-16 00:09:17.000000000","message":"FYI it is not enough to check for ACTIVE because it will show as ACTIVE even if it can\u0027t boot. We could make a request for the console log and verify that it is not empty (this is one way I tested locally when I worked on the bug).\n\nAlso note that the bug fix contained a change to the volume extend code, so it would be good to add a volume resize to the scenario. I can\u0027t remember if we also need to stop/start with the resize, probably so.\n\nAnd finally another FYI is the NFS jobs don\u0027t run `slow` tests by default, so after this scenario merges we still need to follow up if we want to cover this to detect future regression.","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3622b9c9a8a1d65a0524fdb3810544e4d12890a7","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        # Step 5: Start the instance and verify it returns to ACTIVE state"},{"line_number":171,"context_line":"        self.servers_client.start_server(instance[\u0027id\u0027])"},{"line_number":172,"context_line":"        waiters.wait_for_server_status(self.servers_client, instance[\u0027id\u0027],"},{"line_number":173,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":176,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c24ee10_5b900998","line":173,"in_reply_to":"b8ccf914_39c57e55","updated":"2025-01-17 02:04:14.000000000","message":"Usually we mark test slow if it consistently takes \u003e200/250 sec and we observe the job timeout. There is no hard and fast on test time to mark slow but here this test takes 102 sec so it is ok to keep it non-slow. If we observe this test taking relatively higher time then we can iterate to mark it slow.\n- https://zuul.opendev.org/t/openstack/build/1f785850b44f4b95b4dbfa5e840562d8/log/job-output.txt#24542","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1427fd4aecbf5340801ad9d05875a864175f21de","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        # Step 5: Start the instance and verify it returns to ACTIVE state"},{"line_number":171,"context_line":"        self.servers_client.start_server(instance[\u0027id\u0027])"},{"line_number":172,"context_line":"        waiters.wait_for_server_status(self.servers_client, instance[\u0027id\u0027],"},{"line_number":173,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":176,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"67e477dc_6b642bb5","line":173,"in_reply_to":"cde0de81_11596ded","updated":"2025-01-16 10:17:14.000000000","message":"I\u0027ll add a verification step for the console log.\nRegarding the extend operation, since the volume is attached, the test can only be run starting from microversion 3.42. Is that acceptable?\nAdditionally, where do you think the extend operation should be placed? Perhaps right after the snapshot creation?\"","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"23f4bdbb8db4d9ad8e27410f2df96e4db3682c68","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        # Step 5: Start the instance and verify it returns to ACTIVE state"},{"line_number":171,"context_line":"        self.servers_client.start_server(instance[\u0027id\u0027])"},{"line_number":172,"context_line":"        waiters.wait_for_server_status(self.servers_client, instance[\u0027id\u0027],"},{"line_number":173,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":176,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b8ccf914_39c57e55","line":173,"in_reply_to":"fb63767a_359e6c71","updated":"2025-01-16 23:06:49.000000000","message":"I\u0027m not sure what/if there is official criteria about what must be labeled `slow`. @gmann@ghanshyammann.com might be able to advise\n\nhttps://docs.openstack.org/tempest/latest/HACKING.html#slow-attribute","commit_id":"ac056fda22f5694159ab36b6f09cd2041f8c55bc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5a28baedb23753bf4bc7eb3c675990655fabfe83","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        # Step 2: Boot an instance from the created volume"},{"line_number":151,"context_line":"        instance \u003d self.boot_instance_from_resource("},{"line_number":152,"context_line":"            source_id\u003dvolume[\u0027id\u0027],"},{"line_number":153,"context_line":"            source_type\u003d\u0027volume\u0027"},{"line_number":154,"context_line":"        )"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Step 3: Stop the instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"efe8f374_88ccb39e","line":153,"updated":"2025-01-16 00:09:17.000000000","message":"FWIW here is where we could add `wait_until\u003d\u0027SSHABLE\u0027`. The advantage to doing that is to reduce the chances of a failure due to SSH timeout later in the test (if we choose to add anything to this test that will SSH). Waiting for SSHABLE also verifies that the VM has booted successfully (it can be ACTIVE even if it can\u0027t boot).","commit_id":"c21b286c99ce7c02d2ba4a8bb1ed5d38176324ce"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3622b9c9a8a1d65a0524fdb3810544e4d12890a7","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        # Step 2: Boot an instance from the created volume"},{"line_number":151,"context_line":"        instance \u003d self.boot_instance_from_resource("},{"line_number":152,"context_line":"            source_id\u003dvolume[\u0027id\u0027],"},{"line_number":153,"context_line":"            source_type\u003d\u0027volume\u0027"},{"line_number":154,"context_line":"        )"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Step 3: Stop the instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5fbbc7_39b8469f","line":153,"in_reply_to":"0687cb57_afc49f57","updated":"2025-01-17 02:04:14.000000000","message":"++","commit_id":"c21b286c99ce7c02d2ba4a8bb1ed5d38176324ce"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"59f39b330a8c6e809c1d9dc9cadc28148a2fb737","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        # Step 2: Boot an instance from the created volume"},{"line_number":151,"context_line":"        instance \u003d self.boot_instance_from_resource("},{"line_number":152,"context_line":"            source_id\u003dvolume[\u0027id\u0027],"},{"line_number":153,"context_line":"            source_type\u003d\u0027volume\u0027"},{"line_number":154,"context_line":"        )"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Step 3: Stop the instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"bdd47cd0_ac250278","line":153,"in_reply_to":"5a5fbbc7_39b8469f","updated":"2025-01-23 19:50:05.000000000","message":"Done","commit_id":"c21b286c99ce7c02d2ba4a8bb1ed5d38176324ce"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1427fd4aecbf5340801ad9d05875a864175f21de","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        # Step 2: Boot an instance from the created volume"},{"line_number":151,"context_line":"        instance \u003d self.boot_instance_from_resource("},{"line_number":152,"context_line":"            source_id\u003dvolume[\u0027id\u0027],"},{"line_number":153,"context_line":"            source_type\u003d\u0027volume\u0027"},{"line_number":154,"context_line":"        )"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Step 3: Stop the instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"0687cb57_afc49f57","line":153,"in_reply_to":"efe8f374_88ccb39e","updated":"2025-01-16 10:17:14.000000000","message":"Yes, we can add the ssh validation here.","commit_id":"c21b286c99ce7c02d2ba4a8bb1ed5d38176324ce"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"18045f0cdc54c073d39c7fbb5cd0b3bb20a9ab32","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        # Step 2: Boot an instance from the created volume"},{"line_number":150,"context_line":"        instance \u003d self.boot_instance_from_resource("},{"line_number":151,"context_line":"            source_id\u003dvolume[\u0027id\u0027],"},{"line_number":152,"context_line":"            source_type\u003d\u0027volume\u0027"},{"line_number":153,"context_line":"        )"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # Step 3: Stop the instance"}],"source_content_type":"text/x-python","patch_set":5,"id":"a8c17306_c65b7203","line":152,"updated":"2025-01-21 03:08:55.000000000","message":"The `wait_until\u003d\u0027SSHABLE\u0027` was lost from PS4. It could help to ensure the volume is ready before snapshotting.","commit_id":"30375ce7e5018d5f363147c81e88152fb7f3d14f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"59f39b330a8c6e809c1d9dc9cadc28148a2fb737","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        # Step 2: Boot an instance from the created volume"},{"line_number":150,"context_line":"        instance \u003d self.boot_instance_from_resource("},{"line_number":151,"context_line":"            source_id\u003dvolume[\u0027id\u0027],"},{"line_number":152,"context_line":"            source_type\u003d\u0027volume\u0027"},{"line_number":153,"context_line":"        )"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # Step 3: Stop the instance"}],"source_content_type":"text/x-python","patch_set":5,"id":"7b7fb137_d43b400c","line":152,"in_reply_to":"3dbb5b21_41da768b","updated":"2025-01-23 19:50:05.000000000","message":"Done","commit_id":"30375ce7e5018d5f363147c81e88152fb7f3d14f"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7b40539bc594b715b2f5ea9defc750509f823108","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        # Step 2: Boot an instance from the created volume"},{"line_number":150,"context_line":"        instance \u003d self.boot_instance_from_resource("},{"line_number":151,"context_line":"            source_id\u003dvolume[\u0027id\u0027],"},{"line_number":152,"context_line":"            source_type\u003d\u0027volume\u0027"},{"line_number":153,"context_line":"        )"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # Step 3: Stop the instance"}],"source_content_type":"text/x-python","patch_set":5,"id":"3dbb5b21_41da768b","line":152,"in_reply_to":"a8c17306_c65b7203","updated":"2025-01-21 05:59:07.000000000","message":"I reverted to PS2 and forgot to include it.","commit_id":"30375ce7e5018d5f363147c81e88152fb7f3d14f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"18045f0cdc54c073d39c7fbb5cd0b3bb20a9ab32","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        self.servers_client.start_server(instance[\u0027id\u0027])"},{"line_number":165,"context_line":"        waiters.wait_for_server_status(self.servers_client, instance[\u0027id\u0027],"},{"line_number":166,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @decorators.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":169,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":170,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"}],"source_content_type":"text/x-python","patch_set":5,"id":"b618223c_53a24ca5","line":167,"updated":"2025-01-21 03:08:55.000000000","message":"The console log verification was lost from PS4. We need that to verify that the instance is booting.","commit_id":"30375ce7e5018d5f363147c81e88152fb7f3d14f"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7b40539bc594b715b2f5ea9defc750509f823108","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        self.servers_client.start_server(instance[\u0027id\u0027])"},{"line_number":165,"context_line":"        waiters.wait_for_server_status(self.servers_client, instance[\u0027id\u0027],"},{"line_number":166,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @decorators.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":169,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":170,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"}],"source_content_type":"text/x-python","patch_set":5,"id":"c1075c9d_43fa941b","line":167,"in_reply_to":"b618223c_53a24ca5","updated":"2025-01-21 05:59:07.000000000","message":"Same","commit_id":"30375ce7e5018d5f363147c81e88152fb7f3d14f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"59f39b330a8c6e809c1d9dc9cadc28148a2fb737","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.servers_client.start_server(instance[\u0027id\u0027])"},{"line_number":165,"context_line":"        waiters.wait_for_server_status(self.servers_client, instance[\u0027id\u0027],"},{"line_number":166,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @decorators.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":169,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":170,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"}],"source_content_type":"text/x-python","patch_set":5,"id":"957e2e03_a70e749c","line":167,"in_reply_to":"c1075c9d_43fa941b","updated":"2025-01-23 19:50:05.000000000","message":"Done","commit_id":"30375ce7e5018d5f363147c81e88152fb7f3d14f"}]}