)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9337a53caef577054d7d199e6c03fb1979eae2d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"013cb5e5_39d4d16d","updated":"2025-02-26 17:05:05.000000000","message":"i also think this is close but not quite correct\nwe will need tempest folks to confirm","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"06f0d7fa9c4e11632ed4f12eea269db2d81fb983","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de274ee3_7a716801","updated":"2025-02-25 19:59:56.000000000","message":"recheck\n\nnova patch was updated","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"86659d997a7f5cd5b599d8b72c480f1eb354483f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"458f568f_06df8633","updated":"2025-02-26 21:18:52.000000000","message":"thank you for your reviews","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"934f85214af9ca358d0ee0a731e81abbc2eb0aec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b0f87557_e0bbbc25","updated":"2025-02-27 10:11:00.000000000","message":"recheck\n\nmultinode-full failed to build a server in \"server_with_soft_affinity\"\ndoesn\u0027t look related","commit_id":"faa1decedfef73a77ab88feee2976036da475e0d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a1b214daa4bf2e36b7e72a84b25429e8cb1063","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0ddcb80f_48484a84","updated":"2025-02-27 18:14:23.000000000","message":"test is passing now https://zuul.opendev.org/t/openstack/build/80031baee6354207aa883ec6cd499698/log/job-output.txt#24217","commit_id":"faa1decedfef73a77ab88feee2976036da475e0d"}],"doc/source/microversion_testing.rst":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ea07292b7211de0a9154a87dd442edb00e9a1b56","unresolved":true,"context_lines":[{"line_number":460,"context_line":""},{"line_number":461,"context_line":"  * `2.98`_"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"  .. _2.98: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#microversion-2-98"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"* Volume"},{"line_number":466,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f26e4e1_e6d38620","line":463,"range":{"start_line":463,"start_character":12,"end_line":463,"end_character":108},"updated":"2025-01-15 17:24:30.000000000","message":"Not yet available","commit_id":"5e07e759f5352dd669e12a05d6c12945a48a33b9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"06f0d7fa9c4e11632ed4f12eea269db2d81fb983","unresolved":false,"context_lines":[{"line_number":460,"context_line":""},{"line_number":461,"context_line":"  * `2.98`_"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"  .. _2.98: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#microversion-2-98"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"* Volume"},{"line_number":466,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da9dd997_4079d5a7","line":463,"range":{"start_line":463,"start_character":12,"end_line":463,"end_character":108},"in_reply_to":"7f26e4e1_e6d38620","updated":"2025-02-25 19:59:56.000000000","message":"Done","commit_id":"5e07e759f5352dd669e12a05d6c12945a48a33b9"}],"tempest/api/compute/servers/test_servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e1fea4ed1ef8d62d337d73a2d6b0e985e8c5a56","unresolved":true,"context_lines":[{"line_number":324,"context_line":"        self.servers_client.list_servers(detail\u003dTrue)"},{"line_number":325,"context_line":"        # Checking show API response schema"},{"line_number":326,"context_line":"        self.servers_client.show_server(server[\u0027id\u0027])"},{"line_number":327,"context_line":"        # Check rebuild API response schema"},{"line_number":328,"context_line":"        self.servers_client.rebuild_server(server[\u0027id\u0027], self.image_ref_alt)"},{"line_number":329,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":330,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6fe328e4_8cba1ad2","line":327,"range":{"start_line":327,"start_character":42,"end_line":327,"end_character":43},"updated":"2025-02-26 20:11:43.000000000","message":"we are missing the update server test here and that is why nova returning the new filed in update server API is not captured in tempest tests otherwise it will fail as tempest schema are not updated.","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a1b214daa4bf2e36b7e72a84b25429e8cb1063","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        self.servers_client.list_servers(detail\u003dTrue)"},{"line_number":325,"context_line":"        # Checking show API response schema"},{"line_number":326,"context_line":"        self.servers_client.show_server(server[\u0027id\u0027])"},{"line_number":327,"context_line":"        # Check rebuild API response schema"},{"line_number":328,"context_line":"        self.servers_client.rebuild_server(server[\u0027id\u0027], self.image_ref_alt)"},{"line_number":329,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":330,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"118023f6_42910f02","line":327,"range":{"start_line":327,"start_character":42,"end_line":327,"end_character":43},"in_reply_to":"2598a164_0d95a640","updated":"2025-02-27 18:14:23.000000000","message":"Done","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dfa869d2d81def69496f9a77466902904446544","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        self.servers_client.list_servers(detail\u003dTrue)"},{"line_number":325,"context_line":"        # Checking show API response schema"},{"line_number":326,"context_line":"        self.servers_client.show_server(server[\u0027id\u0027])"},{"line_number":327,"context_line":"        # Check rebuild API response schema"},{"line_number":328,"context_line":"        self.servers_client.rebuild_server(server[\u0027id\u0027], self.image_ref_alt)"},{"line_number":329,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":330,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"78f5104b_3c8c6033","line":327,"range":{"start_line":327,"start_character":42,"end_line":327,"end_character":43},"in_reply_to":"2598a164_0d95a640","updated":"2025-02-27 12:11:22.000000000","message":"Done","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"86659d997a7f5cd5b599d8b72c480f1eb354483f","unresolved":true,"context_lines":[{"line_number":324,"context_line":"        self.servers_client.list_servers(detail\u003dTrue)"},{"line_number":325,"context_line":"        # Checking show API response schema"},{"line_number":326,"context_line":"        self.servers_client.show_server(server[\u0027id\u0027])"},{"line_number":327,"context_line":"        # Check rebuild API response schema"},{"line_number":328,"context_line":"        self.servers_client.rebuild_server(server[\u0027id\u0027], self.image_ref_alt)"},{"line_number":329,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":330,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2598a164_0d95a640","line":327,"range":{"start_line":327,"start_character":42,"end_line":327,"end_character":43},"in_reply_to":"6fe328e4_8cba1ad2","updated":"2025-02-26 21:18:52.000000000","message":"going to add in the next PS. Thanks!","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"}],"tempest/lib/api_schema/response/compute/v2_100/servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9337a53caef577054d7d199e6c03fb1979eae2d7","unresolved":true,"context_lines":[{"line_number":13,"context_line":"import copy"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":16,"context_line":"from tempest.lib.api_schema.response.compute.v2_98 import servers as servers298"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"###########################################################################"},{"line_number":19,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"a6738c4f_b2c6f99d","line":16,"updated":"2025-02-26 17:05:05.000000000","message":"ok your imporatign form v2_98 because 2.99 does not modify any of the server schemas relate to show list or rebuild,","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dfa869d2d81def69496f9a77466902904446544","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import copy"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":16,"context_line":"from tempest.lib.api_schema.response.compute.v2_98 import servers as servers298"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"###########################################################################"},{"line_number":19,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"b41318f6_01dde067","line":16,"in_reply_to":"7de9bc4e_4865932f","updated":"2025-02-27 12:11:22.000000000","message":"Acknowledged","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a1b214daa4bf2e36b7e72a84b25429e8cb1063","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import copy"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":16,"context_line":"from tempest.lib.api_schema.response.compute.v2_98 import servers as servers298"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"###########################################################################"},{"line_number":19,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba183e1e_94eba727","line":16,"in_reply_to":"7de9bc4e_4865932f","updated":"2025-02-27 18:14:23.000000000","message":"Done","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e1fea4ed1ef8d62d337d73a2d6b0e985e8c5a56","unresolved":true,"context_lines":[{"line_number":13,"context_line":"import copy"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":16,"context_line":"from tempest.lib.api_schema.response.compute.v2_98 import servers as servers298"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"###########################################################################"},{"line_number":19,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"7de9bc4e_4865932f","line":16,"in_reply_to":"a6738c4f_b2c6f99d","updated":"2025-02-26 20:11:43.000000000","message":"for GET/rebuild/update server response it is fine to copy from 2.98 which is same in 2.99 and 2.98 but for other schema change for example get_remote_consoles is changed in 2.99 and if we copy it from 2.98 (L112) then we are override the 2.99 change for that response.","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e1fea4ed1ef8d62d337d73a2d6b0e985e8c5a56","unresolved":true,"context_lines":[{"line_number":23,"context_line":"# of the following calls:"},{"line_number":24,"context_line":"# - GET /servers/detail"},{"line_number":25,"context_line":"# - GET /servers/{server_id}"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"###########################################################################"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_hints \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3bf1c965_d495fbf8","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":1},"updated":"2025-02-26 20:11:43.000000000","message":"also, rebuild server schema","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a1b214daa4bf2e36b7e72a84b25429e8cb1063","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# of the following calls:"},{"line_number":24,"context_line":"# - GET /servers/detail"},{"line_number":25,"context_line":"# - GET /servers/{server_id}"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"###########################################################################"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_hints \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3b7185c6_74bd94b2","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":1},"in_reply_to":"3bf1c965_d495fbf8","updated":"2025-02-27 18:14:23.000000000","message":"Done","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dfa869d2d81def69496f9a77466902904446544","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# of the following calls:"},{"line_number":24,"context_line":"# - GET /servers/detail"},{"line_number":25,"context_line":"# - GET /servers/{server_id}"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"###########################################################################"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_hints \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"5da41a0a_4f3da7cb","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":1},"in_reply_to":"3bf1c965_d495fbf8","updated":"2025-02-27 12:11:22.000000000","message":"Done","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9337a53caef577054d7d199e6c03fb1979eae2d7","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    # http://lists.openstack.org/pipermail/openstack-dev/2015-June/067996.html"},{"line_number":80,"context_line":"    # pointed out the limit the scheduler-hints in the API is problematic. So"},{"line_number":81,"context_line":"    # relax it."},{"line_number":82,"context_line":"    \u0027additionalProperties\u0027: True"},{"line_number":83,"context_line":"}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"get_server \u003d copy.deepcopy(servers298.get_server)"}],"source_content_type":"text/x-python","patch_set":2,"id":"97a0ca14_e306f5e8","line":82,"updated":"2025-02-26 17:05:05.000000000","message":"right you are allowed to extened them for custom filter provided you do not modify any of the standard hints.","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e1fea4ed1ef8d62d337d73a2d6b0e985e8c5a56","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    # http://lists.openstack.org/pipermail/openstack-dev/2015-June/067996.html"},{"line_number":80,"context_line":"    # pointed out the limit the scheduler-hints in the API is problematic. So"},{"line_number":81,"context_line":"    # relax it."},{"line_number":82,"context_line":"    \u0027additionalProperties\u0027: True"},{"line_number":83,"context_line":"}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"get_server \u003d copy.deepcopy(servers298.get_server)"}],"source_content_type":"text/x-python","patch_set":2,"id":"abb5d21d_0602c6b7","line":82,"in_reply_to":"97a0ca14_e306f5e8","updated":"2025-02-26 20:11:43.000000000","message":"Acknowledged","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e1fea4ed1ef8d62d337d73a2d6b0e985e8c5a56","unresolved":true,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"get_server \u003d copy.deepcopy(servers298.get_server)"},{"line_number":86,"context_line":"get_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":87,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"list_servers_detail \u003d copy.deepcopy(servers298.list_servers_detail)"},{"line_number":90,"context_line":"list_servers_detail[\u0027response_body\u0027][\u0027properties\u0027][\u0027servers\u0027][\u0027items\u0027]["}],"source_content_type":"text/x-python","patch_set":2,"id":"ef155a49_5811d0b6","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":52},"updated":"2025-02-26 20:11:43.000000000","message":"from nova change this new field is returned always (I mean after 2.100 microversion) - https://review.opendev.org/c/openstack/nova/+/938604/12/nova/api/openstack/compute/views/servers.py#335\n\nwe should add that in required field also.\n\n\nget_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027][\n    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})\nget_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027][\n    \u0027required\u0027].append(\u0027scheduler_hints\u0027)","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dfa869d2d81def69496f9a77466902904446544","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"get_server \u003d copy.deepcopy(servers298.get_server)"},{"line_number":86,"context_line":"get_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":87,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"list_servers_detail \u003d copy.deepcopy(servers298.list_servers_detail)"},{"line_number":90,"context_line":"list_servers_detail[\u0027response_body\u0027][\u0027properties\u0027][\u0027servers\u0027][\u0027items\u0027]["}],"source_content_type":"text/x-python","patch_set":2,"id":"86e83569_2889eb63","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":52},"in_reply_to":"cd1a42ae_9229ca8c","updated":"2025-02-27 12:11:22.000000000","message":"Done","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a1b214daa4bf2e36b7e72a84b25429e8cb1063","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"get_server \u003d copy.deepcopy(servers298.get_server)"},{"line_number":86,"context_line":"get_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":87,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"list_servers_detail \u003d copy.deepcopy(servers298.list_servers_detail)"},{"line_number":90,"context_line":"list_servers_detail[\u0027response_body\u0027][\u0027properties\u0027][\u0027servers\u0027][\u0027items\u0027]["}],"source_content_type":"text/x-python","patch_set":2,"id":"f3a0e76a_5a922f07","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":52},"in_reply_to":"cd1a42ae_9229ca8c","updated":"2025-02-27 18:14:23.000000000","message":"Done","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"86659d997a7f5cd5b599d8b72c480f1eb354483f","unresolved":true,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"get_server \u003d copy.deepcopy(servers298.get_server)"},{"line_number":86,"context_line":"get_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":87,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"list_servers_detail \u003d copy.deepcopy(servers298.list_servers_detail)"},{"line_number":90,"context_line":"list_servers_detail[\u0027response_body\u0027][\u0027properties\u0027][\u0027servers\u0027][\u0027items\u0027]["}],"source_content_type":"text/x-python","patch_set":2,"id":"cd1a42ae_9229ca8c","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":52},"in_reply_to":"ef155a49_5811d0b6","updated":"2025-02-26 21:18:52.000000000","message":"oh, missed that detail, thanks!","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e1fea4ed1ef8d62d337d73a2d6b0e985e8c5a56","unresolved":true,"context_lines":[{"line_number":86,"context_line":"get_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":87,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"list_servers_detail \u003d copy.deepcopy(servers298.list_servers_detail)"},{"line_number":90,"context_line":"list_servers_detail[\u0027response_body\u0027][\u0027properties\u0027][\u0027servers\u0027][\u0027items\u0027]["},{"line_number":91,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"rebuild_server \u003d copy.deepcopy(servers298.rebuild_server)"},{"line_number":94,"context_line":"rebuild_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":95,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":98,"context_line":"    servers298.rebuild_server_with_admin_pass)"},{"line_number":99,"context_line":"rebuild_server_with_admin_pass[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":100,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# NOTE(zhufl): Below are the unchanged schema in this microversion. We"},{"line_number":103,"context_line":"# need to keep this schema in this file to have the generic way to select the"}],"source_content_type":"text/x-python","patch_set":2,"id":"4b958a62_ab4de281","line":100,"range":{"start_line":89,"start_character":0,"end_line":100,"end_character":53},"updated":"2025-02-26 20:11:43.000000000","message":"for these schema also, we should add new field as required also.","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e1fea4ed1ef8d62d337d73a2d6b0e985e8c5a56","unresolved":true,"context_lines":[{"line_number":94,"context_line":"rebuild_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":95,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":98,"context_line":"    servers298.rebuild_server_with_admin_pass)"},{"line_number":99,"context_line":"rebuild_server_with_admin_pass[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":100,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# NOTE(zhufl): Below are the unchanged schema in this microversion. We"},{"line_number":103,"context_line":"# need to keep this schema in this file to have the generic way to select the"}],"source_content_type":"text/x-python","patch_set":2,"id":"05dff6b0_5b1d899c","line":100,"range":{"start_line":97,"start_character":0,"end_line":100,"end_character":53},"updated":"2025-02-26 20:11:43.000000000","message":"we should update the update server API response schema also as that also is changed in nova change. I commented in nova change in detail.","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"86659d997a7f5cd5b599d8b72c480f1eb354483f","unresolved":true,"context_lines":[{"line_number":94,"context_line":"rebuild_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":95,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":98,"context_line":"    servers298.rebuild_server_with_admin_pass)"},{"line_number":99,"context_line":"rebuild_server_with_admin_pass[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":100,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# NOTE(zhufl): Below are the unchanged schema in this microversion. We"},{"line_number":103,"context_line":"# need to keep this schema in this file to have the generic way to select the"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa26068_ff93d088","line":100,"range":{"start_line":97,"start_character":0,"end_line":100,"end_character":53},"in_reply_to":"05dff6b0_5b1d899c","updated":"2025-02-26 21:18:52.000000000","message":"ack, fixing in the next PS","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dfa869d2d81def69496f9a77466902904446544","unresolved":false,"context_lines":[{"line_number":94,"context_line":"rebuild_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":95,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":98,"context_line":"    servers298.rebuild_server_with_admin_pass)"},{"line_number":99,"context_line":"rebuild_server_with_admin_pass[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":100,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# NOTE(zhufl): Below are the unchanged schema in this microversion. We"},{"line_number":103,"context_line":"# need to keep this schema in this file to have the generic way to select the"}],"source_content_type":"text/x-python","patch_set":2,"id":"8a387088_281dcfb5","line":100,"range":{"start_line":97,"start_character":0,"end_line":100,"end_character":53},"in_reply_to":"3fa26068_ff93d088","updated":"2025-02-27 12:11:22.000000000","message":"Done","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a1b214daa4bf2e36b7e72a84b25429e8cb1063","unresolved":false,"context_lines":[{"line_number":94,"context_line":"rebuild_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":95,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":98,"context_line":"    servers298.rebuild_server_with_admin_pass)"},{"line_number":99,"context_line":"rebuild_server_with_admin_pass[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":100,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# NOTE(zhufl): Below are the unchanged schema in this microversion. We"},{"line_number":103,"context_line":"# need to keep this schema in this file to have the generic way to select the"}],"source_content_type":"text/x-python","patch_set":2,"id":"90677f02_62d8fa58","line":100,"range":{"start_line":97,"start_character":0,"end_line":100,"end_character":53},"in_reply_to":"3fa26068_ff93d088","updated":"2025-02-27 18:14:23.000000000","message":"Done","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"86659d997a7f5cd5b599d8b72c480f1eb354483f","unresolved":true,"context_lines":[{"line_number":86,"context_line":"get_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":87,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"list_servers_detail \u003d copy.deepcopy(servers298.list_servers_detail)"},{"line_number":90,"context_line":"list_servers_detail[\u0027response_body\u0027][\u0027properties\u0027][\u0027servers\u0027][\u0027items\u0027]["},{"line_number":91,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"rebuild_server \u003d copy.deepcopy(servers298.rebuild_server)"},{"line_number":94,"context_line":"rebuild_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":95,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":98,"context_line":"    servers298.rebuild_server_with_admin_pass)"},{"line_number":99,"context_line":"rebuild_server_with_admin_pass[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":100,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# NOTE(zhufl): Below are the unchanged schema in this microversion. We"},{"line_number":103,"context_line":"# need to keep this schema in this file to have the generic way to select the"}],"source_content_type":"text/x-python","patch_set":2,"id":"b8400390_cf147904","line":100,"range":{"start_line":89,"start_character":0,"end_line":100,"end_character":53},"in_reply_to":"4b958a62_ab4de281","updated":"2025-02-26 21:18:52.000000000","message":"right, they are required in all, starting at 2.100\nThanks!","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a1b214daa4bf2e36b7e72a84b25429e8cb1063","unresolved":false,"context_lines":[{"line_number":86,"context_line":"get_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":87,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"list_servers_detail \u003d copy.deepcopy(servers298.list_servers_detail)"},{"line_number":90,"context_line":"list_servers_detail[\u0027response_body\u0027][\u0027properties\u0027][\u0027servers\u0027][\u0027items\u0027]["},{"line_number":91,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"rebuild_server \u003d copy.deepcopy(servers298.rebuild_server)"},{"line_number":94,"context_line":"rebuild_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":95,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":98,"context_line":"    servers298.rebuild_server_with_admin_pass)"},{"line_number":99,"context_line":"rebuild_server_with_admin_pass[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":100,"context_line":"    \u0027properties\u0027].update({\u0027scheduler_hints\u0027: _hints})"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# NOTE(zhufl): Below are the unchanged schema in this microversion. We"},{"line_number":103,"context_line":"# need to keep this schema in this file to have the generic way to select the"}],"source_content_type":"text/x-python","patch_set":2,"id":"e59b0ec3_b7883cec","line":100,"range":{"start_line":89,"start_character":0,"end_line":100,"end_character":53},"in_reply_to":"b8400390_cf147904","updated":"2025-02-27 18:14:23.000000000","message":"Done","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9337a53caef577054d7d199e6c03fb1979eae2d7","unresolved":true,"context_lines":[{"line_number":109,"context_line":"update_server \u003d copy.deepcopy(servers298.update_server)"},{"line_number":110,"context_line":"list_servers \u003d copy.deepcopy(servers298.list_servers)"},{"line_number":111,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers298.show_server_diagnostics)"},{"line_number":112,"context_line":"get_remote_consoles \u003d copy.deepcopy(servers298.get_remote_consoles)"},{"line_number":113,"context_line":"list_tags \u003d copy.deepcopy(servers298.list_tags)"},{"line_number":114,"context_line":"update_all_tags \u003d copy.deepcopy(servers298.update_all_tags)"},{"line_number":115,"context_line":"delete_all_tags \u003d copy.deepcopy(servers298.delete_all_tags)"}],"source_content_type":"text/x-python","patch_set":2,"id":"31931675_1812f66a","line":112,"updated":"2025-02-26 17:05:05.000000000","message":"however 2.99 doe modify this and console_auth_tokens\n\nso you proably should be importing form v2_99 instead of v2_98\nand copying console_auth_tokens as well.\n\n\nim not actully sure what happes if you forget to copy it.","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4818dc4837ca1c0841b44c7208a55ae71021928c","unresolved":true,"context_lines":[{"line_number":109,"context_line":"update_server \u003d copy.deepcopy(servers298.update_server)"},{"line_number":110,"context_line":"list_servers \u003d copy.deepcopy(servers298.list_servers)"},{"line_number":111,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers298.show_server_diagnostics)"},{"line_number":112,"context_line":"get_remote_consoles \u003d copy.deepcopy(servers298.get_remote_consoles)"},{"line_number":113,"context_line":"list_tags \u003d copy.deepcopy(servers298.list_tags)"},{"line_number":114,"context_line":"update_all_tags \u003d copy.deepcopy(servers298.update_all_tags)"},{"line_number":115,"context_line":"delete_all_tags \u003d copy.deepcopy(servers298.delete_all_tags)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3880d543_4808a68b","line":112,"in_reply_to":"28c8d98b_0c334515","updated":"2025-02-26 19:03:07.000000000","message":"i dont know if we really need to do that\nor if we only need to have the ones we use in the test we run.","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a1b214daa4bf2e36b7e72a84b25429e8cb1063","unresolved":false,"context_lines":[{"line_number":109,"context_line":"update_server \u003d copy.deepcopy(servers298.update_server)"},{"line_number":110,"context_line":"list_servers \u003d copy.deepcopy(servers298.list_servers)"},{"line_number":111,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers298.show_server_diagnostics)"},{"line_number":112,"context_line":"get_remote_consoles \u003d copy.deepcopy(servers298.get_remote_consoles)"},{"line_number":113,"context_line":"list_tags \u003d copy.deepcopy(servers298.list_tags)"},{"line_number":114,"context_line":"update_all_tags \u003d copy.deepcopy(servers298.update_all_tags)"},{"line_number":115,"context_line":"delete_all_tags \u003d copy.deepcopy(servers298.delete_all_tags)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4f79d963_8bf6e9cc","line":112,"in_reply_to":"2d25e9a8_b724233c","updated":"2025-02-27 18:14:23.000000000","message":"Done","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f286ffdc1578733162ac9d26ca3ad06b83163895","unresolved":true,"context_lines":[{"line_number":109,"context_line":"update_server \u003d copy.deepcopy(servers298.update_server)"},{"line_number":110,"context_line":"list_servers \u003d copy.deepcopy(servers298.list_servers)"},{"line_number":111,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers298.show_server_diagnostics)"},{"line_number":112,"context_line":"get_remote_consoles \u003d copy.deepcopy(servers298.get_remote_consoles)"},{"line_number":113,"context_line":"list_tags \u003d copy.deepcopy(servers298.list_tags)"},{"line_number":114,"context_line":"update_all_tags \u003d copy.deepcopy(servers298.update_all_tags)"},{"line_number":115,"context_line":"delete_all_tags \u003d copy.deepcopy(servers298.delete_all_tags)"}],"source_content_type":"text/x-python","patch_set":2,"id":"28c8d98b_0c334515","line":112,"in_reply_to":"31931675_1812f66a","updated":"2025-02-26 18:31:06.000000000","message":"I think that you are correct, I missed that in my rebase\n\nbtw, it seems that 2.99 missed copying all `tags` ones:\n```\nlist_tags \u003d copy.deepcopy(servers298.list_tags)\nupdate_all_tags \u003d copy.deepcopy(servers298.update_all_tags)\ndelete_all_tags \u003d copy.deepcopy(servers298.delete_all_tags)\ncheck_tag_existence \u003d copy.deepcopy(servers298.check_tag_existence)\nupdate_tag \u003d copy.deepcopy(servers298.update_tag)\ndelete_tag \u003d copy.deepcopy(servers298.delete_tag)\n```","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e1fea4ed1ef8d62d337d73a2d6b0e985e8c5a56","unresolved":true,"context_lines":[{"line_number":109,"context_line":"update_server \u003d copy.deepcopy(servers298.update_server)"},{"line_number":110,"context_line":"list_servers \u003d copy.deepcopy(servers298.list_servers)"},{"line_number":111,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers298.show_server_diagnostics)"},{"line_number":112,"context_line":"get_remote_consoles \u003d copy.deepcopy(servers298.get_remote_consoles)"},{"line_number":113,"context_line":"list_tags \u003d copy.deepcopy(servers298.list_tags)"},{"line_number":114,"context_line":"update_all_tags \u003d copy.deepcopy(servers298.update_all_tags)"},{"line_number":115,"context_line":"delete_all_tags \u003d copy.deepcopy(servers298.delete_all_tags)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2d25e9a8_b724233c","line":112,"in_reply_to":"3880d543_4808a68b","updated":"2025-02-26 20:11:43.000000000","message":"we need to import things from 2.99 for schema 2.99 is changing for example get_remote_consoles otherwise this change override the 2.99 schema change with 2.98 which is wrong.","commit_id":"3827622ec07a72815ea100b39db3fee99018cbd8"}]}