)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9a4636f2fa48561495904963fbd0e802d5ee7604","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7daf489_cf4efa48","updated":"2025-02-10 19:04:36.000000000","message":"Almost looks good but a few comment.\n\nAlso, let me know in which job you are enabling it, i did not find it in nova change also https://review.opendev.org/c/openstack/nova/+/924844/34","commit_id":"4e2f0503d306ec4736b66f6ec22b76c6be2e2d24"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f600bf4ab20b904dc8722631ea138fc1ec907611","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8bc8b6b9_ee4247f2","updated":"2025-02-10 19:36:21.000000000","message":"Thanks for these comments. I\u0027ll address them today. For reference, Sean added the job config in https://review.opendev.org/c/openstack/nova/+/940835 and https://review.opendev.org/c/openstack/nova/+/940873.","commit_id":"4e2f0503d306ec4736b66f6ec22b76c6be2e2d24"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d4ef0f66b1bd4c4921f70aa8eb1106162f34540c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6004dcdf_b379d18a","updated":"2025-02-11 19:49:52.000000000","message":"thanks for update, test lgtm but before merging I would like see the result. commented in nova change about why they are not running in nova job https://review.opendev.org/c/openstack/nova/+/940873/5/.zuul.yaml#173","commit_id":"c0fce7a9fdedf1fe71b335b33eb09129eec6d9b7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"47c0508a1297f0c1fffa2814ce96dbc92668b874","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d9f6abc4_16fa7fd4","updated":"2025-02-13 19:20:02.000000000","message":"lgtm.\n\nTest is being enabled in https://review.opendev.org/c/openstack/nova/+/924844 and https://review.opendev.org/c/openstack/devstack/+/940838\n\nand it is running fine\n\nhttps://zuul.opendev.org/t/openstack/build/45d55cb0b39148ec9f23b608b94304c3/log/job-output.txt#28840","commit_id":"fbbf01b2c7989a0ed1877acb5b370ee1ee6af0ff"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"caf796233d53707633c1481735b60851a92723d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2e5ba7c2_f0e83bc2","updated":"2025-02-13 03:14:51.000000000","message":"recheck ceph","commit_id":"fbbf01b2c7989a0ed1877acb5b370ee1ee6af0ff"}],"tempest/api/compute/servers/test_spice.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9a4636f2fa48561495904963fbd0e802d5ee7604","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        super().skip_checks()"},{"line_number":42,"context_line":"        if not CONF.compute_feature_enabled.spice_console:"},{"line_number":43,"context_line":"            raise cls.skipException(\u0027SPICE console feature is disabled.\u0027)"},{"line_number":44,"context_line":"        if not cls.is_requested_microversion_compatible(\u00272.98\u0027):"},{"line_number":45,"context_line":"            raise cls.skipException("},{"line_number":46,"context_line":"                \u0027Nova API too old to support spice-direct.\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def tearDown(self):"},{"line_number":49,"context_line":"        super().tearDown()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bd703c63_2e5ec6bd","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":60},"updated":"2025-02-10 19:04:36.000000000","message":"you can mention the min microversion as class variable instead of explicit here\n\nclass SpiceDirectConsoleTestJSON(base.BaseV2ComputeTest):\n    \"\"\"Test the spice-direct console\"\"\"\n\n    create_default_network \u003d True\n    \n    min_microversion \u003d \u00272.98\u0027\n    max_microversion \u003d \u0027latest\u0027","commit_id":"4e2f0503d306ec4736b66f6ec22b76c6be2e2d24"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"fb03a8ac2ee62504935fe637b669d0e98d1c7cee","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        super().skip_checks()"},{"line_number":42,"context_line":"        if not CONF.compute_feature_enabled.spice_console:"},{"line_number":43,"context_line":"            raise cls.skipException(\u0027SPICE console feature is disabled.\u0027)"},{"line_number":44,"context_line":"        if not cls.is_requested_microversion_compatible(\u00272.98\u0027):"},{"line_number":45,"context_line":"            raise cls.skipException("},{"line_number":46,"context_line":"                \u0027Nova API too old to support spice-direct.\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def tearDown(self):"},{"line_number":49,"context_line":"        super().tearDown()"}],"source_content_type":"text/x-python","patch_set":1,"id":"6510e0b6_d82e8f6c","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":60},"in_reply_to":"bd703c63_2e5ec6bd","updated":"2025-02-11 07:09:40.000000000","message":"Done","commit_id":"4e2f0503d306ec4736b66f6ec22b76c6be2e2d24"}],"tempest/lib/api_schema/response/compute/v2_6/servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9a4636f2fa48561495904963fbd0e802d5ee7604","unresolved":true,"context_lines":[{"line_number":46,"context_line":"                \u0027properties\u0027: {"},{"line_number":47,"context_line":"                    \u0027protocol\u0027: {\u0027enum\u0027: [\u0027vnc\u0027, \u0027rdp\u0027, \u0027serial\u0027, \u0027spice\u0027]},"},{"line_number":48,"context_line":"                    \u0027type\u0027: {\u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027rdp-html5\u0027,"},{"line_number":49,"context_line":"                                      \u0027spice-html5\u0027, \u0027spice-direct\u0027,"},{"line_number":50,"context_line":"                                      \u0027serial\u0027]},"},{"line_number":51,"context_line":"                    \u0027url\u0027: {"},{"line_number":52,"context_line":"                        \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0d52be_ddb168eb","line":49,"range":{"start_line":49,"start_character":52,"end_line":49,"end_character":68},"updated":"2025-02-10 19:04:36.000000000","message":"As you are adding this type in new microversion 2.98, we should not change the old microversion schema. you can add it for 2.98 onwards only  \n\nnew file - tempest/lib/api_schema/response/compute/v2_98/servers.py and update the console schema. For example https://github.com/openstack/tempest/blob/master/tempest/lib/api_schema/response/compute/v2_96/servers.py","commit_id":"4e2f0503d306ec4736b66f6ec22b76c6be2e2d24"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"fb03a8ac2ee62504935fe637b669d0e98d1c7cee","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                \u0027properties\u0027: {"},{"line_number":47,"context_line":"                    \u0027protocol\u0027: {\u0027enum\u0027: [\u0027vnc\u0027, \u0027rdp\u0027, \u0027serial\u0027, \u0027spice\u0027]},"},{"line_number":48,"context_line":"                    \u0027type\u0027: {\u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027rdp-html5\u0027,"},{"line_number":49,"context_line":"                                      \u0027spice-html5\u0027, \u0027spice-direct\u0027,"},{"line_number":50,"context_line":"                                      \u0027serial\u0027]},"},{"line_number":51,"context_line":"                    \u0027url\u0027: {"},{"line_number":52,"context_line":"                        \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d950db4d_0ba6f98d","line":49,"range":{"start_line":49,"start_character":52,"end_line":49,"end_character":68},"in_reply_to":"fa0d52be_ddb168eb","updated":"2025-02-11 07:09:40.000000000","message":"Done","commit_id":"4e2f0503d306ec4736b66f6ec22b76c6be2e2d24"}],"tempest/lib/api_schema/response/compute/v2_98/servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b65afd2658cee8ed8d2252724268b50b821641a3","unresolved":true,"context_lines":[{"line_number":44,"context_line":"                \u0027properties\u0027: {"},{"line_number":45,"context_line":"                    \u0027protocol\u0027: {\u0027enum\u0027: [\u0027vnc\u0027, \u0027rdp\u0027, \u0027serial\u0027, \u0027spice\u0027]},"},{"line_number":46,"context_line":"                    \u0027type\u0027: {\u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027rdp-html5\u0027,"},{"line_number":47,"context_line":"                                      \u0027spice-html5\u0027, \u0027spice-direct\u0027,"},{"line_number":48,"context_line":"                                      \u0027serial\u0027]},"},{"line_number":49,"context_line":"                    \u0027url\u0027: {"},{"line_number":50,"context_line":"                        \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ac1e3b73_7064a08a","line":47,"updated":"2025-02-12 02:52:55.000000000","message":"so either this is not working or the wrong microversion was used.\n\nhttps://aad732c16f9202f5bcc1-7527cbce0d45d09e05ca8cd34bbf6fcf.ssl.cf1.rackcdn.com/924844/35/check/nova-ovs-hybrid-plug/0f2307d/testr_results.html\n\n \u0027openstack-api-version\u0027: \u0027compute 2.98\u0027, is in teh responce so i think there is an issseu with the schema","commit_id":"c0fce7a9fdedf1fe71b335b33eb09129eec6d9b7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"47c0508a1297f0c1fffa2814ce96dbc92668b874","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \u0027properties\u0027: {"},{"line_number":45,"context_line":"                    \u0027protocol\u0027: {\u0027enum\u0027: [\u0027vnc\u0027, \u0027rdp\u0027, \u0027serial\u0027, \u0027spice\u0027]},"},{"line_number":46,"context_line":"                    \u0027type\u0027: {\u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027rdp-html5\u0027,"},{"line_number":47,"context_line":"                                      \u0027spice-html5\u0027, \u0027spice-direct\u0027,"},{"line_number":48,"context_line":"                                      \u0027serial\u0027]},"},{"line_number":49,"context_line":"                    \u0027url\u0027: {"},{"line_number":50,"context_line":"                        \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"143cf0e7_23e85d71","line":47,"in_reply_to":"8c5e8e98_87d3e561","updated":"2025-02-13 19:20:02.000000000","message":"Done","commit_id":"c0fce7a9fdedf1fe71b335b33eb09129eec6d9b7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"00e9170ddaa8e6c7710e1a286cb54254bd9bd30e","unresolved":true,"context_lines":[{"line_number":44,"context_line":"                \u0027properties\u0027: {"},{"line_number":45,"context_line":"                    \u0027protocol\u0027: {\u0027enum\u0027: [\u0027vnc\u0027, \u0027rdp\u0027, \u0027serial\u0027, \u0027spice\u0027]},"},{"line_number":46,"context_line":"                    \u0027type\u0027: {\u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027rdp-html5\u0027,"},{"line_number":47,"context_line":"                                      \u0027spice-html5\u0027, \u0027spice-direct\u0027,"},{"line_number":48,"context_line":"                                      \u0027serial\u0027]},"},{"line_number":49,"context_line":"                    \u0027url\u0027: {"},{"line_number":50,"context_line":"                        \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8c5e8e98_87d3e561","line":47,"in_reply_to":"ac1e3b73_7064a08a","updated":"2025-02-12 02:55:32.000000000","message":"this is right but new schema version missing in server client, this comment https://review.opendev.org/c/openstack/tempest/+/940943/comment/4b1cc154_361f1c5e/","commit_id":"c0fce7a9fdedf1fe71b335b33eb09129eec6d9b7"}],"tempest/lib/services/compute/servers_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0ac0c42e1e68203b11d91cd63bc1b6f46bf6c174","unresolved":true,"context_lines":[{"line_number":46,"context_line":"from tempest.lib.api_schema.response.compute.v2_89 import servers as schemav289"},{"line_number":47,"context_line":"from tempest.lib.api_schema.response.compute.v2_9 import servers as schemav29"},{"line_number":48,"context_line":"from tempest.lib.api_schema.response.compute.v2_96 import servers as schemav296"},{"line_number":49,"context_line":"from tempest.lib.common import rest_client"},{"line_number":50,"context_line":"from tempest.lib.services.compute import base_compute_client"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7e21fd7f_2eaaf157","line":49,"updated":"2025-02-12 02:49:37.000000000","message":"here you need to import new schema \n\nfrom tempest.lib.api_schema.response.compute.v2_98 import servers as schemav298","commit_id":"c0fce7a9fdedf1fe71b335b33eb09129eec6d9b7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"47c0508a1297f0c1fffa2814ce96dbc92668b874","unresolved":false,"context_lines":[{"line_number":46,"context_line":"from tempest.lib.api_schema.response.compute.v2_89 import servers as schemav289"},{"line_number":47,"context_line":"from tempest.lib.api_schema.response.compute.v2_9 import servers as schemav29"},{"line_number":48,"context_line":"from tempest.lib.api_schema.response.compute.v2_96 import servers as schemav296"},{"line_number":49,"context_line":"from tempest.lib.common import rest_client"},{"line_number":50,"context_line":"from tempest.lib.services.compute import base_compute_client"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"db2fdcbb_5bcc4db1","line":49,"in_reply_to":"7e21fd7f_2eaaf157","updated":"2025-02-13 19:20:02.000000000","message":"Done","commit_id":"c0fce7a9fdedf1fe71b335b33eb09129eec6d9b7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0ac0c42e1e68203b11d91cd63bc1b6f46bf6c174","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        {\u0027min\u0027: \u00272.73\u0027, \u0027max\u0027: \u00272.74\u0027, \u0027schema\u0027: schemav273},"},{"line_number":77,"context_line":"        {\u0027min\u0027: \u00272.75\u0027, \u0027max\u0027: \u00272.78\u0027, \u0027schema\u0027: schemav275},"},{"line_number":78,"context_line":"        {\u0027min\u0027: \u00272.79\u0027, \u0027max\u0027: \u00272.88\u0027, \u0027schema\u0027: schemav279},"},{"line_number":79,"context_line":"        {\u0027min\u0027: \u00272.89\u0027, \u0027max\u0027: \u00272.95\u0027, \u0027schema\u0027: schemav289},"},{"line_number":80,"context_line":"        {\u0027min\u0027: \u00272.96\u0027, \u0027max\u0027: None, \u0027schema\u0027: schemav296}]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def __init__(self, auth_provider, service, region,"},{"line_number":83,"context_line":"                 enable_instance_password\u003dTrue, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"4b1cc154_361f1c5e","line":80,"range":{"start_line":79,"start_character":60,"end_line":80,"end_character":58},"updated":"2025-02-12 02:49:37.000000000","message":"this part is missing and that is why test is failing in nova change[1]. we need to add the new microversion schema here:\n\n,\n        {\u0027min\u0027: \u00272.96\u0027, \u00272.97\u0027: None, \u0027schema\u0027: schemav296},\n        {\u0027min\u0027: \u00272.98\u0027, \u0027max\u0027: None, \u0027schema\u0027: schemav298}]\n        \n     \n     \n [1] https://aad732c16f9202f5bcc1-7527cbce0d45d09e05ca8cd34bbf6fcf.ssl.cf1.rackcdn.com/924844/35/check/nova-ovs-hybrid-plug/0f2307d/testr_results.html","commit_id":"c0fce7a9fdedf1fe71b335b33eb09129eec6d9b7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"47c0508a1297f0c1fffa2814ce96dbc92668b874","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        {\u0027min\u0027: \u00272.73\u0027, \u0027max\u0027: \u00272.74\u0027, \u0027schema\u0027: schemav273},"},{"line_number":77,"context_line":"        {\u0027min\u0027: \u00272.75\u0027, \u0027max\u0027: \u00272.78\u0027, \u0027schema\u0027: schemav275},"},{"line_number":78,"context_line":"        {\u0027min\u0027: \u00272.79\u0027, \u0027max\u0027: \u00272.88\u0027, \u0027schema\u0027: schemav279},"},{"line_number":79,"context_line":"        {\u0027min\u0027: \u00272.89\u0027, \u0027max\u0027: \u00272.95\u0027, \u0027schema\u0027: schemav289},"},{"line_number":80,"context_line":"        {\u0027min\u0027: \u00272.96\u0027, \u0027max\u0027: None, \u0027schema\u0027: schemav296}]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def __init__(self, auth_provider, service, region,"},{"line_number":83,"context_line":"                 enable_instance_password\u003dTrue, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"465842f8_1e7fc050","line":80,"range":{"start_line":79,"start_character":60,"end_line":80,"end_character":58},"in_reply_to":"4b1cc154_361f1c5e","updated":"2025-02-13 19:20:02.000000000","message":"Done","commit_id":"c0fce7a9fdedf1fe71b335b33eb09129eec6d9b7"}]}