)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a59dc0ffad4da364e9d849d4ed329bccadb2fd93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0e2a9dd2_7fd7f9fb","updated":"2025-02-22 17:22:52.000000000","message":"it is passing more hten its failing i guess\n\nhttps://zuul.opendev.org/t/openstack/builds?job_name\u003dironic-tempest-bios-ipmi-direct-tinyipa\u0026project\u003dopenstack%2Ftempest\u0026skip\u003d0","commit_id":"cb03598a65f47c51406fc86c9c1503fe42424848"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"35e68cd6ef13a244501a86db4ab39236c4bc953c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"84f09347_23784dcb","updated":"2025-02-22 05:09:08.000000000","message":"lgtm","commit_id":"cb03598a65f47c51406fc86c9c1503fe42424848"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5391413ff8b959052ded41c2d1bfe9ebdb7bad52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"02845353_841b7bb0","updated":"2025-02-22 11:54:01.000000000","message":"recheck","commit_id":"cb03598a65f47c51406fc86c9c1503fe42424848"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"05483720ee5d2f907c2ffbb10e5570f32ecfd621","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2e687290_2d4cc849","updated":"2025-02-22 17:21:02.000000000","message":"recheck ironic failed again with no clear error.\n\ni wonder if that job should be non voting or it it has a temperoy propelm in general that need to be fixed.\n\ni dont see how it could be related to this chagne so this looks unrelated to me","commit_id":"cb03598a65f47c51406fc86c9c1503fe42424848"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f0b1d4be6a1b3a4d31d75cc656c119281a10a169","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e4acaf59_2f418e8d","updated":"2025-02-22 20:35:24.000000000","message":"recheck ssh timeout in jammy job","commit_id":"cb03598a65f47c51406fc86c9c1503fe42424848"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f65026698e87e0f3cdf9887b41fe01b2e2adea83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"071bdb66_b0c0b08b","updated":"2025-02-23 03:16:21.000000000","message":"recheck tempest-full-py3 timeoput","commit_id":"cb03598a65f47c51406fc86c9c1503fe42424848"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a17f10cec19f9f4ec52df1b7c14d77ed8ee74c3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d4a42be2_045c9f43","updated":"2025-02-22 13:15:32.000000000","message":"recheck test_baremetal_server_ops_wholedisk_image timedout","commit_id":"cb03598a65f47c51406fc86c9c1503fe42424848"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"050c2bdfbf1ca671e2938ec9c29689e52e6379b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f9204c22_5b9acfe8","updated":"2025-02-22 10:42:53.000000000","message":"recheck unrelated ironic job failure","commit_id":"cb03598a65f47c51406fc86c9c1503fe42424848"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70f483b6af3b5d89846ae8f5698b893ff6a3a535","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6acdebe1_d8ead57a","updated":"2025-02-22 20:35:44.000000000","message":"recheck well at least its a different job","commit_id":"cb03598a65f47c51406fc86c9c1503fe42424848"}],"tempest/api/compute/servers/test_servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"eb6d9838fc86c52f002a39f562433b524f8128da","unresolved":true,"context_lines":[{"line_number":300,"context_line":"        # Check rebuild API response schema"},{"line_number":301,"context_line":"        self.servers_client.rebuild_server(server[\u0027id\u0027], self.image_ref_alt)"},{"line_number":302,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":303,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"4ad8a477_b85dcb76","line":303,"updated":"2025-02-21 23:38:55.000000000","message":"ok ya all 3 share the same response and were modified in the same api microversion so this provides coverage of all the changes.","commit_id":"48c86edcaf3b3a5f183fa2a20c02140570a9ead6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"35e68cd6ef13a244501a86db4ab39236c4bc953c","unresolved":true,"context_lines":[{"line_number":283,"context_line":"        # Checking show API response schema"},{"line_number":284,"context_line":"        self.servers_client.show_server(server[\u0027id\u0027])"},{"line_number":285,"context_line":"        # Check rebuild API response schema"},{"line_number":286,"context_line":"        self.servers_client.rebuild_server(server[\u0027id\u0027], self.image_ref_alt)"},{"line_number":287,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":288,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"20bc5813_349e94af","line":286,"range":{"start_line":286,"start_character":0,"end_line":286,"end_character":76},"updated":"2025-02-22 05:09:08.000000000","message":"++ thanks for adding it.","commit_id":"cb03598a65f47c51406fc86c9c1503fe42424848"}],"tempest/lib/api_schema/response/compute/v2_98/servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"eb6d9838fc86c52f002a39f562433b524f8128da","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        },"},{"line_number":40,"context_line":"    },"},{"line_number":41,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"get_server \u003d copy.deepcopy(servers296.get_server)"},{"line_number":45,"context_line":"get_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027]["}],"source_content_type":"text/x-python","patch_set":5,"id":"4757c320_f577aa97","line":42,"updated":"2025-02-21 23:38:55.000000000","message":"yep this matches with nova\u0027s restriction on key/value length and nova response","commit_id":"48c86edcaf3b3a5f183fa2a20c02140570a9ead6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4e92212713f747a3e1d0629e0f26e44154ce242a","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        },"},{"line_number":40,"context_line":"    },"},{"line_number":41,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"get_server \u003d copy.deepcopy(servers296.get_server)"},{"line_number":45,"context_line":"get_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027]["}],"source_content_type":"text/x-python","patch_set":5,"id":"99e525df_dbb75076","line":42,"in_reply_to":"201227a8_96ea032d","updated":"2025-02-22 00:10:56.000000000","message":"What we can do is normalize all the values to a string before we return it and fix the other issue you noted.\n\nmy change is intened to fix the keys we return ot only the offical image propertes but i did not intent ot change the data type or the responce form a sting to a Union[str|bool|None]\n\nill update the patch i started to depned on this tempest test","commit_id":"48c86edcaf3b3a5f183fa2a20c02140570a9ead6"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ee0e3ff4ae83a7884bf2322d98ff8f592d3e5865","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        },"},{"line_number":40,"context_line":"    },"},{"line_number":41,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"get_server \u003d copy.deepcopy(servers296.get_server)"},{"line_number":45,"context_line":"get_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027]["}],"source_content_type":"text/x-python","patch_set":5,"id":"201227a8_96ea032d","line":42,"in_reply_to":"4757c320_f577aa97","updated":"2025-02-21 23:52:57.000000000","message":"Note to reviewers: this is tested in Nova by https://review.opendev.org/c/openstack/nova/+/942493 which is stacked on top of PS40 of the spice series.\n\nAlso note that this schema is different than the response schema as currently written in Nova because during my testing the Nova API returned for example `hw_input_bus` as `None`. There is also a typo in the Nova side schema \"max_Length\" which should be \"maxLength\".\n\nSeparately, according to Sean\u0027s proposed fix for image properties in the API, the `boolean` type is also a possible return type for Nova API image properties. If that\u0027s the case, we will need to update the schema in Tempest to add type `boolean`.","commit_id":"48c86edcaf3b3a5f183fa2a20c02140570a9ead6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"35e68cd6ef13a244501a86db4ab39236c4bc953c","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        },"},{"line_number":40,"context_line":"    },"},{"line_number":41,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"get_server \u003d copy.deepcopy(servers296.get_server)"},{"line_number":45,"context_line":"get_server[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027]["}],"source_content_type":"text/x-python","patch_set":5,"id":"51e12b94_fc2415aa","line":42,"in_reply_to":"99e525df_dbb75076","updated":"2025-02-22 05:09:08.000000000","message":"Acknowledged","commit_id":"48c86edcaf3b3a5f183fa2a20c02140570a9ead6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"eb6d9838fc86c52f002a39f562433b524f8128da","unresolved":true,"context_lines":[{"line_number":59,"context_line":"rebuild_server_with_admin_pass[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":60,"context_line":"    \u0027properties\u0027][\u0027image\u0027][\u0027oneOf\u0027][0][\u0027properties\u0027].update("},{"line_number":61,"context_line":"        {\u0027properties\u0027: image_properties})"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Below are the unchanged schema in this microversion. We need to keep this"},{"line_number":64,"context_line":"# schema in this file to have the generic way to select the right schema based"},{"line_number":65,"context_line":"# on self.schema_versions_info mapping in service client."}],"source_content_type":"text/x-python","patch_set":5,"id":"b69a0525_f3bfd04c","line":62,"updated":"2025-02-21 23:38:55.000000000","message":"definetly not my area of expertise but this looks correct ot me based on skiming other similar chagnes","commit_id":"48c86edcaf3b3a5f183fa2a20c02140570a9ead6"}]}