)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"4e3b0f5f29cb580ec1a3b80158e120d8a6208a54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1adb9f28_aedc4951","updated":"2025-07-14 09:06:45.000000000","message":"I wonder why we didn\u0027t use here `hashlib.new(\u0027md5\u0027, foo, usedforsecurity\u003dFalse)`.\nOr for better compatibility use:\n`try:\n        return hashlib.new(\u0027md5\u0027, data, usedforsecurity\u003dFalse)\n    except TypeError:\n        return hashlib.md5(data)  # Fall back if flag is unsupported`","commit_id":"b32773fadf676596b24f2e978b7e674f7c6dabbf"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"4afd66e8fa7fcde3174bfd0963dd1c34f3526c9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"486fad8d_4bd7d353","updated":"2025-07-14 06:46:16.000000000","message":"recheck","commit_id":"b32773fadf676596b24f2e978b7e674f7c6dabbf"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"29e61cff2e38190ff749deab26c5e16b5b1faaf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fad64bed_595b3c55","in_reply_to":"023a7e45_24a4b5ee","updated":"2025-07-15 14:02:17.000000000","message":"Done","commit_id":"b32773fadf676596b24f2e978b7e674f7c6dabbf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"55b935c1290655269cc6016b58c0aa04dbad9cce","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a0cca6c2_313cc0be","in_reply_to":"023a7e45_24a4b5ee","updated":"2025-07-15 14:01:38.000000000","message":"Oops I posted the translation link. I meant to point https://docs.python.org/3.13/library/hashlib.html#hashlib.md5 .","commit_id":"b32773fadf676596b24f2e978b7e674f7c6dabbf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"50890be580f39e75028f0ab9a8b6532088b7d6ba","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a93f5989_19a7ffa4","in_reply_to":"1adb9f28_aedc4951","updated":"2025-07-14 09:26:21.000000000","message":"usedforsecurity was added in Python 3.9. Because tempest supports Python \u003e\u003d 3.9 since [1], we don\u0027t need that compatibility code.\n\n\n[1] https://review.opendev.org/c/openstack/tempest/+/933398","commit_id":"b32773fadf676596b24f2e978b7e674f7c6dabbf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"955182f856450a9b218f26c02598a948fd9127b1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"023a7e45_24a4b5ee","in_reply_to":"8d6ee60e_89285719","updated":"2025-07-15 14:00:44.000000000","message":"We can technically use hashlib.new but that\u0027s unnecessary unless md5 method is deprecated. As far as the python doc tells I see no indication of deprecation.\n\nhttps://docs.python.org/ja/3.13/library/hashlib.html#hashlib.md5","commit_id":"b32773fadf676596b24f2e978b7e674f7c6dabbf"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"149eb0ee400807d6bfff89404585a2c428e37aef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8d6ee60e_89285719","in_reply_to":"a93f5989_19a7ffa4","updated":"2025-07-15 13:56:49.000000000","message":"Ack we don\u0027t need compatibility code here but  should we use here the new hashlib method `hashlib.new(\u0027md5\u0027, foo, usedforsecurity\u003dFalse)`?","commit_id":"b32773fadf676596b24f2e978b7e674f7c6dabbf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0a4706a0f8d10d730dae49d9931e25727a49337f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8fbb1a17_6e7ab8b9","updated":"2026-01-21 18:29:06.000000000","message":"lgtm, thanks","commit_id":"f9a7a6d2c08184c2cf03619f86ab49410d60ddc4"}],"tox.ini":[{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"11bdee20397bf498df1911ea84d20a37a244ce39","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  coverage combine"},{"line_number":62,"context_line":"  coverage html -d cover"},{"line_number":63,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":64,"context_line":"  coverage report -m --fail-under\u003d70"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"[testenv:debug]"},{"line_number":67,"context_line":"commands \u003d oslo_debug_helper -t tempest/tests {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7b94f8c8_d49e980e","line":64,"updated":"2025-07-15 14:16:28.000000000","message":"Why we changed here test coverage?","commit_id":"b32773fadf676596b24f2e978b7e674f7c6dabbf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"13cf639a2f079f1a33afd650b235585b588eb97e","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  coverage combine"},{"line_number":62,"context_line":"  coverage html -d cover"},{"line_number":63,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":64,"context_line":"  coverage report -m --fail-under\u003d70"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"[testenv:debug]"},{"line_number":67,"context_line":"commands \u003d oslo_debug_helper -t tempest/tests {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"dba2cf65_2d0fa068","line":64,"in_reply_to":"7b94f8c8_d49e980e","updated":"2025-07-15 14:26:32.000000000","message":"I vaguely remember when I tested this initially this change reduced coverage from 76 to 75 and I had to lower down the bound. However the latest CI result shows 76% so this may no longer be needed (though I don\u0027t know using the exact current coverage percent is a good idea because it makes the limit quite fragile.","commit_id":"b32773fadf676596b24f2e978b7e674f7c6dabbf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe72dd7f93badf83ec3bce32af5b1b930addb51a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  coverage combine"},{"line_number":62,"context_line":"  coverage html -d cover"},{"line_number":63,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":64,"context_line":"  coverage report -m --fail-under\u003d70"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"[testenv:debug]"},{"line_number":67,"context_line":"commands \u003d oslo_debug_helper -t tempest/tests {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"902202c7_07e21aaf","line":64,"in_reply_to":"dba2cf65_2d0fa068","updated":"2025-07-15 14:27:21.000000000","message":"Done","commit_id":"b32773fadf676596b24f2e978b7e674f7c6dabbf"}]}