)]}'
{"tempest/api/queuing/test_claims.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"e634764fc5cab0d3c465e0b1a6c27c7ed4573f11","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":39,"context_line":"    def test_post_claim(self):"},{"line_number":40,"context_line":"        # Post Messages"},{"line_number":41,"context_line":"        message_body \u003d self.generate_message_body(repeat\u003d1)"},{"line_number":42,"context_line":"        self.client.post_messages(queue_name\u003dself.queue_name,"},{"line_number":43,"context_line":"                                  rbody\u003dmessage_body)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_250ed23b","line":40,"updated":"2014-06-03 17:01:29.000000000","message":"DRY: L40-52 seem to be repeated in each test method. Could these be factored out into a helper method or put in setUp?","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"d94090a6638c2e08218c4f692d14073022a0ec3a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        claim_grace \u003d data_utils.rand_int_id(start\u003d60,"},{"line_number":49,"context_line":"                                             end\u003dCONF.queuing.max_claim_grace)"},{"line_number":50,"context_line":"        claim_body \u003d {\"ttl\": claim_ttl, \"grace\": claim_grace}"},{"line_number":51,"context_line":"        resp, body \u003d self.post_claims(queue_name\u003dself.queue_name,"},{"line_number":52,"context_line":"                                      rbody\u003dclaim_body)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        claimed_message_uri \u003d body[0][\u0027href\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_44ac728c","line":51,"updated":"2014-06-05 13:01:08.000000000","message":"unused variable \"resp\"","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"821b5de1010aed2c6306fad5c9796f1bb2347167","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        claim_grace \u003d data_utils.rand_int_id(start\u003d60,"},{"line_number":49,"context_line":"                                             end\u003dCONF.queuing.max_claim_grace)"},{"line_number":50,"context_line":"        claim_body \u003d {\"ttl\": claim_ttl, \"grace\": claim_grace}"},{"line_number":51,"context_line":"        resp, body \u003d self.post_claims(queue_name\u003dself.queue_name,"},{"line_number":52,"context_line":"                                      rbody\u003dclaim_body)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        claimed_message_uri \u003d body[0][\u0027href\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_8a92014a","line":51,"in_reply_to":"1ae5cdf2_44ac728c","updated":"2014-06-05 14:06:24.000000000","message":"Thanks for the review Sergey!\nw.r.t your comment, this seems to be the standard Tempest way of getting back responses, when you are using the responses for further verification. See example https://github.com/openstack/tempest/blob/master/tempest/api/compute/flavors/test_flavors.py#L44.\nI followed the same approach to keep Marconi tests consistent with other tempest tests. If you have a Tempest example from elsewhere which handles it differently, I can update these as well","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"d94090a6638c2e08218c4f692d14073022a0ec3a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        claim_ttl \u003d data_utils.rand_int_id(start\u003d60,"},{"line_number":99,"context_line":"                                           end\u003dCONF.queuing.max_claim_ttl)"},{"line_number":100,"context_line":"        update_rbody \u003d {\"ttl\": claim_ttl}"},{"line_number":101,"context_line":"        resp, body \u003d self.update_claim(claim_uri, rbody\u003dupdate_rbody)"},{"line_number":102,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        # Delete Claimed message"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_c4afa27b","line":101,"updated":"2014-06-05 13:01:08.000000000","message":"unused variable \"body\"","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"821b5de1010aed2c6306fad5c9796f1bb2347167","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        claim_ttl \u003d data_utils.rand_int_id(start\u003d60,"},{"line_number":99,"context_line":"                                           end\u003dCONF.queuing.max_claim_ttl)"},{"line_number":100,"context_line":"        update_rbody \u003d {\"ttl\": claim_ttl}"},{"line_number":101,"context_line":"        resp, body \u003d self.update_claim(claim_uri, rbody\u003dupdate_rbody)"},{"line_number":102,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        # Delete Claimed message"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_0acd1166","line":101,"in_reply_to":"1ae5cdf2_c4afa27b","updated":"2014-06-05 14:06:24.000000000","message":"Ditto","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"d94090a6638c2e08218c4f692d14073022a0ec3a","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        # Post Claim"},{"line_number":116,"context_line":"        claim_body \u003d {\"ttl\": 60, \"grace\": 60}"},{"line_number":117,"context_line":"        resp, body \u003d self.post_claims(queue_name\u003dself.queue_name,"},{"line_number":118,"context_line":"                                      rbody\u003dclaim_body)"},{"line_number":119,"context_line":"        claim_uri \u003d resp[\u0027location\u0027]"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_84075a81","line":117,"updated":"2014-06-05 13:01:08.000000000","message":"unused variable \"body\"","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"821b5de1010aed2c6306fad5c9796f1bb2347167","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        # Post Claim"},{"line_number":116,"context_line":"        claim_body \u003d {\"ttl\": 60, \"grace\": 60}"},{"line_number":117,"context_line":"        resp, body \u003d self.post_claims(queue_name\u003dself.queue_name,"},{"line_number":118,"context_line":"                                      rbody\u003dclaim_body)"},{"line_number":119,"context_line":"        claim_uri \u003d resp[\u0027location\u0027]"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_2ac80d54","line":117,"in_reply_to":"1ae5cdf2_84075a81","updated":"2014-06-05 14:06:24.000000000","message":"ditto","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"d94090a6638c2e08218c4f692d14073022a0ec3a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        claim_uri \u003d resp[\u0027location\u0027]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # Release Claim"},{"line_number":122,"context_line":"        resp, body \u003d self.release_claim(claim_uri)"},{"line_number":123,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # Delete Claimed message"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_24c84654","line":122,"updated":"2014-06-05 13:01:08.000000000","message":"unused variable body","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"821b5de1010aed2c6306fad5c9796f1bb2347167","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        claim_uri \u003d resp[\u0027location\u0027]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # Release Claim"},{"line_number":122,"context_line":"        resp, body \u003d self.release_claim(claim_uri)"},{"line_number":123,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # Delete Claimed message"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_8ae041ce","line":122,"in_reply_to":"1ae5cdf2_24c84654","updated":"2014-06-05 14:06:24.000000000","message":"ditto","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"}],"tempest/api/queuing/test_messages.py":[{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"d94090a6638c2e08218c4f692d14073022a0ec3a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        # Post Messages"},{"line_number":41,"context_line":"        message_body \u003d self.generate_message_body("},{"line_number":42,"context_line":"            repeat\u003dCONF.queuing.max_messages_per_page)"},{"line_number":43,"context_line":"        resp, body \u003d self.post_messages(queue_name\u003dself.queue_name,"},{"line_number":44,"context_line":"                                        rbody\u003dmessage_body)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_e4001e68","line":43,"updated":"2014-06-05 13:01:08.000000000","message":"unused variables","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"821b5de1010aed2c6306fad5c9796f1bb2347167","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        # Post Messages"},{"line_number":41,"context_line":"        message_body \u003d self.generate_message_body("},{"line_number":42,"context_line":"            repeat\u003dCONF.queuing.max_messages_per_page)"},{"line_number":43,"context_line":"        resp, body \u003d self.post_messages(queue_name\u003dself.queue_name,"},{"line_number":44,"context_line":"                                        rbody\u003dmessage_body)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_0a2991e5","line":43,"in_reply_to":"1ae5cdf2_e4001e68","updated":"2014-06-05 14:06:24.000000000","message":"will remove","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"e634764fc5cab0d3c465e0b1a6c27c7ed4573f11","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":47,"context_line":"    def test_list_messages(self):"},{"line_number":48,"context_line":"        # Post Messages"},{"line_number":49,"context_line":"        message_body \u003d self.generate_message_body("},{"line_number":50,"context_line":"            repeat\u003dCONF.queuing.max_messages_per_page)"},{"line_number":51,"context_line":"        resp, body \u003d self.post_messages(queue_name\u003dself.queue_name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_00a9c4de","line":48,"updated":"2014-06-03 17:01:29.000000000","message":"DRY: L48-52 seem to be repeated in each test method. Could they be factored out? Perhaps a helper method could be used, where you pass in the \"repeat\" value for the message body...","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"821b5de1010aed2c6306fad5c9796f1bb2347167","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":47,"context_line":"    def test_list_messages(self):"},{"line_number":48,"context_line":"        # Post Messages"},{"line_number":49,"context_line":"        message_body \u003d self.generate_message_body("},{"line_number":50,"context_line":"            repeat\u003dCONF.queuing.max_messages_per_page)"},{"line_number":51,"context_line":"        resp, body \u003d self.post_messages(queue_name\u003dself.queue_name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_aa7fbdde","line":48,"in_reply_to":"1ae5cdf2_00a9c4de","updated":"2014-06-05 14:06:24.000000000","message":"Done","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"},{"author":{"_account_id":8824,"name":"Sergey Murashov","email":"smurashov@mirantis.com","username":"SergeyMurashov"},"change_message_id":"d94090a6638c2e08218c4f692d14073022a0ec3a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # Post Messages"},{"line_number":49,"context_line":"        message_body \u003d self.generate_message_body("},{"line_number":50,"context_line":"            repeat\u003dCONF.queuing.max_messages_per_page)"},{"line_number":51,"context_line":"        resp, body \u003d self.post_messages(queue_name\u003dself.queue_name,"},{"line_number":52,"context_line":"                                        rbody\u003dmessage_body)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # List Messages"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_04fb4a79","line":51,"updated":"2014-06-05 13:01:08.000000000","message":"unused variables","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"821b5de1010aed2c6306fad5c9796f1bb2347167","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # Post Messages"},{"line_number":49,"context_line":"        message_body \u003d self.generate_message_body("},{"line_number":50,"context_line":"            repeat\u003dCONF.queuing.max_messages_per_page)"},{"line_number":51,"context_line":"        resp, body \u003d self.post_messages(queue_name\u003dself.queue_name,"},{"line_number":52,"context_line":"                                        rbody\u003dmessage_body)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # List Messages"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_ca8249c7","line":51,"in_reply_to":"1ae5cdf2_04fb4a79","updated":"2014-06-05 14:06:24.000000000","message":"will remove","commit_id":"997a9d4795b22484b7b24ee42f93f522a787b85f"}]}