)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"1c30658a812c4927480907aa41569c4d9e48c088","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pranav Salunke \u003cdguitarbite@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-25 09:28:19 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Minor Fixes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes minor syntax issues."},{"line_number":10,"context_line":"Renames variables to be more pythonic."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5adbc538_eec35d88","line":7,"updated":"2014-05-26 07:32:54.000000000","message":"Please pay attention to:\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"c3d5eb776874386d328019cde594bbff8b61797c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4fe9f2142d294aaa8d782e30e67dba31f67c3f29","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pranav Salunke \u003cdguitarbite@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-25 09:28:19 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Minor Fixes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes minor syntax issues."},{"line_number":10,"context_line":"Renames variables to be more pythonic."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5adbc538_a86860f6","line":7,"in_reply_to":"5adbc538_eec35d88","updated":"2014-05-26 14:25:52.000000000","message":"yep, nice point. current title does not show any meanings.","commit_id":"c3d5eb776874386d328019cde594bbff8b61797c"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"347f0c51b4d493e2cdaaf66d306b2030a77bbc69","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pranav Salunke \u003cdguitarbite@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-27 11:19:23 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Renames Variables, fixs code to follow PEP8"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Rename variables \"e\",\"s\" and give them more pythonic names like"},{"line_number":10,"context_line":"\"setup_endpoint\", \"service_id\". Carry out PEP8 fixes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ae8d1ca_086a3d1a","line":7,"updated":"2014-05-27 14:56:36.000000000","message":"renames-\u003erename; fixs-\u003efix. BTW, there is no need to write \"variables\" starting with a capital letter.","commit_id":"a8ed921f251582f157191116e8f7ec48508bc033"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"646f2cd07b524f25ed6d30cef571f9d180647f0b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2014-05-25 00:01:05 +0530"},{"line_number":4,"context_line":"Commit:     Pranav Salunke \u003cdguitarbite@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-24 02:20:31 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes Scoping bugs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes scoping bugs, removes unnecessary use of self.xx."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1ae5cdf2_a4e4ed3c","line":6,"updated":"2014-06-24 13:27:15.000000000","message":"What bug ? :) If there\u0027s a bug maybe you could send a bug report first.\n\nTo me this patch is just a welcomed cleanup, I don\u0027t see any functionnal problem. Just reword the commit message please.\n\nThe title could be, as in patchset 5 \"Rename variables, fixe code to follow PEP8\"","commit_id":"0485290c4375c5608b148dbe20f06a3a7daa8e31"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"941bdffd19b732607164677462eaea0e3e03a8e3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2014-05-25 00:01:05 +0530"},{"line_number":4,"context_line":"Commit:     Pranav Salunke \u003cdguitarbite@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-24 02:20:31 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes Scoping bugs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes scoping bugs, removes unnecessary use of self.xx."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1ae5cdf2_e4b355ea","line":6,"in_reply_to":"1ae5cdf2_a4e4ed3c","updated":"2014-06-24 13:37:31.000000000","message":"I agree the commit message needs to be more descriptive. Can you add some more detail about why you\u0027re making these changes. For smaller changes like this the why is more important than the how or what. See: \n\nhttps://wiki.openstack.org/wiki/GitCommitMessages\n\n@Jordan see the comments on the earlier revision to see why the commit messsage was changed","commit_id":"0485290c4375c5608b148dbe20f06a3a7daa8e31"}],"tempest/api/identity/admin/v3/test_endpoints.py":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"1c30658a812c4927480907aa41569c4d9e48c088","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":58,"context_line":"    def test_list_endpoints(self):"},{"line_number":59,"context_line":"        \u0027\u0027\u0027Get a list of endpoints.\u0027\u0027\u0027"},{"line_number":60,"context_line":"        resp, fetched_endpoints \u003d self.client.list_endpoints()"},{"line_number":61,"context_line":"        # Asserting LIST endpoints"},{"line_number":62,"context_line":"        self.assertEqual(resp[\u0027status\u0027], \u0027200\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5adbc538_eb6c2f39","line":59,"updated":"2014-05-26 07:32:54.000000000","message":"This line is a comment, not a doc string. So I think there is no reason to change it.","commit_id":"c3d5eb776874386d328019cde594bbff8b61797c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4fe9f2142d294aaa8d782e30e67dba31f67c3f29","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @test.attr(type\u003d\u0027gate\u0027)"},{"line_number":58,"context_line":"    def test_list_endpoints(self):"},{"line_number":59,"context_line":"        \u0027\u0027\u0027Get a list of endpoints.\u0027\u0027\u0027"},{"line_number":60,"context_line":"        resp, fetched_endpoints \u003d self.client.list_endpoints()"},{"line_number":61,"context_line":"        # Asserting LIST endpoints"},{"line_number":62,"context_line":"        self.assertEqual(resp[\u0027status\u0027], \u0027200\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5adbc538_c83bece9","line":59,"in_reply_to":"5adbc538_eb6c2f39","updated":"2014-05-26 14:25:52.000000000","message":"agree here also.\nThere is a lot of this kind of comment, and now I\u0027m not sure this change is right.","commit_id":"c3d5eb776874386d328019cde594bbff8b61797c"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"1c30658a812c4927480907aa41569c4d9e48c088","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":96,"context_line":"    def test_update_endpoint(self):"},{"line_number":97,"context_line":"        \u0027\u0027\u0027Creating an endpoint so as to check update endpoint"},{"line_number":98,"context_line":"        with new values."},{"line_number":99,"context_line":"        \u0027\u0027\u0027"},{"line_number":100,"context_line":"        region1 \u003d data_utils.rand_name(\u0027region\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5adbc538_cbd693c5","line":97,"updated":"2014-05-26 07:32:54.000000000","message":"Same as in line 59","commit_id":"c3d5eb776874386d328019cde594bbff8b61797c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9f439e64dc52bc4b68769f2ba5942bdbee38785b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        cls.identity_client \u003d cls.client"},{"line_number":29,"context_line":"        cls.client \u003d cls.endpoints_client"},{"line_number":30,"context_line":"        cls.service_ids \u003d list()"},{"line_number":31,"context_line":"        s_name \u003d data_utils.rand_name(\u0027service-\u0027)"},{"line_number":32,"context_line":"        s_type \u003d data_utils.rand_name(\u0027type--\u0027)"},{"line_number":33,"context_line":"        s_description \u003d data_utils.rand_name(\u0027description-\u0027)"},{"line_number":34,"context_line":"        resp, cls.service_data \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_ed4c63ca","line":31,"updated":"2014-06-06 08:24:35.000000000","message":"You can do it for these variable also \u0027s_name\u0027-\u003e \u0027service_name\u0027 etc. Same for s_*","commit_id":"2957c4f4f73af9ec104e47b8d67ea8cbdf41989b"},{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"087afcd011018f08976ba077bef561a7e0340cf9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        resp, cls.service_data \u003d \\"},{"line_number":35,"context_line":"            cls.service_client.create_service(service_name, service_type,"},{"line_number":36,"context_line":"                                              description\u003dservice_description)"},{"line_number":37,"context_line":"        service_id \u003d cls.service_data[\u0027id\u0027]"},{"line_number":38,"context_line":"        cls.service_ids.append(service_id)"},{"line_number":39,"context_line":"        # Create endpoints so as to use for LIST and GET test cases"},{"line_number":40,"context_line":"        cls.setup_endpoints \u003d list()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_2aef23b2","line":37,"updated":"2014-06-20 15:29:33.000000000","message":"Don\u0027t remove cls here and on lines 38 and 46. This must be a class attribute or it will be gone by the time the test methods try to use it.","commit_id":"1b03fb9db015ec1bc91b5a27eba191dcced1359e"}]}
