)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ddf3683ea59e28f344a75cb67f572b541d8a842","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding a new test for password regex for PCI DSS"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: https://review.opendev.org/c/openstack/keystone/+/961726"},{"line_number":12,"context_line":"Signed-off-by: Milana Levy \u003cmillevy@redhat.com\u003e"},{"line_number":13,"context_line":"Co-Authored-By: Douglas Mendizábal \u003cdmendiza@redhat.com\u003e"},{"line_number":14,"context_line":"Change-Id: I8559820c5f830d6dbb9fd1a986c1f568b77a46e6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"0752f3d0_c648266e","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":68},"updated":"2025-10-16 15:36:59.000000000","message":"this is incorrect, you should make this tempest change as depends-on in keystone change so that we can see the result of the new test in keystone change adding new job","commit_id":"156918212df5b3483dd4ca17791d44ce84be1958"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"19bb065a8afc0373e095a3362a73fea7643a2905","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding a new test for password regex for PCI DSS"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: https://review.opendev.org/c/openstack/keystone/+/961726"},{"line_number":12,"context_line":"Signed-off-by: Milana Levy \u003cmillevy@redhat.com\u003e"},{"line_number":13,"context_line":"Co-Authored-By: Douglas Mendizábal \u003cdmendiza@redhat.com\u003e"},{"line_number":14,"context_line":"Change-Id: I8559820c5f830d6dbb9fd1a986c1f568b77a46e6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bfbe92b2_128c2fd7","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":68},"in_reply_to":"0752f3d0_c648266e","updated":"2025-11-04 21:34:09.000000000","message":"Done","commit_id":"156918212df5b3483dd4ca17791d44ce84be1958"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"f51cc3cafbc00951cecf58468b766dfe03d8d168","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5aa74915_e5b3d609","updated":"2025-07-03 12:05:26.000000000","message":"Hi , please review the test. Thank you.","commit_id":"e52300697166bdb647b54e9f9195b45528205f7a"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"d631ba1d7a83120a15f5f574dc73da3a279793da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8d3c0cf9_3f9424a3","updated":"2025-07-03 13:50:59.000000000","message":"It seems the tempest-full-py3 is linked to this change","commit_id":"e52300697166bdb647b54e9f9195b45528205f7a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"67d8e6638001ec74eb58e81b79079fe3f3fba5db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1d817e2c_17955436","in_reply_to":"8d3c0cf9_3f9424a3","updated":"2025-07-03 17:22:41.000000000","message":"yeah, failure shows it is allowed to change password of 4 char at least (i could not find any such limitation in keystone code/doc)","commit_id":"e52300697166bdb647b54e9f9195b45528205f7a"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"9f5147206028d64029cd7d516fc5a4760adef599","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a666329f_c204209e","updated":"2025-07-14 12:52:12.000000000","message":"recheck","commit_id":"3b85f2ffa745f647eb640ad0a0b6f961bb86dfe8"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"2583d1319bea130b4a8e6e369a98de6d527e0a02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d25f4e3b_edf4311a","updated":"2025-07-13 11:37:43.000000000","message":"recheck","commit_id":"3b85f2ffa745f647eb640ad0a0b6f961bb86dfe8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d5efe62a046cc38d88840aa894df92caac453c12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"380ccae5_45a55c16","updated":"2025-10-15 18:38:21.000000000","message":"also, add releasenotes for the new config option","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"dc5ff002526ae873bfe57b71e23137f7c7e5970a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c6a5709d_ce010abb","updated":"2025-08-03 07:21:12.000000000","message":"recheck","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"cb1ddef45faffeb233b267f803d03c58ebe09f6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"205885db_ef6035d7","updated":"2025-08-01 04:20:07.000000000","message":"recheck - depends-on updated","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"5037664be6fdb55e04b13889ae3d64ef253b8826","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7b49b440_51764eb0","updated":"2025-10-16 12:52:55.000000000","message":"Zuul is still not happy, please don\u0027t increase the review priority until at least there is a positive vote from zuul","commit_id":"8edce6b96dff8a1aa4f6ad274c29731867a8d0c0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ddf3683ea59e28f344a75cb67f572b541d8a842","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"e154099e_e6ba39a4","updated":"2025-10-16 15:36:59.000000000","message":"also, please add a releasenotes for the new config. example - https://github.com/openstack/tempest/blob/master/releasenotes/notes/Add-http_qcow2_image-config-option-a9dca410897c3044.yaml","commit_id":"156918212df5b3483dd4ca17791d44ce84be1958"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"19bb065a8afc0373e095a3362a73fea7643a2905","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"3463d594_e0b03c35","updated":"2025-11-04 21:34:09.000000000","message":"still no release notes are added","commit_id":"07bcb36a890a3d1fb450e5a03bb7bd022167d371"}],"tempest/api/identity/v3/test_users.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"6741fa5b6ed2633814ed5d97423948a402d52866","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        \"\"\"Test updating password with a length less than the number of characters required.\"\"\""},{"line_number":166,"context_line":"        old_pass \u003d self.creds.password"},{"line_number":167,"context_line":"        # Generate a password that is less than the required number of characters."},{"line_number":168,"context_line":"        short_password \u003d data_utils.rand_password(length\u003d4)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Expect a BadRequest exception because the password is too short."},{"line_number":171,"context_line":"        self.assertRaises(exceptions.BadRequest,"}],"source_content_type":"text/x-python","patch_set":3,"id":"2c3a8b8a_a822c30f","line":168,"updated":"2025-07-03 12:43:58.000000000","message":"I don\u0027t know this code too much, so I need to ask: where is the \"required number of characters\"? How do we know that 4 is small enough? \nIn other words: could the cluster administrator configure the cluster to accept password of 4 characters? If that\u0027s possible, wouldn\u0027t this test fail when it should pass if executed against that cluster?","commit_id":"e52300697166bdb647b54e9f9195b45528205f7a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d5efe62a046cc38d88840aa894df92caac453c12","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        \"\"\"Test updating password with a length less than the number of characters required.\"\"\""},{"line_number":166,"context_line":"        old_pass \u003d self.creds.password"},{"line_number":167,"context_line":"        # Generate a password that is less than the required number of characters."},{"line_number":168,"context_line":"        short_password \u003d data_utils.rand_password(length\u003d4)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Expect a BadRequest exception because the password is too short."},{"line_number":171,"context_line":"        self.assertRaises(exceptions.BadRequest,"}],"source_content_type":"text/x-python","patch_set":3,"id":"b6956327_a88defe0","line":168,"in_reply_to":"26298c3a_177593c2","updated":"2025-10-15 18:38:21.000000000","message":"Done","commit_id":"e52300697166bdb647b54e9f9195b45528205f7a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b1e9a114a1d105cdba67313861c943f73e293f86","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        \"\"\"Test updating password with a length less than the number of characters required.\"\"\""},{"line_number":166,"context_line":"        old_pass \u003d self.creds.password"},{"line_number":167,"context_line":"        # Generate a password that is less than the required number of characters."},{"line_number":168,"context_line":"        short_password \u003d data_utils.rand_password(length\u003d4)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Expect a BadRequest exception because the password is too short."},{"line_number":171,"context_line":"        self.assertRaises(exceptions.BadRequest,"}],"source_content_type":"text/x-python","patch_set":3,"id":"26298c3a_177593c2","line":168,"in_reply_to":"2c3a8b8a_a822c30f","updated":"2025-07-03 17:20:07.000000000","message":"Yeah, this is what I was checking in keystone and I only found that keystone check max_password_length and when conf.strict_password_check is enabled \n\n- https://github.com/openstack/keystone/blob/4e4cd0dcdc51c531f5451361e3fe514d32e69978/keystone/conf/identity.py#L116\n\nor at backend for example in sql case:\n- https://github.com/openstack/keystone/blob/4e4cd0dcdc51c531f5451361e3fe514d32e69978/keystone/identity/backends/sql.py#L307\n\neven api-ref did not tell about this limitation\n- https://docs.openstack.org/api-ref/identity/v3/#id845","commit_id":"e52300697166bdb647b54e9f9195b45528205f7a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b1e9a114a1d105cdba67313861c943f73e293f86","unresolved":true,"context_lines":[{"line_number":168,"context_line":"        short_password \u003d data_utils.rand_password(length\u003d4)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Expect a BadRequest exception because the password is too short."},{"line_number":171,"context_line":"        self.assertRaises(exceptions.BadRequest,"},{"line_number":172,"context_line":"                          self.non_admin_users_client.update_user_password,"},{"line_number":173,"context_line":"                          self.user_id,"},{"line_number":174,"context_line":"                          password\u003dshort_password,"},{"line_number":175,"context_line":"                          original_password\u003dold_pass)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # Ensure the old password still works, and old password still works"},{"line_number":178,"context_line":"        self.non_admin_token.auth(user_id\u003dself.user_id, password\u003dold_pass)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c6efe70c_367ebb5a","line":175,"range":{"start_line":171,"start_character":0,"end_line":175,"end_character":53},"updated":"2025-07-03 17:20:07.000000000","message":"it seems like keystone allowed to change 4 char password - https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_4cf/openstack/4cfd9e55783e4e77ad842f6b946e0129/testr_results.html","commit_id":"e52300697166bdb647b54e9f9195b45528205f7a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d5efe62a046cc38d88840aa894df92caac453c12","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        short_password \u003d data_utils.rand_password(length\u003d4)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Expect a BadRequest exception because the password is too short."},{"line_number":171,"context_line":"        self.assertRaises(exceptions.BadRequest,"},{"line_number":172,"context_line":"                          self.non_admin_users_client.update_user_password,"},{"line_number":173,"context_line":"                          self.user_id,"},{"line_number":174,"context_line":"                          password\u003dshort_password,"},{"line_number":175,"context_line":"                          original_password\u003dold_pass)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # Ensure the old password still works, and old password still works"},{"line_number":178,"context_line":"        self.non_admin_token.auth(user_id\u003dself.user_id, password\u003dold_pass)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0ec502a8_e752e7a4","line":175,"range":{"start_line":171,"start_character":0,"end_line":175,"end_character":53},"in_reply_to":"c6efe70c_367ebb5a","updated":"2025-10-15 18:38:21.000000000","message":"Done","commit_id":"e52300697166bdb647b54e9f9195b45528205f7a"}],"tempest/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9693915e112c9ea67ffe5cf586f51d988bdfaa79","unresolved":true,"context_lines":[{"line_number":221,"context_line":"                    \"options \""},{"line_number":222,"context_line":"                    \"keystone.conf:security_compliance.minimum_password_age.\"),"},{"line_number":223,"context_line":"    cfg.IntOpt(\u0027user_minimum_password_length\u0027,"},{"line_number":224,"context_line":"                default\u003d7,"},{"line_number":225,"context_line":"                min\u003d2,"},{"line_number":226,"context_line":"                help\u003d\"The minimum length for a password is set\""},{"line_number":227,"context_line":"                    \"This only takes effect when\""}],"source_content_type":"text/x-python","patch_set":11,"id":"8271a028_5cb09e4d","line":224,"range":{"start_line":224,"start_character":24,"end_line":224,"end_character":25},"updated":"2025-08-19 19:25:00.000000000","message":"If this is impacting existing tests/setup then you can set it to 3 and set it to 7 in tempest job. But if 7 working fine then no issue.","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d5efe62a046cc38d88840aa894df92caac453c12","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                    \"options \""},{"line_number":222,"context_line":"                    \"keystone.conf:security_compliance.minimum_password_age.\"),"},{"line_number":223,"context_line":"    cfg.IntOpt(\u0027user_minimum_password_length\u0027,"},{"line_number":224,"context_line":"                default\u003d7,"},{"line_number":225,"context_line":"                min\u003d2,"},{"line_number":226,"context_line":"                help\u003d\"The minimum length for a password is set\""},{"line_number":227,"context_line":"                    \"This only takes effect when\""}],"source_content_type":"text/x-python","patch_set":11,"id":"80c1c7ec_bced8c27","line":224,"range":{"start_line":224,"start_character":24,"end_line":224,"end_character":25},"in_reply_to":"8271a028_5cb09e4d","updated":"2025-10-15 18:38:21.000000000","message":"Done","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"55c6a0de48bf407957325203d9892a39ef94df4a","unresolved":true,"context_lines":[{"line_number":229,"context_line":"                    \"\u0027True\u0027. set identity.user_minimum_password_length\""},{"line_number":230,"context_line":"                    \"For more details, refer to keystone config \""},{"line_number":231,"context_line":"                    \"options \""},{"line_number":232,"context_line":"                    \"keystone.conf:security_compliance.minimum_password_length.\")"},{"line_number":233,"context_line":"]"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"service_clients_group \u003d cfg.OptGroup(name\u003d\u0027service-clients\u0027,"},{"line_number":236,"context_line":"                                     title\u003d\"Service Clients Options\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"1c47671b_9dacc914","line":233,"range":{"start_line":232,"start_character":0,"end_line":233,"end_character":1},"updated":"2025-08-06 18:30:54.000000000","message":"I could not find this option in keystone, can you please point it in code where this conf is defined in keystone - https://github.com/search?q\u003drepo%3Aopenstack%2Fkeystone%20minimum_password_length\u0026type\u003dcode","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"b505f46b6709e7e29311cd8b1ab5e7fbb7c967db","unresolved":true,"context_lines":[{"line_number":229,"context_line":"                    \"\u0027True\u0027. set identity.user_minimum_password_length\""},{"line_number":230,"context_line":"                    \"For more details, refer to keystone config \""},{"line_number":231,"context_line":"                    \"options \""},{"line_number":232,"context_line":"                    \"keystone.conf:security_compliance.minimum_password_length.\")"},{"line_number":233,"context_line":"]"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"service_clients_group \u003d cfg.OptGroup(name\u003d\u0027service-clients\u0027,"},{"line_number":236,"context_line":"                                     title\u003d\"Service Clients Options\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"b8dd1d04_75f34f95","line":233,"range":{"start_line":232,"start_character":0,"end_line":233,"end_character":1},"in_reply_to":"0427100b_067dc242","updated":"2025-08-13 07:58:11.000000000","message":"Yes, the regex can also define min length like you see in the documentation.","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2fcfcc60f637750f2946bb507e5897771ffd7765","unresolved":true,"context_lines":[{"line_number":229,"context_line":"                    \"\u0027True\u0027. set identity.user_minimum_password_length\""},{"line_number":230,"context_line":"                    \"For more details, refer to keystone config \""},{"line_number":231,"context_line":"                    \"options \""},{"line_number":232,"context_line":"                    \"keystone.conf:security_compliance.minimum_password_length.\")"},{"line_number":233,"context_line":"]"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"service_clients_group \u003d cfg.OptGroup(name\u003d\u0027service-clients\u0027,"},{"line_number":236,"context_line":"                                     title\u003d\"Service Clients Options\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"0427100b_067dc242","line":233,"range":{"start_line":232,"start_character":0,"end_line":233,"end_character":1},"in_reply_to":"1c47671b_9dacc914","updated":"2025-08-06 18:33:48.000000000","message":"or you mean \u0027keystone.conf:security_compliance.password_regex\u0027 which define the password min length requirement\n\n- https://docs.openstack.org/keystone/latest/admin/configuration.html#configuring-password-strength-requirements","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d5efe62a046cc38d88840aa894df92caac453c12","unresolved":true,"context_lines":[{"line_number":229,"context_line":"                    \"\u0027True\u0027. set identity.user_minimum_password_length\""},{"line_number":230,"context_line":"                    \"For more details, refer to keystone config \""},{"line_number":231,"context_line":"                    \"options \""},{"line_number":232,"context_line":"                    \"keystone.conf:security_compliance.minimum_password_length.\")"},{"line_number":233,"context_line":"]"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"service_clients_group \u003d cfg.OptGroup(name\u003d\u0027service-clients\u0027,"},{"line_number":236,"context_line":"                                     title\u003d\"Service Clients Options\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"e58e71d3_4da733f7","line":233,"range":{"start_line":232,"start_character":0,"end_line":233,"end_character":1},"in_reply_to":"4199dab5_672e0d71","updated":"2025-10-15 18:38:21.000000000","message":"let\u0027s update the help msg also to comething like:\n\n                  help\u003d\"The minimum length for a password is set\"\n                    \"This only takes effect when\"\n                    \"identity-feature-enabled.security_compliance is set to \"\n                    \"\u0027True\u0027. The passowrd min length is defined in \"\n                    \"\u0027keystone.conf:security_compliance.password_regex\u0027. \"\n                    \"You need to set the same length of password in this \"\n                    \"tempest config option.","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a44a1f39d533e864fd2be0ae952b7cd27acf6b1f","unresolved":true,"context_lines":[{"line_number":229,"context_line":"                    \"\u0027True\u0027. set identity.user_minimum_password_length\""},{"line_number":230,"context_line":"                    \"For more details, refer to keystone config \""},{"line_number":231,"context_line":"                    \"options \""},{"line_number":232,"context_line":"                    \"keystone.conf:security_compliance.minimum_password_length.\")"},{"line_number":233,"context_line":"]"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"service_clients_group \u003d cfg.OptGroup(name\u003d\u0027service-clients\u0027,"},{"line_number":236,"context_line":"                                     title\u003d\"Service Clients Options\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"4199dab5_672e0d71","line":233,"range":{"start_line":232,"start_character":0,"end_line":233,"end_character":1},"in_reply_to":"b8dd1d04_75f34f95","updated":"2025-08-19 19:13:09.000000000","message":"perfect, idea/test lgtm. also, please add a release note about this new config.","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"bc689628bdd6b359fc37feee1a201842b22103b6","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                    \"\u0027True\u0027. set identity.user_minimum_password_length\""},{"line_number":230,"context_line":"                    \"For more details, refer to keystone config \""},{"line_number":231,"context_line":"                    \"options \""},{"line_number":232,"context_line":"                    \"keystone.conf:security_compliance.minimum_password_length.\")"},{"line_number":233,"context_line":"]"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"service_clients_group \u003d cfg.OptGroup(name\u003d\u0027service-clients\u0027,"},{"line_number":236,"context_line":"                                     title\u003d\"Service Clients Options\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"d8a7dd30_54168039","line":233,"range":{"start_line":232,"start_character":0,"end_line":233,"end_character":1},"in_reply_to":"e58e71d3_4da733f7","updated":"2025-10-16 10:39:26.000000000","message":"Done","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a44a1f39d533e864fd2be0ae952b7cd27acf6b1f","unresolved":true,"context_lines":[{"line_number":287,"context_line":"    cfg.BoolOpt(\u0027security_compliance\u0027,"},{"line_number":288,"context_line":"                default\u003dFalse,"},{"line_number":289,"context_line":"                help\u003d\u0027Does the environment have the security compliance \u0027"},{"line_number":290,"context_line":"                     \u0027settings enabled?\u0027),"},{"line_number":291,"context_line":"    cfg.BoolOpt(\u0027change_password_on_first_use\u0027,"},{"line_number":292,"context_line":"                default\u003dFalse,"},{"line_number":293,"context_line":"                help\u003d\u0027Does the environment require users to change their \u0027"},{"line_number":294,"context_line":"                     \u0027password on first login? This corresponds to \u0027"},{"line_number":295,"context_line":"                     \u0027keystone.conf:security_compliance.change_password_upon_first_use.\u0027),"},{"line_number":296,"context_line":"    cfg.BoolOpt(\u0027access_rules\u0027,"},{"line_number":297,"context_line":"                default\u003dTrue,"},{"line_number":298,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5b9150ee_ae6213f4","line":295,"range":{"start_line":290,"start_character":0,"end_line":295,"end_character":90},"updated":"2025-08-19 19:13:09.000000000","message":"this is not used? do we need this now?","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"de19d5e777bf87a68db9db6aaf65dc089c394ab7","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    cfg.BoolOpt(\u0027security_compliance\u0027,"},{"line_number":288,"context_line":"                default\u003dFalse,"},{"line_number":289,"context_line":"                help\u003d\u0027Does the environment have the security compliance \u0027"},{"line_number":290,"context_line":"                     \u0027settings enabled?\u0027),"},{"line_number":291,"context_line":"    cfg.BoolOpt(\u0027change_password_on_first_use\u0027,"},{"line_number":292,"context_line":"                default\u003dFalse,"},{"line_number":293,"context_line":"                help\u003d\u0027Does the environment require users to change their \u0027"},{"line_number":294,"context_line":"                     \u0027password on first login? This corresponds to \u0027"},{"line_number":295,"context_line":"                     \u0027keystone.conf:security_compliance.change_password_upon_first_use.\u0027),"},{"line_number":296,"context_line":"    cfg.BoolOpt(\u0027access_rules\u0027,"},{"line_number":297,"context_line":"                default\u003dTrue,"},{"line_number":298,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"72c7cde8_fa58a331","line":295,"range":{"start_line":290,"start_character":0,"end_line":295,"end_character":90},"in_reply_to":"5b9150ee_ae6213f4","updated":"2025-10-16 12:44:26.000000000","message":"It is removed now. It will be added much later, when we will write the proper test that will use it.","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"}],"zuul.d/integrated-gate.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8a9371532760f0d423a5041fa1d93c512f28d685","unresolved":true,"context_lines":[{"line_number":387,"context_line":"      enable_fips: True"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"- job:"},{"line_number":390,"context_line":"    name: tempest-keystone-security-compliance"},{"line_number":391,"context_line":"    parent: tempest-full-py3"},{"line_number":392,"context_line":"    vars:"},{"line_number":393,"context_line":"      devstack_localrc:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"463ae757_e2d55e0e","line":390,"updated":"2025-09-18 17:03:06.000000000","message":"so this shoudl now likely be replaced by the new devstack-identity-security-compliance job defined by https://review.opendev.org/c/openstack/keystone/+/961726\n\nor it shoudl inherit form it \n\nif this patch is updated to depnd on  https://review.opendev.org/c/openstack/keystone/+/961726 you can add the devstack-identity-security-compliance job to the project.yaml instead and it shoudl test the new functionaltiy","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"bc689628bdd6b359fc37feee1a201842b22103b6","unresolved":false,"context_lines":[{"line_number":387,"context_line":"      enable_fips: True"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"- job:"},{"line_number":390,"context_line":"    name: tempest-keystone-security-compliance"},{"line_number":391,"context_line":"    parent: tempest-full-py3"},{"line_number":392,"context_line":"    vars:"},{"line_number":393,"context_line":"      devstack_localrc:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"46afe300_6008ef43","line":390,"in_reply_to":"463ae757_e2d55e0e","updated":"2025-10-16 10:39:26.000000000","message":"Acknowledged","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a44a1f39d533e864fd2be0ae952b7cd27acf6b1f","unresolved":true,"context_lines":[{"line_number":386,"context_line":"      nslookup_target: \u0027opendev.org\u0027"},{"line_number":387,"context_line":"      enable_fips: True"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"- job:"},{"line_number":390,"context_line":"    name: tempest-keystone-security-compliance"},{"line_number":391,"context_line":"    parent: tempest-full-py3"},{"line_number":392,"context_line":"    vars:"},{"line_number":393,"context_line":"      devstack_localrc:"},{"line_number":394,"context_line":"        # this regex sets minimum length to 7"},{"line_number":395,"context_line":"        KEYSTONE_PASSWORD_REGEX: \"^.{7,}$\""},{"line_number":396,"context_line":"      devstack_local_conf:"},{"line_number":397,"context_line":"        test-config:"},{"line_number":398,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":399,"context_line":"            identity:"},{"line_number":400,"context_line":"              # 7 below matches the 7 used in password_regex"},{"line_number":401,"context_line":"              user_minimum_password_length: 7"},{"line_number":402,"context_line":"            identity-feature-enabled:"},{"line_number":403,"context_line":"              security_compliance: true"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"- job:"},{"line_number":406,"context_line":"    name: tempest-pg-full"},{"line_number":407,"context_line":"    parent: tempest-full-py3"},{"line_number":408,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"91842313_bd60edda","line":405,"range":{"start_line":389,"start_character":0,"end_line":405,"end_character":6},"updated":"2025-08-19 19:13:09.000000000","message":"I am not sure we need a separate job here. how about enabling it in tempest-full-py3 (L64) or in tempest-extra-tests (L40) job ?","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d5efe62a046cc38d88840aa894df92caac453c12","unresolved":true,"context_lines":[{"line_number":386,"context_line":"      nslookup_target: \u0027opendev.org\u0027"},{"line_number":387,"context_line":"      enable_fips: True"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"- job:"},{"line_number":390,"context_line":"    name: tempest-keystone-security-compliance"},{"line_number":391,"context_line":"    parent: tempest-full-py3"},{"line_number":392,"context_line":"    vars:"},{"line_number":393,"context_line":"      devstack_localrc:"},{"line_number":394,"context_line":"        # this regex sets minimum length to 7"},{"line_number":395,"context_line":"        KEYSTONE_PASSWORD_REGEX: \"^.{7,}$\""},{"line_number":396,"context_line":"      devstack_local_conf:"},{"line_number":397,"context_line":"        test-config:"},{"line_number":398,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":399,"context_line":"            identity:"},{"line_number":400,"context_line":"              # 7 below matches the 7 used in password_regex"},{"line_number":401,"context_line":"              user_minimum_password_length: 7"},{"line_number":402,"context_line":"            identity-feature-enabled:"},{"line_number":403,"context_line":"              security_compliance: true"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"- job:"},{"line_number":406,"context_line":"    name: tempest-pg-full"},{"line_number":407,"context_line":"    parent: tempest-full-py3"},{"line_number":408,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"437a854b_29c877bc","line":405,"range":{"start_line":389,"start_character":0,"end_line":405,"end_character":6},"in_reply_to":"08ddf830_854297c7","updated":"2025-10-15 18:38:21.000000000","message":"you can remove this new job from here as you are defining and running it in keystone https://review.opendev.org/c/openstack/keystone/+/961726","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"bc689628bdd6b359fc37feee1a201842b22103b6","unresolved":false,"context_lines":[{"line_number":386,"context_line":"      nslookup_target: \u0027opendev.org\u0027"},{"line_number":387,"context_line":"      enable_fips: True"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"- job:"},{"line_number":390,"context_line":"    name: tempest-keystone-security-compliance"},{"line_number":391,"context_line":"    parent: tempest-full-py3"},{"line_number":392,"context_line":"    vars:"},{"line_number":393,"context_line":"      devstack_localrc:"},{"line_number":394,"context_line":"        # this regex sets minimum length to 7"},{"line_number":395,"context_line":"        KEYSTONE_PASSWORD_REGEX: \"^.{7,}$\""},{"line_number":396,"context_line":"      devstack_local_conf:"},{"line_number":397,"context_line":"        test-config:"},{"line_number":398,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":399,"context_line":"            identity:"},{"line_number":400,"context_line":"              # 7 below matches the 7 used in password_regex"},{"line_number":401,"context_line":"              user_minimum_password_length: 7"},{"line_number":402,"context_line":"            identity-feature-enabled:"},{"line_number":403,"context_line":"              security_compliance: true"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"- job:"},{"line_number":406,"context_line":"    name: tempest-pg-full"},{"line_number":407,"context_line":"    parent: tempest-full-py3"},{"line_number":408,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"f4c5a42d_a8729e28","line":405,"range":{"start_line":389,"start_character":0,"end_line":405,"end_character":6},"in_reply_to":"437a854b_29c877bc","updated":"2025-10-16 10:39:26.000000000","message":"Done","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9f501d9c8e901e136194308f78f78b7b276995e5","unresolved":true,"context_lines":[{"line_number":386,"context_line":"      nslookup_target: \u0027opendev.org\u0027"},{"line_number":387,"context_line":"      enable_fips: True"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"- job:"},{"line_number":390,"context_line":"    name: tempest-keystone-security-compliance"},{"line_number":391,"context_line":"    parent: tempest-full-py3"},{"line_number":392,"context_line":"    vars:"},{"line_number":393,"context_line":"      devstack_localrc:"},{"line_number":394,"context_line":"        # this regex sets minimum length to 7"},{"line_number":395,"context_line":"        KEYSTONE_PASSWORD_REGEX: \"^.{7,}$\""},{"line_number":396,"context_line":"      devstack_local_conf:"},{"line_number":397,"context_line":"        test-config:"},{"line_number":398,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":399,"context_line":"            identity:"},{"line_number":400,"context_line":"              # 7 below matches the 7 used in password_regex"},{"line_number":401,"context_line":"              user_minimum_password_length: 7"},{"line_number":402,"context_line":"            identity-feature-enabled:"},{"line_number":403,"context_line":"              security_compliance: true"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"- job:"},{"line_number":406,"context_line":"    name: tempest-pg-full"},{"line_number":407,"context_line":"    parent: tempest-full-py3"},{"line_number":408,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"08ddf830_854297c7","line":405,"range":{"start_line":389,"start_character":0,"end_line":405,"end_character":6},"in_reply_to":"91842313_bd60edda","updated":"2025-08-20 00:00:13.000000000","message":"or doping it in keystone jobs can be more close place to enable it? https://review.opendev.org/c/openstack/devstack/+/957969/comment/e6e86755_41632d23/","commit_id":"4aac8207a4270313989cf462c0f421874c1830e4"}]}