)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"195433d8b594a93de420982769f15b2577b5ab6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"726f2ba2_4bf2ce06","updated":"2025-08-03 08:34:00.000000000","message":"recheck","commit_id":"d09fb7da40ee3e6a1b42a35318932c488b0dffad"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b64db801748b465035ad4f93e7b918b951625832","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b3330830_7d86d875","updated":"2025-08-04 10:02:31.000000000","message":"Thanks Yosi,\nI added a few comments, but overall it looks good.","commit_id":"6ed988490fffd53629af3dcdcccd5b8fb39bc974"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"6ed2c8201e9e9494a5154c925848f1b79c730f10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4df34d73_9d9c8393","updated":"2025-08-04 09:58:04.000000000","message":"recheck\n\nUnrelated failure in tempest","commit_id":"6ed988490fffd53629af3dcdcccd5b8fb39bc974"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"3749817855be9cbd6ccf90bde414ab22aa9cc02b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b3261d21_106e5b1b","updated":"2025-08-06 12:08:27.000000000","message":"Decided to revert the changes since it adds complexity to the code.\nCreation of a new volume-type is a simple and fast operation which does not require a lot of resources.\nMoreover, this way, the test is not dependent on a volume-type that might be missing during deployment and cause the test to fail.","commit_id":"48d7a2d8aec16a79303583daaa4941a15bd00c93"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0f7d6efe4ecb5e4df4811de950f1348c5c84a288","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6986fb0c_a5b09d8d","updated":"2025-08-07 09:56:16.000000000","message":"Thanks Yosi\nLGTM","commit_id":"48d7a2d8aec16a79303583daaa4941a15bd00c93"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"6c2a873f5c9cdd117ed4499bc1cce6a20aab245d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"46ae43c5_53a893fb","updated":"2025-08-07 07:42:46.000000000","message":"recheck\n\nUnrelated failure in image upload test","commit_id":"48d7a2d8aec16a79303583daaa4941a15bd00c93"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a8be93caa95e31124059f71c2f5224414b3ca21e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"71e8f608_5b81341a","updated":"2025-09-03 09:16:27.000000000","message":"I\u0027m unable to find the test running in the following full jobs, can you link me to the job where this is running?\n\n1. tempest-full-py3: https://f0db0d256d3d4b350b70-3f475577843c6519bda0c8c12c28da61.ssl.cf1.rackcdn.com/openstack/1d700b893a9444d597de07640cc3e98e/testr_results.html\n\n2. tempest-multinode-full-py3: https://f9f550c7212a587264cd-bda0a6518257bbde543702bfa0c7dcc6.ssl.cf1.rackcdn.com/openstack/39ec40e45f7f462bb609ffe6e8f7551a/testr_results.html\n\n3.","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"08914512191a88a15e94f54d7a16143fbc43bc71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0a7a5f29_ebd865d1","updated":"2025-09-01 07:19:25.000000000","message":"LGTM!","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"aea70808be7894bab18cafb992a367fc33e29408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"907190a1_47f40eff","updated":"2025-09-03 09:07:05.000000000","message":"The test looks good but it\u0027s fairly a basic one.\n\n1. The volumes are not attached to any server\n2. The migration policy is \u0027never\u0027 which means no migration will happen\n\nBasically we are just changing the type of a volume from multiattach to non-multiattach so I\u0027m not really sure how this test translate into validating a real deployment issue?\nAnyways, +1 for the proposed patch.","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c69a348ebf64646e9b91726fe83783472afca554","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d2692c32_d9ace57e","updated":"2025-09-03 21:15:30.000000000","message":"lgtm, just some test doc string comment otherwise lgtm","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5b841dc9cbd6ed2758e1acde300f227c941f3ac2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"83c14f8d_9220dfd6","updated":"2025-08-24 15:39:13.000000000","message":"recheck\n\nUnrelated failure","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fc4d5914037cbaea34cce9045bdd82327e227c0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a3f6abf5_4c4528f7","updated":"2025-09-03 10:02:27.000000000","message":"running in tempest-extra-tests","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fc4d5914037cbaea34cce9045bdd82327e227c0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0ada3698_f5ee29d3","in_reply_to":"6497e9d8_3fd6a8b8","updated":"2025-09-03 10:02:27.000000000","message":"hmm, that job doesn\u0027t really require running any retype tests ... but yosi pointed me to tempest-extra-tests where this is running\n\ntempest.api.volume.admin.test_volume_retype.VolumeRetypeMultiattachTest\t1\t1\t0\t0\t0\tDetail\t\ntest_volume_retype_multiattach[id-c0521465-ed82-4d03-961d-a68d673a5051]\npass","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5948705f42aebd0d82439bcbae79cc27a151172a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6497e9d8_3fd6a8b8","in_reply_to":"71e8f608_5b81341a","updated":"2025-09-03 09:27:14.000000000","message":"The test in running here:\nglance-multistore-cinder-import: https://zuul.opendev.org/t/openstack/build/cd7a2e5c7b034a56933ed64d8c64473e","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c69a348ebf64646e9b91726fe83783472afca554","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b56455e6_40d341a6","in_reply_to":"a3f6abf5_4c4528f7","updated":"2025-09-03 21:15:30.000000000","message":"yes, all admin and negative tests run in tempest-extra-tests job.\n\nTest is running successfully: \n\nhttps://zuul.opendev.org/t/openstack/build/6bf12d431bcc450c9cefa9401096920c/log/job-output.txt#24575","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4cae7d897540e06bf6f152168f9c27b7f7e2da69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3c1eb687_6b7ad933","updated":"2025-09-11 14:22:11.000000000","message":"It looks like this required a fix, currently proposed as https://review.opendev.org/c/openstack/tempest/+/960562","commit_id":"3789a11f6d0cdff3881c78af780df04bbe2156f3"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"b1de3781719f533f6427446de025144152e289dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b83c9a99_f1503c25","updated":"2025-09-08 08:45:55.000000000","message":"recheck\n\nUnrelated failure in tempest.api.compute","commit_id":"3789a11f6d0cdff3881c78af780df04bbe2156f3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"06e3f0591c5caa43b8216092434c62784224119c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"25d3af5b_d72e761c","updated":"2025-09-04 15:59:43.000000000","message":"thanks for updates.\n\nlgtm, test passing fine https://zuul.opendev.org/t/openstack/build/353d32d9d65a4a99aeaa1a7714c5df58/log/job-output.txt#24889","commit_id":"3789a11f6d0cdff3881c78af780df04bbe2156f3"}],"tempest/api/volume/admin/test_volume_retype.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b64db801748b465035ad4f93e7b918b951625832","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        self._retype_volume(src_vol, migration_policy\u003d\u0027never\u0027)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"class VolumeRetypeMultiattachTest(VolumeRetypeTest):"},{"line_number":210,"context_line":"    \"\"\"Test volume retype with/without multiattach\"\"\""},{"line_number":211,"context_line":"    @classmethod"},{"line_number":212,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"0eb6797c_5858bbe4","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":52},"updated":"2025-08-04 10:02:31.000000000","message":"According to the documentation (https://docs.openstack.org/cinder/latest/admin/volume-multiattach.html), multiattach is supported starting from microversion 3.50.\nPlease add the following configuration to enable it:\nvolume_min_microversion \u003d \u00273.50\u0027\nvolume_max_microversion \u003d \u0027latest\u0027\n\nSince this test does not involve attaching the same volume to multiple servers, it doesn’t appear necessary to specify:\ncompute_min_microversion \u003d \u00272.60\u0027\ncompute_max_microversion \u003d \u0027latest\u0027","commit_id":"6ed988490fffd53629af3dcdcccd5b8fb39bc974"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"05c20fdffe99a3929db16e71935239bb1bbc5971","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        self._retype_volume(src_vol, migration_policy\u003d\u0027never\u0027)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"class VolumeRetypeMultiattachTest(VolumeRetypeTest):"},{"line_number":210,"context_line":"    \"\"\"Test volume retype with/without multiattach\"\"\""},{"line_number":211,"context_line":"    @classmethod"},{"line_number":212,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"323d5753_3eb00118","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":52},"in_reply_to":"0eb6797c_5858bbe4","updated":"2025-08-04 11:33:16.000000000","message":"Done","commit_id":"6ed988490fffd53629af3dcdcccd5b8fb39bc974"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b64db801748b465035ad4f93e7b918b951625832","unresolved":true,"context_lines":[{"line_number":243,"context_line":"        \"\"\""},{"line_number":244,"context_line":"        # Retype from non-multiattach to multiattach"},{"line_number":245,"context_line":"        vol \u003d self.create_volume(volume_type\u003dself.src_vol_type[\u0027name\u0027])"},{"line_number":246,"context_line":"        self._retype_volume(vol, migration_policy\u003d\u0027never\u0027)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        self.dst_vol_type \u003d self.src_vol_type"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c7ea756a_d4c123e5","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":58},"updated":"2025-08-04 10:02:31.000000000","message":"I\u0027d prefer to explicitly specify the new_type parameter for better clarity and readability.","commit_id":"6ed988490fffd53629af3dcdcccd5b8fb39bc974"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"f209f8c3328dea2531a0d1136a7d1b43189ec8e7","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        \"\"\""},{"line_number":244,"context_line":"        # Retype from non-multiattach to multiattach"},{"line_number":245,"context_line":"        vol \u003d self.create_volume(volume_type\u003dself.src_vol_type[\u0027name\u0027])"},{"line_number":246,"context_line":"        self._retype_volume(vol, migration_policy\u003d\u0027never\u0027)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        self.dst_vol_type \u003d self.src_vol_type"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3596e2c5_573bac38","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":58},"in_reply_to":"aea11bc0_2b39ccf5","updated":"2025-08-14 11:20:22.000000000","message":"Done","commit_id":"6ed988490fffd53629af3dcdcccd5b8fb39bc974"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"05c20fdffe99a3929db16e71935239bb1bbc5971","unresolved":true,"context_lines":[{"line_number":243,"context_line":"        \"\"\""},{"line_number":244,"context_line":"        # Retype from non-multiattach to multiattach"},{"line_number":245,"context_line":"        vol \u003d self.create_volume(volume_type\u003dself.src_vol_type[\u0027name\u0027])"},{"line_number":246,"context_line":"        self._retype_volume(vol, migration_policy\u003d\u0027never\u0027)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        self.dst_vol_type \u003d self.src_vol_type"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"aea11bc0_2b39ccf5","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":58},"in_reply_to":"c7ea756a_d4c123e5","updated":"2025-08-04 11:33:16.000000000","message":"I\u0027m using the _retype_volume method from the parent class and didn\u0027t want to change the Convention.","commit_id":"6ed988490fffd53629af3dcdcccd5b8fb39bc974"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b64db801748b465035ad4f93e7b918b951625832","unresolved":true,"context_lines":[{"line_number":248,"context_line":"        self.dst_vol_type \u003d self.src_vol_type"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        # Retype from multiattach to non-multiattach"},{"line_number":251,"context_line":"        self._retype_volume(vol, migration_policy\u003d\u0027never\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"696afafa_f114c2ae","line":251,"range":{"start_line":251,"start_character":33,"end_line":251,"end_character":56},"updated":"2025-08-04 10:02:31.000000000","message":"I\u0027m not sure which policy is preferred \"on-demand\" or \"never\" or if it even matters in this case.","commit_id":"6ed988490fffd53629af3dcdcccd5b8fb39bc974"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b64db801748b465035ad4f93e7b918b951625832","unresolved":true,"context_lines":[{"line_number":248,"context_line":"        self.dst_vol_type \u003d self.src_vol_type"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        # Retype from multiattach to non-multiattach"},{"line_number":251,"context_line":"        self._retype_volume(vol, migration_policy\u003d\u0027never\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a3b59414_37084697","line":251,"range":{"start_line":251,"start_character":8,"end_line":251,"end_character":58},"updated":"2025-08-04 10:02:31.000000000","message":"Same","commit_id":"6ed988490fffd53629af3dcdcccd5b8fb39bc974"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"f209f8c3328dea2531a0d1136a7d1b43189ec8e7","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        self.dst_vol_type \u003d self.src_vol_type"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        # Retype from multiattach to non-multiattach"},{"line_number":251,"context_line":"        self._retype_volume(vol, migration_policy\u003d\u0027never\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"679133ca_d13a323a","line":251,"range":{"start_line":251,"start_character":33,"end_line":251,"end_character":56},"in_reply_to":"669fab05_c89f1be1","updated":"2025-08-14 11:20:22.000000000","message":"Done","commit_id":"6ed988490fffd53629af3dcdcccd5b8fb39bc974"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"05c20fdffe99a3929db16e71935239bb1bbc5971","unresolved":true,"context_lines":[{"line_number":248,"context_line":"        self.dst_vol_type \u003d self.src_vol_type"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        # Retype from multiattach to non-multiattach"},{"line_number":251,"context_line":"        self._retype_volume(vol, migration_policy\u003d\u0027never\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"669fab05_c89f1be1","line":251,"range":{"start_line":251,"start_character":33,"end_line":251,"end_character":56},"in_reply_to":"696afafa_f114c2ae","updated":"2025-08-04 11:33:16.000000000","message":"The \"migration_policy\" could be either \"never\" or \"on-demand\".\nWhen passing \"on-demand\", it means that the volume will be migrated on retype, which is already tested in the other tests.","commit_id":"6ed988490fffd53629af3dcdcccd5b8fb39bc974"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"05c20fdffe99a3929db16e71935239bb1bbc5971","unresolved":true,"context_lines":[{"line_number":248,"context_line":"        self.dst_vol_type \u003d self.src_vol_type"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        # Retype from multiattach to non-multiattach"},{"line_number":251,"context_line":"        self._retype_volume(vol, migration_policy\u003d\u0027never\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c3ed665f_80b895be","line":251,"range":{"start_line":251,"start_character":8,"end_line":251,"end_character":58},"in_reply_to":"a3b59414_37084697","updated":"2025-08-04 11:33:16.000000000","message":"same ^","commit_id":"6ed988490fffd53629af3dcdcccd5b8fb39bc974"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"f209f8c3328dea2531a0d1136a7d1b43189ec8e7","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        self.dst_vol_type \u003d self.src_vol_type"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        # Retype from multiattach to non-multiattach"},{"line_number":251,"context_line":"        self._retype_volume(vol, migration_policy\u003d\u0027never\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8b88c64c_2dd09e5c","line":251,"range":{"start_line":251,"start_character":8,"end_line":251,"end_character":58},"in_reply_to":"c3ed665f_80b895be","updated":"2025-08-14 11:20:22.000000000","message":"Done","commit_id":"6ed988490fffd53629af3dcdcccd5b8fb39bc974"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"75f4b3e65d3c552e50bbd3032bc0c2cb54d88d2d","unresolved":true,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        extra_specs_src \u003d {\"multiattach\": \u0027\u003cis\u003e True\u0027}"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        cls.src_vol_type \u003d cls.create_volume_type()"},{"line_number":229,"context_line":"        cls.dst_vol_type \u003d cls.create_volume_type(extra_specs\u003dextra_specs_src)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def _verify_migration(self, source_vol, dest_vol):"}],"source_content_type":"text/x-python","patch_set":3,"id":"36716893_8ebe4084","line":228,"updated":"2025-08-04 12:02:49.000000000","message":"Shouldn\u0027t you use CONF.volume.volume_type_multiattach without creating a new one?","commit_id":"a798e90580a8a35cb3f3c750e640a0046c34990a"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"1180e5fc512f24b826c5bc0b4189ab54378f161f","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        extra_specs_src \u003d {\"multiattach\": \u0027\u003cis\u003e True\u0027}"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        cls.src_vol_type \u003d cls.create_volume_type()"},{"line_number":229,"context_line":"        cls.dst_vol_type \u003d cls.create_volume_type(extra_specs\u003dextra_specs_src)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def _verify_migration(self, source_vol, dest_vol):"}],"source_content_type":"text/x-python","patch_set":3,"id":"a4a76569_0f36a591","line":228,"in_reply_to":"36716893_8ebe4084","updated":"2025-08-04 13:25:39.000000000","message":"Done","commit_id":"a798e90580a8a35cb3f3c750e640a0046c34990a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b1aec47392b82c3a4f956dac8e6b9e55a615afc1","unresolved":true,"context_lines":[{"line_number":215,"context_line":"    @classmethod"},{"line_number":216,"context_line":"    def skip_checks(cls):"},{"line_number":217,"context_line":"        super(VolumeRetypeMultiattachTest, cls).skip_checks()"},{"line_number":218,"context_line":"        if not CONF.compute_feature_enabled.volume_multiattach:"},{"line_number":219,"context_line":"            raise cls.skipException(\u0027Volume multi-attach is not available.\u0027)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"e6a548bc_62291384","line":218,"range":{"start_line":218,"start_character":15,"end_line":218,"end_character":62},"updated":"2025-08-14 13:40:10.000000000","message":"I think this check is not needed since this test doesn\u0027t actually attach the volume.","commit_id":"48d7a2d8aec16a79303583daaa4941a15bd00c93"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"3e13373fd9b5a8e7a46e5c830f4ea95e8d3967be","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    @classmethod"},{"line_number":216,"context_line":"    def skip_checks(cls):"},{"line_number":217,"context_line":"        super(VolumeRetypeMultiattachTest, cls).skip_checks()"},{"line_number":218,"context_line":"        if not CONF.compute_feature_enabled.volume_multiattach:"},{"line_number":219,"context_line":"            raise cls.skipException(\u0027Volume multi-attach is not available.\u0027)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"5587260b_56caad8a","line":218,"range":{"start_line":218,"start_character":15,"end_line":218,"end_character":62},"in_reply_to":"e6a548bc_62291384","updated":"2025-08-14 18:40:38.000000000","message":"Done","commit_id":"48d7a2d8aec16a79303583daaa4941a15bd00c93"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c69a348ebf64646e9b91726fe83783472afca554","unresolved":true,"context_lines":[{"line_number":231,"context_line":"    def test_volume_retype_multiattach(self):"},{"line_number":232,"context_line":"        \"\"\"Test volume retype with/without multiattach"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        1. Create volume_type_1 with \"multiattach \u003d \u0027\u003cis\u003e True\u0027\""},{"line_number":235,"context_line":"        2. Create volume_type_2 without the \"multiattach\" property"},{"line_number":236,"context_line":"        3. Retype volume from volume_type_1 to volume_type_2 and vice versa"},{"line_number":237,"context_line":"        4. Verify successful retype."}],"source_content_type":"text/x-python","patch_set":7,"id":"609c0593_cc009b83","line":234,"range":{"start_line":234,"start_character":18,"end_line":234,"end_character":32},"updated":"2025-09-03 21:15:30.000000000","message":"I was searching where you created volume_type_1 but i think you mean dst_vol_type  as this is volume type you are creating with multiattach","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"06ce61939ca2848cb0250d418c51e2996b81f0f8","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    def test_volume_retype_multiattach(self):"},{"line_number":232,"context_line":"        \"\"\"Test volume retype with/without multiattach"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        1. Create volume_type_1 with \"multiattach \u003d \u0027\u003cis\u003e True\u0027\""},{"line_number":235,"context_line":"        2. Create volume_type_2 without the \"multiattach\" property"},{"line_number":236,"context_line":"        3. Retype volume from volume_type_1 to volume_type_2 and vice versa"},{"line_number":237,"context_line":"        4. Verify successful retype."}],"source_content_type":"text/x-python","patch_set":7,"id":"31221954_d2004962","line":234,"range":{"start_line":234,"start_character":18,"end_line":234,"end_character":32},"in_reply_to":"609c0593_cc009b83","updated":"2025-09-04 06:22:01.000000000","message":"Done","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c69a348ebf64646e9b91726fe83783472afca554","unresolved":true,"context_lines":[{"line_number":232,"context_line":"        \"\"\"Test volume retype with/without multiattach"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        1. Create volume_type_1 with \"multiattach \u003d \u0027\u003cis\u003e True\u0027\""},{"line_number":235,"context_line":"        2. Create volume_type_2 without the \"multiattach\" property"},{"line_number":236,"context_line":"        3. Retype volume from volume_type_1 to volume_type_2 and vice versa"},{"line_number":237,"context_line":"        4. Verify successful retype."},{"line_number":238,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"edc94f78_28d5cd46","line":235,"range":{"start_line":235,"start_character":18,"end_line":235,"end_character":32},"updated":"2025-09-03 21:15:30.000000000","message":"src_vol_type","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"06ce61939ca2848cb0250d418c51e2996b81f0f8","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        \"\"\"Test volume retype with/without multiattach"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        1. Create volume_type_1 with \"multiattach \u003d \u0027\u003cis\u003e True\u0027\""},{"line_number":235,"context_line":"        2. Create volume_type_2 without the \"multiattach\" property"},{"line_number":236,"context_line":"        3. Retype volume from volume_type_1 to volume_type_2 and vice versa"},{"line_number":237,"context_line":"        4. Verify successful retype."},{"line_number":238,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"648a1281_faf43f75","line":235,"range":{"start_line":235,"start_character":18,"end_line":235,"end_character":32},"in_reply_to":"edc94f78_28d5cd46","updated":"2025-09-04 06:22:01.000000000","message":"Done","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c69a348ebf64646e9b91726fe83783472afca554","unresolved":true,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        1. Create volume_type_1 with \"multiattach \u003d \u0027\u003cis\u003e True\u0027\""},{"line_number":235,"context_line":"        2. Create volume_type_2 without the \"multiattach\" property"},{"line_number":236,"context_line":"        3. Retype volume from volume_type_1 to volume_type_2 and vice versa"},{"line_number":237,"context_line":"        4. Verify successful retype."},{"line_number":238,"context_line":"        \"\"\""},{"line_number":239,"context_line":"        # Retype from non-multiattach to multiattach"}],"source_content_type":"text/x-python","patch_set":7,"id":"2c2515dc_28156c11","line":236,"range":{"start_line":236,"start_character":30,"end_line":236,"end_character":44},"updated":"2025-09-03 21:15:30.000000000","message":"src_vol_type (non-multiattach) to dst_vol_type(multiattach)","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"06ce61939ca2848cb0250d418c51e2996b81f0f8","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        1. Create volume_type_1 with \"multiattach \u003d \u0027\u003cis\u003e True\u0027\""},{"line_number":235,"context_line":"        2. Create volume_type_2 without the \"multiattach\" property"},{"line_number":236,"context_line":"        3. Retype volume from volume_type_1 to volume_type_2 and vice versa"},{"line_number":237,"context_line":"        4. Verify successful retype."},{"line_number":238,"context_line":"        \"\"\""},{"line_number":239,"context_line":"        # Retype from non-multiattach to multiattach"}],"source_content_type":"text/x-python","patch_set":7,"id":"eb98e8c5_56d46b5e","line":236,"range":{"start_line":236,"start_character":30,"end_line":236,"end_character":44},"in_reply_to":"2c2515dc_28156c11","updated":"2025-09-04 06:22:01.000000000","message":"Done","commit_id":"aa639502977976b19aef35d1bfba3e5dfa1124da"}]}